[edk2] [Patch] BaseTools: report build time measured by module of EDKII Build

In the build report, we add AutoGen Phase, Make Phase and GenFds Phase time duration in the Platform Summary section, and we also add a item in Module section to display module and library's build time. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [PATCH 4/6] MdeModulePkg/DxeNetLib: Fix negative value left shift

Reviewed-by: Wu Jiaxin > -Original Message- > From: Wu, Hao A > Sent: Tuesday, September 19, 2017 7:44 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Shi, Steven ; > Fu, Siyuan ; Ye, Ting

Re: [edk2] [PATCH] ShellPkg/dmpstore: Show name of known variable vendor GUID

"Variable %H%s%N '%H%g%N:%H%s%N' DataSize = 0x%02x\r\n" "Variable %H%s%N '%H%s%N:%H%s%N' DataSize = 0x%02x\r\n" HEADER_LINE dumps the GUID in hex format, using %g. HEADER_LINE2 dumps the GUID name, using %s. Thanks/Ray > -Original Message- > From: Carsey, Jaben > Sent:

[edk2] [PATCH v2 5/6] IntelFrameworkModulePkg/Csm: Add code to bypass NULL pointer detection

Legacy has to access interrupt vector, BDA, etc. located in memory between 0-4095. To allow as much code as possible to be monitered by NULL pointer detection, we add code to temporarily disable this feature right before those memory access and enable it again afterwards. Cc: Star Zeng

[edk2] [PATCH v2 6/6] OvmfPkg/QemuVideoDxe: Bypass NULL pointer detection during VBE SHIM installing

QemuVideoDxe driver will install VBE SHIM into page 0. If NULL pointer detection is enabled, this driver will fail to load. NULL pointer detection bypassing code is added to prevent such problem during boot. Please note that Windows 7 will try to access VBE SHIM during boot if it's installed, and

[edk2] [PATCH v2 4/6] MdeModulePkg/Core/Dxe: Add EndOfDxe workaround for NULL pointer detection

One of issue caused by enabling NULL pointer detection is that some PCI device OptionROM, binary drivers and binary OS boot loaders may have NULL pointer access bugs, which will prevent BIOS from booting and is almost impossible to fix. BIT7 of PCD PcdNullPointerDetectionPropertyMask is used as a

[edk2] [PATCH v2 2/6] MdeModulePkg/DxeIpl: Implement NULL pointer detection

NULL pointer detection is done by making use of paging mechanism of CPU. During page table setup, if enabled, the first 4-K page (0-4095) will be marked as NOT PRESENT. Any code which unintentionally access memory between 0-4095 will trigger a Page Fault exception which warns users that there's

[edk2] [PATCH v2 3/6] UefiCpuPkg/PiSmmCpuDxeSmm: Implement NULL pointer detection for SMM code

The mechanism behind is the same as NULL pointer detection enabled in EDK-II core. SMM has its own page table and we have to disable page 0 again in SMM mode. Cc: Star Zeng Cc: Eric Dong Cc: Laszlo Ersek Cc: Jiewen Yao

[edk2] [PATCH v2 0/6] Add NULL pointer detection feature

The mechanism behind is to trigger a page fault exception at address 0. This can be made by disabling page 0 (0-4095) during page table setup. So this feature can only be available on platform with paging enabled. Once this feature is enabled, any code, like CSM, which has to access memory in

[edk2] [PATCH v2 1/6] MdeModulePkg/MdeModulePkg.dec: Add NULL pointer detection PCD

From: "Wang, Jian J" PCD PcdNullPointerDetectionPropertyMask is a bitmask used to control the NULL address detection functionality in code for different phases. If enabled, accessing NULL address in UEFI or SMM code can be caught as a page fault exception. BIT0-

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017 2/2] Update Minor Version of BIOS ID.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: zwei4 --- Platform/BroxtonPlatformPkg/BiosId.env | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/BroxtonPlatformPkg/BiosId.env b/Platform/BroxtonPlatformPkg/BiosId.env index

Re: [edk2] [PATCH v3] CryptoPkg: Add new API to retrieve commonName of X.509 certificate

Hi Qin, I think we might add OPTIONAL attribute to CommonName, as NULL is an valid input for this API. In function description, I think we need update below statement to "if *** and *CommonNameSize is 0." "If CommonName is not NULL and CommonNameSize is 0." Others are good to me.

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Calibrate PMIC IMON.

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: zwei4 --- .../PlatformPostMemPei/PlatformInit.c | 49 ++ .../PlatformSettings/PlatformSetupDxe/UnCore.vfi | 6 +-- .../BroxtonSiPkg/NorthCluster/Include/SaRegs.h |

Re: [edk2] [PATCH 3/6] MdeModulePkg/Tpl: Fix negative value left shift

Star and Paolo, Thanks for the feedbacks. I will refine the patch according to your suggestions. Best Regards, Hao Wu > -Original Message- > From: Zeng, Star > Sent: Thursday, September 21, 2017 10:57 AM > To: Paolo Bonzini; Wu, Hao A; edk2-devel@lists.01.org > Cc: Dong, Eric; Zeng,

Re: [edk2] NVME DXE Driver and PATA SS

Hi, Could you help to provide more information on the firmware which you are using? Is it built by yourself or provided by vender? As far as I know, the edk2 NVME driver only manages the devices, it will not create boot options for them. It's for the BDS-related modules to create boot options

Re: [edk2] [PATCH 3/6] MdeModulePkg/Tpl: Fix negative value left shift

There is a case must be considered that gEventPending is 0, HighBitSet64 will return -1, then the code will be wrong. The code maybe: while (gEventPending != 0) { PendingTpl = (UINTN) HighBitSet64 (gEventPending); if (NewTpl >= PendingTpl) { break; } gEfiCurrentTpl =

[edk2] [PATCH v3] CryptoPkg: Add new API to retrieve commonName of X.509 certificate

v3: Add extra CommonNameSize check since OpenSSL didn't check this input parameter. (One openssl issue was filed to address this risk: https://github.com/openssl/openssl/issues/4392) v2: Update function interface to return RETURN_STATUS to represent different error cases. Add one new

Re: [edk2] [PATCH] MdePkg: add ARM/AARCH64 support to BaseCacheMaintenanceLib

Leif: I see current ArmLib in ArmPkg. It is not clean enough. ArmLib.h still includes Chipset/ArmV7 header. Its function has no function header. When you work the patch to move them to BaseLib, please make sure they align to BaseLib style. Thanks Liming > -Original Message- > From:

Re: [edk2] [PATCH 0/2] Use PCD for Watchdog count

Hi Leif, I tested it on Juno R2. I see a one EFI SBSA watchdog test failure but I see the same failure without the patches so it's not a patch issue. It looks good for me. Thanks, Daniil -Original Message- From: Leif Lindholm [mailto:leif.lindh...@linaro.org] Sent: Wednesday,

Re: [edk2] [PATCH 5/6] MdeModulePkg/Crc32: Fix possible out of range left shift

> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Wednesday, September 20, 2017 1:06 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Dong, Eric; Zeng, Star > Subject: Re: [edk2] [PATCH 5/6] MdeModulePkg/Crc32: Fix possible

Re: [edk2] [RFC 1/6] ConfigPkg: add new package for holding common config fragments

On 20 September 2017 at 10:27, Leif Lindholm wrote: > Start with common networking options. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Leif Lindholm > --- > ConfigPkg/Network/Network.dsc.inc | 92 >

Re: [edk2] [PATCH 2/2] MdeModulePkg/Core: Fix out-of-sync issue in GCD

Sure. I'll submit a new patch after enough validation. Thanks for the review. -Original Message- From: Zeng, Star Sent: Wednesday, September 20, 2017 5:30 PM To: Wang, Jian J ; edk2-devel@lists.01.org Cc: Kinney, Michael D ; Laszlo Ersek

Re: [edk2] [PATCH v1] MdePkg: Add definitions for the SPI protocols introduced in UEFI PI 1.6.

Hey Vincent, Thank you for your response! It would be very kind of you if you would post an update to edk2-devel and CC me once you get a response from the Forum! In case you know somebody working on the MM part of the specification, could you please forward the following? There is a potential

Re: [edk2] [RFC 0/6] Create central repository for boilerplate configuration

On Wed, Sep 20, 2017 at 08:14:59PM +0200, Laszlo Ersek wrote: > On 09/20/17 19:27, Leif Lindholm wrote: > > An awful lot of platform configuration is just repeated verbatim for > > every platform. This is my first stab at eliminating some of this > > redundancy. > > > > I have additional bits as

Re: [edk2] [PATCH v1] MdePkg: Add definitions for the SPI protocols introduced in UEFI PI 1.6.

Marvin: Thanks for all of the feedback on the SPI items from the most recent UEFI PI spec. We're updating the PI spec now responsive to your findings and these corrections will be reflected in an upcoming errata. Sorry for the delayed response to you on the findings. I'll follow up w/ UEFI

[edk2] [Patch v2 3/3] ArmPkg/Include: Add ArmSvcLib header file.

ArmSvcLib header file to specify the SVC arguments structure and function prototype to trigger an SVC call. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Achin Gupta Signed-off-by: Supreeth Venkatesh ---

[edk2] [Patch v2 2/3] ArmPkg: Modify description file to build ArmSvcLib.

Add ArmPkg/Library/ArmSvcLib/ArmSvcLib.inf to [Components.common] section of ArmPkg.dsc file to build it as part of Arm package. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Achin Gupta Signed-off-by: Supreeth Venkatesh

[edk2] [Patch v2 1/3] ArmPkg/ArmSvcLib: Add ArmSvcLib implementation.

This patch adds a library that enables invocation of SVCs from Exception Level EL0. It will be used by the Standalone MM environment to request services from a software running in a privileged EL e.g. ARM Trusted Firmware. The library is derived directly from Arm SMC Library. Contributed-under:

[edk2] [Patch v2 0/3] *** Add ArmSvc Library ***

*** This patchset adds a library that enables invocation of SVCs from Exception Level EL0. It will be used by the Standalone MM environment to request services from a software running in a privileged EL e.g. ARM Trusted Firmware. The library is derived directly from Arm SMC Library. Further, it

Re: [edk2] [PATCH v3 0/2] UDF partition driver fix

On September 20, 2017 4:25:10 PM GMT-03:00, Laszlo Ersek wrote: >On 09/20/17 20:16, Paulo Alcantara wrote: > >> Please, test building these changes in toolchains other than GCC and >> make sure they don't break the world :-) > >> Repo: https://github.com/pcacjr/edk2.git >>

Re: [edk2] [PATCH v3 0/2] UDF partition driver fix

On 09/20/17 20:16, Paulo Alcantara wrote: > Please, test building these changes in toolchains other than GCC and > make sure they don't break the world :-) > Repo: https://github.com/pcacjr/edk2.git > Branch: udf-partition-fix-v3 I build-tested your branch with OVMF (both IA32 and X64),

Re: [edk2] [PATCH 0/3] OvmfPkg/QemuVideoDxe/VbeShim: handle PAM1 register on Q35 correctly

On 09/20/17 20:11, Jordan Justen wrote: > Series Reviewed-by: Jordan Justen Much appreciated! :) Aleksei, thank you for the LaunchPad bug report (complete with bisection) and the testing. Pushed: b68c793144e8..947f3737abf6. Cheers, Laszlo > On 2017-09-19 12:18:12,

[edk2] [PATCH v3 1/2] MdePkg: Add UDF volume structure definitions

This patch adds a few more UDF volume structures in order to detect an UDF file system which is supported by current EDK2 UDF file system implementation in Partition driver. Cc: Michael D Kinney Cc: Liming Gao Cc: Laszlo Ersek

[edk2] [PATCH v3 2/2] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition

Do not reserve entire block device size for an UDF file system - instead, reserve the appropriate space (UDF logical volume space) for it. Additionally, only create a logical partition for UDF logical volumes that are currently supported by EDK2 UDF file system implementation. For instance, an

[edk2] [PATCH v3 0/2] UDF partition driver fix

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=707 Hi, This patchset fixes a bug in Partition driver that created UDF logical partitions by using entire block device space and thus polluting protocol database with broken handles. v1->v2: - Followed Laszlo's suggestions to submit a proper

Re: [edk2] [RFC 0/6] Create central repository for boilerplate configuration

On 09/20/17 19:27, Leif Lindholm wrote: > An awful lot of platform configuration is just repeated verbatim for > every platform. This is my first stab at eliminating some of this > redundancy. > > I have additional bits as work in progress, but before I sink too much > time into it, I would like

Re: [edk2] [PATCH 0/3] OvmfPkg/QemuVideoDxe/VbeShim: handle PAM1 register on Q35 correctly

Series Reviewed-by: Jordan Justen On 2017-09-19 12:18:12, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: vbe_shim_q35_pam > > Fix the long-standing OVMF/Q35 bug recently exposed by a QEMU change, > and reported under

Re: [edk2] Storing Non volatile variables on SD/NAND

> On Sep 20, 2017, at 10:39 AM, Ard Biesheuvel > wrote: > > On 20 September 2017 at 10:39, Ard Biesheuvel > wrote: >> On 20 September 2017 at 10:34, Udit Kumar wrote: >>> >>> When we want to have UEFI and OS

Re: [edk2] Storing Non volatile variables on SD/NAND

On 20 September 2017 at 10:39, Ard Biesheuvel wrote: > On 20 September 2017 at 10:34, Udit Kumar wrote: >> >> When we want to have UEFI and OS accessing same media , >> Possibilities I see >> >> 1- Patch OS For status check of media (diversion from

Re: [edk2] Storing Non volatile variables on SD/NAND

On 20 September 2017 at 10:34, Udit Kumar wrote: > > When we want to have UEFI and OS accessing same media , > Possibilities I see > > 1- Patch OS For status check of media (diversion from generic OS), Good case > will be modify low level driver. > But we may end up some

Re: [edk2] Storing Non volatile variables on SD/NAND

Pankaj, We understand the use cases. We just don't have a good solution for the spec that is OS, Firmware, and hardware agnostic. Thanks, Andrew Fish > On Sep 20, 2017, at 7:51 AM, Pankaj Bansal wrote: > > This use case also arises for single-board systems like

Re: [edk2] Storing Non volatile variables on SD/NAND

When we want to have UEFI and OS accessing same media , Possibilities I see 1- Patch OS For status check of media (diversion from generic OS), Good case will be modify low level driver. But we may end up some surprises on synchronization. 2- no runtime service for OS . I guess this will

Re: [edk2] [PATCH] MdePkg: add ARM/AARCH64 support to BaseCacheMaintenanceLib

Leif, Adding the ARM specific functions to the BaseLib to provide access to ARM specific CPU registers/instructions makes sense and is what has already been done for IA32/X64/IPF/EBC. Put the arch specific content in BaseLib.h inside #if clauses. #if defined (MDE_CPU_ARM) #if defined

[edk2] [RFC 5/6] ArmVirtPkg: use ConfigPkg for common security items

Remove boilerplate from the QEMU platforms by including ConfigPkg/Security/Security.{dsc|fdf}.inc. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm --- ArmVirtPkg/ArmVirt.dsc.inc | 19 +++

[edk2] [RFC 6/6] OvmfPkg: use ConfigPkg for common security items

Remove boilerplate from the Ovmf platforms by including ConfigPkg/Security/Security.{dsc|fdf}.inc. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm --- OvmfPkg/OvmfPkgIa32.dsc| 25 -

[edk2] [RFC 0/6] Create central repository for boilerplate configuration

An awful lot of platform configuration is just repeated verbatim for every platform. This is my first stab at eliminating some of this redundancy. I have additional bits as work in progress, but before I sink too much time into it, I would like to try to gather feedback on this approach (all the

[edk2] [RFC 3/6] OvmfPkg: use ConfigPkg for common network items

Remove boilerplate from the Ovmf platforms by including ConfigPkg/Network/Network.{dsc|fdf}.inc. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm --- OvmfPkg/OvmfPkgIa32.dsc| 67 +-

[edk2] [RFC 4/6] ConfigPkg: add common Security settings

Collate universal Secure Boot and crypto settings under Security/. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm --- ConfigPkg/Security/Security.dsc.inc | 67 +

[edk2] [RFC 1/6] ConfigPkg: add new package for holding common config fragments

Start with common networking options. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm --- ConfigPkg/Network/Network.dsc.inc | 92 +++ ConfigPkg/Network/Network.fdf.inc | 47 2

[edk2] [RFC 2/6] ArmVirtPkg: use ConfigPkg for common network items

Remove boilerplate from the QEMU platforms by including ConfigPkg/Network/Network.{dsc|fdf}.inc. As a side effect, this enables support for building in IPv6 support, by specifying -D CONFIG_NETWORK_IP6_ENABLE=TRUE. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif

Re: [edk2] [PATCH v2] CryptoPkg: Add new API to retrieve commonName of X.509 certificate

On 09/20/17 19:04, Long, Qin wrote: > > > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, September 21, 2017 12:38 AM > To: Long, Qin ; Ye, Ting ; Zhang, Chao > B > Cc: edk2-devel@lists.01.org > Subject: Re: [PATCH

Re: [edk2] [PATCH v2] CryptoPkg: Add new API to retrieve commonName of X.509 certificate

From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, September 21, 2017 12:38 AM To: Long, Qin ; Ye, Ting ; Zhang, Chao B Cc: edk2-devel@lists.01.org Subject: Re: [PATCH v2] CryptoPkg: Add new API to retrieve commonName of

Re: [edk2] [PATCH v2] CryptoPkg: Add new API to retrieve commonName of X.509 certificate

Hello Qin, On 09/20/17 18:05, Qin Long wrote: > v2: Update function interface to return RETURN_STATUS to represent > different error cases. > > Add one new API (X509GetCommonName()) to retrieve the subject commonName > string from one X.509 certificate. > > Cc: Laszlo Ersek

[edk2] NVME DXE Driver and PATA SS

Hi, Is the PATA SS message that comes up in the bios boot menu when you insert the NVME Express DXE driver from Edk2 into one's firmware by design or a side-effect of the system not identifying the new device correctly? Thank you ___ edk2-devel mailing

Re: [edk2] [PATCH 0/2] Use PCD for Watchdog count

Arvind, Daniil, Thomas - any comments? I have no objections to this changeset. / Leif On Mon, Sep 18, 2017 at 03:53:42PM +0100, evan.ll...@arm.com wrote: > From: EvanLloyd > > Paired patches for edk2 and edk2-platforms that add and use a PCD > indicating the number of

[edk2] [PATCH v2] CryptoPkg: Add new API to retrieve commonName of X.509 certificate

v2: Update function interface to return RETURN_STATUS to represent different error cases. Add one new API (X509GetCommonName()) to retrieve the subject commonName string from one X.509 certificate. Cc: Laszlo Ersek Cc: Ting Ye Cc: Chao Zhang

Re: [edk2] [PATCH 1/1] ArmPkg/ArmSvcLib: Add ArmSvcLib implementation.

On Tue, 2017-09-19 at 13:14 -0700, Ard Biesheuvel wrote: > Hi Supreeth, > > On 19 September 2017 at 12:55, Supreeth Venkatesh > wrote: > > > > This patch adds a library that enables invocation of SVCs from > > Exception > > Level EL0. It will be used by the

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Calibrate PMIC IMON.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: zwei4 --- .../PlatformPostMemPei/PlatformInit.c | 76 ++ .../PlatformSettings/PlatformSetupDxe/UnCore.vfi | 6 +- .../BroxtonSiPkg/NorthCluster/Include/SaRegs.h |

Re: [edk2] [PATCH] MdePkg: add ARM/AARCH64 support to BaseCacheMaintenanceLib

Hi Liming, I understand the purity argument, but the situation (without this patch) is that: 1) There is a non-functional BaseCacheMaintenanceLib ARM/AARCH64 implementation with misleading information in MdePkg. 2) ARM/AARCH64-based needs to include a different cache maintenance library

Re: [edk2] [PATCH v2] PeiLib : Inform UEFI memory to Linux

To reserve the memory resource in boot phase and open them for OS phase, after create system resource hob, we can create memory allocation hob to take some range in PEI phase. Then, these ranges will not be allocated in DXE phase, but they will still be reported in UEFI memory map. So, for this

Re: [edk2] Storing Non volatile variables on SD/NAND

This use case also arises for single-board systems like raspberry-pi, which do not have an onboard flash. The boot firmware/bootloader as well as operating system are loaded from SD card. https://www.raspberrypi.org/documentation/configuration/config-txt/ Thanks & Regards, Pankaj Bansal

Re: [edk2] [PATCH] MdePkg: add ARM/AARCH64 support to BaseCacheMaintenanceLib

Leif: This change lets MdePkg BaseCacheMaintenanceLib depend on ArmPkg ArmLib. But, MdePkg is the basic package. It should not depend on other package. I suggest to add this ARM specific BaseCacheMaintenanceLib library instance into ArmPkg. Thanks Liming > -Original Message- >

Re: [edk2] [PATCH 0/3] OvmfPkg/QemuVideoDxe/VbeShim: handle PAM1 register on Q35 correctly

Tested-by: Aleksei Kovura Works for me with Qemu 2.10.0. On 19/09/17 22:18, Laszlo Ersek wrote: Repo: https://github.com/lersek/edk2.git Branch: vbe_shim_q35_pam Fix the long-standing OVMF/Q35 bug recently exposed by a QEMU change, and reported under

[edk2] [PATCH] MdePkg: add ARM/AARCH64 support to BaseCacheMaintenanceLib

ARM platforms have been using a separately located library in ArmPkg for high-level cache maintenance calls. Resolve this anomaly by overwriting ArmCache.c with the contents of ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.c, and add the ArmLib dependency for the affected

[edk2] [PATCH V6 6/6] MdeModulePkg/DriverSample: Add questions with bit/union VarStore

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=545 Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- .../Universal/DriverSampleDxe/DriverSample.c | 120

[edk2] [PATCH V6 2/6] MdeModulePkg: Add GUID/flags to implement BitField support

V6:Update EDKII extenstion MACRO name with EDKII prefix which are missing in V5. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=545 Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi

[edk2] [PATCH V6 3/6] MdeModulePkg/UefiHiiLib: Validate question with bit fields

V6:Update EDKII extenstion MACRO name with EDKII prefix which are missing in V5. REF:https://bugzilla.tianocore.org/show_bug.cgi?id=545 In UefiHiiLib, there are codes to validate the current setting of questions, now update the logic to handle question with bit storage. Cc: Eric Dong

[edk2] [PATCH V6 5/6] MdeModulePkg/SetupBrowser: Handle questions with Bit VarStore

V6:Update EDKII extenstion MACRO name with EDKII prefix which are missing in V5. REF:https://bugzilla.tianocore.org/show_bug.cgi?id=545 For oneof/numeric/CheckBox(storage can be Bit VarStore) If the question value can be updated and shown correctly in UI page, we need do enhancements in

[edk2] [PATCH V6 4/6] MdeModulePkg/HiiDatabase: Handle questions with Bit VarStore

V6:Update EDKII extenstion MACRO name with EDKII prefix which are missing in V5. REF:https://bugzilla.tianocore.org/show_bug.cgi?id=545 For oneof/numeric/checkbox, their storage may be bit field. When generating string to get default value for these questions, we need to parse the Ifr data to

[edk2] [PATCH V6 0/6] Support bitfield in storage of vfr

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=545 This patch series is to: (1) Update VfrCompiler to parse bit field in data structure. (2) Update HiiDatabase,SetupBrowser and UefiHiiLib to handle questions with Bit VarStore. (3) Add sample questions with bit/union VarStore in

Re: [edk2] [PATCH] CryptoPkg: Add new API to retrieve commonName of X.509 certificate

Laszlo. It's one good feedback. This is one historical design issue. We choose to use simple BOOLEAN as the return value, because OpenSSL has complicated return data (reason) with extra api (e.g. ERR_get_error()...). It's hard to map these error messages directly, then we just used one

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition

Laszlo: ECC depends on antlr V3.0.1. It can be downloaded from http://www.antlr3.org/download/Python/ After download it, use python setup.py install to install it. I try this way on Windows OS, it can work. Thanks Liming > -Original Message- > From: edk2-devel

Re: [edk2] [PATCH] CryptoPkg: Add new API to retrieve commonName of X.509 certificate

Hello Qin, On 09/19/17 05:38, Long Qin wrote: > Add one new API (X509GetCommonName()) to retrieve the subject commonName > string from one X.509 certificate. > > Cc: Ting Ye > Cc: Chao Zhang > Contributed-under: TianoCore Contribution Agreement 1.0 >

Re: [edk2] [PATCH 0/3] OvmfPkg/QemuVideoDxe/VbeShim: handle PAM1 register on Q35 correctly

On 09/20/17 09:05, Aleksei wrote: > Hi Laszlo, > > I've built it (despite edk2/ovmf build process being as convoluted as > ever) Criticism well deserved :) , but at least we have excuses (multi-platform, multi-compiler build system, and freestanding (i.e., not hosted) codebase). > and am trying

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition

On 09/20/17 12:11, Ni, Ruiyu wrote: > I am surprised that you don't know ECC tool.  > It's a much more complex tool than PatchCheck.py. > It's to report all coding style issues that doesn't follow EDKII C coding > style. Well, before my previous email, I tried to execute the command line you

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition

I am surprised that you don't know ECC tool.  It's a much more complex tool than PatchCheck.py. It's to report all coding style issues that doesn't follow EDKII C coding style. Thanks/Ray > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, September

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition

Ray, On 09/20/17 10:14, Ni, Ruiyu wrote: > When you add the header comments, please run > Python BaseTools/Source/Python/Ecc/Ecc.py -t > MdeModulePkg/Universal/Disk/PartitionDxe -s > To make sure there is no other coding style issue. side question: do you mean "PatchCheck.py"? I've never

Re: [edk2] [PATCH 2/2] MdeModulePkg/Core: Fix out-of-sync issue in GCD

Reviewed-by: Star Zeng for this patch. Please notice that the MemoryProtection.c is using gCpu->SetMemoryAttributes but not GCD SetMemorySpaceAttributes. You should need update it to use GCD SetMemorySpaceAttributes, you can have separated patch to cover it. Thanks, Star

[edk2] [PATCH V5 5/6] MdeModulePkg/SetupBrowser: Handle questions with Bit VarStore

V5: Update the EDKII extension GUID name with EDKII/Edkii prefix. Refine the interface and implemetation of function GetBitsQuestionValue and SetBitsQuestionValue. REF:https://bugzilla.tianocore.org/show_bug.cgi?id=545 For oneof/numeric/CheckBox(storage can be Bit VarStore) If the question value

[edk2] [PATCH V5 6/6] MdeModulePkg/DriverSample: Add questions with bit/union VarStore

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=545 Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- .../Universal/DriverSampleDxe/DriverSample.c | 120

[edk2] [PATCH V5 3/6] MdeModulePkg/UefiHiiLib: Validate question with bit fields

V5: Update the EDKII extension GUID name with EDKII/Edkii prefix. REF:https://bugzilla.tianocore.org/show_bug.cgi?id=545 In UefiHiiLib, there are codes to validate the current setting of questions, now update the logic to handle question with bit storage. Cc: Eric Dong Cc:

[edk2] [PATCH V5 0/6] Support bitfield in storage of vfr

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=545 This patch series is to: (1) Update VfrCompiler to parse bit field in data structure. (2) Update HiiDatabase,SetupBrowser and UefiHiiLib to handle questions with Bit VarStore. (3) Add sample questions with bit/union VarStore in

[edk2] [PATCH V5 4/6] MdeModulePkg/HiiDatabase: Handle questions with Bit VarStore

V5: Update the EDKII extension GUID name with EDKII/Edkii prefix. REF:https://bugzilla.tianocore.org/show_bug.cgi?id=545 For oneof/numeric/checkbox, their storage may be bit field. When generating string to get default value for these questions, we need to parse the Ifr data to get the bit

[edk2] [PATCH V5 2/6] MdeModulePkg: Add GUID/flags to implement BitField support

V5: Update the EDKII extension GUID name with EDKII/Edkii prefix. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=545 Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi

Re: [edk2] [PATCH] CryptoPkg: Add new API to retrieve commonName of X.509 certificate

Qin: Thanks for your explanation. It makes sense to me. Reviewed-by: Chao Zhang -Original Message- From: Long, Qin Sent: Wednesday, September 20, 2017 4:25 PM To: Zhang, Chao B ; Ye, Ting Cc:

Re: [edk2] [PATCH] CryptoPkg: Add new API to retrieve commonName of X.509 certificate

Thanks, Chao. Cryptest just simply use the hard-coded test vectors for API usage demonstration. So 64 is big enough for the given test X.509 data. Best Regards & Thanks, LONG, Qin -Original Message- From: Zhang, Chao B Sent: Wednesday, September 20, 2017 2:57 PM To: Long, Qin

Re: [edk2] [PATCH v2] PeiLib : Inform UEFI memory to Linux

Thanks for the information. Seems my understanding was not correct in this context. I have no other doubts on this change. -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Wednesday, September 20, 2017 12:02 PM To: Sakar Arora Cc:

Re: [edk2] [Patch] MdeModulePkg/DxeNetLib: Check the actual packet size before trim data from Nbuf.

Hi Siyuan, Maybe we can add more check for the Len to return directly, what do you think? if (Len == 0) { return 0; } > + if (Nbuf->TotalSize == 0) { > +return 0; > + } Thanks, Jiaxin > -Original Message- > From: Fu, Siyuan > Sent: Wednesday, September 20, 2017 11:24 AM

Re: [edk2] [PATCH v2 2/3] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition

Thanks/Ray > -Original Message- > From: Paulo Alcantara [mailto:pca...@zytor.com] > Sent: Tuesday, September 19, 2017 12:38 AM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star ; > Laszlo Ersek

Re: [edk2] [PATCH 0/2] Fixe out-of-sync issue between GCD and CPU driver

Thanks. I have no other comments. From: Wang, Jian J Sent: Wednesday, September 20, 2017 3:54 PM To: Yao, Jiewen ; edk2-devel@lists.01.org Cc: Kinney, Michael D ; Laszlo Ersek ; Dong, Eric ; Zeng, Star

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/UdfDxe: Rework driver to support PartitionDxe changes

OK I understood the reason now. I tried to understand the relationship between AVDP, LVD, and PD, but failed. The code below in Partition driver seems to say the LVD and PD are close to each other. Is it always true? If it is, I agree with the implementation. // // Cover the main VDS

Re: [edk2] [PATCH 0/2] Fixe out-of-sync issue between GCD and CPU driver

Jiewen, Yes. The patch has passed the validation of the UEFI booting Windows 10, Windows 7 and Fedora 25. If no comments from you and others, I'll push the patch to upstream soon. Thanks, Jian Wang -Original Message- From: Yao, Jiewen Sent: Wednesday, September 20, 2017 2:08 PM To:

[edk2] [Patch][edk2-platforms/minnowboard-max-udk2017] Vlv2TbltDevicePkg: Add ESRT table in OS

1. Add ESRT table in OS. 2. Changed SystemFirmware Descriptor. 3. Remove redundant code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Guo Mang --- .../SystemFirmwareDescriptor.acpi | Bin 172 -> 0 bytes

Re: [edk2] [PATCH 0/3] OvmfPkg/QemuVideoDxe/VbeShim: handle PAM1 register on Q35 correctly

Hi Laszlo, I've built it (despite edk2/ovmf build process being as convoluted as ever) and am trying to run it with qemu 2.10.0 - it's not booting at all, stuck at "Guest has not initialized the display (yet)." Maybe the problem is gcc version? I have 7.2.0 while edk2 instructions mention

Re: [edk2] [PATCH] CryptoPkg: Add new API to retrieve commonName of X.509 certificate

Qin: For cryptest, do we need to support 64 maximum CN name and NULL? That makes buffer size 65 instead of 64. Others are good to me. -Original Message- From: Long, Qin Sent: Tuesday, September 19, 2017 11:39 AM To: Ye, Ting ; Zhang, Chao B

[edk2] Repeated condition check

Hi all, There is a redundant condition check in the API PxeBcIcmp6ErrorDpcHandle() VOID EFIAPI PxeBcIcmp6ErrorDpcHandle ( IN VOID *Context ) { ... if (Type != ICMP_V6_DEST_UNREACHABLE && Type != ICMP_V6_PACKET_TOO_BIG && -Type != ICMP_V6_PACKET_TOO_BIG &&

Re: [edk2] [PATCH 2/3] IntelSiliconPkg/IntelVTdPmrPei: Parse RMRR table.

Yes, Typo. will be fixed. > -Original Message- > From: Zeng, Star > Sent: Wednesday, September 20, 2017 2:30 PM > To: Yao, Jiewen ; edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: RE: [PATCH 2/3] IntelSiliconPkg/IntelVTdPmrPei: Parse RMRR

Re: [edk2] [PATCH 1/3] IntelSiliconPkg/VTdInfoPpi: Let it follow DMAR table.

Agree! > -Original Message- > From: Zeng, Star > Sent: Wednesday, September 20, 2017 2:30 PM > To: Yao, Jiewen ; edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: RE: [PATCH 1/3] IntelSiliconPkg/VTdInfoPpi: Let it follow DMAR table. > > I

Re: [edk2] [PATCH v2] PeiLib : Inform UEFI memory to Linux

On 19 September 2017 at 22:32, Sakar Arora wrote: > The DXE core dispatcher relies on the available memory to allocate space for > loading the rest of the modules from the UEFI image. If we declare the UEFI > image memory space (from which DXE dispatcher reads the efi

Re: [edk2] [PATCH 0/3] IntelSiliconPkg/InteVTdPei: Add RMRR support in PEI

Minor comments added for separated patches, with that fixed, Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Yao, Jiewen Sent: Sunday, September 17, 2017 2:07 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [PATCH 0/3]

  1   2   >