[edk2] [patch] MdeModulePkg/SdMmc: update TPL to notify to fix UEFI SCT hang

We have to upgrade the TPL level used by SdMmc stack because the following flow: DiskIo2ReadWriteDisk() in logical partition -> PartitionReadBlocksEx() in logical partition at TPL callback level -> ProbeMediaStatusEx() with sync request -> DiskIo2ReadWriteDisk() in physical partition -> waiting

Re: [edk2] [Patch 000/351] Convert EDK II core packages to NASM for IA32/X64

Laszlo: Thanks! If no more comments, I plan to push those patches early next week. Thanks Liming > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, June 23, 2016 2:44 AM > To: Gao, Liming ; Kinney, Michael D >

Re: [edk2] [Patch] MdeModulePkg: Fix the wrong IpSb->State update

Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Wednesday, June 22, 2016 7:14 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Ryan Harkin Subject: [Patch] MdeModulePkg: Fix

Re: [edk2] [PATCH 4/4] ArmVirtPkg: add FDF definition for empty varstore

On 23 June 2016 at 03:43, Gao, Liming wrote: > Ard: > Could you send the updated FDF file that causes build failure? I would like > to see what issue here. > As it turns out, the defines should go into the associated .DSC file, in a [Defines] section. The .FDF parser

[edk2] [PATCH v2] MdeModulePkg/UefiBootManagerLib: Fix for wrong data built into MemoryTypeInformation variable

After booting a large-size ISO RAM disk (HTTP boot option pointing to a ISO file) and reboot system, system will possibly run into the following ASSERT because the BDS core code doesn't consider the case that Memory page management (Page.c) would possibly NOT update current memory usage

Re: [edk2] [PATCH] OvmfPkg: Add ACPI support for Virt Xen ARM

On 2016/5/31 18:35, Laszlo Ersek wrote: > On 05/31/16 06:59, Shannon Zhao wrote: >> > From: Shannon Zhao >> > >> > Add ACPI support for Virt Xen ARM and it gets the ACPI tables through >> > Xen ARM multiboot protocol. >> > >> > Contributed-under: TianoCore

Re: [edk2] [Xen-devel] [PATCH] OvmfPkg: Add ACPI support for Virt Xen ARM

On 2016/6/7 21:50, Julien Grall wrote: > > On 31/05/16 05:59, Shannon Zhao wrote: >> +EFI_STATUS >> +EFIAPI >> +GetXenArmAcpiRsdp ( >> + OUT EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER **RsdpPtr >> + ) >> +{ >> + VOID *Hob; >> +

[edk2] [Patch 0/2] Update PlatformSecureLibNull with PCD to get user physical presence

Liming Gao (2): SecurityPkg: Add PcdUserPhysicalPresence to indicate use physical presence. SecurityPkg: Update PlatformSecureLibNull with PCD to get physical presence. .../PlatformSecureLibNull/PlatformSecureLibNull.c | 29 -- .../PlatformSecureLibNull.inf

Re: [edk2] [PATCH v2 0/6] MMC fixes and PIO mode

Hi Feng, > You may misunderstand what I meant. Sorry for that. Indeed, we understood that introducing new PCD is a main problem. > > At first, the SD_MMC_PASS_THRU protocol is defined by UEFI spec, you couldn't > change its interfaces. > > Secondly, the transfer mode judgement should be done

[edk2] [Patch 1/2] SecurityPkg: Add PcdUserPhysicalPresence to indicate use physical presence.

This PCD supports all configuration type. Its default value is FALSE. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- SecurityPkg/SecurityPkg.dec | 6 ++ SecurityPkg/SecurityPkg.uni | 9 + 2 files changed, 15 insertions(+)

Re: [edk2] [PATCH 4/4] ArmVirtPkg: add FDF definition for empty varstore

On 06/23/16 10:14, Ard Biesheuvel wrote: > On 23 June 2016 at 03:43, Gao, Liming wrote: >> Ard: >> Could you send the updated FDF file that causes build failure? I would >> like to see what issue here. >> > > As it turns out, the defines should go into the associated

[edk2] [Patch 2/2] SecurityPkg: Update PlatformSecureLibNull with PCD to get physical presence.

This is an incompatible change. It uses PcdUserPhysicalPresence value instead of hard code TRUE. Because PcdUserPhysicalPresence default value is FALSE, this patch changes UserPhysicalPresent() return value from TRUE to FALSE. >From Security point, it is not safe to always return TRUE. If user

[edk2] [Patch 2/2] PcAtChipsetPkg: Update ResetSystemLib with PCDs

Update ResetSystemLib with PCDs for Reset Control Register and Value instead of hard code 0x64 and 0xFE. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.c | 6 +++---

[edk2] [Patch 0/2] PcAtChipsetPkg: Update ResetSystemLib with PCDs for Reset Control Register and Value

Liming Gao (2): PcAtChipsetPkg: Add two PCDs for Reset Control Register and Value PcAtChipsetPkg: Update ResetSystemLib with PCDs PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.c | 6 +++--- PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.inf | 6 +-

[edk2] [Patch 1/2] PcAtChipsetPkg: Add two PCDs for Reset Control Register and Value

PcdResetControlRegister for Reset Control Register address. PcdResetControlValueColdReset for Reset Control Register code reset value. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- PcAtChipsetPkg/PcAtChipsetPkg.dec | 8

Re: [edk2] [PATCH] ArmPkg/ArmGicV3Dxe: configure all interrupts as non-secure Group-1

On 23 June 2016 at 15:25, Laszlo Ersek wrote: > On 06/22/16 16:32, Ard Biesheuvel wrote: >> Reassign all interrupts to non-secure Group-1 if the GIC has its DS >> (Disable Security) bit set. In this case, it is safe to assume that we >> own the GIC, and that no other firmware

[edk2] [PATCH v2] ArmVirtPkg/ArmVirtXen: Add ACPI support for Virt Xen ARM

From: Shannon Zhao Add ACPI support for Virt Xen ARM and only for aarch64. It gets the ACPI tables through Xen ARM multiboot protocol. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Shannon Zhao --- Changes since v1: *

Re: [edk2] [PATCH] ArmPkg/ArmGicV3Dxe: configure all interrupts as non-secure Group-1

On 06/22/16 16:32, Ard Biesheuvel wrote: > Reassign all interrupts to non-secure Group-1 if the GIC has its DS > (Disable Security) bit set. In this case, it is safe to assume that we > own the GIC, and that no other firmware has performed any configuration > yet, which means it is up to us to

Re: [edk2] iPXE invalidates the OVMF network device options

On 06/23/16 06:43, Gary Lin wrote: > On Wed, Jun 22, 2016 at 07:24:32PM +0200, Laszlo Ersek wrote: >> Gary, >> >> On 06/22/16 17:33, Laszlo Ersek wrote: >>> On 06/22/16 17:24, Gerd Hoffmann wrote: On Mi, 2016-06-22 at 17:14 +0200, Laszlo Ersek wrote: > On 06/22/16 10:34, Michael Brown

Re: [edk2] [Patch 2/2] PcAtChipsetPkg: Update ResetSystemLib with PCDs

Looks good to me. Can you also use the PCD control for Warm and add new PCD for warm reset value in separate patch? Reviewed-by: Giri P Mudusuru Thanks, -Giri > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >

Re: [edk2] [PATCH] ArmPkg/ArmGicV3Dxe: configure all interrupts as non-secure Group-1

On Thu, Jun 23, 2016 at 03:26:53PM +0200, Ard Biesheuvel wrote: > On 23 June 2016 at 15:25, Laszlo Ersek wrote: > > On 06/22/16 16:32, Ard Biesheuvel wrote: > >> Reassign all interrupts to non-secure Group-1 if the GIC has its DS > >> (Disable Security) bit set. In this case,

Re: [edk2] [PATCH] ArmPkg/ArmGicV3Dxe: configure all interrupts as non-secure Group-1

On 23 June 2016 at 15:51, Leif Lindholm wrote: > On Thu, Jun 23, 2016 at 03:26:53PM +0200, Ard Biesheuvel wrote: >> On 23 June 2016 at 15:25, Laszlo Ersek wrote: >> > On 06/22/16 16:32, Ard Biesheuvel wrote: >> >> Reassign all interrupts to non-secure

Re: [edk2] [PATCH 4/4] ArmVirtPkg: add FDF definition for empty varstore

On 23 June 2016 at 16:00, Ard Biesheuvel wrote: > On 23 June 2016 at 12:57, Laszlo Ersek wrote: >> On 06/23/16 10:14, Ard Biesheuvel wrote: >>> On 23 June 2016 at 03:43, Gao, Liming wrote: Ard: Could you send the

Re: [edk2] [PATCH v2] ArmVirtPkg/ArmVirtXen: Add ACPI support for Virt Xen ARM

On 23 June 2016 at 13:31, Shannon Zhao wrote: > From: Shannon Zhao > > Add ACPI support for Virt Xen ARM and only for aarch64. It gets the > ACPI tables through Xen ARM multiboot protocol. > > Contributed-under: TianoCore Contribution Agreement

Re: [edk2] Adding a memory region to GCD on AARCH64?

Hi Laszlo, On Wed, Jun 22, 2016 at 09:56:11PM +0200, Laszlo Ersek wrote: > On 06/22/16 20:53, Achin Gupta wrote: > > Hi All, > > > > I having some trouble trying an experiment on the AARCH64 Base FVP with > > UEFI and > > ARM Trusted Firmware. There is a buffer that is allocated by the latter in

Re: [edk2] [PATCH 4/4] ArmVirtPkg: add FDF definition for empty varstore

On 23 June 2016 at 12:57, Laszlo Ersek wrote: > On 06/23/16 10:14, Ard Biesheuvel wrote: >> On 23 June 2016 at 03:43, Gao, Liming wrote: >>> Ard: >>> Could you send the updated FDF file that causes build failure? I would >>> like to see what issue

Re: [edk2] [Patch 1/2] PcAtChipsetPkg: Add two PCDs for Reset Control Register and Value

Looks good to me. Reviewed-by: Giri P Mudusuru > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Liming Gao > Sent: Thursday, June 23, 2016 2:54 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch 1/2]

Re: [edk2] [Patch 1/2] SecurityPkg: Add PcdUserPhysicalPresence to indicate use physical presence.

Looks good to me. Reviewed-by: Giri P Mudusuru > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Liming Gao > Sent: Thursday, June 23, 2016 2:50 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch 1/2]

Re: [edk2] Adding a memory region to GCD on AARCH64?

On 06/23/16 16:19, Achin Gupta wrote: > Hi Laszlo, > > On Wed, Jun 22, 2016 at 09:56:11PM +0200, Laszlo Ersek wrote: >> On 06/22/16 20:53, Achin Gupta wrote: >>> Hi All, >>> >>> I having some trouble trying an experiment on the AARCH64 Base FVP with >>> UEFI and >>> ARM Trusted Firmware. There

Re: [edk2] [Patch 2/2] SecurityPkg: Update PlatformSecureLibNull with PCD to get physical presence.

Looks good to me. Reviewed-by: Giri P Mudusuru > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Liming Gao > Sent: Thursday, June 23, 2016 2:53 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch 2/2]

[edk2] [PATCH] [edk2-staging/HTTPS-TLS][PATCH]: Centralize TLS var cert name and guid

Put the TLS cert variable name define into GlobalVariable.h and create a GUID for it in CryptoPkg.dec. Describe the minimum size and expected variable attributes in VarCheckUefiLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Palmer ---

Re: [edk2] StdLib usage for drivers?

On 06/22/2016 02:38 PM, Marvin H?user wrote: Dear EDK2 developers, For an experimental project, I'm currently attempting to write a library wrapper for the disassembler library 'Capstone' in a similar manner to CryptoPkg's OpensslLib. ... Marvin, If you only need IA32/X64, the Udis86 library

Re: [edk2] [RFC V2] Proposal to organize packages into directories

On Tue, Jun 21, 2016 at 12:11:14PM -0700, Andrew Fish wrote: > > > On Jun 20, 2016, at 5:58 PM, Jordan Justen > > wrote: > > > > On 2016-06-20 17:08:58, Kinney, Michael D wrote: > >> Jordan, > >> > >> There is a "Driver" directory in the proposal and the types of >

Re: [edk2] [Patch 2/2] PcAtChipsetPkg: Update ResetSystemLib with PCDs

Giri: Thanks for your comment. I thought this option before. For this library implementation, its WarmReset is same to CodeReset. So, I just introduce one PCD to configure it. If this library is expected to have the different WarmReset, I can add warm reset value later. Thanks Liming From:

Re: [edk2] iPXE invalidates the OVMF network device options

On Fri, Jun 24, 2016 at 10:19:30AM +0800, Gary Lin wrote: > On Thu, Jun 23, 2016 at 02:57:49PM +0200, Laszlo Ersek wrote: > > On 06/23/16 06:43, Gary Lin wrote: > > > On Wed, Jun 22, 2016 at 07:24:32PM +0200, Laszlo Ersek wrote: > > >> Gary, > > >> > > >> On 06/22/16 17:33, Laszlo Ersek wrote: > >

Re: [edk2] [PATCH] IntelFsp2Pkg-BaseFspCommonLib: Add funtion to return the reset required status

Looks good to me. Reviewed-by: Giri P Mudusuru > -Original Message- > From: Yao, Jiewen > Sent: Thursday, June 23, 2016 8:21 PM > To: Yarlagadda, Satya P ; edk2- > de...@lists.01.org > Cc: Mudusuru, Giri P

[edk2] [PATCH] MdeModulePkg PiDxeS3BootScriptLib: Use a specific name for mSmst

When a driver also uses a same name, there will be a link error: one or more multiply defined symbols found. Use a specific name for mSmst to avoid the link error. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng

Re: [edk2] [Patch 2/2] PcAtChipsetPkg: Update ResetSystemLib with PCDs

Thanks for clarification Liming. Reviewed-by: Giri P Mudusuru > From: Gao, Liming Sent: Thursday, June 23, 2016 9:11 PM To: Mudusuru, Giri P ; edk2-devel@lists.01.org Subject: RE: [edk2] [Patch 2/2]

Re: [edk2] [PATCH v2 0/6] MMC fixes and PIO mode

Sure, thanks. Reviewed-by: Feng Tian for patch 1 & 2. I will help push them to git repo. Best Regards Feng -Original Message- From: Marcin Wojtas [mailto:m...@semihalf.com] Sent: Thursday, June 23, 2016 5:49 PM To: Tian, Feng Cc:

[edk2] [patch v2] MdeModulePkg/SdMmc: update TPL to notify to fix UEFI SCT hang

Compared with v1, we added critical region protection on queue access made in EraseBlock support. We have to upgrade the TPL level used by SdMmc stack because the following flow: DiskIo2ReadWriteDisk() in logical partition -> PartitionReadBlocksEx() in logical partition at TPL callback level ->

[edk2] [patch] MdeModulePkg/HiiDatabaseDxe: Add ASSERT before using the pointer 'String'

The 'Sting' is returned by the function GetUnicodeStringTextAndSize. If it is NULL, function GetUnicodeStringTextAndSize will return EFI_OUT_OF_RESOURCES, and error handling codes will cover it. So the pointer 'Sting' can not be NULL when using it. So we can add the ASSERT codes. Cc: Eric Dong

Re: [edk2] [PATCH v2 0/6] MMC fixes and PIO mode

Thanks! Best regards, Marcin 2016-06-24 2:25 GMT+02:00 Tian, Feng : > Sure, thanks. > > Reviewed-by: Feng Tian for patch 1 & 2. > > I will help push them to git repo. > > Best Regards > Feng > > -Original Message- > From: Marcin Wojtas

Re: [edk2] [patch] MdeModulePkg/SdMmc: update TPL to notify to fix UEFI SCT hang

Hi Feng, I found that some "RemoveEntryList" calls that modifies SD/EMMC device's queue are not guarded by raising the TPL. I think most of them are related with EraseBlock feature functions in file EmmcBlockIo.c & SdBlockIo.c. Could you help to double confirm and add the missing guards? Best

Re: [edk2] iPXE invalidates the OVMF network device options

On Thu, Jun 23, 2016 at 02:57:49PM +0200, Laszlo Ersek wrote: > On 06/23/16 06:43, Gary Lin wrote: > > On Wed, Jun 22, 2016 at 07:24:32PM +0200, Laszlo Ersek wrote: > >> Gary, > >> > >> On 06/22/16 17:33, Laszlo Ersek wrote: > >>> On 06/22/16 17:24, Gerd Hoffmann wrote: > On Mi, 2016-06-22 at

[edk2] [PATCH] IntelFsp2Pkg-BaseFspCommonLib: Add funtion to return the reset required status

Added new funtion in FSPCommonLib to update the FSP API return status with the requested return status and return the control to the boot loader. Cc: Giri P Mudusuru Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [PATCH] IntelFsp2Pkg-BaseFspCommonLib: Add funtion to return the reset required status

Reviewed-by: jiewen@intel.com > -Original Message- > From: Yarlagadda, Satya P > Sent: Friday, June 24, 2016 10:38 AM > To: edk2-devel@lists.01.org > Cc: Mudusuru, Giri P ; Yao, Jiewen > > Subject: [PATCH]

Re: [edk2] [patch] MdeModulePkg/SdMmc: update TPL to notify to fix UEFI SCT hang

thanks for your findings. Yes. It's mistake when I added EraseBlock support. I will update it at v2. Thanks Feng -Original Message- From: Wu, Hao A Sent: Friday, June 24, 2016 11:27 AM To: Tian, Feng Cc: edk2-devel@lists.01.org Subject: RE: [patch]