Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268

2011-05-20 Thread ThorstenB
On 19.05.2011 20:38, Lauri Peltonen wrote:
 So the solution is either change the clear color to what it was, or make
 it ramp linearly to black or something with altitude.

 Or change simgear/scene/sky.cxx around line 117 (repaint method), there
 is a
 if ( effective_visibility  1000.0 ) {
...
 } else {
// turn off sky
disable();
 }

Great find, Lauri! Removing the visibility condition fixes the issue for 
me - and I haven't seen any side effects (yet ;) ). Not sure why that 
condition was introduced in the first place (suggestions anyone?).
The condition seems a bit of hack to me - why should sky be switched 
off for 999 feet, but not for 1001 feet visibility... So, removing it 
may be the cleanest solution to the sky color issue.

My suggestion: we try removing the condition now and see if anyone sees 
new issues. If so, it's probably best to temporarily revert both patches 
for the upcoming release - and try to find a better solution for the 
next one. And if removing the condition does not cause any new issues, 
we've solved the issue anyway (and of course keep it for the release).

Other suggestions? Any background info on the effective_visibility 
1000.0 condition? Otherwise I'll try removing it from sg/next.

cheers,
Thorsten

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268

2011-05-19 Thread Lauri Peltonen
Hi all!

At last I had time to look at the black sky problem which resulted every
time visibility was  1000 meters (or feet?). Anyways, I found the
problem.

Indeed I changed the clear color to be black to make space look better.
But what I didn't know was that the whole sky (dome and stars etc) is
optimised away if visibility is less than that 1000 units.

So the solution is either change the clear color to what it was, or make
it ramp linearly to black or something with altitude.

Or change simgear/scene/sky.cxx around line 117 (repaint method), there
is a 
if ( effective_visibility  1000.0 ) {
  ...
} else {
  // turn off sky
  disable();
}

so taking that condition away would solve the problem.

What would be the best solution, what do you think?

Zan


--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268

2011-05-19 Thread TDO_Brandano -

I think that the best setup would use a broken line rather than a simple linear 
ramp, to show actual transition outside of atmospheric flight.  Would something 
like that affect performance much?

Alessandro

 From: lauri.pelto...@gmail.com
 To: flightgear-devel@lists.sourceforge.net
 Date: Thu, 19 May 2011 21:38:38 +0300
 Subject: Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268
 
 Hi all!
 
 At last I had time to look at the black sky problem which resulted every
 time visibility was  1000 meters (or feet?). Anyways, I found the
 problem.
 
 Indeed I changed the clear color to be black to make space look better.
 But what I didn't know was that the whole sky (dome and stars etc) is
 optimised away if visibility is less than that 1000 units.
 
 So the solution is either change the clear color to what it was, or make
 it ramp linearly to black or something with altitude.
 
 Or change simgear/scene/sky.cxx around line 117 (repaint method), there
 is a 
 if ( effective_visibility  1000.0 ) {
   ...
 } else {
   // turn off sky
   disable();
 }
 
 so taking that condition away would solve the problem.
 
 What would be the best solution, what do you think?
 
 Zan
 
 
 --
 What Every C/C++ and Fortran developer Should Know!
 Read this article and learn how Intel has extended the reach of its 
 next-generation tools to help Windows* and Linux* C/C++ and Fortran 
 developers boost performance applications - including clusters. 
 http://p.sf.net/sfu/intel-dev2devmay
 ___
 Flightgear-devel mailing list
 Flightgear-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/flightgear-devel
  --
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268

2011-05-18 Thread ThorstenB
On 18.05.2011 01:42, Csaba Halász wrote:
 Also: it seems 3D clouds are broken with current OSG-trunk. Works well
 for me with older OSG versions. Can anyone else confirm the issue?
 Downgraded to svn rev 11900, got 3D clouds back. Note, I am not saying
 the breakage occurred there, I just randomly picked that as a testing
 point.

Ok, thanks. We'll probably have to narrow it down to the exact OSG 
commit to see what changed there. If anyone else has a 
working/non-working OSG revision in between 11900 and 12419, you're 
welcome to let us know. Also, maybe someone has an extremely powerful 
machine and could help with testing different OSG revisions.
I've created a tracker issue - you could just post working/non-working 
revisions there:
http://code.google.com/p/flightgear-bugs/issues/detail?id=317

cheers,
Thorsten

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268

2011-05-18 Thread TDO_Brandano -

That's 519 possible culprits. It will take 10 compiles to find the exact 
revision by successive approximations.

 Date: Wed, 18 May 2011 08:45:11 +0200
 From: bre...@gmail.com
 To: flightgear-devel@lists.sourceforge.net
 Subject: Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268
 
 On 18.05.2011 01:42, Csaba Halász wrote:
  Also: it seems 3D clouds are broken with current OSG-trunk. Works well
  for me with older OSG versions. Can anyone else confirm the issue?
  Downgraded to svn rev 11900, got 3D clouds back. Note, I am not saying
  the breakage occurred there, I just randomly picked that as a testing
  point.
 
 Ok, thanks. We'll probably have to narrow it down to the exact OSG 
 commit to see what changed there. If anyone else has a 
 working/non-working OSG revision in between 11900 and 12419, you're 
 welcome to let us know. Also, maybe someone has an extremely powerful 
 machine and could help with testing different OSG revisions.
 I've created a tracker issue - you could just post working/non-working 
 revisions there:
 http://code.google.com/p/flightgear-bugs/issues/detail?id=317
 
 cheers,
 Thorsten
 
 --
 What Every C/C++ and Fortran developer Should Know!
 Read this article and learn how Intel has extended the reach of its 
 next-generation tools to help Windows* and Linux* C/C++ and Fortran 
 developers boost performance applications - including clusters. 
 http://p.sf.net/sfu/intel-dev2devmay
 ___
 Flightgear-devel mailing list
 Flightgear-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/flightgear-devel
  --
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268

2011-05-18 Thread Torsten Dreyer

 Ok, thanks. We'll probably have to narrow it down to the exact OSG
 commit to see what changed there. If anyone else has a
 working/non-working OSG revision in between 11900 and 12419, you're
 welcome to let us know. Also, maybe someone has an extremely powerful
 machine and could help with testing different OSG revisions.
 I've created a tracker issue - you could just post working/non-working
 revisions there:
 http://code.google.com/p/flightgear-bugs/issues/detail?id=317
Message understood ;-)
I'll have al look during the next days. There is not much spare time to 
dedicate to fg, though but I'll give it a try.
Making osg, sg and fg is just a matter of 1-2 minutes on our machine.

Torsten

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268

2011-05-18 Thread Alan Teeder
As requested I have today tested with VC2010 and all the pre-compiled 
versions of OSG that I have available.

These are OSG 2,8.4 and OSG trunk (at present OSG 2.9.12) from 
http://openscenegraph.alphapixel.com/osg/downloads/free-openscenegraph-binary-downloads
 
and  and OSG 2.9.10 from 
ftp://ftp.ihg.uni-duisburg.de/FlightGear/Win32/MSVC/).

I have black sky in all 3 as we have discussed in 
http://sourceforge.net/mailarchive/message.php?msg_id=27467054.

I did not bother with a cmake for each of these , just copied the OSG bin, 
include and lib directories to my 
C:\FlightGear\install\msvc100\OpenSceneGraph directory and then did a 
build-clean followed by a build and install of both simgear and flightgear.

The random yelllow text bug was apparent on the splash screens as well.

Alan 


--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268

2011-05-18 Thread Csaba Halász
On Wed, May 18, 2011 at 8:45 AM, ThorstenB bre...@gmail.com wrote:
 working/non-working OSG revision in between 11900 and 12419, you're
 welcome to let us know. Also, maybe someone has an extremely powerful
 machine and could help with testing different OSG revisions.

My machine is not extremely powerful, but 12300 works while 12330 doesn't.

-- 
Csaba/Jester

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268

2011-05-18 Thread ThorstenB
On 18.05.2011 19:29, Csaba Halász wrote:
 On Wed, May 18, 2011 at 8:45 AM, ThorstenBbre...@gmail.com  wrote:
 working/non-working OSG revision in between 11900 and 12419, you're
 welcome to let us know. Also, maybe someone has an extremely powerful
 machine and could help with testing different OSG revisions.

 My machine is not extremely powerful, but 12300 works while 12330 doesn't.
Thanks Csaba, that's already close! I looked at the commit logs but 
didn't find any obvious culprit. A good next test would be r12312 - 
which is the OSG 2.9.13 dev release. Everything before 12312 was actual 
development (nothing obvious), everything after 12312 were code changes 
to fix compiler warnings and Coverity code analysis issues. This one 
will be fun... ;-)

 Message understood ;-)
 I'll have al look during the next days. There is not much spare time to
 dedicate to fg, though but I'll give it a try.
Thanks Torsten, though the message wasn't specifically for you. But our 
FlightGear monster server could probably be helpful here indeed.

cheers,
Thorsten

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268

2011-05-18 Thread ThorstenB
On 18.05.2011 18:16, Alan Teeder wrote:
 As requested I have today tested with VC2010 and all the pre-compiled
 versions of OSG that I have available.

 These are OSG 2,8.4 and OSG trunk (at present OSG 2.9.12) from
 http://openscenegraph.alphapixel.com/osg/downloads/free-openscenegraph-binary-downloads
 and  and OSG 2.9.10 from
 ftp://ftp.ihg.uni-duisburg.de/FlightGear/Win32/MSVC/).

 I have black sky in all 3 as we have discussed in
 http://sourceforge.net/mailarchive/message.php?msg_id=27467054.

 I did not bother with a cmake for each of these , just copied the OSG bin,
 include and lib directories to my
 C:\FlightGear\install\msvc100\OpenSceneGraph directory and then did a
 build-clean followed by a build and install of both simgear and flightgear.

 The random yelllow text bug was apparent on the splash screens as well.

Ok, thanks for testing Alan. At LinuxTag we actually noticed an issue 
that happened when 3D clouds were disabled. Whenever flying in between 
2D cloud sheets, the sky turned black (with white 2D clouds) - really 
ugly. Didn't happen with 3D cloud support enabled. And we figured that's 
a genuine FG bug, which must have been introduced only recently. Might 
be the result of some shader change (maybe by introducing the new sky 
dome shader, but not sure). Do you see a difference when 
enabling/disabling 3D cloud support?

cheers,
Thorsten

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268

2011-05-18 Thread Curtis Olson
I seem to recall we changed the clear color to black recently.  It may be
that with 2d clouds we were depending on the clear color matching the fog
color for correct rendering?  I'm not sure what the motivation for changing
the clear color was, but I'm guessing it was related to the sky dome or
drawing space views???

Curt.


On Wed, May 18, 2011 at 1:30 PM, ThorstenB bre...@gmail.com wrote:

 On 18.05.2011 18:16, Alan Teeder wrote:
  As requested I have today tested with VC2010 and all the pre-compiled
  versions of OSG that I have available.
 
  These are OSG 2,8.4 and OSG trunk (at present OSG 2.9.12) from
 
 http://openscenegraph.alphapixel.com/osg/downloads/free-openscenegraph-binary-downloads
  and  and OSG 2.9.10 from
  ftp://ftp.ihg.uni-duisburg.de/FlightGear/Win32/MSVC/).
 
  I have black sky in all 3 as we have discussed in
  http://sourceforge.net/mailarchive/message.php?msg_id=27467054.
 
  I did not bother with a cmake for each of these , just copied the OSG
 bin,
  include and lib directories to my
  C:\FlightGear\install\msvc100\OpenSceneGraph directory and then did a
  build-clean followed by a build and install of both simgear and
 flightgear.
 
  The random yelllow text bug was apparent on the splash screens as well.

 Ok, thanks for testing Alan. At LinuxTag we actually noticed an issue
 that happened when 3D clouds were disabled. Whenever flying in between
 2D cloud sheets, the sky turned black (with white 2D clouds) - really
 ugly. Didn't happen with 3D cloud support enabled. And we figured that's
 a genuine FG bug, which must have been introduced only recently. Might
 be the result of some shader change (maybe by introducing the new sky
 dome shader, but not sure). Do you see a difference when
 enabling/disabling 3D cloud support?

 cheers,
 Thorsten


 --
 What Every C/C++ and Fortran developer Should Know!
 Read this article and learn how Intel has extended the reach of its
 next-generation tools to help Windows* and Linux* C/C++ and Fortran
 developers boost performance applications - including clusters.
 http://p.sf.net/sfu/intel-dev2devmay
 ___
 Flightgear-devel mailing list
 Flightgear-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/flightgear-devel




-- 
Curtis Olson:
http://www.atiak.com - http://aem.umn.edu/~uav/
http://www.flightgear.org - http://gallinazo.flightgear.org
--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268

2011-05-18 Thread ThorstenB
On 18.05.2011 20:39, Curtis Olson wrote:
 I seem to recall we changed the clear color to black recently.  It may
 be that with 2d clouds we were depending on the clear color matching the
 fog color for correct rendering?  I'm not sure what the motivation for
 changing the clear color was, but I'm guessing it was related to the sky
 dome or drawing space views???

Thanks Curt, that sounds very much like a possible reason. Was that a 
change to fg/sg or fgdata? Anyone remembers the exact commit? Again, 
would be great if s.o. could test the 2D cloud / sky-color behaviour 
with and without the specific clear color-patch. If that patch was the 
cause, then we may need to revert it - and find a better solution.

cheers,
Thorsten

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268

2011-05-18 Thread Martin Spott
ThorstenB wrote:

 Thanks Curt, that sounds very much like a possible reason. Was that a 
 change to fg/sg or fgdata? Anyone remembers the exact commit?

As far as I remember, it's related to Lauri Peltonen and sky dome,
it's implementing a shader (among other stuff) and was indeed meant to
bring FG closer to how the sky looks in real life: black  :-)
I'd have a few commits on offer which might be related, but at least
one of them is hiding the possible changes in a big reformatting rush
(preferences.xml).

Cheers,
Martin.
-- 
 Unix _IS_ user friendly - it's just selective about who its friends are !
--

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268

2011-05-18 Thread Alan Teeder

--
From: Martin Spott martin.sp...@mgras.net
Sent: Wednesday, May 18, 2011 8:15 PM
Newsgroups: list.flightgear-devel
To: flightgear-devel@lists.sourceforge.net
Subject: Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268

 ThorstenB wrote:

 Thanks Curt, that sounds very much like a possible reason. Was that a
 change to fg/sg or fgdata? Anyone remembers the exact commit?

 As far as I remember, it's related to Lauri Peltonen and sky dome,
 it's implementing a shader (among other stuff) and was indeed meant to
 bring FG closer to how the sky looks in real life: black  :-)
 I'd have a few commits on offer which might be related, but at least
 one of them is hiding the possible changes in a big reformatting rush
 (preferences.xml).



Thorsten, Martin.

There is a reference to the black sky problem on the forum at 
http://www.flightgear.org/forums/viewtopic.php?f=47t=11274start=30 by 
Zan, the author of the atmospheric scattering patch .

I have been trying various cloud combinations with an aircraft parked on the 
runway, but so far have not made any visible changes.

Alan

 


--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268

2011-05-18 Thread ThorstenB
Ok, the black sky issue was indeed caused by changing the clear color.
The effect is really ugly - black sky when flying through clouds or
fog. Also black sky when flying above a cloud layer. And it's not
restricted to 2D clouds alone.

That's the relevant commit:
http://www.gitorious.org/fg/flightgear/commit/b36b33f716031ef5933d41a1e5c17c6be3e54c28

Apparently the change was introduced only to turn the color of space
black instead of gray. I think flying through clouds/fog is more
important than space-flights for now, so I'm planning to revert that
particular commit shortly until we have a better solution. I know it's
a pity and I apologize to all Vostok-1 cosmonauts. :-)

Any objections (preferably accompanied by a patch ;-) )?

cheers,
Thorsten


On Wed, May 18, 2011 at 9:58 PM, Alan Teeder ajtee...@v-twin.org.uk wrote:

 --
 From: Martin Spott martin.sp...@mgras.net
 Sent: Wednesday, May 18, 2011 8:15 PM
 Newsgroups: list.flightgear-devel
 To: flightgear-devel@lists.sourceforge.net
 Subject: Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268

 ThorstenB wrote:

 Thanks Curt, that sounds very much like a possible reason. Was that a
 change to fg/sg or fgdata? Anyone remembers the exact commit?

 As far as I remember, it's related to Lauri Peltonen and sky dome,
 it's implementing a shader (among other stuff) and was indeed meant to
 bring FG closer to how the sky looks in real life: black  :-)
 I'd have a few commits on offer which might be related, but at least
 one of them is hiding the possible changes in a big reformatting rush
 (preferences.xml).



 Thorsten, Martin.

 There is a reference to the black sky problem on the forum at
 http://www.flightgear.org/forums/viewtopic.php?f=47t=11274start=30 by
 Zan, the author of the atmospheric scattering patch .

 I have been trying various cloud combinations with an aircraft parked on the
 runway, but so far have not made any visible changes.

 Alan

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268

2011-05-18 Thread Csaba Halász
On Wed, May 18, 2011 at 8:19 PM, ThorstenB bre...@gmail.com wrote:

 Thanks Csaba, that's already close! I looked at the commit logs but
 didn't find any obvious culprit. A good next test would be r12312 -

... which is broken.
Turns out 12303 is the cause for the constant sunshine ;)

Specifically, the GLSL version parsing has been broken:

Original code: _glslLanguageVersion = asciiToFloat( langVerStr );
New code: _glslLanguageVersion = ( asciiToFloat( glslvs.substr(
glslvs.find( GLSL +5 ) ).c_str() ) );

The version string for me here is simply 3.30 (using fglrx 11.4), so
the old code works but the new one doesn't.
Incidentally, the GL version parsing doesn't work either, because
version string is 3.3.10666 Compatibility Profile Context and the
code (both the old and the new) expect a decimal number before the
space.

I can't really believe this is the best way to get version numbers from opengl.

-- 
Csaba/Jester

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268

2011-05-18 Thread ThorstenB
On 18.05.2011 22:45, Csaba Halász wrote:
 On Wed, May 18, 2011 at 8:19 PM, ThorstenBbre...@gmail.com  wrote:

 Thanks Csaba, that's already close! I looked at the commit logs but
 didn't find any obvious culprit. A good next test would be r12312 -

 ... which is broken.
 Turns out 12303 is the cause for the constant sunshine ;)
Great! Excellent you've found it!

 Specifically, the GLSL version parsing has been broken:

 Original code: _glslLanguageVersion = asciiToFloat( langVerStr );
 New code: _glslLanguageVersion = ( asciiToFloat( glslvs.substr(
 glslvs.find( GLSL +5 ) ).c_str() ) );

 The version string for me here is simply 3.30 (using fglrx 11.4), so
 the old code works but the new one doesn't.
 Incidentally, the GL version parsing doesn't work either, because
 version string is 3.3.10666 Compatibility Profile Context and the
 code (both the old and the new) expect a decimal number before the
 space.

 I can't really believe this is the best way to get version numbers from 
 opengl.

Indeed. And a very good find! I can't believe they've just hard-coded 
some +5s and +8s to the index to parse the version string. Stuff 
like this has to fail.
Can you please post this find at osg-devel? I could cross-post for you, 
but then again it'd be good if you could do the follow ups on this.

cheers,
Thorsten

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268

2011-05-18 Thread TDO_Brandano -

How hard would it be to change the background colour based on the camera 
altitude? Even a linear gradient between two set points would work, I think.


 Date: Wed, 18 May 2011 22:41:54 +0200
 From: bre...@gmail.com
 To: flightgear-devel@lists.sourceforge.net
 Subject: Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268
 
 Ok, the black sky issue was indeed caused by changing the clear color.
 The effect is really ugly - black sky when flying through clouds or
 fog. Also black sky when flying above a cloud layer. And it's not
 restricted to 2D clouds alone.
 
 That's the relevant commit:
 http://www.gitorious.org/fg/flightgear/commit/b36b33f716031ef5933d41a1e5c17c6be3e54c28
 
 Apparently the change was introduced only to turn the color of space
 black instead of gray. I think flying through clouds/fog is more
 important than space-flights for now, so I'm planning to revert that
 particular commit shortly until we have a better solution. I know it's
 a pity and I apologize to all Vostok-1 cosmonauts. :-)
 
 Any objections (preferably accompanied by a patch ;-) )?
 
 cheers,
 Thorsten
 
 
 On Wed, May 18, 2011 at 9:58 PM, Alan Teeder ajtee...@v-twin.org.uk wrote:
 
  --
  From: Martin Spott martin.sp...@mgras.net
  Sent: Wednesday, May 18, 2011 8:15 PM
  Newsgroups: list.flightgear-devel
  To: flightgear-devel@lists.sourceforge.net
  Subject: Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268
 
  ThorstenB wrote:
 
  Thanks Curt, that sounds very much like a possible reason. Was that a
  change to fg/sg or fgdata? Anyone remembers the exact commit?
 
  As far as I remember, it's related to Lauri Peltonen and sky dome,
  it's implementing a shader (among other stuff) and was indeed meant to
  bring FG closer to how the sky looks in real life: black  :-)
  I'd have a few commits on offer which might be related, but at least
  one of them is hiding the possible changes in a big reformatting rush
  (preferences.xml).
 
 
 
  Thorsten, Martin.
 
  There is a reference to the black sky problem on the forum at
  http://www.flightgear.org/forums/viewtopic.php?f=47t=11274start=30 by
  Zan, the author of the atmospheric scattering patch .
 
  I have been trying various cloud combinations with an aircraft parked on the
  runway, but so far have not made any visible changes.
 
  Alan
 
 --
 What Every C/C++ and Fortran developer Should Know!
 Read this article and learn how Intel has extended the reach of its 
 next-generation tools to help Windows* and Linux* C/C++ and Fortran 
 developers boost performance applications - including clusters. 
 http://p.sf.net/sfu/intel-dev2devmay
 ___
 Flightgear-devel mailing list
 Flightgear-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/flightgear-devel
  --
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268

2011-05-17 Thread Csaba Halász
On Wed, May 18, 2011 at 12:25 AM, ThorstenB bre...@gmail.com wrote:

 Also: it seems 3D clouds are broken with current OSG-trunk. Works well
 for me with older OSG versions. Can anyone else confirm the issue?

I don't get any 3D clouds at the moment, but I assumed that was
because I also upgraded graphics driver (fglrx 11.4) at the same time.

-- 
Csaba/Jester

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


Re: [Flightgear-devel] Testing OSG-trunk / bug issue #268

2011-05-17 Thread Csaba Halász
On Wed, May 18, 2011 at 12:36 AM, Csaba Halász csaba.hal...@gmail.com wrote:
 On Wed, May 18, 2011 at 12:25 AM, ThorstenB bre...@gmail.com wrote:

 Also: it seems 3D clouds are broken with current OSG-trunk. Works well
 for me with older OSG versions. Can anyone else confirm the issue?

 I don't get any 3D clouds at the moment, but I assumed that was
 because I also upgraded graphics driver (fglrx 11.4) at the same time.

Downgraded to svn rev 11900, got 3D clouds back. Note, I am not saying
the breakage occurred there, I just randomly picked that as a testing
point.

-- 
Csaba/Jester

--
What Every C/C++ and Fortran developer Should Know!
Read this article and learn how Intel has extended the reach of its 
next-generation tools to help Windows* and Linux* C/C++ and Fortran 
developers boost performance applications - including clusters. 
http://p.sf.net/sfu/intel-dev2devmay
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel