[Freeciv-Dev] [patch #4402] Fix typo that allowed custom formats only up to sizeof(char*)

2014-01-03 Thread Guillaume Melquiond
URL: http://gna.org/patch/?4402 Summary: Fix typo that allowed custom formats only up to sizeof(char*) Project: Freeciv Submitted by: silene Submitted on: Fri 03 Jan 2014 01:22:58 PM CET Category: general

[Freeciv-Dev] [bug #21424] Handle negated requirements in client improvement help (Prevents Granary as well as Allows Granary)

2014-01-03 Thread Jacob Nevins
Update of bug #21424 (project freeciv): Summary: Handle negated requirements in client help (Prevents Granary as well as Allows Granary) = Handle negated requirements in client improvement help (Prevents Granary as well as Allows Granary)

[Freeciv-Dev] [bug #21424] Handle negated requirements in client improvement help (Prevents Granary as well as Allows Granary)

2014-01-03 Thread Jacob Nevins
Update of bug #21424 (project freeciv): Dependency Removed: = bugs #21417 ___ Reply to this item at: http://gna.org/bugs/?21424 ___ Message sent

[Freeciv-Dev] [bug #21417] Requirement 'present' / 'negated' field for effects never sent to client

2014-01-03 Thread Jacob Nevins
Update of bug #21417 (project freeciv): Summary: Requirement 'present' / 'negated' field never sent to client = Requirement 'present' / 'negated' field for effects never sent to client ___ Follow-up Comment #2: This only

[Freeciv-Dev] [bug #21115] [metaticket] Negated requirements for effects ('negated'=TRUE, 'present'=FALSE) do not work

2014-01-03 Thread Jacob Nevins
Follow-up Comment #9, bug #21115 (project freeciv): All fair enough. Now I've realised the impact of bug #21417 was less than I thought, it's more plausible that we don't need the client/server compatibility check. (FWIW, I've reproduced the original issue of this ticket with Tile_Workable with

[Freeciv-Dev] [bug #21115] [metaticket] Negated requirements for effects ('negated'=TRUE, 'present'=FALSE) do not work

2014-01-03 Thread Jacob Nevins
Update of bug #21115 (project freeciv): Assigned to: jtn = None ___ Reply to this item at: http://gna.org/bugs/?21115 ___ Message sent

[Freeciv-Dev] [bug #21115] [metaticket] Negated requirements ('negated'=TRUE, 'present'=FALSE) do not work reliably

2014-01-03 Thread Jacob Nevins
Update of bug #21115 (project freeciv): Summary: [metaticket] Negated requirements for effects ('negated'=TRUE, 'present'=FALSE) do not work = [metaticket] Negated requirements ('negated'=TRUE, 'present'=FALSE) do not work reliably

[Freeciv-Dev] [bug #21417] Requirement 'present' / 'negated' field for effects never sent to client

2014-01-03 Thread Jacob Nevins
Follow-up Comment #3, bug #21417 (project freeciv): Per discussion in patch #4400 Patch #4401, doh. ___ Reply to this item at: http://gna.org/bugs/?21417 ___ Message sent via/by Gna!

[Freeciv-Dev] [bug #21425] Correct display of city output bonuses in the presence of negated requirements

2014-01-03 Thread Jacob Nevins
Follow-up Comment #1, bug #21425 (project freeciv): If nreqs are used for this instead (as is conventional in effects.ruleset), the American clause doesn't appear at all, so old code didn't display misleading information and behaviour after this patch is no different. nreqs and present=FALSE are

[Freeciv-Dev] [bug #21430] Ignore negated requirements in client improvement prerequisites

2014-01-03 Thread Jacob Nevins
URL: http://gna.org/bugs/?21430 Summary: Ignore negated requirements in client improvement prerequisites Project: Freeciv Submitted by: jtn Submitted on: Fri Jan 3 15:20:53 2014 Category: client Severity:

[Freeciv-Dev] [bug #21430] Ignore negated requirements in client improvement prerequisites

2014-01-03 Thread Jacob Nevins
Follow-up Comment #1, bug #21430 (project freeciv): (This probably doesn't actually bite that often, because generally there will be a non-negated requirement and it will likely be the first one.) ___ Reply to this item at:

[Freeciv-Dev] [bug #21430] Ignore negated requirements in client improvement prerequisites help

2014-01-03 Thread Jacob Nevins
Update of bug #21430 (project freeciv): Summary: Ignore negated requirements in client improvement prerequisites = Ignore negated requirements in client improvement prerequisites help ___ Reply to this item at:

[Freeciv-Dev] [bug #21431] Improvement requirements help deficiencies

2014-01-03 Thread Jacob Nevins
URL: http://gna.org/bugs/?21431 Summary: Improvement requirements help deficiencies Project: Freeciv Submitted by: jtn Submitted on: Fri Jan 3 15:24:04 2014 Category: client Severity: 3 - Normal

[Freeciv-Dev] [bug #21427] Nationset rule_name mandatory

2014-01-03 Thread Jacob Nevins
Follow-up Comment #1, bug #21427 (project freeciv): Hm. I'm not sure what I was thinking (it's been a long time) but I'm guessing that I wanted to encourage people providing nation sets to provide all of: 0 a short, machine-friendly name (all) to go in the setting (no spaces or apostrophes or

[Freeciv-Dev] [bug #21427] Nationset rule_name mandatory

2014-01-03 Thread Jacob Nevins
Update of bug #21427 (project freeciv): Planned Release: = 2.5.0,2.6.0 ___ Reply to this item at: http://gna.org/bugs/?21427 ___ Message sent

[Freeciv-Dev] [bug #21430] Ignore negated requirements in client improvement prerequisites help

2014-01-03 Thread Jacob Nevins
Follow-up Comment #2, bug #21430 (project freeciv): (The first patch for bug #21425 -- file #19630 -- addresses this by adding a ! in front, so !Construction would be displayed if no-Construction was the first req -- but I won't be taking that patch forward.)

[Freeciv-Dev] [bug #21115] [metaticket] Negated requirements ('negated'=TRUE, 'present'=FALSE) do not work reliably

2014-01-03 Thread Jacob Nevins
Update of bug #21115 (project freeciv): Depends on: = bugs #21430 ___ Reply to this item at: http://gna.org/bugs/?21115 ___ Message sent

[Freeciv-Dev] [bug #21432] Handle negated improvement requirements in freeciv-manual

2014-01-03 Thread Jacob Nevins
URL: http://gna.org/bugs/?21432 Summary: Handle negated improvement requirements in freeciv-manual Project: Freeciv Submitted by: jtn Submitted on: Fri Jan 3 15:49:42 2014 Category: None Severity: 2 -

[Freeciv-Dev] [bug #21115] [metaticket] Negated requirements ('negated'=TRUE, 'present'=FALSE) do not work reliably

2014-01-03 Thread Jacob Nevins
Update of bug #21115 (project freeciv): Depends on: = bugs #21432 ___ Reply to this item at: http://gna.org/bugs/?21115 ___ Message sent

[Freeciv-Dev] [bug #21431] Improvement requirements help deficiencies

2014-01-03 Thread Jacob Nevins
Update of bug #21431 (project freeciv): Depends on: = bugs #21430 ___ Reply to this item at: http://gna.org/bugs/?21431 ___ Message sent

[Freeciv-Dev] [bug #21433] SDL client help segfaults in ruleset with non-tech building prerequisites (e.g. civ2civ3)

2014-01-03 Thread Jacob Nevins
URL: http://gna.org/bugs/?21433 Summary: SDL client help segfaults in ruleset with non-tech building prerequisites (e.g. civ2civ3) Project: Freeciv Submitted by: jtn Submitted on: Fri Jan 3 16:40:58 2014 Category:

[Freeciv-Dev] [bug #21431] Improvement requirements help deficiencies

2014-01-03 Thread Jacob Nevins
Update of bug #21431 (project freeciv): Depends on: = bugs #21433 ___ Reply to this item at: http://gna.org/bugs/?21431 ___ Message sent

[Freeciv-Dev] [patch #4399] Reqtree colours for goal set to tech with root req

2014-01-03 Thread Marko Lindqvist
Follow-up Comment #1, patch #4399 (project freeciv): New version for S2_5 (other branches coming up later when dependency patches are ok) - Fixed goal requirement techs to be marked as such even if they themselves have root req. (file #19635)

[Freeciv-Dev] [bug #21404] i can't get selected cities to celebrate

2014-01-03 Thread Jacob Nevins
Follow-up Comment #3, bug #21404 (project freeciv): I assume the relevant cities are Xihe, Yin, and Coburg. Looking at them, I believe no celebration is to be expected. In each of these cities of size 3 there is 1 happy, 1 content, and 1 entertainer citizen. According to the help, Cities that

[Freeciv-Dev] [bug #21143] send_unit_info_to_onlookers() puts huge positive or negative values to 8 bits

2014-01-03 Thread Jacob Nevins
Update of bug #21143 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4384] Always initialise all fields of unit orders on client

2014-01-03 Thread Jacob Nevins
Update of patch #4384 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #21412] Connect-with-road etc path can't be reviewed with middle-click

2014-01-03 Thread Jacob Nevins
Update of bug #21412 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4400] Tidy up requirement descriptions

2014-01-03 Thread Jacob Nevins
Update of patch #4400 (project freeciv): Depends on: = patch #3841 ___ Reply to this item at: http://gna.org/patch/?4400 ___ Message sent

[Freeciv-Dev] [patch #3841] Add strings for negated requirements

2014-01-03 Thread Jacob Nevins
Update of patch #3841 (project freeciv): Assigned to: cazfi = jtn Open/Closed: Closed = Open Planned Release: 2.5.0 = 2.4.2,2.5.0

[Freeciv-Dev] [patch #3841] Add strings for negated requirements

2014-01-03 Thread Marko Lindqvist
Follow-up Comment #3, patch #3841 (project freeciv): At least notify i18n list so those who have already translated those strings in S2_5 know to consider merge from there. Is there more we can do to ease that? ___ Reply to this item at:

[Freeciv-Dev] [bug #21419] Conjunctive requirement sanity checking applied to disjunctive building obsolete_by list

2014-01-03 Thread Jacob Nevins
Update of bug #21419 (project freeciv): Status: In Progress = Ready For Test Planned Release: = 2.4.2,2.5.0,2.6.0 ___ Additional Item Attachment: File name:

[Freeciv-Dev] [bug #21421] Effects sanity checking prohibits valid multiple-nation requirements

2014-01-03 Thread Jacob Nevins
Update of bug #21421 (project freeciv): Status: In Progress = Ready For Test Planned Release: = 2.4.2,2.5.0,2.6.0 ___ Additional Item Attachment: File name:

[Freeciv-Dev] [bug #21418] Ruleset loading requirement validity check relies on information not yet loaded

2014-01-03 Thread Jacob Nevins
Update of bug #21418 (project freeciv): Status: In Progress = Ready For Test Planned Release: = 2.4.2,2.5.0,2.6.0 ___ Additional Item Attachment: File name:

[Freeciv-Dev] [bug #21422] Bugs in Alliance-ranged wonder requirements

2014-01-03 Thread Jacob Nevins
Update of bug #21422 (project freeciv): Status: In Progress = Ready For Test ___ Reply to this item at: http://gna.org/bugs/?21422 ___ Message sent

[Freeciv-Dev] [bug #21423] AI want uses uninitialised memory with Alliance-ranged improvements

2014-01-03 Thread Jacob Nevins
Update of bug #21423 (project freeciv): Status: In Progress = Ready For Test ___ Reply to this item at: http://gna.org/bugs/?21423 ___ Message sent

[Freeciv-Dev] [bug #21417] Requirement 'present' / 'negated' field for effects never sent to client

2014-01-03 Thread Jacob Nevins
Update of bug #21417 (project freeciv): Status: In Progress = Ready For Test Planned Release: = 2.4.2,2.5.0,2.6.0 ___ Additional Item Attachment: File name:

[Freeciv-Dev] [patch #4396] Check validity of 'survives' requirement field

2014-01-03 Thread Jacob Nevins
Update of patch #4396 (project freeciv): Status: In Progress = Ready For Test Planned Release: = 2.4.2,2.5.0,2.6.0 ___ Additional Item Attachment: File name:

[Freeciv-Dev] [bug #21424] Handle negated requirements in client improvement help (Prevents Granary as well as Allows Granary)

2014-01-03 Thread Jacob Nevins
Update of bug #21424 (project freeciv): Status: In Progress = Ready For Test Planned Release: = 2.4.2,2.5.0,2.6.0 ___ Additional Item Attachment: File name:

[Freeciv-Dev] [bug #21425] Correct display of city output bonuses in the presence of negated requirements

2014-01-03 Thread Jacob Nevins
Update of bug #21425 (project freeciv): Status: In Progress = Ready For Test Planned Release: = 2.4.2,2.5.0,2.6.0 ___ Follow-up Comment #2: New, much simpler

[Freeciv-Dev] [bug #21430] Ignore negated requirements in client improvement prerequisites help

2014-01-03 Thread Jacob Nevins
Update of bug #21430 (project freeciv): Status: In Progress = Ready For Test Planned Release: = 2.4.2,2.5.0,2.6.0 ___ Additional Item Attachment: File name:

[Freeciv-Dev] [bug #21432] Handle negated improvement requirements in freeciv-manual

2014-01-03 Thread Jacob Nevins
Update of bug #21432 (project freeciv): Status: In Progress = Ready For Test Planned Release: = 2.4.2,2.5.0,2.6.0 ___ Additional Item Attachment: File name:

[Freeciv-Dev] [bug #21433] SDL client help segfaults in ruleset with non-tech building prerequisites (e.g. civ2civ3)

2014-01-03 Thread Jacob Nevins
Update of bug #21433 (project freeciv): Status: In Progress = Ready For Test Planned Release: = 2.4.2,2.5.0,2.6.0 ___ Additional Item Attachment: File name:

[Freeciv-Dev] [patch #4375] Extra rmreqs

2014-01-03 Thread Marko Lindqvist
Update of patch #4375 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [patch #4403] Requirements sanity checking for extra rmcauses

2014-01-03 Thread Jacob Nevins
URL: http://gna.org/patch/?4403 Summary: Requirements sanity checking for extra rmcauses Project: Freeciv Submitted by: jtn Submitted on: Sat Jan 4 01:01:31 2014 Category: None Priority: 5 - Normal

[Freeciv-Dev] [patch #4403] Requirements sanity checking for extra rmcauses

2014-01-03 Thread Jacob Nevins
Update of patch #4403 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-extra-rmcauses-sanity.patch Size:0 KB

[Freeciv-Dev] [patch #4400] Tidy up requirement descriptions

2014-01-03 Thread Jacob Nevins
Follow-up Comment #1, patch #4400 (project freeciv): Newer version fixing more issues. Still not a commit candidate. (file #19661) ___ Additional Item Attachment: File name: trunk-rework-req-descs-bis.patch Size:67 KB

[Freeciv-Dev] [bug #20030] Amplio2 missing civ2civ3 wonder gfx

2014-01-03 Thread Marko Lindqvist
Update of bug #20030 (project freeciv): Planned Release: 2.5.0 = 2.5.0, 2.6.0 ___ Follow-up Comment #3: gm1530 has posted these to forum: http://forum.freeciv.org/f/viewtopic.php?f=12t=7start=20#p1251

[Freeciv-Dev] [bug #21408] User terrain flags not saved

2014-01-03 Thread Marko Lindqvist
Update of bug #21408 (project freeciv): Status:None = Ready For Test Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [bug #21407] Expansionist AI always evaluates building value to 0

2014-01-03 Thread Marko Lindqvist
Update of bug #21407 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [bug #21427] Nationset rule_name mandatory

2014-01-03 Thread Marko Lindqvist
Follow-up Comment #2, bug #21427 (project freeciv): the potential persistence in settings and server scripts and direct user interaction Ok, thanks for clarifying this. Maybe this ticket could then be resolved by adding more comments to default/nationlist.ruleset about how the rule_name is

[Freeciv-Dev] [bug #21241] Ai does not build Basic Infrastructure building in alien ruleset

2014-01-03 Thread Marko Lindqvist
Update of bug #21241 (project freeciv): Status: In Progress = Duplicate Assigned to:None = cazfi Open/Closed:Open = Closed Planned Release:

[Freeciv-Dev] [bug #21403] Pillaging EF_ALWAYS_ON_CITY_CENTER extras from city centers

2014-01-03 Thread Marko Lindqvist
Follow-up Comment #1, bug #21403 (project freeciv): New TRUNK version - Updated against current svn - Moved EF_ALWAYS_ON_CITY_CENTER check inside can_remove_extra() player_can_remove_extra(). This is logically correct place, and also handles the theoretical case that someone has extra removable

[Freeciv-Dev] [bug #21435] Science report Show All button reversed

2014-01-03 Thread Marko Lindqvist
URL: http://gna.org/bugs/?21435 Summary: Science report Show All button reversed Project: Freeciv Submitted by: cazfi Submitted on: Sat 04 Jan 2014 09:04:51 AM EET Category: client Severity: 3 - Normal

[Freeciv-Dev] [patch #4397] player_invention_reachable() root req reworked

2014-01-03 Thread Marko Lindqvist
Follow-up Comment #1, patch #4397 (project freeciv): As per bug #21435, handling of show_all functionality is a mess with this patch, as it implements parts of the lower level right, where upper level still expects things to be reversed. This affects both Show All button and techtree view of

[Freeciv-Dev] [bug #21428] Number of extras defined by the ruleset (= 8) are lower than the number in the savefile (= 10)

2014-01-03 Thread Marko Lindqvist
Follow-up Comment #1, bug #21428 (project freeciv): Well, I ended making just temporary fix of adding dummy (never occur in game) extras to my ruleset (as the save in question is a scenario file I've been working on, simply leaving it behind isn't an option). Instead of rushing partial solution

[Freeciv-Dev] [bug #21416] Alien ruleset specialists don't have human-friendly names or descriptions

2014-01-03 Thread Marko Lindqvist
Follow-up Comment #1, bug #21416 (project freeciv): At a minimum we should use the standard translateable names (and move the existing tags to rule_name). To continue with our existing policy about Alien ruleset: As long as the change goes to S2_5 too (and does so before 2.5.0-beta1) the new