[Freeciv-Dev] [patch #3804] Enabling restricted air transport

2013-03-28 Thread Emmet Hikory
Follow-up Comment #10, patch #3804 (project freeciv): I've encountered a strangeness during the implementation: a difference in behaviour of unit.c:can_unit_unload() when called from the client and the server. I am using BV_ISSET(unit_type(pcargo)->disembarks, uclass_index(unit_class(ptrans))) to

[Freeciv-Dev] [bug #20664] fcintl.h:71: error

2013-03-28 Thread David Lowe
Follow-up Comment #4, bug #20664 (project freeciv): Yeah, it works. ___ Reply to this item at: ___ Message sent via/by Gna! http://gna.org/ _

[Freeciv-Dev] [patch #3809] Refer to "classic", not "default", ruleset in README.ruleset_civ2civ3

2013-03-28 Thread Marko Lindqvist
URL: Summary: Refer to "classic", not "default", ruleset in README.ruleset_civ2civ3 Project: Freeciv Submitted by: cazfi Submitted on: Fri 29 Mar 2013 01:59:51 AM EET Category: docs

[Freeciv-Dev] [bug #20628] Server crashes when loading saved game on wrong ruleset

2013-03-28 Thread Marko Lindqvist
Update of bug #20628 (project freeciv): Status:None => Invalid Assigned to:None => cazfi Open/Closed:Open => Closed _

[Freeciv-Dev] [bug #20577] new parameter gameloss_style in game.ruleset

2013-03-28 Thread Marko Lindqvist
Follow-up Comment #20, bug #20577 (project freeciv): - Added cleartext names for values to be used in ruleset - Added gameloss_style entries to rulesets, with comments documenting it - More minor style fixes - Detect the case when there's more tokens in ruleset than maximum handled - Do not log "E

[Freeciv-Dev] [bug #20655] Hydro Plant & Hoover depend on River special, not road type

2013-03-28 Thread Marko Lindqvist
Update of bug #20655 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed _

[Freeciv-Dev] [bug #20621] Scorelog continuing failure

2013-03-28 Thread Marko Lindqvist
Update of bug #20621 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed _

[Freeciv-Dev] [bug #20648] Old road building activities considered real

2013-03-28 Thread Marko Lindqvist
Update of bug #20648 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed _

[Freeciv-Dev] [bug #20599] Boolean sounding name "is_blended" for integer field

2013-03-28 Thread Marko Lindqvist
Update of bug #20599 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed _

[Freeciv-Dev] [bug #20675] Caravan ferry need determined from homecity, not current location

2013-03-28 Thread Marko Lindqvist
URL: Summary: Caravan ferry need determined from homecity, not current location Project: Freeciv Submitted by: cazfi Submitted on: Thu 28 Mar 2013 06:10:25 PM EET Category: ai S

[Freeciv-Dev] [patch #3804] Enabling restricted air transport

2013-03-28 Thread Marko Lindqvist
Follow-up Comment #9, patch #3804 (project freeciv): No apologies needed (if not from my part). I just wanted to make sure everyone, including lurkers, has the same understanding that alien ruleset was used as an example only. ___ Reply to

[Freeciv-Dev] [patch #3804] Enabling restricted air transport

2013-03-28 Thread Emmet Hikory
Follow-up Comment #8, patch #3804 (project freeciv): Great. Thanks for the confirmation. As for the examples from the Alien ruleset: my apologies if I implied such changes should be made. I selected it as an example only because it has two different semantics for unreachable units as well as a

[Freeciv-Dev] [patch #3804] Enabling restricted air transport

2013-03-28 Thread Marko Lindqvist
Follow-up Comment #7, patch #3804 (project freeciv): I think that's enough for now. No point in using more resources to this when we don't know if anybody is ever going to use it. We can rework it if users express huge demand for improved version. As for Burrow Tubes example, in addition to being

[Freeciv-Dev] [patch #3808] Fast units avoid autoattack

2013-03-28 Thread Emmet Hikory
Follow-up Comment #3, patch #3808 (project freeciv): My apologies: I misunderstood the intent. My concern is that I would like autoattack to do *something*, even slow units autoattacking fast units. Not having autoattack happen mid-turn before the attacking unit actually attacks improves the tac

[Freeciv-Dev] [patch #3804] Enabling restricted air transport

2013-03-28 Thread Emmet Hikory
Follow-up Comment #6, patch #3804 (project freeciv): Heh, if you're happy with a less complex patch even if it's not known to be correct for any imagined use cases, that makes it relatively easy. I'll implement with two bitvectors (embark, disembark) that work like targets, and in wipe_unit just

[Freeciv-Dev] [bug #20567] Lua random() not really random

2013-03-28 Thread Marko Lindqvist
Follow-up Comment #9, bug #20567 (project freeciv): > wanted players to study in advance I was that close to commit my patch when it sink in that this use-case might be the reason startposition assignment has not been using mapseed. While you may want terrain to be known to everyone, at the same

[Freeciv-Dev] [bug #20567] Lua random() not really random

2013-03-28 Thread Marko Lindqvist
Follow-up Comment #8, bug #20567 (project freeciv): > if the mapseed triggered a retry. Note that there's retry only if random mapseed is requested in the first place. No point in retrying with same set seed. If user explicitly set mapseed, (s)he probably did it for a reason and providing map wit

[Freeciv-Dev] [bug #20667] Setting value savegame handling not prepared for compatibility handling

2013-03-28 Thread Marko Lindqvist
Update of bug #20667 (project freeciv): Category:None => general Status:None => Fixed Assigned to:None => cazfi Open/Closed:

[Freeciv-Dev] [bug #20669] Missing migration from old killcitizen value

2013-03-28 Thread Marko Lindqvist
URL: Summary: Missing migration from old killcitizen value Project: Freeciv Submitted by: cazfi Submitted on: Thu 28 Mar 2013 12:39:30 PM EET Category: general Severity: 3 - Nor

[Freeciv-Dev] [bug #20667] Setting value savegame handling not prepared for compatibility handling

2013-03-28 Thread Marko Lindqvist
Follow-up Comment #2, bug #20667 (project freeciv): Thanks, I somehow missed that even though settings loading is not done in savegame2.c, they still go through compat conversions. And for settings the conversions should be simple enough that there's no problems often associated with making compl

[Freeciv-Dev] [bug #20667] Setting value savegame handling not prepared for compatibility handling

2013-03-28 Thread Jacob Nevins
Follow-up Comment #1, bug #20667 (project freeciv): These days I would migrate settings in the functions called from sg_load_compat(). See for instance compat_load_020400() (start at /* Server setting migration. */), which migrates pre-2.4 saveturns to saveturns+autosaves. (However, that point in

[Freeciv-Dev] [patch #3808] Fast units avoid autoattack

2013-03-28 Thread Marko Lindqvist
Follow-up Comment #2, patch #3808 (project freeciv): The problem I'm trying to find answer with this patch relates to turn-based nature of freeciv, not to combat abilities of the units. That is, autoattack should not happen when it's still turn of the approaching unit. You should consider the rea

[Freeciv-Dev] [patch #3804] Enabling restricted air transport

2013-03-28 Thread Marko Lindqvist
Follow-up Comment #5, patch #3804 (project freeciv): > Unfortunately, without the certain knowledge that the model is > of vertical separation with only intervening air, this isn't > enough. It certainly does not allow just anything, but I think it has good feature enabling / complexity ratio. Yo

[Freeciv-Dev] [patch #3808] Fast units avoid autoattack

2013-03-28 Thread Emmet Hikory
Follow-up Comment #1, patch #3808 (project freeciv): Rather than being an absolute measure of the ability of the threatening unit to get away, could this be a measure of difference between threatening unit and auto-attacking unit? For example, in the default ruleset, untired Horsemen should clear

[Freeciv-Dev] [patch #3804] Enabling restricted air transport

2013-03-28 Thread Emmet Hikory
Follow-up Comment #4, patch #3804 (project freeciv): Yes, more abstraction makes sense, and certainly expands the range of what ruleset authors would be able to do. is_flying_unit() and is_flying_unit_class() are clearly not in the spirit of gen_move. dai_choose_attacker_air() would need to r

[Freeciv-Dev] [bug #20652] Homeless ai caravan crash

2013-03-28 Thread Marko Lindqvist
Update of bug #20652 (project freeciv): Category:None => ai Status:None => In Progress Planned Release: => 2.3.5, 2.4.0, 2.5.0 Summary: d