[Freeciv-Dev] [patch #4970] Better path-finding reverse maps

Follow-up Comment #3, patch #4970 (project freeciv): I prefer symbols to magic numbers, but agree -1 isn't PF_IMPOSSIBLE_MC in this case. Thanks for the explanation on attack cost. Everything else in this patch looked good, so please consider me not to have objected at all.

[Freeciv-Dev] [bug #22381] Inconsistent nativity limits on source tile for regular attacks

Follow-up Comment #1, bug #22381 (project freeciv): This is a bit complicated. For the source tile in unit_attack_unit_at_tile_result(), changing to can_exist_at_tile() would be better. For the destination tile, we may need a new test (or to refactor the existing ones), because UTYF_TRIREME unit

[Freeciv-Dev] [bug #22374] Civ2Civ3 ruleset enforces restricted infrastructure setting on rivers

Follow-up Comment #4, bug #22374 (project freeciv): This leads to an interesting question: should restrictinfra affect nativity? A similar class of issue would be BigLand units being able to move on roaded Mountains (at high cost) despite restrictinfra. __

[Freeciv-Dev] [patch #4966] civ2civ3: maglev

Update of patch #4966 (project freeciv): Status: Ready For Test => Done Assigned to:None => persia Open/Closed:Open => Closed

[Freeciv-Dev] [patch #4812] civ2civ3: increased fuel of air units

Update of patch #4812 (project freeciv): Status: Ready For Test => Done Assigned to:None => persia Open/Closed:Open => Closed

[Freeciv-Dev] [bug #22374] Civ2Civ3 ruleset enforces restricted infrastructure setting on rivers

Update of bug #22374 (project freeciv): Status:None => Wont Fix Open/Closed:Open => Closed Planned Release:2.5.0, 2.6.0 => __

[Freeciv-Dev] [bug #22381] Inconsistent nativity limits on source tile for regular attacks

Follow-up Comment #3, bug #22381 (project freeciv): That the source tile isn't checking can_exist_at_tile() now is an oversight (and a bug). I'm unsure of the right solution for the destination tile though. Should the source bug just be fixed, and we can discuss the destination more? Should can

[Freeciv-Dev] [bug #22381] Inconsistent nativity limits on source tile for regular attacks

Update of bug #22381 (project freeciv): Status: In Progress => None Assigned to:sveinung => None ___ Follow-up Comment #6: I wrote the source

[Freeciv-Dev] [patch #4885] Revised logic for AI improvement consideration and improvement redundancy

Follow-up Comment #4, patch #4885 (project freeciv): New strategy, informed by IRC discussion: 1) AI callers of is_effect_prevented() and is_improvement_redundant() to use new daieffects facility to determine if an improvement provides any currently useful feature (units, extras, disaster protect

[Freeciv-Dev] [patch #4987] Replace UI concept "Redundant" with current utility indicator

URL: Summary: Replace UI concept "Redundant" with current utility indicator Project: Freeciv Submitted by: persia Submitted on: Sat 26 Jul 2014 07:04:42 AM JST Category: client

[Freeciv-Dev] [patch #4988] Always allow selected reqs to be met with nulls

URL: Summary: Always allow selected reqs to be met with nulls Project: Freeciv Submitted by: persia Submitted on: Sat 26 Jul 2014 08:12:39 AM JST Category: general Priority: 5 -

[Freeciv-Dev] [patch #4989] Use universal_fulfills for immune government test

URL: Summary: Use universal_fulfills for immune government test Project: Freeciv Submitted by: persia Submitted on: Sat 26 Jul 2014 08:21:18 AM JST Category: general Priority: 5

[Freeciv-Dev] [patch #4990] Consider improvement side effects other than buildable units

URL: Summary: Consider improvement side effects other than buildable units Project: Freeciv Submitted by: persia Submitted on: Sat 26 Jul 2014 10:24:21 AM JST Category: general

[Freeciv-Dev] [patch #4885] Revised logic for AI improvement consideration and improvement redundancy

Update of patch #4885 (project freeciv): Status: In Progress => Ready For Test ___ Follow-up Comment #5: And a new pair of patches for this. These patches are independent of each other, but are both

[Freeciv-Dev] [patch #4885] Revised logic for AI improvement consideration and improvement redundancy

Update of patch #4885 (project freeciv): Depends on: => patch #4990 ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [patch #4987] Replace UI concept "Redundant" with current utility indicator

Update of patch #4987 (project freeciv): Status:None => In Progress Assigned to:None => persia ___ Reply to this item at:

[Freeciv-Dev] [patch #4987] Replace UI concept "Redundant" with current utility indicator

Update of patch #4987 (project freeciv): Depends on: => patch #4885 ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [patch #4990] Consider improvement side effects other than buildable units

Follow-up Comment #1, patch #4990 (project freeciv): Seems I failed to use the new functions everywhere: updated patch with more consistent implementation for the allows_extras tests. (file #21561) ___ Additional Item Attachment: File name

[Freeciv-Dev] [bug #14210] optionally include advance benefits in output message

Follow-up Comment #5, bug #14210 (project freeciv): Another rebase of the patch, this time to go over patches #4889 and #4990, and use the semantics enabled there. As a side effect, no longer advertises available stuff just because the discovered technologies don't block it. Still incomplete. (

[Freeciv-Dev] [patch #4988] Always allow selected reqs to be met with nulls

Follow-up Comment #2, patch #4988 (project freeciv): The problem with returning TRI_MAYBE is that the various tests the AI uses to determine if a requirement is really active right now all check with RPT_CERTAIN and NULL target_output. If VUT_OTYPE sets eval to TRI_MAYBE in this situation, the re

[Freeciv-Dev] [patch #4988] Always allow selected reqs to be met with nulls

Follow-up Comment #4, patch #4988 (project freeciv): Yes, this stomps all over the meaning of "RPT_CERTAIN": on the unit side, it's just a generalisation of an existing hack, but the addition of OutputType and Specialist make it more glaringly obvious that the hack is to support a feature we don't

[Freeciv-Dev] [patch #4991] Use dai_can_requirement_be_met_in_city in dai_wants_defender_against

URL: Summary: Use dai_can_requirement_be_met_in_city in dai_wants_defender_against Project: Freeciv Submitted by: persia Submitted on: Sat 26 Jul 2014 07:56:38 PM JST Category: ai

[Freeciv-Dev] [patch #4991] Use dai_can_requirement_be_met_in_city in dai_wants_defender_against

Update of patch #4991 (project freeciv): Depends on: => patch #4885 ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [patch #4992] Extend insert_allows in helpdata.c

URL: Summary: Extend insert_allows in helpdata.c Project: Freeciv Submitted by: persia Submitted on: Sun 27 Jul 2014 08:17:10 AM JST Category: client Priority: 5 - Normal

[Freeciv-Dev] [patch #4988] Always allow selected reqs to be met with nulls

Update of patch #4988 (project freeciv): Status: Ready For Test => None Assigned to: persia => None Planned Release: 2.6.0 => _

[Freeciv-Dev] [patch #4989] Use universal_fulfills for immune government test

Follow-up Comment #1, patch #4989 (project freeciv): More testing shows that while the prior patch worked when it was supposed to work, it also worked when it wasn't supposed to work. The attached patch actually tests the government value in government_found, rather than just whether we are looki

[Freeciv-Dev] [patch #4993] Add improvement obsoletes improvement helptext

URL: Summary: Add improvement obsoletes improvement helptext Project: Freeciv Submitted by: persia Submitted on: Sun 27 Jul 2014 10:17:59 PM JST Category: client Priority: 5 - N

[Freeciv-Dev] [patch #4885] Revised logic for AI improvement consideration and improvement redundancy

Follow-up Comment #6, patch #4885 (project freeciv): Rebased improve-Ai-inspection-of-effects-requirement-vectors.patch over r25732 (patch #4983), added implementations for VUT_SPECIALIST and VUT_NATIONALITY, and added recursion to the VUT_IMPROVEMENT check to avoid believing an improvement that d

[Freeciv-Dev] [patch #4885] Revised logic for AI improvement consideration and improvement redundancy

Follow-up Comment #7, patch #4885 (project freeciv): Pulled back some of the changes in draft revisions for patch #4987 which would also be applicable to the AI into replace-AI-uses-of-is_improvement_redundant.patch: update attached. (file #21569) _

[Freeciv-Dev] [patch #4990] Consider improvement side effects other than buildable units

Follow-up Comment #2, patch #4990 (project freeciv): Testing this more with for patch #4987 shows that improvementhas_side_effects() almost never returns TRUE with conjunctive logic, and that the function should really check if ANY side effect is available, rather than if ALL side effects are avai

[Freeciv-Dev] [patch #4987] Replace UI concept "Redundant" with current utility indicator

Follow-up Comment #1, patch #4987 (project freeciv): Not a commit candidate (needs better helptext), but a first pass at the non-helptext code changes involved. (file #21571) ___ Additional Item Attachment: File name: replace-client-uses-o

[Freeciv-Dev] [patch #4987] Replace UI concept "Redundant" with current utility indicator

Update of patch #4987 (project freeciv): Depends on: => patch #4992 ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [patch #4992] Extend insert_allows in helpdata.c

Update of patch #4992 (project freeciv): Status: Ready For Test => In Progress ___ Follow-up Comment #1: Unfortunately, this interacts really badly with advance help. While the information provided b

[Freeciv-Dev] [patch #4995] Make the source tile limit on spy actions a hard action enabler requirement

Follow-up Comment #3, patch #4995 (project freeciv): On reflection, I'm not sure that my use of "tool" is semantically ideal there. Perhaps "faculties" or "facilities" would have been better. Generally speaking, I believe a tool to be anything that when used, eases a task, but I suspect narrower

[Freeciv-Dev] [patch #4830] Multipliers to effects

Follow-up Comment #29, patch #4830 (project freeciv): In multipliers.c: do multipliers, multiplier_count, and multiplier_used need the "static" keyword? I had thought this was necessary for persistent variables defined at file scope. In handle_ruleset_multiplier(), is there a reason to use get_m

[Freeciv-Dev] [patch #4995] Make the source tile limit on spy actions a hard action enabler requirement

Follow-up Comment #6, patch #4995 (project freeciv): On English: have no worries. If your meaning is clear, that is sufficient. If my meaning is unclear, feel free to ask for clarification (I use English as my primary language, but do not claim that my usage matches any accepted norms). If you'

[Freeciv-Dev] [patch #4989] Use universal_fulfills for immune government test

Update of patch #4989 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4885] Revised logic for AI improvement consideration and improvement redundancy

Update of patch #4885 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4990] Consider improvement side effects other than buildable units

Update of patch #4990 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4993] Add improvement obsoletes improvement helptext

Update of patch #4993 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4991] Use dai_can_requirement_be_met_in_city in dai_wants_defender_against

Update of patch #4991 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #5000] Remove obsolete move_cost constants

URL: Summary: Remove obsolete move_cost constants Project: Freeciv Submitted by: persia Submitted on: Wed 30 Jul 2014 09:45:56 AM JST Category: general Priority: 5 - Normal

[Freeciv-Dev] [patch #4759] Setting TRUNK for 3.0 development

Follow-up Comment #4, patch #4759 (project freeciv): I like 2.99.99 : it makes the next step obvious to readers. ___ Reply to this item at: ___ Message sent via/

[Freeciv-Dev] [patch #4997] [Metaticket] Get rid of action_enabler_append_hard()

Follow-up Comment #2, patch #4997 (project freeciv): My apologies for any confusion: the *current* AI is omniscient, so there's no increase of want for embassy creation based on other conditions (like relations with the other player, wish to understand the techs / money / map / units of the other

[Freeciv-Dev] [patch #5000] Remove obsolete move_cost constants

Update of patch #5000 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #5006] Suppress "Can build mines on tiles" etc in help based on Mining_Possible, etc

Follow-up Comment #1, patch #5006 (project freeciv): For trunk, using requirement_fulfilled_by_unit() and extension of the relevant requirements vectors can address irrigation, mining, farmland, and road/rail (can this unit mine? If so, can it produce any of the EC_MINE extras?, etc.). Removing

[Freeciv-Dev] [bug #22419] "Airbase" flag not documented as enabling Buoys

Follow-up Comment #1, bug #22419 (project freeciv): For trunk, this has a minor collision with patch #5006, in that if 5006 were implemented in the obvious and generic way, the helptext for the Airbase flag would be removed entirely. Note that 5006 needs to touch these lines regardless of whether

[Freeciv-Dev] [bug #22417] civ2civ3 Transport can build mines in coastal cities, etc

Follow-up Comment #7, bug #22417 (project freeciv): On trunk, one can prevent Transports cleaning Pollution in cities by adjusting rmreqs{} for the extra. I don't know of a way to do the equivalent for 2.5. For preventing Transports from doing stuff, adding `"UnitClass", "Sea", "Local", FALSE`

[Freeciv-Dev] [patch #5014] "Industrial Accident" disaster

Follow-up Comment #1, patch #5014 (project freeciv): Could this also be added to experimental, if added to classic? ___ Reply to this item at: ___ Message sent v

<    2   3   4   5   6   7