[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #22, patch #1188 (project freeciv): Understood, thanks Marko. I wasn't sure what to check in order to follow your request on the dev list. I'll first check that link in the future. ___ Reply to this item at:

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #21, patch #1188 (project freeciv): Since results of update-po benefit only translators, I have not been committing them to Freeciv svn every time. Instead I make them available for translators at http://www.cazfi.net/freeciv/translations/ __

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #20, patch #1188 (project freeciv): Cool, thanks Marko! It feels cool to have my first patch integrated into Freeciv... I wasn't sure if you were going to wait to run "update-po" until after committing the patches for the other clients (#1211, #1212, #1213). But the four patch

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Update of patch #1188 (project freeciv): Status: In Progress => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #18, patch #1188 (project freeciv): Hi, Marko and Matthias. Thank you both again for taking time to review my patches and for your comments. I've created a new patch, which rolls both stages into a single patch. (I figured that this was less confusing than trying to keep the me

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #17, patch #1188 (project freeciv): > I use the new menu structure. It is a little bit strange first - I expect tax setting in the game menu. Speaking of my incorporating feedback, I'd definitely like to take the opportunity to learn your other feelings. This first round was ve

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #16, patch #1188 (project freeciv): > I use the new menu structure. It is a little bit strange first - I expect tax setting in the game menu. I can understand the initial confusion. I'd agree to an extent, since I myself am still not sure this is the most optimal structure - bu

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #15, patch #1188 (project freeciv): I use the new menu structure. It is a little bit strange first - I expect tax setting in the game menu. One message I get: > Can't set sensitivity for non-existent menu /Civilization/Tax Rates. It is repeated quit often for the client.

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #14, patch #1188 (project freeciv): I'd like to hear third opinion. If we don't get one and there's only my opinion against your opinion, let's go with lesser change - keep it as it is in your existing patch. ___ Reply to

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #13, patch #1188 (project freeciv): Hi, Marko. Just wanted to check whether you still wanted me to modify the menu order, or if you were okay with the order as in my patches. As I said earlier, I'm happy to make your requested modifications now. As I mentioned below, my rationa

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #12, patch #1188 (project freeciv): I just submitted patches for the other clients: * patch #1211: SDL * patch #1212: Windows native * patch #1213: XAW These three bring the same changes to other clients as the files in this patch: * file #6194: (apply first) menu.c.01_reorg.di

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #11, patch #1188 (project freeciv): OK, I'll get patches together and put each one in a separate ticket, so that they can be reviewed independently. > - "Civilization" has general settings affecting your whole > civilization, yet it is next to last menu. I would move it > secon

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #10, patch #1188 (project freeciv): > I could have those three patches for this weekend; > Would that help get these changes in for 2.2? Yes. I'd like to hear more opinions if this restructuring goes to correct direction, but if nobody complains we can only assume that everybo

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #9, patch #1188 (project freeciv): Excuse me, I must have a tired brain. I meant "2.2" where I wrote "2.1" in my previous comment... i.e. hoping to get these changes into 2.2 before it's branched. ___ Reply to this item

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #8, patch #1188 (project freeciv): Wow, Marco. Thanks for the willingness to experiment! I definitely understand and respect not wanting to make different key usage in different clients. I tried to make these changes logical and at the same time not too disruptive (I don't thi

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #7, patch #1188 (project freeciv): > (necessary) refinements ^^^ Drat, I was planning to commit menu restructuring now (well, I have not yet even investigated or tested the code, but I'm sure we can make it acceptable) and postpone accelerator changes. Problem with

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #6, patch #1188 (project freeciv): Glad to hear the patches worked for you, Marko! I had split the patch into two patches in order to avoid "noise" created by the renaming. That makes it possible to see the basic restructuring ("menu.c.01_reorg.diff") and the (necessary) refine

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Update of patch #1188 (project freeciv): Category:None => client-gtk-2.0 Status:None => In Progress Assigned to:None => cazfi

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #4, patch #1188 (project freeciv): I tested it - the patches applay fine. I like the split of the unit commands into 'Unit', 'Work' and 'Combat'. I only use the standard keys so I can't say something bout the key selection. The default keys are the expected ... _

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #3, patch #1188 (project freeciv): Huh, that's odd. menu.c hasn't changed since I made the patches. Maybe I made an error? Which patch doesn't work? Did you apply them in order? ("menu.c.01_reorg.diff", "menu.c.02_accels_revised.diff", then "helpdata.txt.diff") "menu.c.02_acce

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #2, patch #1188 (project freeciv): This patch does not apply cleanly to current menu.c ___ Reply to this item at: ___ Message sent via/by Gna!

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

Follow-up Comment #1, patch #1188 (project freeciv): Oops - already a fix... "menu.c.02_accels_revised.diff" replaces "menu.c.02_accels.diff" The previous version of the patch didn't correctly set the sensitivity of "Unload All From Transporter". As long as I'm here, here's the bulleted list c

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

URL: Summary: proposed menu and command key revamp Project: Freeciv Submitted by: jkeller Submitted on: Saturday 07/11/2009 at 16:56 Category: None Priority: 5 - Normal