Follow-up Comment #1, patch #1701 (project freeciv):
this patch results in an error for me:
make[4]: Entering directory
`/home/matthias/data/git/freeciv.git/client/gui-gtk-2.0'
/bin/sh ../../libtool --preserve-dup-deps --tag=CC --mode=compile gcc
-DHAVE_CONFIG_H -I. -I../.. -I. -I./..
Follow-up Comment #2, patch #1701 (project freeciv):
Well, it works without any macro for me (both on Gentoo with gkt+-2.18.9 and
on Ubuntu with gtk+-2.18.3), but then it works with the GTK_LABEL() macro too
(just tested), so try that one.
Also, please note that I've only tested this on the 2.2
Follow-up Comment #1, patch #1684 (project freeciv):
I did test the patch and it is working as expected. The attached version
includes some coding style fixes.
(file #9301)
___
Additional Item Attachment:
File name:
20100612-01-trunk
Update of patch #1684 (project freeciv):
Status:None = Ready For Test
Assigned to:None = syntron
Planned Release: = 2.3.0
Update of patch #1685 (project freeciv):
Status:None = Ready For Test
Assigned to:None = syntron
Planned Release: = 2.3.0
___
Follow-up Comment #1:
Nice patch! I did move the check for the option
'gui_gtk2_small_display_layout' into the gtk2 client.
(file #9302)
___
Additional Item Attachment:
File name:
20100612-03-trunk-patch
) moves around if one switches the city. How can it be
fixed to start at half the width of the window?
(also update the patch to trunk)
(file #9303)
___
Additional Item Attachment:
File name:
20100612-04-trunk-patch-1687-Move-the-citizen-bar
Update of patch #1688 (project freeciv):
Status:None = Ready For Test
Assigned to:None = syntron
Planned Release: = 2.3.0
___
Follow-up Comment #1:
I did fix some long line to 78 characters but else the patch is fine.
(file #9304)
___
Additional Item Attachment:
File name:
20100612-06-trunk-patch-1689-Reduce-the-width-allocated
Follow-up Comment #3, patch #1701 (project freeciv):
I think file #9300 is the diff for patch #1689. I will now test this patch
with the macro. There should be no other change interfering with this.
___
Reply to this item at:
columns force scrolling.
(file #9305)
___
Additional Item Attachment:
File name:
20100612-07-trunk-patch-1701-Reduce-the-minimum-width-of-the-city-re.patch
Size:4 KB
___
Reply to this item
Follow-up Comment #2, patch #1688 (project freeciv):
Perhaps it would be an idea to add the city dialog as an tab to the main
notebook for such small displays. This would reduce the number of widows
opened ...
___
Reply to this item at:
Follow-up Comment #2, bug #16125 (project freeciv):
I did test it setting ec_turn to 9. The messages are saved in the savegame
file. I do not know, why they are not displayed. The messages are generated
in citytools.c:1497.
(file #9306)
Follow-up Comment #2, patch #1687 (project freeciv):
The problem is the size of the first line and the alignment.
At the moment the city name (+ population + status) moves
around if one switches the city. How can it be fixed to start
at half the width of the window?
This is trivial. If you
Follow-up Comment #3, patch #1688 (project freeciv):
Perhaps it would be an idea to add the city dialog as an tab to
the main notebook for such small displays. This would reduce the
number of widows opened ...
Probably not, as the city dialogue need the full 1024 px width, and not just
the
Follow-up Comment #2, patch #1689 (project freeciv):
I did fix some long line to 78 characters but else the patch is fine.
Ok, I'll try to remember to check for that in the future...
___
Reply to this item at:
Follow-up Comment #3, patch #1687 (project freeciv):
This is trivial.
But it is also that I wanted ;-) This way (city name left aligned in the
right half) it is similar to the previous centered place.
Attaching an updated patch as well as a backport to the 2.2
branch. (The backport is
Follow-up Comment #4, patch #1687 (project freeciv):
As it is a cosmetic change which allows to play freeciv on
netbooks I think this should go into 2.2.2. So no need to patch
your own version anymore ...
Great! Please note that I found a typo in my backport (removed one variable
to much,
); ? =
is_sailing_unit()
- server/unittools.c
= wipe_unit(): save home for undisbandable units (10010)
So 'only_known' is never used ...
If somebody could please check this analysis?
(file #9310)
___
Additional Item Attachment:
File name: 20100612-02-trunk
Follow-up Comment #5, patch #1687 (project freeciv):
Great! Please note that I found a typo in my backport (removed
one variable to much, fixed in the attacked version).
I did also fixed this to do a compile test ...
The line break in the Production progress-bar/drop-down-menu
is imho
Follow-up Comment #5, patch #1701 (project freeciv):
Sorry, it appear I managed to attach the wrong file, but no harm done, as you
managed to create it yourself, based on my description.
Anyway, I applied your patch on a fresh trunk checkout, and tested the result
(on my desktop, but in a
Follow-up Comment #6, patch #1687 (project freeciv):
but it is needed to reduce the size of the production
progressbar (test it with: 'Magellans Expedition (W) [+]
200/400')
Good point, I guess it stays.
Which topology are you using? For topology 3 it is OK.
I'm using topology 5. For me,
Update of patch #1697 (project freeciv):
Assigned to:None = jtn
___
Follow-up Comment #1:
Jacob, I believe you were working on the same thing.
If you don't have time to look at it,
switching to another city
___
File Attachments:
---
Date: Samstag 12.06.2010 um 20:45 Name:
20100612-08-trunk-add-scrolling-bars-to-the-city-map.patch Size: 5kB By:
syntron
http
Update of patch #1702 (project freeciv):
Depends on: = patch #1235
___
Reply to this item at:
http://gna.org/patch/?1702
___
Nachricht
URL:
http://gna.org/patch/?1703
Summary: Nimíipuu (Nez Percé)
Project: Freeciv
Submitted by: kudra
Submitted on: Saturday 06/12/2010 at 20:36
Category: rulesets
Priority: 5 - Normal
26 matches
Mail list logo
