Re: [Freeipa-devel] [PATCH 0031] ipatests: fix the install of external ca

2016-01-27 Thread Martin Basti
On 27.01.2016 11:02, Martin Babinsky wrote: On 01/19/2016 05:56 PM, Milan Kubík wrote: On 01/19/2016 05:31 PM, Milan Kubík wrote: Patch attached. This actually has a ticket opened. Patch with fixed commit message. ;) -- Milan Kubik ACK Pushed to: master: 8f6fb7b4eaa74e9478f946a3be8

Re: [Freeipa-devel] [PATCH 0409] Warn user when ipa *-find reach search limit

2016-01-27 Thread Martin Basti
On 27.01.2016 09:16, Petr Spacek wrote: On 26.1.2016 15:38, Gabe Alford wrote: On Tue, Jan 26, 2016 at 7:33 AM, Martin Basti wrote: On 26.01.2016 15:17, Petr Spacek wrote: On 26.1.2016 15:06, Martin Basti wrote: On 26.01.2016 15:00, Gabe Alford wrote: On Tue, Jan 26, 2016 at 6:56 AM

Re: [Freeipa-devel] [PATCH 0004] Refactor test_attr

2016-01-26 Thread Martin Basti
On 26.01.2016 18:38, Milan Kubík wrote: On 01/12/2016 03:03 PM, Milan Kubík wrote: On 12/07/2015 01:25 PM, Filip Škola wrote: Now the tier marker have lost somewhere on the way... which is corrected in this patch. /me apologizes for the noise F. On Mon, 7 Dec 2015 13:00:41 +0100 Filip Škol

Re: [Freeipa-devel] [PATCH 0003] Refactor test_replace

2016-01-26 Thread Martin Basti
On 26.01.2016 18:37, Milan Kubík wrote: On 01/12/2016 03:04 PM, Milan Kubík wrote: On 12/04/2015 11:29 AM, Filip Škola wrote: On Fri, 4 Dec 2015 10:08:40 +0100 Milan Kubík wrote: On 12/04/2015 10:04 AM, Filip Škola wrote: Hi, sending rather short one this time. F. NACK, UserTracker is

Re: [Freeipa-devel] [PATCH 0011-0012][RFE] ipa-replica-manage: automatically clean dangling RUVs

2016-01-26 Thread Martin Basti
01/22/2016 01:22 PM, Martin Basti wrote: Hello, I have a few comments PATCH Automatically detect and remove dangling RUVs 1) +# get the Directory Manager password +if options.dirman_passwd: +dirman_passwd = options.dirman_passwd +else: +dirman_passwd = installutils.rea

Re: [Freeipa-devel] [PATCH 0409] Warn user when ipa *-find reach search limit

2016-01-26 Thread Martin Basti
On 26.01.2016 15:17, Petr Spacek wrote: On 26.1.2016 15:06, Martin Basti wrote: On 26.01.2016 15:00, Gabe Alford wrote: On Tue, Jan 26, 2016 at 6:56 AM, Martin Basti mailto:mba...@redhat.com>> wrote: On 26.01.2016 14:55, Petr Spacek wrote: On 26.1.2016 14:02, Martin

Re: [Freeipa-devel] [PATCH 0409] Warn user when ipa *-find reach search limit

2016-01-26 Thread Martin Basti
On 26.01.2016 15:00, Gabe Alford wrote: On Tue, Jan 26, 2016 at 6:56 AM, Martin Basti <mailto:mba...@redhat.com>> wrote: On 26.01.2016 14:55, Petr Spacek wrote: On 26.1.2016 14:02, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5634

Re: [Freeipa-devel] [PATCH 0409] Warn user when ipa *-find reach search limit

2016-01-26 Thread Martin Basti
On 26.01.2016 14:55, Petr Spacek wrote: On 26.1.2016 14:02, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5634 Patch attached. It works for me in API, CLI, and Web UI. The warning is shown as expected. Interestingly, Web UI behaves strangely when search limit is hit. This

Re: [Freeipa-devel] [PATCH 0407] make lint: migration to config file and pylint plugin due pylint 1.5.2

2016-01-26 Thread Martin Basti
On 20.01.2016 14:38, Jan Cholasta wrote: Hi, On 19.1.2016 13:43, Martin Basti wrote: New pylint version will broke our custom make-lint script again, attached patch migrates make-lint to: * config file * pylint plugin which are supported by pylint and should not have regular compatibility

[Freeipa-devel] [PATCH 0409] Warn user when ipa *-find reach search limit

2016-01-26 Thread Martin Basti
https://fedorahosted.org/freeipa/ticket/5634 Patch attached. From c3ff150ac9787608f0bb7b27802a499a05084b49 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Tue, 26 Jan 2016 13:47:56 +0100 Subject: [PATCH] Warn user when ipa *-find reach limit Truncated entries were silently ignored, now a

Re: [Freeipa-devel] [PATCH] 0001 Refactor test_user_plugin

2016-01-25 Thread Martin Basti
On 25.01.2016 15:12, Aleš Mareček wrote: Tested + several other dependent tests executed as well - PASS. The patch looks good, ACK. - Original Message - From: "Filip Skola" To: "Milan Kubík" Cc: freeipa-devel@redhat.com, "Aleš Mareček" Sent: Monday, January 25, 2016 11:55:35 AM Sub

Re: [Freeipa-devel] [PATCH] 948 stop installer when setup-ds.pl fail

2016-01-25 Thread Martin Basti
On 22.01.2016 10:17, Martin Babinsky wrote: On 01/21/2016 07:28 PM, Petr Vobornik wrote: Petr Vobornik ACK. Pushed to: master: b0894a84932c3b02c495f29b7c110dd072da745f ipa-4-3: 0b2961e87c1978dc49395aba6df50269ef359ba4 -- Manage your subscription for the Freeipa-devel mailing list: https:/

Re: [Freeipa-devel] [PATCH 0408] CI DNSSEC: add missing glue record

2016-01-25 Thread Martin Basti
On 23.01.2016 10:34, Petr Spacek wrote: On 22.1.2016 17:47, Martin Basti wrote: -# make BIND happy, and delegate zone which contains A record of master +# make BIND happy: add the glue record and delegate zone +args = [ +"ipa", "dnsrecord-

Re: [Freeipa-devel] [PATCH] 0751 spec: Split out python-ipap11helper and, python-default_encoding_utf8

2016-01-25 Thread Martin Basti
On 22.01.2016 16:24, Petr Viktorin wrote: On 01/21/2016 01:14 PM, Jan Cholasta wrote: We got rid of both default_encoding_utf8 and _ipap11helper, so python-ipalib can be packaged as noarch. See the attached patch. The patch looks good to me, so ACK (though an ACK for me probably doesn't count

Re: [Freeipa-devel] Fwd: Re: [Freeipa-users] Freeipa 4.3.0 replica installation fails with DuplicateEntry: This entry already exists

2016-01-25 Thread Martin Basti
On 25.01.2016 09:30, Ludwig Krispenz wrote: Hi, this is from a discussion on the user-list, there is a difference in acis on 4.2.0 and 4.2.3 this is the aci which is present in 4.2.0 and is missing in 4.2.3: aci: (targetattr = "cn || createtimestamp || description || entryusn || modify t

[Freeipa-devel] [PATCH 0408] CI DNSSEC: add missing glue record

2016-01-22 Thread Martin Basti
Patch attached. From 15e6c98420c9ffc7b840373910a06f251cca653a Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Fri, 22 Jan 2016 14:23:53 +0100 Subject: [PATCH] Fix DNSSEC test: add glue record Missing glue record causes test failure in cases when DNS zone was not managed by IPA DNS

Re: [Freeipa-devel] [PATCH 0011-0012][RFE] ipa-replica-manage: automatically clean dangling RUVs

2016-01-22 Thread Martin Basti
patches attached. On 01/13/2016 02:01 PM, Martin Basti wrote: On 18.12.2015 12:46, Stanislav Laznicka wrote: Hi, Attached are the patches for auto-find and clean of dangling (cs)ruvs. Currently, the cleaning of an RUV waits for all replicas to be online, even on --force. If that were an issue, I

Re: [Freeipa-devel] [PATCH 0129] correctly set LDAP bind related attributes when setting up replication

2016-01-21 Thread Martin Basti
On 19.01.2016 18:04, Martin Babinsky wrote: Fixes https://fedorahosted.org/freeipa/ticket/5412 ACK Pushed to: master: f2b22ec0172243ae2c388dad012112ff0fd843c6 ipa-4-3: 7c8683d26294a6fd33ff3a4e21a67e39576f34ef -- Manage your subscription for the Freeipa-devel mailing list: https://www.red

Re: [Freeipa-devel] [PATCH 0121] consider IPA master removed from topology when request for host TGT fails

2016-01-21 Thread Martin Basti
On 20.01.2016 15:45, Simo Sorce wrote: On Wed, 2016-01-20 at 09:42 +0100, Martin Babinsky wrote: On 01/15/2016 06:29 PM, Martin Babinsky wrote: On 01/15/2016 04:57 PM, Simo Sorce wrote: On Fri, 2016-01-15 at 13:35 +0100, Martin Babinsky wrote: On 01/14/2016 10:31 PM, Simo Sorce wrote: On W

Re: [Freeipa-devel] [PATCH] 0049 Remove workaround for CA running check

2016-01-21 Thread Martin Basti
keep the "workaround" I will submit a different patch that removes unused code and FIXME comments :) Cheers, Fraser You may also want to check FreeIPA spec file, if there is now no extra curl dependency. I would leave it up to Martin Basti, to confirm that the original issue cannot appear

Re: [Freeipa-devel] [PATCH 0022] topology plugin prevents deletes but does not prevent moddn

2016-01-21 Thread Martin Basti
2016 09:11 AM, Ludwig Krispenz wrote: On 01/20/2016 05:45 PM, Martin Basti wrote: On 11.12.2015 13:56, Ludwig Krispenz wrote: Ticket: https://fedorahosted.org/freeipa/ticket/5536 Patch attached. Patch works, I cannot move entry out of container via moddn operation. I have question, is i

Re: [Freeipa-devel] [PATCH 0406] Exclude o=ipaca from syncrepl

2016-01-21 Thread Martin Basti
On 18.01.2016 17:55, Christian Heimes wrote: On 2016-01-18 17:28, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5538 Patch attached ACK Pushed to: master: 54a91c3ed33c7be54cadb188add802e781893ec9 ipa-4-3: 89c32f2bdaf53a1408ea67fe19c0033cff202dfc Can I revert workaround in

Re: [Freeipa-devel] [PATCH 537] ipapython: port p11helper C code to Python

2016-01-21 Thread Martin Basti
On 20.01.2016 15:36, Jan Cholasta wrote: On 20.1.2016 13:51, Martin Basti wrote: On 19.01.2016 11:43, Jan Cholasta wrote: On 12.1.2016 16:06, Martin Basti wrote: On 12.01.2016 14:44, Jan Cholasta wrote: On 12.1.2016 13:32, Martin Basti wrote: On 12.01.2016 12:24, Jan Cholasta wrote

Re: [Freeipa-devel] [PATCH 0022] topology plugin prevents deletes but does not prevent moddn

2016-01-20 Thread Martin Basti
On 11.12.2015 13:56, Ludwig Krispenz wrote: Ticket: https://fedorahosted.org/freeipa/ticket/5536 Patch attached. Patch works, I cannot move entry out of container via moddn operation. I have question, is it expected to be able rename entry? I tried it and I was able to change RDN #!RESUL

Re: [Freeipa-devel] [PATCH 565] Fix potential aborts in KDB driver

2016-01-20 Thread Martin Basti
On 13.01.2016 16:13, Martin Basti wrote: On 13.01.2016 16:03, Simo Sorce wrote: On Wed, 2016-01-13 at 15:49 +0100, Martin Basti wrote: On 13.01.2016 15:31, Martin Babinsky wrote: On 01/13/2016 03:30 PM, Simo Sorce wrote: On Wed, 2016-01-13 at 14:02 +0100, Martin Babinsky wrote: On 01/05

Re: [Freeipa-devel] [PATCH] 945 webui: dislay server suffixes in server search page

2016-01-20 Thread Martin Basti
On 20.01.2016 08:21, Martin Babinsky wrote: On 01/19/2016 06:32 PM, Petr Vobornik wrote: [PATCH] webui: dislay server suffixes in server search page There was a change where suffixes in server are not longer returned as DNs but rather a cn of related topology suffix. I.e. they share "memberof

Re: [Freeipa-devel] [PATCH] Added kpasswd_server directive in client krb5.conf

2016-01-20 Thread Martin Basti
On 20.01.2016 12:33, Christian Heimes wrote: On 2016-01-20 12:15, Abhijeet Kasurde wrote: Hi Christian, On 01/20/2016 04:15 PM, Christian Heimes wrote: On 2016-01-20 08:30, Abhijeet Kasurde wrote: Ping for review request. Hi, your initial patch has a small problem. Please provide a new pa

Re: [Freeipa-devel] [PATCH 537] ipapython: port p11helper C code to Python

2016-01-20 Thread Martin Basti
On 19.01.2016 11:43, Jan Cholasta wrote: On 12.1.2016 16:06, Martin Basti wrote: On 12.01.2016 14:44, Jan Cholasta wrote: On 12.1.2016 13:32, Martin Basti wrote: On 12.01.2016 12:24, Jan Cholasta wrote: On 12.1.2016 12:17, Martin Basti wrote: On 12.01.2016 10:19, Jan Cholasta wrote

Re: [Freeipa-devel] [TEST][PATCH 0019] A proper fix for reverse-zone creation in integration tests

2016-01-19 Thread Martin Basti
On 18.01.2016 12:51, Oleg Fayans wrote: On 01/18/2016 10:30 AM, Petr Spacek wrote: On 14.1.2016 15:05, Oleg Fayans wrote: Date: Thu, 14 Jan 2016 14:59:37 +0100 Subject: [PATCH] fixed an issue with master installation not creating reverse zone When resolv.conf is set to point to the master

Re: [Freeipa-devel] [PATCH 0407] WIP: make-lint migration to config file and pylint plugin due pylint 1.5.2

2016-01-19 Thread Martin Basti
On 19.01.2016 16:34, Christian Heimes wrote: On 2016-01-19 13:43, Martin Basti wrote: + +def fake_class(name_or_class_obj, members=[]): Please use a non-mutable argument here. members=() will do the job just fine. Fixed. +if isinstance(name_or_class_obj, scoped_nodes.Class

Re: [Freeipa-devel] [PATCH 0398] logger: Use warning instead of warn

2016-01-19 Thread Martin Basti
On 18.01.2016 17:50, Martin Basti wrote: On 18.01.2016 17:49, Martin Basti wrote: On 15.01.2016 17:15, Tomas Babej wrote: On 01/15/2016 05:12 PM, Martin Basti wrote: On 15.01.2016 16:27, Tomas Babej wrote: Hi, this should build up to another pylint-related patch Martin^2 has in

[Freeipa-devel] [PATCH 0407] WIP: make-lint migration to config file and pylint plugin due pylint 1.5.2

2016-01-19 Thread Martin Basti
o 'houroffset' member) ipatests/test_ipapython/test_ipautil.py:417: [E1101(no-member), TestTimeParser.test_time_zones] Class 'tzinfo' has no 'minoffset' member) ipatests/test_ipapython/test_ipautil.py:418: [E1101(no-member), TestTimeParser.test_time_zones] Class 'tzinfo&

Re: [Freeipa-devel] [PATCH 0398] logger: Use warning instead of warn

2016-01-18 Thread Martin Basti
On 18.01.2016 17:49, Martin Basti wrote: On 15.01.2016 17:15, Tomas Babej wrote: On 01/15/2016 05:12 PM, Martin Basti wrote: On 15.01.2016 16:27, Tomas Babej wrote: Hi, this should build up to another pylint-related patch Martin^2 has in works. Tomas NACK

Re: [Freeipa-devel] [PATCH 0398] logger: Use warning instead of warn

2016-01-18 Thread Martin Basti
On 15.01.2016 17:15, Tomas Babej wrote: On 01/15/2016 05:12 PM, Martin Basti wrote: On 15.01.2016 16:27, Tomas Babej wrote: Hi, this should build up to another pylint-related patch Martin^2 has in works. Tomas NACK :) * Module ipalib.plugins.dns ipalib/plugins/dns.py

[Freeipa-devel] [PATCH 0406] Exclude o=ipaca from syncrepl

2016-01-18 Thread Martin Basti
https://fedorahosted.org/freeipa/ticket/5538 Patch attached From cffdb8b4cc7af8edc1500069a375d62530b309fe Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Mon, 18 Jan 2016 17:19:08 +0100 Subject: [PATCH] Exclude o=ipaca subtree from Retro Changelog (syncrepl) CA and DS have issues with Retro

Re: [Freeipa-devel] [PATCH 0405] Fix: uninstall does not stop named-pkcs11 and ipa-ods-exporter

2016-01-18 Thread Martin Basti
On 18.01.2016 10:10, David Kupka wrote: On 15/01/16 10:10, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5262 Patch attached, detailed description in the commit message. Works for me, ACK. Pushed to: master: 7baa675947f012f36376811e2e1f47ff4779cfe3 ipa-4-3

Re: [Freeipa-devel] [PATCH 0398] logger: Use warning instead of warn

2016-01-15 Thread Martin Basti
On 15.01.2016 16:27, Tomas Babej wrote: Hi, this should build up to another pylint-related patch Martin^2 has in works. Tomas NACK :) * Module ipalib.plugins.dns ipalib/plugins/dns.py:3441: [E1101(no-member), dnsrecord.wait_for_modified_attr] Class 'log' has no 'warn' member

[Freeipa-devel] [PATCH 0405] Fix: uninstall does not stop named-pkcs11 and ipa-ods-exporter

2016-01-15 Thread Martin Basti
https://fedorahosted.org/freeipa/ticket/5262 Patch attached, detailed description in the commit message. From 4c674535fa994a2a7c4208d3382c41bc6692e04e Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Thu, 14 Jan 2016 14:52:15 +0100 Subject: [PATCH] Fix: uninstall does not stop named-pkcs11 and

Re: [Freeipa-devel] [PATCH 0402] Warn user about possibility to loss CA, KRA, DNSSEC master during uninstall

2016-01-14 Thread Martin Basti
On 14.01.2016 14:18, David Kupka wrote: On 13/01/16 18:18, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5544 Patch attached. Thanks for the patch, works for me, ACK. Pushed to: master: 58c42ddac0964a8cce7c1e1faa7516da53f028ad ipa-4-3

[Freeipa-devel] [PATCH 0403][test] CI: fix regression in task.install_kra

2016-01-14 Thread Martin Basti
From: Martin Basti Date: Thu, 14 Jan 2016 10:23:11 +0100 Subject: [PATCH] CI test: fix regression in task.install_kra ipa-kra-install needs directory manager password Regression caused by c4b9b295d8184694c50c0d56051e0273445c98ec --- ipatests/test_integration/tasks.py | 2 +- 1 file changed, 1

Re: [Freeipa-devel] [PATCH 0401] Pylint enable unbalanced tuple unpacking check

2016-01-14 Thread Martin Basti
On 14.01.2016 11:23, Martin Babinsky wrote: On 01/12/2016 01:09 PM, Martin Basti wrote: Patch attached. ACK. Pushed to master: 2320be18a34628fa6d05ffc42e695da5dd6dab6e -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 0404] Pylint: enable unpacking-non-sequence check

2016-01-14 Thread Martin Basti
On 14.01.2016 11:22, Martin Babinsky wrote: On 01/14/2016 11:02 AM, Martin Basti wrote: Patch attached. ACK. Pushed to master: 267bad10a81f101db8b645abf01b2cdd62c91775 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH 0404] Pylint: enable unpacking-non-sequence check

2016-01-14 Thread Martin Basti
Patch attached. From b13ef989eabc361d17fdc5d1d6137a460e650d6b Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Thu, 17 Dec 2015 15:51:32 +0100 Subject: [PATCH] Enable pylint unpacking-non-sequence check Enables check and marks occurences of runtime error in dcerpc.py as false positive

Re: [Freeipa-devel] [PATCH 562-563] Fix ipa-sam to use the getkeytab control instead of the setkeytab control

2016-01-14 Thread Martin Basti
On 14.01.2016 08:24, Alexander Bokovoy wrote: On Thu, 03 Dec 2015, Simo Sorce wrote: The first patch is preparatory and is needed in general now that we want top allow alias and use krbCanonicalName as the canonical name when multiple values are avilable in krbPrincipalName. The second patch

[Freeipa-devel] [PATCH 0402] Warn user about possibility to loss CA, KRA, DNSSEC master during uninstall

2016-01-13 Thread Martin Basti
https://fedorahosted.org/freeipa/ticket/5544 Patch attached. From a882c48058cca2564265546e557e9d7d542a9553 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Wed, 13 Jan 2016 17:27:06 +0100 Subject: [PATCH] Warn about potential loss of CA, KRA, DNSSEC during uninstall If connection do LDAP

Re: [Freeipa-devel] [PATCH 0126-0127] reset openldap client config to point to freshly promote replica

2016-01-13 Thread Martin Basti
On 13.01.2016 17:59, Rob Crittenden wrote: Martin Babinsky wrote: fixes https://fedorahosted.org/freeipa/ticket/5584 In order to ensure consistent behavior with ipa-client-install, I opted to reuse the configure_openldap_conf() function and restoring the config from client sysrestore before m

Re: [Freeipa-devel] [TEST] Workaround for ticket N 5559

2016-01-13 Thread Martin Basti
On 08.01.2016 10:12, Oleg Fayans wrote: Passes lint, fixes an issue with replica installation failures due to absence of corresponding reverse zone on master. NACK [ipa.ipatests.test_integration.host.Host.master.ParamikoTransport] RUN ['ipa', 'dnsrecord-add', '129.168.192.in-addr.arpa.',

Re: [Freeipa-devel] [PATCH 565] Fix potential aborts in KDB driver

2016-01-13 Thread Martin Basti
On 13.01.2016 16:03, Simo Sorce wrote: On Wed, 2016-01-13 at 15:49 +0100, Martin Basti wrote: On 13.01.2016 15:31, Martin Babinsky wrote: On 01/13/2016 03:30 PM, Simo Sorce wrote: On Wed, 2016-01-13 at 14:02 +0100, Martin Babinsky wrote: On 01/05/2016 11:19 PM, Simo Sorce wrote: On Tue

Re: [Freeipa-devel] [PATCH 565] Fix potential aborts in KDB driver

2016-01-13 Thread Martin Basti
On 13.01.2016 15:31, Martin Babinsky wrote: On 01/13/2016 03:30 PM, Simo Sorce wrote: On Wed, 2016-01-13 at 14:02 +0100, Martin Babinsky wrote: On 01/05/2016 11:19 PM, Simo Sorce wrote: On Tue, 2016-01-05 at 16:15 -0500, Simo Sorce wrote: The LDAP context was not checked on the first api cal

Re: [Freeipa-devel] [PATCH] Remove des3/arcfour from default enctypes

2016-01-13 Thread Martin Basti
On 13.01.2016 15:06, Alexander Bokovoy wrote: On Mon, 23 Nov 2015, Simo Sorce wrote: Note, this does not touch the trust code because apparently we use only arcfour there. CCing Alexander to give me a comment about that, probably worth opening a ticket specific to trusts. Otherwise addresses

Re: [Freeipa-devel] [PATCH 0011-0012][RFE] ipa-replica-manage: automatically clean dangling RUVs

2016-01-13 Thread Martin Basti
On 18.12.2015 12:46, Stanislav Laznicka wrote: Hi, Attached are the patches for auto-find and clean of dangling (cs)ruvs. Currently, the cleaning of an RUV waits for all replicas to be online, even on --force. If that were an issue, I can make the command fail before trying to clean any of

Re: [Freeipa-devel] [patch 0029, 0030] fixes for install tasks in integration tests

2016-01-13 Thread Martin Basti
On 11.01.2016 11:59, Milan Kubík wrote: On 01/07/2016 09:36 AM, Milan Kubík wrote: 0029: Add 10.in-addr.arpa. zone to ipa 0030: If the IP addresses in the topology are resolvable, do not add them to master. Hi. I'm dropping 0029 for now. 0030 gets an update. -- Milan Kubik ACK Pushe

Re: [Freeipa-devel] [PATCH 0124] ipa-csreplica-manage: remove extraneous ldap2 connection

2016-01-13 Thread Martin Basti
On 11.01.2016 16:47, Martin Basti wrote: On 11.01.2016 12:34, Martin Kosek wrote: On 01/08/2016 06:31 PM, Martin Babinsky wrote: On 01/08/2016 06:17 PM, Martin Basti wrote: On 08.01.2016 17:18, Martin Babinsky wrote: fixes ipa-csreplica-manage del blowing up due https

Re: [Freeipa-devel] [PATCH 0118] fix Py3 incompatible exception instantiation in replica install code

2016-01-13 Thread Martin Basti
On 11.01.2016 13:30, Martin Babinsky wrote: On 01/08/2016 06:26 PM, Tomas Babej wrote: On 01/07/2016 05:56 PM, Martin Babinsky wrote: On 01/04/2016 09:02 AM, Martin Babinsky wrote: I have created ticket to patch and added it to commit message: https://fedorahosted.org/freeipa/ticket/5

Re: [Freeipa-devel] [PATCH 539] ipalib: assume version 2.0 when skip_version_check is enabled

2016-01-12 Thread Martin Basti
On 12.01.2016 16:07, Jan Cholasta wrote: On 12.1.2016 15:58, Martin Kosek wrote: On 01/12/2016 03:46 PM, Jan Cholasta wrote: Hi, the attached patch fixes . Honza I see you set the version to 2.0. As I am reading https://bugzilla.redhat.com/s

Re: [Freeipa-devel] [PATCH 537] ipapython: port p11helper C code to Python

2016-01-12 Thread Martin Basti
On 12.01.2016 14:44, Jan Cholasta wrote: On 12.1.2016 13:32, Martin Basti wrote: On 12.01.2016 12:24, Jan Cholasta wrote: On 12.1.2016 12:17, Martin Basti wrote: On 12.01.2016 10:19, Jan Cholasta wrote: On 12.1.2016 09:32, Martin Basti wrote: On 07.01.2016 14:13, Jan Cholasta wrote

Re: [Freeipa-devel] [PATCH 0122-0123] reimplementation of package version comparison code

2016-01-12 Thread Martin Basti
On 12.01.2016 13:14, Martin Babinsky wrote: On 01/12/2016 01:03 PM, Martin Basti wrote: On 12.01.2016 10:23, Martin Babinsky wrote: On 01/11/2016 06:38 PM, Martin Basti wrote: On 11.01.2016 17:58, Jan Cholasta wrote: On 11.1.2016 16:29, Martin Babinsky wrote: On 01/11/2016 02:27 PM

Re: [Freeipa-devel] Design: Automatic Empty Zone handling in bind-dyndb-ldap

2016-01-12 Thread Martin Basti
On 12.01.2016 15:06, Petr Spacek wrote: On 8.1.2016 18:14, Martin Basti wrote: On 08.01.2016 16:57, Petr Spacek wrote: Hello, recent improvements in FreeIPA 4.3.0 (finally) prevent FreeIPA installer from creating made-up DNS reverse zones, which already exist on some other DNS server

Re: [Freeipa-devel] [PATCH 537] ipapython: port p11helper C code to Python

2016-01-12 Thread Martin Basti
On 12.01.2016 12:24, Jan Cholasta wrote: On 12.1.2016 12:17, Martin Basti wrote: On 12.01.2016 10:19, Jan Cholasta wrote: On 12.1.2016 09:32, Martin Basti wrote: On 07.01.2016 14:13, Jan Cholasta wrote: On 7.1.2016 09:50, Jan Cholasta wrote: Hi, the attached patch ports the

[Freeipa-devel] [PATCH 0401] Pylint enable unbalanced tuple unpacking check

2016-01-12 Thread Martin Basti
Patch attached. From ac8af289c283aaf44d7ac42e1b8bfeecc417e59c Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Thu, 17 Dec 2015 16:07:10 +0100 Subject: [PATCH] Enable pylint unbalanced-tuple-unpacking check Enables check and fixes one issue. get_entries can be replaced by get_entry, filter is

Re: [Freeipa-devel] [PATCH 0122-0123] reimplementation of package version comparison code

2016-01-12 Thread Martin Basti
On 12.01.2016 10:23, Martin Babinsky wrote: On 01/11/2016 06:38 PM, Martin Basti wrote: On 11.01.2016 17:58, Jan Cholasta wrote: On 11.1.2016 16:29, Martin Babinsky wrote: On 01/11/2016 02:27 PM, Martin Babinsky wrote: On 01/11/2016 02:01 PM, Jan Cholasta wrote: On 11.1.2016 13:14

Re: [Freeipa-devel] [PATCH 0088] Don't error when find_base() fails if a base is not required

2016-01-12 Thread Martin Basti
On 11.01.2016 18:05, Martin Basti wrote: On 11.01.2016 17:52, Nathaniel McCallum wrote: On Mon, 2016-01-11 at 17:45 +0100, Martin Basti wrote: On 14.12.2015 16:22, Nathaniel McCallum wrote: We always have to call find_base() in order to force libldap to open the socket. However, if no

Re: [Freeipa-devel] [PATCH 537] ipapython: port p11helper C code to Python

2016-01-12 Thread Martin Basti
On 12.01.2016 10:19, Jan Cholasta wrote: On 12.1.2016 09:32, Martin Basti wrote: On 07.01.2016 14:13, Jan Cholasta wrote: On 7.1.2016 09:50, Jan Cholasta wrote: Hi, the attached patch ports the _ipap11helper module to python-cffi. Combined with my patch 536 [1], this makes ipapython

Re: [Freeipa-devel] [PATCH 0077-8] ipa-replica-prepare: Add '--auto-reverse' and, '--allow-zone-overlap' options

2016-01-12 Thread Martin Basti
On 22.12.2015 16:19, Petr Spacek wrote: On 22.12.2015 15:14, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/5563 NACK: $ ipa-replica-prepare vm-058-106.abc.idm.lab.eng.brq.redhat.com --ip-address=10.34.58.106 --reverse-zone=58.34.10.in-addr.arpa. Directory Manager (existing maste

Re: [Freeipa-devel] [PATCHES 0396-0397] DNSSEC CI: fix tests

2016-01-12 Thread Martin Basti
On 12.01.2016 10:44, Martin Babinsky wrote: On 01/06/2016 06:05 PM, Martin Basti wrote: Patches attached. ACK Pushed to: master: 34b197afa4beb0a84ca01cb594c39859abdc4706 ipa-4-3: d2c103df5d3bec3fbaafb854291a5ab245c436f8 -- Manage your subscription for the Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH 537] ipapython: port p11helper C code to Python

2016-01-12 Thread Martin Basti
On 07.01.2016 14:13, Jan Cholasta wrote: On 7.1.2016 09:50, Jan Cholasta wrote: Hi, the attached patch ports the _ipap11helper module to python-cffi. Combined with my patch 536 [1], this makes ipapython architecture independent. Updated patch attached. I tried to run DNSSEC tests and i

Re: [Freeipa-devel] [PATCH 0122-0123] reimplementation of package version comparison code

2016-01-11 Thread Martin Basti
On 11.01.2016 17:58, Jan Cholasta wrote: On 11.1.2016 16:29, Martin Babinsky wrote: On 01/11/2016 02:27 PM, Martin Babinsky wrote: On 01/11/2016 02:01 PM, Jan Cholasta wrote: On 11.1.2016 13:14, Martin Babinsky wrote: On 01/11/2016 07:47 AM, Jan Cholasta wrote: On 8.1.2016 18:30, Lukas Sle

Re: [Freeipa-devel] [PATCH 0088] Don't error when find_base() fails if a base is not required

2016-01-11 Thread Martin Basti
On 11.01.2016 17:52, Nathaniel McCallum wrote: On Mon, 2016-01-11 at 17:45 +0100, Martin Basti wrote: On 14.12.2015 16:22, Nathaniel McCallum wrote: We always have to call find_base() in order to force libldap to open the socket. However, if no base is actually required then there is no

Re: [Freeipa-devel] [PATCH 0088] Don't error when find_base() fails if a base is not required

2016-01-11 Thread Martin Basti
On 14.12.2015 16:22, Nathaniel McCallum wrote: We always have to call find_base() in order to force libldap to open the socket. However, if no base is actually required then there is no reason to error out if find_base() fails. This condition can arise when anonymous binds are disabled. Hell

Re: [Freeipa-devel] [PATCH] Remove des3/arcfour from default enctypes

2016-01-11 Thread Martin Basti
On 23.11.2015 19:49, Simo Sorce wrote: Note, this does not touch the trust code because apparently we use only arcfour there. CCing Alexander to give me a comment about that, probably worth opening a ticket specific to trusts. Otherwise addresses #4740 Simo. Patch works for me, if Alexan

Re: [Freeipa-devel] [PATCH 0124] ipa-csreplica-manage: remove extraneous ldap2 connection

2016-01-11 Thread Martin Basti
On 11.01.2016 12:34, Martin Kosek wrote: On 01/08/2016 06:31 PM, Martin Babinsky wrote: On 01/08/2016 06:17 PM, Martin Basti wrote: On 08.01.2016 17:18, Martin Babinsky wrote: fixes ipa-csreplica-manage del blowing up due https://fedorahosted.org/freeipa/ticket/5583 for master and ipa-4

Re: [Freeipa-devel] Fix ipa-replica-prepare after DNS check patches

2016-01-11 Thread Martin Basti
On 08.01.2016 12:55, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/5563 ACK Pushed to: master: bc6543efae9bb1bf7c5e792e30b1ea396607f57e ipa-4-3: 5e2abd332b1292504dcdcd41972db888eff7296c -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mai

Re: [Freeipa-devel] [PATCHES] 0752-0757, 0759 Enable pylint --py3k

2016-01-11 Thread Martin Basti
On 08.01.2016 12:45, Petr Viktorin wrote: On 01/06/2016 03:28 PM, Petr Viktorin wrote: Hello, Patches 0753-0757 fix remaining warnings from `pylint --py3k`, except "no-absolute-import" (which seems redundant to me) and the ones in contrib/RHEL4. The last patch adds py3k lint check to make-li

Re: [Freeipa-devel] [patch 0028] ipatests: Fix configuration problems in dns tests

2016-01-11 Thread Martin Basti
On 11.01.2016 12:38, Martin Basti wrote: On 11.01.2016 12:01, Milan Kubík wrote: On 01/07/2016 10:37 AM, Martin Basti wrote: On 07.01.2016 10:23, Milan Kubík wrote: On 01/07/2016 09:31 AM, Oleg Fayans wrote: Hi Milan, As we are eventialy going to move to python3, I would make the code

Re: [Freeipa-devel] [TESTS][PATCH 0007] Multiple managers per user

2016-01-11 Thread Martin Basti
On 11.01.2016 12:47, Lenka Doudova wrote: Hi, everyone having time to take a look at this? It's been hanging for a few weeks. Thanks, Lenka On 12/15/2015 12:42 PM, Lenka Doudova wrote: Hi, I updated the (stage)user tests to reflect the multiple managers per user feature. Corresponding t

Re: [Freeipa-devel] [patch 0028] ipatests: Fix configuration problems in dns tests

2016-01-11 Thread Martin Basti
On 11.01.2016 12:01, Milan Kubík wrote: On 01/07/2016 10:37 AM, Martin Basti wrote: On 07.01.2016 10:23, Milan Kubík wrote: On 01/07/2016 09:31 AM, Oleg Fayans wrote: Hi Milan, As we are eventialy going to move to python3, I would make the code python3-compatible: 1. from __future__

Re: [Freeipa-devel] [PATCH 0399] Upgrade: fix upgrading of NIS Server configuration

2016-01-11 Thread Martin Basti
On 11.01.2016 08:34, Alexander Bokovoy wrote: On Fri, 08 Jan 2016, Martin Basti wrote: On 08.01.2016 16:22, Martin Basti wrote: On 08.01.2016 16:19, Petr Vobornik wrote: On 01/08/2016 02:54 PM, Alexander Bokovoy wrote: On Wed, 06 Jan 2016, Martin Basti wrote: https://fedorahosted.org

Re: [Freeipa-devel] [PATCH 0398] Allow to use mixed case for sysrestore

2016-01-08 Thread Martin Basti
On 08.01.2016 16:48, Martin Babinsky wrote: On 01/07/2016 05:55 PM, Martin Basti wrote: On 06.01.2016 19:08, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5574 Patch attached. I missed one occurrence, updated patch attached. ACK (also the reason why Martin^2 didn&#

Re: [Freeipa-devel] [PATCH 0124] ipa-csreplica-manage: remove extraneous ldap2 connection

2016-01-08 Thread Martin Basti
On 08.01.2016 17:18, Martin Babinsky wrote: fixes ipa-csreplica-manage del blowing up due https://fedorahosted.org/freeipa/ticket/5583 for master and ipa-4-3 only. Give me patch plese!! -- Manage your subscription for the Freeipa-devel mailing list: https://www.redh

Re: [Freeipa-devel] Design: Automatic Empty Zone handling in bind-dyndb-ldap

2016-01-08 Thread Martin Basti
On 08.01.2016 16:57, Petr Spacek wrote: Hello, recent improvements in FreeIPA 4.3.0 (finally) prevent FreeIPA installer from creating made-up DNS reverse zones, which already exist on some other DNS server. This change uncovered a well-hidden automatic empty zones in BIND 9.9+, which is now

Re: [Freeipa-devel] [PATCH 0399] Upgrade: fix upgrading of NIS Server configuration

2016-01-08 Thread Martin Basti
On 08.01.2016 16:22, Martin Basti wrote: On 08.01.2016 16:19, Petr Vobornik wrote: On 01/08/2016 02:54 PM, Alexander Bokovoy wrote: On Wed, 06 Jan 2016, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5507 Patch attached. Is proposed workaround in ticket enough or should I

Re: [Freeipa-devel] [PATCH 0399] Upgrade: fix upgrading of NIS Server configuration

2016-01-08 Thread Martin Basti
On 08.01.2016 16:19, Petr Vobornik wrote: On 01/08/2016 02:54 PM, Alexander Bokovoy wrote: On Wed, 06 Jan 2016, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5507 Patch attached. Is proposed workaround in ticket enough or should I also prepare a update that will fix missing

Re: [Freeipa-devel] import rpm causes failure during IPA caless install

2016-01-08 Thread Martin Basti
On 08.01.2016 14:14, Jan Cholasta wrote: On 8.1.2016 14:09, Martin Basti wrote: On 08.01.2016 14:00, Martin Kosek wrote: On 01/08/2016 01:45 PM, Martin Basti wrote: Hello all, fix for ticket https://fedorahosted.org/freeipa/ticket/5535 requires to import rpm module This import somehow

Re: [Freeipa-devel] import rpm causes failure during IPA caless install

2016-01-08 Thread Martin Basti
On 08.01.2016 14:00, Martin Kosek wrote: On 01/08/2016 01:45 PM, Martin Basti wrote: Hello all, fix for ticket https://fedorahosted.org/freeipa/ticket/5535 requires to import rpm module This import somehow breaks nsslib in IPA https://fedorahosted.org/freeipa/ticket/5572 We have 2 ways

[Freeipa-devel] import rpm causes failure during IPA caless install

2016-01-08 Thread Martin Basti
you all agree or do you have better idea? Feedback welcome, please ASAP. Martin^2 From bc665a86825c6fb5654eb3446a85ecc08ef7eefd Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Fri, 8 Jan 2016 13:24:20 +0100 Subject: [PATCH] fix rpm import --- ipaplatform/redhat/tasks.py | 3 ++- 1 file

Re: [Freeipa-devel] [PATCH 0083-0084] Fix DNS zone overlap check to allow ipa-replica-install to worFix dns_is_enabled() API command to throw exceptions as appropriat

2016-01-08 Thread Martin Basti
On 08.01.2016 09:59, David Kupka wrote: On 07/01/16 16:26, Petr Spacek wrote: Hello, Fix DNS zone overlap check to allow ipa-replica-install to work. My review script claims that "No problems detected using lint, pep8, ./make{api,aci}, and VERSION" Please review. Thanks, looks good and wo

Re: [Freeipa-devel] [PATCH 0082] Fix --auto-reverse option in --unattended mode

2016-01-08 Thread Martin Basti
On 08.01.2016 09:59, David Kupka wrote: On 07/01/16 11:25, Petr Spacek wrote: Hello, Fix --auto-reverse option in --unattended mode. Oleg, this should fix your particular environment. Unfortunately it is not a complete fix for https://fedorahosted.org/freeipa/ticket/5559 , stay tuned - I wi

Re: [Freeipa-devel] [PATCH] 943 webui: pwpolicy cospriority field was marked as required

2016-01-08 Thread Martin Basti
On 08.01.2016 10:09, Martin Basti wrote: On 22.12.2015 14:23, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/5553 Pushed to: master: af0e0e5153afdcdf5b8165162ae4ef5d60ecbe0b ipa-4-3: 574a637c730e62b741c9f901e51ff324b57bb781 ACK -- Manage your subscription for the

Re: [Freeipa-devel] [PATCH] 943 webui: pwpolicy cospriority field was marked as required

2016-01-08 Thread Martin Basti
On 22.12.2015 14:23, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/5553 Pushed to: master: af0e0e5153afdcdf5b8165162ae4ef5d60ecbe0b ipa-4-3: 574a637c730e62b741c9f901e51ff324b57bb781 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailma

Re: [Freeipa-devel] [PATCH] 942 webui: add examples to network address validator error message

2016-01-08 Thread Martin Basti
On 22.12.2015 14:33, Gabe Alford wrote: LGTM. Gabe On Tue, Dec 22, 2015 at 6:06 AM, Petr Vobornik > wrote: https://fedorahosted.org/freeipa/ticket/5532 -- Petr Vobornik -- Manage your subscription for the Freeipa-devel mailing list: htt

Re: [Freeipa-devel] [PATCH 0086] Migrate OTP import script to python-cryptography

2016-01-07 Thread Martin Basti
On 29.09.2015 12:00, Martin Babinsky wrote: On 09/25/2015 07:05 PM, Nathaniel McCallum wrote: On Fri, 2015-09-25 at 18:29 +0200, Martin Babinsky wrote: On 09/25/2015 04:53 PM, Nathaniel McCallum wrote: On Mon, 2015-08-31 at 11:08 -0400, Nathaniel McCallum wrote: https://fedorahosted.org/fre

Re: [Freeipa-devel] [PATCH 559] Fix kadmin for new users

2016-01-07 Thread Martin Basti
On 06.01.2016 09:49, Petr Vobornik wrote: On 01/06/2016 08:42 AM, Martin Kosek wrote: On 01/06/2016 08:37 AM, Martin Babinsky wrote: On 11/25/2015 03:41 PM, Martin Kosek wrote: On 11/25/2015 03:32 PM, Simo Sorce wrote: On Wed, 2015-11-25 at 14:13 +0100, Tomas Babej wrote: On 11/25/2015 02

Re: [Freeipa-devel] [PATCH 027] Require Dogtag 10.2.6-13 to fix KRA uninstall

2016-01-07 Thread Martin Basti
On 07.01.2016 07:37, Jan Cholasta wrote: On 6.1.2016 20:37, Martin Basti wrote: On 06.01.2016 11:21, Martin Babinsky wrote: On 01/05/2016 01:49 PM, Lukas Slebodnik wrote: On (05/01/16 12:24), Christian Heimes wrote: The combination of a bug in Dogtag's sslget command and a new featu

Re: [Freeipa-devel] [PATCH 0072-0081] DNSSEC: fixes

2016-01-07 Thread Martin Basti
On 07.01.2016 14:38, Martin Basti wrote: On 07.01.2016 12:19, Martin Basti wrote: On 06.01.2016 18:49, Martin Basti wrote: On 22.12.2015 14:32, Petr Spacek wrote: On 21.12.2015 18:56, Martin Basti wrote: On 21.12.2015 15:45, Martin Basti wrote: On 21.12.2015 15:33, Petr Spacek

Re: [Freeipa-devel] [patch 0028] ipatests: Fix configuration problems in dns tests

2016-01-07 Thread Martin Basti
On 07.01.2016 10:23, Milan Kubík wrote: On 01/07/2016 09:31 AM, Oleg Fayans wrote: Hi Milan, As we are eventialy going to move to python3, I would make the code python3-compatible: 1. from __future__ import unicode_literals 2. get rid of all u's in front of the strings On the other hand, we

Re: [Freeipa-devel] [patch 0029, 0030] fixes for install tasks in integration tests

2016-01-07 Thread Martin Basti
On 07.01.2016 10:21, Milan Kubík wrote: On 01/07/2016 10:12 AM, Martin Basti wrote: On 07.01.2016 10:03, Oleg Fayans wrote: Hi Milan, There is already a more generic method in tasks.py, that does the same: prepare_reverse_zone You can just call it from apply_common_fixes. That way, it

Re: [Freeipa-devel] [PATCH 027] Require Dogtag 10.2.6-13 to fix KRA uninstall

2016-01-06 Thread Martin Basti
On 06.01.2016 11:21, Martin Babinsky wrote: On 01/05/2016 01:49 PM, Lukas Slebodnik wrote: On (05/01/16 12:24), Christian Heimes wrote: The combination of a bug in Dogtag's sslget command and a new feature in mod_nss causes an incomplete uninstallation of KRA. The bug has been fixed in Dogtag

[Freeipa-devel] [PATCH 0400] update_uniqueness plugin: fix possible referenced before assignment error

2016-01-06 Thread Martin Basti
Variable 'update' might be undefined if a plugin configuration cannot be migrated to new format. Patch attached. From 3226a3a1753c7d53cc4d03bc4e98085fe18ba316 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Wed, 6 Jan 2016 20:26:09 +0100 Subject: [PATCH] update_uniqueness p

[Freeipa-devel] [PATCH 0399] Upgrade: fix upgrading of NIS Server configuration

2016-01-06 Thread Martin Basti
https://fedorahosted.org/freeipa/ticket/5507 Patch attached. Is proposed workaround in ticket enough or should I also prepare a update that will fix missing maps? From 39e1124314a66578022f7d7810fd6252af96fd80 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Wed, 6 Jan 2016 19:47:22 +0100

[Freeipa-devel] [PATCH 0398] Allow to use mixed case for sysrestore

2016-01-06 Thread Martin Basti
https://fedorahosted.org/freeipa/ticket/5574 Patch attached. From cffa75803ba38587a4002107df76558a77120262 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Tue, 5 Jan 2016 17:58:49 +0100 Subject: [PATCH] Allow to used mixed case for sysrestore This commit allows to use mixed case of keys

<    5   6   7   8   9   10   11   12   13   14   >