[Freeipa-devel] [PATCH 0003] TEST: Stageuser plugin

2015-08-19 Thread Lenka Doudova
Hi, I'm sending additional patch for stageuser plugin tests. It applies on top of 0002.3 patch sent earlier and reflects the change of 'stageuser-add --from-delete' command to 'user-stage'. Lenka From 03521e0683eb8a9a81d3acd97b08e2402affd270 Mon Sep 17 00:00:00 2001 From: Lenka Doudova ldoud

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-08-24 Thread Lenka Doudova
Attached. Lenka On 08/24/2015 03:14 PM, Martin Basti wrote: NACK You have unmerged changes in the patch On 08/24/2015 02:14 PM, Lenka Doudova wrote: from ipatests.test_xmlrpc import objectclasses + HEAD from ipatests.test_xmlrpc.xmlrpc_test import ( Declarative, fuzzy_digits

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-08-24 Thread Lenka Doudova
... and adding a patch version applicable for master branch Lenka On 08/24/2015 12:14 PM, Lenka Doudova wrote: On 08/20/2015 03:48 PM, Martin Basti wrote: On 08/14/2015 06:32 PM, Lenka Doudova wrote: Yes, that is correct - it's malfunctioning behavior of the plugin - command 'stageuser

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-08-24 Thread Lenka Doudova
On 08/20/2015 03:48 PM, Martin Basti wrote: On 08/14/2015 06:32 PM, Lenka Doudova wrote: Yes, that is correct - it's malfunctioning behavior of the plugin - command 'stageuser-add --from-delete', which is discussed in another thread. I left this test case for so long as it's not fixed

Re: [Freeipa-devel] Replace stageuser-add --from-delete with user-undel --to-staged

2015-07-28 Thread Lenka Doudova
Dne 28.7.2015 v 11:27 Jan Cholasta napsal(a): Dne 27.7.2015 v 17:59 Martin Basti napsal(a): On 23/07/15 14:43, Martin Basti wrote: Hello, I tried to fix #5145 and I partially succeeded. However, I cannot fix this part of ticket, where user is prompted to write name and surname. $ ipa

Re: [Freeipa-devel] [patch 0007] tests: Allow Tracker.dn be an instance of Fuzzy

2015-07-30 Thread Lenka Doudova
ACK, just configure your email client not to prepend '' to the patch. Lenka Dne 27.7.2015 v 12:32 Milan Kubík napsal(a): Hi, the patch changes the check on the Tracker.dn setter, allowing to use an instance of ipatests.util.Fuzzy to ease writing Trackers for plugins like CA ACL, which use

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-08-04 Thread Lenka Doudova
Dne 30.7.2015 v 16:10 Martin Basti napsal(a): On 30/07/15 16:09, Martin Basti wrote: On 29/07/15 16:10, Martin Basti wrote: On 29/07/15 15:29, Lenka Doudova wrote: Hi, thanks a lot for the comments, will work on it tomorrow. Lenka Dne 29.7.2015 v 15:27 Martin Basti napsal(a): On 27/07

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-07-29 Thread Lenka Doudova
Hi, thanks a lot for the comments, will work on it tomorrow. Lenka Dne 29.7.2015 v 15:27 Martin Basti napsal(a): On 27/07/15 16:47, Lenka Doudova wrote: Hi, I'm attaching a patch with automated tests for stageuser plugin (https://fedorahosted.org/freeipa/ticket/3813). The user plugin test

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-08-11 Thread Lenka Doudova
On 08/11/2015 10:06 AM, thierry bordaz wrote: On 08/04/2015 01:37 PM, Lenka Doudova wrote: Dne 30.7.2015 v 16:10 Martin Basti napsal(a): On 30/07/15 16:09, Martin Basti wrote: On 29/07/15 16:10, Martin Basti wrote: On 29/07/15 15:29, Lenka Doudova wrote: Hi, thanks a lot

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-08-14 Thread Lenka Doudova
two testcases that Thierry proposed, and changed names of few methods (original ones were confusing). Lenka From 05ce6f86ebb5a7889c1d55697f2b6985c3ca2d2d Mon Sep 17 00:00:00 2001 From: Lenka Doudova ldoud...@redhat.com Date: Fri, 14 Aug 2015 10:20:57 +0200 Subject: [PATCH] Automated test

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-08-14 Thread Lenka Doudova
fix the test case to reflect the new command. Lenka On 08/14/2015 05:39 PM, Martin Basti wrote: On 08/14/2015 11:04 AM, Lenka Doudova wrote: NACK syntax error, missing ')' -from ipatests.util import assert_equal, assert_not_equal, raises +from ipatests.util import ( +assert_equal

[Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-07-27 Thread Lenka Doudova
Hi, I'm attaching a patch with automated tests for stageuser plugin (https://fedorahosted.org/freeipa/ticket/3813). The user plugin test is affected as well (one class was added). The tests seem a bit of a mess even to myself, but what with the way freeipa behaves I didn't know how else to

Re: [Freeipa-devel] [PATCH 0329] Tests: fix user tracker

2015-10-26 Thread Lenka Doudova
On 10/21/2015 06:53 AM, Lenka Doudova wrote: On 10/20/2015 06:21 PM, Martin Basti wrote: On 20.10.2015 15:53, Martin Basti wrote: On 19.10.2015 14:16, Martin Basti wrote: On 19.10.2015 12:30, Martin Basti wrote: Attribute nsaccountlock has not been processed correctly Patch

Re: [Freeipa-devel] [PATCH 0329] Tests: fix user tracker

2015-11-03 Thread Lenka Doudova
On 10/26/2015 06:05 PM, Martin Basti wrote: On 26.10.2015 09:01, Lenka Doudova wrote: On 10/21/2015 06:53 AM, Lenka Doudova wrote: On 10/20/2015 06:21 PM, Martin Basti wrote: On 20.10.2015 15:53, Martin Basti wrote: On 19.10.2015 14:16, Martin Basti wrote: On 19.10.2015 12:30

Re: [Freeipa-devel] Stageuser capability in UI

2015-10-14 Thread Lenka Doudova
On 10/14/2015 09:45 AM, Petr Vobornik wrote: On 10/13/2015 04:09 PM, Lenka Doudova wrote: Hi, I've been told to do some tests of stageuser UI capabilities ASAP. I think I covered most of the test cases from test plan (http://www.freeipa.org/page/V4/User_Life-Cycle_Management/Test_Plan

Re: [Freeipa-devel] [PATCH 0329] Tests: fix user tracker

2015-10-20 Thread Lenka Doudova
On 10/20/2015 06:21 PM, Martin Basti wrote: On 20.10.2015 15:53, Martin Basti wrote: On 19.10.2015 14:16, Martin Basti wrote: On 19.10.2015 12:30, Martin Basti wrote: Attribute nsaccountlock has not been processed correctly Patch attached. Self-NACK, more fixes required

[Freeipa-devel] Stageuser capability in UI

2015-10-13 Thread Lenka Doudova
Hi, I've been told to do some tests of stageuser UI capabilities ASAP. I think I covered most of the test cases from test plan (http://www.freeipa.org/page/V4/User_Life-Cycle_Management/Test_Plan) (will check that tomorrow morning, as I need to go soon). I haven't found any really serious bug,

[Freeipa-devel] [PATCH] 0004 Fix user tracker to reflect new user-del message

2015-08-26 Thread Lenka Doudova
Fix for user tracker in ipatests/test_xmlrpc/test_user_plugin.py so that it reflects recently changed message of user-del command. Lenka From 226ea47939160ef3a164a1e8f979f52f10a7d83e Mon Sep 17 00:00:00 2001 From: Lenka Doudova ldoud...@redhat.com Date: Wed, 26 Aug 2015 16:16:43 +0200 Subject

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-04 Thread Lenka Doudova
to add a certprofile, but if I try to do is manually using 'ipa certprofile-import' command with the exact same data as used in the test, it works fine. Lenka On 09/03/2015 02:35 PM, Tomas Babej wrote: On 09/03/2015 01:40 PM, Lenka Doudova wrote: Hi, I took a look at it at Milan's request

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-03 Thread Lenka Doudova
Hi, I took a look at it at Milan's request. patch 0008 - tracker looks ok, ACK patch 0009 - test cases look ok as well, but can't get it to run, 10 out of 14 tests fail, starting with internal error, which I haven't been able to track down, nor fix it. Lenka

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-14 Thread Lenka Doudova
All good, ACK On 09/14/2015 11:54 AM, Milan Kubík wrote: On 09/14/2015 10:10 AM, Lenka Doudova wrote: NACK because: $ pep8 ipatests/test_xmlrpc/test_certprofile_plugin.py ipatests/test_xmlrpc/test_certprofile_plugin.py:213:8: E121 continuation line under-indented for hanging indent (just

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-11 Thread Lenka Doudova
On 09/10/2015 02:11 PM, Milan Kubík wrote: On 09/04/2015 03:57 PM, Martin Babinsky wrote: On 09/04/2015 11:06 AM, Lenka Doudova wrote: Hi, there's no traceback in the file you mentioned, but I'm running it through lite-server, so here's the traceback from there: http

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-11 Thread Lenka Doudova
On 09/11/2015 11:45 AM, Milan Kubík wrote: On 09/11/2015 10:27 AM, Martin Basti wrote: On 09/11/2015 09:51 AM, Lenka Doudova wrote: On 09/10/2015 02:11 PM, Milan Kubík wrote: On 09/04/2015 03:57 PM, Martin Babinsky wrote: On 09/04/2015 11:06 AM, Lenka Doudova wrote: Hi, there's

Re: [Freeipa-devel] Linking tickets in the commit messages

2015-09-17 Thread Lenka Doudova
Hi, though I'm not a fellow developer, I'd like to point out that the habit you mentioned (putting a link into commit message) is indeed documented on wiki [1]. It's just on a spot where it's not that much visible. Sorry if I misunderstood the point of your email. Lenka [1]

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-14 Thread Lenka Doudova
, Lenka Doudova wrote: On 09/11/2015 11:45 AM, Milan Kubík wrote: On 09/11/2015 10:27 AM, Martin Basti wrote: On 09/11/2015 09:51 AM, Lenka Doudova wrote: On 09/10/2015 02:11 PM, Milan Kubík wrote: On 09/04/2015 03:57 PM, Martin Babinsky wrote: On 09/04/2015 11:06 AM, Lenka

Re: [Freeipa-devel] [TESTS][PATCH 0006] Add comments to stageuser plugin tests

2015-12-09 Thread Lenka Doudova
On 12/09/2015 10:13 AM, Martin Basti wrote: On 09.12.2015 09:41, Lenka Doudova wrote: Hi, attaching fixed patches for master and ipa-4-2 branch. Also fixes test accordingly to https://fedorahosted.org/freeipa/ticket/5387. Lenka On 11/20/2015 12:13 PM, Martin Babinsky wrote: On 11/19

Re: [Freeipa-devel] [TESTS][PATCH 0006] Add comments to stageuser plugin tests

2015-12-09 Thread Lenka Doudova
Hi, attaching fixed patches for master and ipa-4-2 branch. Also fixes test accordingly to https://fedorahosted.org/freeipa/ticket/5387. Lenka On 11/20/2015 12:13 PM, Martin Babinsky wrote: On 11/19/2015 10:34 AM, Petr Viktorin wrote: On 11/19/2015 09:30 AM, Lenka Doudova wrote: On 11/18

[Freeipa-devel] [TESTS][PATCH 0007] Multiple managers per user

2015-12-15 Thread Lenka Doudova
Hi, I updated the (stage)user tests to reflect the multiple managers per user feature. Corresponding ticket: https://fedorahosted.org/freeipa/ticket/5344 Lenka From 03b4673debf019562d00d0c0f4cfcf3f295fa612 Mon Sep 17 00:00:00 2001 From: Lenka Doudova <ldoud...@redhat.com> Date: Mon,

[Freeipa-devel] [TESTS][PATCH 0008] Fix tests for (stage)user plugin

2015-12-16 Thread Lenka Doudova
Hi, this patch fixes few Tracker methods for staged and 'normal' user, which were mistakenly modified by my patch 0006.3. Applies for ipa-4-2 branch only. Lenka From f632687a338bd17f1b143fa72e040f4111510998 Mon Sep 17 00:00:00 2001 From: Lenka Doudova <ldoud...@redhat.com> Date: Wed,

[Freeipa-devel] [TESTS][PATCH 0006] Add comments to stageuser plugin tests

2015-11-18 Thread Lenka Doudova
Hi, here's a patch that adds a few comments to stageuser tests in order to allow easier determining of a problem when tests fail. Lenka From a1ec552f27eeb05f5f9c41d59e076aa6ef7601db Mon Sep 17 00:00:00 2001 From: Lenka Doudova <ldoud...@redhat.com> Date: Wed, 18 Nov 2015 09:11:29

Re: [Freeipa-devel] [TESTS][PATCH 0006] Add comments to stageuser plugin tests

2015-11-19 Thread Lenka Doudova
On 11/18/2015 04:51 PM, Martin Babinsky wrote: On 11/18/2015 02:16 PM, Lenka Doudova wrote: Hi, here's a patch that adds a few comments to stageuser tests in order to allow easier determining of a problem when tests fail. Lenka Hi Lenka, Firstly a technical detail: Python indexes lists

Re: [Freeipa-devel] [patch 0025] Separated Tracker implementations into standalone package

2015-11-23 Thread Lenka Doudova
NACK - there's a "typo" in /tracker/user_plugin.py, line 17-18: def get_user_dn(cn): return DN(('cn', cn), api.env.container_user, api.env.basedn) should be def get_user_dn(uid): return DN(('uid', uid), api.env.container_user, api.env.basedn) Some tests may fail because of

[Freeipa-devel] [Testplan] Support of UPN for trusted domains

2016-05-27 Thread Lenka Doudova
Hi all, here [1] is a draft of test plan for V4 RFE Support of UPN for trusted domains. Please review this and let me know if there's something missing or wrong. Thanks, Lenka [1] http://www.freeipa.org/page/V4/Support_of_UPN_for_trusted_domains/Test_Plan -- Manage your subscription

Re: [Freeipa-devel] [Testplan] Thin client

2016-06-01 Thread Lenka Doudova
Hi, thanks for reviewing, I changed the test plan to reflect your comments. Lenka On 05/31/2016 06:07 PM, Petr Vobornik wrote: On 05/31/2016 03:30 PM, Lenka Doudova wrote: Hi all, here's [1] a draft of test plan for V4 RFE Thin client. Please review this and let me know if there's

[Freeipa-devel] [Testplan] External trust to AD

2016-06-01 Thread Lenka Doudova
Hi all, here's [1] a draft of test plan for V4 RFE External trust to Active Directory. Please review this and let me know if there's something missing or wrong. Thanks, Lenka [1] http://www.freeipa.org/page/V4/External_trust_to_AD/Test_Plan -- Manage your subscription for the

[Freeipa-devel] [Testplan] Thin client

2016-05-31 Thread Lenka Doudova
Hi all, here's [1] a draft of test plan for V4 RFE Thin client. Please review this and let me know if there's something missing or wrong. Thanks, Lenka [1] http://www.freeipa.org/page/V4/Thin_Client/Test_Plan -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [Testplan] Authentication indicators

2016-05-31 Thread Lenka Doudova
Hi all, here's [1] a draft of test plan for V4 RFE Authentication Indicators. Please review this and let me know if there's something missing or wrong. Thanks, Lenka [1] http://www.freeipa.org/page/V4/Authentication_Indicators/Test_Plan -- Manage your subscription for the Freeipa-devel

Re: [Freeipa-devel] [PATCH 0019][Tests] Fix for failing location tests

2016-06-22 Thread Lenka Doudova
On 06/22/2016 08:33 AM, Martin Basti wrote: On 22.06.2016 07:37, Lenka Doudova wrote: On 06/21/2016 06:57 PM, Martin Basti wrote: On 21.06.2016 15:39, Lenka Doudova wrote: Hi, attaching patch for failing location tests (ipatests/test_xmlrpc/test_location_plugin.py). Lenka

Re: [Freeipa-devel] [PATCH 0019][Tests] Fix for failing location tests

2016-06-22 Thread Lenka Doudova
On 06/22/2016 04:37 PM, Lenka Doudova wrote: On 06/22/2016 08:33 AM, Martin Basti wrote: On 22.06.2016 07:37, Lenka Doudova wrote: On 06/21/2016 06:57 PM, Martin Basti wrote: On 21.06.2016 15:39, Lenka Doudova wrote: Hi, attaching patch for failing location tests (ipatests

Re: [Freeipa-devel] [PATCH 0019][Tests] Fix for failing location tests

2016-06-21 Thread Lenka Doudova
On 06/21/2016 06:57 PM, Martin Basti wrote: On 21.06.2016 15:39, Lenka Doudova wrote: Hi, attaching patch for failing location tests (ipatests/test_xmlrpc/test_location_plugin.py). Lenka Hello, 1) +expected_updates={u'ipalocation_location': [location.idnsname_obj

[Freeipa-devel] [PATCH 0014-0016][Tests] Authentication indicators

2016-06-16 Thread Lenka Doudova
not be pushed without it. Lenka From 2dfcc81b979a345dbed2449a5c30ba19fd2025ee Mon Sep 17 00:00:00 2001 From: Lenka Doudova <ldoud...@redhat.com> Date: Wed, 15 Jun 2016 13:40:00 +0200 Subject: [PATCH] Tests: Tracker class for services Provides basic service tracker, so far for purposes

[Freeipa-devel] [PATCH 0019][Tests] Fix for failing location tests

2016-06-21 Thread Lenka Doudova
Hi, attaching patch for failing location tests (ipatests/test_xmlrpc/test_location_plugin.py). Lenka From 6fc64ea5574e730c5c4c733e4e1eeb60163f6163 Mon Sep 17 00:00:00 2001 From: Lenka Doudova <ldoud...@redhat.com> Date: Tue, 21 Jun 2016 15:29:46 +0200 Subject: [PATCH] Tests: Fix for f

[Freeipa-devel] [PATCH 0018][Tests] Fix some of the failing tests in test_ipalib/test_frontend.py

2016-06-21 Thread Lenka Doudova
Hi, attaching patch with fix for a few failing tests in ipatests/test_ipalib/test_frontend.py. Lenka From 31c7c0f792820aedb4429f8a9a4766653f7fa52c Mon Sep 17 00:00:00 2001 From: Lenka Doudova <ldoud...@redhat.com> Date: Tue, 21 Jun 2016 08:17:17 +0200 Subject: [PATCH] Tests: Fix f

Re: [Freeipa-devel] [PATCH 0019][Tests] Fix for failing location tests

2016-06-23 Thread Lenka Doudova
On 06/23/2016 10:30 AM, Martin Basti wrote: On 23.06.2016 06:55, Lenka Doudova wrote: On 06/22/2016 05:11 PM, Lenka Doudova wrote: On 06/22/2016 04:37 PM, Lenka Doudova wrote: On 06/22/2016 08:33 AM, Martin Basti wrote: On 22.06.2016 07:37, Lenka Doudova wrote: On 06/21

Re: [Freeipa-devel] [PATCH 0014-0016][Tests] Authentication indicators

2016-06-22 Thread Lenka Doudova
Bump for review. Thanks. On 06/16/2016 03:23 PM, Lenka Doudova wrote: Hi, attached are tests for authentication indicators. Please note: 1. newly created service tracker is not exactly complete, list of unimplemented methods is in doc. These methods can be filled in when existing

Re: [Freeipa-devel] [PATCH 0019][Tests] Fix for failing location tests

2016-06-22 Thread Lenka Doudova
On 06/22/2016 05:11 PM, Lenka Doudova wrote: On 06/22/2016 04:37 PM, Lenka Doudova wrote: On 06/22/2016 08:33 AM, Martin Basti wrote: On 22.06.2016 07:37, Lenka Doudova wrote: On 06/21/2016 06:57 PM, Martin Basti wrote: On 21.06.2016 15:39, Lenka Doudova wrote: Hi

[Freeipa-devel] [PATCH 0020][Tests] Make ID views test reflect new krbcanonicalname attribute

2016-06-23 Thread Lenka Doudova
Patch attached. Lenka From 3a3adaaf9c2f778ad82d0138f05455b488eb870a Mon Sep 17 00:00:00 2001 From: Lenka Doudova <ldoud...@redhat.com> Date: Thu, 23 Jun 2016 15:47:03 +0200 Subject: [PATCH] Tests: Make ID views tests reflect new krbcanonicalname attribute --- ipatests/test_

[Freeipa-devel] [PATCH 0021][Tests] Fix failing ipatests/test_ipaserver/test_rpcserver.py

2016-06-24 Thread Lenka Doudova
Hi, attaching patch for one of the failing tests. Failure caused by an assertion that was no longer valid. Lenka From 9eb1ec2335145916ce0e83a6f2a9ca6bac056682 Mon Sep 17 00:00:00 2001 From: Lenka Doudova <ldoud...@redhat.com> Date: Fri, 24 Jun 2016 10:24:40 +0200 Subject: [PATCH] Test

Re: [Freeipa-devel] [TESTS][PATCH 0007] Multiple managers per user

2016-01-11 Thread Lenka Doudova
Hi, everyone having time to take a look at this? It's been hanging for a few weeks. Thanks, Lenka On 12/15/2015 12:42 PM, Lenka Doudova wrote: Hi, I updated the (stage)user tests to reflect the multiple managers per user feature. Corresponding ticket: https://fedorahosted.org/freeipa

[Freeipa-devel] [PATCH 0023][Tests] Fix frontend tests - #5987

2016-06-27 Thread Lenka Doudova
From: Lenka Doudova <ldoud...@redhat.com> Date: Tue, 28 Jun 2016 06:27:41 +0200 Subject: [PATCH] Tests: Fix frontend tests Test ipatests/test_ipalib/test_frontend.py::test_Command::test_validate fails due to attributes that are no longer present, therefore assertion for these values was r

[Freeipa-devel] [TESTS][PATCH 0009] WebUI tests fix

2016-02-11 Thread Lenka Doudova
that is no longer there. Since the checkbox is clickable directly, I changed the code accordingly. Most of the tests should now proceed successfully. Lenka From c628f695cc1441b0bde7ec41bee811fbad5fd92e Mon Sep 17 00:00:00 2001 From: Lenka Doudova <ldoud...@redhat.com> Date: Wed, 10 Feb 2016 16:16:22

[Freeipa-devel] [TESTS][PATCH 0011] WebUI: Creating user without private group

2016-02-25 Thread Lenka Doudova
b9d0d7d5887e339de24d9878b733b45a0618bb9b Mon Sep 17 00:00:00 2001 From: Lenka Doudova <ldoud...@redhat.com> Date: Thu, 25 Feb 2016 15:00:49 +0100 Subject: [PATCH] WebUI: Test creating user without private group Test for option to create a user without private group in web UI. Covers ticket

[Freeipa-devel] [TESTS][PATCH 0010] WebUI tests - ID views

2016-02-23 Thread Lenka Doudova
Hi, attached is patch providing missing test coverage for ID views in webUI. Lenka From 5940a3e7f63b7b6360a28fd52ba6c7df65e4ea98 Mon Sep 17 00:00:00 2001 From: Lenka Doudova <ldoud...@redhat.com> Date: Fri, 19 Feb 2016 14:59:19 +0100 Subject: [PATCH] WebUI test: ID views Provides missin

Re: [Freeipa-devel] [TESTS][PATCH 0009] WebUI tests fix

2016-02-16 Thread Lenka Doudova
On 02/11/2016 11:13 AM, Lenka Doudova wrote: Hi all, most of webUI tests fail with AssertionError: Can't click on checkbox label: table.table Message: Element is not clickable at point (37, 340.338964844). Other element would receive the click: type="checkbox"> The

Re: [Freeipa-devel] [TESTS][PATCH 0009] WebUI tests fix

2016-02-19 Thread Lenka Doudova
On 02/19/2016 10:51 AM, Petr Vobornik wrote: On 02/16/2016 10:10 AM, Lenka Doudova wrote: On 02/11/2016 11:13 AM, Lenka Doudova wrote: Hi all, most of webUI tests fail with AssertionError: Can't click on checkbox label: table.table Message: Element is not clickable at point (37

Re: [Freeipa-devel] [TESTS][PATCH 0011] WebUI: Creating user without private group

2016-03-18 Thread Lenka Doudova
On 03/10/2016 06:58 PM, Petr Vobornik wrote: On 03/08/2016 01:17 PM, Lenka Doudova wrote: On 03/08/2016 12:59 PM, Petr Vobornik wrote: On 03/07/2016 04:29 PM, Pavel Vomacka wrote: On 02/25/2016 03:08 PM, Lenka Doudova wrote: Hi, here's a patch for webUI tests that provides test

Re: [Freeipa-devel] [TESTS][PATCH 0011] WebUI: Creating user without private group

2016-03-08 Thread Lenka Doudova
On 03/08/2016 12:59 PM, Petr Vobornik wrote: On 03/07/2016 04:29 PM, Pavel Vomacka wrote: On 02/25/2016 03:08 PM, Lenka Doudova wrote: Hi, here's a patch for webUI tests that provides test for creating user without private group. Related to ticket https://fedorahosted.org/freeipa/ticket

Re: [Freeipa-devel] [TESTS][PATCH 0010] WebUI tests - ID views

2016-03-08 Thread Lenka Doudova
On 03/08/2016 12:43 PM, Pavel Vomacka wrote: On 02/23/2016 03:20 PM, Lenka Doudova wrote: Hi, attached is patch providing missing test coverage for ID views in webUI. Lenka Hi, Thank you for your patch. I have small one comment: The delete_associtaion() function duplicates code

Re: [Freeipa-devel] [TESTS][PATCH 0011] WebUI: Creating user without private group

2016-03-31 Thread Lenka Doudova
On 03/31/2016 12:42 PM, Pavel Vomacka wrote: On 03/18/2016 11:24 AM, Lenka Doudova wrote: On 03/10/2016 06:58 PM, Petr Vobornik wrote: On 03/08/2016 01:17 PM, Lenka Doudova wrote: On 03/08/2016 12:59 PM, Petr Vobornik wrote: On 03/07/2016 04:29 PM, Pavel Vomacka wrote: On 02/25

Re: [Freeipa-devel] [TESTS][PATCH 0011] WebUI: Creating user without private group

2016-04-14 Thread Lenka Doudova
On 04/04/2016 06:54 PM, Martin Basti wrote: On 01.04.2016 14:34, Pavel Vomacka wrote: On 03/31/2016 04:16 PM, Lenka Doudova wrote: On 03/31/2016 12:42 PM, Pavel Vomacka wrote: On 03/18/2016 11:24 AM, Lenka Doudova wrote: On 03/10/2016 06:58 PM, Petr Vobornik wrote: On 03/08/2016

Re: [Freeipa-devel] [TESTS]{PATCH 0013] Maximum username length higher than 255 cannot be set

2016-05-19 Thread Lenka Doudova
On 05/18/2016 01:51 PM, Ganna Kaihorodova wrote: - Original Message - From: "Lenka Doudova" <ldoud...@redhat.com> To: "Ganna Kaihorodova" <gkaih...@redhat.com> Sent: Wednesday, May 18, 2016 10:37:49 AM Subject: Fwd: [Freeipa-devel] [TESTS]{PATCH 0013]

[Freeipa-devel] [TESTS]{PATCH 0013] Maximum username length higher than 255 cannot be set

2016-05-13 Thread Lenka Doudova
Patch attached. Lenka From 2b6d0b4fe1a3f468e5125d521194fb10d4e654c1 Mon Sep 17 00:00:00 2001 From: Lenka Doudova <ldoud...@redhat.com> Date: Fri, 13 May 2016 12:56:03 +0200 Subject: [PATCH] Test: Maximum username length higher than 255 cannot be set https://fedorahosted.org/freeipa/

Re: [Freeipa-devel] [TESTS]{PATCH 0013] Maximum username length higher than 255 cannot be set

2016-05-18 Thread Lenka Doudova
Bump for review (Ganna) Thanks, Lenka On 05/13/2016 01:08 PM, Lenka Doudova wrote: Patch attached. Lenka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute

[Freeipa-devel] [TESTS][PATCH 0012] Provide cleanup for host certificate

2016-05-03 Thread Lenka Doudova
Hi, attached patch provides solution for https://fedorahosted.org/freeipa/ticket/5839 by removing all certificates added to local host during tests. Lenka From 031adf1f50308b70e87c93a7a853f04eae593bf0 Mon Sep 17 00:00:00 2001 From: Lenka Doudova <ldoud...@redhat.com> Date: Mon, 2 May 2

Re: [Freeipa-devel] [TESTS][PATCH 0012] Provide cleanup for host certificate

2016-05-03 Thread Lenka Doudova
On 05/03/2016 12:15 PM, Martin Basti wrote: On 03.05.2016 11:18, Lenka Doudova wrote: On 05/03/2016 10:33 AM, Martin Basti wrote: Hello I'm quite confused what is happening in that code, can you explain it more to me? I see duplicated code there. Sorry, that was just an unnecessary

[Freeipa-devel] [DESIGN REVIEW] V4/Thin client

2016-05-09 Thread Lenka Doudova
Hi, looks fine, but it would be nice to update the document so that it would reflect changes mentioned on previous email thread. Lenka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [DESIGN REVIEW] V4/Support of UPN for trusted domains

2016-05-09 Thread Lenka Doudova
Hi, design look good, no remarks. Lenka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0026][Tests] RFE: Support UPN for trusted domains

2016-07-14 Thread Lenka Doudova
On 07/13/2016 06:04 PM, Martin Babinsky wrote: On 07/01/2016 04:45 PM, Lenka Doudova wrote: On 07/01/2016 03:04 PM, Martin Babinsky wrote: On 07/01/2016 11:13 AM, Lenka Doudova wrote: And, of course, a patch file :) On 07/01/2016 11:09 AM, Lenka Doudova wrote: Hi all, here's patch

Re: [Freeipa-devel] [PATCH] webui test: bunch of patches which fix webui patches

2016-07-27 Thread Lenka Doudova
On 07/27/2016 03:00 PM, Lenka Doudova wrote: On 07/20/2016 04:43 PM, Pavel Vomacka wrote: On 07/11/2016 06:33 PM, Pavel Vomacka wrote: Hello, please review these patches. First four of them fixes patches and the last one fixes small bug in WebUI which causes that some tests fail

Re: [Freeipa-devel] [PATCH] 0078-82: webui tests: tests for new certificate widget

2016-07-28 Thread Lenka Doudova
On 07/20/2016 04:51 PM, Pavel Vomacka wrote: Please review attached patches, which add tests for new certificate widget in WebUI. https://fedorahosted.org/freeipa/ticket/6064 Hi, thanks for patches. Functionally ok, but you have lots of PEP8 errors in patches 78, 80, 81 and 82 -> NACK.

Re: [Freeipa-devel] [PATCH 0003] Test validity of URIs in certificate

2016-07-28 Thread Lenka Doudova
Hi, I cannot find any attached patch :) Lenka On 07/28/2016 01:30 PM, Peter Lacko wrote: Attached you can find a patch adding test for URIs in generated certificate ipatests/test_xmlrpc/test_cert_plugin.py Since I'm leaving Red Hat in end of July, I won't be able to modify this patch

Re: [Freeipa-devel] [PATCH 0027][Tests] Fix failing automember tests in 4.3

2016-07-29 Thread Lenka Doudova
On 07/28/2016 06:08 PM, Ganna Kaihorodova wrote: Greetings! ACK Best regards, Ganna Kaihorodova Associate Software Quality Engineer - Original Message - From: "Lenka Doudova" <ldoud...@redhat.com> To: "freeipa-devel" <freeipa-devel@redhat.com> Sent:

Re: [Freeipa-devel] [PATCH 0003] Test validity of URIs in certificate

2016-07-29 Thread Lenka Doudova
On 07/28/2016 01:35 PM, Peter Lacko wrote: Hops, fixed. Peter - Original Message - From: "Lenka Doudova" <ldoud...@redhat.com> To: freeipa-devel@redhat.com Sent: Thursday, July 28, 2016 1:32:25 PM Subject: Re: [Freeipa-devel] [PATCH 0003] Test validity of URIs in

Re: [Freeipa-devel] [PATCH 0003] Test validity of URIs in certificate

2016-07-29 Thread Lenka Doudova
On 07/29/2016 11:41 AM, Lenka Doudova wrote: On 07/28/2016 01:35 PM, Peter Lacko wrote: Hops, fixed. Peter - Original Message - From: "Lenka Doudova"<ldoud...@redhat.com> To:freeipa-devel@redhat.com Sent: Thursday, July 28, 2016 1:32:25 PM Subject: Re: [Freeipa-de

[Freeipa-devel] [PATCH 0030][Tests] Fix authentication indicators tests failing due to removal of has_keytab key from list of expected attributes of update command

2016-08-01 Thread Lenka Doudova
:00 2001 From: Lenka Doudova <ldoud...@redhat.com> Date: Mon, 1 Aug 2016 08:00:16 +0200 Subject: [PATCH] Tests: Remove has_keytab from list of expected keys of update command As part of https://fedorahosted.org/freeipa/ticket/5281, the has_keytab attribute was removed from results of servi

Re: [Freeipa-devel] [PATCH] 0078-82: webui tests: tests for new certificate widget

2016-08-01 Thread Lenka Doudova
On 07/29/2016 03:00 PM, Pavel Vomacka wrote: On 07/28/2016 08:16 AM, Lenka Doudova wrote: On 07/20/2016 04:51 PM, Pavel Vomacka wrote: Please review attached patches, which add tests for new certificate widget in WebUI. https://fedorahosted.org/freeipa/ticket/6064 Hi, thanks

Re: [Freeipa-devel] [PATCH 0022][Tests] Prevent trust test failures cause by adding duplicate DNS forward zone

2016-07-26 Thread Lenka Doudova
On 06/30/2016 01:14 PM, Martin Basti wrote: On 30.06.2016 12:58, Lenka Doudova wrote: On 06/30/2016 12:51 PM, Petr Spacek wrote: On 30.6.2016 12:32, Lenka Doudova wrote: On 06/29/2016 07:49 PM, Petr Spacek wrote: On 29.6.2016 18:52, Lenka Doudova wrote: On 06/29/2016 06:51 PM, Petr

Re: [Freeipa-devel] [PATCH] webui test: bunch of patches which fix webui patches

2016-07-27 Thread Lenka Doudova
On 07/20/2016 04:43 PM, Pavel Vomacka wrote: On 07/11/2016 06:33 PM, Pavel Vomacka wrote: Hello, please review these patches. First four of them fixes patches and the last one fixes small bug in WebUI which causes that some tests fail. https://fedorahosted.org/freeipa/ticket/6050

Re: [Freeipa-devel] [PATCH 0003] Test validity of URIs in certificate

2016-08-02 Thread Lenka Doudova
On 07/29/2016 11:43 AM, Lenka Doudova wrote: On 07/29/2016 11:41 AM, Lenka Doudova wrote: On 07/28/2016 01:35 PM, Peter Lacko wrote: Hops, fixed. Peter - Original Message - From: "Lenka Doudova"<ldoud...@redhat.com> To:freeipa-devel@redhat.com Sent: Thursday,

Re: [Freeipa-devel] [PATCH 0196] baseldap: Fix MidairCollision instantiation during entry modification

2016-08-04 Thread Lenka Doudova
On 07/26/2016 05:22 PM, Alexander Bokovoy wrote: On Tue, 26 Jul 2016, Martin Babinsky wrote: Fix for https://fedorahosted.org/freeipa/ticket/6097 Since this issue was found during investigation of other ticket[1], you can test it by performing steps to reproduce #6041, but instead of

[Freeipa-devel] [PATCH 0031, 0032][Tests] Fixes for failing test_ipalib/test_messages tests

2016-08-15 Thread Lenka Doudova
Hi, attached are patches that are fixing 3 failing tests in test_ipalib/test_messages.py. Lenka From 11bd09d8b82630b959deebe265320221db815540 Mon Sep 17 00:00:00 2001 From: Lenka Doudova <ldoud...@redhat.com> Date: Mon, 15 Aug 2016 11:10:57 +0200 Subject: [PATCH 1/2] Fix mal

Re: [Freeipa-devel] [PATCH 0003] Test validity of URIs in certificate

2016-08-11 Thread Lenka Doudova
On 08/10/2016 05:48 PM, Martin Basti wrote: On 08.08.2016 10:30, Martin Basti wrote: On 02.08.2016 14:50, Lenka Doudova wrote: On 07/29/2016 11:43 AM, Lenka Doudova wrote: On 07/29/2016 11:41 AM, Lenka Doudova wrote: On 07/28/2016 01:35 PM, Peter Lacko wrote: Hops, fixed

Re: [Freeipa-devel] [PATCH 0014-0016][Tests] Authentication indicators

2016-07-14 Thread Lenka Doudova
On 07/13/2016 04:48 PM, Milan Kubík wrote: On 07/11/2016 01:34 PM, Lenka Doudova wrote: On 07/08/2016 02:24 PM, Milan Kubík wrote: On 07/01/2016 05:13 PM, Lenka Doudova wrote: On 07/01/2016 02:42 PM, Milan Kubík wrote: On 06/16/2016 03:23 PM, Lenka Doudova wrote: Hi, attached

Re: [Freeipa-devel] [PATCH 0014-0016][Tests] Authentication indicators

2016-07-14 Thread Lenka Doudova
On 07/14/2016 09:20 AM, Lenka Doudova wrote: On 07/13/2016 04:48 PM, Milan Kubík wrote: On 07/11/2016 01:34 PM, Lenka Doudova wrote: On 07/08/2016 02:24 PM, Milan Kubík wrote: On 07/01/2016 05:13 PM, Lenka Doudova wrote: On 07/01/2016 02:42 PM, Milan Kubík wrote: On 06/16/2016 03

Re: [Freeipa-devel] [PATCH 0014-0016][Tests] Authentication indicators

2016-07-14 Thread Lenka Doudova
On 07/14/2016 11:25 AM, Lenka Doudova wrote: On 07/14/2016 09:20 AM, Lenka Doudova wrote: On 07/13/2016 04:48 PM, Milan Kubík wrote: On 07/11/2016 01:34 PM, Lenka Doudova wrote: On 07/08/2016 02:24 PM, Milan Kubík wrote: On 07/01/2016 05:13 PM, Lenka Doudova wrote: On 07/01

Re: [Freeipa-devel] [PATCH 0025][Tests] RFE: External trust

2016-07-14 Thread Lenka Doudova
On 07/13/2016 05:40 PM, Martin Babinsky wrote: On 07/01/2016 04:15 PM, Lenka Doudova wrote: On 07/01/2016 02:38 PM, Martin Babinsky wrote: On 07/01/2016 06:36 AM, Lenka Doudova wrote: On 06/30/2016 05:01 PM, Martin Babinsky wrote: On 06/30/2016 03:47 PM, Lenka Doudova wrote: Hi

Re: [Freeipa-devel] [PATCH 0025][Tests] RFE: External trust

2016-07-18 Thread Lenka Doudova
On 07/18/2016 04:55 PM, Martin Babinsky wrote: On 07/14/2016 11:42 AM, Lenka Doudova wrote: On 07/13/2016 05:40 PM, Martin Babinsky wrote: On 07/01/2016 04:15 PM, Lenka Doudova wrote: On 07/01/2016 02:38 PM, Martin Babinsky wrote: On 07/01/2016 06:36 AM, Lenka Doudova wrote: On 06

[Freeipa-devel] [PATCH 0029][Tests] Adding authentication test to trust test suite

2016-07-19 Thread Lenka Doudova
Sep 17 00:00:00 2001 From: Lenka Doudova <ldoud...@redhat.com> Date: Mon, 18 Jul 2016 14:38:18 +0200 Subject: [PATCH] Tests: Adding authentication test to basic trust test suite Providing missing test case verifying authentication as IPA user, namely "kinit -E ipauser@IPAD

Re: [Freeipa-devel] [PATCH 0024][Tests] Fix integration tests not to produce incorrect /etc/hosts file

2016-07-19 Thread Lenka Doudova
). Lenka On 06/29/2016 06:27 PM, Lenka Doudova wrote: Hi all, a function 'fix_etc_hosts' in ipatests/test_integration/tasks.py produces incorrect /etc/hosts file (solitary IPv6 address), and currently parser is not able to resolve the issue, causing ipa-server-install to fail with 'list index ou

Re: [Freeipa-devel] [PATCH 0028][Tests] Fix failing user tests

2016-07-20 Thread Lenka Doudova
On 07/20/2016 02:04 PM, Martin Babinsky wrote: On 07/15/2016 06:10 PM, Lenka Doudova wrote: Hi, here's patch with fix for failing user tests, specifically tests with renaming users. Failures were caused by RFE Kerberos principal aliases. As part of the fix, I had to rewrite few of the tests

[Freeipa-devel] [PATCH 0027][Tests] Fix failing automember tests in 4.3

2016-07-13 Thread Lenka Doudova
2001 From: Lenka Doudova <ldoud...@redhat.com> Date: Wed, 13 Jul 2016 15:14:11 +0200 Subject: [PATCH] Tests: Fix failing automember tests Two tests in xmlrpc/automember suite were failing as a result of manager data normalization in user attributes. Tests are fixed to reflect the

Re: [Freeipa-devel] [PATCH 0022][Tests] Prevent trust test failures cause by adding duplicate DNS forward zone

2016-06-27 Thread Lenka Doudova
On 06/27/2016 10:04 AM, Petr Vobornik wrote: On 06/27/2016 09:42 AM, Lenka Doudova wrote: Hi! With newly created AD machines in Brno lab, existing trust tests fail on 'ipa dnsforwardzone-add' command claiming the zone is already present, as new AD domain is dom-221.idm.lab.eng.brq.redhat.com

Re: [Freeipa-devel] [PATCH 0022][Tests] Prevent trust test failures cause by adding duplicate DNS forward zone

2016-06-27 Thread Lenka Doudova
On 06/27/2016 10:33 AM, Martin Babinsky wrote: On 06/27/2016 10:28 AM, Petr Spacek wrote: On 27.6.2016 10:26, Petr Spacek wrote: On 27.6.2016 10:18, Martin Babinsky wrote: On 06/27/2016 10:04 AM, Petr Vobornik wrote: On 06/27/2016 09:42 AM, Lenka Doudova wrote: Hi! With newly created AD

Re: [Freeipa-devel] [PATCH 0167] test_serverroles: ensure that test API is initialized with correct ldap_uri

2016-06-27 Thread Lenka Doudova
On 06/27/2016 02:04 PM, Martin Babinsky wrote: Makes the test suite play nice with others during CI. https://fedorahosted.org/freeipa/ticket/6000 ACK, thank you! Lenka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH 0022][Tests] Prevent trust test failures cause by adding duplicate DNS forward zone

2016-06-27 Thread Lenka Doudova
the forward zone, but in case of non-zero return code will check the message if it says that the forward zone is already configured, and lets the tests continue, if it is so. Lenka From 33761de592e867d63665ebe974dbec7c29294367 Mon Sep 17 00:00:00 2001 From: Lenka Doudova <ldoud...@redhat.

Re: [Freeipa-devel] [Testplan] Support of UPN for trusted domains

2016-07-11 Thread Lenka Doudova
On 07/07/2016 11:13 AM, Sumit Bose wrote: On Fri, May 27, 2016 at 11:24:24AM +0300, Alexander Bokovoy wrote: On Fri, 27 May 2016, Sumit Bose wrote: On Fri, May 27, 2016 at 09:57:37AM +0200, Lenka Doudova wrote: Hi all, here [1] is a draft of test plan for V4 RFE Support of UPN for trusted

Re: [Freeipa-devel] [PATCH 0014-0016][Tests] Authentication indicators

2016-07-11 Thread Lenka Doudova
On 07/08/2016 02:24 PM, Milan Kubík wrote: On 07/01/2016 05:13 PM, Lenka Doudova wrote: On 07/01/2016 02:42 PM, Milan Kubík wrote: On 06/16/2016 03:23 PM, Lenka Doudova wrote: Hi, attached are tests for authentication indicators. Please note: 1. newly created service tracker

Re: [Freeipa-devel] [PATCH] 0002 New User Role Tests

2016-08-08 Thread Lenka Doudova
On 07/20/2016 05:31 PM, Peter Lacko wrote: Sorry for late reply, I was waiting how the discussion with tracker improvement will end, but since there's no progress and I'm leaving soon, I'm attaching new patch. I also created mapping between old and new tests [1], to make life of reviewer

Re: [Freeipa-devel] [PATCH 0029][Tests] Adding authentication test to trust test suite

2016-07-22 Thread Lenka Doudova
On 07/20/2016 02:28 PM, Martin Babinsky wrote: On 07/19/2016 10:41 AM, Lenka Doudova wrote: Hi, this patch adds authentication test (specifically "kinit -E ipauser@IPADOMAIN") to basic trust test suite, as requested by Sumit. Intended to be applied after my patches 25.4 and 26.

Re: [Freeipa-devel] [PATCH 0022][Tests] Prevent trust test failures cause by adding duplicate DNS forward zone

2016-06-30 Thread Lenka Doudova
On 06/30/2016 12:32 PM, Lenka Doudova wrote: On 06/29/2016 07:49 PM, Petr Spacek wrote: On 29.6.2016 18:52, Lenka Doudova wrote: On 06/29/2016 06:51 PM, Petr Spacek wrote: On 29.6.2016 18:48, Lenka Doudova wrote: On 06/27/2016 11:05 AM, Lenka Doudova wrote: On 06/27/2016 10:33 AM

  1   2   >