Re: [gem5-dev] Review Request: SLICC: Add a check function for State Machine

2011-06-10 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/723/#review1320 --- src/mem/slicc/symbols/StateMachine.py

Re: [gem5-dev] Single Header File for Debug Flags

2011-06-09 Thread nathan binkert
Well, I guess the recompilation tradeoff is worth the temporary annoyance of adding the specific debug flag header file everywhere. I'm also hoping that the new changes will allow us to eventually make compound flags of compound flags. The changes are already in the tree (and have been for a

Re: [gem5-dev] [m5-dev] Review Request: stats: move code that loops over all stats into python

2011-06-08 Thread nathan binkert
I'm trying to call a global function implemented in C++ from a function in the Python __init__.py file, how can I do that? Is that a good example that I can follow? Just add your function foo() to src/python/swig/core.i and then you can access it from m5.internal.core.foo() Most of the

Re: [gem5-dev] changeset in m5: scons: rename TraceFlags to DebugFlags

2011-06-08 Thread nathan binkert
Why not just let TraceFlags be interpreted as DebugFlags, so TraceFlags still works for users. For better or worse, I renamed trace flags to debug flags and I should have changed the name of TraceFlags to DebugFlags when I did that, so this was just correcting that and removing an

Re: [gem5-dev] Single Header File for Debug Flags

2011-06-08 Thread nathan binkert
What do people (mostly Nate) think about having a single header file for all debug flags? Instead of #include debug/MyFlag.hh for every flag you want in a DPRINTF, you could say #include debug/debugflags.hh and that would cover all the debug flags available for DPRINTF. Would that (the old

Re: [gem5-dev] Single Header File for Debug Flags

2011-06-08 Thread nathan binkert
Oh, and I forgot. Compound flags generate a header file as well. debug/O3CPUAll.hh for example would have all of the flags that O3CPUAll covers On Wed, Jun 8, 2011 at 9:40 PM, nathan binkert n...@binkert.org wrote: What do people (mostly Nate) think about having a single header file for all

Re: [gem5-dev] [m5-dev] Review Request: stats: move code that loops over all stats into python

2011-06-06 Thread nathan binkert
Where in the code is the signal from kill -USR1 handled to dump stats? % grep -nR USR1 src src/sim/init.cc:97:signal(SIGUSR1, dumpStatsHandler); ___ gem5-dev mailing list gem5-dev@m5sim.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request: copyright: clean up copyright blocks

2011-06-02 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/725/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[gem5-dev] Review Request: copyright: Add code for finding all copyright blocks and create a COPYING file

2011-06-02 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/726/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[gem5-dev] Review Request: scons: rename TraceFlags to DebugFlags

2011-06-02 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/728/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[gem5-dev] Review Request: scons: rename some things from m5 to gem5

2011-06-02 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/727/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[gem5-dev] changeset in m5: copyright: clean up copyright blocks

2011-06-02 Thread Nathan Binkert
changeset 23711432221f in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=23711432221f description: copyright: clean up copyright blocks diffstat: src/arch/alpha/kgdb.h | 4 ++-- src/arch/alpha/remote_gdb.cc |

[gem5-dev] changeset in m5: copyright: Add code for finding all copyright b...

2011-06-02 Thread Nathan Binkert
+Copyright (c) 2006-2009 Nathan Binkert +Copyright (c) 2001 The NetBSD Foundation, Inc. +Copyright (c) 2010-2011 Gabe Black +Copyright (c) 1994 Adam Glass +Copyright (c) 1990-1992 MIPS Computer Systems, Inc. +Copyright (c) 2004 Richard J. Wagner +Copyright (c) 2000 Computer Engineering and Communication

[gem5-dev] changeset in m5: scons: rename some things from m5 to gem5

2011-06-02 Thread Nathan Binkert
changeset 483e936f44f0 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=483e936f44f0 description: scons: rename some things from m5 to gem5 The default generated binary is now gem5.type instead of m5.type. The latter does still work but gem5.type will be

[gem5-dev] changeset in m5: scons: rename TraceFlags to DebugFlags

2011-06-02 Thread Nathan Binkert
changeset 9228e00459d4 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=9228e00459d4 description: scons: rename TraceFlags to DebugFlags diffstat: src/SConscript | 2 - src/arch/SConscript | 6 +- src/arch/arm/SConscript

[gem5-dev] Debug Flags

2011-06-01 Thread nathan binkert
Ok, there has been a lot of confusion about debug flags and trace flags. I changed the way the flags stuff worked from a compile perspective which required me to make changes throughout the tree, so I took the opportunity to rename the trace flags to debug flags. The idea behind the change was

Re: [gem5-dev] Debug Flags

2011-06-01 Thread nathan binkert
together and partially distinguishing them that leads to confusion. The mental model is different from the way you have to control things, and trying to reconcile the two views makes the system hard to reason about. Gabe Quoting nathan binkert n...@binkert.org: Ok, there has been a lot

Re: [gem5-dev] registerThreadContext

2011-05-27 Thread nathan binkert
For #1 and #4, these  are pretty much the same right? The contextID is really all possible sharers rather then just threadContext. Seems like you should keep the meaning of contextID as it pertains to thread and then generate a sharerID that would be a superset of the contextIDs. Objects that

Re: [gem5-dev] Review Request: Config: Add support for a Self.all proxy object

2011-05-27 Thread Nathan Binkert
/ --- (Updated 2011-05-26 19:17:18) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- Config: Add support for a Self.all proxy object Diffs - src/python/m5/SimObject.py 3f37cc5d25bc src/python/m5

[gem5-dev] Review Request: style: Make the style hook work in directories other than the root.

2011-05-24 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/714/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[gem5-dev] Review Request: grammar: better encapsulation of a grammar and parsing

2011-05-24 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/715/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[gem5-dev] Review Request: slicc: cleanup slicc code and make it less verbose

2011-05-24 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/716/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[gem5-dev] Review Request: slicc: add a protocol statement and an include statement

2011-05-24 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/717/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[gem5-dev] changeset in m5: style: Make the style hook work in directories ...

2011-05-24 Thread Nathan Binkert
changeset 8b0eee09deaf in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=8b0eee09deaf description: style: Make the style hook work in directories other than the root. diffstat: util/style.py | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) diffs

Re: [gem5-dev] Review Request: util/regress: make default action a more thorough regression

2011-05-20 Thread nathan binkert
So I played around with this, and the first problem is that your current code can't handle default values. I fixed that in options.py, but it still doesn't print the defaults nicely, e.g., instead of: --test-variants=TEST_VARIANTS comma-separated build variants

Re: [gem5-dev] Review Request: Ruby: Convert to M5 Stats

2011-05-18 Thread Nathan Binkert
On 2011-05-17 12:13:18, Nathan Binkert wrote: src/mem/ruby/profiler/AddressProfiler.cc, line 235 http://reviews.m5sim.org/r/704/diff/1/?file=12593#file12593line235 .name should really have name() as part of the name. Is the AddressProfiler not a SimObject() ? Derek Hower

[gem5-dev] changeset in m5: gcc: fix an uninitialized variable warning from...

2011-05-18 Thread Nathan Binkert
changeset d1ce92fd3245 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=d1ce92fd3245 description: gcc: fix an uninitialized variable warning from G++ 4.5 diffstat: src/arch/arm/isa/insts/macromem.isa | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diffs (13

Re: [gem5-dev] Review Request: Ruby: Convert to M5 Stats

2011-05-18 Thread Nathan Binkert
On 2011-05-17 12:13:18, Nathan Binkert wrote: src/mem/ruby/profiler/Profiler.cc, line 456 http://reviews.m5sim.org/r/704/diff/1/?file=12599#file12599line456 How did you pick this magic number? Can we at least make it a constant that is defined in a header file

Re: [gem5-dev] Review Request: Ruby: Convert to M5 Stats

2011-05-18 Thread nathan binkert
I agree that makes sense in some instances, but I've found that when you do that, it makes it hard to extract stats that can compare to runs of different systems. For example, when I'm comparing stats across different systems, I want to easily compare how many times a coherency miss fell

[gem5-dev] Review Request: gcc: fix an uninitialized variable warning from G++ 4.5

2011-05-17 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/705/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

Re: [gem5-dev] Review Request: Ruby: Convert to M5 Stats

2011-05-17 Thread Nathan Binkert
: --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/704/ --- (Updated 2011-05-16 15:06:16) Review request for Default, Nathan Binkert, Korey Sewell, and Brad Beckmann. Summary

Re: [gem5-dev] Review Request: Ruby: Convert to M5 Stats

2011-05-17 Thread nathan binkert
I had trouble getting my individual patches uploaded to review board (it said they were diffs?), so I merged them into one. You should ignore the first request that came through, as it is included below. In the future, it's best to use the reviewboard mercurial extension and use the command

Re: [gem5-dev] Review Request: Ruby: Convert to M5 Stats

2011-05-17 Thread nathan binkert
These histograms dynamically size. Does the default in M5 do the same? and using the same resizing algorithm? The histogram itself dynamically resizes, but the vector that's here doesn't need to be dynamic. Nate ___ gem5-dev mailing list

Re: [m5-dev] Review Request: O3: Removed unnecessary unserialize instruction flags.

2011-05-13 Thread Nathan Binkert
/ --- (Updated 2011-05-13 14:34:53) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- O3: Removed unnecessary unserialize instruction flags. Diffs - src/arch/alpha/isa/decoder.isa 54a65799e4c1 Diff: http

Re: [m5-dev] Review Request: stats: better expose statistics to python.

2011-05-12 Thread Nathan Binkert
/#comment1694 Actually, this is fixed in the subsequent diff. This code is already in the tree and was just part of the rename from stats.py to stats/__init__.py - Nathan On 2011-05-10 06:08:21, Nathan Binkert wrote

Re: [m5-dev] Review Request: stats: better expose statistics to python.

2011-05-12 Thread Nathan Binkert
--- On 2011-05-10 06:08:21, Nathan Binkert wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/689

[m5-dev] changeset in m5: stats: better expose statistics to python.

2011-05-12 Thread Nathan Binkert
; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY -# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT -# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE -# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -# -# Authors: Nathan Binkert

[m5-dev] changeset in m5: stats: move code that loops over all stats into...

2011-05-12 Thread Nathan Binkert
changeset be7f03723412 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=be7f03723412 description: stats: move code that loops over all stats into python diffstat: src/base/SConscript | 2 - src/base/statistics.cc | 60

[m5-dev] changeset in m5: stats: delete mysql support

2011-05-12 Thread Nathan Binkert
OUT OF THE USE - * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - * - * Authors: Nathan Binkert - */ - -#include iostream - -#include base/mysql.hh -#include base/trace.hh -#include debug/SQL.hh - -using namespace std; - -namespace MySQL { - -inline const char * -charstar

Re: [m5-dev] Review Request: stats: move code that loops over all stats into python

2011-05-11 Thread Nathan Binkert
an m5op or from kill -USR1, you don't want to dump twice in the same cycle because stuff just doesn't work well. - Nathan On 2011-05-10 06:08:36, Nathan Binkert wrote: --- This is an automatically generated e-mail. To reply, visit

Re: [m5-dev] Review Request: stats: better expose statistics to python.

2011-05-11 Thread Nathan Binkert
/#comment1692 yeah, yeah. src/python/m5/stats/__init__.py http://reviews.m5sim.org/r/689/#comment1693 good point. - Nathan On 2011-05-10 06:08:21, Nathan Binkert wrote: --- This is an automatically generated e-mail. To reply, visit

[m5-dev] Review Request: stats: better expose statistics to python.

2011-05-10 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/689/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[m5-dev] Review Request: stats: move code that loops over all stats into python

2011-05-10 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/690/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[m5-dev] Review Request: stats: delete mysql support

2011-05-10 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/691/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[m5-dev] gem5 Tutorial @ ISCA 2011

2011-05-09 Thread nathan binkert
Call for Participation: ISCA 2011 Tutorial gem5: A Multiple-ISA Full System Simulator with Detailed Memory Modeling Sunday, June 5, 2011 http://www.gem5.org The gem5 simulator is a merger of two of the computer architecture community’s most popular, open source simulators: M5 and GEMS. The best

[m5-dev] changeset in m5: work around gcc 4.5 warning

2011-05-09 Thread Nathan Binkert
changeset 44f8c2507d85 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=44f8c2507d85 description: work around gcc 4.5 warning diffstat: src/cpu/inorder/resource_pool.cc | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diffs (21 lines): diff -r db269e704d07

Re: [m5-dev] [m5-users] Tracing does not work

2011-05-07 Thread nathan binkert
I was thinking og doing it since Nate is not around. I'll do it soon. instance, trace-flags, and trace-file are still accepted, but they don't do anything now.  They should be eliminated from the message.  We're also missing the equivalent of trace-start and trace-file.  Do you mind

Re: [m5-dev] Review Request: Cache: fix vector stats in classic cache to have matching lengths

2011-05-05 Thread nathan binkert
I don't know.  Is it?  I haven't opened a file in dev/ in years.  Does this involve changing all device models?  Changing something in a port interface?  Which?  I don't know.  I have not looked into it at all.  I tried to page out as little of what I was doing to fix this vector length

[m5-dev] changeset in m5: debug: fix help output

2011-05-04 Thread Nathan Binkert
3f49ed206f46 -r 5a9a639ce16f src/python/m5/debug.py --- a/src/python/m5/debug.pyMon May 02 12:40:32 2011 -0700 +++ b/src/python/m5/debug.pyWed May 04 10:08:08 2011 -0400 @@ -26,24 +26,36 @@ # # Authors: Nathan Binkert +from UserDict import DictMixin + import internal +from internal.debug

Re: [m5-dev] changeset in m5: debug: fix help output

2011-05-04 Thread nathan binkert
-start=TIME      Start tracing at TIME (must be in ticks) --trace-file=FILE       Sets the output file for tracing [Default: cout] --trace-ignore=EXPR     Ignore EXPR sim objects On Wed, May 4, 2011 at 7:07 AM, Nathan Binkert n...@binkert.org wrote: changeset 5a9a639ce16f in /z/repo/m5

Re: [m5-dev] Review Request: ruby-stats: support for dump_stats instruction

2011-05-04 Thread Nathan Binkert
to change the name of base/time.hh's version of Time. Nathan Binkert wrote: While I wouldn't be opposed to changing the time in base/time.hh if we needed both, but don't we need to move ruby away from its own version of Time anyway? Shouldn't we be using Tick? Also, we've

Re: [m5-dev] changeset in m5: debug: fix help output

2011-05-04 Thread nathan binkert
So --trace-start, --trace-ignore, and --trace-file didn't get renamed? Yeah, the idea was that there was more to the flags than tracing, but the start, ignore, and file things were specific to tracing. Nate ___ m5-dev mailing list m5-dev@m5sim.org

Re: [m5-dev] Review Request: Trace: Allow printing ASIDs and selectively tracing based on user/kernel code.

2011-05-04 Thread Nathan Binkert
) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- Trace: Allow printing ASIDs and selectively tracing based on user/kernel code. Debug flags are ExecUser, ExecKernel, and ExecAsid. ExecUser and ExecKernel are set by default when Exec

Re: [m5-dev] Review Request: ruby-stats: support for dump_stats instruction

2011-05-03 Thread Nathan Binkert
for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- ruby-stats: support for dump_stats instruction *** NOTE: The core changes for this diff are in Profiler.cc/hh, stat_control.hh/cc, and pseudo_inst.cc This is a first pass toward getting dump

Re: [m5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-05-02 Thread Nathan Binkert
request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- SConstruct: automatically update .hg/hgrc with style hooks Seems easier than pestering people about it. Note also that path is now absolute, so you don't get errors when invoking hg from

Re: [m5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-05-02 Thread Nathan Binkert
On 2011-05-02 12:51:56, Nathan Binkert wrote: SConstruct, line 247 http://reviews.m5sim.org/r/668/diff/1/?file=12211#file12211line247 Should we prompt the user for permission? That way the user would at least know that something happened. Steve Reinhardt wrote: I doubt

Re: [m5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-05-02 Thread Nathan Binkert
:34:56) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- SConstruct: automatically update .hg/hgrc with style hooks Seems easier than pestering people about it. Note also that path is now absolute, so you don't get errors

Re: [m5-dev] Review Request: Debug: Add a function to cause the simulator to create a checkpoint from GDB.

2011-05-02 Thread Nathan Binkert
/ --- (Updated 2011-05-02 15:42:09) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- Debug: Add a function to cause the simulator to create a checkpoint from GDB. Diffs

Re: [m5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-05-02 Thread Nathan Binkert
On 2011-05-02 12:51:56, Nathan Binkert wrote: SConstruct, line 243 http://reviews.m5sim.org/r/668/diff/1/?file=12211#file12211line243 I know you didn't change this, but should we check for both hooks? (I added the pre-qrefresh one a while ago) Steve Reinhardt wrote

Re: [m5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-05-02 Thread Nathan Binkert
On 2011-05-02 12:51:56, Nathan Binkert wrote: SConstruct, line 247 http://reviews.m5sim.org/r/668/diff/1/?file=12211#file12211line247 Should we prompt the user for permission? That way the user would at least know that something happened. Steve Reinhardt wrote: I doubt

Re: [m5-dev] Review Request: debug: fix help output

2011-04-28 Thread Nathan Binkert
want a reference in the constructor for sure because I don't want people to pass NULL or anything like that. Since I want a reference in the constructor, it's easier to have a reference here. - Nathan On 2011-04-28 16:48:33, Nathan Binkert wrote

[m5-dev] Code Reviewing

2011-04-27 Thread nathan binkert
Hi Everyone, We don't have an official policy on code reviews, but I think we're being a bit pedantic with them. While I definitely want us to err on the side of having code review is the author has any doubt, I think it is completely unnecessary to have reviews on things like changing comments

Re: [m5-dev] Review Request: ruby: moved topology to the top network directory

2011-04-23 Thread Nathan Binkert
/ --- (Updated 2011-04-22 15:16:44) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- ruby: moved topology to the top network directory Moved the Topology class to the top network directory because it is shared

Re: [m5-dev] Review Request: network: convert links switches to first class C++ SimObjects

2011-04-23 Thread Nathan Binkert
: --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/653/ --- (Updated 2011-04-22 15:16:58) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary

Re: [m5-dev] Review Request: Util: Replace mkblankimage.sh with the new gem5img.py.

2011-04-23 Thread nathan binkert
I looked at it and it is similar, but it's different enough that they can't be interchanged. My functions all allow passing a string in as standard input and return the error code, but readCommand doesn't. I could extend it to take an input string, but it's not clear how to return the

Re: [m5-dev] Review Request: Util: Replace mkblankimage.sh with the new gem5img.py.

2011-04-23 Thread nathan binkert
All that said, if you want to take the script and move things into m5.util, or rework it so it uses m5.util, or make it handle paths better, or whatever, I certainly won't try to stop you. I think my version is an improvement over the original, but it's definitely not perfect. I didn't mean

Re: [m5-dev] Review Request: O3: Tighten memory order violation checking to 16 bytes.

2011-04-22 Thread nathan binkert
be there and is hit during some miss speculation. - Ali On March 30th, 2011, 8:41 a.m., Ali Saidi wrote: Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. By Ali Saidi. *Updated 2011-03-30 08:41:48* Description O3: Tighten memory order violation checking

Re: [m5-dev] what scons can do

2011-04-22 Thread nathan binkert
Is that 1%/99% a statement of a clean build for m5.fast?  I think the much more common case is you edit one .cc file and rebuild.  In that situation, it sure seems like a lot more than 1% of the time is spent by scons regenerating and reanalyzing SLICC files. Whatever it may be, it sure

Re: [m5-dev] Review Request: Cache: fix vector stats in classic cache to have matching lengths

2011-04-22 Thread Nathan Binkert
request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- Cache: fix vector stats in classic cache to have matching lengths Diffs - configs/common/CacheConfig.py 914389024c33 src/cpu/base.cc 914389024c33 src/mem/cache/BaseCache.py

Re: [m5-dev] Review Request: Cache: fix vector stats in classic cache to have matching lengths

2011-04-22 Thread Nathan Binkert
On 2011-04-22 18:51:32, Nathan Binkert wrote: src/mem/cache/base.hh, line 503 http://reviews.m5sim.org/r/654/diff/1/?file=11759#file11759line503 This can pretty easily be done with a template: template class STAT void incThreadVectorStat(PacketPtr pkt, STAT

[m5-dev] changeset in m5: stats: one more name violation

2011-04-22 Thread Nathan Binkert
changeset acf4b902c02e in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=acf4b902c02e description: stats: one more name violation diffstat: src/cpu/o3/lsq_unit_impl.hh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diffs (12 lines): diff -r 914389024c33 -r

[m5-dev] changeset in m5: stats: ensure that stat names are valid

2011-04-22 Thread Nathan Binkert
changeset d69720504203 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=d69720504203 description: stats: ensure that stat names are valid diffstat: src/base/statistics.cc | 34 ++ 1 files changed, 34 insertions(+), 0 deletions(-) diffs

[m5-dev] changeset in m5: tests: updates for stat name change

2011-04-22 Thread Nathan Binkert
changeset 6e368a935ac0 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=6e368a935ac0 description: tests: updates for stat name change diffstat: tests/long/00.gzip/ref/alpha/tru64/o3-timing/simout | 4 +-

[m5-dev] changeset in m5: python: fix another bug from changes to main.py

2011-04-21 Thread Nathan Binkert
changeset 914389024c33 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=914389024c33 description: python: fix another bug from changes to main.py diffstat: configs/common/cpu2000.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diffs (12 lines): diff -r

Re: [m5-dev] what scons can do

2011-04-21 Thread nathan binkert
A mechanism where I can say binary foo needs file bar, and then when I tell it to build foo it build's it with bar, and bar doesn't get mixed in to other things. I think you're new widget that was like mercurial patch guards would help with that, right? You could have a guard for each extra

Re: [m5-dev] what scons can do

2011-04-21 Thread nathan binkert
That doesn't really fit with how the ISA files work. They get broken into an AST, but that gets consumed as it goes, Does it have to be? and it has a lot of anonymous python in it that just gets executed somehow. I want to move more into the python, so the AST will be less and less useful.

Re: [m5-dev] what scons can do

2011-04-21 Thread nathan binkert
Are you sure?  Running SLICC every time just to get a (typically unchanging) list of files is not exactly instantaneous, and the names of the SLICC output files hardly ever change.  What about this approach: It is pretty fast (and this includes starting the python interpreter) 0.48s user 0.03s

Re: [m5-dev] Stats Bug

2011-04-20 Thread nathan binkert
There's more to it than that.  I started it yesterday and I'll post a diff today and you can see what I mean. So one question to you Nate, is what do you prefer, doing a single #if FULL_SYSTEM in the C++, or doing a if buildEnv[FULL_SYSTEM] in the python so that the value passed into the C++

Re: [m5-dev] Error while compiling (changeset 8229)

2011-04-20 Thread nathan binkert
Nate, since I have provided the option USE_MYSQL=False, why should mysql.hh even come in to picture? Because that file is being included regardless. I'm actively trying to squash all of these bugs and I'll be committing some changes soon. This one is trivial to fix. Nate

[m5-dev] changeset in m5: fix some build problems from prior changesets

2011-04-20 Thread Nathan Binkert
changeset a9d06c894afe in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=a9d06c894afe description: fix some build problems from prior changesets diffstat: src/arch/arm/interrupts.hh| 1 + src/arch/arm/linux/system.cc | 1 + src/arch/arm/table_walker.cc | 3 +++

Re: [m5-dev] Error while compiling (changeset 8229)

2011-04-20 Thread nathan binkert
Because that file is being included regardless.  I'm actively trying to squash all of these bugs and I'll be committing some changes soon. This one is trivial to fix. I can't reproduce this bug on my machine, even with USE_MYSQL=False. Can you try the attached diff? If it works for you, feel

[m5-dev] Review Request: stats: rename stats so they can be used as python expressions

2011-04-19 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/645/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

Re: [m5-dev] Bad Stats Names

2011-04-19 Thread nathan binkert
) On Tue, Apr 19, 2011 at 1:53 PM, nathan binkert n...@binkert.org wrote: The python stats stuff exposes all stats as python variables.  (Making scripting far easier). While I can support stat names that are not valid python expressions, stuff works far better if stats names are valid python

Re: [m5-dev] Stats Bug

2011-04-19 Thread nathan binkert
I love that you guys want to fix this. Can we agree on the immediate fix so it's no longer broken and then improve it? :) Thanks, Nate I suppose you could do that kind of walking, though I think it would be overly complicated.  Let's say again you have 4 private L1s, 2 shared L2s, and a

Re: [m5-dev] Stats Bug

2011-04-19 Thread nathan binkert
I think the immediate fix is the pythonic fix from a few msgs ago.  I believe that's quick and easy.  I think :). The fix has to be more than python. I'm talking about the original question. The stats use three different lengths: _numCpus + 1, _numCpus, or maxThreadsPerCPU. Which one is

[m5-dev] changeset in m5: python: different import for dealing with deman...

2011-04-19 Thread Nathan Binkert
changeset 24406820a7e0 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=24406820a7e0 description: python: different import for dealing with demandimport diffstat: src/python/m5/__init__.py | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diffs (16 lines):

[m5-dev] changeset in m5: stats: rename stats so they can be used as pyth...

2011-04-19 Thread Nathan Binkert
changeset 38befb82b2c9 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=38befb82b2c9 description: stats: rename stats so they can be used as python expressions diffstat: src/cpu/inorder/pipeline_stage.cc | 2 +- src/cpu/inorder/resource_pool.9stage.cc | 39

[m5-dev] Review Request: cache: properly initialize vector stats that are per context

2011-04-19 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/646/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

Re: [m5-dev] Stats Bug

2011-04-19 Thread nathan binkert
Yes, Steve's got it right.  In the C++ you replace the instances of the 3 lengths Nate mentions with a single var (that can be more aptly named as Steve wants) that is pythonically calculated and passed in from the configuration.  I'm making up words here :). I think I can do this tonight or

[m5-dev] Stats Bug

2011-04-18 Thread nathan binkert
I'm trying to get my python stats stuff committed and I found a bug in the classic cache stats. Look in src/mem/cache/base.cc. The VectorStats have several different lengths _numCpus + 1, _numCpus, or maxThreadsPerCPU. The fact that this works in the current stats package is lucky. I can be

Re: [m5-dev] Stats Bug

2011-04-18 Thread nathan binkert
serious? Gabe Quoting nathan binkert n...@binkert.org:  I'm trying to get my python stats stuff committed and I found a bug in the classic cache stats.  Look in src/mem/cache/base.cc.  The VectorStats have several different lengths _numCpus + 1, _numCpus, or maxThreadsPerCPU. The fact

Re: [m5-dev] Review Request: Util: Replace mkblankimage.sh with the new gem5img.py.

2011-04-18 Thread Nathan Binkert
: http://reviews.m5sim.org/r/644/ --- (Updated 2011-04-18 02:37:48) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- Util: Replace mkblankimage.sh with the new gem5img.py

[m5-dev] changeset in m5: file_types: Make code work in Python 2.4

2011-04-17 Thread Nathan Binkert
changeset a660cabc3ea6 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=a660cabc3ea6 description: file_types: Make code work in Python 2.4 diffstat: util/file_types.py | 5 - 1 files changed, 4 insertions(+), 1 deletions(-) diffs (15 lines): diff -r 6381dc8bcfcc

[m5-dev] changeset in m5: style: remove extra debugging print

2011-04-17 Thread Nathan Binkert
changeset b83e07b4541d in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=b83e07b4541d description: style: remove extra debugging print diffstat: util/style.py | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diffs (11 lines): diff -r a660cabc3ea6 -r

Re: [m5-dev] Cron m5test@zizzer /z/m5/regression/do-regression --scratch all

2011-04-17 Thread nathan binkert
Argh. I guess different versions of python deal with this differently too. I'll try to fix this tonight. Stupid demandimport. Nate Deleting build didn't seem to do anything. Traceback (most recent call last):  File string, line 1, in module  File

[m5-dev] changeset in m5: style: fix all_regions code and remove bogus re...

2011-04-17 Thread Nathan Binkert
changeset d8ec0a7b3f0c in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=d8ec0a7b3f0c description: style: fix all_regions code and remove bogus region type diffstat: util/style.py | 6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diffs (23 lines): diff -r

Re: [m5-dev] Cron m5test@zizzer /z/m5/regression/do-regression quick

2011-04-16 Thread nathan binkert
This is likely due to my push last night, though I ran the full regression suite before I pushed. My guess is that the directory needs to be blown away so a fresh build can happen. Can someone do that for me? I'm in the car about to go camping. Nate On Sat, Apr 16, 2011 at 12:56 AM, Cron

Re: [m5-dev] Bug in changeset 8225 or 8227

2011-04-16 Thread nathan binkert
What version of python are you using? It could be that that syntax wasn't available until 2.5 and you're using something older. I can't do anything about it right now because I'm about to leave on a hike. Nate Nate, it seems one of your checkins from yesterday has a bug. I receive the

[m5-dev] changeset in m5: python: figure out if the m5.internal package e...

2011-04-15 Thread Nathan Binkert
changeset 95fe5c720cfa in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=95fe5c720cfa description: python: figure out if the m5.internal package exists even with demandimport diffstat: src/python/m5/__init__.py | 7 ++- 1 files changed, 6 insertions(+), 1

[m5-dev] changeset in m5: SortedDict: add functions for getting ranges of...

2011-04-15 Thread Nathan Binkert
changeset 394cb2dc3f7c in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=394cb2dc3f7c description: SortedDict: add functions for getting ranges of keys, values, items diffstat: src/python/m5/util/sorteddict.py | 61 1 files

  1   2   3   4   5   6   7   8   9   10   >