[gem5-dev] Review Request 2991: misc: add a vimrc that mathces gem5 style guide

10928:e712d7d61644 --- misc: add a vimrc that mathces gem5 style guide Diffs - util/vi/vimrc PRE-CREATION Diff: http://reviews.gem5.org/r/2991/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5

Re: [gem5-dev] Review Request 2991: misc: add a vimrc that mathces gem5 style guide

Description (updated) --- Changeset 10928:2887789ee53c --- misc: add a vimrc that mathces gem5 style guide Diffs (updated) - util/vi/vimrc PRE-CREATION Diff: http://reviews.gem5.org/r/2991/diff/ Testing --- Thanks, Tony Gutierrez

Re: [gem5-dev] Review Request 2991: misc: add a vimrc that mathces gem5 style guide

find it distracting. Sure, I've added them. - Tony --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2991/#review6823 ------

Re: [gem5-dev] Review Request 2991: misc: add a vimrc that mathces gem5 style guide

Description (updated) --- Changeset 10928:1b60547a7fa4 --- misc: add a vimrc that mathces gem5 style guide Diffs (updated) - util/vi/vimrc PRE-CREATION Diff: http://reviews.gem5.org/r/2991/diff/ Testing --- Thanks, Tony Gutierrez

Re: [gem5-dev] Review Request 2991: misc: add a vimrc that mathces gem5 style guide

Description (updated) --- Changeset 10928:dc89ce497741 --- misc: add a vimrc that mathces gem5 style guide Diffs (updated) - util/vi/vimrc PRE-CREATION Diff: http://reviews.gem5.org/r/2991/diff/ Testing --- Thanks, Tony Gutierrez

Re: [gem5-dev] Review Request 2963: mem: Make caches way aware

src/mem/cache/tags/base_set_assoc.hh (line 327) <http://reviews.gem5.org/r/2963/#comment5924> Curly braces for this function and the next should be on a new line. - Tony Gutierrez On July 28, 2015, 3:15 a.m., Andreas Hansson wrote: > >

Re: [gem5-dev] Review Request 2784: mem: MSHR livelock bug fix

during his internship at AMD. Diffs - src/mem/packet_queue.cc fbdaa08aaa426b9f4660c366f934ccb670d954ec Diff: http://reviews.gem5.org/r/2784/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http

Re: [gem5-dev] Review Request 2862: ruby: Change PerfectCacheMemory::lookup to return pointer

> On July 31, 2015, 7:24 a.m., Joel Hestness wrote: > > Bump. AMD is planning to push patches today, but I'm not sure what was > > decided on the SLICC getPointer patch (http://reviews.gem5.org/r/2786/). > > Note that this fix to PerfectCacheMemory should make the getPointer patch > > unnecess

Re: [gem5-dev] Review Request 3003: mem: Remove extraneous acquire/release flags and attributes

ation going. There arem more flags our APU model - which we plan to release publically soon - has added as well. - Tony Gutierrez On Aug. 5, 2015, 1:51 a.m., Andreas Hansson wrote: > > --- > This is an automatically generated e-

Re: [gem5-dev] Review Request 3003: mem: Remove extraneous acquire/release flags and attributes

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3003/#review6907 --- Ship it! Ship It! - Tony Gutierrez On Aug. 5, 2015, 1:51 a.m

Re: [gem5-dev] Review Request 3004: mem: Cleanup packet attributes and rely on command type

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3004/#review6906 --- Ship it! Ship It! - Tony Gutierrez On Aug. 6, 2015, 2:41 p.m

Re: [gem5-dev] Review Request 3034: base: fix small memory leak in the ELF loader

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3034/#review6935 --- Ship it! Ship It! - Tony Gutierrez On Aug. 12, 2015, 2:19 p.m

Re: [gem5-dev] Review Request 3005: ruby: consumer: pass on the current tick to wakeup() function

argument. Please post a full patch showing how this will be used, so proper reviews can be done. - Tony Gutierrez On Aug. 9, 2015, 11:24 a.m., Nilay Vaish wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: [gem5-dev] Review Request 3005: ruby: consumer: pass on the current tick to wakeup() function

> On Aug. 13, 2015, 11:27 a.m., Tony Gutierrez wrote: > > This patch is simply changing the API without making use of the new > > argument. Please post a full patch showing how this will be used, so proper > > reviews can be done. > > Nilay Vaish wrote: > L

Re: [gem5-dev] Review Request 3045: mem: Use C++11 delegating constructors for Request

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3045/#review7024 --- Ship it! Ship It! - Tony Gutierrez On Aug. 19, 2015, 2:06 a.m

Re: [gem5-dev] Review Request 3014: ruby: set: reimplement using std::bitset

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3014/#review7038 --- Ship it! Ship It! - Tony Gutierrez On Aug. 9, 2015, 11:26 a.m

Re: [gem5-dev] Review Request 3014: ruby: set: reimplement using std::bitset

> On Aug. 17, 2015, 2:37 p.m., Jieming Yin wrote: > > src/mem/ruby/common/NetDest.cc, line 113 > > > > > > m_bits[i].getSize() returns NUMBER_BITS_PER_SET, which is 64 for all > > machine types. In case of broadcast, all bi

Re: [gem5-dev] Review Request 2965: rename System.{hh, cc} to RubySystem.{hh, cc}

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2965/#review7107 --- Are they comments on this? We'd like to ship this soon. -

Re: [gem5-dev] Review Request 2965: rename System.{hh, cc} to RubySystem.{hh, cc}

> On Sept. 3, 2015, 11:36 a.m., Tony Gutierrez wrote: > > Are they comments on this? We'd like to ship this soon. > > Nilay Vaish wrote: > Has hg mv been used to move those two files? We can do hg mv or hg rm/hg add. What

Re: [gem5-dev] Review Request 3005: ruby: consumer: pass on the current tick to wakeup() function

> On Sept. 8, 2015, 5:22 p.m., Nilay Vaish wrote: > > Any more comments before it push this to the repo? > > Jason Lowe-Power wrote: > I agree with Tony that this seems like a lot of changes for a small > benefit. At a minumum I would like to know what the performance benefit > actually is

[gem5-dev] Review Request 3111: ruby: fix message buffer init order

, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3111: ruby: fix message buffer init order

/SimpleNetwork.cc 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd src/mem/slicc/symbols/StateMachine.py 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd Diff: http://reviews.gem5.org/r/3111/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev

Re: [gem5-dev] Review Request 3111: ruby: fix message buffer init order

- Tony --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3111/#review7171 --- On Sept. 14, 2015, 10:37 a.m., Tony Gutierrez wrote: &

[gem5-dev] Review Request 3112: slicc: export uint64_t instead of uint64

11096:dd686487b6d7 --- slicc: export uint64_t instead of uint64 Diffs - src/mem/protocol/RubySlicc_Exports.sm 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd Diff: http://reviews.gem5.org/r/3112/diff/ Testing --- Thanks, Tony Gutierrez

Re: [gem5-dev] Review Request 3112: slicc: export uint64_t instead of uint64

Exports.sm 1a9ecb4fe05e86fc7af4e4dcf616412274a3e7cd Diff: http://reviews.gem5.org/r/3112/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 2965: rename System.{hh, cc} to RubySystem.{hh, cc}

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2965/#review7175 --- Any last comments? I plan to ship this before the EoD today. - Tony

[gem5-dev] Review Request 3122: ruby: update WireBuffer API to match that of MessageBuffer

11232:1b03783440b5 --- ruby: update WireBuffer API to match that of MessageBuffer this patch updates the WireBuffer API to mirror the changes in revision 1 Diffs - Diff: http://reviews.gem5.org/r/3122/diff/ Testing --- Thanks, Tony Gutierrez

Re: [gem5-dev] Review Request 3122: ruby: update WireBuffer API to match that of MessageBuffer

4872dbdea907265734b7469786382b0fcdd2e385 src/mem/ruby/structures/WireBuffer.cc 4872dbdea907265734b7469786382b0fcdd2e385 src/mem/slicc/symbols/StateMachine.py 4872dbdea907265734b7469786382b0fcdd2e385 Diff: http://reviews.gem5.org/r/3122/diff/ Testing --- Thanks, Tony Gutierrez

Re: [gem5-dev] Review Request 3122: ruby: update WireBuffer API to match that of MessageBuffer

lly generated e-mail. To reply, visit: http://reviews.gem5.org/r/3122/#review7202 --- On Sept. 17, 2015, 9:39 a.m., Tony Gutierrez wrote: > > --- > This is an automatically ge

[gem5-dev] changeset in gem5: ruby: update WireBuffer API to match that of ...

changeset d6fb95dbf3e2 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=d6fb95dbf3e2 description: ruby: update WireBuffer API to match that of MessageBuffer this patch updates the WireBuffer API to mirror the changes in revision 1 diffstat: src/mem/ruby

Re: [gem5-dev] Review Request 3124: ruby: print addresses in hex

g/r/3124/#comment6125> std::string& ? - Tony Gutierrez On Sept. 18, 2015, 6:40 a.m., Nilay Vaish wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://r

Re: [gem5-dev] Review Request 3124: ruby: print addresses in hex

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3124/#review7217 --- Ship it! Ship It! - Tony Gutierrez On Sept. 18, 2015, 6:40 a.m

Re: [gem5-dev] Review Request 3106: syscall_emul: Bandage readlink /proc/self/exe

uld be revisited once an FS redirection scheme is in place, the lack of which is causing the real problem. - Tony Gutierrez On Sept. 20, 2015, 10:06 a.m., Joel Hestness wrote: > > --- > This is an automatically generated e-mail. To reply

[gem5-dev] Review Request 3176: ruby: imported from reviewboard patch 2550

: http://reviews.gem5.org/r/3176/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3177: ruby: imported from reviewboard patch 2551

4daf60db14d794e2344a6c86a93bdd8273bc5bb6 Diff: http://reviews.gem5.org/r/3177/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3179: ruby: Fixed pipeline squashes caused by aliased requests

Diff: http://reviews.gem5.org/r/3179/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3180: mem: add request types for acquire and release

4daf60db14d794e2344a6c86a93bdd8273bc5bb6 src/mem/packet.cc 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 src/mem/request.hh 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 Diff: http://reviews.gem5.org/r/3180/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev

[gem5-dev] Review Request 3178: ruby: cleaner ruby tester support

, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3181: cpu: Add store-access operations

4daf60db14d794e2344a6c86a93bdd8273bc5bb6 src/mem/ruby/system/Sequencer.cc 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 Diff: http://reviews.gem5.org/r/3181/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5

[gem5-dev] Review Request 3193: ruby: added stl vector of ints to be used by SLICC

src/mem/ruby/common/IntVec.cc PRE-CREATION Diff: http://reviews.gem5.org/r/3193/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3192: ruby: split CPU and GPU latency stats

/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3187: slicc: fixes for the Address to Addr changeset (11025)

/slicc_interface/RubySlicc_Util.hh 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 src/mem/slicc/symbols/Transition.py 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 Diff: http://reviews.gem5.org/r/3187/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev

[gem5-dev] Review Request 3182: sim: support for distcc pump server settings

11188:ba88f221e3e4 --- sim: support for distcc pump server settings Diffs - SConstruct 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 Diff: http://reviews.gem5.org/r/3182/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5

[gem5-dev] Review Request 3183: mem: increase arbitrary limit on the packet queue

11189:d89321a4dac4 --- mem: increase arbitrary limit on the packet queue Diffs - src/mem/packet_queue.cc 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 Diff: http://reviews.gem5.org/r/3183/diff/ Testing --- Thanks, Tony Gutierrez

[gem5-dev] Review Request 3190: ruby: fixed latency memory controller

--- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3188: syscall_emul: don't check host fd when allocating target fd

src/sim/process.cc 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 Diff: http://reviews.gem5.org/r/3188/diff/ Testing ------- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3185: mem: support for scoped atomics in GPU ruby protocols

://reviews.gem5.org/r/3185/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3191: ext: add a simple emulated cl-runtime for the gpu

/cl_command_queue.h PRE-CREATION SConstruct 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 ext/cl-runtime/CL/cl.h PRE-CREATION ext/cl-runtime/CL/cl.hpp PRE-CREATION Diff: http://reviews.gem5.org/r/3191/diff/ Testing --- Thanks, Tony Gutierrez

[gem5-dev] Review Request 3186: ruby: fillMask helper function

11192:34f9a235f2f4 --- ruby: fillMask helper function Diffs - src/mem/protocol/RubySlicc_Exports.sm 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 Diff: http://reviews.gem5.org/r/3186/diff/ Testing --- Thanks, Tony Gutierrez

[gem5-dev] Review Request 3184: ruby: add BoolVec

://reviews.gem5.org/r/3184/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3189: gpu: AMD's baseline GPU model

src/gpu/arch/hsail/insts/gpu_static_inst.hh PRE-CREATION src/gpu/arch/hsail/insts/gpu_static_inst.cc PRE-CREATION src/gpu/arch/hsail/insts/main.cc PRE-CREATION src/gpu/arch/hsail/insts/mem.hh PRE-CREATION Diff: http://reviews.gem5.org/r/3189/diff/ Testing --- Thanks, Tony Guti

Re: [gem5-dev] Review Request 3186: ruby: fillMask helper function

-- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3186/#review7436 --- On Oct. 30, 2015, 2:52 p.m., Tony Gutierrez wrote: > > ---

Re: [gem5-dev] Review Request 3191: ext: add a simple emulated cl-runtime for the gpu

wiki about the runtime as well as the GPU model itself. - Tony --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3191/#review7447 ------

Re: [gem5-dev] Review Request 3179: ruby: Fixed pipeline squashes caused by aliased requests

ht, we'll update that patch and close this one. - Tony --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3179/#review7445 ------

Re: [gem5-dev] Review Request 3189: gpu: AMD's baseline GPU model

-mail. To reply, visit: http://reviews.gem5.org/r/3189/#review7428 --- On Oct. 30, 2015, 2:52 p.m., Tony Gutierrez wrote: > > --- > This is an automa

Re: [gem5-dev] Review Request 3185: mem: support for scoped atomics in GPU ruby protocols

/DataBlock.cc 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 src/mem/protocol/RubySlicc_Types.sm 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 src/mem/request.hh 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 Diff: http://reviews.gem5.org/r/3185/diff/ Testing --- Thanks, Tony Gutierrez

[gem5-dev] Review Request 3199: misc: add object files and static libs to .hgignore

11188:2912767b09d8 --- misc: add object files and static libs to .hgignore Diffs - .hgignore 854e61d5390e3bee8864848465fab311e95b9759 Diff: http://reviews.gem5.org/r/3199/diff/ Testing --- Thanks, Tony Gutierrez

Re: [gem5-dev] Review Request 3199: misc: add object files and static libs to .hgignore

//reviews.gem5.org/r/3199/#review7515 --- On Nov. 5, 2015, 3:46 p.m., Tony Gutierrez wrote: > > --- > This is an automatically generated e-mail. To

Re: [gem5-dev] Review Request 3199: misc: add object files and static libs to .hgignore

refer that the ignores > > are more specific than all .a and .o files. > > Tony Gutierrez wrote: > .o and .a files are typically left in util/m5/ > > Joel Hestness wrote: > Ok, in that case, can you please change these ignores to util/m5/*.a and > util/m5/*.o

Re: [gem5-dev] Review Request 3192: ruby: split CPU and GPU latency stats

://reviews.gem5.org/r/3192/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3185: mem: misc flags for AMD gpu model

/DataBlock.hh 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 src/mem/ruby/slicc_interface/RubyRequest.hh 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 src/mem/ruby/system/RubyPort.cc 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 Diff: http://reviews.gem5.org/r/3185/diff/ Testing --- Thanks, Tony Gutierrez

[gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

src/mem/protocol/RubySlicc_Exports.sm 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 src/mem/request.hh 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 Diff: http://reviews.gem5.org/r/3205/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing

[gem5-dev] Review Request 3206: mem: write combining for ruby protocols

: http://reviews.gem5.org/r/3206/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3185: mem: misc flags for AMD gpu model

457 ------- On Nov. 12, 2015, 1:59 p.m., Tony Gutierrez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3185/ &g

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

5/#comment6501> Joel's comment from 3185: This flag doesn't appear to be used anywhere... - Tony Gutierrez On Nov. 12, 2015, 2:05 p.m., Tony Gutierrez wrote: > > --- > This is an automatically generated

Re: [gem5-dev] Review Request 3185: mem: misc flags for AMD gpu model

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3185/#review7566 --- - Tony Gutierrez On Nov. 12, 2015, 1:59 p.m., Tony Gutierrez wrote

Re: [gem5-dev] Review Request 3185: mem: misc flags for AMD gpu model

205 and 3206), and I think I moved over all of your unaddressed comments to their relevant patches. - Tony --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3185/#review7448 --- On Nov. 12, 2015, 1

Re: [gem5-dev] Review Request 3183: mem: add boolean to disable PacketQueue's size sanity check

t_queue.hh 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 src/mem/packet_queue.cc 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 Diff: http://reviews.gem5.org/r/3183/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem

Re: [gem5-dev] Review Request 3183: mem: add boolean to disable PacketQueue's size sanity check

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3183/#review7426 --- On Nov. 12, 2015, 2:58 p.m., Tony Gutierrez wrote: > > --

Re: [gem5-dev] Review Request 3183: mem: add boolean to disable PacketQueue's size sanity check

ue.cc 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 Diff: http://reviews.gem5.org/r/3183/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3183: mem: add boolean to disable PacketQueue's size sanity check

guide any new standards need to be maintained on the wiki in one location. - Tony --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3183/#review7569 -----

Re: [gem5-dev] Review Request 3183: mem: add boolean to disable PacketQueue's size sanity check

ue.cc 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 Diff: http://reviews.gem5.org/r/3183/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3183: mem: add boolean to disable PacketQueue's size sanity check

eply, visit: http://reviews.gem5.org/r/3183/#review7569 --- On Nov. 12, 2015, 3:54 p.m., Tony Gutierrez wrote: > > --- > This is an automatically generated e-mai

Re: [gem5-dev] Review Request 3183: mem: add boolean to disable PacketQueue's size sanity check

ue.cc 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 Diff: http://reviews.gem5.org/r/3183/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3183: mem: add boolean to disable PacketQueue's size sanity check

ue.cc 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 Diff: http://reviews.gem5.org/r/3183/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3183: sim: support for distcc pump server settings

Diff: http://reviews.gem5.org/r/3183/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3182: sim: support for distcc pump server settings

Description (updated) --- Changeset 11207:e5a917a3a9da --- sim: support for distcc pump server settings Diffs (updated) - SConstruct 2375b33bddc61ea484b3bd194ba02f7889095624 Diff: http://reviews.gem5.org/r/3182/diff/ Testing --- Thanks, Tony

Re: [gem5-dev] Review Request 3183: mem: add boolean to disable PacketQueue's size sanity check

src/mem/packet_queue.hh 2375b33bddc61ea484b3bd194ba02f7889095624 src/mem/packet_queue.cc 2375b33bddc61ea484b3bd194ba02f7889095624 Diff: http://reviews.gem5.org/r/3183/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem

Re: [gem5-dev] Review Request 3189: gpu: AMD's baseline GPU model

ed e-mail. To reply, visit: http://reviews.gem5.org/r/3189/#review7453 --- On Oct. 30, 2015, 2:52 p.m., Tony Gutierrez wrote: > > --- > This is an au

[gem5-dev] changeset in gem5: slicc: fixes for the Address to Addr changese...

changeset d5a7a4da9f63 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=d5a7a4da9f63 description: slicc: fixes for the Address to Addr changeset (11025) misc changes now that Address has become Addr including int to address util function diffstat: s

Re: [gem5-dev] Review Request 3182: sim: support for distcc pump server settings

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3182/#review7582 --- Any more comments on this? I plan to ship this soon. - Tony Gutierrez

Re: [gem5-dev] Review Request 3188: syscall_emul: don't check host fd when allocating target fd

. - Tony Gutierrez On Oct. 30, 2015, 2:52 p.m., Tony Gutierrez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

) - src/mem/packet.hh c0ea80fed78fef29ad2829b9d93e7bd568c46665 src/mem/packet.cc c0ea80fed78fef29ad2829b9d93e7bd568c46665 src/mem/request.hh c0ea80fed78fef29ad2829b9d93e7bd568c46665 Diff: http://reviews.gem5.org/r/3180/diff/ Testing --- Thanks, Tony Gutierrez

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

://reviews.gem5.org/r/3180/#review7429 --- On Nov. 19, 2015, 1:07 p.m., Tony Gutierrez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3180/ >

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

------ On Nov. 19, 2015, 1:07 p.m., Tony Gutierrez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3180/ > -

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

) - src/mem/packet.hh c0ea80fed78fef29ad2829b9d93e7bd568c46665 src/mem/packet.cc c0ea80fed78fef29ad2829b9d93e7bd568c46665 src/mem/request.hh c0ea80fed78fef29ad2829b9d93e7bd568c46665 Diff: http://reviews.gem5.org/r/3180/diff/ Testing --- Thanks, Tony Gutierrez

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

) - src/mem/packet.hh c0ea80fed78fef29ad2829b9d93e7bd568c46665 src/mem/packet.cc c0ea80fed78fef29ad2829b9d93e7bd568c46665 src/mem/request.hh c0ea80fed78fef29ad2829b9d93e7bd568c46665 Diff: http://reviews.gem5.org/r/3180/diff/ Testing --- Thanks, Tony Gutierrez

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

) - src/mem/packet.hh c0ea80fed78fef29ad2829b9d93e7bd568c46665 src/mem/packet.cc c0ea80fed78fef29ad2829b9d93e7bd568c46665 src/mem/request.hh c0ea80fed78fef29ad2829b9d93e7bd568c46665 Diff: http://reviews.gem5.org/r/3180/diff/ Testing --- Thanks, Tony Gutierrez

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

On Nov. 20, 2015, 5:33 a.m., Tony Gutierrez wrote: > > I am still not really understanding the request and the packet part. How > > are the two related (are they)? I have a patch to undo the packet ACQ/REL changes, and will post it soon. Honestly I think the original author of th

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

) - src/mem/request.hh c0ea80fed78fef29ad2829b9d93e7bd568c46665 Diff: http://reviews.gem5.org/r/3180/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3234: mem: remove aqcuire/release cmd from packet

, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

On Nov. 20, 2015, 5:33 a.m., Tony Gutierrez wrote: > > I am still not really understanding the request and the packet part. How > > are the two related (are they)? > > Tony Gutierrez wrote: > I have a patch to undo the packet ACQ/REL changes, and will post it soon. &

Re: [gem5-dev] Review Request 3188: syscall_emul: don't check host fd when allocating target fd

> On Nov. 14, 2015, 8:50 a.m., Tony Gutierrez wrote: > > I will be shipping this today unless somebody voices an objection. > > Nilay Vaish wrote: > Do you think it would be better if the function took the driver variable > as an input param? > May be

Re: [gem5-dev] Review Request 3234: mem: remove acq/rel cmds from packet and add mem fence req

needed, however a generic MemFence req/resp is added. Diffs (updated) - src/mem/packet.hh c0ea80fed78fef29ad2829b9d93e7bd568c46665 src/mem/packet.cc c0ea80fed78fef29ad2829b9d93e7bd568c46665 Diff: http://reviews.gem5.org/r/3234/diff/ Testing --- Thanks, Tony Gutierrez

Re: [gem5-dev] Review Request 3234: mem: remove acq/rel cmds from packet and add mem fence req

rg/r/3234/#review7709 --- On Dec. 7, 2015, 1:06 p.m., Tony Gutierrez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://re

Re: [gem5-dev] Review Request 3178: ruby: more flexible ruby tester support

c0ea80fed78fef29ad2829b9d93e7bd568c46665 Diff: http://reviews.gem5.org/r/3178/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3178: ruby: more flexible ruby tester support

this asap, could you guys please give it a quick review to make sure we addressed your comments. Thanks. - Tony Gutierrez On Dec. 8, 2015, 1:31 p.m., Tony Gutierrez wrote: > > --- > This is an automatically generated e-ma

Re: [gem5-dev] Review Request 3178: ruby: more flexible ruby tester support

This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3178/#review7713 --- On Dec. 8, 2015, 1:31 p.m., Tony Gutierrez wrote: > > --- > This is an a

Re: [gem5-dev] Review Request 3234: mem: remove acq/rel cmds from packet and add mem fence req

> On Dec. 7, 2015, 2:04 p.m., Andreas Hansson wrote: > > No objections...but could you give a hint as to how they will be used? > > Tony Gutierrez wrote: > These are currently used by packets that encapsulate acq/rel requests. > Instead of using specific acq/req cmds

Re: [gem5-dev] Review Request 3180: mem: add request types for acquire and release

pping this. Do we have a ship it from you? Thanks. - Tony Gutierrez On Nov. 20, 2015, 1:52 p.m., Tony Gutierrez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://review

  1   2   3   4   5   >