RE: Python version auditing followup

> From: Junio C Hamano [mailto:gits...@pobox.com] > Sent: Thursday, December 20, 2012 10:39 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: Python version auditing followup > > "Joachim Schmitz" writes: > > > Junio C Hamano wrote: > >> I personally would think 2.6 is recent eno

[PATCH v2] mergetools/p4merge: Honor $TMPDIR for the /dev/null placeholder

Use $TMPDIR when creating the /dev/null placeholder for p4merge. This keeps it out of the current directory. Reported-by: Jeremy Morton Signed-off-by: David Aguilar --- No mktemp usage in this round. mergetools/p4merge | 27 +-- 1 file changed, 13 insertions(+), 14 dele

Thomas Sabo Deutschland

Die Sammlung von Thomas Sabo Deutschland für den Herbst-Winter 2009 ist eine Wut unter den Liebhabern von Sterling Silber. Dieser Bereich hat seine Inspiration bilden die beliebte ikonische Puppe namens Barbie. Es war im Jahr 2009, dass Barbie das Alter v

Re: [PATCH] Python scripts audited for minimum compatible version and checks added.

I needed something like this on top of it to get it pass t5800. diff --git a/git_remote_helpers/git/__init__.py b/git_remote_helpers/git/__init__.py index 776e891..5047fd4 100644 --- a/git_remote_helpers/git/__init__.py +++ b/git_remote_helpers/git/__init__.py @@ -1,3 +1,5 @@ +import sys + if sy

[PATCH v7 6/7] tests: test the test framework more thoroughly

From: Adam Spiers Add 5 new full test suite runs each with a different number of passing/failing/broken/fixed tests, in order to ensure that the correct exit code and output are generated in each case. As before, these are run in a subdirectory to avoid disrupting the metrics for the parent test

[PATCH v7 7/7] tests: paint unexpectedly fixed known breakages in bold red

From: Adam Spiers Change color of unexpectedly fixed known breakages to bold red. An unexpectedly passing test indicates that the test code is somehow broken or out of sync with the code it is testing. Either way this is an error which is potentially as bad as a failing test, and as such is no

[PATCH v7 5/7] tests: refactor mechanics of testing in a sub test-lib

From: Adam Spiers This will allow us to test the test framework more thoroughly without disrupting the top-level test metrics. Signed-off-by: Adam Spiers Signed-off-by: Junio C Hamano --- t/t-basic.sh | 85 ++-- 1 file changed, 40 insert

[PATCH v7 4/7] tests: change info messages from yellow/brown to cyan

From: Adam Spiers Now that we've adopted a "traffic lights" coloring scheme, yellow is used for warning messages, so we need to re-color info messages to something less alarmist. Blue is a universal color for informational messages; however we are using that for skipped tests in order to align w

[PATCH v7 3/7] tests: paint skipped tests in blue

From: Adam Spiers Skipped tests indicate incomplete test coverage. Whilst this is not a test failure or other error, it's still not a complete success. Other testsuite related software like automake, autotest and prove seem to use blue for skipped tests, so let's follow suit. Signed-off-by: Ad

[PATCH v7 2/7] tests: paint known breakages in yellow

From: Adam Spiers Yellow seems a more appropriate color than bold green when considering the universal traffic lights coloring scheme, where green conveys the impression that everything's OK, and amber that something's not quite right. Likewise, change the color of the summarized total number of

[PATCH v7 1/7] tests: test number comes first in 'not ok $count - $message'

From: Adam Spiers The old output to say "not ok - 1 messsage" was working by accident only because the test numbers are optional in TAP. Signed-off-by: Adam Spiers Signed-off-by: Junio C Hamano --- t/t-basic.sh | 4 ++-- t/test-lib.sh| 2 +- 2 files changed, 3 insertions(+), 3 deletio

[PATCH v7 0/7] coloring test output after traffic signal

To conclude the bikeshedding discussion we had today, here is what I queued by squashing stuff into relevant patches, so that people can eyeball the result for the last time. Adam Spiers (7): tests: test number comes first in 'not ok $count - $message' tests: paint known breakages in yellow

Re: [PATCH] Documentation/git-clean: Document --force --force

Soren Brinkmann writes: > Ping? I *think* it is a mistake for the command to remove a separate project repository within, with any number of "-f", so I'd rather see a patch to fix it, instead of casting such a misbehaviour as a feature in stone by documenting it. I dunno. > On Thu, Dec 13, 201

Re: [PATCH] Documentation/git-update-index: caution about tree objects

Greg Troxel writes: > While one can add tree objects to the index, this is not currently > useful. Therefore, use "git ls-tree -r" as the example to be fed to > --index-info. Add a section explaining about expected index contents. > (Thanks to Junio for explaining this to me in August of 2011.)

Re: Noob Question

Hi! On 21 December 2012 12:07, awingnut wrote: > My main questions center around the git repository and accessing it. The main thing you need to know is that you can work on your code base in the *exact* same way while using git. You don't *have* to change anything about how you work, as git's p

[PATCH] Documentation/git-update-index: caution about tree objects

While one can add tree objects to the index, this is not currently useful. Therefore, use "git ls-tree -r" as the example to be fed to --index-info. Add a section explaining about expected index contents. (Thanks to Junio for explaining this to me in August of 2011.) Signed-off-by: Greg Troxel

Noob Question

I have not used git yet but am planning to. I am trying to get my head around how it will work and the documentation I found so far is of modest help. I currently have a Java application developed using Eclipse on Windows. However, the project is located on a Linux shared drive which is my Eclipse

Re: [PATCH] Documentation/git-clean: Document --force --force

Ping? On Thu, Dec 13, 2012 at 05:46:55PM -0800, Soren Brinkmann wrote: > This patch documents the behavior of 'git clean' when > encountering nested git repositories. > Such repositories are only deleted if '-f' is passed twice > to 'git clean'. > > Signed-off-by: Soren Brinkmann > --- > Docume

Re: [PATCH v6 0/7] make test output coloring more intuitive

On Thu, Dec 20, 2012 at 7:21 PM, Junio C Hamano wrote: > Jeff King writes: >>> Good point, I forgot to check what it looked like with -v. Since this >>> series is already on v6, is there a more lightweight way of addressing >>> this tiny tweak than sending v7? >> >> It is ultimately up to Junio,

Re: [PATCH] Highlight the link target line in Gitweb using CSS

On 20 December 2012 20:54, Junio C Hamano wrote: > [jc: adding area expert to Cc] Thanks. > Matthew Blissett writes: > > > This is useful when a Gitweb link with a target (like #l100) refers to > > a line in the last screenful of text. Highlight the background in > > yellow, and display a ⚓ ch

Re: RFC: "git config -l" should not expose sensitive information

On 21 December 2012 02:49, Aaron Schrab wrote: > Tools outside of the core git tree may add support for new config keys which > are meant to contain sensitive information, and there would be no way for > `git config` to know about those. I understand that we've come down mostly on the 'users must

Change in cvsps maintainership, abd a --fast-export option

Earlier today David Mansfield handed off to me the cvsps project. This is the code used as an engine for reading CVS repositories by git-cvsimport. His reason (aside from general overwork and no longer having a strong interest on the code) is that I have added a --fast-export option to cvsps-3.0 t

Re: Python version auditing followup

"Joachim Schmitz" writes: > Junio C Hamano wrote: >> I personally would think 2.6 is recent enough. Which platforms that >> are long-term-maintained by their vendors still pin their Python at >> 2.4.X? 2.4.6 was in 2008 that was source only, 2.4.4 was in late >> 2006 that was the last 2.4 with

Re: Python version auditing followup

Junio C Hamano wrote: e...@thyrsus.com (Eric S. Raymond) writes: That was the first of three patches I have promised. In order to do the next one, which will be a development guidelines recommend compatibility back to some specific version X, I need a policy decision. How do we set X? I don'

Re: $PATH pollution and t9902-completion.sh

On Thu, Dec 20, 2012 at 09:53:06PM +0100, Torsten Bögershausen wrote: > (Good to learn about the comm command, thanks ) > What do we think about this: > > > diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh > index 3cd53f8..82eeba7 100755 > --- a/t/t9902-completion.sh > +++ b/t/t9902-co

[PATCH v2] oneway_merge(): only lstat() when told to update worktree

Although the subject line of 613f027 (read-tree -u one-way merge fix to check out locally modified paths., 2006-05-15) mentions "read-tree -u", it did not seem to check whether -u was in effect. Not checking whether -u is in effect makes e.g. "read-tree --reset" lstat() the worktree, even though th

Re: $PATH pollution and t9902-completion.sh

Torsten Bögershausen writes: > On 20.12.12 21:01, Jeff King wrote: >> +test_fully_contains () { >>> + sort "$1" >expect.sorted && >>> + sort "$2" >actual.sorted && >>> + test $(comm -23 expect.sorted actual.sorted | wc -l) = 0 >>> +} > > (Good to learn about the comm command, thanks ) > Wha

Re: [PATCH] Highlight the link target line in Gitweb using CSS

[jc: adding area expert to Cc] Matthew Blissett writes: > This is useful when a Gitweb link with a target (like #l100) refers to > a line in the last screenful of text. Highlight the background in > yellow, and display a ⚓ character on the left. Show the same > highlight when hovering the mous

Re: $PATH pollution and t9902-completion.sh

On 20.12.12 21:01, Jeff King wrote: > +test_fully_contains () { >> +sort "$1" >expect.sorted && >> +sort "$2" >actual.sorted && >> +test $(comm -23 expect.sorted actual.sorted | wc -l) = 0 >> +} (Good to learn about the comm command, thanks ) What do we think about this: diff --git a

Re: What's cooking in git.git (Dec 2012, #05; Tue, 18)

Jeff King writes: > So our attempt for more compile-time safety may actually introduce a > run-time bug. And it is a hard bug to find, as the preprocessor > "magically" converts the error code into -1 without you being able to > see it in the code. > > It would be safer to just unconditionally u

Re: [PATCH] oneway_merge(): only lstat() when told to update worktree

Martin von Zweigbergk writes: > Although the subject line of 613f027 (read-tree -u one-way merge fix > to check out locally modified paths., 2006-05-15) mentions "read-tree > -u", it did not seem to check whether -u was in effect. Not checking > whether -u is in effect makes e.g. "read-tree --res

Re: $PATH pollution and t9902-completion.sh

On Thu, Dec 20, 2012 at 11:55:45AM -0800, Junio C Hamano wrote: > The beginning of such a change may look like the attached patch. > [...] > +test_fully_contains () { > + sort "$1" >expect.sorted && > + sort "$2" >actual.sorted && > + test $(comm -23 expect.sorted actual.sorted | wc -l

Re: What's cooking in git.git (Dec 2012, #05; Tue, 18)

On Thu, Dec 20, 2012 at 10:13:37AM -0800, Junio C Hamano wrote: > >> * jk/error-const-return (2012-12-15) 2 commits > >> - silence some -Wuninitialized false positives > >> - make error()'s constant return value more visible > >> > >> Help compilers' flow analysis by making it more explicit th

Re: $PATH pollution and t9902-completion.sh

Junio C Hamano writes: > Jeff King writes: > >> 2. Loosen the test to look for the presence of "checkout", but not >> fail when other items are present. Bonus points if it makes sure >> that everything returned starts with "check". >> >> I think (2) is the ideal solution in terms of

Re: [PATCH v6 0/7] make test output coloring more intuitive

On Thu, Dec 20, 2012 at 11:21:09AM -0800, Junio C Hamano wrote: > The "expected_failure" cases painted in "warn" are all long-known > failures; I do not think reminding about them in "bold" over and > over will help encouraging the developers take a look at them. > > The "skipped" cases fall into

Re: [PATCH v6 0/7] make test output coloring more intuitive

Jeff King writes: >> Good point, I forgot to check what it looked like with -v. Since this >> series is already on v6, is there a more lightweight way of addressing >> this tiny tweak than sending v7? > > It is ultimately up to Junio, but I suspect he would be OK if you just > reposted patch 4/7

Re: Q: do people compile with NO_FNMATCH on OpenBSD 5.2?

[mkstemp truncating output on error] diff --git c/wrapper.c w/wrapper.c index 68739aa..a066e2e 100644 --- c/wrapper.c +++ w/wrapper.c @@ -229,7 +229,7 @@ int xmkstemp(char *template) int saved_errno = errno; const char *nonrelative_template; -

Re: RFC: "git config -l" should not expose sensitive information

Michael Haggerty writes: > I think the problem is yet another step earlier: why do we build tools > that encourage people to store passwords in plaintext in a configuration > file that is by default world-readable? True. This particular one mentioned in the thread predates credential helpers, s

Re: RFC: "git config -l" should not expose sensitive information

Jeff King writes: > Yeah. Thanks for a dose of sanity. I was really trying not to say "the > given advice is bad, and we cannot help those people". But I think you > are right; the only sensible path is for the user to inspect the output > before posting it. True. -- To unsubscribe from this lis

Re: $PATH pollution and t9902-completion.sh

Jeff King writes: > 2. Loosen the test to look for the presence of "checkout", but not > fail when other items are present. Bonus points if it makes sure > that everything returned starts with "check". > > I think (2) is the ideal solution in terms of behavior, but writing it > may be

[PATCH] builtin/clean.c: Fix some sparse warnings

Sparse issues two "Using plain integer as NULL pointer" warnings (lines 41 and 47). The first warning relates to the initializer expression in the declaration for the 'char *dir' variable. In order to suppress the warning, we simply replace the zero initializer with NULL. The second warning rela

Re: Python version auditing followup

e...@thyrsus.com (Eric S. Raymond) writes: > That was the first of three patches I have promised. In order to do > the next one, which will be a development guidelines recommend > compatibility back to some specific version X, I need a policy > decision. How do we set X? > > I don't think X can

Re: [PATCH] Python scripts audited for minimum compatible version and checks added.

"Eric S. Raymond" writes: >> Should the error message say ciabot.py? >> >> -Peff > > Gack. Yes. Thaty's what I get for cut-and-pasting too quickly. > The information about xnml.sex is correct, though. > > Want me to resubmit, or will you just patch it? Can handle it myself; thanks for the pat

[PATCH] Highlight the link target line in Gitweb using CSS

This is useful when a Gitweb link with a target (like #l100) refers to a line in the last screenful of text. Highlight the background in yellow, and display a ⚓ character on the left. Show the same highlight when hovering the mouse over a line number. Signed-off-by: Matthew Blissett --- The bac

Re: [PATCH v6 0/7] make test output coloring more intuitive

On Thu, Dec 20, 2012 at 4:11 PM, Jeff King wrote: > On Thu, Dec 20, 2012 at 03:44:53PM +, Adam Spiers wrote: >> > diff --git a/t/test-lib.sh b/t/test-lib.sh >> > index 256f1c6..31f59af 100644 >> > --- a/t/test-lib.sh >> > +++ b/t/test-lib.sh >> > @@ -227,7 +227,7 @@ then >> > p

Re: What's cooking in git.git (Dec 2012, #05; Tue, 18)

Jeff King writes: > On Tue, Dec 18, 2012 at 12:31:43PM -0800, Junio C Hamano wrote: > >> * jk/error-const-return (2012-12-15) 2 commits >> - silence some -Wuninitialized false positives >> - make error()'s constant return value more visible >> >> Help compilers' flow analysis by making it mor

[PATCH] oneway_merge(): only lstat() when told to update worktree

Although the subject line of 613f027 (read-tree -u one-way merge fix to check out locally modified paths., 2006-05-15) mentions "read-tree -u", it did not seem to check whether -u was in effect. Not checking whether -u is in effect makes e.g. "read-tree --reset" lstat() the worktree, even though th

[PATCH] t9902: Be more specific when completing git-checkout

t9902 is trying to complete e.g. "git --version check" into "git --version checkout" If there are other binaries like "git-check-email" or "git-check-ignore" in the PATH one test case failes By using "checkou" instead of "check" the test becomes more future proof. Signed-off-by: Torsten Bögersha

Re: $PATH pollution and t9902-completion.sh

On 20.12.12 16:13, Adam Spiers wrote: > On Thu, Dec 20, 2012 at 2:55 PM, Jeff King wrote: >> On Mon, Dec 17, 2012 at 01:05:38AM +, Adam Spiers wrote: >>> t/t9902-completion.sh is currently failing for me because I happen to >>> have a custom shell-script called git-check-email in ~/bin, which

Re: [RFC] test: Old shells and physical paths

Hi, On Thu, Dec 20, 2012 at 12:01 AM, David Aguilar wrote: > Do you know if the differences are relegated to "cd", > or do other common commands such as awk, grep, sed, mktemp, expr, > etc. have similar issues? There are almost certainly going to be incompatibilities with other commands. The sy

Re: RFC: "git config -l" should not expose sensitive information

yep - understood On 12/20/2012 04:49 PM, Aaron Schrab wrote: > At 10:04 -0500 20 Dec 2012, Jeff King wrote: >> The problem seems to be that people are giving bad advice to tell >> people to post "git config -l" output without looking at. Maybe we >> could help them with a "git config --share-con

Re: [PATCH v6 0/7] make test output coloring more intuitive

On Thu, Dec 20, 2012 at 03:44:53PM +, Adam Spiers wrote: > > diff --git a/t/test-lib.sh b/t/test-lib.sh > > index 256f1c6..31f59af 100644 > > --- a/t/test-lib.sh > > +++ b/t/test-lib.sh > > @@ -227,7 +227,7 @@ then > > pass) > > tput setaf 2;;

Re: RFC: "git config -l" should not expose sensitive information

On Thu, Dec 20, 2012 at 04:51:37PM +0100, Michael Haggerty wrote: > > The problem seems to be that people are giving bad advice to tell people > > to post "git config -l" output without looking at. Maybe we could help > > them with a "git config --share-config" option that dumps all config, > > bu

Re: RFC: "git config -l" should not expose sensitive information

On Thu, Dec 20, 2012 at 10:49:15AM -0500, Aaron Schrab wrote: > At 10:04 -0500 20 Dec 2012, Jeff King wrote: > >The problem seems to be that people are giving bad advice to tell > >people to post "git config -l" output without looking at. Maybe we > >could help them with a "git config --share-con

Re: RFC: "git config -l" should not expose sensitive information

On 12/20/2012 04:04 PM, Jeff King wrote: > On Mon, Dec 17, 2012 at 12:35:54PM +0100, Toralf Förster wrote: >> often the output is requested in help forums - and a >> "git config -l | wgetpaste" exposes parameters like sendmail.smtppass - >> so hide those variables in the output (if not explicitly w

Re: RFC: "git config -l" should not expose sensitive information

At 10:04 -0500 20 Dec 2012, Jeff King wrote: The problem seems to be that people are giving bad advice to tell people to post "git config -l" output without looking at. Maybe we could help them with a "git config --share-config" option that dumps all config, but sanitizes the output. It would

Re: [PATCH v6 0/7] make test output coloring more intuitive

On Thu, Dec 20, 2012 at 3:34 PM, Jeff King wrote: > On Sun, Dec 16, 2012 at 07:01:56PM +, Adam Spiers wrote: >> On Sun, Dec 16, 2012 at 6:54 PM, Junio C Hamano wrote: >> > Adam Spiers writes: >> >> This series of commits attempts to make test output coloring >> >> more intuitive,... >> > >>

Re: [PATCH v6 0/7] make test output coloring more intuitive

On Sun, Dec 16, 2012 at 07:01:56PM +, Adam Spiers wrote: > On Sun, Dec 16, 2012 at 6:54 PM, Junio C Hamano wrote: > > Adam Spiers writes: > > > >> This series of commits attempts to make test output coloring > >> more intuitive,... > > > > Thanks; I understand that this is to replace the pre

Re: $PATH pollution and t9902-completion.sh

On Thu, Dec 20, 2012 at 2:55 PM, Jeff King wrote: > On Mon, Dec 17, 2012 at 01:05:38AM +, Adam Spiers wrote: >> t/t9902-completion.sh is currently failing for me because I happen to >> have a custom shell-script called git-check-email in ~/bin, which is >> on my $PATH. This is different to a

Re: RFC: "git config -l" should not expose sensitive information

On Mon, Dec 17, 2012 at 12:35:54PM +0100, Toralf Förster wrote: > often the output is requested in help forums - and a > "git config -l | wgetpaste" exposes parameters like sendmail.smtppass - > so hide those variables in the output (if not explicitly wanted) would > makes sense, or ? But if we c

Re: [PATCH] Python scripts audited for minimum compatible version and checks added.

Jeff King : > On Thu, Dec 20, 2012 at 09:13:37AM -0500, Eric S. Raymond wrote: > > > diff --git a/contrib/ciabot/ciabot.py b/contrib/ciabot/ciabot.py > > index bd24395..b55648f 100755 > > --- a/contrib/ciabot/ciabot.py > > +++ b/contrib/ciabot/ciabot.py > > @@ -50,6 +50,11 @@ > > import os, sys,

Re: What's cooking in git.git (Dec 2012, #05; Tue, 18)

On Tue, Dec 18, 2012 at 12:31:43PM -0800, Junio C Hamano wrote: > * jk/error-const-return (2012-12-15) 2 commits > - silence some -Wuninitialized false positives > - make error()'s constant return value more visible > > Help compilers' flow analysis by making it more explicit that > error() a

Re: $PATH pollution and t9902-completion.sh

On Mon, Dec 17, 2012 at 01:05:38AM +, Adam Spiers wrote: > t/t9902-completion.sh is currently failing for me because I happen to > have a custom shell-script called git-check-email in ~/bin, which is > on my $PATH. This is different to a similar-looking case reported > recently, which was due

Re: [PATCH] Python scripts audited for minimum compatible version and checks added.

On Thu, Dec 20, 2012 at 09:13:37AM -0500, Eric S. Raymond wrote: > diff --git a/contrib/ciabot/ciabot.py b/contrib/ciabot/ciabot.py > index bd24395..b55648f 100755 > --- a/contrib/ciabot/ciabot.py > +++ b/contrib/ciabot/ciabot.py > @@ -50,6 +50,11 @@ > import os, sys, commands, socket, urllib >

Python version auditing followup

Most of the Python scripts in the distribution are small and simple to audit, so I am pretty sure of the results. The only place where I have a concern is the git_helpers library; that is somewhat more complex and I might have missed a dependency somewhere. Whoever owns that should check my findi

[PATCH] Python scripts audited for minimum compatible version and checks added.

Signed-off-by: Eric S. Raymond --- contrib/ciabot/ciabot.py | 5 + contrib/fast-import/import-zips.py | 5 + contrib/hg-to-git/hg-to-git.py | 5 + contrib/p4import/git-p4import.py | 5 + contrib/svn-fe/svnrdump_sim.py | 4 git-p4.py

Gitweb running as FCGI does not print its output in UTF-8

Hello, I'm sending this message to explain a problem I've found with gitweb.cgi when running it using a call like the following: export FCGI_SOCKET_PATH="/run/gitweb.socket" gitweb.cgi --fcgi --nproc 2 I've fixed the problem for my installation usign a wrapper script, as explained below.

Re: [PATCH 2/3] wildmatch: support "no FNM_PATHNAME" mode

On Thu, Dec 20, 2012 at 8:55 AM, Nguyen Thai Ngoc Duy wrote: >> As long as simpler patterns fnmatch() groks (namely, '?', '*', and >> '[class]' wildcards only) are not slowed down by replacing it with >> wildmatch(), that is, of course. > > I'm concerned about performance vs fnmatch too. I'll prob

Re: [PATCH 3/3] Convert all fnmatch() calls to wildmatch()

On Thu, Dec 20, 2012 at 1:36 AM, Junio C Hamano wrote: >> @@ -627,7 +628,7 @@ enum interesting tree_entry_interesting(const struct >> name_entry *entry, >> return entry_interesting; >> >> if (item->use_wildcard) { >> -

Re: [PATCH] mergetools/p4merge: Honor $TMPDIR for the /dev/null placeholder

Junio C Hamano wrote: David Aguilar writes: Use mktemp to create the /dev/null placeholder for p4merge. This keeps it out of the current directory. Reported-by: Jeremy Morton Signed-off-by: David Aguilar --- I consider this a final finishing touch on a new 1.8.1 feature, so hopefully we can

Re: [PATCH] mergetools/p4merge: Honor $TMPDIR for the /dev/null placeholder

On Wed, Dec 19, 2012 at 10:28 PM, Junio C Hamano wrote: > David Aguilar writes: > >> Use mktemp to create the /dev/null placeholder for p4merge. >> This keeps it out of the current directory. >> >> Reported-by: Jeremy Morton >> Signed-off-by: David Aguilar >> --- >> I consider this a final fini