Re: Feature Request Google Authenticator Support

2014-01-30 Thread Jakub Narębski
that it does not do authenthication, but passes it to appropriate programs, SSH or web server (HTTP). Own git:// protocol is unathenthicated. -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 5/6] Document a bunch of functions defined in sha1_file.c

2014-02-24 Thread Jakub Narębski
alternate directory listed in the - * DB_ENVIRONMENT environment variable if it is not found in - * the primary object database. - */ const char *sha1_file_name(const unsigned char *sha1) Has this changed? -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body

Re: [PATCH] gitweb: Improve diffs when filenames contain problem characters

2014-04-03 Thread Jakub Narębski
path if ($line =~ s!^((copy|rename) from ).*$!$1! $from-{'href'}) { $line .= $cgi-a({-href=$from-{'href'}, -class=path}, I'd have to examine code flow to check where it lands... -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message

Re: [PATCH 03/10] diffcore-pickaxe.c: Refactor pickaxe_fn signature

2014-04-04 Thread Jakub Narębski
W dniu 2014-03-27 19:50, David A. Dalrymple (and Bhushan G. Lodha) pisze: From: Bhushan G. Lodha David A. Dalrymple dad-...@mit.edu This function type previously accepted separate regex_t and kwset_t parameters, which conceptually go together. Here we create a struct to encapsulate them, in

Re: [PATCH 06/10] log: --function-name pickaxe

2014-04-04 Thread Jakub Narębski
in. Well, there is 'texconv', e.g. .gitattributes *.jpg diff=jpg .git/config [diff jpg] textconv = exif Doesn't it fit in said place in the transformation pipeline? -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord

Re: [PATCH 09/10] t4213: test --function-name option

2014-04-04 Thread Jakub Narębski
+ test_tick + git commit -am second Wouldn't it be more readable to use cat \-EOF or separate files instead of printf-s with embedded newlines \n and tabs \t? -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord

Re: [PATCH/RFC] Gitweb: Convert UTF-8 encoded file names

2014-05-14 Thread Jakub Narębski
it is at best partial fix. -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH/RFC] Gitweb: Convert UTF-8 encoded file names

2014-05-15 Thread Jakub Narębski
On Thu, May 15, 2014 at 7:08 AM, Michael Wagner accou...@mwagner.org wrote: On Thu, May 15, 2014 at 12:25:45AM +0200, Jakub Narębski wrote: On Wed, May 14, 2014 at 11:57 PM, Junio C Hamano gits...@pobox.com wrote: Michael Wagner accou...@mwagner.org writes: Perl has an internal encoding used

Re: [PATCH/RFC] Gitweb: Convert UTF-8 encoded file names

2014-05-15 Thread Jakub Narębski
On Thu, May 15, 2014 at 8:48 PM, Michael Wagner accou...@mwagner.org wrote: On Thu, May 15, 2014 at 10:04:24AM +0100, Peter Krefting wrote: Michael Wagner: Decoding the UTF-8 encoded file name (again with an additional print statement): $ REQUEST_METHOD=GET

Re: [PATCH/RFC] Gitweb: Convert UTF-8 encoded file names

2014-05-15 Thread Jakub Narębski
On Thu, May 15, 2014 at 9:28 PM, Jakub Narębski jna...@gmail.com wrote: On Thu, May 15, 2014 at 8:48 PM, Michael Wagner accou...@mwagner.org wrote: [...] The subroutine git tree generates the tree view. It stores the output of git ls-tree -z ... in an array named @entries. Printing the content

Re: [PATCH/RFC] Gitweb: Convert UTF-8 encoded file names

2014-05-15 Thread Jakub Narębski
On Thu, May 15, 2014 at 9:38 PM, Junio C Hamano gits...@pobox.com wrote: Jakub Narębski jna...@gmail.com writes: Writing test for this would not be easy, and require some HTML parser (WWW::Mechanize, Web::Scraper, HTML::Query, pQuery, ... or low level HTML::TreeBuilder, or other low level

Re: [PATCH/RFC] Gitweb: Convert UTF-8 encoded file names

2014-05-16 Thread Jakub Narębski
On Fri, May 16, 2014 at 3:26 AM, Junio C Hamano gits...@pobox.com wrote: Jakub Narębski jna...@gmail.com writes: On Thu, May 15, 2014 at 9:38 PM, Junio C Hamano gits...@pobox.com wrote: Jakub Narębski jna...@gmail.com writes: Writing test for this would not be easy, and require some HTML

Re: [PATCH/RFC 0/5] add unset.variable for unsetting previously set variables

2014-10-07 Thread Jakub Narębski
user must know which variables are safe, why it cannot be left to Git to know which configuration variables can call external scripts? -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v2] mergetool: use more conservative temporary filenames

2014-10-10 Thread Jakub Narębski
$MERGED : '\(.*\)\.[^/]*$') + then + ext=$(expr $MERGED : '.*\(\.[^/]*\)$') + else + BASE=$MERGED + ext= + fi Why use expr and not POSIX shell parameter substitution? BASE=${MERGED%.*} ext=.${MERGED##*.} Or something like that... -- Jakub

Re: [PATCH 0/4] Allow building Git with Asciidoctor

2014-10-14 Thread Jakub Narębski
the attributes. All but litdd are built-in to Asciidoctor, and I can reroll with a modification to extensions.rb that implements that one. Would it be possible to automatically convert asciidoc.conf file to Asciidoctor extension? -- Jakub Narębski -- To unsubscribe from this list: send the line

Re: [PATCH] clone: --dissociate option to mark that reference is only temporary

2014-10-17 Thread Jakub Narębski
, then copy any unique objects from the neighbour before disassociating from it. M. -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 1/2] Documentation/technical: signature formats

2014-10-22 Thread Jakub Narębski
by space, but it is multi-line header which uses RFC-2822 like wrapping (see Long Header Fields there) - leading space means wrapped in email, separate line here. Nice work. -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord

Re: squash commits deep down in history

2014-10-24 Thread Jakub Narębski
know if it is possible to run filter-branch without replacing replaces? Just for completeness, yet another way to do scripted history rewriting is to use git-fast-export + some editing script (e.g. reposurgeon[1]) + git-fast-import. [1]: http://www.catb.org/esr/reposurgeon/ -- Jakub Narębski

Re: [PATCH 1/2] Documentation/technical: signature formats

2014-10-25 Thread Jakub Narębski
it (as description of merged branch) in 'mergetag' header? -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: What is the default refspec for fetch?

2014-11-08 Thread Jakub Narębski
that. Actually FETCH_HEAD consists of multiple lines, one per ref... but only top ref is merged. -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4] gitweb: make search help link less ugly

2013-08-03 Thread Jakub Narębski
On Tue, Jul 9, 2013 at 7:15 PM, Tony Finch d...@dotat.at wrote: The search help link was a superscript question mark right next to a drop-down menu, which looks misaligned I think the idea was to simulate footnote explaining search terms (I think, I am not the author of this feature)...

Re: [PATCH 3/4] gitweb: omit the repository owner when it is unset

2013-08-03 Thread Jakub Narębski
On Tue, Jul 2, 2013 at 6:24 PM, Tony Finch d...@dotat.at wrote: On the repository summary page, leave the whole owner line out if the repo does not have an owner, rather than displaying a labelled empty field.. Note that if $omit_owner is true, whole _column_ is skipped. Is removing cell

Re: The gitweb author initials feature from a36817b doesn't work with i18n names

2013-08-29 Thread Jakub Narębski
[Ævar, sorry for duplication but I accidentally send HTML email; stupid Gmail] On Thu, Aug 29, 2013 at 4:26 PM, Ævar Arnfjörð Bjarmason ava...@gmail.com wrote: The @author_initials feature Jakub added in a36817b claims to use a i18n regexp (/\b([[:upper:]])\B/g), but in Perl this doesn't

Re: [PATCH] gitweb: Fix the author initials in blame for non-ASCII names

2013-08-31 Thread Jakub Narębski
On Fri, Aug 30, 2013 at 11:39 PM, Kyle J. McKay mack...@gmail.com wrote: On Aug 30, 2013, at 11:13, Junio C Hamano wrote: Junio C Hamano gits...@pobox.com writes: Ævar Arnfjörð Bjarmason ava...@gmail.com writes: + binmode $fh, ':utf8'; What happens if the author name is written in

Re: [RFC] Questions for Git User's Survey 2011

2012-09-22 Thread Jakub Narębski
On Wed, Sep 19, 2012 at 7:35 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Hi, On Wed, Sep 14, 2011 at 7:39 PM, Jakub Narebski jna...@gmail.com wrote: P.S. Would you be interested in running the next survey? I haven't seen any news regarding the 2012 survey. I'm interested in

Re: [RFC] Questions for Git User's Survey 2011

2012-09-23 Thread Jakub Narębski
On Sun, Sep 23, 2012 at 10:09 AM, Junio C Hamano gits...@pobox.com wrote: Jakub Narębski jna...@gmail.com writes: I have created short (well, at least shorter than previous ones) Git User's Survey 2012 on Survs.com. The test channel is https://www.survs.com/survey/J87I3PDBU4 Note

Re: [RFC] Questions for Git User's Survey 2011

2012-09-24 Thread Jakub Narębski
On Mon, Sep 24, 2012 at 3:23 PM, Michael J Gruber g...@drmicha.warpmail.net wrote: [...] Other version control systems: I think the list needs to be sorted alphabetically, it's really long. I have split this list in two: other centralized VCS and other distributed VCS; both have other field.

Re: [RFC] Questions for Git User's Survey 2011

2012-09-24 Thread Jakub Narębski
On Mon, Sep 24, 2012 at 5:37 PM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Jakub Narębski jna...@gmail.com writes: I have created short (well, at least shorter than previous ones) Git User's Survey 2012 on Survs.com. The test channel is https://www.survs.com/survey/J87I3PDBU4

Re: [RFC] Questions for Git User's Survey 2011

2012-09-24 Thread Jakub Narębski
On Mon, Sep 24, 2012 at 6:18 PM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Jakub Narębski jna...@gmail.com writes: I have therefore added the following multiple-choice question: #19. What git workflow(s) is used by projects in which development you participate? If we want to have

Re: [RFC] Questions for Git User's Survey 2011

2012-09-24 Thread Jakub Narębski
On Mon, Sep 24, 2012 at 9:35 PM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Jakub Narębski jna...@gmail.com writes: On Mon, Sep 24, 2012 at 6:18 PM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Jakub Narębski jna...@gmail.com writes: I have therefore added the following multiple

[RFC] Questions for Git User's Survey 2011

2012-09-25 Thread Jakub Narębski
[I'm sorry for breaking the chain, but I have accidentally hit Reply, instead of Reply To All, and missed sending reply to git mailing list] On Tue, Sep 25, 2012 at 8:17 AM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Jakub Narębski jna...@gmail.com writes: Second, the situation is more

Re: gitweb

2012-10-29 Thread Jakub Narębski
On Mon, Oct 29, 2012 at 6:28 AM, Jeff King p...@peff.net wrote: On Sun, Oct 28, 2012 at 04:56:47PM -0700, rh wrote: I'm not using gitweb I was thinking about using it and was looking at the cgi and saw this in this file: https://github.com/git/git/blob/master/gitweb/gitweb.perl I think I

Re: [PATCH] gitweb: fix problem causing erroneous project list

2013-06-07 Thread Jakub Narębski
On Wed, Jun 5, 2013 at 9:17 PM, Junio C Hamano gits...@pobox.com wrote: Charles McGarvey chazmcgar...@brokenzipper.com writes: The bug is manifest when running gitweb in a persistent process (e.g. FastCGI, PSGI), and it's easy to reproduce. If a gitweb request includes the searchtext

Re: [PATCH] instaweb: make the perl path configurable

2013-06-12 Thread Jakub Narębski
, and not other places? Nb. for short Perl scripts not using extra modules we pick first perl in PATH, IIRC... -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] gitweb: allow extra breadcrumbs to prefix the trail

2013-07-03 Thread Jakub Narębski
On Wed, Jul 3, 2013 at 11:59 PM, Jonathan Nieder jrnie...@gmail.com wrote: Tony Finch wrote: +@extra_breadcrumbs:: + Additional links to be added to the start of the breadcrumb trail, + that are logically above the gitweb projects list. For example, + links to the organization

Re: [PATCH] gitweb: allow extra breadcrumbs to prefix the trail

2013-07-04 Thread Jakub Narębski
On Thu, Jul 4, 2013 at 10:44 AM, Tony Finch d...@dotat.at wrote: Jakub Narębski jna...@gmail.com wrote: On Wed, Jul 3, 2013 at 11:59 PM, Jonathan Nieder jrnie...@gmail.com wrote: Tony Finch wrote: +@extra_breadcrumbs:: BTW. perhaps (it is only an idea) @top_level_breadcrumbs

Re: [PATCH] gitweb: allow extra breadcrumbs to prefix the trail

2013-07-04 Thread Jakub Narębski
On Thu, Jul 4, 2013 at 5:11 PM, Tony Finch d...@dotat.at wrote: Jakub Narębski jna...@gmail.com wrote: It would be better to improve documentation, than follow current bad practice... ;-P The v2 patch does just that :-) Thanks. Perhaps even make ( [ $home_link_str, $home_link

Re: [PATCH] gitweb: allow extra breadcrumbs to prefix the trail

2013-07-04 Thread Jakub Narębski
On Thu, Jul 4, 2013 at 5:56 PM, Tony Finch d...@dotat.at wrote: Jakub Narębski jna...@gmail.com wrote: First, do I understand correctly that @extra_breadcrumbs are rendered *after* $home_link*, and in exactly the same manner? Before the home link, and yes, in the same manner. The extra

Re: [PATCH] gitweb: allow extra breadcrumbs to prefix the trail

2013-07-04 Thread Jakub Narębski
On Thu, Jul 4, 2013 at 7:08 PM, Tony Finch d...@dotat.at wrote: Jakub Narębski jna...@gmail.com wrote: In what situation do you need those extra breadcrumbs useful? What necessity / itch to scratch is behind idea of this patch? For an example, see https://git.csx.cam.ac.uk/x/ucs/git/git.git

Re: [PATCH v3] gitweb: allow extra breadcrumbs to prefix the trail

2013-07-04 Thread Jakub Narębski
On Thu, Jul 4, 2013 at 7:02 PM, Tony Finch d...@dotat.at wrote: There are often parent pages logically above the gitweb projects list, e.g. home pages of the organization and department that host the gitweb server. This change allows you to include links to those pages in gitweb's breadcrumb

Re: [BUG] gitweb: XSS vulnerability of RSS feed

2012-11-12 Thread Jakub Narębski
variables emitted with the same print like $descr and $owner are formed. It looks like good solution to me too. Nb. the problems with feed are mainly because it is generated by hand even more than HTML (which uses CGI.pm). -- Jakub Narębski -- Jakub Narebski -- To unsubscribe from this list: send

Re: [BUG] gitweb: XSS vulnerability of RSS feed

2012-11-13 Thread Jakub Narębski
On Tue, Nov 13, 2012 at 3:44 PM, Drew Northup n1xim.em...@gmail.com wrote: On Mon, Nov 12, 2012 at 3:24 PM, Jeff King p...@peff.net wrote: On Mon, Nov 12, 2012 at 01:55:46PM -0500, Drew Northup wrote: + # No XSS script/script inclusions + if ($input =~ m!(script)(.*)(/script)!){

Re: [BUG] gitweb: XSS vulnerability of RSS feed

2012-11-13 Thread Jakub Narębski
On Tue, Nov 13, 2012 at 4:45 PM, Kevin i...@ikke.info wrote: The problem with input filtering is that you can only filter for one output scenario. What if the the input is going to be output in a wiki like environment, or to pdf, or whatever? Then you have to unescape the data again, and maybe

Re: [BUG] gitweb: XSS vulnerability of RSS feed

2012-11-13 Thread Jakub Narębski
On Tue, Nov 13, 2012 at 6:04 PM, Jeff King p...@peff.net wrote: On Tue, Nov 13, 2012 at 09:44:06AM -0500, Drew Northup wrote: Besides, inserting one call to esc_html only fixes one attack path. I didn't look to see if all others were already covered. Properly quoting output is something that

Re: [PATCH v2 02/12] pretty: share code between format_decoration and show_decorations

2013-04-05 Thread Jakub Narębski
be left with variable name, don't you think? -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] gitweb: Fix utf8 encoding for blob_plain, blobdiff_plain, commitdiff_plain, and patch

2013-04-09 Thread Jakub Narębski
threshold for refactoring it into subroutine, for example: sub dump_fh_raw { my $fh = shift; local $/ = undef; binmode STDOUT, ':raw'; print $fh; binmode STDOUT, ':utf8'; # as set at the beginning of gitweb.cgi return $fh; } -- Jakub Narębski

Re: [PATCH] t3700 (add): add failing test for add with submodules

2013-04-09 Thread Jakub Narębski
repository. So my (admittedly strange) setup will stop working? -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC/PATCH 0/7] Rework git core for native submodules

2013-04-09 Thread Jakub Narębski
in gitweb (and thus git-instaweb) than just marking it as submodule in 'tree' view. -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: git-http-backend: anonymous read, authenticated write

2013-04-09 Thread Jakub Narębski
worked around this by allowing all registered users to read with require valid-user (which in my situation might be even more correct solution; the case being repositories for Computer Science class lab work), and restricting write via pre-receive hook which checks REMOTE_USER. -- Jakub Narębski

Re: [PATCH] t3700 (add): add failing test for add with submodules

2013-04-09 Thread Jakub Narębski
On 09.04.2013, Ramkumar Ramachandra wrote: Jakub Narębski wrote: Hmmm... I used to do (and still do) such not-recommended thing, i.e. keeping git/gitweb/TODO etc. in git/gitweb/.git repository, while having git/gitweb/gitweb.perl in git/.git repository. Why don't you put the gitweb/TODO

Re: [PATCH v4 1/6] send-email: make annotate configurable

2013-04-09 Thread Jakub Narębski
] +multiedit = [\$multiedit, undef], +annotate = [\$annotate, undef] ); Why not leave hanging , to make it easier on future changes, i.e.: -multiedit = [\$multiedit, undef] +multiedit = [\$multiedit, undef], +annotate = [\$annotate, undef], -- Jakub Narębski

Re: [PATCH 2/4] gitweb: Make feed title valid utf8

2013-04-09 Thread Jakub Narębski
) . /$action; my $feed_type = 'log'; if (defined $hash) { $title .= - '$hash'; Was this patch triggered by some bug? Because the above is not necessary, as git_feed() has $title = esc_html($title); a bit later, which does to_utf8() internally. -- Jakub

Re: [PATCH 4/4] gitweb: Fix broken blob action parameters on blob/commitdiff pages

2013-04-09 Thread Jakub Narębski
. - format_diff_cc_simplified($diffinfo, @hash_parents) . + format_diff_cc_simplified($diffinfo, $hash, @hash_parents) . /div\n; # class=patch $patch_number++; -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git

Re: [PATCH 3/4] gitweb: Don't append ';js=(0|1)' to external links

2013-04-09 Thread Jakub Narębski
W dniu 09.04.2013 19:54, Jürgen Kreileder napisał: Jakub Narębski jna...@gmail.com writes: Jürgen Kreileder wrote: Don't add js parameters to links outside of gitweb itself. Hmmm... this limits adding ';js=(0|1)' to only links which begin with $my_url, i.e. absolute links beginning

Re: [PATCH 2/4] gitweb: Make feed title valid utf8

2013-04-09 Thread Jakub Narębski
W dniu 09.04.2013 19:40, Jürgen Kreileder napisał: Jakub Narębski jna...@gmail.com writes: Jürgen Kreileder wrote: Properly encode site and project names for RSS and Atom feeds. - my $title = $site_name - $project/$action; + my $title = to_utf8($site_name) . - . to_utf8($project

Re: [PATCH 2/2] add: refuse to add paths beyond repository boundaries

2013-04-09 Thread Jakub Narębski
important information here? Or we shouldn't care? -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] add: refuse to add paths beyond repository boundaries

2013-04-09 Thread Jakub Narębski
Junio C Hamano wrote: Jakub Narębski jna...@gmail.com writes: W dniu 09.04.2013 19:34, Junio C Hamano pisze: - if (has_symlink_leading_path(path, len)) - return error('%s' is beyond a symbolic link, path); + if (path_outside_our_project(path, len)) + return error

Re: [PATCH 2/4] gitweb: Make feed title valid utf8

2013-04-09 Thread Jakub Narębski
W dniu 09.04.2013 21:22, Jürgen Kreileder napisał: Jakub Narębski jna...@gmail.com writes: W dniu 09.04.2013 19:40, Jürgen Kreileder napisał: Jakub Narębski jna...@gmail.com writes: Jürgen Kreileder wrote: Properly encode site and project names for RSS and Atom feeds. Good point

Re: [PATCH 1/4] gitweb: Fix utf8 encoding for blob_plain, blobdiff_plain, commitdiff_plain, and patch

2013-04-10 Thread Jakub Narębski
On 09.04.2013 at 23:59, Jürgen Kreileder wrote: Jakub Narębski jna...@gmail.com writes: On 08.04.2013, Junio C Hamano wrote: j...@blackdown.de (Jürgen Kreileder) writes: Fixes the encoding for several _plain actions and for text/* and */*+xml blobs. Signed-off-by: Jürgen Kreileder j

Re: [PATCH] glossary: extend detached HEAD description

2013-04-10 Thread Jakub Narębski
the tip of any + particular branch. The HEAD in such a state is called + detached. Should we also add that git branch output shows this situation as (no branch)? Nb. this is not documented in git-branch(1) manpage either... -- Jakub Narębski -- To unsubscribe from this list: send

Re: git instaweb - share all project files

2013-04-10 Thread Jakub Narębski
.) to my gitweb TODO, but I don't know when I would be able to get to implementing it. -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Advice and repo setup

2013-04-10 Thread Jakub Narębski
developer to have their own private clone to work in). Is there documentation I can refer to for this, or is there an obvious way to do these things? Any help or pointers appreciated. -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message

Re: [PATCH] glossary: extend detached HEAD description

2013-04-10 Thread Jakub Narębski
W dniu 10.04.2013 16:45, Junio C Hamano pisze: Jakub Narębski jna...@gmail.com writes: Junio C Hamano wrote: diff --git a/Documentation/glossary-content.txt b/Documentation/glossary-content.txt index f928b57..69c90d1 100644 --- a/Documentation/glossary-content.txt +++ b/Documentation

Re: git-http-backend: anonymous read, authenticated write

2013-04-10 Thread Jakub Narębski
whole config? I think I have seen a patch on git mailing list to correct this, but I am not sure. Are you sure that we test this correctly? -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info

Re: git-http-backend: anonymous read, authenticated write

2013-04-11 Thread Jakub Narębski
=AUTHREQUIRED AuthType Basic AuthName Git Access Require group committers Satisfy Any Location Not tested. P.S. By the way, is there some debugger for apache config (mod_rewrite and deny/allow)? -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git

Re: [PATCH 2/2] doc/http-backend: give some lighttpd config examples

2013-04-11 Thread Jakub Narębski
Location And perhaps also adding it as test... -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] doc/http-backend: give some lighttpd config examples

2013-04-11 Thread Jakub Narębski
W dniu 11.04.2013 19:02, Jeff King napisał: On Thu, Apr 11, 2013 at 06:47:49PM +0200, Jakub Narębski wrote: W dniu 11.04.2013 05:36, Jeff King napisał: +Note that unlike the similar setup with Apache, we can easily match the +query string for receive-pack, catching the initial request from

[PATCH] gitweb/INSTALL: Simplify description of GITWEB_CONFIG_SYSTEM

2013-04-12 Thread Jakub Narębski
On Fri, 12 April 2013, Junio C Hamano wrote: Jonathan Nieder jrnie...@gmail.com writes: Note that if per-instance configuration file exists, then system-wide - configuration is _not used at all_. This is quite untypical and suprising + configuration is _not used at all_. This is quite

Re: What's cooking in git.git (Apr 2013, #04; Fri, 12)

2013-04-12 Thread Jakub Narębski
-core itself also had to be adjusted. You may want to consider updating such scripts to always call git gc --auto to let it decide when to repack for you. Will merge to 'master'. So mc/count-objects-kibibytes is to be discarded, or merged to 'master'? -- Jakub Narębski -- To unsubscribe

Re: [PATCH 3/2] doc/http-backend: match query-string in apache half-auth example

2013-04-13 Thread Jakub Narębski
for writing(and testing) this patch. -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: git instaweb - share all project files

2013-04-13 Thread Jakub Narębski
Please do not top-post. On 11.04.2013, Trenton D. Adams wrote: #1 would actually work. Though long term it would be cool to view it with all the most recent commit information, kind of like github does. You know, showing updated 4 days ago. On Wed, Apr 10, 2013 at 11:03 AM, Jakub

Re: [RFC/PATCH] push: introduce implicit push

2013-04-14 Thread Jakub Narębski
to remote based on current branch or push to remote or remotes based on branch or branches being pushed. -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: git instaweb - share all project files

2013-04-14 Thread Jakub Narębski
W dniu 10.04.2013 19:03, Jakub Narębski pisze: W dniu 07.04.2013 05:02, Trenton D. Adams pisze: On that first page that shows up, it shows the .git folder. It would be kind of nice if it shared out both the git repo and the actual current project files. I frequently have stuff I'd like

Re: Why does git config output nothing instead of the default value for unset variables?

2013-04-14 Thread Jakub Narębski
to check whether a given variable name is known to Git or not. I think git-config was meant to be git agnostic (and therefore usable outside git, and for files other that git config files). It would be better to add required functionality to git-var, IMHO. -- Jakub Narębski -- To unsubscribe from

Re: State of CVS-to-git conversion tools (Was: Re: cvsps: bad usage: invalid argument --norc)

2013-04-15 Thread Jakub Narębski
support versioning of whole repository aka. changesets (beside tags), has slow and complicated branching and even more complicated merging, etc.? http://stackoverflow.com/questions/802573/difference-between-git-and-cvs/824241#824241 -- Jakub Narębski -- To unsubscribe from this list: send the line

Re: gitweb commitdiff page - binary files with ampersands in filename?

2013-04-15 Thread Jakub Narębski
Oj W wrote: Change a binary file whose filename contains an ampersand, then view the commitdiff page in gitweb. Git outputs a message like Binary files a/bw.dll and b/bw.dll differ Gitweb format_diff_from_to_header() doesn't notice anything in that output which needs escaping, and writes

Re: [PATCH] gitweb/INSTALL: Simplify description of GITWEB_CONFIG_SYSTEM

2013-04-16 Thread Jakub Narębski
, and not about the reference documentation: gitweb(1) or gitweb.conf(5). Description of historical behavior (and backward compatibility) has place (if any) in manpages, not gitweb/INSTALL. -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message

[PATCH] gitweb/INSTALL: GITWEB_CONFIG_SYSTEM is for backward compatibility

2013-04-16 Thread Jakub Narębski
Signed-off-by: Jakub Narebski jna...@gmail.com --- This can be either squashed with previous patch to gitweb/INSTALL, kept as separate patch or discarded. Drew: gitweb(1) or gitweb.conf(5) solution is more involved, so perhaps something like that? gitweb/INSTALL |3 ++- 1 file changed, 2

Re: [RFC/PATCH] doc: git-foo was obsoleted several years ago

2013-10-17 Thread Jakub Narębski
tree +git checkout - Checkout a branch or paths to the working tree SYNOPSIS ... But change this, as we use this command as git checkout, not as git-checkout. -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord

Re: Limiting disk usage

2013-10-29 Thread Jakub Narębski
where we need only some of them) If they are independent projects, they should get independent repositories; you can stitch them back together using git-submodule (or git-subtree). reposurgeon can hel you with that. -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe

Re: Limiting disk usage

2013-10-30 Thread Jakub Narębski
interdependent repositories, e.g.: gitslave, repo, fgit. Maybe one of them would be good fit for your problem. [1]: https://git.wiki.kernel.org/index.php/InterfacesFrontendsAndTools -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord

Re: collapsing old git history to reduce repo size, while preserving commit #s and tags

2013-10-30 Thread Jakub Narębski
by new). You could try to use father or shallow clone, namely *grafts*, to 'cauterize' history, but there remains same problems as with shallow clone, perhaps with exception that git won't check things for you. -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git

Re: rcs

2013-11-05 Thread Jakub Narębski
used for fast conversion between different version control systems). -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: htonll, ntohll

2013-11-12 Thread Jakub Narębski
://commandcenter.blogspot.co.uk/2012/04/byte-order-fallacy.html Errr... htonl is about host to network order, and not about big- or little-endianness of architecture. The macros are good, its their implementation that might fail [1]. -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git

Re: Bizarre git merge behaviour

2013-11-20 Thread Jakub Narębski
be of help in complicated merges? -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] gitweb: Add an option for adding more branch refs

2013-11-27 Thread Jakub Narębski
, undef); } [...] -- Jakub Narębski -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3] gitweb: Add an option for adding more branch refs

2013-12-01 Thread Jakub Narębski
On Thu, Nov 28, 2013 at 12:44 PM, Krzesimir Nowak krzesi...@endocode.com wrote: Allow @additional_branch_refs configuration variable to tell gitweb to show refs from additional hierarchies in addition to branches in the list-of-branches view. Signed-off-by: Krzesimir Nowak

Re: [PATCH v3] gitweb: Add an option for adding more branch refs

2013-12-02 Thread Jakub Narębski
W dniu 2013-12-02 13:06, Krzesimir Nowak pisze: On Mon, 2013-12-02 at 01:21 +0100, Jakub Narębski wrote: On Thu, Nov 28, 2013 at 12:44 PM, Krzesimir Nowak krzesi...@endocode.com wrote: Allow @additional_branch_refs configuration variable to tell gitweb to show refs from additional

Re: [PATCH v3] gitweb: Add an option for adding more branch refs

2013-12-02 Thread Jakub Narębski
On Mon, Dec 2, 2013 at 7:18 PM, Junio C Hamano gits...@pobox.com wrote: Krzesimir Nowak krzesi...@endocode.com writes: On Mon, 2013-12-02 at 01:21 +0100, Jakub Narębski wrote: On Thu, Nov 28, 2013 at 12:44 PM, Krzesimir Nowak krzesi...@endocode.com wrote: Allow @additional_branch_refs

Re: [PATCH v3] gitweb: Add an option for adding more branch refs

2013-12-03 Thread Jakub Narębski
On Tue, Dec 3, 2013 at 11:53 AM, Krzesimir Nowak krzesi...@endocode.com wrote: On Mon, 2013-12-02 at 18:34 +0100, Jakub Narębski wrote: W dniu 2013-12-02 13:06, Krzesimir Nowak pisze: On Mon, 2013-12-02 at 01:21 +0100, Jakub Narębski wrote: On Thu, Nov 28, 2013 at 12:44 PM, Krzesimir Nowak

Re: [PATCH 1/3] gitweb: Move check-ref-format code into separate function

2013-12-03 Thread Jakub Narębski
On Tue, Dec 3, 2013 at 8:02 PM, Junio C Hamano gits...@pobox.com wrote: Krzesimir Nowak krzesi...@endocode.com writes: +sub check_ref_format { + my $input = shift || return undef; + + # restrictions on ref name according to git-check-ref-format + if ($input =~

Re: [PATCH 2/3] gitweb: Add a feature for adding more branch refs

2013-12-03 Thread Jakub Narębski
On Tue, Dec 3, 2013 at 9:15 PM, Junio C Hamano gits...@pobox.com wrote: Krzesimir Nowak krzesi...@endocode.com writes: @@ -626,6 +640,17 @@ sub feature_avatar { return @val ? @val : @_; } +sub feature_extra_branch_refs { + my (@branch_refs) = @_; + my $values =

Re: [PATCH 1/5] gitweb: Add a comment explaining the meaning of $/

2013-12-04 Thread Jakub Narębski
On Wed, Dec 4, 2013 at 2:42 PM, Krzesimir Nowak krzesi...@endocode.com wrote: So future reader will know what does it mean without running perldoc perlvar. Hmmm... shouldn't future reader know it anyway? It is not that cryptic. I'd say it is idiomatic Perl. Besides, it is not the only place

Re: [PATCH 2/5] gitweb: Move check-ref-format code into separate function

2013-12-04 Thread Jakub Narębski
On Wed, Dec 4, 2013 at 2:43 PM, Krzesimir Nowak krzesi...@endocode.com wrote: This check will be used in more than one place later. Signed-off-by: Krzesimir Nowak krzesi...@endocode.com Reviewed-by: Junio C Hamano gits...@pobox.com Reviewed-by: Jakub Narębski jna...@gmail.com All right

Re: [PATCH 3/5] gitweb: Return plain booleans in validation methods

2013-12-04 Thread Jakub Narębski
On Wed, Dec 4, 2013 at 2:43 PM, Krzesimir Nowak krzesi...@endocode.com wrote: Users of validate_* passing 0 might get failures on correct name because of coercion of 0 to false in code like: die_error(500, invalid ref) unless (check_ref_format (0)); I would say that the problem was that

Re: [PATCH 1/5] gitweb: Add a comment explaining the meaning of $/

2013-12-04 Thread Jakub Narębski
On Wed, Dec 4, 2013 at 4:46 PM, Krzesimir Nowak krzesi...@endocode.com wrote: On Wed, 2013-12-04 at 16:11 +0100, Jakub Narębski wrote: On Wed, Dec 4, 2013 at 2:42 PM, Krzesimir Nowak krzesi...@endocode.com wrote: So future reader will know what does it mean without running perldoc perlvar

Re: [PATCH 1/5] gitweb: Add a comment explaining the meaning of $/

2013-12-04 Thread Jakub Narębski
On Wed, Dec 4, 2013 at 6:34 PM, Jakub Narębski jna...@gmail.com wrote: On Wed, Dec 4, 2013 at 4:46 PM, Krzesimir Nowak krzesi...@endocode.com wrote: On Wed, 2013-12-04 at 16:11 +0100, Jakub Narębski wrote: On Wed, Dec 4, 2013 at 2:42 PM, Krzesimir Nowak krzesi...@endocode.com wrote: So

Re: [PATCH 4/5] gitweb: Add a feature for adding more branch refs

2013-12-04 Thread Jakub Narębski
-by: Junio C Hamano gits...@pobox.com Reviewed-by: Jakub Narębski jna...@gmail.com This version is Helped-by (maybe), but not (yet!) Reviewed-by. --- Documentation/gitweb.conf.txt | 37 +++ gitweb/gitweb.perl| 85 +-- 2 files

Re: [PATCH 5/5] gitweb: Denote non-heads, non-remotes branches

2013-12-04 Thread Jakub Narębski
On Wed, Dec 4, 2013 at 2:43 PM, Krzesimir Nowak krzesi...@endocode.com wrote: Given two branches residing in refs/heads/master and refs/wip/feature the list-of-branches view will present them in following way: master feature (wip) When getting a snapshot of a 'feature' branch, the tarball

Re: [PATCH 4/5] gitweb: Add a feature for adding more branch refs

2013-12-05 Thread Jakub Narębski
On Thu, Dec 5, 2013 at 11:00 AM, Krzesimir Nowak krzesi...@endocode.com wrote: On Wed, 2013-12-04 at 19:06 +0100, Jakub Narębski wrote: On Wed, Dec 4, 2013 at 2:43 PM, Krzesimir Nowak krzesi...@endocode.com wrote: +The gitweb.extrabranchrefs is actually a multi-valued configuration

  1   2   3   4   5   >