[gwt-contrib] Re: Fix 'ant dist-dev' and 'ant-doc' builds: (issue953801)

2010-10-05 Thread rice
http://gwt-code-reviews.appspot.com/953801/diff/1/5 File user/src/com/google/gwt/requestfactory/client/impl/messages/JsonResults.java (right): http://gwt-code-reviews.appspot.com/953801/diff/1/5#newcode28 user/src/com/google/gwt/requestfactory/client/impl/messages/JsonResults.java:28: // javac

[gwt-contrib] Re: Fix 'ant dist-dev' and 'ant-doc' builds: (issue953801)

2010-10-05 Thread rice
http://gwt-code-reviews.appspot.com/953801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Test timeout in JUnitShell ? (GWT 2.0.0)

2010-10-05 Thread Ed
running the test in your continuous build environment with remote debugging enabled and attaching to it with a debugger to see what is going on. Thanks again. John I did that already but will do it again now that I have a better understanding of the GWT Junit code. (I only have to use some

[gwt-contrib] Re: Removed all the Request sub-types. Fixed the generator and the server code where we were relying... (issue926801)

2010-10-05 Thread Ray Ryan
LGTM Talked offline. Agree that your change is pretty safe. But please be sure to land the corresponding addon-gwt change in lock step. On Mon, Sep 27, 2010 at 2:49 PM, Ray Ryan rj...@google.com wrote: Let's hold off on this one until we find a real solution to the bad create api issue. The

[gwt-contrib] Re: Add a ControllerBinder in UiBinder so that UiHandlers can be bound on both the (issue923801)

2010-10-05 Thread Ray Ryan
It may be a day or two before I can take this review, Zach. Sorry for the delay. On Fri, Sep 24, 2010 at 5:49 PM, zac...@gmail.com wrote: Reviewers: rjrjr, Description: Add a ControllerBinder in UiBinder so that UiHandlers can be bound on both the controller and the view. This allows views

[gwt-contrib] Re: Removed all the Request sub-types. Fixed the generator and the server code where we were relying... (issue926801)

2010-10-05 Thread Ray Ryan
Let's hold off on this one until we find a real solution to the bad create api issue. The sketch in https://jira.springsource.org/browse/ROO-1456 will not do it. On Mon, Sep 27, 2010 at 12:13 PM, Ray Ryan rj...@google.com wrote: On Mon, Sep 27, 2010 at 12:10 PM, amitman...@google.com wrote:

[gwt-contrib] Re: Changes required to make the Scaffold app look like the mocks. Added null checks AbstractProxyLi... (issue925801)

2010-10-05 Thread Ray Ryan
Point taken on the view contention front. I think Thomas is right that setting and clearing the view delegate should happen in start() and stop(), not in the constructor. Thanks, Thomas. On Mon, Sep 27, 2010 at 12:46 PM, t.bro...@gmail.com wrote:

[gwt-contrib] Re: Removing isChanged() because requestProxyGenerator doesn't handle is. (issue907802)

2010-10-05 Thread rjrjr
lgtm http://gwt-code-reviews.appspot.com/907802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add verbose validation and diagnostics to RequestFactoryGenerator (issue929801)

2010-10-05 Thread Ray Ryan
The only blocker bug I see on your list is the one about the pom.xml tweak for Rajeev. https://jira.springsource.org/secure/IssueNavigator.jspa?mode=hiderequestId=12040 The JRE tests are actually pretty easy to write, especially if you copy

[gwt-contrib] Re: Use @UiChild and @UiConstructor (issue865801)

2010-10-05 Thread rjrjr
It seems odd to make these changes to deprecated classes. The NamedFrame case LGTM On 2010/09/12 11:24:12, Konstantin.Scheglov wrote: http://gwt-code-reviews.appspot.com/865801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] EntityProxyId

2010-10-05 Thread Ray Ryan
On Tue, Sep 28, 2010 at 10:13 AM, Patrick Julien pjul...@gmail.com wrote: It's not very clear to me how EntityProxyId helps us achieve very simple scenarios. How do you use this thing when you have pre and post operations to do in an activity? If I have an edit scenario, let's say a user

Re: [gwt-contrib] EntityProxyId

2010-10-05 Thread Ray Ryan
Also note RequestFactory#find(EntityProxyId) On Tue, Sep 28, 2010 at 10:26 AM, Ray Ryan rj...@google.com wrote: On Tue, Sep 28, 2010 at 10:13 AM, Patrick Julien pjul...@gmail.comwrote: It's not very clear to me how EntityProxyId helps us achieve very simple scenarios. How do you use this

[gwt-contrib] Re: Allowing final methods as Tree.addOpenHandler to be bind with (issue881802)

2010-10-05 Thread rjrjr
LGTM Thanks, one nit. http://gwt-code-reviews.appspot.com/881802/diff/1/2 File user/src/com/google/gwt/uibinder/rebind/HandlerEvaluator.java (right): http://gwt-code-reviews.appspot.com/881802/diff/1/2#newcode279 user/src/com/google/gwt/uibinder/rebind/HandlerEvaluator.java:279: // Normalize

[gwt-contrib] Re: Add verbose validation and diagnostics to RequestFactoryGenerator (issue929801)

2010-10-05 Thread rjrjr
You should be able to add JRE tests for these diagnostics, especially if you factor them into a separate helper class. See EditorModelTest for an example. On 2010/09/28 17:20:16, rjrjr wrote: Please fix DTRF and re-enable the commented out block before submitting.

[gwt-contrib] Re: Add verbose validation and diagnostics to RequestFactoryGenerator (issue929801)

2010-10-05 Thread rjrjr
Please fix DTRF and re-enable the commented out block before submitting. http://gwt-code-reviews.appspot.com/929801/diff/1/2 File user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java (right): http://gwt-code-reviews.appspot.com/929801/diff/1/2#newcode157

[gwt-contrib] Re: Add tests to verify that proxies created on the client side can be sent across the wire, both i... (issue936801)

2010-10-05 Thread rjrjr
LGTM On 2010/09/30 01:53:37, amitmanjhi wrote: http://gwt-code-reviews.appspot.com/936801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enable ability to display leaves of CellTreeView as a Grid (issue943801)

2010-10-05 Thread quintok
http://gwt-code-reviews.appspot.com/943801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding more unit tests to RequestFactoryTest. Refactoring SimpleFoo to use a HashMap to store re... (issue931802)

2010-10-05 Thread Ray Ryan
Please be careful with that kind of quick hack. What will happen to the person who writes the next test? On Wed, Sep 29, 2010 at 3:44 PM, jlaba...@google.com wrote: http://gwt-code-reviews.appspot.com/931802/diff/1/6 File user/test/com/google/gwt/requestfactory/server/SimpleFoo.java (right):

[gwt-contrib] Re: Added a RowStyles interface that can be used to customize the classes (issue930801)

2010-10-05 Thread dburrows
http://gwt-code-reviews.appspot.com/930801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Changes to the expenses sample to match the GWT changes in http://code.google.com/p/google-web-t... (issue932801)

2010-10-05 Thread rjrjr
LGTM On 2010/09/29 15:53:31, amitmanjhi wrote: http://gwt-code-reviews.appspot.com/932801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Enable ability to display leaves of CellTreeView as a Grid (issue943801)

2010-10-05 Thread quintok
Reviewers: , Description: Gives the ability to specify css values within the CellTreeView if the node is a leaf or a branch. Also changed the padding-left/right of children within the tree. an example of the css to allow the tree to display the children in a grid is: .cellTreeItemLeaf {

[gwt-contrib] Re: Fix asJsonString() to properly encode nulls (issue932802)

2010-10-05 Thread Ray Ryan
Just to reiterate: please make sure that this fix lands with the test that it fixes. On Thu, Sep 30, 2010 at 10:45 AM, cromwell...@google.com wrote: Reviewers: rjrjr, robertvawter, Description: Fix asJsonString() to properly encode nulls Please review this at

[gwt-contrib] Re: Adding more unit tests to RequestFactoryTest. Refactoring SimpleFoo to use a HashMap to store re... (issue931802)

2010-10-05 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/931802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] moving to EntityProxyId

2010-10-05 Thread Ray Ryan
On Wed, Sep 29, 2010 at 2:18 PM, Patrick Julien pjul...@gmail.com wrote: I am trying to migrate to EntityProxyId and all I can get is java.lang.AssertionError: encodedId required When do you get this? What did you call? Presuming you got it by calling stableId on a proxy, where did that

[gwt-contrib] Re: Adding more unit tests to RequestFactoryTest. Refactoring SimpleFoo to use a HashMap to store re... (issue931802)

2010-10-05 Thread Ray Ryan
Ray C, can you take this review? On Wed, Sep 29, 2010 at 2:20 PM, jlaba...@google.com wrote: Reviewers: rjrjr, Description: Adding more unit tests to RequestFactoryTest. Refactoring SimpleFoo to use a HashMap to store records instead of a singleton. Please review this at

[gwt-contrib] Fix nonstandard two method handler interface that probably would have (issue941801)

2010-10-05 Thread rjrjr
Reviewers: rice, Description: Fix nonstandard two method handler interface that probably would have broken UiBinder. Please review this at http://gwt-code-reviews.appspot.com/941801/show Affected files: M user/src/com/google/gwt/event/logical/shared/AttachEvent.java M

[gwt-contrib] Re: RR : Overhaul the client-side RequestFactory code (issue924801)

2010-10-05 Thread rjrjr
As discussed, please fix samples/expenses too. Below I've answered the XXX blockers you pointed out so you should be able jump on it. http://gwt-code-reviews.appspot.com/924801/diff/2001/3007 File user/src/com/google/gwt/app/place/AbstractProxyListActivity.java (right):

[gwt-contrib] Enable ability to display leaves in a CellTreeWidget as a grid rather than as a list.

2010-10-05 Thread Nick Cronin
Hi, Was wondering if I could get a code-review done on this patch please. It adds two classes, one that is only placed on leaves and one that is placed on branches. It also changes the way indentation works so that the whole set of children of a branch are indented as a group rather than

[gwt-contrib] Re: Fix ClassCastException in AbtstractRequestContext.isChanged(); (issue931803)

2010-10-05 Thread Ray Ryan
LGTM Thanks! On Sun, Oct 3, 2010 at 4:46 PM, b...@google.com wrote: Reviewers: rjrjr, Description: Fix ClassCastException in AbtstractRequestContext.isChanged(); Patch by: bobv Review by: rjrjr Please review this at http://gwt-code-reviews.appspot.com/931803/show Affected files: M

Re: [gwt-contrib] Sub entities not being filled in

2010-10-05 Thread Ray Ryan
At the moment we always fetch all non-entities, and only treat with() as additive, to add related entities into the mix. I'm a bit concerned about that, actually. With the RF overhaul we no longer have a client side cache to confuse things, so I wonder if we should try to get sparse DTOs in place

[gwt-contrib] Re: Fix NPE in AbstractRequestContext with newly-created items. (issue938802)

2010-10-05 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/938802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add test to verify fix of ROO-1215 (issue947801)

2010-10-05 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/947801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Changes in com.google.gwt.app land to catch up to the RequestFactory (issue946802)

2010-10-05 Thread rjrjr
Submitting. http://gwt-code-reviews.appspot.com/946802/diff/1/3 File user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java (right): http://gwt-code-reviews.appspot.com/946802/diff/1/3#newcode83 user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java:83: setWaiting(true);

[gwt-contrib] Fix exit on cancel from create activity. Wasn't going to a (issue950801)

2010-10-05 Thread rjrjr
Reviewers: cromwellian, Description: Fix exit on cancel from create activity. Wasn't going to a new place, so you couldn't try to create again. Please review this at http://gwt-code-reviews.appspot.com/950801/show Affected files: M user/src/com/google/gwt/app/place/CreateAndEditProxy.java

[gwt-contrib] Re: RR : Overhaul the client-side RequestFactory code (issue924801)

2010-10-05 Thread rjrjr
Flushing comments accumulated so far. Still reviewing. http://gwt-code-reviews.appspot.com/924801/diff/2001/3010 File user/src/com/google/gwt/editor/client/AutoBean.java (right): http://gwt-code-reviews.appspot.com/924801/diff/2001/3010#newcode21

Re: [gwt-contrib] Sub entities not being filled in

2010-10-05 Thread Ray Ryan
Bob is in transit today. We're working on a fix. On Mon, Oct 4, 2010 at 9:07 AM, Patrick Julien pjul...@gmail.com wrote: Bob, any suggestions for a work around for the moment? On Mon, Oct 4, 2010 at 9:41 AM, Patrick Julien pjul...@gmail.com wrote: For the editor part, I can see in the

[gwt-contrib] Re: RR : Overhaul the client-side RequestFactory code (issue924801)

2010-10-05 Thread rjrjr
I have to admit that I skimmed the code generators. I'm as reviewed as I can be. LGTM once I've looked through the changes we all discussed off line to base update events on the version number http://gwt-code-reviews.appspot.com/924801/diff/13001/7090 File

[gwt-contrib] Changes in com.google.gwt.app land to catch up to the RequestFactory (issue946802)

2010-10-05 Thread rjrjr
Reviewers: cromwellian, Description: Changes in com.google.gwt.app land to catch up to the RequestFactory overhaul. In particular, nukes PropertyColumn, and reworks AbstractProxyEdit now that create semantics have changed. Made APE a bit less monolithic in the process. I will still be busting

Re: [gwt-contrib] Sub entities not being filled in

2010-10-05 Thread Ray Ryan
The editor framework can give you the info for the with calls, but it's up to you to use it. If you want everything, put the contents of RequestFactoryEditorDriver.getPaths() into your with() call. On Sun, Oct 3, 2010 at 4:10 PM, Ray Cromwell cromwell...@gmail.com wrote: Any relational

[gwt-contrib] Re: Update DynaTableRf sample to demonstrate Leaf+CompositeEditor that shows how to work with option... (issue948801)

2010-10-05 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/948801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Changes in com.google.gwt.app land to catch up to the RequestFactory (issue946802)

2010-10-05 Thread rjrjr
http://gwt-code-reviews.appspot.com/946802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix NullPointerException in SimpleEntityProxyId. (issue949801)

2010-10-05 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/949801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Sub entities not being filled in

2010-10-05 Thread Ray Ryan
https://jira.springsource.org/browse/ROO-1488 On Mon, Oct 4, 2010 at 11:13 AM, Ray Ryan rj...@google.com wrote: Bob is in transit today. We're working on a fix. On Mon, Oct 4, 2010 at 9:07 AM, Patrick Julien pjul...@gmail.com wrote: Bob, any suggestions for a work around for the moment?

[gwt-contrib] Re: Update DynaTableRf sample to demonstrate Leaf+CompositeEditor that shows how to work with option... (issue948801)

2010-10-05 Thread rjrjr
Nice, but now I have to ask you for OptionalFieldEditorTest http://gwt-code-reviews.appspot.com/948801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix exit on cancel from create activity. Wasn't going to a (issue950801)

2010-10-05 Thread rjrjr
http://gwt-code-reviews.appspot.com/950801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Package re-org in advance of 2.1 RC. (issue957801)

2010-10-05 Thread rjrjr
Oops, forgot the renderer tests. Added. http://gwt-code-reviews.appspot.com/957801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Changes in com.google.gwt.app land to catch up to the RequestFactory (issue946802)

2010-10-05 Thread Ray Ryan
Thanks, will fix. On Mon, Oct 4, 2010 at 3:22 AM, t.bro...@gmail.com wrote: http://gwt-code-reviews.appspot.com/946802/diff/8001/9006 File user/src/com/google/gwt/app/place/FindAndEditProxy.java (right): http://gwt-code-reviews.appspot.com/946802/diff/8001/9006#newcode50

[gwt-contrib] Re: Changes in com.google.gwt.app land to catch up to the RequestFactory (issue946802)

2010-10-05 Thread Ray Ryan
Caught that case, fix is in http://gwt-code-reviews.appspot.com/950801 On Mon, Oct 4, 2010 at 1:22 AM, t.bro...@gmail.com wrote: http://gwt-code-reviews.appspot.com/946802/diff/8001/9005 File user/src/com/google/gwt/app/place/CreateAndEditProxy.java (right):

[gwt-contrib] Re: Fixed the serialization bug that the version numbers were not being sent back (issue930802)

2010-10-05 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/930802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Package re-org in advance of 2.1 RC. (issue957801)

2010-10-05 Thread rjrjr
Reviewers: cromwellian, Description: Package re-org in advance of 2.1 RC. * Proxy specific places and activities are half baked, and have been banished to the expenses sample (which will later be updated to use them) * com.google.gwt.app has been broken up into gwt.place and gwt.activity * ui

[gwt-contrib] Re: Package re-org in advance of 2.1 RC. (issue957801)

2010-10-05 Thread rjrjr
http://gwt-code-reviews.appspot.com/957801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixed the serialization bug that the version numbers were not being sent back (issue930802)

2010-10-05 Thread rjrjr
LGTM with the following changes. We need a follow up that makes Foo and Bar more realistic, s.t. the counter is incremented only when they actually change. You might use AutoBean to simplify that. http://gwt-code-reviews.appspot.com/930802/diff/1/3 File

[gwt-contrib] Re: Adding examples for cell widgets and data providers. (issue955801)

2010-10-05 Thread jlabanca
http://gwt-code-reviews.appspot.com/955801/diff/1/2 File user/javadoc/com/google/gwt/examples/cell/CellExample.java (right): http://gwt-code-reviews.appspot.com/955801/diff/1/2#newcode77 user/javadoc/com/google/gwt/examples/cell/CellExample.java:77: super(click, keydown); Which class would it

[gwt-contrib] Re: Adding examples for cell widgets and data providers. (issue955801)

2010-10-05 Thread jlabanca
http://gwt-code-reviews.appspot.com/955801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix 'ant dist-dev' and 'ant-doc' builds: (issue953801)

2010-10-05 Thread fabbott
Lgtm. http://gwt-code-reviews.appspot.com/953801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix verifyPositionStatic() to that RooPanel.get() is explicitly allowed, e.g. (issue931801)

2010-10-05 Thread fredsa
Verified manually that using GWT.isProdMode() as an early exit indeed gets rid of Class.getName() http://gwt-code-reviews.appspot.com/931801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding examples for cell widgets and data providers. (issue955801)

2010-10-05 Thread arthur . kalm
http://gwt-code-reviews.appspot.com/955801/diff/1/2 File user/javadoc/com/google/gwt/examples/cell/CellExample.java (right): http://gwt-code-reviews.appspot.com/955801/diff/1/2#newcode77 user/javadoc/com/google/gwt/examples/cell/CellExample.java:77: super(click, keydown); On 2010/10/05

[gwt-contrib] Re: Adding examples for cell widgets and data providers. (issue955801)

2010-10-05 Thread arthur . kalm
http://gwt-code-reviews.appspot.com/955801/diff/1/2 File user/javadoc/com/google/gwt/examples/cell/CellExample.java (right): http://gwt-code-reviews.appspot.com/955801/diff/1/2#newcode77 user/javadoc/com/google/gwt/examples/cell/CellExample.java:77: super(click, keydown); Sorry, I haven't kept

[gwt-contrib] Re: Fix ROO-1488 where forward references were not correctly resolved. (issue958801)

2010-10-05 Thread rjrjr
LGTM with doc changes below. Should also add tests that we really don't post extra wide side effect updates, as we discussed. http://gwt-code-reviews.appspot.com/958801/diff/1/2 File user/src/com/google/gwt/requestfactory/client/impl/AbstractRequestContext.java (right):

[gwt-contrib] Re: Package re-org in advance of 2.1 RC. (issue957801)

2010-10-05 Thread rjrjr
Bob has offered to take the review. http://gwt-code-reviews.appspot.com/957801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Send an update notification to a stale client by comparing the incoming version (issue959801)

2010-10-05 Thread amitmanjhi
Reviewers: rjrjr, robertvawter, Description: Send an update notification to a stale client by comparing the incoming version number, with the version number on the server. This code path will only be taken if the ORM system has not flagged any errors. Hacked the test harness so that the version

[gwt-contrib] Re: Fix Eclipse / Checkstyle / Javadoc warnings (issue954801)

2010-10-05 Thread jat
Mostly LGTM with some small suggestions. However, I think there is one big thing that needs further discussion -- I think instead of trying to change the code, I suggest we change the Eclipse warnings to not warn about unused parameters in implemented/overridden methods.

[gwt-contrib] Re: Send an update notification to a stale client by comparing the incoming version (issue959801)

2010-10-05 Thread Ray Ryan
Per our offline discussion, you should do the version check before bothering with any diff checks — if the client is stale, we know it needs to update the entity regardless of what happens when the method fires. It's tempting to rip out the diff mechanism entirely, but this is not the the time.

[gwt-contrib] Re: Package re-org in advance of 2.1 RC. (issue957801)

2010-10-05 Thread rjrjr
Per our offline conversation, I'll • move TakesValue back into user.client • move RequestFactoryEditorDriver back into requestfactory.client • segerate the user.client.ui dependent bits of editor into editor.ui.client http://gwt-code-reviews.appspot.com/957801/show --

[gwt-contrib] [google-web-toolkit] r8934 committed - Fixes to use Java 1.5 compatible JARs...

2010-10-05 Thread codesite-noreply
Revision: 8934 Author: rchan...@google.com Date: Tue Oct 5 05:31:20 2010 Log: Fixes to use Java 1.5 compatible JARs Fixed DynaTableRf eclipse .classpath to use json-1.5.jar Fixed build scripts and eclipse classpaths to use java 1.5 compatible StreamHtmlParser JAR Review at

[gwt-contrib] Remove remaining use of JSON.stringify() and replace with simple StringBuilder concatenation. (issue960801)

2010-10-05 Thread bobv
Reviewers: cromwellian, Description: Remove remaining use of JSON.stringify() and replace with simple StringBuilder concatenation. Patch by: bobv Review by: cromwellian Please review this at http://gwt-code-reviews.appspot.com/960801/show Affected files: D

[gwt-contrib] Re: Send an update notification to a stale client by comparing the incoming version (issue959801)

2010-10-05 Thread amitmanjhi
http://gwt-code-reviews.appspot.com/959801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding examples for cell widgets and data providers. (issue955801)

2010-10-05 Thread jlabanca
http://gwt-code-reviews.appspot.com/955801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8935 committed - Changes the default row count of HasDataPresenter from Integer.MIN_VAL...

2010-10-05 Thread codesite-noreply
Revision: 8935 Author: jlaba...@google.com Date: Tue Oct 5 05:40:44 2010 Log: Changes the default row count of HasDataPresenter from Integer.MIN_VALUE to a more reasonable 0. We use the boolean isRowCountExact to determine if we actually have 0 rows, or just think we do. Review at

[gwt-contrib] [google-web-toolkit] r8936 committed - Fix verifyPositionStatic() so that RootPanel.get() is explicitly allow...

2010-10-05 Thread codesite-noreply
Revision: 8936 Author: fre...@google.com Date: Tue Oct 5 06:38:51 2010 Log: Fix verifyPositionStatic() so that RootPanel.get() is explicitly allowed, e.g. RootPanel.get().add(widget, x, y), by whitelisting a BODY parent element. Also, only perform parent==offsetParent test when both parent

[gwt-contrib] Remove dependency on CastableTypeMap from deRPC (issue943803)

2010-10-05 Thread jbrosenberg
Reviewers: zundel, Description: Remove dependency on CastableTypeMap from deRPC Please review this at http://gwt-code-reviews.appspot.com/943803/show Affected files: M user/src/com/google/gwt/rpc/linker/CastableTypeDataImpl.java M user/src/com/google/gwt/rpc/linker/ClientOracleLinker.java

[gwt-contrib] Remove extra slash from request URL of Showcase source files to be compatible with servers that ... (issue961801)

2010-10-05 Thread jlabanca
Reviewers: kathrin, Description: Remove extra slash from request URL of Showcase source files to be compatible with servers that do not all double slashses. Please review this at http://gwt-code-reviews.appspot.com/961801/show Affected files: M

[gwt-contrib] [google-web-toolkit] r8937 committed - Fix ROO-1488 where forward references were not correctly resolved....

2010-10-05 Thread codesite-noreply
Revision: 8937 Author: b...@google.com Date: Tue Oct 5 09:11:00 2010 Log: Fix ROO-1488 where forward references were not correctly resolved. Patch by: cromwellian, bobv Review by: bobv, cromwellian Review at http://gwt-code-reviews.appspot.com/958801

[gwt-contrib] Re: Remove dependency on CastableTypeMap from deRPC (issue943803)

2010-10-05 Thread zundel
LGTM http://gwt-code-reviews.appspot.com/943803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Remove extra slash from request URL of Showcase source files to be compatible with servers that ... (issue961801)

2010-10-05 Thread kprobst
LGTM http://gwt-code-reviews.appspot.com/961801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix Eclipse / Checkstyle / Javadoc warnings (issue954801)

2010-10-05 Thread rice
http://gwt-code-reviews.appspot.com/954801/diff/1/6 File dev/core/src/com/google/gwt/dev/jjs/impl/OptimizerStats.java (right): http://gwt-code-reviews.appspot.com/954801/diff/1/6#newcode91 dev/core/src/com/google/gwt/dev/jjs/impl/OptimizerStats.java:91: * Return a human readable string

[gwt-contrib] Re: Fix verifyPositionStatic() to that RooPanel.get() is explicitly allowed, e.g. (issue931801)

2010-10-05 Thread fredsa
Commited in r8936 http://gwt-code-reviews.appspot.com/931801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixed the serialization bug that the version numbers were not being sent back (issue930802)

2010-10-05 Thread Amit Manjhi
Submitted http://code.google.com/p/google-web-toolkit/source/detail?r=8932 On Mon, Oct 4, 2010 at 5:59 PM, rj...@google.com wrote: LGTM http://gwt-code-reviews.appspot.com/930802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Send an update notification to a stale client by comparing the incoming version (issue959801)

2010-10-05 Thread Amit Manjhi
The updated patch incorporates the feedback. On Tue, Oct 5, 2010 at 11:59 AM, amitman...@google.com wrote: http://gwt-code-reviews.appspot.com/959801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Send an update notification to a stale client by comparing the incoming version (issue959801)

2010-10-05 Thread rjrjr
http://gwt-code-reviews.appspot.com/959801/diff/4001/5001 File user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java (right): http://gwt-code-reviews.appspot.com/959801/diff/4001/5001#newcode78 user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:78:

[gwt-contrib] Re: Send an update notification to a stale client by comparing the incoming version (issue959801)

2010-10-05 Thread bobv
http://gwt-code-reviews.appspot.com/959801/diff/4001/5001 File user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java (right): http://gwt-code-reviews.appspot.com/959801/diff/4001/5001#newcode1381 user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:1381: *

[gwt-contrib] [google-web-toolkit] r8938 committed - Original change by Ray Cromwell...

2010-10-05 Thread codesite-noreply
Revision: 8938 Author: r...@google.com Date: Tue Oct 5 10:23:33 2010 Log: Original change by Ray Cromwell Add validation of context methods and proxy against domain objects. Add verbose diagnostic messages. Add test cases for RequestFactoryModel. Review at

[gwt-contrib] Re: Changes the default row count of HasDataPresenter from Integer.MIN_VALUE to a more reasonable 0.... (issue950802)

2010-10-05 Thread jlabanca
committed as r8935 http://gwt-code-reviews.appspot.com/950802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8939 committed - Remove remaining use of JSON.stringify() and replace with simple Strin...

2010-10-05 Thread codesite-noreply
Revision: 8939 Author: b...@google.com Date: Tue Oct 5 10:47:22 2010 Log: Remove remaining use of JSON.stringify() and replace with simple StringBuilder concatenation. Patch by: bobv Review by: cromwellian Review at http://gwt-code-reviews.appspot.com/960801

[gwt-contrib] Re: Fix Eclipse / Checkstyle / Javadoc warnings (issue954801)

2010-10-05 Thread jat
LGTM http://gwt-code-reviews.appspot.com/954801/diff/1/19 File samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseDetails.java (left): http://gwt-code-reviews.appspot.com/954801/diff/1/19#oldcode46

[gwt-contrib] [google-web-toolkit] r8940 committed - Remove extra slash from request URL of Showcase source files to be com...

2010-10-05 Thread codesite-noreply
Revision: 8940 Author: jlaba...@google.com Date: Tue Oct 5 10:51:03 2010 Log: Remove extra slash from request URL of Showcase source files to be compatible with servers that do not all double slashses. Review at http://gwt-code-reviews.appspot.com/961801 Review by: kpro...@google.com

[gwt-contrib] Avoid an infinite loop in toString() for collections that directly include themselves (issue962801)

2010-10-05 Thread rice
Reviewers: jat, Description: Avoid an infinite loop in toString() for collections that directly include themselves Please review this at http://gwt-code-reviews.appspot.com/962801/show Affected files: M user/super/com/google/gwt/emul/java/util/AbstractCollection.java Index:

[gwt-contrib] Re: Remove extra slash from request URL of Showcase source files to be compatible with servers that ... (issue961801)

2010-10-05 Thread jlabanca
committed as r8940 http://gwt-code-reviews.appspot.com/961801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Send an update notification to a stale client by comparing the incoming version (issue959801)

2010-10-05 Thread Amit Manjhi
On Tue, Oct 5, 2010 at 1:26 PM, rj...@google.com wrote: http://gwt-code-reviews.appspot.com/959801/diff/4001/5001 File user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java (right): http://gwt-code-reviews.appspot.com/959801/diff/4001/5001#newcode78

[gwt-contrib] Re: Send an update notification to a stale client by comparing the incoming version (issue959801)

2010-10-05 Thread Amit Manjhi
Done everything. On Tue, Oct 5, 2010 at 1:32 PM, b...@google.com wrote: http://gwt-code-reviews.appspot.com/959801/diff/4001/5001 File user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java (right): http://gwt-code-reviews.appspot.com/959801/diff/4001/5001#newcode1381

[gwt-contrib] Re: Avoid an infinite loop in toString() for collections that directly include themselves (issue962801)

2010-10-05 Thread jat
http://gwt-code-reviews.appspot.com/962801/diff/1/2 File user/super/com/google/gwt/emul/java/util/AbstractCollection.java (right): http://gwt-code-reviews.appspot.com/962801/diff/1/2#newcode146 user/super/com/google/gwt/emul/java/util/AbstractCollection.java:146: sb.append(value == this ? (this

[gwt-contrib] Re: Send an update notification to a stale client by comparing the incoming version (issue959801)

2010-10-05 Thread amitmanjhi
http://gwt-code-reviews.appspot.com/959801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Avoid an infinite loop in toString() for collections that directly include themselves (issue962801)

2010-10-05 Thread דניאל רייס
This emulates JRE behavior, as pointed out in http://code.google.com/p/google-web-toolkit/issues/detail?id=5297. Dan On Tue, Oct 5, 2010 at 5:11 PM, j...@google.com wrote: http://gwt-code-reviews.appspot.com/962801/diff/1/2 File

[gwt-contrib] Re: Avoid an infinite loop in toString() for collections that directly include themselves (issue962801)

2010-10-05 Thread jat
On 2010/10/05 21:16:39, rice wrote: This emulates JRE behavior, as pointed out in http://code.google.com/p/google-web-toolkit/issues/detail?id=5297. Ok. http://gwt-code-reviews.appspot.com/962801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Send an update notification to a stale client by comparing the incoming version (issue959801)

2010-10-05 Thread rjrjr
http://gwt-code-reviews.appspot.com/959801/diff/4001/5001 File user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java (right): http://gwt-code-reviews.appspot.com/959801/diff/4001/5001#newcode78 user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:78:

[gwt-contrib] Re: Send an update notification to a stale client by comparing the incoming version (issue959801)

2010-10-05 Thread Amit Manjhi
Updated patch incorporates the feedback, including adding the additional test. On Tue, Oct 5, 2010 at 2:14 PM, amitman...@google.com wrote: http://gwt-code-reviews.appspot.com/959801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8941 committed - Fix Eclipse / Checkstyle / Javadoc warnings...

2010-10-05 Thread codesite-noreply
Revision: 8941 Author: gwt.mirror...@gmail.com Date: Tue Oct 5 14:33:18 2010 Log: Fix Eclipse / Checkstyle / Javadoc warnings Review at http://gwt-code-reviews.appspot.com/954801 Review by: j...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8941 Modified:

[gwt-contrib] [google-web-toolkit] r8942 committed - Remove dependency on CastableTypeMap from deRPC...

2010-10-05 Thread codesite-noreply
Revision: 8942 Author: jbrosenb...@google.com Date: Tue Oct 5 11:17:13 2010 Log: Remove dependency on CastableTypeMap from deRPC Review at http://gwt-code-reviews.appspot.com/943803 Review by: zun...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8942 Modified:

[gwt-contrib] [google-web-toolkit] r8943 committed - Fix 'ant dist-dev' and 'ant-doc' builds:...

2010-10-05 Thread codesite-noreply
Revision: 8943 Author: gwt.mirror...@gmail.com Date: Tue Oct 5 14:37:58 2010 Log: Fix 'ant dist-dev' and 'ant-doc' builds: 1) Add memory to java heap for 'gwt.javac' 2) Break up a line in JsonResults that caused javac to exit 3) Remove an annotation in SafeHtmlHostedModeUtils that caused javadoc

[gwt-contrib] Re: Comment on DefaultLocaleBinding in google-web-toolkit

2010-10-05 Thread codesite-noreply
Comment by saglikpasaji: Genel içerik ve özgün makaleler ile a href=http://www.saglikpasaji.com;sağlık/a pasajı sizler ile burada a href=http://www.saglikpasaji.com;dengeli beslenme/aküçüklerin a href=http://www.oyuncun.com;oyun oyna/ama merağını a

<    1   2   3   >