[gwt-contrib] Re: Deal with null (but defined) localStorage and sessionStorage objects. (issue1615807)

On 2011/12/27 18:39:02, pdr wrote: On 2011/12/20 04:12:58, Jason Terk wrote: Thank you for the patch! I vaguely remember there being cross-browser issues with this approach, but I just tested IE9, IE7, FF3.6 and FF4 and things look good so far with your new approach. Modernizr even

[gwt-contrib] Re: Deal with null (but defined) localStorage and sessionStorage objects. (issue1615807)

On 2011/12/20 04:12:58, Jason Terk wrote: Thank you for the patch! I vaguely remember there being cross-browser issues with this approach, but I just tested IE9, IE7, FF3.6 and FF4 and things look good so far with your new approach. Modernizr even wraps this check in a try/catch, but I think

[gwt-contrib] Re: change to fix the JavaDoc error during build (issue1478801)

On 2011/07/12 17:50:51, Mark R Russell wrote: LGTM! http://gwt-code-reviews.appspot.com/1478801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Change formatter to use 100 col. comments and add a checkstyle check for it (issue1465803)

http://gwt-code-reviews.appspot.com/1465803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Change formatter to use 100 col. comments and add a checkstyle check for it (issue1465803)

Thanks for the review! Looks like we might get this to land once and for all :) http://gwt-code-reviews.appspot.com/1465803/diff/8/build-tools/customchecks/src/com/google/gwt/checkstyle/GwtHeaderCheck.java File build-tools/customchecks/src/com/google/gwt/checkstyle/GwtHeaderCheck.java (right):

[gwt-contrib] Change formatter to use 100 col. comments and add a checkstyle check for it (issue1465803)

Reviewers: rjrjr, Description: Change formatter to use 100 col. comments and add a checkstyle check for it Please review this at http://gwt-code-reviews.appspot.com/1465803/ Affected files: A build-tools/customchecks/src/com/google/gwt/checkstyle/CustomRegexpHeaderCheck.java A

[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)

http://gwt-code-reviews.appspot.com/1407803/diff/5001/user/src/com/google/gwt/user/tools/WebAppCreator.java File user/src/com/google/gwt/user/tools/WebAppCreator.java (right): http://gwt-code-reviews.appspot.com/1407803/diff/5001/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode461

[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)

LGTM http://gwt-code-reviews.appspot.com/1407803/diff/10001/user/src/com/google/gwt/user/tools/WebAppCreator.java File user/src/com/google/gwt/user/tools/WebAppCreator.java (right):

[gwt-contrib] Re: New projects should always have a DTD specified in their template .gwt.xml module file (issue1407803)

On 2011/06/17 15:36:34, fredsa wrote: http://gwt-code-reviews.appspot.com/1407803/diff/10001/user/src/com/google/gwt/user/tools/WebAppCreator.java File user/src/com/google/gwt/user/tools/WebAppCreator.java (right):

[gwt-contrib] Re: Autoformat of Widget in preparation for some new additions. (issue1447822)

On 2011/06/08 23:14:41, rjrjr wrote: LGTM. http://gwt-code-reviews.appspot.com/1447822/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Format comments to 100 columns to match code format (issue1450808)

I wasn't able to find that in the style guide or discussion when it was changed. 80 code / 100 comments feels inconsistent. On 2011/05/29 23:06:55, zundel wrote: Leaving comments at 80 was intentional as per the style guide, I thought. On May 29, 2011 6:43 PM, mailto:p...@google.com wrote:

[gwt-contrib] Format comments to 100 columns to match code format (issue1450808)

Reviewers: zundel, rjrjr, Description: Format comments to 100 columns to match code format Please review this at http://gwt-code-reviews.appspot.com/1450808/ Affected files: M eclipse/settings/code-style/gwt-format.xml Index: eclipse/settings/code-style/gwt-format.xml

[gwt-contrib] Re: Adds HTML5 App Cache support to MobileWebApp sample. (issue1428811)

You'll need to add this to the mobile web app .gwt.xml: add-linker name=simpleappcachelinker / http://gwt-code-reviews.appspot.com/1428811/diff/1/dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java File dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java (right):

[gwt-contrib] Re: Adds HTML5 App Cache support to MobileWebApp sample. (issue1422815)

Rietveld is giving me a bunch of errors trying to read files such as web.xml. I reviewed the one file I could access and that is relevant to this change, but do you mind re-uploading the patch?

[gwt-contrib] Re: Adding the SourceElement for use with Audio and Video, and adding convenience methods in those w... (issue1423810)

/client/SourceElement.java#newcode67 user/src/com/google/gwt/dom/client/SourceElement.java:67: * Sets the type of media represented by the src. On 2011/04/28 00:18:50, pdr wrote: Can you add a mention that codec info can be specified here too? Maybe provide an example in the doc like: type

[gwt-contrib] Re: Adding the SourceElement for use with Audio and Video, and adding convenience methods in those w... (issue1423810)

http://gwt-code-reviews.appspot.com/1423810/diff/1/user/src/com/google/gwt/dom/client/SourceElement.java File user/src/com/google/gwt/dom/client/SourceElement.java (right): http://gwt-code-reviews.appspot.com/1423810/diff/1/user/src/com/google/gwt/dom/client/SourceElement.java#newcode67

[gwt-contrib] Re: Adding the SourceElement for use with Audio and Video, and adding convenience methods in those w... (issue1423810)

http://gwt-code-reviews.appspot.com/1423810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Change Audio and Video support detection method for Safari3. (issue1423802)

Reviewers: jlabanca, Description: Change Audio and Video support detection method for Safari3. Safari3 incorrectly reports that audio/video are supported when using !!element.play, but correctly reports that audio/video are not supported using !!element.canPlayType. This was verified to work

[gwt-contrib] Re: Fixing a bug in Image where IE throws a native JavaScript exception if an image is attached and ... (issue1421801)

LGTM http://gwt-code-reviews.appspot.com/1421801/diff/1/user/test/com/google/gwt/user/client/ui/ImageTest.java File user/test/com/google/gwt/user/client/ui/ImageTest.java (right):

[gwt-contrib] Re: Auto-formats the GWT tools projects (excluding api-checker covered in (issue1402803)

On 2011/04/15 15:35:21, zundel wrote: ping Despite my minor complaints, but this matches what was proposed so LGTM. http://gwt-code-reviews.appspot.com/1402803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Audio and Video cleanup. (issue1415801)

http://gwt-code-reviews.appspot.com/1415801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removing duplicate entries from User.gwt.xml that were added in r9976 due to an undetected merge... (issue1422801)

On 2011/04/15 13:35:59, jlabanca wrote: LGTM http://gwt-code-reviews.appspot.com/1422801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Audio and Video cleanup. (issue1415801)

Reviewers: jlabanca, Description: Audio and Video cleanup. Add a MediaBase widget backing Audio and Video, and clean up tests. Also, address comments by reviewer and re-encode test media files for a smaller size and to fix an h264 video issue. Please review this at

[gwt-contrib] Re: Improving TouchScroller to allow native document level scrolling when appropriate. If the scroll... (issue1410803)

On 2011/04/12 20:17:42, jlabanca wrote: LGTM. Much better! http://gwt-code-reviews.appspot.com/1410803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Audio and Video cleanup. (issue1415801)

http://gwt-code-reviews.appspot.com/1415801/diff/1/user/src/com/google/gwt/media/client/Video.java File user/src/com/google/gwt/media/client/Video.java (right): http://gwt-code-reviews.appspot.com/1415801/diff/1/user/src/com/google/gwt/media/client/Video.java#newcode88

[gwt-contrib] Re: Audio and Video cleanup. (issue1415801)

http://gwt-code-reviews.appspot.com/1415801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Escape single characters in SafeHtmlBuilder/SafeHtmlUtils (external issue 6222) (issue1413802)

On 2011/04/12 18:35:43, xtof wrote: LGTM. LGTM2 http://gwt-code-reviews.appspot.com/1413802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add the beginnings of new HTML5 drag and drop events (issue1398802)

/google/gwt/event/dom/client/DragExitEvent.java#newcode41 user/src/com/google/gwt/event/dom/client/DragExitEvent.java:41: * {@link DomEvent#fireNativeEvent(com.google.gwt.dom.client.NativeEvent, com.google.gwt.event.shared.HasHandlers)} On 2011/04/04 14:43:23, pdr wrote: Line 100 chars. Done

[gwt-contrib] Re: Updating Showcase to use LayoutPanels throughout the hierarchy, thus implementing ProvidesResize... (issue1409801)

LGTM pending a check of showcase on mobile/tablet devices. http://gwt-code-reviews.appspot.com/1409801/diff/1/samples/showcase/src/com/google/gwt/sample/showcase/client/ContentWidget.java File samples/showcase/src/com/google/gwt/sample/showcase/client/ContentWidget.java (right):

[gwt-contrib] Re: Add the beginnings of new HTML5 drag and drop events (issue1398802)

On 2011/03/31 17:50:22, fredsa wrote: LGTM http://gwt-code-reviews.appspot.com/1398802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add the beginnings of new HTML5 drag and drop events (issue1398802)

LGTM http://gwt-code-reviews.appspot.com/1398802/diff/1/user/src/com/google/gwt/event/dom/client/DragExitEvent.java File user/src/com/google/gwt/event/dom/client/DragExitEvent.java (right):

[gwt-contrib] Re: Adding a SuppressWarnings to prevent the Google Plugin for Eclipse from marking this class as error. (issue1386805)

On 2011/03/31 18:35:21, schenney wrote: LGTM http://gwt-code-reviews.appspot.com/1386805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes build break - unit test expected non-existent dir to throw an exception (issue1396802)

LGTM http://gwt-code-reviews.appspot.com/1396802/diff/2001/dev/core/test/com/google/gwt/dev/javac/PersistentUnitCacheTest.java File dev/core/test/com/google/gwt/dev/javac/PersistentUnitCacheTest.java (right):

[gwt-contrib] Re: Add media events for audio/video elements (issue1385804)

On 2011/03/30 19:06:49, fredsa wrote: The code review tool is being a little funny but LGTM for the change to DOMImplStandard.java http://gwt-code-reviews.appspot.com/1385804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Roll-back due to test breakage. (issue1396801)

On 2011/03/29 21:54:47, rchandia wrote: LGTM http://gwt-code-reviews.appspot.com/1396801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing HasDataPresenter#scheduleFinally to schedule the command in the argument, not the pending... (issue1391801)

On 2011/03/24 20:18:47, jlabanca wrote: LGTM but this bug means there's no test coverage of this functionality. Can you add it? http://gwt-code-reviews.appspot.com/1391801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing HasDataPresenter#scheduleFinally to schedule the command in the argument, not the pending... (issue1391801)

On 2011/03/24 20:18:47, jlabanca wrote: LGTM but this bug means there's no test coverage of this functionality. Can you add it? http://gwt-code-reviews.appspot.com/1391801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Cells should only fill a CellWidget if they render exactly one topmost element, or the first chi... (issue1385806)

On 2011/03/24 15:59:37, jlabanca wrote: LGTM, thanks for catching that tbroyer :) http://gwt-code-reviews.appspot.com/1385806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Update partial support elements for ie9. (issue1389802)

Reviewers: jlabanca, Description: Update partial support elements for ie9. Please review this at http://gwt-code-reviews.appspot.com/1389802/ Affected files: M user/src/com/google/gwt/canvas/Canvas.gwt.xml M user/src/com/google/gwt/media/Media.gwt.xml Index:

[gwt-contrib] Re: Adding a new TextButton widget to replace the existing Button widget. The new widget provides th... (issue1383806)

LGTM2 On 2011/03/23 18:07:02, rjrjr wrote: LGTM This is pretty exciting. On Wed, Mar 23, 2011 at 11:05 AM, mailto:jlaba...@google.com wrote: Moving the Default/Negative/Primary Decorations into DefaultAppearance makes the API much cleaner. First, I removed all of the static factory

[gwt-contrib] Re: Making rendered Cells in CellWidgets fill the root element of the widget so that setting the hei... (issue1383807)

On 2011/03/23 19:28:33, jlabanca wrote: LGTM if you add a test of the sizing changes for CellWidget http://gwt-code-reviews.appspot.com/1383807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding a new TextButton widget to replace the existing Button widget. The new widget provides th... (issue1383806)

A small review--larger one coming up tomorrow. http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/cell/client/ButtonCellBase.java File user/src/com/google/gwt/cell/client/ButtonCellBase.java (right):

[gwt-contrib] Re: Add media events for audio/video elements (issue1385804)

Per our discussion, an overhaul of the event system is required to get all the media events in, but I think these look good for now. I think the Error and LoadedData events would also be useful if you have the time. Lastly, could you add tests for these events? You may be blocked on the Audio

[gwt-contrib] Re: Add media events for audio/video elements (issue1385804)

LGTM http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/media/client/Audio.java File user/src/com/google/gwt/media/client/Audio.java (right): http://gwt-code-reviews.appspot.com/1385804/diff/1014/user/src/com/google/gwt/media/client/Audio.java#newcode93

[gwt-contrib] Re: Fix Javadoc for gesture/touch events (issue1383805)

On 2011/03/20 04:45:50, fredsa wrote: LGTM http://gwt-code-reviews.appspot.com/1383805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

http://gwt-code-reviews.appspot.com/1294801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

http://gwt-code-reviews.appspot.com/1294801/diff/17001/user/src/com/google/gwt/user/client/ui/Frame.java File user/src/com/google/gwt/user/client/ui/Frame.java (right): http://gwt-code-reviews.appspot.com/1294801/diff/17001/user/src/com/google/gwt/user/client/ui/Frame.java#newcode78

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

http://gwt-code-reviews.appspot.com/1294801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing touch scrolling support for devices that support it natively. Our current touch support o... (issue1369809)

I had reviewed this after all, but forgot to click send. D'oh! Sorry for the delay. http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/src/com/google/gwt/event/dom/DomEvent.gwt.xml File user/src/com/google/gwt/event/dom/DomEvent.gwt.xml (right):

[gwt-contrib] Re: Fixing touch scrolling support for devices that support it natively. Our current touch support o... (issue1369809)

/event/dom/DomEvent.gwt.xml#newcode3 user/src/com/google/gwt/event/dom/DomEvent.gwt.xml:3: inherits name=com.google.gwt.dom.DOM / On 2011/03/14 18:09:14, pdr wrote: Can you alphabetize these? Done. http://gwt-code-reviews.appspot.com/1369809/diff/4001/user/src/com/google/gwt/event/dom/client

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

http://gwt-code-reviews.appspot.com/1294801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing touch scrolling support for devices that support it natively. Our current touch support o... (issue1369809)

http://gwt-code-reviews.appspot.com/1369809/diff/1/user/src/com/google/gwt/touch/client/TouchScroller.java File user/src/com/google/gwt/touch/client/TouchScroller.java (right): http://gwt-code-reviews.appspot.com/1369809/diff/1/user/src/com/google/gwt/touch/client/TouchScroller.java#newcode173

[gwt-contrib] Re: Replacing the testng-5.14.1.jar with testng-5.14.1-nojunit.jar in the gwt-user .classpath file. ... (issue1377803)

On 2011/03/09 15:23:11, jlabanca wrote: LGTM http://gwt-code-reviews.appspot.com/1377803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding vertical padding to hborder.png in the new Clean style theme to handle large Buttons/Date... (issue1368808)

On 2011/03/09 15:55:18, jlabanca wrote: LGTM http://gwt-code-reviews.appspot.com/1368808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing ActionCell and ButtonCell clicks outside of the Button element are ignored. (issue1371810)

On 2011/03/07 16:43:50, jlabanca wrote: adapted from http://gwt-code-reviews.appspot.com/1183801/show LGTM http://gwt-code-reviews.appspot.com/1371810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

http://gwt-code-reviews.appspot.com/1374803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

http://gwt-code-reviews.appspot.com/1374803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

http://gwt-code-reviews.appspot.com/1374803/diff/7004/user/src/com/google/gwt/storage/client/Storage.java File user/src/com/google/gwt/storage/client/Storage.java (right): http://gwt-code-reviews.appspot.com/1374803/diff/7004/user/src/com/google/gwt/storage/client/Storage.java#newcode107

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

http://gwt-code-reviews.appspot.com/1374803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

http://gwt-code-reviews.appspot.com/1374803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

http://gwt-code-reviews.appspot.com/1374803/diff/20/user/src/com/google/gwt/storage/client/StorageImplNonNativeEvents.java File user/src/com/google/gwt/storage/client/StorageImplNonNativeEvents.java (right):

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

http://gwt-code-reviews.appspot.com/1374803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] HTML5 Storage API in GWT. (issue1374803)

Reviewers: jlabanca, Description: HTML5 Storage API in GWT. This change adds the HTML5 local and session storage APIs, and a Map interface backed by storage. This is a contribution from an external project, the gwt-mobile-webkit project, and is a copy of issue#1290802 with some additional

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

http://gwt-code-reviews.appspot.com/1374803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

http://gwt-code-reviews.appspot.com/1374803/diff/1/user/src/com/google/gwt/storage/client/StorageImpl.java File user/src/com/google/gwt/storage/client/StorageImpl.java (right): http://gwt-code-reviews.appspot.com/1374803/diff/1/user/src/com/google/gwt/storage/client/StorageImpl.java#newcode193

[gwt-contrib] Re: Adding touch scrolling support to ScrollPanel for mobile support. TouchScroller augments an exis... (issue1370801)

LGTM with nits http://gwt-code-reviews.appspot.com/1370801/diff/7001/user/src/com/google/gwt/touch/client/Momentum.java File user/src/com/google/gwt/touch/client/Momentum.java (right):

[gwt-contrib] Re: Fix bug for IE frames where onload events don't fire. (issue1353801)

Step-by-step how I was running the tests: 1) Open Eclipse and go to Run-Run Configurations 2) Select GWT JUnit Test on the left and click the new test icon. 3) Put anything for the name, but for the Project put gwt-user and for the Test Class put com.google.gwt.user.client.ui.ImageTest 4) Click

[gwt-contrib] Re: Fix bug for IE frames where onload events don't fire. (issue1353801)

During testing, I found this patch causes several timeout errors in ImageTest.java on IE8: testChangeImageToClipped() testCreateImage() testSetUrlAndVisiblerectOnUnclippedImage() testNoEventOnReattachInHandler() http://gwt-code-reviews.appspot.com/1353801/ --

[gwt-contrib] Re: Adding touch scrolling support to ScrollPanel for mobile support. TouchScroller augments an exis... (issue1370801)

http://gwt-code-reviews.appspot.com/1370801/diff/1016/user/src/com/google/gwt/touch/Touch.gwt.xml File user/src/com/google/gwt/touch/Touch.gwt.xml (right): http://gwt-code-reviews.appspot.com/1370801/diff/1016/user/src/com/google/gwt/touch/Touch.gwt.xml#newcode25

[gwt-contrib] Re: Adding new style theme called Clean, and using the new theme in Showcase and in the default GWT ... (issue1330801)

On 2011/02/25 16:51:09, jlabanca wrote: LGTM http://gwt-code-reviews.appspot.com/1330801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix a codegen bug for use of {0,localtime,predef:FOO} (issue1373801)

On 2011/02/28 19:42:53, jat wrote: LGTM http://gwt-code-reviews.appspot.com/1373801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fix bug for IE frames where onload events don't fire. (issue1353801)

Thank you for the patch! LGTM with a few nits. Lets get this into 2.3 and end this travesty of broken onload events forever :) http://gwt-code-reviews.appspot.com/1353801/diff/1/user/src/com/google/gwt/user/client/ui/Frame.java File user/src/com/google/gwt/user/client/ui/Frame.java (right):

[gwt-contrib] Re: Eclipse autoformatter update: allow assignments to wrap. (issue1354803)

On 2011/02/11 18:51:18, zundel wrote: Well, I personally like the way it looks: this.myPackage = StringInterner.get().intern( (myPackage.length() == 0) ? : (myPackage + '.')); becomes: this.myPackage = StringInterner.get().intern( (myPackage.length() == 0) ?

[gwt-contrib] Fixing a bug in DeckLayoutPanel where animating the current widget causes the current widget to ... (issue1354801)

LGTM http://gwt-code-reviews.appspot.com/1354801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding a LoadingStateEvent to CellList and CellTable so users can receive an event when the data... (issue1338809)

On 2011/02/07 23:45:33, jlabanca wrote: LGTM http://gwt-code-reviews.appspot.com/1338809/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Update getGeckoVersion() to support beta versions of Firefox. (issue1343803)

Reviewers: jlabanca, Description: Update getGeckoVersion() to support beta versions of Firefox. Previously, gecko versions of the form 2.0b10 would cause the regex to get mad because it is missing a second period. This change updates the gecko version detector to support gecko versions such as

[gwt-contrib] Remove unnecessary script src=... from MediaTest.gwt.xml to avoid virus scanner false positives (issue1341801)

Reviewers: rice, Description: Remove unnecessary script src=... from MediaTest.gwt.xml to avoid virus scanner false positives A user reported that Sophos antivirus was flagging MediaTest.gwt.xml (see: http://savmac7-20.p.link.sophos.com/t/en/Mal/Badsrc-D). The script src=... line isn't

[gwt-contrib] Re: Setting the line-height of the splitter in Vertical/HorizontalSplitPanel to 0px so the font size... (issue1335801)

On 2011/01/28 14:53:05, jlabanca wrote: LGTM http://gwt-code-reviews.appspot.com/1335801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding new style theme called Clean, and using the new theme in Showcase and in the default GWT ... (issue1330801)

Few nits about the styles: button image is off by 1px in showcase button example, and a few blue border elements remain. http://gwt-code-reviews.appspot.com/1330801/diff/1/8 File user/src/com/google/gwt/user/theme/chrome/public/gwt/chrome/chrome.css (right):

[gwt-contrib] Initial version of HTML5 Audio and Video (issue1318803)

Reviewers: rice, jlabanca, Description: Initial version of HTML5 Audio and Video Original patch by rice, updated by pdr. Please review this at http://gwt-code-reviews.appspot.com/1318803/show Affected files: A user/src/com/google/gwt/dom/client/AudioElement.java M user/src/com/google/gwt

[gwt-contrib] Remove experimental warning from Canvas and clean up javadoc. (issue1286802)

Reviewers: rjrjr, Description: Remove experimental warning from Canvas and clean up javadoc. Please review this at http://gwt-code-reviews.appspot.com/1286802/show Affected files: M user/src/com/google/gwt/canvas/client/Canvas.java M

[gwt-contrib] Re: Adding a new widget ResizeLayoutPanel that can trigger a resize event when it changes size. The ... (issue1301801)

http://gwt-code-reviews.appspot.com/1301801/diff/1/4 File user/src/com/google/gwt/user/client/ui/HeaderPanel.java (right): http://gwt-code-reviews.appspot.com/1301801/diff/1/4#newcode37 user/src/com/google/gwt/user/client/ui/HeaderPanel.java:37: Rendering bug: vertical scrollbars will be hidden

[gwt-contrib] Re: Adding a new widget ResizeLayoutPanel that can trigger a resize event when it changes size. The ... (issue1301801)

LGTM http://gwt-code-reviews.appspot.com/1301801/diff/5001/6001 File user/src/com/google/gwt/user/ResizeLayoutPanel.gwt.xml (right): http://gwt-code-reviews.appspot.com/1301801/diff/5001/6001#newcode23 user/src/com/google/gwt/user/ResizeLayoutPanel.gwt.xml:23: !-- Most browsers do not support

[gwt-contrib] Re: Improve canvas for browsers (and permutations) with partial canvas support. (issue1296801)

http://gwt-code-reviews.appspot.com/1296801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Improve canvas for browsers (and permutations) with partial canvas support. (issue1296801)

http://gwt-code-reviews.appspot.com/1296801/diff/28001/29002 File user/src/com/google/gwt/canvas/client/Canvas.java (right): http://gwt-code-reviews.appspot.com/1296801/diff/28001/29002#newcode64 user/src/com/google/gwt/canvas/client/Canvas.java:64: CanvasElementSupportDetector.class); On

[gwt-contrib] Re: Improve canvas for browsers (and permutations) with partial canvas support. (issue1296801)

http://gwt-code-reviews.appspot.com/1296801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing HasWidgetsTester#testAll to actually call testDoDetachChildrenWithError. Currently, it c... (issue1300801)

On 2011/01/18 14:46:40, jlabanca wrote: LGTM http://gwt-code-reviews.appspot.com/1300801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Improve canvas for browsers (and permutations) with partial canvas support. (issue1296801)

http://gwt-code-reviews.appspot.com/1296801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Improve canvas for browsers (and permutations) with partial canvas support. (issue1296801)

http://gwt-code-reviews.appspot.com/1296801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Improve canvas for browsers (and permutations) with partial canvas support. (issue1296801)

http://gwt-code-reviews.appspot.com/1296801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Improve canvas for browsers (and permutations) with partial canvas support. (issue1296801)

http://gwt-code-reviews.appspot.com/1296801/diff/7001/8002 File user/src/com/google/gwt/canvas/client/Canvas.java (right): http://gwt-code-reviews.appspot.com/1296801/diff/7001/8002#newcode42 user/src/com/google/gwt/canvas/client/Canvas.java:42: public static Canvas createCanvasIfSupported() {

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

http://gwt-code-reviews.appspot.com/1294801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

http://gwt-code-reviews.appspot.com/1294801/diff/3001/4002 File user/test/com/google/gwt/dom/client/FrameTests.java (right): http://gwt-code-reviews.appspot.com/1294801/diff/3001/4002#newcode49 user/test/com/google/gwt/dom/client/FrameTests.java:49: final Timer timer = new Timer() { On

[gwt-contrib] Re: Improve canvas for browsers (and permutations) with partial canvas support. (issue1296801)

http://gwt-code-reviews.appspot.com/1296801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Improve canvas for browsers (and permutations) with partial canvas support. (issue1296801)

http://gwt-code-reviews.appspot.com/1296801/diff/21001/22002 File user/src/com/google/gwt/canvas/client/Canvas.java (right): http://gwt-code-reviews.appspot.com/1296801/diff/21001/22002#newcode61 user/src/com/google/gwt/canvas/client/Canvas.java:61: public static final boolean isSupported() {

[gwt-contrib] Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

Reviewers: jlabanca, rjrjr, Description: Fix bug on IE where onload events don't fire for IFrames. This is a bugfix for http://code.google.com/p/google-web-toolkit/issues/detail?id=1720 Please review this at http://gwt-code-reviews.appspot.com/1294801/show Affected files: M

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

http://gwt-code-reviews.appspot.com/1294801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Improve canvas for browsers (and permutations) with partial canvas support. (issue1296801)

Reviewers: jlabanca, rice, Description: Improve canvas for browsers (and permutations) with partial canvas support. Please review this at http://gwt-code-reviews.appspot.com/1296801/show Affected files: M user/src/com/google/gwt/canvas/client/Canvas.java M

[gwt-contrib] Tone down the experimental api warning. (issue1285801)

Reviewers: rjrjr, Description: Tone down the experimental api warning. Please review this at http://gwt-code-reviews.appspot.com/1285801/show Affected files: M user/src/com/google/gwt/canvas/client/Canvas.java M user/src/com/google/gwt/canvas/dom/client/CanvasGradient.java M

[gwt-contrib] Re: Initial version of HTML5 Audio and Video (issue1195801)

LGTM http://gwt-code-reviews.appspot.com/1195801/diff/19002/32018 File user/test/com/google/gwt/media/MediaTest.gwt.xml (right): http://gwt-code-reviews.appspot.com/1195801/diff/19002/32018#newcode24 user/test/com/google/gwt/media/MediaTest.gwt.xml:24: script src=testh264.mp4/script Does

  1   2   3   >