Re: [PHP-DEV] P++: FAQ

2019-08-12 Thread Andrey Hristov
On 12.08.19 г. 12:06 ч., Benjamin Eberlei wrote: On Sun, Aug 11, 2019 at 6:32 AM Andi Gutmans wrote: I must admit that the first time I read Zeev’s email I got anxious... but it is frustrating that PHP has a WAY better runtime than Python and most other dynamic languages yet is falling out of

Re: [PHP-DEV] Object Type Casting Reloaded

2019-04-23 Thread Andrey Hristov
Hi, On 23.04.19 г. 13:44 ч., azjezz wrote: Hello Dan, I don' think this a problem relating to just one use case, some PHP builtin functions have weird union return types, where static analysis tools would warn you about the return type being `string|bool`, when you are expecting `string`.

Re: [PHP-DEV] Object Type Casting Reloaded

2019-04-23 Thread Andrey Hristov
Hi, maybe with short closures this will be pretty easy to implement by injecting a short closure that expects the return type to be of the type to be casted and to return it. Something in the like of : $service = (fn(EmailService $s):EmailService => $s

Re: [PHP-DEV] RFC Draft: Comprehensions

2019-03-12 Thread Andrey Hristov
Hi, the real fun starts when people start to put list comprehension in a list comprehension in a list comprehension. And the result is one-liners that are pretty dense and write once never read. The problem during software development are not the key strokes, it's the time which later has to

Re: [PHP-DEV] [RFC] JIT

2019-02-03 Thread Andrey Hristov
Guys, On 3.02.19 г. 18:16 ч., Zeev Suraski wrote: On 3 Feb 2019, at 16:43, Jan Ehrhardt wrote: Zeev Suraski in php.internals (Sun, 3 Feb 2019 11:02:56 +): How is that related? It is directly related with your statement that "developers with other host OSs still use Linux for the

Re: [PHP-DEV] RFC: RFC Workflow & Voting (2019 update)

2019-02-02 Thread Andrey Hristov
On 2.02.19 г. 3:41 ч., Johannes Schlüter wrote: On Do, 2019-01-31 at 14:28 -0500, Bishop Bettini wrote:    2. Core developers are defined as the top 13 committers within the    period of two years since voting began. A core developer is a de facto    community member, but caucuses as a core

Re: [PHP-DEV] [RFC] JIT

2019-02-01 Thread Andrey Hristov
Pierre, On 1.02.19 г. 13:12 ч., Pierre Joye wrote: On Thu, Jan 31, 2019, 11:39 PM Dmitry Stogov I don't see any problems with including JIT without Windows support. Windows runs PHP much slower any way. How so? I tend to disagree here. Except if recent changes affect Windows indirectly

Re: [PHP-DEV] [RFC] JIT

2019-02-01 Thread Andrey Hristov
Hi, On 31.01.19 г. 18:47 ч., Kalle Sommer Nielsen wrote: Den tor. 31. jan. 2019 kl. 18.39 skrev Dmitry Stogov : On 1/31/19 7:01 PM, Nikita Popov wrote: On Thu, Jan 31, 2019 at 10:44 AM Dmitry Stogov mailto:dmi...@zend.com>> wrote: Hi Internals, I'm glad to finally propose

[PHP-DEV] Re: Help with mysqlnd bug?

2016-09-21 Thread Andrey Hristov
Hi Richard, On 21.09.2016 19:39, Fleshgrinder wrote: On 9/21/2016 8:42 AM, Andrey Hristov wrote: Hi Richard, On 20.09.2016 21:02, Fleshgrinder wrote: Hi Andrey! I am writing you because you are the last person with actual commits in the mysqlnd extension. I would like to ask if you could

Re: [PHP-DEV] PR #1723 - fix for crash in mysqli_connect

2016-01-13 Thread Andrey Hristov
Hi, the patch looks ok. Sorry that I borked this. Will push it in a short! Thanks, Andrey On 13.01.2016 14:37, John Bafford wrote: Hi all, Can someone take a look at this PR to fix a crash with mysqli_connect arising with a mysqlnd refactor in e81ecc80c in master from November:

Re: [PHP-DEV] PHP 7.0.0 final RTM delay

2015-12-03 Thread Andrey Hristov
Hi, guys, just go out and say to the public, that due to Openssl security fixes which are awaited and thus because we want to ensure that 7.0.0. will be correctly working with it, we won't release 7.0.0 even as source until we are sure the QA procedure is gone. PHP can get really good

[PHP-DEV] Re: [PATCH] Tick functions (on C level) with state

2015-04-07 Thread Andrey Hristov
this helps to enlighten my intentions. Best, Andrey Thanks. Dmitry. On Tue, Apr 7, 2015 at 4:43 PM, Andrey Hristov p...@hristov.com mailto:p...@hristov.com wrote: Hi, I would like to hear comments about a small change to the low-level tick functionality (main/php_ticks.c) to add

[PHP-DEV] [PATCH] Tick functions (on C level) with state

2015-04-07 Thread Andrey Hristov
Hi, I would like to hear comments about a small change to the low-level tick functionality (main/php_ticks.c) to add state to when calling a C tick function The patch is alive at : http://pastebin.com/0zhVNxaY Currently a C tick function gets as a parameter just the number of ticks, and

Re: [PHP-DEV] Re: HTTP/2 and Websocket support in 7.x versions

2015-03-31 Thread Andrey Hristov
Hi, On 31.03.2015 17:40, Daniel Lowrey wrote: On Tue, Mar 31, 2015 at 10:11 AM Grégory Planchat greg...@luni.fr wrote: Le 31/03/2015 15:56, Daniel Lowrey a écrit : HTTP/2 is entirely outside the scope of the PHP web SAPI as it currently exists. The protocol impacts the actual HTTP server and

Re: [PHP-DEV] Re: HTTP/2 and Websocket support in 7.x versions

2015-03-31 Thread Andrey Hristov
On 31.03.2015 18:26, Rowan Collins wrote: Andrey Hristov wrote on 31/03/2015 16:02: Currently in MT environment the task of data separation is pushed to the TSRM by using TLS. Now, if TSRM is reimplemented in a fashion that the data is not stored by using TLS but other mechanism and cooperative

Re: [PHP-DEV] Re: HTTP/2 and Websocket support in 7.x versions

2015-03-31 Thread Andrey Hristov
On 1.04.2015 00:31, Rowan Collins wrote: On 31 March 2015 21:23:56 GMT+01:00, Andrey Hristov p...@hristov.com wrote: So, if Zend can be optimized to quickly clean the execution environment, and easily switch between them, we can have a giant leap towards concurrent non-blockable PHP. The idea

Re: [PHP-DEV] Voting irregularities

2015-03-16 Thread Andrey Hristov
On 16.03.2015 01:08, Jordi Boggiano wrote: On 15/03/2015 22:27, Derick Rethans wrote: On Sun, 15 Mar 2015, Zeev Suraski wrote: I don't think it's going to far, if you have people with no clue writing this: https://plus.google.com/+KristianK%C3%B6hntopp/posts/ijoDNH2M8mB Do you know who

Re: [PHP-DEV] Deprecate array()

2015-03-03 Thread Andrey Hristov
On 3.03.2015 19:10, Adrian Parker wrote: Seeing it makes me vomit, IMHO. Great introduction! This is just a proposal, I know next to nothing about core PHP development. https://www.simonholywell.com/post/2010/09/15-excellent-resources-for-php-extension-development.html Enjoy!

Re: [PHP-DEV] [RFC] Argument unpacking

2013-08-30 Thread Andrey Hristov
On 08/30/2013 05:23 PM, Nikita Popov wrote: Hi internals! This RFC proposes to add a syntax for argument unpacking: https://wiki.php.net/rfc/argument_unpacking Basically, this is the complement of the variadics RFC: It is not about declaring variadic functions, but about calling them.

Re: [PHP-DEV] Segfault on mysqlnd stream cast

2013-08-05 Thread Andrey Hristov
Hi Rasmus, On 08/03/2013 07:51 PM, Rasmus Lerdorf wrote: Hey Johannes, could you take a look at: https://gist.github.com/anonymous/6143477 You can reproduce in 5.5 with: sapi/cli/php ext/mysqli/tests/mysqli_poll_kill.php main/streams/cast.c:306 is: if (php_stream_is_filtered(stream)) {

Re: [PHP-DEV] [PATCH] Constification of some PHP API calls

2013-07-31 Thread Andrey Hristov
if not... I just like that web view. :) I have already done that : https://github.com/andreyhristov/php-src I have filled a pull request too. Best, Andrey On Mon, Jul 29, 2013 at 3:01 AM, Andrey Hristov p...@hristov.com mailto:p...@hristov.com wrote: Hi, after experiencing again warnings

Re: [PHP-DEV] [PATCH] Constification of some PHP API calls

2013-07-31 Thread Andrey Hristov
On 07/31/2013 04:56 PM, Sara Golemon wrote: Ah, yeah, I can see that clearly now. Looks universally cool to me. Do you just need someone with engine karma to push it? right. I have no Zend karma, or at least didn't have at CVS/SVN times. On Wed, Jul 31, 2013 at 1:35 AM, Andrey Hristov p

Re: [PHP-DEV] Re: About to end 5.3

2013-06-20 Thread Andrey Hristov
On 06/19/2013 10:08 PM, David Soria Parra wrote: On 2013-06-19, Johannes Schlüter johan...@php.net wrote: Good bye 5.3, you were a great step for PHP! Looking forward to a bright and open future! Thank you for taking care of this branch for so long. Keep the good job up. ditto! Andrey --

Re: [PHP-DEV] 5.NEXT Integer and String type modifications

2013-06-01 Thread Andrey Hristov
Hi, On 05/31/2013 10:03 PM, Anthony Ferrara wrote: Derick, In principle I think this is great thing to do. Not having a 64 bit type is annoying. I'm a bit curious on how this is going to work with all sorts of object wrappers that are now in place as workaround. And casting int64 to int32

Re: [PHP-DEV] idea: add wrapper support to mysqli_connect

2013-03-14 Thread Andrey Hristov
Hi, On 03/13/2013 10:09 PM, Thomas Anderson wrote: On Wed, Mar 13, 2013 at 3:37 PM, Rasmus Lerdorf ras...@lerdorf.com wrote: On 03/13/2013 12:08 PM, Thomas Anderson wrote: Instead of passing localhost to mysqli_connect as the $host parameter I think it'd be useful if you could pass something

Re: [PHP-DEV] RFC mysqlnd.localhost_override

2013-02-12 Thread Andrey Hristov
Hi, On 02/12/2013 12:51 PM, Asbjørn Sannes wrote: https://wiki.php.net/rfc/mysqlnd_localhost_override I propose we introduce a new option called mysqlnd.localhost_override which enables a system administrator or php distributor to configure how localhost should be overridden. I am

Re: [PHP-DEV] shared mysqlnd extension ...

2012-08-20 Thread Andrey Hristov
On 08/20/2012 11:52 PM, Lester Caine wrote: Having now got mysql running on the PHP5.4.3 machine, I'm trying to compile mysqlnd and mysqli as extensions to load and unload as required. php_mysqlnd_config.h no longer exists, but why is the config file named config9.m4 rather than config.m4? What

Re: [PHP-DEV] Expose mysqlnd API through all MySQL extensions

2012-04-24 Thread Andrey Hristov
Hi, On 04/24/2012 03:32 PM, jpauli wrote: On Tue, Apr 24, 2012 at 2:34 PM, Ulf Wendelulf.wen...@oracle.com wrote: Am 24.04.2012 14:27, schrieb jpauli: I understand your thoughts, but I disagree as I think it would be much more clean to expose it via mysqlnd_***() API than through each MySQL

Re: [PHP-DEV] [Windows] Error Building PHP 5.4 NTS Debug Version, mysqlnd

2012-01-22 Thread Andrey Hristov
Hi Pierre, On 01/22/2012 12:37 PM, Pierre Joye wrote: hi, Can reproduce it now, can you open a bug please and assign it to mysql? The problem is due to TSRMLS_FETCH being called at the wrong place. I'm not sure how they want it but ideally it should in the DBG macro already. called at the

Re: [PHP-DEV] Cast trap with INI entries compiling C++ extension

2011-09-29 Thread Andrey Hristov
On 09/29/2011 07:13 PM, Ángel González wrote: On 29/09/11 17:42, Olivier Favre wrote: I checked with a tiny test program, you're right about GCC complaining. The right fix is to make the field const (I don't know about const keyword). G++ won't give warnings, no error would be triggered by a

Re: [SPAM?]: Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-07 Thread Andrey Hristov
Hi, On 09/07/2011 07:17 AM, Tomas Kuliavas wrote: 2011.09.06 23:20 Ulf Wendel rašė: Am 06.09.2011 21:33, schrieb Stas Malyshev: Hi! Any new PHP major release is about setting new directions. I, Andrey and Johannes, the guys maintaining ext/*mysql* recommend going mysqlnd after an

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Andrey Hristov
On 09/06/2011 10:45 AM, Stas Malyshev wrote: Hi! On 9/6/11 1:24 AM, Andrey Hristov wrote: no, it's about consistency, which you want. mysqlnd should behave like libmysql, and it is a test that can test it. What libmysql returns in filtered in mysqli, mysqli_num_rows() is a direct wrapper

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Andrey Hristov
On 09/06/2011 11:16 AM, Stas Malyshev wrote: Hi! Have you actually checked what libmysql returns??!? If _you_ just have tried to do it, you might actually find that libmysql does what mysqlnd did long ago, but mysqli was hiding it. Here is output from what libmysql does, after removing the

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Andrey Hristov
Stas, On 09/06/2011 06:55 PM, Stas Malyshev wrote: Hi! On 9/6/11 2:46 AM, Andrey Hristov wrote: I've looked into mysqli_result_is_unbuffered_and_not_everything_is_fetched() and it looks like for libmysql it checks this: (((r)-handle (r)-handle-status == MYSQL_STATUS_USE_RESULT) || ((r)-data

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Andrey Hristov
On 09/06/2011 09:08 PM, Stas Malyshev wrote: Hi! On 9/6/11 11:05 AM, Andrey Hristov wrote: I've looked into mysqli_result_is_unbuffered_and_not_everything_is_fetched() and it looks like for libmysql it checks this: (((r)-handle (r)-handle-status == MYSQL_STATUS_USE_RESULT) || ((r)-data == NULL

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Andrey Hristov
On 09/06/2011 09:54 PM, Andrey Hristov wrote: On 09/06/2011 09:08 PM, Stas Malyshev wrote: Hi! On 9/6/11 11:05 AM, Andrey Hristov wrote: I've looked into mysqli_result_is_unbuffered_and_not_everything_is_fetched() and it looks like for libmysql it checks this: (((r)-handle (r)-handle-status

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-05 Thread Andrey Hristov
Hi Stas, On 09/02/2011 10:44 PM, Stas Malyshev wrote: Hi! On 9/2/11 1:41 PM, Ferenc Kovacs wrote: I think you missed the referenced [1]: [1] Yes, we will still allow building with libmysql and we will fix bugs reported there and we will verify it works but focus on mysqlnd, as we're actually

Re: [PHP-DEV] mysqli tests breaking

2011-09-05 Thread Andrey Hristov
On 09/05/2011 03:19 PM, Ulf Wendel wrote: No mysqlnd-libmysql BC break here. Metadata and libmysql - there's hardly a better example why mysqlnd should be set as a default. With libmysql as a default, PHP 5.4 will have a randomly crashing default configuration.

Re: [PHP-DEV] mysqli tests breaking

2011-09-05 Thread Andrey Hristov
Hi, On 09/05/2011 04:53 PM, Ulf Wendel wrote: This is the one and only mysqlnd-libmysql difference of some practical relevance. I consider it at least questionable if libmysql is correct. If it was to be decided that mysqlnd is wrong, it is probably like five lines of code in mysqlnd to

[PHP-DEV] Re: [BC]mysql_pconnect generate warning when link against mysqlnd

2011-08-24 Thread Andrey Hristov
Hi, in my opinion a warning in this case is better than no warning. Because this shows a problem and even if display_warnings is off the warnings can be logged for further inspection. Best, Andrey On 08/24/2011 09:35 AM, Laruence wrote: And the same warnings will be throw while call

Re: [PHP-DEV] 5.3.7 is breaking SSL

2011-08-24 Thread Andrey Hristov
Hi, it's pretty simple, once you have a MySQL server running with enabled SSL. You can use the following three files to set your MySQL http://hristov.com/mysql_certs/server-key.pem http://hristov.com/mysql_certs/server-cert.pem http://hristov.com/mysql_certs/cacert.pem [mysqld]

Re: [PHP-DEV] [PATCH]mysql_pconnect leaks file descriptors on reconnect

2011-08-22 Thread Andrey Hristov
Hi, On 08/22/2011 10:40 AM, Laruence wrote: georg, andery, ulf: hello, there is a bug in mysqlnd, the details about this bug can be found at https://bugs.php.net/bug.php?id=55473 I found the reason is that mysqlnd_connect didn't free the stream when doing reconnect. I have

Re: [PHP-DEV] [PATCH]mysql_pconnect leaks file descriptors on reconnect

2011-08-22 Thread Andrey Hristov
Hi, I have a fix, currently running the full test suite. Will commit soon. Best, Andrey On 08/22/2011 11:56 AM, Pierre Joye wrote: it is attached to the bug :) On Mon, Aug 22, 2011 at 11:47 AM, Andrey Hristovp...@hristov.com wrote: Hi, On 08/22/2011 10:40 AM, Laruence wrote: georg,

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/date/php_date.c trunk/ext/date/php_date.c

2011-01-25 Thread Andrey Hristov
Pierre, On 01/25/2011 04:07 PM, Pierre Joye wrote: On Tue, Jan 25, 2011 at 4:04 PM, Derick Rethans der...@php.net wrote: On Tue, 25 Jan 2011, Pierre Joye wrote: Also doing so (testing a == NULL instead of !a) is a common and widely adopted practice Really? I've never written code like

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/date/php_date.c trunk/ext/date/php_date.c

2011-01-25 Thread Andrey Hristov
On 01/25/2011 06:37 PM, Pierre Joye wrote: On Tue, Jan 25, 2011 at 6:03 PM, Andrey Hristov p...@hristov.com wrote: the first thing to do is to contact the extension maintainer, whoever this is. We have karma system and people with php-src access, however it is good first to contact

Re: [PHP-DEV] Deprecating global + $GLOBALS, making $_REQUEST, $_GET, $_POST read-only

2010-12-09 Thread Andrey Hristov
and $GLOBALS? In short I like it but I'm not sure how it would ever get implemented without breaking stuff... (this is where the clever core developers can propose some easy method I can't think of right now) INI variable, like register_globals -Original Message- From: Andrey Hristov

Re: [PHP-DEV] Deprecating global + $GLOBALS, making $_REQUEST, $_GET, $_POST read-only

2010-12-09 Thread Andrey Hristov
James Butler wrote: -Original Message- From: Andrey Hristov [mailto:p...@hristov.com] James Butler wrote: +1 million because GLOBAL scope is horrid (generally) and is thoroughly abused -1 million because it will be the most horrific BC break since time began and I imagine

Re: [PHP-DEV] Deprecating global + $GLOBALS, making $_REQUEST, $_GET, $_POST read-only

2010-12-09 Thread Andrey Hristov
Michael Shadle wrote: On Thu, Dec 9, 2010 at 2:38 AM, Andrey Hristov p...@hristov.com wrote: Yes, as the documentation will mention how to do it, for old applications. For new apps it is easy - pass all the information you need as parameter to the function. It works in other languages, why

Re: [PHP-DEV] Deprecating global + $GLOBALS, making $_REQUEST, $_GET, $_POST read-only

2010-12-09 Thread Andrey Hristov
Eloy Bote Falcon wrote: 2010/12/9 Andrey Hristov p...@hristov.com Reindl Harald wrote: Please do not global + GLOBALS can be used in so many ways and you would break 200.000 LOC only here which is running with reporting E_STRICT in a production environment what happened after

Re: [PHP-DEV] Deprecating global + $GLOBALS, making $_REQUEST, $_GET, $_POST read-only

2010-12-09 Thread Andrey Hristov
Derick Rethans wrote: On Thu, 9 Dec 2010, Andrey Hristov wrote: the topic says most of it. What do you think about deprecating the global keyword and $GLOBALS with it? Together with this making $_REQUEST, $_GET and $_POST read-only as they should be used only to read-only anyway. No thanks

Re: [PHP-DEV] Deprecating global + $GLOBALS, making $_REQUEST, $_GET, $_POST read-only

2010-12-09 Thread Andrey Hristov
Alain Williams wrote: On Thu, Dec 09, 2010 at 11:53:08AM +0100, Andrey Hristov wrote: Is copying the POST variables into another variables best practice (like a manual register_globals)? In the global scope of the application I think it's cleaner to work with $_POST to overwrite the values

Re: [PHP-DEV] Deprecating global + $GLOBALS, making $_REQUEST, $_GET, $_POST read-only

2010-12-09 Thread Andrey Hristov
Ferenc Kovacs wrote: On Thu, Dec 9, 2010 at 11:14 AM, Andrey Hristov p...@hristov.com mailto:p...@hristov.com wrote: Â Hi guys, the topic says most of it. What do you think about deprecating the global keyword and $GLOBALS with it? Together with this making $_REQUEST, $_GET

Re: [PHP-DEV] Deprecating global + $GLOBALS, making $_REQUEST, $_GET, $_POST read-only

2010-12-09 Thread Andrey Hristov
Adam Harvey wrote: On 9 December 2010 18:14, Andrey Hristov p...@hristov.com wrote: the topic says most of it. What do you think about deprecating the global keyword and $GLOBALS with it? Together with this making $_REQUEST, $_GET and $_POST read-only as they should be used only to read-only

Re: [PHP-DEV] Deprecating global + $GLOBALS, making $_REQUEST, $_GET, $_POST read-only

2010-12-09 Thread Andrey Hristov
Ángel González wrote: Andrey Hristov wrote: I am not against global variables, I'm against usage of $GLOBALS and global. So how do you support global variables by banning the two ways they can be accessed? very easy, by using them by name. Global variables are those outside of a classes

Re: [PHP-DEV] Deprecating global + $GLOBALS, making $_REQUEST, $_GET, $_POST read-only

2010-12-09 Thread Andrey Hristov
Reindl Harald wrote: Am 09.12.2010 13:46, schrieb Andrey Hristov: There were many apps which relied on register_globals but register_globals was introduced. There were many apps which relied on references in PHP4, but the object model changed in 5, references too. There are apps which rely

Re: [PHP-DEV] Deprecating global + $GLOBALS, making $_REQUEST, $_GET, $_POST read-only

2010-12-09 Thread Andrey Hristov
Reindl Harald wrote: Am 09.12.2010 17:19, schrieb Andrey Hristov: one day you might have to support globalized applications and I am sure you will feel very enlightened to fix them :) This is my problem and not yours sure, one's thrash is another mans cash. There are thousands of scripts

Re: [PHP-DEV] Deprecating global + $GLOBALS, making $_REQUEST, $_GET, $_POST read-only

2010-12-09 Thread Andrey Hristov
Ferenc Kovacs wrote: On Thu, Dec 9, 2010 at 5:19 PM, Andrey Hristov p...@hristov.com mailto:p...@hristov.com wrote: Reindl Harald wrote: Am 09.12.2010 13:46, schrieb Andrey Hristov: There were many apps which relied on register_globals

Re: [PHP-DEV] Deprecating global + $GLOBALS, making $_REQUEST, $_GET, $_POST read-only

2010-12-09 Thread Andrey Hristov
Alain Williams wrote: On Thu, Dec 09, 2010 at 05:40:09PM +0100, Reindl Harald wrote: Am 09.12.2010 17:19, schrieb Andrey Hristov: one day you might have to support globalized applications and I am sure you will feel very enlightened to fix them :) This is my problem and not yours

Re: [PHP-DEV] Deprecating global + $GLOBALS, making $_REQUEST, $_GET, $_POST read-only

2010-12-09 Thread Andrey Hristov
Reindl Harald wrote: Am 09.12.2010 17:49, schrieb Andrey Hristov: sure, one's thrash is another mans cash. Stop this dumb style I have been paid quite well for fixing other man's thrash because it just did not work. Thus, one's thrash is another man's cash. But do we want this a normal

Re: [PHP-DEV] Deprecating global + $GLOBALS, making $_REQUEST, $_GET, $_POST read-only

2010-12-09 Thread Andrey Hristov
Pierre Joye wrote: On Thu, Dec 9, 2010 at 5:55 PM, Andrey Hristov p...@hristov.com wrote: If all your functions take 15 params I am worried that your program design is flawed, sorry. That's not an argument to do it. PHP and all other languages have many ways to shoot yourself in the knees

Re: [PHP-DEV] Deprecating global + $GLOBALS, making $_REQUEST, $_GET, $_POST read-only

2010-12-09 Thread Andrey Hristov
Ángel González wrote: Andrey Hristov wrote: Ángel González wrote: So how do you support global variables by banning the two ways they can be accessed? very easy, by using them by name. Global variables are those outside of a classes, methods and functions. If they can only be used outside

Re: [PHP-DEV] Deprecating global + $GLOBALS, making $_REQUEST, $_GET, $_POST read-only

2010-12-09 Thread Andrey Hristov
Hi Lester, Lester Caine wrote: Andrey Hristov wrote: You probably got me wrong. The code will be broken and can be fixed. It's not like going line by line and checking whether everything will work. I'm tired of explaining this. SO you are happy to do all that work for us for free? Only

[PHP-DEV] C++ comments in Zend

2010-11-30 Thread Andrey Hristov
Zend/zend_compile.h:508:1: warning: C++ style comments are not allowed in ISO C90 Zend/zend_compile.h:508:1: warning: (this will be reported only once per input file) Lines 508 and 509 Someone with Zend karma, please, fix this. Compiled in trunk. Thanks, Andrey -- PHP Internals - PHP

Re: [PHP-DEV] Remove sqlite2 from trunk

2010-06-16 Thread Andrey Hristov
Kalle, Kalle Sommer Nielsen wrote: 2010/6/15 Ilia Alshanetsky i...@prohost.org: There is way too much code that uses ext/mysql and ext/mysql does not depend on a legacy library, I don't think we can remove it. As far as mssql, it is the one way to talk to Microsoft SQL from *nix systems, until

[PHP-DEV] Bug #51647 Certificate file without private key (pk in another file) doesn't work

2010-04-23 Thread Andrey Hristov
Pierre, if you don't like the patch I have committed to openssl to fix the problem you can revert it, but only if you can provide a better one. The test case is ext/mysqli/tests/bug51647.phpt You need to start the MySQL server with the following options : ssl-ca=/path/to/cacert.pem

Re: [PHP-DEV] Bug #51647 Certificate file without private key (pk in another file) doesn't work

2010-04-23 Thread Andrey Hristov
latest patch, but only when you have a better patch. Otherwise, even possibly imperfect, my patch does the job and passes the relevant tests. Cheers, On Fri, Apr 23, 2010 at 4:53 PM, Andrey Hristov p...@hristov.com wrote: Pierre, if you don't like the patch I have committed to openssl to fix

Re: [PHP-DEV] Where are we ACTUALLY on Unicode?

2010-03-16 Thread Andrey Hristov
dreamcat four wrote: On Tue, Mar 16, 2010 at 8:30 AM, Lester Caine les...@lsces.co.uk wrote: '3' is not a very processor friendly number, so working with 4 even though wasteful on memory, does make perfect sense. How long is it since we had a 640k limit on working memory? SERVERS should have a

Re: [PHP-DEV] Where are we ACTUALLY on Unicode?

2010-03-16 Thread Andrey Hristov
dreamcat four wrote: On Tue, Mar 16, 2010 at 11:48 AM, dreamcat four dreamc...@gmail.com wrote: On Tue, Mar 16, 2010 at 8:30 AM, Lester Caine les...@lsces.co.uk wrote: '3' is not a very processor friendly number, so working with 4 even though wasteful on memory, does make perfect sense. How

Re: [PHP-DEV] About optimization

2010-01-14 Thread Andrey Hristov
Rasmus Lerdorf wrote: Tim Starling wrote: ?php class C { var $v1, $v2, $v3, $v4, $v5, $v6, $v7, $v8, $v9, $v10; } $m = memory_get_usage(); $a = array(); for ( $i = 0; $i 1; $i++ ) { $a[] = new C; } print ((memory_get_usage() - $m) / 1) . \n; ? 1927 bytes (I'll use 64-bit from

Re: [PHP-DEV] [PATCH] Attempt to include ext/mysqlnd/mysqlnd_portability.h when building MySQLi against libmysql

2010-01-11 Thread Andrey Hristov
Hi Jess, does it compile after that, because I guess it doesn't. We use some macros from that header file to be able to handle bit types correctly in mysqli, when libmysql is used. #if MYSQL_VERSION_ID 50002 if (mysql_fetch_field_direct(result, i)-type == MYSQL_TYPE_BIT) {

Re: [PHP-DEV] [PATCH] Attempt to include ext/mysqlnd/mysqlnd_portability.h when building MySQLi against libmysql

2010-01-11 Thread Andrey Hristov
Andrey, Yes, it compiled just fine with my patch. Even loaded :) May the source be with you, Best regards, Jess Portnoy Andrey Hristov wrote: Hi Jess, does it compile after that, because I guess it doesn't. We use some macros from that header file to be able to handle bit types correctly

Re: [PHP-DEV] [PATCH] Attempt to include ext/mysqlnd/mysqlnd_portability.h when building MySQLi against libmysql

2010-01-11 Thread Andrey Hristov
will be able to compile as a module (with phpize). May the source be with you, Best regards, Jess Portnoy Best, Andrey Andrey Hristov wrote: Jess Portnoy wrote: Reason is MYSQL_VERSION_ID is defined here: ext/mysqlnd/mysqlnd_libmysql_compat.h:#define MYSQL_VERSION_ID

Re: [PHP-DEV] [PATCH] Attempt to include ext/mysqlnd/mysqlnd_portability.h when building MySQLi against libmysql

2010-01-11 Thread Andrey Hristov
Hi Jess, Jess Portnoy wrote: I see but assuming mysqlnd is copied, I can still see a problem, in the configure script: echo #define $php_def_have_what 1 ext/mysqlnd/php_mysqlnd_config.h When running my configure: ./configure --disable-xml --disable-dom --disable-libxml --disable-simplexml

Re: [PHP-DEV] Re: svn: /php/php-src/ branches/PHP_5_2/main/php_version.h branches/PHP_5_3/ext/mysqlnd/mysqlnd.c branches/PHP_5_3/ext/mysqlnd/mysqlnd_statistics.c branches/PHP_5_3/ext/mysqlnd/mysqlnd_

2010-01-11 Thread Andrey Hristov
Sebastian Bergmann wrote: Am 11.01.2010 19:31, schrieb Andrey Hristov: Modified: php/php-src/branches/PHP_5_2/main/php_version.h === --- php/php-src/branches/PHP_5_2/main/php_version.h 2010-01-11 18:27:31 UTC (rev 293417

Re: [PHP-DEV] Re: svn: /php/php-src/branches/PHP_5_3/ NEWS ext/mysqlnd/mysqlnd_portability.h

2009-08-25 Thread Andrey Hristov
Sebastian Bergmann wrote: Andrey Hristov schrieb: Jani Taskinen wrote: This should propably be some FAQ somewhere, but please commit things in one single commit. (sparse checkouts rule! :) One single commit? I did commit at once. Jani meant one commit to update all three branches. ah

[PHP-DEV] Renaming php-cvs to php-svn ?

2009-07-16 Thread Andrey Hristov
Hi, does it makes sense? Once we renamed php-dev to internals, so this won't be the first ML rename. Best, Andrey -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] HASH_DEL_KEY_QUICK without any meaning?

2009-06-04 Thread Andrey Hristov
and...@winnie:~/dev/vanilla/php5/Zend$ grep HASH_DEL_KEY_QUICK * zend_hash.h:#define HASH_DEL_KEY_QUICK 2 zend_hash.h:zend_hash_del_key_or_index(ht, arKey, nKeyLength, h, HASH_DEL_KEY_QUICK) Can someone enlighten why do we need that, or it was something left unimplemented?

[PHP-DEV] Re: [PATCH] mysqli #35203 / #48065 Eliminate special case for calling procedures in mysqli

2009-04-26 Thread Andrey Hristov
Hi, could you show how you want to express that in PHP code that will work with calling prepared statements. How the API should work? (Example PHP code that uses the new API). Best, Andrey Michael G Schwern wrote: This is a patch against 5.2.9 to fix mysqli::query so a user can call stored

Re: [PHP-DEV] mysqlnd problems

2009-03-30 Thread Andrey Hristov
Hi, Ionut G. Stan wrote: Hi Ulf, Thanks for the answer, but let me understand this better. The old mysql API did not support the auth protocol of MySQL 4.1+, but only lower, while the new mysqlnd API only supports MySQL 4.1+ auth protocol. At least this is what I understand from the error

Re: [PHP-DEV] GSOC Idea, RPC Server

2009-03-19 Thread Andrey Hristov
http://www.vl-srm.net/ ? Cesar D. Rodas wrote: 2009/3/19 mike mike...@gmail.com: ... Andrey -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Namespace Resolution

2008-11-04 Thread Andrey Hristov
Ryan Panning wrote: use 'NsA\NsB\NsC\func_c()'; OMG That looks UGLY1 $obj = new NsA\NsB\ClassB; $obj-methodB(); func_c(); ? Best, Andrey -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] php7- dropping the $ from the variable name - rfc

2008-09-19 Thread Andrey Hristov
in :) Best, Andrey -- Andrey Hristov, Connectors Software Developer, Database Group Sun Microsystems GmbH, Sonnenallee 1, 85551 Kirchheim-Heimstetten Amtsgericht Muenchen: HRB161028 Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer Vorsitzender des Aufsichtsrates: Martin Haering

Re: [PHP-DEV] Inconsistencies in 5.3

2008-08-04 Thread Andrey Hristov
Hi, Lukas Kahwe Smith wrote: On 04.08.2008, at 10:41, Marcus Boerger wrote: Hello Lukas, Monday, August 4, 2008, 10:32:26 AM, you wrote: On 04.08.2008, at 10:28, Stefan Priebsch wrote: Hannes Magnusson schrieb: I don't think anyone but him likes multiple namespaces per file. I do

Re: [PHP-DEV] CVS to SVN Migration

2008-07-25 Thread Andrey Hristov
Hi, David Soria Parra wrote: However I think we should provide the infrastructure for developers to setup a dvcs. I dont know if we want to standardize on a specific one. But collaboration on exterimental stuff that requires a dvcs should be possible on php.net servers. Maybe it's just

Re: [PHP-DEV] to be discussed items

2008-07-15 Thread Andrey Hristov
Lukas Kahwe Smith wrote: Hi, I am about to move all to be discussed items [1] to the future PHP release section (so after 5.3): 1) userspace streams filter that acts as a default filter through which require/include read their files (Sebastian, Sara) 2) XMLWriter: Add writeNode([xmlreader

[PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/mysql php_mysql.c /ext/mysqli mysqli.c /ext/mysqlnd mysqlnd.c mysqlnd_palloc.c mysqlnd_ps.c mysqlnd_wireprotocol.c

2008-07-15 Thread Andrey Hristov
Hi Marcus, Marcus Boerger wrote: Hello Andrey, Tuesday, July 15, 2008, 3:12:27 PM, you wrote: andrey Tue Jul 15 13:12:27 2008 UTC Modified files: /php-src/ext/mysql php_mysql.c /php-src/ext/mysqli mysqli.c /php-src/ext/mysqlndmysqlnd.c

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/mysql php_mysql.c /ext/mysqli mysqli.c /ext/mysqlnd mysqlnd.c mysqlnd_palloc.c mysqlnd_ps.c mysqlnd_wireprotocol.c

2008-07-15 Thread Andrey Hristov
Marcus, Marcus Boerger wrote: Hello Ulf, Tuesday, July 15, 2008, 4:32:10 PM, you wrote: Pierre Joye schrieb: Drop the launchpad and use php's cvs. We have actually two development branches (5.3 until the 24th and HEAD) and PECL. The latter let you experiment as much as you wish. Pierre,

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/mysql php_mysql.c /ext/mysqli mysqli.c /ext/mysqlnd mysqlnd.c mysqlnd_palloc.c mysqlnd_ps.c mysqlnd_wireprotocol.c

2008-07-15 Thread Andrey Hristov
Pierre, Pierre Joye wrote: Hi Ulf, On Tue, Jul 15, 2008 at 4:32 PM, Ulf Wendel [EMAIL PROTECTED] wrote: Pierre Joye schrieb: Drop the launchpad and use php's cvs. We have actually two development branches (5.3 until the 24th and HEAD) and PECL. The latter let you experiment as much as you

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/mysql php_mysql.c /ext/mysqli mysqli.c /ext/mysqlnd mysqlnd.c mysqlnd_palloc.c mysqlnd_ps.c mysqlnd_wireprotocol.c

2008-07-15 Thread Andrey Hristov
Pierre, Pierre Joye wrote: On Tue, Jul 15, 2008 at 5:42 PM, Ulf Wendel [EMAIL PROTECTED] wrote: What's your point, what requests are you talking about? Please ask Johannes, I told them to him live last time we met. If there is doubts, I will happily repeat them. I saw one person

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/mysql php_mysql.c /ext/mysqli mysqli.c /ext/mysqlnd mysqlnd.c mysqlnd_palloc.c mysqlnd_ps.c mysqlnd_wireprotocol.c

2008-07-15 Thread Andrey Hristov
Pierre Joye wrote: I have no clue if Andrey has combined several fixes in one commit. At this point I have to rely on him choosing a proper granularity for a commit. Too large commits can always happen. You can work for a month in your local CVS copy and commit 100k at one - no difference.

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/mysql php_mysql.c /ext/mysqli mysqli.c /ext/mysqlnd mysqlnd.c mysqlnd_palloc.c mysqlnd_ps.c mysqlnd_wireprotocol.c

2008-07-15 Thread Andrey Hristov
Pierre Joye wrote: On Tue, Jul 15, 2008 at 7:47 PM, Andrey Hristov [EMAIL PROTECTED] wrote: Pierre Joye wrote: I have no clue if Andrey has combined several fixes in one commit. At this point I have to rely on him choosing a proper granularity for a commit. Too large commits can always happen

Re: [PHP-DEV] Float comparison

2008-05-02 Thread Andrey Hristov
and check whether the difference is bigger or smaller than a small predefined number. Regards, Andrey -- Andrey Hristov, Connectors Software Developer Sun Microsystems GmbH, Sonnenallee 1, 85551 Kirchheim-Heimstetten Amtsgericht Muenchen: HRB161028 Geschaeftsfuehrer: Thomas Schroeder, Wolfgang

Re: [PHP-DEV] [PATCH] More array filling optimizations

2008-04-25 Thread Andrey Hristov
Hi, Matt Wilmas wrote: Hi all, Expanding on the idea of passing a size other than 0 to zend_hash_init(), when possible, which was done awhile ago in a few areas (to save resize/rehash operations), I finally added an array_init_size() that can be used instead of array_init(), likewise, when a

Re: [PHP-DEV] PHP 5.2.6RC5 Released

2008-04-11 Thread Andrey Hristov
a while. libmysql should be updated in all cases to at least 5.0.51. There is a nasty bug with long history which is fixed when using 5.0.51 . The my_thread_end bug. Let's smash it now and forever. regards holo Regards, Andrey -- Andrey Hristov, Connectors Software Developer MySQL GmbH

Re: [PHP-DEV] Add a memory limit in mysql ext

2008-03-31 Thread Andrey Hristov
Hi, Olivier Bonvalet wrote: Hello, I often host clients which have bad PHP/SQL code ; as for example a select * + mysql_row_nums on a 200Mo table just to count lines... So I add a little patch to throw a warning in case the result of mysql_query is larger than a specified limit. I use the

Re: [PHP-DEV] Re: [PDO] [RFC] An Idea for PDO 2

2008-02-04 Thread Andrey Hristov
Hi, Pierre Joye wrote: Hi, I think the biggest myths in this CLA discussion are: The main realization was that the vendors could not co-operate with each other on code without a CLA in place, and that some of them would not be able to co-operate with the community without a CLA in place.

Re: [PHP-DEV] PHP6 - fixed mysql/mysqlnd/mysqli/pdo_mysql

2007-08-31 Thread Andrey Hristov
Hi, BuildSmart wrote: On Aug 30, 2007, at 03:18:34, Jani Taskinen wrote: Perhaps you could send the diff to the list, or better yet, an url pointing to the place you uploaded the diff. And note: it should be unified diff. (diff -u) I don't understand the intention of the changes? What

Re: [PHP-DEV] PHP6 - fixed mysql/mysqlnd/mysqli/pdo_mysql

2007-08-31 Thread Andrey Hristov
Hi Dale, BuildSmart wrote: On Aug 31, 2007, at 09:43:14, Andrey Hristov wrote: Hi, BuildSmart wrote: On Aug 30, 2007, at 03:18:34, Jani Taskinen wrote: Perhaps you could send the diff to the list, or better yet, an url pointing to the place you uploaded the diff. And note: it should

Re: [PHP-DEV] What should be in 5.3?

2007-08-29 Thread Andrey Hristov
Hi Andi, Andi Gutmans wrote: Hi all, From my point of view I think we can make a really good PHP 5.3 release pretty quickly as long as we are careful about the scope. There's a lot of good work which is low risk which we can easily roll into it. There are high risk items like garbage

Re: [PHP-DEV] Re: multi-threaded run-tests.php

2007-07-25 Thread Andrey Hristov
Hi Tony, Antony Dovgal wrote: On 25.07.2007 19:37, Nuno Lopes wrote: So here it is my first attempt: http://gcov.php.net/~nlopess/multi_threaded_run_tests.txt WARNING: The patch is ugly and the output of the script isn't the prettiest. Anyway, for automated testing seems to be good enough.

  1   2   3   4   >