[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146758705 ## File path:

[GitHub] jvrao commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

jvrao commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146758311 ## File path:

[GitHub] jvrao commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

jvrao commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146756424 ## File path:

[GitHub] ivankelly commented on a change in pull request #227: DLFS - A FileSystem API wrapper over dlog API

ivankelly commented on a change in pull request #227: DLFS - A FileSystem API wrapper over dlog API URL: https://github.com/apache/distributedlog/pull/227#discussion_r146754100 ## File path: distributedlog-io/dlfs/src/main/java/org/apache/distributedlog/fs/DLFileSystem.java

[GitHub] sijie commented on a change in pull request #658: Fail earlier when encountering DNS issues

sijie commented on a change in pull request #658: Fail earlier when encountering DNS issues URL: https://github.com/apache/bookkeeper/pull/658#discussion_r146712866 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java

[GitHub] sijie commented on a change in pull request #658: Fail earlier when encountering DNS issues

sijie commented on a change in pull request #658: Fail earlier when encountering DNS issues URL: https://github.com/apache/bookkeeper/pull/658#discussion_r146712921 ## File path:

[GitHub] sijie opened a new issue #659: Checkpoint logic is broken in SortedLedgerStorage

sijie opened a new issue #659: Checkpoint logic is broken in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/issues/659 *Problem* Currently SortedLedgerStorage doesn't maintain any checkpoint related information. It shares the same `checkpoint holder` with

[GitHub] asfgit commented on issue #658: Fail earlier when encountering DNS issues

asfgit commented on issue #658: Fail earlier when encountering DNS issues URL: https://github.com/apache/bookkeeper/pull/658#issuecomment-339158066 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #658: Fail earlier when encountering DNS issues

asfgit commented on issue #658: Fail earlier when encountering DNS issues URL: https://github.com/apache/bookkeeper/pull/658#issuecomment-339153607 Refer to this link for build results (access rights to CI server needed):

[GitHub] merlimat commented on a change in pull request #657: Use hash set with native ints for write set tracking

merlimat commented on a change in pull request #657: Use hash set with native ints for write set tracking URL: https://github.com/apache/bookkeeper/pull/657#discussion_r146706531 ## File path: bookkeeper-server/pom.xml ## @@ -178,6 +178,11 @@ http-server

[GitHub] sijie commented on a change in pull request #657: Use hash set with native ints for write set tracking

sijie commented on a change in pull request #657: Use hash set with native ints for write set tracking URL: https://github.com/apache/bookkeeper/pull/657#discussion_r146698783 ## File path: bookkeeper-server/pom.xml ## @@ -178,6 +178,11 @@ http-server

[GitHub] eolivelli commented on a change in pull request #657: Use hash set with native ints for write set tracking

eolivelli commented on a change in pull request #657: Use hash set with native ints for write set tracking URL: https://github.com/apache/bookkeeper/pull/657#discussion_r146650203 ## File path: bookkeeper-server/pom.xml ## @@ -178,6 +178,11 @@ http-server

[GitHub] sijie commented on issue #225: Create log should create missing path components

sijie commented on issue #225: Create log should create missing path components URL: https://github.com/apache/distributedlog/issues/225#issuecomment-339084336 this is merged by #228 This is an automated message from the

[GitHub] ivankelly opened a new pull request #657: Use hash set with native ints for write set tracking

ivankelly opened a new pull request #657: Use hash set with native ints for write set tracking URL: https://github.com/apache/bookkeeper/pull/657 This avoids the autoboxing on Integers and allocations of cells for the hashset. This also implies using IntArrayList for the write

[GitHub] jiazhai commented on a change in pull request #43: DLFS - A filesystem built on replicated logs

jiazhai commented on a change in pull request #43: DLFS - A filesystem built on replicated logs URL: https://github.com/apache/distributedlog/pull/43#discussion_r146567681 ## File path:

[GitHub] jiazhai commented on a change in pull request #43: DLFS - A filesystem built on replicated logs

jiazhai commented on a change in pull request #43: DLFS - A filesystem built on replicated logs URL: https://github.com/apache/distributedlog/pull/43#discussion_r146567445 ## File path:

Build failed in Jenkins: bookkeeper-postcommit-publish-website #128

See Changes: [eolivelli] Pool AddCompletions -- [...truncated 450.93 KB...] [INFO] Apache BookKeeper :: Stats Providers :: Twitter Science Stats

[GitHub] eolivelli closed pull request #649: Pool AddCompletions

eolivelli closed pull request #649: Pool AddCompletions URL: https://github.com/apache/bookkeeper/pull/649 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146521260 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerType.java ##

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146520915 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerType.java ##

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146520352 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -83,6 +92,7 @@ message

[GitHub] sijie opened a new pull request #230: Issue 226: ByteBuf.release() was not called before it's garbage-collected

sijie opened a new pull request #230: Issue 226: ByteBuf.release() was not called before it's garbage-collected URL: https://github.com/apache/distributedlog/pull/230 Descriptions of the changes in this PR: the problem is a new entry buffer was allocated when closing log segment

[GitHub] sijie opened a new pull request #229: Issue 224: listing logs should exclude

sijie opened a new pull request #229: Issue 224: listing logs should exclude URL: https://github.com/apache/distributedlog/pull/229 Descriptions of the changes in this PR: exclude `` from listing logs (the tests are covered by #227)

[GitHub] sijie opened a new issue #226: ByteBuf.release() was not called before it's garbage-collected.

sijie opened a new issue #226: ByteBuf.release() was not called before it's garbage-collected. URL: https://github.com/apache/distributedlog/issues/226 Found following logging on closing log segment. It is harmless but annoying. ``` 2017-10-24 01:40:28,333 - ERROR -

[GitHub] sijie opened a new issue #224: listing logs should exclude

sijie opened a new issue #224: listing logs should exclude URL: https://github.com/apache/distributedlog/issues/224 **FEATURE REQUEST** 1. Please describe the feature you are requesting. `` is used for log identifier. it would be good to exclude `` while listing

[GitHub] sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146491818 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -83,6 +92,7 @@ message

Jenkins build is still unstable: bookkeeper-release-nightly-snapshot #83

See

[GitHub] ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146486343 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -62,6 +62,7 @@ enum

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146036457 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -83,6 +92,7 @@ message

[GitHub] ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146485874 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -83,6 +92,7 @@ message

[GitHub] asfgit commented on issue #649: Pool AddCompletions

asfgit commented on issue #649: Pool AddCompletions URL: https://github.com/apache/bookkeeper/pull/649#issuecomment-338913081 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/bookkeeper-precommit-pullrequest-docker/141/

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146483992 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146483788 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146483553 ## File path:

[GitHub] sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146482385 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -136,6 +147,11 @@ message

[GitHub] sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

sijie commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146482199 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -83,6 +92,7 @@ message

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146480717 ## File path:

[GitHub] eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146480119 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -62,6 +62,7 @@ enum

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146479924 ## File path:

[GitHub] sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146479659 ## File path:

[GitHub] ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes

ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146479494 ## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ## @@ -62,6 +62,7 @@ enum

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146476663 ## File path:

[GitHub] ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy

ivankelly commented on a change in pull request #641: Issue-596 Issue-583: Auto replication should honor ensemble placement policy URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146476218 ## File path:

Jenkins build became unstable: distributedlog-nightly-build #466

See

[GitHub] ivankelly commented on issue #649: Pool AddCompletions

ivankelly commented on issue #649: Pool AddCompletions URL: https://github.com/apache/bookkeeper/pull/649#issuecomment-338899120 Latest push is a straight rebase onto master to get rid of conflicts. In fact their was no conflicts, it rebased without issue.

[GitHub] ivankelly commented on issue #649: Pool AddCompletions

ivankelly commented on issue #649: Pool AddCompletions URL: https://github.com/apache/bookkeeper/pull/649#issuecomment-338899120 Latest push is a straight rebase onto master to get rid of conflicts. This is an automated

[GitHub] eolivelli commented on a change in pull request #649: Pool AddCompletions

eolivelli commented on a change in pull request #649: Pool AddCompletions URL: https://github.com/apache/bookkeeper/pull/649#discussion_r146470714 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java ## @@ -832,28 +836,7 @@

[GitHub] ivankelly commented on a change in pull request #649: Pool AddCompletions

ivankelly commented on a change in pull request #649: Pool AddCompletions URL: https://github.com/apache/bookkeeper/pull/649#discussion_r146470461 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java ## @@ -832,28 +836,7 @@