Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2225#discussion_r185481687
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/DDLStrategy.scala
---
@@ -224,15 +224,32 @@ class
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2225#discussion_r185481616
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/DDLStrategy.scala
---
@@ -224,15 +224,32 @@ class
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2232
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2243
In CSVInputFormat.java class set the error content length to 0 in parser
setting so that parser while preparing the exception message does not contain
the data on the error message
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2243
Can we add a test case for this scenario
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2232#discussion_r185400079
--- Diff:
integration/spark-common/src/main/java/org/apache/carbondata/spark/dictionary/server/SecureDictionaryServer.java
---
@@ -63,7 +67,18
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2225#discussion_r185398816
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/sql/commands/UsingCarbondataSuite.scala
---
@@ -69,4 +73,11
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1812
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2244#discussion_r184915943
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/CacheClient.java ---
@@ -16,21 +16,40 @@
*/
package
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2244#discussion_r184911430
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/dev/expr/DataMapExprWrapperImpl.java
---
@@ -86,4 +87,8 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2244#discussion_r184915870
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/BlockletDataMapUtil.java ---
@@ -0,0 +1,198 @@
+/*
+ * Licensed
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2244#discussion_r184914643
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java
---
@@ -277,4 +298,30 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2244#discussion_r184914866
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/blocklet/DataFileFooter.java
---
@@ -52,7 +52,7
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1812
retest sdv please
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2210
retest sdv please
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1812
LGTM...can be merged once build is passed
Please raise a sub-jira task under the same jira to track the Custom
compaction implementation for child tables/datamaps and add the jira link
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2192
PR #2149 already merged in master
---
Github user manishgupta88 closed the pull request at:
https://github.com/apache/carbondata/pull/2192
---
Github user manishgupta88 closed the pull request at:
https://github.com/apache/carbondata/pull/2191
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2191
Already pr raised in master PR #2210
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2210#discussion_r184610515
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/ResultCollectorFactory.java
---
@@ -45,31 +46,37 @@
* @return
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2121
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2063
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1812#discussion_r184397997
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1812#discussion_r184403180
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala
---
@@ -566,6
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1812#discussion_r184386961
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datacompaction
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1812#discussion_r184398845
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSpark2SqlParser.scala
---
@@ -124,11 +124,13 @@ class
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1812#discussion_r184401040
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/CarbonDataMergerUtil.java
---
@@ -444,6 +450,26 @@ public int compare
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1812#discussion_r184398253
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2231
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2187
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2210#discussion_r184326083
--- Diff:
core/src/main/java/org/apache/carbondata/core/stats/QueryStatisticsConstants.java
---
@@ -58,6 +58,28 @@
String
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2187#discussion_r184281751
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableInfo.java
---
@@ -97,6 +102,14 @@ public TableSchema
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2187#discussion_r184281016
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java
---
@@ -121,7 +123,7 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2187#discussion_r184280492
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/UnsafeMemoryDMStore.java
---
@@ -101,6 +102,7 @@ public void addIndexRow
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2187#discussion_r184278866
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/DataRefNode.java ---
@@ -141,5 +141,5 @@ DimensionRawColumnChunk
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/2217
[CARBONDATA-2391] [Compaction Thread Leak] Thread leak in compaction
operation if prefetch is enabled and compaction process is killed
Problem
Thread leak in compaction operation
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2191#discussion_r183342972
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/result/impl/NonFilterQueryScannedResult.java
---
@@ -48,6 +53,31 @@ public
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/2210
[CARBONDATA-2381] Improve compaction performance by filling batch result in
columnar format and performing IO at blocklet level
Problem: Compaction performance is slow as compared
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/2192
[WIP] [Sync PR 2149] Changes taken from PR 2149 for compaction to enable
reading at blocklet level and page uncompression at page level
Code synced from PR #2149 for compaction
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/2191
[WIP] Improve compaction performance
Problem: Compaction performance is slow as compared to data load
Analysis:
1. During compaction result filling is done in row format. Due
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2063
LGTM...can be merged once SDV build is success
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2136
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2136
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2163
retest this please
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2159
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2158
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2142
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2154
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2146
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2155
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2142#discussion_r180646025
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/AbstractResultProcessor.java
---
@@ -37,7 +39,7 @@
* @param
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2142#discussion_r180646899
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/CompactionResultSortProcessor.java
---
@@ -165,8 +168,12 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2142#discussion_r180645796
--- Diff: processing/pom.xml ---
@@ -34,6 +34,11 @@
+
+ org.apache.spark
+ spark-core_
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2142#discussion_r180646949
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/RowResultMergerProcessor.java
---
@@ -157,10 +160,15 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2142#discussion_r180646852
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/CompactionResultSortProcessor.java
---
@@ -165,8 +168,12 @@ public
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2143
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2066
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2154#discussion_r180638168
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonSessionInfo.java ---
@@ -60,11 +60,9 @@ public CarbonSessionInfo clone
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2134
@dhatchayani ...Merged to 1.3 branch, kindly raise the PR for master
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2134
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2143#discussion_r180315475
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonCreateTableCommand.scala
---
@@ -121,21 +121,24
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2143
Add a test case for this scenario. We have multiple test cases to test
concurrency scenarios, you can take the reference from there
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2140
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2140#discussion_r179661112
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -493,18 +493,15 @@ object
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2102
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2109
retest sdv please
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2136#discussion_r179080266
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/MeasureRawColumnChunk.java
---
@@ -106,9 +106,13 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2136#discussion_r179080396
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/DimensionRawColumnChunk.java
---
@@ -106,9 +106,13 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2136#discussion_r179074922
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala
---
@@ -438,7 +438,9 @@ class
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2136#discussion_r179074140
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala
---
@@ -402,7 +402,7 @@ class
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178719972
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178787300
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -62,8
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178784636
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala
---
@@ -39,6
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178780592
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala
---
@@ -39,6
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178719497
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonOutputCommitter.java
---
@@ -130,15 +130,20 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178758267
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/partition/CarbonAlterTableDropHivePartitionCommand.scala
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178767625
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala
---
@@ -39,6
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178761202
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/partition/CarbonAlterTableDropHivePartitionCommand.scala
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178775449
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala
---
@@ -39,6
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2109#discussion_r178727711
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/standardpartition
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2134
Add few UT's to test this code
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2134#discussion_r178724959
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java
---
@@ -156,15 +167,18 @@ private
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2134#discussion_r178724390
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapDistributable.java
---
@@ -38,4 +38,5 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2134#discussion_r178724054
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/UnsafeMemoryDMStore.java
---
@@ -32,9 +37,14 @@
/**
* Store
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2134#discussion_r178723724
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/row/UnsafeDataMapRow.java
---
@@ -30,7 +30,12 @@
*/
public class
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2134#discussion_r178723563
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMap.java
---
@@ -124,10 +130,12
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2134#discussion_r178723434
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMap.java
---
@@ -77,6 +78,11
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2134#discussion_r178723320
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/UnsafeMemoryDMStore.java
---
@@ -177,10 +204,45 @@ public UnsafeDataMapRow
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2134#discussion_r178723089
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/UnsafeMemoryDMStore.java
---
@@ -97,12 +119,17 @@ public void
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2134#discussion_r178722797
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/BlockletDataMapIndexStore.java
---
@@ -206,6 +206,31 @@ public void
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2134#discussion_r178721874
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/BlockIndexStore.java ---
@@ -229,6 +229,10 @@ private String getLruCacheKey
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2134#discussion_r178721900
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/SegmentTaskIndexStore.java
---
@@ -140,6 +140,10 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2134#discussion_r178721496
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/DataMapJob.java ---
@@ -19,15 +19,21 @@
import java.io.Serializable
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2134#discussion_r178720946
--- Diff:
core/src/main/java/org/apache/carbondata/core/cache/dictionary/ReverseDictionaryCache.java
---
@@ -168,6 +168,10 @@ public
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2118
LGTMAlready merged to master as part of PR #2110
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2117
Already merged to master as part of PR #2104
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2117
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2084
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2107
LGTM
---
401 - 500 of 771 matches
Mail list logo
