[GitHub] carbondata issue #1116: [CARBONDATA-1249] Wrong order of columns in redirect...

2017-12-20 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/carbondata/pull/1116 LGTM ---

[GitHub] carbondata pull request #2276: [CARBONDATA-2443][WIP][SDK]Multi level comple...

2018-05-06 Thread sounakr
GitHub user sounakr opened a pull request: https://github.com/apache/carbondata/pull/2276 [CARBONDATA-2443][WIP][SDK]Multi level complex type support for AVRO based SDK Multi level complex type support for AVRO based SDK - [ ] Any interfaces changed? - [ ] Any

[GitHub] carbondata issue #2261: [CARBONDATA-2430][SDK] Reshuffling of Columns given ...

2018-05-07 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/carbondata/pull/2261 Retest this please ---

[GitHub] carbondata issue #2261: [CARBONDATA-2430][SDK] Reshuffling of Columns given ...

2018-05-07 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/carbondata/pull/2261 Retest this please. ---

[GitHub] carbondata issue #2261: [CARBONDATA-2430][SDK] Reshuffling of Columns given ...

2018-05-07 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/carbondata/pull/2261 @ravipesala Refactoring of Building schema will be done as part of a separate PR as the changes are more and can impact the CarbonTable creation. ---

[GitHub] carbondata pull request #2276: [CARBONDATA-2443][WIP][SDK]Multi level comple...

2018-05-07 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2276#discussion_r186388685 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/steps/InputProcessorStepForPartitionImpl.java --- @@ -220,32 +241,97

[GitHub] carbondata pull request #2276: [CARBONDATA-2443][WIP][SDK]Multi level comple...

2018-05-07 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2276#discussion_r186388739 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModel.java --- @@ -202,6 +202,13

[GitHub] carbondata pull request #2276: [CARBONDATA-2443][WIP][SDK]Multi level comple...

2018-05-07 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2276#discussion_r186388851 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/DataLoadProcessBuilder.java --- @@ -76,6 +78,19 @@ public

[GitHub] carbondata issue #2276: [CARBONDATA-2443][WIP][SDK]Multi level complex type ...

2018-05-07 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/carbondata/pull/2276 Retest this please ---

[GitHub] carbondata issue #2276: [CARBONDATA-2443][WIP][SDK]Multi level complex type ...

2018-05-07 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/carbondata/pull/2276 Retest this please ---

[GitHub] carbondata pull request #2276: [CARBONDATA-2443][SDK]Multi level complex typ...

2018-05-07 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2276#discussion_r186433007 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/steps/InputProcessorStepForPartitionImpl.java --- @@ -220,32 +241,97

[GitHub] carbondata issue #2276: [CARBONDATA-2443][SDK]Multi level complex type suppo...

2018-05-07 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/carbondata/pull/2276 Retest this please ---

[GitHub] carbondata issue #2276: [CARBONDATA-2443][SDK]Multi level complex type suppo...

2018-05-08 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/carbondata/pull/2276 Retest this please ---

[GitHub] carbondata pull request #2273: [CARBONDATA-2442] Fixed: Reading two sdk writ...

2018-05-09 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2273#discussion_r187030343 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java --- @@ -151,6 +154,33 @@ public CarbonTable

[GitHub] carbondata pull request #2294: [CARBONDATA-2443][SDK] Multi level complex ty...

2018-05-10 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2294#discussion_r187337029 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java --- @@ -114,12 +115,12 @@ public void

[GitHub] carbondata issue #2276: [CARBONDATA-2443][SDK]Multi level complex type suppo...

2018-05-07 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/carbondata/pull/2276 Retest this please ---

[GitHub] carbondata pull request #2261: [CARBONDATA-2430][SDK] Reshuffling of Columns...

2018-05-04 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2261#discussion_r186057583 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java --- @@ -416,16 +411,58 @@ private CarbonTable

[GitHub] carbondata issue #2261: [CARBONDATA-2430][SDK] Reshuffling of Columns given ...

2018-05-04 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/carbondata/pull/2261 Retest this please ---

[GitHub] carbondata pull request #2261: [CARBONDATA-2430][SDK] Reshuffling of Columns...

2018-05-04 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2261#discussion_r186058580 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestNonTransactionalCarbonTable.scala

[GitHub] carbondata pull request #2261: [CARBONDATA-2430][SDK] Reshuffling of Columns...

2018-05-04 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2261#discussion_r186058667 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java --- @@ -169,11 +186,11 @@ private void

[GitHub] carbondata pull request #2261: [CARBONDATA-2430][SDK] Reshuffling of Columns...

2018-05-04 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2261#discussion_r186059780 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -604,31 +604,58 @@ abstract class

[GitHub] carbondata pull request #2261: [CARBONDATA-2430][SDK] Reshuffling of Columns...

2018-05-04 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2261#discussion_r186056928 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java --- @@ -108,21 +115,36 @@ public void

[GitHub] carbondata pull request #2261: [CARBONDATA-2430][SDK] Reshuffling of Columns...

2018-05-04 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2261#discussion_r186057833 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestNonTransactionalCarbonTable.scala

[GitHub] carbondata pull request #2214: [CARBONDATA-2387]Primitive AVRO Datatype Chec...

2018-05-04 Thread sounakr
Github user sounakr closed the pull request at: https://github.com/apache/carbondata/pull/2214 ---

[GitHub] carbondata pull request #2318: [CARBONDATA-2491] Fix the error when reader r...

2018-05-22 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2318#discussion_r189922516 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -77,6 +85,24 @@ public void testWriteAndReadFiles

[GitHub] carbondata pull request #2318: [CARBONDATA-2491] Fix the error when reader r...

2018-05-22 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2318#discussion_r189923456 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -77,6 +85,24 @@ public void testWriteAndReadFiles

[GitHub] carbondata issue #2318: [CARBONDATA-2491] Fix the error when reader read twi...

2018-05-23 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/carbondata/pull/2318 LGTM ---

[GitHub] carbondata pull request #2349: [CARBONDATA-2552]Fix Data Mismatch for Comple...

2018-05-29 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2349#discussion_r191325961 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/complextypes/PrimitiveQueryType.java --- @@ -95,7 +95,7 @@ public PrimitiveQueryType

[GitHub] carbondata pull request #2345: [CARBONDATA-2557] Improve Carbon Reader Schem...

2018-05-29 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2345#discussion_r191328391 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java --- @@ -101,6 +108,45 @@ public static CarbonReaderBuilder builder

[GitHub] carbondata issue #2352: [CARBONDATA-2555]Fixed SDK reader set default isTran...

2018-05-29 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/carbondata/pull/2352 LGTM ---

[GitHub] carbondata pull request #2353: [CARBONDATA-2558] Optimize carbon schema read...

2018-05-29 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2353#discussion_r191356357 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java --- @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache

[GitHub] carbondata pull request #2347: [CARBONDATA-2554] Added support for logical t...

2018-05-29 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2347#discussion_r191403062 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java --- @@ -177,13 +198,26 @@ private static Field prepareFields

[GitHub] carbondata pull request #2347: [CARBONDATA-2554] Added support for logical t...

2018-05-29 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2347#discussion_r191404125 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java --- @@ -221,13 +255,22 @@ private static Field prepareFields

[GitHub] carbondata pull request #2347: [CARBONDATA-2554] Added support for logical t...

2018-05-29 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2347#discussion_r191399826 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/steps/InputProcessorStepWithNoConverterImpl.java --- @@ -313,7 +315,22

[GitHub] carbondata pull request #2347: [CARBONDATA-2554] Added support for logical t...

2018-05-29 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2347#discussion_r191396937 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/PrimitiveDataType.java --- @@ -316,15 +321,32 @@ public int

[GitHub] carbondata pull request #2347: [CARBONDATA-2554] Added support for logical t...

2018-05-29 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2347#discussion_r191398287 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/PrimitiveDataType.java --- @@ -316,15 +321,32 @@ public int

[GitHub] carbondata pull request #2347: [CARBONDATA-2554] Added support for logical t...

2018-05-29 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2347#discussion_r191396859 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/PrimitiveDataType.java --- @@ -288,7 +288,12 @@ public int

[GitHub] carbondata issue #2347: [CARBONDATA-2554] Added support for logical type

2018-05-29 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/carbondata/pull/2347 @kunal642 . Please check all these logicalType can be supported in the current PR. 1. Time-millis 2. Time-micros     2. duration   ---

[GitHub] carbondata pull request #2347: [CARBONDATA-2554] Added support for logical t...

2018-05-29 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2347#discussion_r191386255 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/PrimitiveDataType.java --- @@ -288,7 +288,12 @@ public int

[GitHub] carbondata issue #2347: [CARBONDATA-2554] Added support for logical type

2018-06-04 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/carbondata/pull/2347 LGTM ---

[GitHub] carbondata pull request #2356: [CARBONDATA-2566] Optimize CarbonReaderExampl...

2018-05-31 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2356#discussion_r192302499 --- Diff: docs/sdk-guide.md --- @@ -408,17 +408,22 @@ External client can make use of this reader to read CarbonData files without Car String

[GitHub] carbondata issue #2356: [CARBONDATA-2566] Optimize CarbonReaderExample

2018-06-01 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/carbondata/pull/2356 LGTM ---

[GitHub] carbondata pull request #2341: [CARBONDATA-2500] Create are API to read user...

2018-05-27 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2341#discussion_r191094243 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -381,7 +384,343 @@ public boolean accept(File pathname

[GitHub] carbondata pull request #2341: [CARBONDATA-2500] Create are API to read user...

2018-05-27 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2341#discussion_r191094114 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java --- @@ -102,7 +104,23 @@ public static CarbonReaderBuilder builder

[GitHub] carbondata pull request #2338: [CARBONDATA-2524] Support create carbonReader...

2018-05-27 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2338#discussion_r191094883 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java --- @@ -152,9 +179,10 @@ public CarbonReaderBuilder

[GitHub] carbondata pull request #2341: [CARBONDATA-2500] Create are API to read user...

2018-05-29 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2341#discussion_r191317495 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -381,7 +384,343 @@ public boolean accept(File pathname

[GitHub] carbondata issue #2341: [CARBONDATA-2500] Create are API to read user's sche...

2018-05-29 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/carbondata/pull/2341 LGTM ---

[GitHub] carbondata issue #2338: [CARBONDATA-2524] Support create carbonReader with d...

2018-05-28 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/carbondata/pull/2338 LGTM ---

[GitHub] carbondata pull request #2338: [CARBONDATA-2524] Support create carbonReader...

2018-05-27 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2338#discussion_r191094718 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -409,4 +409,76 @@ public boolean accept(File pathname

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-26 Thread sounakr
GitHub user sounakr opened a pull request: https://github.com/apache/carbondata/pull/2417 [WIP][Complex Column Enhancements]Primitive DataType Adaptive Encoding Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily

[GitHub] carbondata pull request #2257: [CARBONDATA-2423][SDK]SDK Reader support to r...

2018-05-02 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2257#discussion_r185401794 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java --- @@ -244,10 +244,17 @@ public static CarbonTable

[GitHub] carbondata pull request #2257: [CARBONDATA-2423][SDK]SDK Reader support to r...

2018-05-02 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2257#discussion_r185403178 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonFileInputFormat.java --- @@ -126,13 +132,27 @@ protected CarbonTable

[GitHub] carbondata issue #2257: [CARBONDATA-2423][SDK]SDK Reader support to read fro...

2018-05-02 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/carbondata/pull/2257 Retest this please ---

[GitHub] carbondata pull request #2257: [CARBONDATA-2423][SDK]SDK Reader support to r...

2018-05-02 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2257#discussion_r185402417 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java --- @@ -244,10 +244,17 @@ public static CarbonTable

[GitHub] carbondata pull request #2257: [CARBONDATA-2423][SDK]SDK Reader support to r...

2018-05-01 Thread sounakr
GitHub user sounakr opened a pull request: https://github.com/apache/carbondata/pull/2257 [CARBONDATA-2423][SDK]SDK Reader support to read from Non Transactional Table SDK Reader support to read from Non Transactional Table - [ ] Any interfaces changed

[GitHub] carbondata issue #2257: [CARBONDATA-2423][SDK]SDK Reader support to read fro...

2018-05-01 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/carbondata/pull/2257 Retest this please ---

[GitHub] carbondata issue #2261: [CARBONDATA-2430][SDK] Reshuffling of Columns given ...

2018-05-03 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/carbondata/pull/2261 Retest this please ---

[GitHub] carbondata pull request #2261: [CARBONDATA-2430][SDK] Reshuffling of Columns...

2018-05-02 Thread sounakr
GitHub user sounakr opened a pull request: https://github.com/apache/carbondata/pull/2261 [CARBONDATA-2430][SDK] Reshuffling of Columns given by user in SDK. Reshuffling of Columns given by the user in SDK. Order should be Sort COlumns -> Dimension -> Complex -->

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-05-01 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r185217366 --- Diff: integration/spark2/src/main/scala/org/apache/spark/util/SparkTypeConverter.scala --- @@ -97,16 +97,30 @@ private[spark] object

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-05-01 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r185217438 --- Diff: integration/spark2/src/main/scala/org/apache/spark/util/SparkTypeConverter.scala --- @@ -123,13 +137,29 @@ private[spark] object

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-05-01 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r185213084 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/PrimitiveDataType.java --- @@ -211,29 +241,66 @@ public int

[GitHub] carbondata issue #2209: [CARBONDATA-2388][SDK]Avro Record Complex Type Imple...

2018-05-01 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/carbondata/pull/2209 Retest this please ---

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184992863 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/TablePage.java --- @@ -222,8 +222,9 @@ private void addComplexColumn(int

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184928356 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java --- @@ -134,7 +134,13 @@ void

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184929215 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/complextypes/PrimitiveQueryType.java --- @@ -53,6 +55,21 @@ public PrimitiveQueryType

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184927388 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/complextypes/PrimitiveQueryType.java --- @@ -53,6 +55,21 @@ public PrimitiveQueryType

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184927567 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/SchemaReader.java --- @@ -81,10 +81,13 @@ public static TableInfo

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184928085 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/column/ColumnSchema.java --- @@ -43,6 +43,9 @@ */ private

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184968977 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/PrimitiveDataType.java --- @@ -245,6 +312,28 @@ public void

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184968935 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/PrimitiveDataType.java --- @@ -245,6 +312,28 @@ public void

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184969127 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/CarbonDataLoadConfiguration.java --- @@ -348,6 +356,33 @@ public void

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184975951 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/CarbonDataLoadConfiguration.java --- @@ -348,6 +356,33 @@ public void

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184976034 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerModel.java --- @@ -609,5 +616,13 @@ public short

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184975993 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/PrimitiveDataType.java --- @@ -245,6 +312,28 @@ public void

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184976246 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/ArrayDataType.java --- @@ -183,7 +187,27 @@ public void parseAndBitPack

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184976193 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/ArrayDataType.java --- @@ -183,7 +187,27 @@ public void parseAndBitPack

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184976155 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/PrimitiveDataType.java --- @@ -245,6 +312,28 @@ public void

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184976110 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/PrimitiveDataType.java --- @@ -245,6 +312,28 @@ public void

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184976629 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/GenericDataType.java --- @@ -71,6 +71,8 @@ void writeByteArray(T input

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184976649 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/PrimitiveDataType.java --- @@ -94,6 +99,11 @@ private

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184976615 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/ArrayDataType.java --- @@ -183,7 +187,27 @@ public void parseAndBitPack

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184976884 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/complextypes/PrimitiveQueryType.java --- @@ -84,6 +101,9 @@ public PrimitiveQueryType

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184976699 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/complextypes/PrimitiveQueryType.java --- @@ -53,6 +55,21 @@ public PrimitiveQueryType

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184977270 --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java --- @@ -267,14 +267,24 @@ private static String

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184961725 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestNonTransactionalCarbonTable.scala

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184961740 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/complextypes/PrimitiveQueryType.java --- @@ -108,4 +128,14 @@ public PrimitiveQueryType

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184962348 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/ArrayDataType.java --- @@ -171,9 +175,9 @@ public void fillCardinality

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184962411 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/ArrayDataType.java --- @@ -183,7 +187,27 @@ public void parseAndBitPack

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184962372 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/ArrayDataType.java --- @@ -171,9 +175,9 @@ public void fillCardinality

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184963324 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/ArrayDataType.java --- @@ -183,7 +187,27 @@ public void parseAndBitPack

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184963740 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/GenericDataType.java --- @@ -80,7 +82,13 @@ void writeByteArray(T input

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184963673 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/GenericDataType.java --- @@ -71,6 +71,8 @@ void writeByteArray(T input

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184964228 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/PrimitiveDataType.java --- @@ -94,6 +99,11 @@ private

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184964754 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/PrimitiveDataType.java --- @@ -94,6 +99,11 @@ private

[GitHub] carbondata pull request #2209: [CARBONDATA-2388][SDK]Avro Record Complex Typ...

2018-04-30 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2209#discussion_r184956997 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/complextypes/PrimitiveQueryType.java --- @@ -53,6 +55,21 @@ public PrimitiveQueryType

[GitHub] carbondata issue #2261: [CARBONDATA-2430][SDK] Reshuffling of Columns given ...

2018-05-03 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/carbondata/pull/2261 Retest this please ---

[GitHub] carbondata issue #2261: [CARBONDATA-2430][SDK] Reshuffling of Columns given ...

2018-05-04 Thread sounakr
Github user sounakr commented on the issue: https://github.com/apache/carbondata/pull/2261 Retest this please ---

[GitHub] carbondata pull request #1434: [CARBONDATA-1593]Add partition to table cause...

2017-10-27 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1434#discussion_r147375453 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/partition/AlterTableSplitCarbonPartitionCommand.scala --- @@ -109,7

[GitHub] carbondata pull request #1437: [CARBONDATA-1618] Fix issue of not support ta...

2017-10-27 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1437#discussion_r147350873 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestCreateTableWithTableComment.scala

[GitHub] carbondata pull request #1437: [CARBONDATA-1618] Fix issue of not support ta...

2017-10-27 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1437#discussion_r147354669 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -247,7 +247,8 @@ abstract class

<    1   2   3   4   5   >