Re: [LyX/master] Nonsense for whoever insists on using gcc4.6 & qt4.8 in 2017

2017-03-19 Thread Guillaume Munch
Le 11/03/2017 à 20:16, Pavel Sanda a écrit : Guillaume Munch wrote: On the other hand, for graphics, the idea of the previous FileMonitor could be adapted to refresh graphics when they appear on the screen Perhaps. But it should do that when window gets active (we already catch that signal

Re: Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended-parameterised #1

2017-03-19 Thread Guillaume Munch
Le 19/03/2017 à 13:17, ci-...@inria.fr a écrit : Making distclean in . make[3]: Entering directory '/build/workspace/lyx-2.3.0dev/_build/sub/src' Makefile:2455: support/tests/.deps/check_ExternalTransforms-dummy_functions.Po: No such file or directory Makefile:2456:

Re: [PATCH] Output of en- and em-dashes

2017-03-18 Thread Guillaume Munch
Le 18/03/2017 à 14:59, Enrico Forestieri a écrit : On Wed, Mar 15, 2017 at 06:12:51PM +0100, Enrico Forestieri wrote: Apparently, nobody has a preference, so I am going to commit the second patch, i.e., the one using a zero-width space character. On second thoughts, I am not sure this is the

Re: cmake compilation error

2017-03-12 Thread Guillaume Munch
Le 12/03/2017 à 16:51, Kornel Benko a écrit : Should we emit a warning (which probably will be ignored) or better refuse to build with "5.0" <= QT < "5.4" ? I don't think so, the indication INSTALL file should be enough in that case. From my POV, if user selects QT5, we should use it.

Re: cmake compilation error

2017-03-11 Thread Guillaume Munch
Le 11/03/2017 à 18:07, Jean-Pierre Chrétien a écrit : Le 11/03/2017 à 17:57, Kornel Benko a écrit : I see the same with installed QT5.2.1. But no problems with QT5.7. Seems that I've got 5.3.2 here, Debian Jessie (up to date stable). Indeed the function is introduced in qt5.4. It is now

Re: [LyX/master] buffer-export without argument exports the default format

2017-03-11 Thread Guillaume Munch
Le 11/03/2017 à 08:37, Scott Kostyshak a écrit : It looks like Guillaume made the change at 3dec5826. Yes, and thanks for the feedback.

Re: [LyX/master] Nonsense for whoever insists on using gcc4.6 & qt4.8 in 2017

2017-03-11 Thread Guillaume Munch
Le 11/03/2017 à 08:34, Pavel Sanda a écrit : Guillaume Munch wrote: commit 24f68aff8d2ba9139017ca3927eda1f1aaf039af Author: Guillaume Munch <g...@lyx.org> Date: Sat Mar 11 00:11:02 2017 +0100 Nonsense for whoever insists on using gcc4.6 & qt4.8 in 2017 Does it mean it is no

Re: [LyX/master] buffer-export without argument exports the default format

2017-03-08 Thread Guillaume Munch
Le 08/03/2017 à 13:18, Kornel Benko a écrit : Am Mittwoch, 8. März 2017 um 11:48:12, schrieb Guenter Milde Would you be opposed to using a different symbol that is not interpreted by common shells? I thought about it. I prefer *, because * it is established as

Re: Ending selection on item inside a table erroneously interpreted as a "click", brings up dialog

2017-03-04 Thread Guillaume Munch
Le 03/03/2017 à 17:42, Helge Hafting a écrit : I guess the same goes for anything that does something when clicked. If it is inside a table cell and a mouse selection ends on top of it, a (wrong) click action happens. Hi Helge, It's fixed at 354897f6. Guillaume

Re: today's compilation errors and warnings

2017-03-04 Thread Guillaume Munch
Le 05/03/2017 à 03:27, Uwe Stöhr a écrit : I compiled today's master and get an error: xgettext: error while opening "src/frontends/qt4/LyXToolBox.cpp" for reading: No such file or directory C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(171,5): error

Re: [LyX/master] buffer-export without argument exports the default format

2017-03-04 Thread Guillaume Munch
Le 28/02/2017 à 04:50, Scott Kostyshak a écrit : On Tue, Feb 28, 2017 at 12:47:12AM +0100, Guillaume Munch wrote: commit a1faa41c839089a9f21323af6540926eae90ec6f Author: Guillaume Munch <g...@lyx.org> Date: Mon Feb 27 20:43:11 2017 +0100 buffer-export without argument exports the d

Re: How far is 2.3.0?

2017-03-04 Thread Guillaume Munch
Le 24/02/2017 à 18:45, Jean-Marc Lasgouttes a écrit : Hi there, A good subject before the week-end: what do we need to do before declaring feature freeze for 2.3? Personally I have finished a cycle or breaking/fixing the math editor and would like to refrain from doing new big architectural

Re: Regular expression search

2017-03-04 Thread Guillaume Munch
Le 27/02/2017 à 22:08, Georg Baum a écrit : Guillaume Munch wrote: AFAIR, the ECMAScript regexes are a proper subset of PCRE whereas there are incompatibilities between POSIX and PCRE. Moreover ECMAScript is the default for , so maybe it is better supported across compilers. This makes

Re: Automatic configuration of forward search

2017-03-04 Thread Guillaume Munch
Le 25/02/2017 à 18:09, Scott Kostyshak a écrit : On Wed, Aug 03, 2016 at 10:11:38PM -0400, Scott Kostyshak wrote: It would be nice if users did not have to configure forward search (although they should have the option to do so if they prefer). I see two possibilities: (1) Can configure.py do

Re: [LyX/master] Generalise the deletion protection mechanism from math to text (#9540)

2017-02-28 Thread Guillaume Munch
Le 28/02/2017 à 11:22, Jean-Marc Lasgouttes a écrit : I agree. My point is that the behavior should be predictable and as far as possible uniform between text and math. Note that I am actually not sure that special casing empty insets is a good idea. I makes things less predictable, and I do

Re: [LyX/master] Generalise the deletion protection mechanism from math to text (#9540)

2017-02-27 Thread Guillaume Munch
Le 27/02/2017 à 11:23, Jean-Marc Lasgouttes a écrit : Small questions though: - I create an empty \mathord inset in a formula, backspace does use deletion confirmation. Is this normal? This is the legacy behaviour, but can be changed. - if there are several cells (empty fraction) that are

Re: EmDash Problems (patch)

2017-02-26 Thread Guillaume Munch
Le 25/02/2017 à 21:09, Enrico Forestieri a écrit : Then, a decision has to still be taken as regards the original problem in this thread. I think that the patch Günther proposed on Jan. 25 is the less controversial one. I think you mean

Re: [LyX/master] Generalise the deletion protection mechanism from math to text (#9540)

2017-02-25 Thread Guillaume Munch
Le 25/02/2017 à 21:12, Guillaume Munch a écrit : Le 25/02/2017 à 20:07, Guenter Milde a écrit : On a similar note: could the "backspace at begin of inset dissolves it" feature be ported to mathed, too? This is a good idea, for consistency with math macros. If you are

Re: EmDash Problems (patch)

2017-02-25 Thread Guillaume Munch
../../../../src/frontends/qt4/GuiViewSource.cpp: In member function ‘void lyx::frontend::ViewSourceWidget::realUpdateView()’: ../../../../src/frontends/qt4/GuiViewSource.cpp:229:14: error: ambiguous overload for ‘operator!=’ (operand types are ‘const QChar’ and ‘char’) while (*oc != '\0'

Re: [LyX/master] Generalise the deletion protection mechanism from math to text (#9540)

2017-02-25 Thread Guillaume Munch
Le 25/02/2017 à 20:07, Guenter Milde a écrit : On 2017-02-18, Guillaume Munch wrote: Generalise the deletion protection mechanism from math to text (#9540) Now backspace and delete in text will select non-empty math and text insets before deleting them. This is consistent

Re: Regular expression search

2017-02-24 Thread Guillaume Munch
Le 24/02/2017 à 20:54, Kornel Benko a écrit : Am Freitag, 24. Februar 2017 um 17:30:39, schrieb Jean-Marc Lasgouttes src/lyxfind.cpp:escape_map.push_back(P("\\", "(?:|backslash)")); src/lyxfind.cpp:escape_map.push_back(P("~",

Re: [LyX/master] Generalise the deletion protection mechanism from math to text (#9540)

2017-02-24 Thread Guillaume Munch
Le 22/02/2017 à 14:59, Jean-Marc Lasgouttes a écrit : Le 18/02/2017 à 23:05, Guillaume Munch a écrit : commit 71623b88b2c613dd4ab826a9783a53e840bcd6e1 Author: Guillaume Munch <g...@lyx.org> Date: Sat Feb 18 19:12:55 2017 +0100 Generalise the deletion protection mechanism fro

Re: Memory leak in master?

2017-02-24 Thread Guillaume Munch
Le 22/02/2017 à 18:03, Jean-Marc Lasgouttes a écrit : Le 21/02/2017 à 20:13, Guillaume Munch a écrit : BTW, why don't you use Cache::contains in getLayout like you do for other cache uses? This is explained in the documentation of Cache::object. It is enough to check for a null pointer

Re: [LyX/master] Add tableaux to outliner

2017-02-21 Thread Guillaume Munch
Le 21/02/2017 à 19:28, Kornel Benko a écrit : Am Dienstag, 21. Februar 2017 um 18:52:28, schrieb Guillaume Munch <g...@lyx.org> Le 21/02/2017 à 18:49, Kornel Benko a écrit : Could it be made translatable? It should be already. It is nether in po-file nor in layouttransl

Re: Memory leak in master?

2017-02-21 Thread Guillaume Munch
Le 21/02/2017 à 07:19, Jean-Marc Lasgouttes a écrit : Le 21/02/2017 à 00:08, Guillaume Munch a écrit : Could you do the backport to stable? :) What about that? Please check especially the code related to LYX_USE_CXX11 in Cache.h. For the caching, I re-read the code to make sure that my hand

Re: Memory leak in master?

2017-02-21 Thread Guillaume Munch
Le 20/02/2017 à 18:25, Jean-Marc Lasgouttes a écrit : Le 10/02/2017 à 17:58, Guillaume Munch a écrit : There's more data, but I am not sure how to interpret the results that massif-visualizer shows. If you send the file or make it available, I can take a look. Here it is. But if it is like

Re: [LyX/master] Add tableaux to outliner

2017-02-21 Thread Guillaume Munch
Le 21/02/2017 à 18:49, Kornel Benko a écrit : Could it be made translatable? It should be already.

Re: [LyX/master] Add tableaux to outliner

2017-02-21 Thread Guillaume Munch
Le 21/02/2017 à 07:11, Juergen Spitzmueller a écrit : commit ed233663008608e5e32a3c675ade790ea63f0a24 Author: Juergen Spitzmueller Date: Tue Feb 21 07:11:23 2017 +0100 Add tableaux to outliner --- +OutlinerName tableau"Tableaux" #no AddToToc (built-in) + Thanks, I

Re: Standalone Math Editor

2017-02-21 Thread Guillaume Munch
Le 20/02/2017 à 07:44, Wei-Ting Lin a écrit : Thanks a lot! I'm trying Lyxserver and Lyx functions. They are amazing. I can just send commands to open a document and insert a display math! One problem seems that there is no Lyx function allowing me to get the content of math. I can use select

Re: Memory leak in master?

2017-02-20 Thread Guillaume Munch
Le 20/02/2017 à 18:27, Jean-Marc Lasgouttes a écrit : Le 13/02/2017 à 20:55, Jean-Marc Lasgouttes a écrit : What I mean is that you can easily force QCache into shared ownership by replacing QCache with QCache and create the appropriate

Re: Standalone Math Editor

2017-02-18 Thread Guillaume Munch
Le 18/02/2017 à 06:44, Guenter Milde a écrit : On 2017-02-18, Wei-Ting Lin wrote: Your suggestions are valuable and important for me. I never think Lyx is not lightweight. Actually, I'm always satisfied with its speed. I just think to type math equations we don't need a full Lyx. But you're

Re: Standalone Math Editor

2017-02-17 Thread Guillaume Munch
Le 17/02/2017 à 07:17, Wei-Ting Lin a écrit : Hi all, I have used Lyx for several years. This is a really amazing software. However, many people still write LaTex with text editors. That usually means when we cowork on some article, we have to write LaTex directly. This is ok. However,

Re: alpha dot

2017-02-15 Thread Guillaume Munch
Le 15/02/2017 à 13:46, Guenter Milde a écrit : On 2017-02-15, Guillaume Munch wrote: [-- Type: text/plain, Encoding: 8bit --] Le 15/02/2017 à 05:02, Scott Kostyshak a écrit : On Wed, Jan 04, 2017 at 09:00:44AM +0100, Wolfgang Engelmann wrote: On 03.01.2017 21:32, Scott Kostyshak wrote

Re: alpha dot

2017-02-15 Thread Guillaume Munch
ne. Guillaume >From 45d8c5edc2c8e26065468c691f90a1d50ddc20a9 Mon Sep 17 00:00:00 2001 From: Guillaume Munch <g...@lyx.org> Date: Mon, 28 Nov 2016 03:27:30 +0100 Subject: [PATCH 1/3] Increase thickness of math delimiter with zoom --- src/mathed/InsetMathAMSArray.cpp | 15 ++- src/mathed

Re: Reproducible crash with attached template

2017-02-01 Thread Guillaume Munch
(Sending again this message from 21/01/2017 which neither bounced nor made it to the list.) Le 26/01/2017 à 20:05, Richard Heck a écrit : This looks familiar. There was a crash a month or two ago, maybe, that also happened during reload (see #9 below) due to invalid cursors. Guillaume, I

Re: [LyX/master] Collect the outliner names for the children's tocs

2017-02-01 Thread Guillaume Munch
Le 21/01/2017 à 04:23, Scott Kostyshak a écrit : LyX places the cursor at the correct spot, but the outliner is collapsed. Before, the outliner was not collapsed. There are other changes of behavior that can be seen, using this file. For example, just clicking on "Section 2" or "Section 5", the

Re: [LyX/master] Collect the outliner names for the children's tocs

2017-01-25 Thread Guillaume Munch
Le 21/01/2017 à 04:23, Scott Kostyshak a écrit : On Sat, Jan 14, 2017 at 11:16:29PM +0100, Guillaume Munch wrote: commit 461fda9ca9a8079f235fe6d26031aa6b9c5ff36e Author: Guillaume Munch <g...@lyx.org> Date: Sat Jan 14 18:40:58 2017 +0100 Collect the outliner names for the children'

Re: row-breaking question

2017-01-25 Thread Guillaume Munch
Le 21/01/2017 à 20:22, Jean-Marc Lasgouttes a écrit : Le 21/01/2017 à 19:33, Scott Kostyshak a écrit : The attached sequence of screenshots show the phases of row-breaking that happens as I keep typing " abc" in the footnote. The word "OLS" seems to jump around a lot and I find that (mildly)

Re: [CONFIRMED] Display Problem in Stable with \notin, etc.

2017-01-25 Thread Guillaume Munch
Le 19/01/2017 à 16:04, Jean-Marc Lasgouttes a écrit : Here is what happened 1/ I change randomly (!) the spacing of math equations in the MathRow work 2/ as a consequence the formulas in lib/symbols are often wrong 3/ I fix the problem with arabic test at e832d2e90f 4/ I do a new round of

Re: EmDash Problems (patch)

2017-01-25 Thread Guillaume Munch
Le 25/01/2017 à 22:51, Guenter Milde a écrit : On 2017-01-25, Enrico Forestieri wrote: The appearance on screen is the same but we always output "--" and "---", except on text exports where the unicode characters are output. This should ensure maximum compatibility without cluttering the

Re: [LyX/2.2.x] Assure long tooltip is correctly formatted.

2017-01-14 Thread Guillaume Munch
Le 14/01/2017 à 16:26, Kornel Benko a écrit : I don't see it. Here it displays as a 6-liner in Slovak translation. QT5.7 OS Mint17.3 desktop MATE Kornel Thanks Kornel and Jürgen for the replies. I will stop my investigation but do not hesitate to report issues like this in the

Re: [LyX/master] Add an "Automatic" bibliography processor pref option

2017-01-14 Thread Guillaume Munch
Le 13/01/2017 à 23:28, Richard Heck a écrit : Format change? It does not look like it to me. However: /// Return the actual bibtex command (lyxrc or buffer param) - std::string const & bibtexCommand() const; + std::string const bibtexCommand() const; I saw const-value

Re: [LyX/2.2.x] Assure long tooltip is correctly formatted.

2017-01-14 Thread Guillaume Munch
Le 14/01/2017 à 10:07, Jürgen Spitzmüller a écrit : Am Freitag, den 13.01.2017, 22:02 +0100 schrieb Guillaume Munch: Weird, it displays fine here at 119dfcb1. Are there precise steps that I must follow to reproduce the bug? * Open the BibTeX inset dialog * Hit "Add" * On the sub-dia

Re: [LyX/2.2.x] Assure long tooltip is correctly formatted.

2017-01-13 Thread Guillaume Munch
Le 13/01/2017 à 11:32, Jürgen Spitzmüller a écrit : Am Freitag, den 13.01.2017, 11:11 +0100 schrieb Guillaume Munch: (Independently, I will try to see why this was not called automatically in master.) OK. Maybe because this is a sub-dialog? Weird, it displays fine here at 119dfcb1

Re: [LyX/2.2.x] Assure long tooltip is correctly formatted.

2017-01-13 Thread Guillaume Munch
Le 13/01/2017 à 09:09, Juergen Spitzmueller a écrit : commit ca9c8dbde1d8a3d4ceeba990bbfcab17bfecb940 Author: Juergen Spitzmueller Date: Fri Jan 13 09:07:44 2017 +0100 Assure long tooltip is correctly formatted. Amendment to ffb195b5e9fa ... +

Re: dynamic quotes

2017-01-07 Thread Guillaume Munch
Le 05/01/2017 à 06:39, Jürgen Spitzmüller a écrit : Am Mittwoch, den 04.01.2017, 23:27 +0100 schrieb Guillaume Munch: There I do not follow anymore: if without the checkbox you would need 12 key bindings, how is the checkbox helping? Or do you mean that even the checkbox does not address your

Re: dynamic quotes

2017-01-04 Thread Guillaume Munch
Le 04/01/2017 à 17:54, Jürgen Spitzmüller a écrit : Let me rephrase: This is style-dependent. Some styles require you to use "foreign" quotes for all foreign text, some for "whole sentences". Most German style sheets I know, however, require you to use the same quotation marks (of the matrix

Re: dynamic quotes

2017-01-04 Thread Guillaume Munch
Le 04/01/2017 à 15:42, Jürgen Spitzmüller a écrit : Am Mittwoch, den 04.01.2017, 15:02 +0100 schrieb Guillaume Munch: Starting with the important point: So, here are two suggestions for improving dynamic quotes, good enough (AFAIU) to be a default behaviour, sparing the need for a document

Re: dynamic quotes

2017-01-04 Thread Guillaume Munch
Le 04/01/2017 à 14:23, Jürgen Spitzmüller a écrit : Am Mittwoch, den 04.01.2017, 13:52 +0100 schrieb Guillaume Munch: I find too that the above does not make the case for a new document setting that changes the default behaviour of a LFUN. Note that the quote document setting has done

Re: [LyX/master] Add ability to use refstyle's plural and capitalization features.

2017-01-04 Thread Guillaume Munch
Le 03/01/2017 à 04:40, Richard Heck a écrit : commit 73f59e87bd62e00bbfbceee59b8876aa59e75f58 Author: Richard Heck Date: Sat Jun 18 19:29:15 2016 -0400 Add ability to use refstyle's plural and capitalization features. --- lib/lyx2lyx/lyx_2_3.py| 67

Re: dynamic quotes

2017-01-04 Thread Guillaume Munch
Le 01/01/2017 à 18:29, Guenter Milde a écrit : On 2016-12-31, Jürgen Spitzmüller wrote: Is there a use case for the document specific setting? (I.e. is there someone in need for one keybinding inserting "dynamic" quote insets in one document but "static" quote insets in another document?)

Re: [LyX/master] TocWidget: fix an erroneous collapse and optimise updates based on profiling

2017-01-03 Thread Guillaume Munch
Le 31/12/2016 à 16:13, Jean-Marc Lasgouttes a écrit : Le 31/12/2016 à 15:48, Guillaume Munch a écrit : Using weak pointers instead of naked pointers could be used to let you know when an inset has been destroyed. The cursor could then check if all slices are valid, and if not then fix itself

Re: [LyX/master] TocWidget: fix an erroneous collapse and optimise updates based on profiling

2016-12-31 Thread Guillaume Munch
Le 30/12/2016 à 21:02, Richard Heck a écrit : On 12/30/2016 12:15 PM, Guillaume Munch wrote: Thanks for the patch. It is the same as calling fixIfBroken in GuiView::structureChanged (as attached) which I agree becomes even simpler. But, provided one accepts the idea that DocIterators hold

Re: [LyX/master] TocWidget: fix an erroneous collapse and optimise updates based on profiling

2016-12-31 Thread Guillaume Munch
Le 30/12/2016 à 22:48, Jean-Marc Lasgouttes a écrit : At some time where DEPM was causing issues, there was the idea of registering cursors with their buffer. This would allow to keep track of what is happening. Another possibility would be to register insets, so that one can know when

Re: Memory leak with WordList

2016-12-31 Thread Guillaume Munch
Le 31/12/2016 à 13:16, Jean-Marc Lasgouttes a écrit : WordList leaks all its contents on exit, which is very impolite (even though the memory will be reclaimed anyway). This hides real memory leaks that may happen elsewhere. Snippet of Valgrind output for stable below. The WordList object

Re: dynamic quotes

2016-12-30 Thread Guillaume Munch
Le 30/12/2016 à 23:39, Guenter Milde a écrit : Dear Jürgen, dear LyX developers, I am glad to see the "dynamic quotes" and optional arguments to the quote-insert LFUN are implemented. Now, M-x quote-insert * * dynamic inserts a quote-inset that * is rendered blue in the GUI, so we can see

Re: [LyX/master] TocWidget: fix an erroneous collapse and optimise updates based on profiling

2016-12-30 Thread Guillaume Munch
Le 30/12/2016 à 17:11, Richard Heck a écrit : On 12/29/2016 01:21 AM, Guillaume Munch wrote: Le 27/12/2016 à 23:11, Scott Kostyshak a écrit : On Tue, May 31, 2016 at 01:15:38AM +0200, Guillaume Munch wrote: commit 1cc14a31ca8320d881b674f93c34a09cf1666cca Author: Guillaume Munch <g...@lyx.

Re: [LyX/master] TocWidget: fix an erroneous collapse and optimise updates based on profiling

2016-12-30 Thread Guillaume Munch
Le 30/12/2016 à 17:05, Jean-Marc Lasgouttes a écrit : Le 29/12/2016 à 07:21, Guillaume Munch a écrit : Le 27/12/2016 à 23:11, Scott Kostyshak a écrit : On Tue, May 31, 2016 at 01:15:38AM +0200, Guillaume Munch wrote: commit 1cc14a31ca8320d881b674f93c34a09cf1666cca Author: Guillaume Munch &l

Re: [LyX/master] TocWidget: fix an erroneous collapse and optimise updates based on profiling

2016-12-28 Thread Guillaume Munch
Le 27/12/2016 à 23:11, Scott Kostyshak a écrit : On Tue, May 31, 2016 at 01:15:38AM +0200, Guillaume Munch wrote: commit 1cc14a31ca8320d881b674f93c34a09cf1666cca Author: Guillaume Munch <g...@lyx.org> Date: Mon May 30 21:42:08 2016 +0100 TocWidget: fix an erroneous collapse and op

Re: master fails to compile with Qt 5.8dev

2016-12-27 Thread Guillaume Munch
Le 25/11/2016 à 05:20, Scott Kostyshak a écrit : I occassionally build the Qt development version to test various things. I currently get the following error when building LyX with Qt 5.8dev: /home/vbox/lyxbuilds/master/repo/src/frontends/qt4/GuiViewSource.cpp:224:14: error: ambiguous

Re: Hardening LyX - AppArmor patch

2016-12-12 Thread Guillaume Munch
Le 11/12/2016 à 01:16, Tommaso Cucinotta a écrit : Hi, please, find attached a rework of the AppArmor patch to harden/confine possible side effects of converters via an AppArmor profile on Linux. The major challenge here is to ship with a meaningful AA profile -- I'd be happy to hear feedback

Re: #10481: Hardening LyX against potential misuse

2016-12-08 Thread Guillaume Munch
Le 05/12/2016 à 08:53, Tommaso Cucinotta a écrit : On 04/12/2016 18:51, Guillaume Munch wrote: Le 04/12/2016 à 18:06, Tommaso Cucinotta a écrit : On 28/11/2016 00:42, Tommaso Cucinotta wrote: On 27/11/2016 13:52, Guillaume Munch wrote: * Converters>Security is located below the conver

Re: #10481: Hardening LyX against potential misuse

2016-12-08 Thread Guillaume Munch
Le 05/12/2016 à 08:36, Tommaso Cucinotta a écrit : On 04/12/2016 18:37, Guillaume Munch wrote: If there are n graphics, then are there n dialogs when opening the file for the first time? it asks as many times as there are (uncached) graphics needing 'needauth' converters,unless you hit

Re: compilation error with current master

2016-12-08 Thread Guillaume Munch
Le 07/12/2016 à 13:57, Jan Niklas Hasse a écrit : Hi, try adding #include to Encoding.cpp. Yes On Wed, 7 Dec 2016, at 00:36, Uwe Stöhr wrote: With today's master I get this compilation error: Encoding.cpp D:\LyXGit\Master\src\Encoding.cpp(267): error C3861: 'back_inserter':

Re: LyX 2.2 slowness

2016-12-08 Thread Guillaume Munch
Le 08/12/2016 à 16:07, Jean-Marc Lasgouttes a écrit : Also, it would be nice to know what are the callers of freettype that consume the most time. As a reminder here is where I got last time with kcachegrind: https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg194401.html The caching in

Re: [LyX/master] Cosmetic changes to the needauth dialogs

2016-12-08 Thread Guillaume Munch
Le 04/12/2016 à 19:59, Enrico Forestieri a écrit : On Sun, Dec 04, 2016 at 06:38:42PM +0100, Guillaume Munch wrote: +// FIXME: This dialog has issues with line breaking and size, in particular with +// html. But it could easily be reimplemented as a QMessageBox using +// QMessageBox

Re: Crash in stable

2016-12-04 Thread Guillaume Munch
Le 04/12/2016 à 18:48, Enrico Forestieri a écrit : I am confused now. You make a convoluted patch justifying it by saying that it was done in view of a proper fix. The simpler one-liner has the same effect and actually would not be possible if the proper fix was in place. Given that it is not

Re: #10481: Hardening LyX against potential misuse

2016-12-04 Thread Guillaume Munch
Le 04/12/2016 à 18:06, Tommaso Cucinotta a écrit : On 28/11/2016 00:42, Tommaso Cucinotta wrote: On 27/11/2016 13:52, Guillaume Munch wrote: * Converters>Security is located below the converter configuration, which leads to think that they are converter properties instead of global setti

Re: #10481: Hardening LyX against potential misuse

2016-12-04 Thread Guillaume Munch
Le 28/11/2016 à 00:42, Tommaso Cucinotta a écrit : eh eh, what about remembering 'needauth' (as well as cursor pos) only for those files in the recent files list :-), and collapse the 3 lists into a single one, and a single session section ? Two problems I see with this idea is that migrating

Re: Crash in stable

2016-12-04 Thread Guillaume Munch
Le 04/12/2016 à 17:04, Enrico Forestieri a écrit : Weak arguments, given that you say the patch was written with the proper fix in mind (which is not in stable). It is probably clear to Enrico (I hope) but maybe less to people who did not follow the discussions and the mentioned commits too

Re: Crash in stable

2016-12-04 Thread Guillaume Munch
Le 04/12/2016 à 12:25, Enrico Forestieri a écrit : On Sun, Dec 04, 2016 at 11:57:29AM +0100, Guillaume Munch wrote: Le 04/12/2016 à 00:57, Enrico Forestieri a écrit : On Sat, Dec 03, 2016 at 11:59:33PM +0100, Guillaume Munch wrote: This is the same as https://www.mail-archive.com/lyx-devel

Re: Crash in stable

2016-12-04 Thread Guillaume Munch
Le 04/12/2016 à 00:57, Enrico Forestieri a écrit : On Sat, Dec 03, 2016 at 11:59:33PM +0100, Guillaume Munch wrote: This is the same as https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg196794.html. I have now backported the fix. Hmmm... a quite convoluted patch. There was a one-liner

Re: Crash-Reporting on Mac

2016-12-03 Thread Guillaume Munch
Le 30/11/2016 à 16:48, Jean-Marc Lasgouttes a écrit : a useless backtrace If you have the symbols at hand, then you can get them by hand. For instance if you have compiled in debug mode, then you can run gdb as you do usually, only after the fact, and get the symbols with "info symbols

Re: Crash in stable

2016-12-03 Thread Guillaume Munch
Le 02/12/2016 à 01:08, Richard Heck a écrit : On 12/01/2016 06:44 PM, Enrico Forestieri wrote: On Thu, Dec 01, 2016 at 07:50:19PM +0100, Enrico Forestieri wrote: This only occurs with 2.2.3dev (not with 2.2.2, nor with 2.3.0dev): 1) Start lyx, make sure the source pane is closed 2) File->New

Re: Qt assertion when trying to view "Hangul Syllables" in special character insertion

2016-12-03 Thread Guillaume Munch
Le 02/12/2016 à 08:03, Scott Kostyshak a écrit : On Sat, Nov 19, 2016 at 12:41:13AM +0100, Guillaume Munch wrote: I cannot reproduce with the provided info (2.3dev & Qt5). A bisect led to b3bed292. The attached patch fixes it for me, although I don't understand my patch. Hello S

Re: #10481: Hardening LyX against potential misuse

2016-11-27 Thread Guillaume Munch
Hi Tommaso, I have been following your work on this issue with interest. Thank you, this is something that was much needed. Making AppArmor work would be great too, but I suspect that it is going to be hard to have a configuration which is both secure and without hassle to the user, especially

Re: #10481: Hardening LyX against potential misuse

2016-11-27 Thread Guillaume Munch
Le 25/11/2016 à 20:50, Scott Kostyshak a écrit : On Fri, Nov 25, 2016 at 02:32:37PM -0500, Scott Kostyshak wrote: I think the line-breaking in the warning dialog should be improved. The horizontal width is larger than my 13 in. screen. See attached. Note that the linebreaking on the *other*

Re: Remove templatization from bformat() ?

2016-11-26 Thread Guillaume Munch
Le 24/11/2016 à 00:33, Tommaso Cucinotta a écrit : Hi, while playing with strings, I've just run into a mysterious linking error [1] which, after a bit of digging, turned out to be decrypted as [2]. Basically, [2] is obtained by removing all templatization code for bformat() in lstrings.h. All

Re: [LyX/master] Citation dialog redesign

2016-11-25 Thread Guillaume Munch
Le 25/11/2016 à 21:04, Scott Kostyshak a écrit : I think that "Search as you type" should be default because (1) this is consistent with similar dialogs such as the cross-reference dialog and the search in LyX preferences/document settings and (2) there is no "search" button as there was in the

Re: [LyX/master] Improve fractions bar

2016-11-21 Thread Guillaume Munch
Le 22/11/2016 à 00:32, Guillaume Munch a écrit : Le 21/11/2016 à 17:33, Jean-Marc Lasgouttes a écrit : * did you try to look at what TeX does and see what can be picked from there? The relevant rules are 15(a-e). It is not funny reading, but last time I looked I conlcuded that part

Re: [LyX/master] Improve fractions bar

2016-11-21 Thread Guillaume Munch
Le 21/11/2016 à 17:33, Jean-Marc Lasgouttes a écrit : It is nice to give some love to \frac (it was somewhere on my to do list). I have not tried it yet, but I have questions: * why not use FontMetrics::lineWidth for the witdth of the line? You do not want to use the same width for a fraction

Re: [LyX/master] mathedSymbolDim only needs a MathBase

2016-11-21 Thread Guillaume Munch
Le 21/11/2016 à 17:35, Jean-Marc Lasgouttes a écrit : Somewhere on my todo list I wanted to make MetricsInfo inherit from MetricsBase, in order to avoid this stupid mi.base thing. Do you see a reason not to do it? Well, do you see a reason to do it? What is wrong with composition in this

Re: [LyX/master] Let math mu skips scale with zoom

2016-11-21 Thread Guillaume Munch
Le 21/11/2016 à 17:28, Jean-Marc Lasgouttes a écrit : Do you really see a difference with this patch? What makes you thing that theFontMetrics(font).em() does not scale with zoom? Looking at the code, the way zoom is taken in account on this code path in Length is pretty ugly. I find the

Re: [LyX/master] On-screen justification: stretch in proportion with the em, up to a limit

2016-11-21 Thread Guillaume Munch
Le 21/11/2016 à 11:56, Jean-Marc Lasgouttes a écrit : Le 21/11/2016 à 11:49, Guillaume Munch a écrit : Le 21/11/2016 à 11:45, Jean-Marc Lasgouttes a écrit : I agree, but I could not figure it out. Do you have a MWE? That's the point, I don't. I can add a terminal error message to help

Re: [LyX/master] On-screen justification: stretch in proportion with the em, up to a limit

2016-11-21 Thread Guillaume Munch
Le 21/11/2016 à 11:45, Jean-Marc Lasgouttes a écrit : I agree, but I could not figure it out. Do you have a MWE? That's the point, I don't. I can add a terminal error message to help find one in the future if you think it is going to help.

Re: [LyX/master] On-screen justification: stretch in proportion with the em, up to a limit

2016-11-21 Thread Guillaume Munch
Le 21/11/2016 à 09:06, Scott Kostyshak a écrit : On Mon, Nov 21, 2016 at 01:04:10AM +0100, Guillaume Munch wrote: But with your recipe I got the attached (unrelated) segfault when closing LyX. A bisect led me to fb264663. Thank you for doing that.

Re: [LyX/master] On-screen justification: stretch in proportion with the em, up to a limit

2016-11-21 Thread Guillaume Munch
Le 21/11/2016 à 10:02, Jean-Marc Lasgouttes a écrit : Can you expand on when w<0 happens? I think that fixing problems (other than with an explicit workaround) is often a better idea in the long run. I agree, but I could not figure it out.

Re: [LyX/master] On-screen justification: stretch in proportion with the em, up to a limit

2016-11-20 Thread Guillaume Munch
Le 21/11/2016 à 00:51, Guillaume Munch a écrit : Le 20/11/2016 à 22:47, Scott Kostyshak a écrit : After this commit I get an assertion. To reproduce: 1. Open lib/doc/Math.lyx 2. ctrl+a to select all. 3. Insert > Branch > Insert New Branch. Call it "hello" and press

Re: [LyX/master] On-screen justification: stretch in proportion with the em, up to a limit

2016-11-20 Thread Guillaume Munch
Le 20/11/2016 à 22:47, Scott Kostyshak a écrit : After this commit I get an assertion. To reproduce: 1. Open lib/doc/Math.lyx 2. ctrl+a to select all. 3. Insert > Branch > Insert New Branch. Call it "hello" and press OK. Hi Scott, Unfortunately I cannot reproduce. But with your recipe I

Re: Qt assertion when trying to view "Hangul Syllables" in special character insertion

2016-11-18 Thread Guillaume Munch
Le 19/11/2016 à 00:16, Richard Heck a écrit : On 11/18/2016 04:01 PM, Scott Kostyshak wrote: If I go to Insert > Special Character > Symbols... and then go to "Hangul Syllables", I get an assertion. On Qt 5 with custom-compiled Qt: ASSERT: "last >= first" in file

Re: New warning on master

2016-11-09 Thread Guillaume Munch
I will gladly let you handle everything, then :) Done.

Re: New warning on master

2016-11-09 Thread Guillaume Munch
Le 09/11/2016 à 20:46, Enrico Forestieri a écrit : On Wed, Nov 09, 2016 at 11:46:33AM +0100, Jean-Marc Lasgouttes wrote: When using dialogs (prefs for example) with master, I get some QMetaObject::connectSlotsByName: No matching signal for on_bufferViewChanged()

Re: New warning on master

2016-11-09 Thread Guillaume Munch
Le 09/11/2016 à 15:58, Jean-Marc Lasgouttes a écrit : Le 09/11/2016 à 15:54, Scott Kostyshak a écrit : On Wed, Nov 09, 2016 at 11:46:33AM +0100, Jean-Marc Lasgouttes wrote: When using dialogs (prefs for example) with master, I get some Does this ring a bell for somebody? I don't see this

Re: [patch] On-screen justification: stretch in proportion with the em, up to a limit

2016-11-06 Thread Guillaume Munch
Le 06/11/2016 à 16:11, Jean-Marc Lasgouttes a écrit : Something I meant to mention: shall we add some on screen cue that the row has not been completely stretched ? JMarc Most of the times it is already clear from the other lines that the text is justified. In addition, on-screen

Re: [patch] On-screen justification: stretch in proportion with the em, up to a limit

2016-11-06 Thread Guillaume Munch
Le 29/08/2016 à 14:16, Jean-Marc Lasgouttes a écrit : The patch looks good. It's in at b30f8d3c4b

Re: please revert: [LyX/2.2.x] Better title for ViewSource

2016-10-25 Thread Guillaume Munch
Le 24/10/2016 à 23:55, Uwe Stöhr a écrit : Am 24.10.2016 um 00:38 schrieb Guillaume Munch: You are not being rude at all, in fact you are quite polite. OK. I felt I was rude. I thought about it and began to update the docs when I realized what an impact these renaming have. Then I searched

Re: [LyX/master] Correctly track ulem commands with change tracking

2016-10-23 Thread Guillaume Munch
Le 24/10/2016 à 01:00, Enrico Forestieri a écrit : On Sun, Oct 23, 2016 at 11:52:55PM +0200, Guillaume Munch wrote: The code does look fragile to me. I do not think that asking that developers care about maintainability is being overzealous. Then, maybe I am mistaken about the code and you got

Re: please revert: [LyX/2.2.x] Better title for ViewSource

2016-10-23 Thread Guillaume Munch
Le 23/10/2016 à 23:20, Uwe Stöhr a écrit : commit a36706c3ffe9570588962a5ad3206d57e63ffcfd Author: Guillaume Munch <g...@lyx.org> Date: Sun Aug 28 21:57:17 2016 +0100 Better title for ViewSource Sorry for being quite rude here: I am strictly opposed to these changes. LyX

Re: [LyX/master] Correctly track ulem commands with change tracking

2016-10-23 Thread Guillaume Munch
Le 23/10/2016 à 22:53, Enrico Forestieri a écrit : On Sun, Oct 23, 2016 at 07:02:31PM +0200, Guillaume Munch wrote: Le 23/10/2016 à 18:38, Enrico Forestieri a écrit : commit dea5ba16de1b98d93cf30ab65119bc2364a7ac2b Author: Enrico Forestieri <for...@lyx.org> Date: Sun Oct 23 18:23:4

Re: [LyX/master] Correctly track ulem commands with change tracking

2016-10-23 Thread Guillaume Munch
Le 23/10/2016 à 19:55, Richard Heck a écrit : On 10/23/2016 01:02 PM, Guillaume Munch wrote: Le 23/10/2016 à 18:38, Enrico Forestieri a écrit : commit dea5ba16de1b98d93cf30ab65119bc2364a7ac2b Author: Enrico Forestieri <for...@lyx.org> Date: Sun Oct 23 18:23:41 2016 +0200 Correctly

  1   2   3   4   5   6   7   8   9   10   >