Multiple login BUG to same targets in Fedora 19

2013-12-05 Thread Boaz Harrosh
Hi iscsi guys I have an annoying problem on Fedora 19. Though it must be a problem on Fedora + new systemd I think it also exposes a bug in iscsiadm and/or Kernel login system. I have a target system that uses tgtd to export multiple targets from the same IP address. Note that this is multiple

Re: Multiple login BUG to same targets in Fedora 19

2013-12-05 Thread Boaz Harrosh
On 12/06/2013 01:18 AM, Mike Christie wrote: On 12/05/2013 05:43 AM, Boaz Harrosh wrote: Hi iscsi guys But what I do not understand is how the iscsiadm lets multiple logins to the same exact target+initiator combination? Is this a bug in the bootup system, because manually running

Re: Multiple login BUG to same targets in Fedora 19

2013-12-05 Thread Boaz Harrosh
On 12/06/2013 01:51 AM, Chris Leech wrote: On Thu, Dec 05, 2013 at 05:18:35PM -0600, Mike Christie wrote: On 12/05/2013 05:43 AM, Boaz Harrosh wrote: Hi iscsi guys into the targets. Which is interesting BTW, on the machine that shows the problem above with multiple devices of the same

Re: Automatic deleting of LUNs possible?

2012-11-02 Thread Boaz Harrosh
On 10/31/2012 10:32 PM, Michael Christie wrote: On Oct 30, 2012, at 7:31 PM, amit.ut...@gmail.com wrote: I apologize if this has been asked in the list before, I did some research but did not find a clear answer/recommendation. Currently, I use udev to monitor new devices added by the

Re: Automatic deleting of LUNs possible?

2012-11-02 Thread Boaz Harrosh
On 11/02/2012 12:47 PM, Mike Christie wrote: Yeah, I updated the iscsi dev loss tmo patch and posted it to the list. I think I hit some bugs with lots of sessions and lots of removals at the same time due to some workqueue/threading stuff or scsi locking issues. I did not get a chance to look

Re: Error codes/return values of iscsiadm commands

2010-07-14 Thread Boaz Harrosh
On 07/14/2010 08:23 PM, Mike Christie wrote: On 07/14/2010 10:49 AM, Boaz Harrosh wrote: On 07/14/2010 05:52 PM, Mike Christie wrote: On 07/14/2010 05:30 AM, HIMANSHU wrote: How can we know error status of iscsiadm commands like discovery,login,logout. I think,all of them directly returns

Re: iscsi performance via 10 Gig

2010-05-26 Thread Boaz Harrosh
On 05/26/2010 09:52 PM, Vladislav Bolkhovitin wrote: Boaz Harrosh, on 05/26/2010 10:45 PM wrote: On 05/26/2010 09:42 PM, Vladislav Bolkhovitin wrote: Taylor, on 05/26/2010 09:32 PM wrote: I'm curious what kind of performance numbers people can get from their iscsi setup, specifically via 10

Re: [PATCH 1/2] RFC: Proposal for BSG Interface

2010-03-18 Thread Boaz Harrosh
On 03/17/2010 08:06 PM, Jayamohan Kallickal wrote: This patch contains the bsg interface based on the bsg interface in FC. What? where? who? how? why? w*\? ... You are proposing a new Kernel ABI/API here right. I think it is not acceptable without a detailed documentation, including every

Re: Can I tell if my iSCSI is already mounted somewhere else?

2010-02-24 Thread Boaz Harrosh
On 02/24/2010 09:14 AM, guymatz wrote: Hello, I would really love to be able to tell if (and ideally where!) an iSCSI LUN (right word here?) is mounted. I don't want to mount it twice . . ! Any way to do this? Is there an ideal way to do iSCSI accounting? Thanks a lot, Guy once you

Re: How to make a 2.6..*_compat.patch without sub-directory?

2009-12-15 Thread Boaz Harrosh
On 12/14/2009 08:25 PM, Yangkook Kim wrote: I posted similar message on other thread, but let me ask the same question with diffrent tittle. I want to make a kernel compat patch without kernel/ sub-directory. I used git diff to output the patch, but each header of outputted patch includes

Re: Unable to apply kernel/2.6.26_compat.patch from git master branch

2009-12-09 Thread Boaz Harrosh
On 12/08/2009 09:15 PM, Yangkook Kim wrote: Hi, you are back. I think for your patch, you want to include open_iscsi_compat.h in it. I included open_iscsi_compat.h and created a patch. Please check it. I have a quetion about creating a patch agaist files in sub-directory. I used git

Re: [PATCH] Fix compilation warnings in usr/kernel code

2009-09-07 Thread Boaz Harrosh
On 09/03/2009 08:02 PM, Mike Christie wrote: On 09/03/2009 11:21 AM, Erez Zilber wrote: Fix compilation warnings and modify the Makefiles to treat warnings as errors. Signed-off-by: Erez Zilber erezzi.l...@gmail.com Thanks. I get this compilation error on fedora 10. We used to

Re: same volume two different hosts

2009-08-04 Thread Boaz Harrosh
On Fri, Jul 31, 2009 at 7:12 PM, nick nicholasfredd...@gmail.com mailto:nicholasfredd...@gmail.com wrote: Hi All, I would like to knw if i can present same volume to two hosts? I am using Stonefly Voyager as SAN and the host would be Xen. Thanks in Advance Nick

Re: [PATCH] libiscsi: Check for CmdSN window before sending data

2009-07-23 Thread Boaz Harrosh
On 07/23/2009 12:24 PM, Mike Christie wrote: But you still might be hitting a problem where the target does not like data-outs when it closed the window. Maybe they interpreted the RFC differently. You should ask the HP target guys for more info. Also your patch might be working because

Re: [PATCH] libiscsi: Check for CmdSN window before sending data

2009-07-23 Thread Boaz Harrosh
On 07/23/2009 07:01 PM, Mike Christie wrote: Boaz Harrosh wrote: I think I can replicate this problem now too. It was by accident. I am using a EQL target remotely (I am in the middle of the US and the target is on the west coast so there is a good deal of space between us

Re: iscsi_sna_lte vs RFC1982

2009-07-06 Thread Boaz Harrosh
On 07/06/2009 02:33 PM, Hannes Reinecke wrote: Hi Mike, debugging my infamous iSCSI IO stall I stumbled across this: drivers/scsi/libiscsi.c: /* Serial Number Arithmetic, 32 bits, less than, RFC1982 */ static int iscsi_sna_lt(u32 n1, u32 n2) { return n1 != n2 ((n1 n2 (n2 -

Re: compile the latest version debian ubuntu

2009-06-24 Thread Boaz Harrosh
On 06/23/2009 11:11 AM, Stefan wrote: Am Montag 22 Juni 2009 13:51:17 schrieb Stefan: Hello all, sorry, its half solved. Its now running on ubuntu jaunty but not on debian lenny. I did what did on the ubuntu machine: aptitude install open-iscsi untar new package make user

Re: compile the latest version debian ubuntu

2009-06-22 Thread Boaz Harrosh
On 06/22/2009 10:43 AM, Stefan wrote: Am Montag 22 Juni 2009 08:59:04 schrieb Boaz Harrosh: I think for 2.6.28 Kernel the best is to run with built-in iscsi modules and only compile and install the install_user from open-iscsi. I reinstalled kernel and did the install_user install

Re: compile the latest version debian ubuntu

2009-06-22 Thread Boaz Harrosh
On 06/22/2009 12:57 PM, Stefan wrote: Am Montag 22 Juni 2009 11:31:28 schrieb Boaz Harrosh: Could you redo the discovery again, with a --login. some thing like: []$ iscsiadm -m discovery -t sendtargets -p 10.100.100.30 --login send the output of that and also the iscsiadm -m session -P 3

Re: iSCSI initiator implementation question

2009-06-18 Thread Boaz Harrosh
On 06/18/2009 10:56 AM, Joachim Worringen wrote: Greetings, I tried to use Open-iSCSI with a non-tcp socket type and failed (timeout after connection has been established). Looking at the source, the reason is obvious: for sending data (iscsi_send()), the function pointers from sock-sk

Re: [pnfs] build open-iscsi error

2009-06-14 Thread Boaz Harrosh
On 06/12/2009 06:49 PM, sun_peix...@emc.com wrote: I have installed the latest linux.2.6.30-pnfs on my client. All modules and headers have been installed. When I was build the open-iscsi, I got the following error. My linux-pnfs source and open-iscsi source are all located under

Re: RFC: do we need a new list for kernel patches

2009-06-14 Thread Boaz Harrosh
On 06/11/2009 08:41 PM, Mike Christie wrote: Hey, It seems like we have a lot of members on the list that are not kernel developers, but we now have 5 iscsi drivers (qla4xxx, bnx2i, cxgb3i, iscsi_tcp and ib_iser) with another being written. So it seems like we are going to have lots of

Re: RFC: do we need a new list for kernel patches

2009-06-14 Thread Boaz Harrosh
On 06/14/2009 12:52 PM, Bart Van Assche wrote: On Sun, Jun 14, 2009 at 11:23 AM, Boaz Harroshbharr...@panasas.com wrote: On 06/11/2009 08:41 PM, Mike Christie wrote: It seems like we have a lot of members on the list that are not kernel developers, but we now have 5 iscsi drivers (qla4xxx,

Re: corruption in session list

2009-04-28 Thread Boaz Harrosh
On 04/28/2009 09:28 AM, Erez Zilber wrote: On Mon, Apr 27, 2009 at 6:56 PM, Mike Christie micha...@cs.wisc.edu wrote: Erez Zilber wrote: From time to time, I see errors like the following when I run 'iscsiadm -m session': tcp: [2] []:-1,1 ��A�¹V��� Is it a known bug? I don't know how

gcc warning at iscsi_add_session

2009-04-27 Thread Boaz Harrosh
drivers/scsi/scsi_transport_iscsi.c: In function 'iscsi_add_session': drivers/scsi/scsi_transport_iscsi.c:678: warning: 'err' may be used uninitialized in this function Hi mike, what ever happened to the fix of above warning? I'm sure I saw a fix in the mailing list but it never made it into

Re: iscsiadm: InitiatorName is required on the first Login PDU

2009-04-06 Thread Boaz Harrosh
On 04/06/2009 06:18 PM, Mike Christie wrote: Boaz Harrosh wrote: then I do the above iscsiadm command above and I don't see even a single print in /var/log/messages. I do see the usual: Apr 5 20:25:47 testlin2 kernel: Loading iSCSI transport class v2.0-870. Apr 5 20:25:47 testlin2

Re: iscsiadm: InitiatorName is required on the first Login PDU

2009-04-05 Thread Boaz Harrosh
On 04/02/2009 07:29 PM, Boaz Harrosh wrote: Sorry, it's gating late here, I'll only get to it first thing Sunday. Have a good weekend Boaz I'm back []$ ll /sbin/iscsi* -rwxr-xr-x 1 root root 19836 Apr 5 11:18 /sbin/iscsi-iname -rwxr-xr-x 1 root root 5309 Apr 5 11:18 /sbin

Re: iscsiadm: InitiatorName is required on the first Login PDU

2009-04-02 Thread Boaz Harrosh
On 04/02/2009 06:39 PM, Mike Christie wrote: So I try again: [] git checkout master [] make user [r...@testlin2] make install_user then I do: [r...@testlin2]$ service open-iscsi start Starting iSCSI initiator service: [ OK ] Setting up iSCSI targets: iscsiadm:

Re: iscsiadm: InitiatorName is required on the first Login PDU

2009-04-02 Thread Boaz Harrosh
On 04/02/2009 07:14 PM, Mike Christie wrote: Boaz Harrosh wrote: could you just do iscsid -d 8 -f What gets spit out for the initiator name? Do you have different versions of iscsid and iscsiadm running? Could you run the discovery command with no debugging with the attached

iscsiadm: InitiatorName is required on the first Login PDU

2009-03-30 Thread Boaz Harrosh
Hi Mike, list. In 2.0-870 I use to discover and login in the following command: []$ iscsiadm -m discovery -t sendtargets -p 192.168.0.142:3260 --login But if I compile master: I get: iscsiadm: InitiatorName is required on the first Login PDU iscsiadm: login failed, couldn't

Re: Q: - PDU header Digest fetaure

2009-03-05 Thread Boaz Harrosh
Hi Mike, list. Mike Christie has pointed out of a serious problem for us which we need the list help of. It started with a question by Ulrich Windl of why data-digests are not supported/recommended by open-iscsi installations and distros. [iscsi data-digests is when the complete payload of an

Re: Disable aggregation of requests

2009-02-19 Thread Boaz Harrosh
Erez Zilber wrote: You can select the no-op I/O elevator and you can also use direct IO like with sg_dd from the sg_utils package I'm using noop already, but that didn't help. I'll try to ask in lkml. Thanks, Erez Using the sg3-utils package sg_dd command you can issue individual

Re: Disable aggregation of requests

2009-02-19 Thread Boaz Harrosh
Or Gerlitz wrote: Boaz Harrosh wrote: You can select the no-op I/O elevator and you can also use direct IO like with sg_dd from the sg_utils package Does anyone know why noop is not the default I/O scheduler? It is a very bad idea in case of using a filesystem which is usually

Re: [PATCH 2/2] open-iscsi: kernel/Makefile: Better Makefile output when compiling with new Kernels

2009-02-08 Thread Boaz Harrosh
Mike Christie wrote: Boaz Harrosh wrote: In case we are compiling against a newer kernel then what the out-of-tree is expecting, Output to the user that use of in-tree modules are recommended. This will still fail the compilation. because we don't want to compile in that case

Re: Need help in compiling open-iscsi-2.0-870.2 for kernel 2.6.28

2009-02-02 Thread Boaz Harrosh
Mike Christie wrote: Jeronimo de A. Barros wrote: Hello, Any help or hint to compile open-iscsi-2.0-870.2 for kernel 2.6.28 ? I'm trying on a Bluewhite64 12.2 running kernel 2.6.28.2: r...@test:/usr/local/src/open-iscsi-2.0-870.2# uname -a Linux test 2.6.28.2 #1 SMP Sun Feb 1 09:32:16

[PATCH 1/2] open-iscsi: Makefile: Don't build out-of-tree Kernel modules by default

2009-02-02 Thread Boaz Harrosh
Separate out the build of kernel: and user: targets. Let all: depend on user: only, though making kernel builds optional. [Mike please revisit the @echo output if we need anything added?] Signed-off-by: Boaz Harrosh bharr...@panasas.com --- Makefile | 26 +++--- 1 files

[PATCH 2/2] open-iscsi: kernel/Makefile: Better Makefile output when compiling with new Kernels

2009-02-02 Thread Boaz Harrosh
and he can proceed. [Mike, we could return with @exit 0 and let the Makefile attempt a compilation, but I think it is better this way?] Signed-off-by: Boaz Harrosh bharr...@panasas.com --- kernel/Makefile |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/kernel

[PATCH 0/2] open-iscsi: Makefile enhancements

2009-02-02 Thread Boaz Harrosh
Mike Christie wrote: Boaz Harrosh wrote: Separate out the build of kernel: and user: targets. Let all: depend on user: only, though making kernel builds optional. I like what the patches are doing by warning the user and fixing up the output, but could we just switch up the default? I

[PATCH 1/2] open-iscsi: Makefile: separate out user: and kernel: make targets

2009-02-02 Thread Boaz Harrosh
Separate out the build of kernel: and user: targets. [Mike please revisit the @echo output if we need anything added] Signed-off-by: Boaz Harrosh bharr...@panasas.com --- Makefile | 25 ++--- 1 files changed, 14 insertions(+), 11 deletions(-) diff --git a/Makefile b

[PATCH 2/2] open-iscsi: kernel/Makefile: Better Makefile output when compiling with new Kernels

2009-02-02 Thread Boaz Harrosh
and he can proceed. [Mike we could: return with @exit 0 and let the Makefile attempt a compilation, but I think it is better this way?] Signed-off-by: Boaz Harrosh bharr...@panasas.com --- kernel/Makefile |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/kernel

[PATCH] iscsi tcp: bidi capable

2009-01-20 Thread Boaz Harrosh
From: Pete Wyckoff p...@padd.com Mark iscsi_tcp as being capable of bidirectional transfers. The bsg interface checks this bit before attempting any bidirectional commands. Signed-off-by: Pete Wyckoff p...@padd.com Signed-off-by: Boaz Harrosh bharr...@panasas.com --- drivers/scsi/iscsi_tcp.c

Re: [PATCH] iscsi tcp: bidi capable

2009-01-20 Thread Boaz Harrosh
Boaz Harrosh wrote: From: Pete Wyckoff p...@padd.com Mark iscsi_tcp as being capable of bidirectional transfers. The bsg interface checks this bit before attempting any bidirectional commands. Signed-off-by: Pete Wyckoff p...@padd.com Signed-off-by: Boaz Harrosh bharr...@panasas.com

[PATCH] iscsi: Kconfig option for debug prints.

2009-01-12 Thread Boaz Harrosh
be selected with one Koption, but mainly so that allmodconfig will not turn it on. bit-1 - will turn on prints for libiscsi. bit-2 - will turn on prints for libiscsi_tcp iscsi_tcp. More iscsi drivers should use more bits. Signed-off-by: Boaz Harrosh bharr...@panasas.com --- drivers/scsi/Kconfig

Re: [PATCH] iscsi: Kconfig option for debug prints.

2009-01-12 Thread Boaz Harrosh
Boaz Harrosh wrote: Remove the dark ages /* define debug_print */ in code, to use a Kconfig option. With a system like Kconfig, in code, commented out, configuration options are slavery and hard work. (version control, manual edit ... need I say more) I've used an int config bit-mask so

Re: [PATCH] iscsi: Kconfig option for debug prints.

2009-01-12 Thread Boaz Harrosh
Mike Christie wrote: Boaz Harrosh wrote: Boaz Harrosh wrote: Remove the dark ages /* define debug_print */ in code, to use a Kconfig option. With a system like Kconfig, in code, commented out, configuration options are slavery and hard work. (version control, manual edit ... need I say more

Re: [PATCH] iscsi: Kconfig option for debug prints.

2009-01-12 Thread Boaz Harrosh
Randy Dunlap wrote: Boaz Harrosh wrote: Remove the dark ages /* define debug_print */ in code, to use a Kconfig option. With a system like Kconfig, in code, commented out, configuration options are slavery and hard work. (version control, manual edit ... need I say more) I've used an int

Re: [PATCH untested] iscsi_tcp: Neat picking on code to make it more clear

2008-12-10 Thread Boaz Harrosh
Mike Christie wrote: Boaz Harrosh wrote: A buffer following an header, in case of a linear allocation can be get at by simply doing header_pointer + 1; I got this part, and it looks nicer. In any way below code loads a local pointer which is never used. I did not get this part. Do

[PATCH untested] iscsi_tcp: Neat picking on code to make it more clear

2008-12-09 Thread Boaz Harrosh
A buffer following an header, in case of a linear allocation can be get at by simply doing header_pointer + 1; In any way below code loads a local pointer which is never used. Signed-off-by: Boaz Harrosh [EMAIL PROTECTED] --- drivers/scsi/iscsi_tcp.c |2 +- 1 files changed, 1 insertions

Re: [PATCH 2/2 2.6.29] cxgb3i - accelerating open-iscsi initiator

2008-12-09 Thread Boaz Harrosh
Mike Christie wrote: Boaz Harrosh wrote: + if (!ddp) { + ddp_log_warn(%s unable to alloc ddp 0x%d, ddp disabled.\n, +tdev-name, ppmax); + return 0; + } + ddp-gl_map = (struct cxgb3i_gather_list **)(ddp + 1); + ddp-gl_skb = (struct

Re: object (osd) based iscsi

2008-07-20 Thread Boaz Harrosh
ashish wrote: Hello All, I am trying to install osd based iscsi using ibm osd simulator as target, and ibm osd initiator. and I am having problem with the initiator installation. This initiator requires patched linux- iscsi-4.0.2, I was able to successfully install linux-iscsi-4.0.2, but

Re: Long CDBs

2008-06-04 Thread Boaz Harrosh
EddyQ wrote: Does open-iscsi support long CDBs? You still need one more patch: http://www.spinics.net/lists/linux-scsi/msg26927.html Mike please push it threw your tree, James has gone mute Just out of curiosity, what are you using long CDBs for? Cheers Boaz

Re: Target address redirect ignored

2008-04-29 Thread Boaz Harrosh
On Mon, Apr 28 2008 at 20:15 +0300, Mike Christie [EMAIL PROTECTED] wrote: ptashek wrote: I have looked around the web, but haven't found a similar issue which suggests that this may be a simple config issue, which I have just not found yet. However, if anyone has any thoughts on this, please

[PATCH 0/3 ver2] iscsi bidi varlen support

2008-02-18 Thread Boaz Harrosh
On Thu, Jan 31 2008 at 20:08 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote: Cheers after 1.3 years these can go in. [PATCH 1/3] iscsi: extended cdb support The varlen support is not yet in mainline for block and scsi-ml. But the API for drivers will not change. All LLD need to do

Re: [PATCH 0/3 ver2] iscsi bidi varlen support

2008-02-18 Thread Boaz Harrosh
On Mon, Feb 18 2008 at 19:22 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Mon, 2008-02-18 at 17:08 +0200, Boaz Harrosh wrote: But ... James? is there any chance these can go into scsi-rc-fixes for the 2.6.25 kernel? The reason they are so late was mainly because of a fallout

Re: [PATCH 2/3] iscsi: bidi support - libiscsi

2008-02-18 Thread Boaz Harrosh
of things. also for resid. - Handle BIDI underflow overflow from target Signed-off-by: Boaz Harrosh [EMAIL PROTECTED] I see you do this a bit differently than in your previous patch set. In particular, the residual handling in libiscsi.c. (I'm editing in a bit more context to the patch

[PATCH 0/3] iscsi bidi varlen support

2008-01-31 Thread Boaz Harrosh
Cheers after 1.3 years these can go in. [PATCH 1/3] iscsi: extended cdb support The varlen support is not yet in mainline for block and scsi-ml. But the API for drivers will not change. All LLD need to do is max_command to the it's maximum and be ready for bigger commands. This is