On Tue, 24 May 2022 21:35:15 GMT, Marius Hanl wrote:
> The `valueProperty()` and `chronologyProperty()` listener are now added in
> the second constructor of `DatePicker`
> (`public DatePicker(LocalDate localDate)`) instead of the first one (`public
> DatePicker()`).
>
The `valueProperty()` and `chronologyProperty()` listener are now added in the
second constructor of `DatePicker`
(`public DatePicker(LocalDate localDate)`) instead of the first one (`public
DatePicker()`).
Therefore, both listener are now added no matter which constructor is used.
On Tue, 24 May 2022 21:25:23 GMT, Marius Hanl wrote:
> This PR fixes a problem, where the layout is broken when a `(Tree)TableRow`
> has padding.
> As also mentioned in the ticket, the `layoutChildren` method in
> `TableRowSkinBase` is implemented wrong.
>
> The `layo
This PR fixes a problem, where the layout is broken when a `(Tree)TableRow` has
padding.
As also mentioned in the ticket, the `layoutChildren` method in
`TableRowSkinBase` is implemented wrong.
The `layoutChildren` method is responsible for layouting all the
`(Tree)TableCells`.
When the row
On Thu, 19 May 2022 14:23:55 GMT, Robert Lichtenberger
wrote:
>> Separate test class added for TreeTableView case.
>> Fix is analogous to JDK-8251480.
>
> Robert Lichtenberger has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - 8285197:
On Tue, 10 May 2022 20:03:08 GMT, Marius Hanl wrote:
> A common reason for using the `TextFormatter` is the need for a `filter`.
> Therefore, the following constructor is typically used:
> `public TextFormatter(@NamedArg("filter") U
On Thu, 12 May 2022 22:13:38 GMT, Kevin Rushforth wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8286552: Added space and revert typo fix
>
> modules/javafx.controls/src/
ck.
>
> Added tests for all `TextFormatter` functionalities, which pass before and
> after.
Marius Hanl has updated the pull request incrementally with one additional
commit since the last revision:
8286552: Added space and revert typo fix
-
Changes:
- all: https://git.open
A common reason for using the `TextFormatter` is the need for a `filter`.
Therefore, the following constructor is typically used:
`public TextFormatter(@NamedArg("filter") UnaryOperator filter) { ... }`
With that, no `valueConverter` is set in the `TextFormatter`.
When a `TextField` will commit
On Thu, 21 Apr 2022 08:38:20 GMT, Robert Lichtenberger
wrote:
> Separate test class added for TreeTableView case.
> Fix is analogous to JDK-8251480.
Looks good! Verified that the fix works.
I can also confirm, that this fix is the same as previously done for
`TableView` in PR:
On Tue, 19 Apr 2022 06:06:25 GMT, Robert Lichtenberger
wrote:
> Is there a pre-existing issue for this? Otherwise I'll try and come up with
> an example and create a new issue...
I don't think so, you may need to create a new issue. I think it's pretty much
the same problem and solution as
On Wed, 16 Mar 2022 13:01:45 GMT, Robert Lichtenberger
wrote:
>> Might make sense to also adjust the TreeTableView sizing implementation?
>
>> Might make sense to also adjust the TreeTableView sizing implementation?
>
> Yes I think that may be a good idea. True to the idea of specific, narrow
On Wed, 30 Mar 2022 12:22:23 GMT, Robert Lichtenberger
wrote:
>> This fix respects a row factory, if present.
>> It will put the cell that is used to measure the column width as child below
>> the row.
>> In that way the row's style will be used.
>
> Robert Lichtenberger has updated the pull
On Thu, 24 Mar 2022 06:14:42 GMT, Robert Lichtenberger
wrote:
>> This fix respects a row factory, if present.
>> It will put the cell that is used to measure the column width as child below
>> the row.
>> In that way the row's style will be used.
>
> Robert Lichtenberger has updated the pull
On Thu, 24 Mar 2022 04:57:27 GMT, Robert Lichtenberger
wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableColumnHeader.java
>> line 650:
>>
>>> 648: }
>>> 649: Callback, TableRow> rowFactory =
>>> tv.getRowFactory();
>>> 650: TableRow
On Wed, 9 Mar 2022 07:48:53 GMT, John Hendrikx wrote:
>> I added a test case for `SpinnerSkin` that checks the arrow positioning.
>>
>> While adding the tests I discovered more problems with the positioning aside
>> from the one mentioned in the JBS ticket.
>>
>> 1) Vertical split arrow
On Wed, 16 Mar 2022 08:20:59 GMT, Robert Lichtenberger
wrote:
> This fix respects a row factory, if present.
> It will put the cell that is used to measure the column width as child below
> the row.
> In that way the row's style will be used.
The approach looks good. I left some comments and
strings.add("abc: " + i);
> }
> }
>
> @TearDown
> public void tearDown() {
> strings = null;
> }
>
> @Benchmark
> public ObservableList init() {
> return FXCollections.observableArrayList(strings);
> }
> }
>
strings.add("abc: " + i);
> }
> }
>
> @TearDown
> public void tearDown() {
> strings = null;
> }
>
> @Benchmark
> public ObservableList init() {
> return FXCollections.observableArrayList(strings);
> }
> }
>
>
On Fri, 18 Mar 2022 21:28:33 GMT, yosbits wrote:
> * I don't know what the modCount property is used for, but is it okay if the
> modified code has different values?
This is fine as the mod count is only there to detect concurrent modifications.
I recommend to read the `modCount` javadoc, its
a hs_err_pid file, which I
attached as well.
-- Marius
Gesendet: Mittwoch, 23. Februar 2022 um 23:54 Uhr
Von: "Kevin Rushforth"
An: "Marius Hanl" , "openjfx-dev"
Betreff: Re: ArrayIndexOutOfBoundsException when disconnecting screen
I spent
This simple PR optimizes the observable `ArrayList` creation by using the
ArrayList constructor/array size so that the underlying array will be
initialized at the correct size which will speed up the creation as the array
does not need to grow as a result of the `addAll` call.
I also added
On Wed, 16 Mar 2022 08:20:59 GMT, Robert Lichtenberger
wrote:
> This fix respects a row factory, if present.
> It will put the cell that is used to measure the column width as child below
> the row.
> In that way the row's style will be used.
Might make sense to also adjust the TreeTableView
e index didn't changed at all, we manually
> call `indexChanged(..)` (basically just like before) since when a property is
> not changed, `invalidated()` is not called, but we need to notify subclasses
> that `updateIndex(..)` was called.
Marius Hanl has updated the pull request incre
This PR fixes an issue where the item of the table row is null, although the
cell itself is not empty (non null value).
The fix is to call `indexChanged(..)` immediately after the index was changed,
but before all `indexProperty()` listener are notified.
The then notified listener in
I get an ArrayIndexOutOfBoundsException sometimes when I disconnect my
screen(s).
Setup: I have a laptop with a docking station attached. The docking
station is connected to two screen, so when I disconnect it 2 screen
will be 'lost'.
The following stacktrace is visible and the
be done in your fork.
-- Marius
Gesendet: Montag, 21. Februar 2022 um 14:21 Uhr
Von: "Jeanette Winzenburg"
An: "Marius Hanl"
Cc: "openjfx-dev"
Betreff: Re: Aw: Sneak preview: cell edit api to support
commit-on-focusLost
hmm .. yeah, will do ..
Can you may create a branch at the jfx sandbox repo?
https://github.com/openjdk/jfx-sandbox
Then I can more easily compare and check it out. (and monitor it :))
-- Marius
Gesendet: Freitag, 11. Februar 2022 um 18:03 Uhr
Von: "Jeanette Winzenburg"
An: "openjfx-dev"
On Wed, 2 Feb 2022 14:18:18 GMT, Jeanette Winzenburg
wrote:
> Issue was TreeView commit editing implementation violated the spec'ed
> mechanism:
>
> - no default commit handler on TreeView
> - TreeCell modifying the data directly
>
> Fix is to move the saving of the edited value from cell
On Fri, 14 Jan 2022 00:04:49 GMT, Marius Hanl wrote:
> This PR will fix a simple NPE which may happens when using the `TableRow`
> inside a `TableCell` during the initial auto sizing.
> In the auto sizing code, no `TableRow` is set, therefore `getTableRow()` will
>
On Sat, 29 Jan 2022 13:57:01 GMT, Jeanette Winzenburg
wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8251481: Using global stageLoader now
>
> modules/javafx.controls/src/test/
> This is fixed by adding the `TableRow` in the `resizeColumnToFitContent`
> method, similar as it is already done for the `TreeTableView`
> (`TreeTableRow`).
Marius Hanl has updated the pull request incrementally with one additional
commit since the last revision:
8251481: Ad
On Mon, 15 Nov 2021 14:34:04 GMT, Marius Hanl wrote:
> When a divider is moved via drag or code it will call **requestLayout()** for
> the **SplitPane**.
> While this is fine, it is also called when the
> **SplitPaneSkin#layoutChildren(..)** method is repositioning the divider.
>
On Fri, 28 Jan 2022 12:40:15 GMT, Jeanette Winzenburg
wrote:
>> I can align it. And yeah makes sense to add a test for the
>> TreeTableView/TreeTableCell.
>
> just curious: why didn't you move the tests into TableColumnHeaderTest?
I had no particular reason, I think the test fits both
On Thu, 27 Jan 2022 15:21:33 GMT, Marius Hanl wrote:
>> just for reference - found the source of my [faintly
>> remember](https://github.com/openjdk/jfx/pull/337/files/8a6fc1cf6cad2c453de17b71777ddd63fadb539e#r510975640)
>
> I see. Unfortunately though that was not done c
it
> (and thus repositioning the dividers as part of it).
>
> Note: I also fixed a simple typo of a private method in SplitPaneSkin:
> initializeDivderEventHandlers -> initializeDiv**i**derEventHandlers
Marius Hanl has updated the pull request incrementally with one additional
On Tue, 25 Jan 2022 12:09:31 GMT, Jeanette Winzenburg
wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8251481: Using global stageLoader now
>
> modules/javafx.controls/src/test/
> This is fixed by adding the `TableRow` in the `resizeColumnToFitContent`
> method, similar as it is already done for the `TreeTableView`
> (`TreeTableRow`).
Marius Hanl has updated the pull request incrementally with one additional
commit since the last revision:
8251481: Usin
On Thu, 27 Jan 2022 12:46:19 GMT, Jeanette Winzenburg
wrote:
>> ah okay. Was just confusing for me since I never read that and I think some
>> recent PRs still had this pattern, e.g. also the touch table scrolling PR I
>> had a look at yesterday.
>>
>> Maybe for future it makes sense to have
On Thu, 27 Jan 2022 10:18:31 GMT, Jeanette Winzenburg
wrote:
>> Hm, is this really needed? Not sure, are there any side effects by the
>> `StageLoader` like this when a test failed?
>> Just asking since the `StageLoader` is used a lot like this.
>> And since the tests normally run green unless
> This is fixed by adding the `TableRow` in the `resizeColumnToFitContent`
> method, similar as it is already done for the `TreeTableView`
> (`TreeTableRow`).
Marius Hanl has updated the pull request incrementally with one additional
commit since the last revision:
8251481:
On Tue, 25 Jan 2022 12:00:11 GMT, Jeanette Winzenburg
wrote:
>> This PR will fix a simple NPE which may happens when using the `TableRow`
>> inside a `TableCell` during the initial auto sizing.
>> In the auto sizing code, no `TableRow` is set, therefore `getTableRow()`
>> will return null and
On Tue, 25 Jan 2022 13:45:54 GMT, Jeanette Winzenburg
wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8277122: Added test for setting a negative divider position + improved
&g
On Tue, 25 Jan 2022 13:38:53 GMT, Jeanette Winzenburg
wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8277122: Added test for setting a negative divider position + improved
&g
it
> (and thus repositioning the dividers as part of it).
>
> Note: I also fixed a simple typo of a private method in SplitPaneSkin:
> initializeDivderEventHandlers -> initializeDiv**i**derEventHandlers
Marius Hanl has updated the pull request incrementally with one additional
c
On Wed, 26 Jan 2022 05:36:07 GMT, meghanEmbrace wrote:
>> With a touch-enabled device, the scrollbar disappears a short while after
>> it's used. During the layout, updateHbar() checks the hbar visibility and
>> resets the clip, causing the user to be scrolled fully to the left when
>> trying
On Tue, 25 Jan 2022 14:34:09 GMT, meghanEmbrace wrote:
>> With a touch-enabled device, the scrollbar disappears a short while after
>> it's used. During the layout, updateHbar() checks the hbar visibility and
>> resets the clip, causing the user to be scrolled fully to the left when
>> trying
I think I had the same issues some days ago. What helped was to delete
all the 'build' or 'target' or 'out' folders - so basically all the
folders with the compiled files.
Gesendet: Dienstag, 18. Januar 2022 um 15:46 Uhr
Von: "Jeanette Winzenburg"
An: "openjfx-dev"
On Tue, 11 Jan 2022 17:21:13 GMT, Michael Strauß wrote:
> The question is whether or not `null` should be a valid value for the
> `selectionModel` and `focusModel` properties. I think there are good reasons
> to think that it shouldn't. The primitive property classes
> (`IntegerProperty`,
On Tue, 30 Nov 2021 12:32:37 GMT, Jeanette Winzenburg
wrote:
> The misbehaviour was that an edit handler received both a commit and cancel
> event when cell commitEdit is called. That happened whenever a collaborator
> reset the controls editing state (either directly or indirectly) while
>
On Fri, 14 Jan 2022 11:52:40 GMT, Jeanette Winzenburg
wrote:
> hmm .. I think here are two issues:
>
> * the auto-sizing code definitely needs to fully configure the cell (with
> index, row, column, tableView plus applying css) to measure the correct size
> * the implementation of
This PR will fix a simple NPE which may happens when using the `TableRow`
inside a `TableCell` during the initial auto sizing.
In the auto sizing code, no `TableRow` is set, therefore `getTableRow()` will
return null and it is not possible to e.g. access the row item.
This is fixed by adding
On Tue, 11 Jan 2022 09:01:51 GMT, John Hendrikx wrote:
> ```
> public final MultipleSelectionModel getSelectionModel() {
> return selectionModel == null ? null :
> selectionModel.get() == NONE_SELECTION_MODEL ? null :
> selectionModel.get();
> }
> ```
That would work altough I
On Sat, 8 Jan 2022 14:32:30 GMT, John Hendrikx wrote:
> Same goes for the selection model; if set to `null` it should not allow any
> kind of selection, which again seems best achieved by installing a model that
> ignores all such actions and always returns empty values.
We had a similar
This PR fixes a bunch of NPEs when a null `SelectionModel` or `FocusModel` is
set on a `ListView`.
The following NPEs are fixed (all are also covered by exactly one test case):
NPEs with null selection model:
- Mouse click on a `ListCell`
- SPACE key press
- KP_UP (arrow up) key press
- HOME key
On Wed, 24 Nov 2021 09:09:53 GMT, Marius Hanl wrote:
> This PR fixes an issue where the `DatePicker` is not committing his text as
> value when the focus is lost.
> As the ticket also mentions, this is a regression which last worked on JavaFX
> 8 and got broken by this refactor
On Fri, 10 Dec 2021 00:12:20 GMT, Marius Hanl wrote:
> This PR replaces 2 deprecations which were added in
> https://bugs.openjdk.java.net/browse/JDK-8188026
This pull request has now been integrated.
Changeset: 79151937
Author:Marius Hanl
Committer: Kevin Rushforth
URL:
This PR replaces 2 deprecations which were added in
https://bugs.openjdk.java.net/browse/JDK-8188026
-
Commit messages:
- 8278425: TreeTableCellStartEditTest uses deprecated TreeTableCell methods
Changes: https://git.openjdk.java.net/jfx/pull/692/files
Webrev:
On Wed, 24 Nov 2021 09:09:53 GMT, Marius Hanl wrote:
> This PR fixes an issue where the `DatePicker` is not committing his value
> when the focus is lost.
> As the ticket also mentions, this is a regression which last worked on JavaFX
> 8 and got broken by the refactoring:
&g
This PR fixes an issue where the `DatePicker` is not committing his value when
the focus is lost.
As the ticket also mentions, this is a regression which last worked on JavaFX 8
and got broken by the refactoring:
[JDK-8150946](https://bugs.openjdk.java.net/browse/JDK-8150946)
The fix is to
it
> (and thus repositioning the dividers as part of it).
>
> Note: I also fixed a simple typo of a private method in SplitPaneSkin:
> initializeDivderEventHandlers -> initializeDiv**i**derEventHandlers
Marius Hanl has updated the pull request incrementally with one additional
On Fri, 19 Nov 2021 12:39:23 GMT, Jeanette Winzenburg
wrote:
> interesting issue - and fix :) Verified the mis-behaviour before the fix and
> its working after.
>
> Wondering, though (read: I don't understand )
>
> * why the layout details in the splitpane hinders the visual update of a
>
On Wed, 17 Nov 2021 05:34:46 GMT, Abhinay Agarwal wrote:
> This work improves the performance of `MultipleSelectionModel` over large
> data sets by caching some values and avoiding unnecessary calls to
> `SelectedIndicesList#size`. It further improves the performance by reducing
> the number
When a divider is moved via drag or code it will call **requestLayout()** for
the **SplitPane**.
While this is fine, it is also called when the **layoutChildren(..)** method is
repositioning the divider.
This makes no sense since we are currently layouting everything, so we don't
need to
On Mon, 1 Nov 2021 12:54:12 GMT, Jeanette Winzenburg
wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java
>> line 365:
>>
>>> 363: // Fix for RT-27782: Need to set isDirty to true,
>>> rather than the
>>> 364: //
On Wed, 27 Oct 2021 09:56:46 GMT, Jeanette Winzenburg
wrote:
>> Cleanup of Tree-/TableRowSkin to support switching skins
>>
>> The misbehavior/s
>> - memory leaks due to manually registered listeners that were not removed
>> - side-effects due to listeners still active on old skin (like NPEs)
On Tue, 26 Oct 2021 12:09:19 GMT, Marius Hanl wrote:
> This problem can happen when using multiple instances with different jfx
> early access (ea) versions.
>
> Example:
> Instance 1 uses 18-ea+4 and Instance 2 uses 18-ea+1.
> Instance 1 is started (and will cache
On Wed, 6 Oct 2021 07:43:15 GMT, Marius Hanl wrote:
> This PR fixes a bug where the blend mode will be falsely recognized as a
> color and therefore won't be set.
> Also a ClassCastException is thrown (The converter expects a String, but gets
> a Color).
>
> Note: There
On Fri, 29 Oct 2021 14:34:39 GMT, Michael Strauß wrote:
> Looks good, although the solution in itself remains fishy. Maybe create a
> ticket to implement a better solution in the future?
yes, the css code is sometimes very ... interesting. I didn't had a deep look
but it's weird that there
On Wed, 27 Oct 2021 08:12:05 GMT, Johan Vos wrote:
> This looks like a good solution, and I agree it fixes the issue. I have 2
> minor concerns:
>
> 1. Are we sure there are no platform-specific restrictions when using a `+`
> in a filename?
> 2. Testing this is probably difficult. We can
This problem can happen when using multiple instances with different jfx early
access (ea) versions.
Example:
Instance 1 uses 18-ea+4 and Instance 2 uses 18-ea+1.
Instance 1 is started (and will cache and use libraries), then instance 2.
Now instance 2 detects via a hash comparison that the
On Sat, 2 Oct 2021 23:53:02 GMT, Marius Hanl wrote:
> This PR fixes a visual glitch which may happen when showing a dialog.
> When a max height is set and the pref height of the dialog content is bigger
> the dialog starts to flicker between the max height and the pref height.
>
&g
I like this idea.
Pretty sure some listener I wrote won't handle a permutation correctly.
I may have one question: Is there something that needs to be done in
case of an update (wasUpdated)?
-- Marius
Gesendet: Mittwoch, 20. Oktober 2021 um 21:07 Uhr
Von: "Michael Strau�"
On Fri, 22 Oct 2021 10:36:24 GMT, Jeanette Winzenburg
wrote:
>> cell startEdit is supposed to update the editing location on its associated
>> control - was done in ListCell, not in Tree-/TableCell nor TreeCell.
>>
>> Fix was to add control.edit(..). Note that ListCell was also touched to use
On Fri, 22 Oct 2021 10:15:59 GMT, Jeanette Winzenburg
wrote:
>> darn .. ;) Thanks
>
> hmm .. I'm all for consistency, so don't mind trying again but ... what _is_
> the formatting rule? Searching in controls:
>
> - wildcard search: `` = 1000+ vs. `` = 379
> - verbatim: `` = 173 vs. `` =
On Fri, 15 Oct 2021 10:21:12 GMT, Jeanette Winzenburg
wrote:
>> cell startEdit is supposed to update the editing location on its associated
>> control - was done in ListCell, not in Tree-/TableCell nor TreeCell.
>>
>> Fix was to add control.edit(..). Note that ListCell was also touched to use
On Fri, 24 Sep 2021 12:42:31 GMT, Kevin Rushforth wrote:
>> This PR fixes an issue which is probably in JavaFX since VirtualFlow exists.
>> While horizontal scrolling any VirtualFlow control the left blue border
>> sometimes disappear/gets smaller. (see also image below)
>>
>> This can be
ed with
> 18-ea+3).
> https://bugs.openjdk.java.net/browse/JDK-8268657
> It also looks different so I don't think this PR fixes this, if it is still
> there.
Marius Hanl has updated the pull request incrementally with two additional
commits since the last revision:
- 8274699: Revert
On Thu, 14 Oct 2021 17:45:40 GMT, Kevin Rushforth wrote:
>> This PR fixes a bug where the blend mode will be falsely recognized as a
>> color and therefore won't be set.
>> Also a ClassCastException is thrown (The converter expects a String, but
>> gets a Color).
>>
>> Note: There is another
On Tue, 5 Oct 2021 13:18:07 GMT, Jeanette Winzenburg
wrote:
> cell startEdit is supposed to update the editing location on its associated
> control - was done in ListCell, not in Tree-/TableCell nor TreeCell.
>
> Fix was to add control.edit(..). Note that ListCell was also touched to use
>
On Wed, 6 Oct 2021 15:34:14 GMT, Jeanette Winzenburg
wrote:
> > Interesting, I just saw that it worked before because of the
> > TableCellBehavior (edit method). Does this mean this can be removed from
> > the behaviour in future?
>
> hmm .. the behavior talks directly to the control (not
On Tue, 5 Oct 2021 13:18:07 GMT, Jeanette Winzenburg
wrote:
> cell startEdit is supposed to update the editing location on its associated
> control - was done in ListCell, not in Tree-/TableCell nor TreeCell.
>
> Fix was to add control.edit(..). Note that ListCell was also touched to use
>
On Tue, 5 Oct 2021 13:18:07 GMT, Jeanette Winzenburg
wrote:
> cell startEdit is supposed to update the editing location on its associated
> control - was done in ListCell, not in Tree-/TableCell nor TreeCell.
>
> Fix was to add control.edit(..). Note that ListCell was also touched to use
>
This PR fixes a bug where the blend mode will be falsely recognized as a color
and therefore won't be set.
Also a ClassCastException is thrown (The converter expects a String, but gets a
Color).
Note: There is another similar bug but I can't reproduce this (Tried on
18-ea+3).
This PR fixes a visual glitch which may happen when showing a dialog.
When a max height is set and the pref height of the dialog content is bigger
the dialog starts to flicker between the max height and the pref height.
This happens because in one case the height is not bound between the min and
On Fri, 1 Oct 2021 14:59:02 GMT, Jeanette Winzenburg
wrote:
>> The misbehavior happens if (super) startEdit didn't succeed (==
>> !cell.isEditing):
>>
>> - must not fire editStart event
>> - must not update control's editing location
>>
>> fix is to back out of startEdit if super.startEdit
that issue,
although I suspect they aren't relevant to the bug you are looking at.
-- Kevin
[1] [1]https://bugs.openjdk.java.net/browse/JDK-8211294
[2] [2]https://github.com/openjdk/jfx/pull/308
On 9/27/2021 2:41 AM, Marius Hanl wrote:
> I recently tried to fix "TableV
On Thu, 30 Sep 2021 12:00:16 GMT, Jeanette Winzenburg
wrote:
> The misbehavior happens if (super) startEdit didn't succeed (==
> !cell.isEditing):
>
> - must not fire editStart event
> - must not update control's editing location
>
> fix is to back out of startEdit if super.startEdit doesn't
On Wed, 7 Jul 2021 22:33:07 GMT, Marius Hanl wrote:
> This PR sets an unified logic to every **startEdit()** method of all Cell
> implementations.
> So startEdit() is always doing the same now:
>
> `super.startEdit();`
> `if (!isEditing()) {
> return;
> }`
>
>
On Wed, 7 Jul 2021 00:25:15 GMT, Marius Hanl wrote:
> This PR fixes a long standing issue with the TreeTableView indentation.
>
> 
>
> In short:
> **TreeTableCe
It would be very helpful if you could provide a minimum reproducable
example. So really just the code which is necessary for all of us to
reproduce it.
Am 29.09.21, 00:06 schrieb Alessandro Parisi
:
Can we have a look at this report please?
I'm having this issue more and
I recently tried to fix "TableView: visual glitch at borders on
horizontal scrolling".
Ticket: [1]https://bugs.openjdk.java.net/browse/JDK-8218745
PR: [2]https://github.com/openjdk/jfx/pull/630
As also written in the PR I have problems understanding the
snapping/scaling of
I also really like this move, thanks for that.
I have also experience with JUnit 5.
And if there is something where I may can help I'm glad to do so.
For people who may don't know, this are the features JUnit5 gives
us and I'm also excited about:
- assertThrows(..)
-
On Fri, 24 Sep 2021 10:48:53 GMT, Ajit Ghaisas wrote:
> Overall the fix looks ok. The new test fails without the fix and passes with
> it.
>
> Can you please confirm the test programs provided in 2 duplicated bugs of
> JDK-8231644 also work as expected with this fix?
Just tried them. They
On Fri, 24 Sep 2021 10:43:31 GMT, Ajit Ghaisas wrote:
>> Marius Hanl has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - Merge branch 'master' of https://github.com/openjdk/jfx into
This PR fixes an issue which is probably in JavaFX since VirtualFlow exists.
While horizontal scrolling any VirtualFlow control the left blue border
sometimes disappear/gets smaller. (see also image below)
This can be fixed by **snapping** the scroll bar value (similar like e.g. a
On Tue, 21 Sep 2021 11:13:06 GMT, Nir Lisker wrote:
> Replacements of more immutable collections.
>
> One thing I found was that the field `idMap` in
> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
> if that's indeed the case.
On Mon, 29 Mar 2021 19:57:17 GMT, Michael Strauß wrote:
> The children of HBox/VBox don't always pixel-snap to the same value as the
> container itself when a render scale other than 1 is used. This can lead to a
> visual glitch where the content bounds don't line up with the container
>
On Tue, 7 Sep 2021 14:53:50 GMT, Jeanette Winzenburg
wrote:
> this PR fixes the inconsistent event firing pattern in cell's xxEdit methods
> (please see the issue for more details):
>
> - fires event if column != null
> - accesses table state if table != null
>
> The first requires a change
As also written in a comment
here: https://github.com/openjdk/jfx/pull/610
I would like to propose one more convenience method which should be
added to JavaFX:
public static Border stroke(Paint stroke, double width) {
return new Border(new BorderStroke(stroke,
1 - 100 of 207 matches
Mail list logo
