On Fri, 9 Oct 2020 18:11:14 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed test
>
> tests/performance/3DLighting/attenuation/LightingSample.java line 62:
>
>> 60:
On Fri, 9 Oct 2020 16:33:28 GMT, Nir Lisker wrote:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixed test
Looks good to me. There seems to be an existing issue
On Fri, 9 Oct 2020 16:33:28 GMT, Nir Lisker wrote:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixed test
I think this is ready to go in once it gets a second
On Fri, 9 Oct 2020 16:33:28 GMT, Nir Lisker wrote:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixed test
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Fixed test
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/43/files
- new:
On Fri, 9 Oct 2020 14:55:36 GMT, Nir Lisker wrote:
>> tests/system/src/test/java/test/javafx/scene/lighting3D/PointLightAttenuationTest.java
>> line 135:
>>
>>> 133: @AfterClass
>>> 134: public static void teardown() {
>>> 135: Platform.runLater(() -> {
>>
>> I forgot to
On Fri, 9 Oct 2020 12:34:08 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comments
>
> tests/system/src/test/java/test/javafx/scene/lighting3D/PointLightAttenuationTest.java
>
On Fri, 9 Oct 2020 04:53:36 GMT, Nir Lisker wrote:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed review comments
On Fri, 9 Oct 2020 01:39:23 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/native-prism-d3d/D3DLight.cc line 64:
>>
>>> 62: }
>>> 63:
>>> 64: /*void D3DLight::setRange(float r) {
>>
>> Remove this unused function?
>
> I forgot to mention this point. These setter functions for color
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comments
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/43/files
- new:
On Thu, 8 Oct 2020 22:21:06 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change range after clamping
>
> modules/javafx.graphics/src/main/native-prism-d3d/D3DLight.cc line 64:
>
>> 62: }
>>
On Thu, 8 Oct 2020 22:20:17 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change range after clamping
>
> modules/javafx.graphics/src/main/native-prism-d3d/D3DLight.cc line 49:
>
>> 47:
On Thu, 8 Oct 2020 22:08:16 GMT, Kevin Rushforth wrote:
>> In that case, it seems like a generally useful optimization (not just at
>> initialization) to send down `maxRange` as 0
>> whenever `ca`, `la`, and `qa` are all at their default values.
>
> Actually, my above comment is wrong. A
On Thu, 24 Sep 2020 02:46:31 GMT, Nir Lisker wrote:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change range after clamping
On Thu, 24 Sep 2020 02:46:31 GMT, Nir Lisker wrote:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change range after clamping
The public API and implementation
On Fri, 7 Aug 2020 22:30:39 GMT, Kevin Rushforth wrote:
>> The only impact this has is that the range will be maximal instead of 0.
>> When these reach the shader, they will run the
>> lighting computation as opposed to skipping it. I'm not sure if this will
>> have any performance impact
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Change range after clamping
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/43/files
- new:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
Nir Lisker has updated the pull request incrementally with two additional
commits since the last revision:
- Fixed whitespaces
- Added an automated test
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/43/files
-
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Fixed whitespace
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/43/files
- new:
On Fri, 4 Sep 2020 23:20:43 GMT, Nir Lisker wrote:
>> Thanks, the test runs now, but I've run into an issue with `snapshot`.
>>
>> `Node#snapshot` uses its scene parameters (like lights) to render the image,
>> but if the node is in a subscene then the
>> image will be wrong since it takes the
On Fri, 4 Sep 2020 14:34:40 GMT, Nir Lisker wrote:
>> If you run it with `--info` you will see something like this:
>>
>> test.javafx.scene.shape.PointLightAttenuationTest STANDARD_ERROR
>> Exception in Application constructor
>> Exception in thread "Thread-4"
On Wed, 2 Sep 2020 17:16:00 GMT, Kevin Rushforth wrote:
>> I wrote the following test:
>>
>> import static org.junit.Assert.assertTrue;
>> import static org.junit.Assert.fail;
>>
>> import java.util.concurrent.CountDownLatch;
>> import java.util.concurrent.TimeUnit;
>>
>> import
On Wed, 2 Sep 2020 16:57:25 GMT, Nir Lisker wrote:
>> It can either be a fully qualified class name (with `.` as separator) or the
>> unqualified name of the test class. The
>> class name must end with exactly `Test`. So for example, try it with
>> `Snapshot1Test`.
>
> I wrote the following
On Tue, 1 Sep 2020 23:09:39 GMT, Kevin Rushforth wrote:
>>> gradle -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests MyTest
>>
>> What format is `MyTest`? Is it some relative path?
>
> It can either be a fully qualified class name (with `.` as separator) or the
> unqualified name of
On Tue, 1 Sep 2020 22:46:44 GMT, Nir Lisker wrote:
>> You need to pass a flag to enable system tests (and a second one for Robot
>> tests, but if you use snapshot it might not
>> need to be).
>> gradle -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests MyTest
>
>> gradle
On Tue, 1 Sep 2020 17:00:10 GMT, Kevin Rushforth wrote:
> gradle -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests MyTest
What format is `MyTest`? Is it some relative path?
-
PR: https://git.openjdk.java.net/jfx/pull/43
On Tue, 1 Sep 2020 13:49:48 GMT, Nir Lisker wrote:
>> I guess you are trying a unit test in the `javafx.graphics` project? That
>> won't work. It needs to be a system test in
>> `tests/system/...`
>
> I tried several approaches. When I put it under `tests/system` and run the
> tests task, I
On Tue, 1 Sep 2020 11:42:30 GMT, Kevin Rushforth wrote:
>> I've written a simple draft for the automated test:
>>
>> PointLight light = new PointLight(Color.BLUE);
>> light.setTranslateZ(-50);
>> var box = new Box(100, 100, 1);
>> var root = new Group(light,
On Tue, 1 Sep 2020 10:54:50 GMT, Nir Lisker wrote:
>> The performance tests need a standard GPLv2+classpath copyright header. I
>> haven't tested them yet, but will do that
>> next week.
>
> I've written a simple draft for the automated test:
>
> PointLight light = new
On Fri, 7 Aug 2020 22:37:15 GMT, Kevin Rushforth wrote:
>> Given that we don't have any automated tests for lighting (we have a couple
>> that verify that we can take a snapshot and
>> get the same result, but that isn't testing the lighting itself), probably
>> the most we can expect is a
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comments
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/43/files
- new:
On Wed, 29 Jul 2020 23:09:52 GMT, Nir Lisker wrote:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixed whitespace
On Fri, 24 Jul 2020 09:16:38 GMT, Ambarish Rapte wrote:
> ```
> float attenuatedColor = gLightColor[i].xyz / (ca + la * dist + qa * dist *
> dist);
> ```
Typo: that should be:
float3 attenuatedColor = gLightColor[i].xyz / (ca + la * dist + qa * dist *
dist);
-
PR:
On Fri, 7 Aug 2020 21:55:25 GMT, Kevin Rushforth wrote:
>>> 1. The API docs look good. If you change the public API to `@since 16` then
>>> you can also update the CSR and move it to
>>> the "Submitted" state.
>>
>> I moved it to the PROPOSED state.
>>
>>> 2. I think it would be good to
On Wed, 29 Jul 2020 09:17:10 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGShape3D.java
>> line 187:
>>
>>> 186: 0, 0, 0, 0, // r g b w
>>> 187: 1, 0, 0, 0); // ca la qa maxRange
>>> 188: }
>>
On Wed, 29 Jul 2020 23:11:20 GMT, Nir Lisker wrote:
>> High-level comments:
>>
>> 1. The API docs look good. If you change the public API to `@since 16` then
>> you can also update the CSR and move it to
>> the "Submitted" state. 2. I think it would be good to cleanup the
>> performance test
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Moved test folder
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/43/files
- new:
On Fri, 24 Jul 2020 21:41:04 GMT, Kevin Rushforth wrote:
> 1. The API docs look good. If you change the public API to `@since 16` then
> you can also update the CSR and move it to
> the "Submitted" state.
I moved it to the PROPOSED state.
> 2. I think it would be good to cleanup the
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Fixed whitespace
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/43/files
- new:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Fixed whitespaces
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/43/files
- new:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Added performance test
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/43/files
- new:
On Fri, 24 Jul 2020 21:25:06 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now
>> contains 11 commits:
>> - Merge branch 'master' into 8217472_Add_attenuation_for_PointLight
>> - Attenuation and
On Tue, 28 Jul 2020 12:44:18 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/resources/com/sun/prism/es2/glsl/main3Lights.frag
>> line 92:
>>
>>> 91: d += clamp(dot(n,l), 0.0, 1.0) * (lights[0].color).rgb * att;
>>> 92: s += pow(clamp(dot(-refl, l), 0.0, 1.0), power)
On Tue, 28 Jul 2020 13:28:38 GMT, Nir Lisker wrote:
> I'd like to know how you did that.
Compiled hlsl shader binaries are stored in folder
`rt\modules\javafx.graphics\build\headers\PrismD3D\hlsl`. The `fxc`
command that generates these files is in `build.gradle`. We can just make a
copy and
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
Nir Lisker has updated the pull request incrementally with three additional
commits since the last revision:
- Merge remote-tracking branch
'nlisker/8217472_Add_attenuation_for_PointLight' into
8217472_Add_attenuation_for_PointLight
On Tue, 28 Jul 2020 13:15:02 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/PointLightHelper.java
>> line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2016, 2019, Oracle and/or its affiliates. All rights
>>> reserved.
>>> 3: * DO NOT ALTER OR REMOVE COPYRIGHT
On Fri, 24 Jul 2020 21:41:04 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now
>> contains 11 commits:
>> - Merge branch 'master' into 8217472_Add_attenuation_for_PointLight
>> - Attenuation and
On Fri, 24 Jul 2020 21:01:08 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now
>> contains 11 commits:
>> - Merge branch 'master' into 8217472_Add_attenuation_for_PointLight
>> - Attenuation and
On Fri, 24 Jul 2020 21:29:06 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now
>> contains 11 commits:
>> - Merge branch 'master' into 8217472_Add_attenuation_for_PointLight
>> - Attenuation and
On Thu, 23 Jul 2020 12:06:17 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now
>> contains 11 commits:
>> - Merge branch 'master' into 8217472_Add_attenuation_for_PointLight
>> - Attenuation and
On Fri, 8 May 2020 12:36:41 GMT, Nir Lisker wrote:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
>
> Nir Lisker has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now
> contains 11 commits:
> - Merge branch 'master' into
On Fri, 8 May 2020 12:36:41 GMT, Nir Lisker wrote:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
>
> Nir Lisker has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now
> contains 11 commits:
> - Merge branch 'master' into
On Wed, 15 Jul 2020 00:16:03 GMT, Nir Lisker wrote:
>>> I've added sphere with 10, 64 (default) and 200 divisions.
>>
>> Thanks, I'll take a look at it.
>
> Using AMD RX 470 4GB on Ubuntu 18, all 3 spheres averaged 60 fps both before
> and after the patch.
>
> I wonder why the number is half
On Fri, 3 Jul 2020 13:49:20 GMT, Kevin Rushforth wrote:
>> I've added sphere with 10, 64 (default) and 200 divisions. Note that this
>> number is approximate because the sphere mesh
>> corrects the division number with `newDivisions = ((oldDivisions + 3) / 4) *
>> 4`.
>>
On Wed, 1 Jul 2020 06:31:22 GMT, Nir Lisker wrote:
>> I would say in addition to rather than instead of, since both are useful.
>>
>> What might help is to add the sphere test plus the pathological test I put
>> together into your test program so we can
>> select between them. And then get a
On Wed, 13 May 2020 23:50:37 GMT, Kevin Rushforth wrote:
>>> We should make sure that we aren't seeing any significant performance drop
>>> when rendering spheres (at a couple
>>> different tessellation levels) or boxes.
>>
>> I missed this. Do you mean that the test should create a mesh of a
On Wed, 13 May 2020 23:42:40 GMT, Nir Lisker wrote:
>> If this were an even remotely representative use case, then no, the
>> performance hit would not be OK. The test was
>> designed as an artificial "worst-case" stress test: a single mesh with a
>> large number of very large (window-sized)
On Sat, 25 Apr 2020 17:07:21 GMT, Kevin Rushforth wrote:
> We should make sure that we aren't seeing any significant performance drop
> when rendering spheres (at a couple
> different tessellation levels) or boxes.
I missed this. Do you mean that the test should create a mesh of a sphere
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
Nir Lisker has updated the pull request with a new target base due to a merge
or a rebase. The pull request now
contains 11 commits:
- Merge branch 'master' into 8217472_Add_attenuation_for_PointLight
- Attenuation and range changed
On Sat, 25 Apr 2020 17:07:21 GMT, Kevin Rushforth wrote:
>> @kevinrushforth
>> Member
>> kevinrushforth commented Apr 18, 2020
>>
>> I think most of those are good suggestions going forward. As for the
>> performance drop, the only place we've seen it so
>> far is on graphics accelerators that
>
> Will there also be any performance drop in case you just use the default
> parameters for the lighting?
That's what we're testing.
The default, which corresponds to the current lighting, should not need
> any additional computations
> and thus no performance drop.
But there is no way to
Am 25.04.20 um 19:09 schrieb Kevin Rushforth:
On Fri, 24 Apr 2020 05:06:56 GMT, Phil Race wrote:
Here is a slightly modified test program. It fixes a compilation error in the
previous, and also adds a system property
to set the number of quads:
It creates 200 quads by default. If you need to
On Fri, 24 Apr 2020 05:06:56 GMT, Phil Race wrote:
>> Here is a slightly modified test program. It fixes a compilation error in
>> the previous, and also adds a system property
>> to set the number of quads:
>> It creates 200 quads by default. If you need to increase this or decrease it
>> to
On Fri, 24 Apr 2020 01:50:11 GMT, Kevin Rushforth wrote:
>> I think most of those are good suggestions going forward. As for the
>> performance drop, the only place we've seen it so
>> far is on graphics accelerators that are a few years old by now. Integrated
>> graphics chipsets (such as
On Sat, 18 Apr 2020 15:45:32 GMT, Kevin Rushforth wrote:
>> I discussed this with a graphics engineer. He said that a couple of branches
>> do not have any real performance impact
>> even on modern mobile devices, and that, e.g., on iOS 7 using half floats
>> instead of floats was improving
On Fri, 17 Apr 2020 16:02:12 GMT, Nir Lisker wrote:
>> Conclusion: The new shaders that support attenuation don't seem to have much
>> of a performance impact on machines with
>> an Intel HD, but on systems with a graphics accelerator, it is a significant
>> slowdown.
>> So we are left with
On Wed, 15 Apr 2020 20:59:40 GMT, Kevin Rushforth wrote:
>> Here are the results on Phil's machine, which is a Mac Book Pro with a
>> graphics accelerator (Nvidia, I think).
>>
>> Without the patch:
>> 2000 quads average 8.805 fps
>>
>> With the patch:
>> 2000 quads average 4.719 fps
>>
>>
On Tue, 7 Apr 2020 23:03:21 GMT, Kevin Rushforth wrote:
>> @arapte Can you please test the performance changes too?
>
> I think @arapte has a similar MacBookPro model to mine.
>
> I think @prrace might be able to test it (I'll sync with him offline).
Here are the results on Phil's machine,
On Wed, 15 Apr 2020 20:59:29 GMT, Kevin Rushforth wrote:
>> I think @arapte has a similar MacBookPro model to mine.
>>
>> I think @prrace might be able to test it (I'll sync with him offline).
>
> Here are the results on Phil's machine, which is a Mac Book Pro with a
> graphics accelerator
On Thu, 2 Apr 2020 12:59:11 GMT, Nir Lisker wrote:
>> I have added few comments, but have not run tests and sample yet.
>
> @arapte Can you please test the performance changes too?
I think @arapte has a similar MacBookPro model to mine.
I think @prrace might be able to test it (I'll sync with
On Fri, 3 Jan 2020 09:26:43 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Attenuation and range changed internally to floats from doubles
>
> I have added few comments, but have not run tests
On Tue, 17 Mar 2020 02:50:28 GMT, Nir Lisker wrote:
>> Updated test case:
>> [attenTest2.zip](https://github.com/openjdk/jfx/files/4332937/attenTest2.zip)
>
> On Win 10 with an AMD RX 470 4GB I get the following:
>
> Without the patch:
> 200 quads average 113 fps
> 5000 quads average 11.5 fps
On Sat, 14 Mar 2020 15:31:18 GMT, Kevin Rushforth wrote:
>> I'll attach the above modified testcase that I ran. I ran it on a relatively
>> new Windows 10 laptop and a rather ancient
>> MacBook Pro. I had to drastically reduce the number of quads on the Mac, but
>> the results are similar: no
On Wed, 11 Mar 2020 21:35:55 GMT, Kevin Rushforth wrote:
>> I'll take a look. My quick thought is that we need some sort of test with a
>> reasonable number of large boxes (so that
>> it is fill-limited). If there isn't such a case, and the 3D rendering is
>> always node-limited, then the
On Sat, 14 Mar 2020 15:29:59 GMT, Kevin Rushforth wrote:
>> I did some limited testing today with a modification to the test program you
>> attached to create a MeshView with 200
>> large quads (400 triangles) in a single node. This will eliminate the node
>> overhead. I can confirm that it is
On Tue, 10 Mar 2020 22:41:26 GMT, Kevin Rushforth wrote:
>> @kevinrushforth Can you have a look at the test app? I would like to get
>> this moving so we would have time to get the
>> rest of the lighting enhancements into 15.
>
> I'll take a look. My quick thought is that we need some sort of
On Tue, 10 Mar 2020 18:52:23 GMT, Nir Lisker wrote:
>> Looks like the `jcheck` bot removed the `rfr` label because the CSR isn't
>> complete. An incomplete CSR should be treated
>> the same way as an insufficient number of reviewers. I filed
>>
On Wed, 5 Feb 2020 13:48:45 GMT, Kevin Rushforth wrote:
>> We have a few performance tests in apps/performance, but I don't know how up
>> to date they are. They might give you a
>> starting point on how to measure FPS, but really the harder part is going to
>> be coming up with a workload --
On Mon, 17 Feb 2020 01:53:18 GMT, Nir Lisker wrote:
>> Looks like the `jcheck` bot removed the `rfr` label because the CSR isn't
>> complete. An incomplete CSR should be treated the same way as an
>> insufficient number of reviewers. I filed
>>
On Wed, 5 Feb 2020 13:48:45 GMT, Kevin Rushforth wrote:
>> We have a few performance tests in apps/performance, but I don't know how up
>> to date they are. They might give you a starting point on how to measure
>> FPS, but really the harder part is going to be coming up with a workload --
>>
On Fri, 10 Jan 2020 00:34:18 GMT, Kevin Rushforth wrote:
>>> This will need a fair bit of testing to ensure that there are no
>>> regressions either in functionality or (especially) performance, in
>>> addition to tests for the new functionality.
>>
>> Which tests for the new functionality
On Thu, 9 Jan 2020 18:00:19 GMT, Nir Lisker wrote:
>> The error was for the cases of 2 and 3 lights (I was testing 1) and should
>> be fixed now. My fault with copy-paste... that's why we use loops, but I
>> guess this is some optimization for the es2 pipeline. I wonder if it's
>> really
On Sat, 4 Jan 2020 18:22:29 GMT, Nir Lisker wrote:
>> Right. This needs to talk about pixels. Perhaps there is a way to make it
>> more clear that we are talking about pixels that are part of a rendered
>> Shape3D, but I don't have a good suggestion right now.
>
> Maybe
>
> A light source
On Fri, 3 Jan 2020 23:02:56 GMT, Nir Lisker wrote:
>>> I still need to test your sample app on Mac.
>>
>> I get the error with your sample app. It fails on Mac or Linux (Ubuntu
>> 16.04) with the same error as I reported above.
>
> The error was for the cases of 2 and 3 lights (I was testing
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
The pull request has been updated with 1 additional commit.
-
Added commits:
- 66cdab32: Attenuation and range changed internally to floats from doubles
Changes:
- all: https://git.openjdk.java.net/jfx/pull/43/files
-
On Fri, 3 Jan 2020 22:23:29 GMT, Kevin Rushforth wrote:
>> I was wondering about it myself, but all the other values are `double`s that
>> are cast to `float`s. Wouldn't it also be odd to have the API properties
>> `DoubleProperty` and the peer to use `float`s? Isn't it just a matter of
>>
On Fri, 3 Jan 2020 22:37:06 GMT, Kevin Rushforth wrote:
>> I have added few comments, but have not run tests and sample yet.
>
>> I still need to test your sample app on Mac.
>
> I get the error with your sample app. It fails on Mac or Linux (Ubuntu 16.04)
> with the same error as I reported
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
The pull request has been updated with 1 additional commit.
-
Added commits:
- 464e8b5d: Fixed shader compilation errors for 2 and 3 lights in es2
Changes:
- all: https://git.openjdk.java.net/jfx/pull/43/files
- new:
On Fri, 3 Jan 2020 09:26:43 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> I have added few comments, but have not run tests and sample yet.
> I still need to test your sample app on Mac.
I get the error with your sample app. It fails on Mac or
On Fri, 3 Jan 2020 19:32:23 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/PointLight.java line 41:
>>
>>> 40: * unless it belongs to a {@code Shape3D} outside of its {@code scope}.
>>> 41: *
>>> 42: * The light's intensity can be set to decrease over distance
On Fri, 3 Jan 2020 09:25:21 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/native-prism-d3d/D3DMeshView.cc line 175:
>
>> 174: lightsAttenuation[a++] = lights[i].attenuation[2];
>> 175:
On Fri, 3 Jan 2020 09:21:32 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGPointLight.java
> line 64:
>
>> 63:
>> 64: private double ca = DEFAULT_CA;
>> 65:
>
> The
On Fri, 3 Jan 2020 05:17:26 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/javafx/scene/PointLight.java line 41:
>
>> 40: * unless it belongs to a {@code Shape3D} outside of its {@code scope}.
>> 41: *
>>
On Fri, 3 Jan 2020 05:08:33 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGPointLight.java
> line 43:
>
>> 42: private static final double DEFAULT_MAX_RANGE =
>>
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
The pull request has been updated with 1 additional commit.
-
Added commits:
- f66e8cf4: Addressing review comments
Changes:
- all: https://git.openjdk.java.net/jfx/pull/43/files
- new:
On Sun, 17 Nov 2019 04:15:34 GMT, Nir Lisker wrote:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
I have added few comments, but have not run tests and sample yet.
modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGPointLight.java
line 71:
> 70: public void
On Thu, 2 Jan 2020 18:18:21 GMT, Nir Lisker wrote:
>> I think this is on the right track. The API looks like it is in good shape.
>>
>> This will need a fair bit of testing to ensure that there are no regressions
>> either in functionality or (especially) performance, in addition to tests
>>
On Fri, 20 Dec 2019 21:56:32 GMT, Kevin Rushforth wrote:
>> The bug I mentioned above is not a bug actually. There are large changes
>> over a small distance that make it looks like a jump in the lighting values,
>> but when working with a finer scale the lighting dynamics seem correct.
>
> I
On Wed, 20 Nov 2019 00:32:36 GMT, Nir Lisker wrote:
>> Kevin, Ambarish,
>>
>> You can start the review, especially the API. I will hunt that specific
>> values bug this week.
>>
>> I'll need to know what kind of tests are needed in terms of functionality
>> and performance.
>
> The bug I
On Mon, 18 Nov 2019 18:00:46 GMT, Nir Lisker wrote:
> On Mon, 18 Nov 2019 18:00:45 GMT, Nir Lisker wrote:
>
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
>>
>>
>>
>> Commits:
>> - a388fb92: Fixed whitespaces
>> - 415927e6: Correction for indexes
>> - 3450ffe9:
1 - 100 of 102 matches
Mail list logo
