Re: [Openvpn-devel] [PATCH v2] Change timestamps to ISO 8601 format.

2016-08-12 Thread Gert Doering
quot; ctime() format today - what I spotted on the management interface is "status" output, both in the header and in each idividual client line. gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doerin

Re: [Openvpn-devel] [PATCH] Fix building with LibreSSL 2.5.1 by cleaning a hack.

2017-02-07 Thread Gert Doering
); > > I have a question (sorry if I couldn't check myself): did you check that > SSL_get_privatekey() and SSL_free() won't crash when ssl is NULL ? crypto_msg(M_FATAL, ...) will not return. gert -- USENET is *not* the non-clickable part of WWW!

Re: [Openvpn-devel] [PATCH applied] github: Add PR template with contributor related information

2017-02-07 Thread Gert Doering
s" number for the Subject: line, I'd go through our recent commits, look at Subject: lines that look reasonable and just measure what we've been using. Yes, "reasonable" is very subjective. gert -- USENET is *not* the non-clickable part of WWW!

Re: [Openvpn-devel] [PATCH] add PR template in order to simplify new developers cooperate properly if they open PR. discussed here: https://sourceforge.net/p/openvpn/mailman/message/35601310/

2017-02-02 Thread Gert Doering
at it's not in "bin/" tells stories :-) gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-3565

Re: [Openvpn-devel] [PATCH] systemd: Move the READY=1 signalling to an earlier point

2017-01-24 Thread Gert Doering
USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025g...@net.informatik.tu-muenchen.de signature.asc De

Re: [Openvpn-devel] [PATCH 1/1] remove GNUism and fix out-of-tree build

2017-01-27 Thread Gert Doering
the zoo. For a v7 of this... we might consider whether to print out the plugin search path at "--help" or "--version" time (we already print the whole autoconf sermon)... gert -- USENET is *not* the non-clickable part of WWW!

Re: [Openvpn-devel] [PATCH applied] Clean up plugin path handling

2017-01-26 Thread Gert Doering
t and open the ACLs (the buildslaves have fairly restricted network access and reachability). gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de f

Re: [Openvpn-devel] [PATCH applied] Add a check for -Wl, --wrap support in linker

2017-01-20 Thread Gert Doering
of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025g...@net.informatik.tu-muenchen.de signature.asc Description: PGP sig

Re: [Openvpn-devel] [PATCH v3 1/1] Clean up plugin path handling

2017-01-25 Thread Gert Doering
ady includes via plugin.h ... I actually think this path > can be quite useful for third-party plug-ins, being built outside of the > openvpn source tree. +1 gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~

[Openvpn-devel] [PATCH applied] Re: Fix building with LibreSSL 2.5.1 by cleaning a hack. Similar to what is done in curl: https://github.com/curl/curl/blob/028391df5d84d9fae3433afdee9261d565900355/lib

2017-02-15 Thread Gert Doering
Acked-by: Steffan Karger <steffan.kar...@fox-it.com> Message-Id: <20170213183826.73008-1-o2graph...@users.noreply.github.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg14045.html Signed-off-by: Gert Doering <g...@greenie

[Openvpn-devel] [PATCH applied] Re: dev-tools: Simple tool wihch automates rebasing LZ4 compat library

2017-02-21 Thread Gert Doering
h Date: Wed Jan 25 21:53:02 2017 +0100 dev-tools: Simple tool which automates rebasing LZ4 compat library Signed-off-by: David Sommerseth <dav...@openvpn.net> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <20170125205302.23069-1-dav...@openv

Re: [Openvpn-devel] [PATCH] Fix segfault when using crypto lib without AES-256-CTR or SHA256

2017-02-21 Thread Gert Doering
is quite obvious, so this is not something to bring in the lawyers - more a matter of general policy. gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany

Re: [Openvpn-devel] NOTE: unable to redirect default gateway -- Cannot read current default gateway from system

2017-02-21 Thread Gert Doering
eporting this application silliness :-) gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025

Re: [Openvpn-devel] [RFC PATCH v1 00/15] Add support for OpenSSL 1.1.x

2017-02-20 Thread Gert Doering
more coverage on SSL library versions. thanks for your work! gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89

Re: [Openvpn-devel] [PATCH v2] Fix user's group membership check in interactive service to work with domains

2017-02-20 Thread Gert Doering
A few more tests, then merge... gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025

[Openvpn-devel] [PATCH applied] Re: Fix user's group membership check in interactive service to work with domains

2017-02-20 Thread Gert Doering
Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <1484428589-7882-1-git-send-email-selva.n...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg13877.html Signed-off-by: Gert Doering <g...@greenie.muc.de>

Re: [Openvpn-devel] [PATCH] dev-tools: Simple tool wihch automates rebasing LZ4 compat library

2017-02-20 Thread Gert Doering
Hi, On Wed, Jan 25, 2017 at 09:53:02PM +0100, David Sommerseth wrote: > This tool depends on a cloned upstream LZ4 git repository and a > checked out release tag. Then run the script like this: > >$ ./dev-tools/lz4-rebaser.sh /path/to/lz4.git > > To see the result before committing, use:

Re: [Openvpn-devel] [PATCH v2] Fix user's group membership check in interactive service to work with domains

2017-02-20 Thread Gert Doering
that makes sense :-) gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025g...@n

Re: [Openvpn-devel] [PATCH] dev-tools: Simple tool wihch automates rebasing LZ4 compat library

2017-02-20 Thread Gert Doering
prefer. It's your code :) (And since this is not "main openvpn code", the rules are not as strict anyway - the actual lz4 commit change would need to be reviewed anyway) gert -- USENET is *not* the non-clickable part of WWW!

[Openvpn-devel] [PATCH applied] Re: attempt to add IPv6 route even when no IPv6 address was configured

2017-02-20 Thread Gert Doering
d Signed-off-by: Antonio Quartulli <a...@unstable.cc> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <20170131112131.13570-...@unstable.cc> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg13994.html Signed-off-by: Gert Doerin

Re: [Openvpn-devel] build against openssl 1.1.0

2017-02-17 Thread Gert Doering
nderstand, at least the RHEL guys would backport anything that shows up while RHEL5 is still supported... (and since they never change version numbers, this is/was the goal). gert -- USENET is *not* the non-clickable part of WWW!

Re: [Openvpn-devel] [PATCH applied] Re: Fix building with LibreSSL 2.5.1 by cleaning a hack. Similar to what is done in curl: https://github.com/curl/curl/blob/028391df5d84d9fae3433afdee9261d565900355

2017-02-18 Thread Gert Doering
Hi, On Sat, Feb 18, 2017 at 02:37:30AM +0100, Olivier W wrote: > 2017-02-16 8:47 GMT+01:00 Gert Doering <g...@greenie.muc.de>: > > Your patch has been applied to the master and release/2.4 branch. > > > > Not sure if it is something we want in release/2.3, but it w

[Openvpn-devel] [PATCH applied] Re: OpenSSL: don't use direct access to the internal of X509_STORE

2017-02-22 Thread Gert Doering
ts.sourceforge.net/msg14076.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slash

[Openvpn-devel] [PATCH applied] Re: OpenSSL: don't use direct access to the internal of SSL_CTX

2017-02-22 Thread Gert Doering
ts.sourceforge.net/msg14088.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slash

[Openvpn-devel] [PATCH applied] Re: OpenSSL: don't use direct access to the internal of X509_OBJECT

2017-02-22 Thread Gert Doering
.com/openvpn-devel@lists.sourceforge.net/msg14080.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slash

[Openvpn-devel] [PATCH applied] Re: fix typo in notification message

2017-02-24 Thread Gert Doering
fix typo in notification message Signed-off-by: Christian Hesse <m...@eworm.de> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <20170224122252.15199-1-l...@eworm.de> URL: http://www.mail-archive.com/search?l=mid=20170224122252.15199-1-l...@eworm.

Re: [Openvpn-devel] [PATCH] Fix "--dev null"

2017-02-24 Thread Gert Doering
Hi, On Fri, Feb 24, 2017 at 04:32:14PM +0200, Samuli Seppänen wrote: > On 24/02/2017 15:52, Gert Doering wrote: > > To test whether a server is reachable and all the key handling is > > right, openvpn can connect with "--dev null --ifconfig-noexec" to > > avoid need

[Openvpn-devel] [PATCH] Fix "--dev null"

2017-02-24 Thread Gert Doering
ly" code didn't know if this is a tun or tap device...) - treat --dev null as "tap", done. Signed-off-by: Gert Doering <g...@greenie.muc.de> --- src/openvpn/tun.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c index

Re: [Openvpn-devel] [PATCH] Ignore auth-nocache for auth-user-pass if auth-token is pushed

2017-02-25 Thread Gert Doering
USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025g...@net.informatik.tu-muenchen.de signature.asc D

[Openvpn-devel] [PATCH applied] Re: Fix '--dev null'

2017-02-24 Thread Gert Doering
Patch has been applied to the master and release/2.4 branch. As ordered, '||' have been moved to pos_arith=lead, and the tab has been extabinated. commit 22c5381b71710ad0e1dbbccc1d5680fccb602311 (master) commit 2085c1f3875b9c96ac739941712247b805677efa (release/2.4) Author: Gert Doering Date

[Openvpn-devel] [PATCH applied] Re: Fix segfault when using crypto lib without AES-256-CTR or SHA256

2017-02-23 Thread Gert Doering
without AES-256-CTR or SHA256 Acked-by: Steffan Karger <steffan.kar...@fox-it.com> Message-Id: <345db0ac-f6e8-8490-a80a-ffbd81972...@karger.me> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg14138.html Signed-off-by: Gert Doering <g...

[Openvpn-devel] [PATCH applied] Re: Add openssl_compat.h to openvpn_SOURCES

2017-02-23 Thread Gert Doering
Patch has been applied to the master and release/2.4 branch. commit 827c05732b0414dbf3cc05bf4ae6bfda042eadd3 (master) commit bbc671c2fdf6287605ef5057b1d44811bcd81785 (release/2.4) Author: Gert Doering Date: Thu Feb 23 09:49:54 2017 +0100 Add openssl_compat.h to openvpn_SOURCES

Re: [Openvpn-devel] [RFC PATCH v1 01/15] OpenSSL: don't use direct access to the internal of SSL_CTX

2017-02-23 Thread Gert Doering
Hi, On Thu, Feb 23, 2017 at 09:03:47AM +0100, Gert Doering wrote: > This patch brings two problems outside the "OpenSSL functionality" > part. > > - openssl_compat.h is not included in the built tarballs, so mingw builds >fail (and "builds for anyone build

[Openvpn-devel] [PATCH applied] Re: OpenSSL: 1.1 fallout - fix configure on old autoconf

2017-02-23 Thread Gert Doering
configure on old autoconf Signed-off-by: Steffan Karger <steffan.kar...@fox-it.com> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <1487846138-22231-1-git-send-email-steffan.kar...@fox-it.com> URL: http://www.mail-archive.com/search?l=mid=148784613

Re: [Openvpn-devel] [RFC PATCH v1 00/15] Add support for OpenSSL 1.1.x

2017-02-19 Thread Gert Doering
*not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025g...@net.informatik.tu-muenchen.de signature.as

Re: [Openvpn-devel] build against openssl 1.1.0

2017-02-19 Thread Gert Doering
t; need. We will see when RHEL 8 gets released :) Interesting times! gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49

[Openvpn-devel] [PATCH applied] Re: OpenSSL: check for the SSL reason, not the full error

2017-02-19 Thread Gert Doering
: Steffan Karger <steffan.kar...@fox-it.com> Message-Id: <0e0d4a67192b563cd07d3f06685f85e34c304142.1487368114.git.log...@free.fr> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg14087.html Signed-off-by: Gert Doering <g...@greenie.muc.de>

Re: [Openvpn-devel] build against openssl 1.1.0

2017-02-17 Thread Gert Doering
ickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025g...@net.informatik.tu-muenchen.de signature.asc Description: PGP signature -

Re: [Openvpn-devel] [PATCH] Fix segfault when using crypto lib without AES-256-CTR or SHA256

2017-02-21 Thread Gert Doering
them have a full name for the author. Do we have a policy how to handle patches with missing author info? gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany

[Openvpn-devel] [PATCH applied] Re: dev-tools: lz4-rebaser tool carried a typo

2017-02-21 Thread Gert Doering
1 20:27:35 2017 +0100 dev-tools: lz4-rebaser tool carried a typo Signed-off-by: David Sommerseth <dav...@openvpn.net> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <20170221192737.24166-2-dav...@openvpn.net> URL: https://www.ma

[Openvpn-devel] [PATCH applied] Re: fix redirect-gateway behaviour when an IPv4 default route does not exist

2017-02-21 Thread Gert Doering
4 default route does not exist Signed-off-by: Antonio Quartulli <a...@unstable.cc> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <20170119162518.31752-...@unstable.cc> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg13905.ht

Re: [Openvpn-devel] [RFC PATCH v1 01/15] OpenSSL: don't use direct access to the internal of SSL_CTX

2017-02-23 Thread Gert Doering
tackle the second one - no access to a CentOS6/RHEL6 box, and not enough autoconf clue to see this right away. Patch *looks* good... most likely just a stray "\" where none should be, or so... Please :-) gert -- USENET is *not* the non-clickable part of WWW!

Re: [Openvpn-devel] [PATCH] Fix building with LibreSSL 2.5.1 by cleaning a hack.

2017-02-14 Thread Gert Doering
ur actual patch! Steffan...? gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025g...@net.informatik.

Re: [Openvpn-devel] [PATCH] Fix building with LibreSSL 2.5.1 by cleaning a hack.

2017-02-13 Thread Gert Doering
rebase --interactive", which will enable you to squash three commits into a single one. Then you can use "git commit --amend" to work on the (combined) commit message until you're happy with it. gert -- USENET is *not* the non-clickable part of WWW!

Re: [Openvpn-devel] [PATCH] Fix building with LibreSSL 2.5.1 by cleaning a hack.

2017-02-13 Thread Gert Doering
Hi, On Mon, Feb 13, 2017 at 06:46:11PM +0100, Olivier W wrote: > 2017-02-13 9:31 GMT+01:00 Gert Doering <g...@greenie.muc.de>: > > Look at "git rebase --interactive", which will enable you to squash > > three commits into a single one. Then you can use &

Re: [Openvpn-devel] build against openssl 1.1.0

2017-02-13 Thread Gert Doering
t compile with 1.1.0 either, at least "out of the repo")? gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de f

Re: [Openvpn-devel] NOTE: unable to redirect default gateway -- Cannot read current default gateway from system

2017-01-19 Thread Gert Doering
to finally reach a working solution :-) - and I'll put "rework that v4 stuff" on my limitless TODO list... gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germa

Re: [Openvpn-devel] [PATCH] options: allow setting default --ca argument value

2017-01-15 Thread Gert Doering
-time option" - someone has to maintain and test this, with and without this option, which adds to our maintenance nightmare. So the gain has to be significant. gert -- USENET is *not* the non-clickable part of WWW!

Re: [Openvpn-devel] [PATCH] Add a check for -Wl, --wrap support in linker

2017-01-18 Thread Gert Doering
merge this, but would like to hear some voices from folks that understand autoconf better - is there anything wrong with this approach? Any suggestions how to do it better? gert -- USENET is *not* the non-clickable part of WWW! //www.muc.

Re: [Openvpn-devel] NOTE: unable to redirect default gateway -- Cannot read current default gateway from system

2017-01-18 Thread Gert Doering
should be smarter - the v4 code is 10+ years old, and has grown over time, and parts of it have been contributed by non-networking folks...) gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering -

Re: [Openvpn-devel] [PATCH v2] Drop recursively routed packets

2016-08-22 Thread Gert Doering
plus, making this an inline function) For now, we stick to "fixes the issue in a easy to read and non-intrusive way", so it can go into 2.3.12. thanks again :) gert -- USENET is *not* the non-clickable part of WWW! //www.

[Openvpn-devel] [PATCH] Fix problems with NCP and --inetd.

2016-08-22 Thread Gert Doering
age and refusing to change ciphers if the server has already set up its keys. Trac #715 Signed-off-by: Gert Doering <g...@greenie.muc.de> --- src/openvpn/options.c | 8 src/openvpn/push.c| 21 - 2 files changed, 24 insertions(+), 5 deletions(-) diff --git a/sr

Re: [Openvpn-devel] Topics for today's (Monday, 22nd Aug 2016) community meeting

2016-08-22 Thread Gert Doering
ert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025g...@net.informatik.tu-

[Openvpn-devel] [PATCH v2] Fix problems with NCP and --inetd.

2016-08-22 Thread Gert Doering
age and refusing to change ciphers if the server has already set up its keys. v2: wrap long msg() text lines Trac #715 Signed-off-by: Gert Doering <g...@greenie.muc.de> --- src/openvpn/options.c | 9 + src/openvpn/push.c| 23 ++- 2 files changed, 27 inserti

Re: [Openvpn-devel] [PATCH (master)] Updated build parameters to match openvpn-install-2.3.12-I601

2016-08-29 Thread Gert Doering
of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025g...@net.informatik.tu-muenchen.de signature.asc Description: PGP sig

Re: [Openvpn-devel] autoconf/automake warnings

2016-08-11 Thread Gert Doering
plugins? Since we do not build a shared library, libtool tends to introduce much more hassles than being helpful about anything - especially on more weird platforms like AIX. gert -- USENET is *not* the non-clickable part of WWW! //www.muc.

[Openvpn-devel] [PATCH] Change timestamps to POSIX format.

2016-08-11 Thread Gert Doering
her places where informational timestamps are produced. Among these are the status files / status to management interface, so applications parsing these time stamp need to be adjusted. trac#719 Signed-off-by: Gert Doering <g...@greenie.muc.de> --- src/openvpn/otime.c | 7 +-- 1 file c

Re: [Openvpn-devel] Dropping Windows Vista / XP support?

2016-09-07 Thread Gert Doering
r that date (or so)... gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025

Re: [Openvpn-devel] Dropping Windows Vista / XP support?

2016-09-07 Thread Gert Doering
rding Vista support: I noticed that major open source projects (like chrome) have already dropped Vista support - so I think dropping Vista for 2.4 should be OK. gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/

[Openvpn-devel] [PATCH applied] Re: Fix --mssfix when using NCP

2016-09-10 Thread Gert Doering
: Gert Doering <g...@greenie.muc.de> Message-Id: <1473487872-13119-1-git-send-email-stef...@karger.me> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg12436.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kin

[Openvpn-devel] help wanted: OpenSolaris building

2016-09-11 Thread Gert Doering
www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025g...@net.informatik.tu-muenchen.de signature.asc Description: PGP

[Openvpn-devel] [PATCH] Do not abort t_client run if OpenVPN instance does not start.

2016-09-13 Thread Gert Doering
Basically, an oversight - if one test instance does not start at all (due to "tap driver not loaded") the whole script would exit, instead of logging the failing instance and proceeding to the next test run. Signed-off-by: Gert Doering <g...@greenie.muc.de> --- tests/t_c

[Openvpn-devel] [PATCH] Fix IP_PKTINFO related compilation failure on NetBSD 7.0

2016-09-16 Thread Gert Doering
PEC_DST". Patch inspired by NetBSD pkgsrc patch set. (Note: with that patch, OpenVPN --multihome is still broken for IPv4 on NetBSD 7.0.1 / amd64, but that's a different issue) Signed-off-by: Gert Doering <g...@greenie.muc.de> --- configure.ac | 9 + src/openvpn/init.c

Re: [Openvpn-devel] [PATCH] Fix IP_PKTINFO related compilation failure on NetBSD 7.0

2016-09-16 Thread Gert Doering
Hi, On Fri, Sep 16, 2016 at 09:02:42PM +0200, Gert Doering wrote: > NetBSD has introduced IP_PKTINFO and struct in_pktinfo, but does not > have the "ipi_spec_dst" structure element, causing compilation errors. > > Introduce a check for that (AC_CHECK_MEMBER) in configur

[Openvpn-devel] [PATCH] Show compile-time variant for --multihome in --version output.

2016-09-16 Thread Gert Doering
Instead of just [MH], show [MH/PKTINFO] or [MH/RECVDA], to see more easily which compile-time variant was chosen by configure and syshead.h Signed-off-by: Gert Doering <g...@greenie.muc.de> --- src/openvpn/options.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

Re: [Openvpn-devel] [PATCH applied] initial travis-ci support

2016-09-17 Thread Gert Doering
Shipitsin Date: Thu Sep 15 16:26:48 2016 +0500 initial travis-ci support Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <1473938808-3312-1-git-send-email-chipits...@gmail.com> URL: http://www.mail-archive.com/search?l=mid=1473938808-3312-1-git-send-e

Re: [Openvpn-devel] [PATCHv2] t_client.sh: Add support for Kerberos/ksu

2016-09-17 Thread Gert Doering
lickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025g...@net.informatik.tu-muenchen.de signature.asc Descri

Re: [Openvpn-devel] [PATCH applied] t_client.sh: Add support for Kerberos/ksu

2016-09-17 Thread Gert Doering
Signed-off-by: David Sommerseth <dav...@openvpn.net> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <1474109433-4710-1-git-send-email-dav...@openvpn.net> URL: http://www.mail-archive.com/search?l=mid=1474109433-4710-1-git-send-email-dav...@openvpn.net S

Re: [Openvpn-devel] [PATCH applied] t_client.sh: Improve detection if the OpenVPN process did start during tests

2016-09-17 Thread Gert Doering
if the OpenVPN process did start during tests Signed-off-by: David Sommerseth <dav...@openvpn.net> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <1474111085-10678-1-git-send-email-dav...@openvpn.net> URL: http://www.mail-archive.com/search?l=mid=147411108

[Openvpn-devel] [PATCH applied] Re: Fix ENABLE_WITH_OPENSSL set to YES even with --disable-crypto set

2016-09-17 Thread Gert Doering
Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <1474111006-16401-1-git-send-email-a...@rfc2549.org> URL: http://www.mail-archive.com/search?l=mid=1474111006-16401-1-git-send-email-a...@rfc2549.org Signed-off-by: Gert Doering <g...@greenie.muc.de> --

[Openvpn-devel] [PATCH applied] Re: Prefer RECVDSTADDR to PKTINFO for IPv4 in OS X since it actually works (unlike PKTINFO)

2016-09-17 Thread Gert Doering
ACK. Your patch has been applied to the master branch. commit 3ffe2338c092d7bd4abace3ae9fa0b4f85cf4b87 Author: Arne Schwabe Date: Sat Sep 17 11:00:35 2016 +0200 Prefer RECVDSTADDR to PKTINFO for IPv4 in OS X since it actually works (unlike PKTINFO) Acked-by: Gert Doering &l

Re: [Openvpn-devel] [PATCH applied] Re: Prefer RECVDSTADDR to PKTINFO for IPv4 in OS X since it actually works (unlike PKTINFO)

2016-09-17 Thread Gert Doering
Hi, On Sat, Sep 17, 2016 at 02:01:03PM +0200, Gert Doering wrote: > Your patch has been applied to the master branch. > > commit 3ffe2338c092d7bd4abace3ae9fa0b4f85cf4b87 > Author: Arne Schwabe > Date: Sat Sep 17 11:00:35 2016 +0200 Forgot to push and then David put a new patch

[Openvpn-devel] [PATCH] Fix win32 building with C99 mode

2016-09-17 Thread Gert Doering
In -std=c99 mode, WIN32 is not defined to be "1" anymore, but just "#define WIN32" - so the "#if WIN32" breaks, needs to be "#ifdef WIN32" Signed-off-by: Gert Doering <g...@greenie.muc.de> --- src/openvpn/misc.c | 2 +- 1 file changed, 1 inserti

Re: [Openvpn-devel] [PATCH] Fix win32 building with C99 mode

2016-09-17 Thread Gert Doering
WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025g...@net.informatik.tu-muenchen.de signature.asc Description: PGP signat

Re: [Openvpn-devel] [PATCH] Enable TCP non-linear packet ID

2016-09-17 Thread Gert Doering
tch... gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025g...@net.inform

Re: [Openvpn-devel] [PATCH] Fix win32 building with C99 mode

2016-09-18 Thread Gert Doering
Hi, On Sat, Sep 17, 2016 at 07:11:56PM -0400, Selva Nair wrote: > On Sat, Sep 17, 2016 at 9:20 AM, Gert Doering <g...@greenie.muc.de> wrote: > > > In -std=c99 mode, WIN32 is not defined to be "1" anymore, but just > > "#define WIN32" - so the &

[Openvpn-devel] [PATCH applied] Re: Support for disabled peer-id

2016-09-18 Thread Gert Doering
-git-send-email-lstipa...@gmail.com> URL: http://www.mail-archive.com/search?l=mid=1474181496-24846-1-git-send-email-lstipa...@gmail.com Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind rega

Re: [Openvpn-devel] [PATCH applied] Incorporate the Debian typo fixes where appropriate and make show_opt default message clearer

2016-09-18 Thread Gert Doering
appropriate and make show_opt default message clearer Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <1468495519-25102-1-git-send-email-a...@rfc2549.org> URL: http://www.mail-archive.com/search?l=mid=1468495519-25102-1-git-send-email-a...@rfc2549.org Signed-

[Openvpn-devel] [PATCHv2] Fix win32 building with C99 mode

2016-09-18 Thread Gert Doering
In -std=c99 mode, WIN32 is not defined to be "1" anymore, but just "#define WIN32" - so the "#if WIN32" breaks, needs to be "#ifdef WIN32" v2: also fix block_dns.c (include config.h + compat.h) (Selva Nair) Signed-off-by: Gert Doering <g...@greenie.mu

Re: [Openvpn-devel] [PATCH] cppcheck finding: add "ASSERT( maxoutput > 0 || separator != NULL )" to prevent possible null pointer derefence

2016-09-18 Thread Gert Doering
lly mention the PR in the commit message - "commit --amend" before sending) gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie

[Openvpn-devel] [PATCH applied] Re: Fix win32 building with C99 mode

2016-09-18 Thread Gert Doering
Patch has been applied to the master branch. commit 6cd7e08d89cc9c39d00989866fb4782d5e7041dc Author: Gert Doering Date: Sun Sep 18 14:14:23 2016 +0200 Fix win32 building with C99 mode Signed-off-by: Gert Doering <g...@greenie.muc.de> Acked-by: Selva Nair <selva.n...@

Re: [Openvpn-devel] [PATCH] Fix win32 building with C99 mode

2016-09-18 Thread Gert Doering
the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025g...@net.informatik.tu-muenchen.de signature.

[Openvpn-devel] [PATCH] Fix t_client runs on OpenSolaris

2016-09-20 Thread Gert Doering
"grep -q" is not portable to non-GNU grep. Replace with ">/dev/null". Signed-off-by: Gert Doering <g...@greenie.muc.de> --- tests/t_client.sh.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/t_client.sh.in b/tests/t_client.sh.in

Re: [Openvpn-devel] [PATCH] Have the same username/password length regardless of PKCS#11 enablement

2016-09-22 Thread Gert Doering
ll, to send a 4k username and password in the OpenVPN handshake? James tells us the space for --push-peer-info is "limited", and username+password share the very same space...) gert -- USENET is *not* the non-clickable part of WWW!

Re: [Openvpn-devel] [PATCH] enable "--disable-crypto" build configuration

2016-09-26 Thread Gert Doering
then complain that I'm slow doing it" is a very trusted way to get moved all the way DOWN on my priority list. Like, "I might think about this next May". gert -- USENET is *not* the non-clickable part of WWW! /

Re: [Openvpn-devel] [PATCH applied] enable --disable-crypto build configuration for travis

2016-09-26 Thread Gert Doering
figuration for travis Acked-by: Steffan Karger <steffan.kar...@fox-it.com> Message-Id: <1474109679-4982-1-git-send-email-chipits...@gmail.com> URL: http://www.mail-archive.com/search?l=mid=1474109679-4982-1-git-send-email-chipits...@gmail.com Signed-o

Re: [Openvpn-devel] [PATCH] Make sure options->ciphername and options->authname are always defined

2016-09-28 Thread Gert Doering
ease verify that it's all as it should be :-) commit 348c416face9a025b618ebcae9d3a74c5a4a242b Author: Steffan Karger <stef...@karger.me> Date: Wed Sep 28 12:40:51 2016 +0200 Make sure options->ciphername and options->authname are always defined Signed-off-by: Steffan Karger <stef...@karger.me>

[Openvpn-devel] [PATCH] make t_client robust against sudoers misconfiguration

2016-10-02 Thread Gert Doering
cially on the buildbots) that can correctly start openvpn but then not stop it later on - leaving openvpn processes dangling around, requiring manual intervention. Signed-off-by: Gert Doering <g...@greenie.muc.de> --- tests/t_client.sh.in | 14 +++--- 1 file changed, 7 insertions(+), 7 del

Re: [Openvpn-devel] [PATCH] Fix win32 building with C99 mode

2016-10-02 Thread Gert Doering
Hi, On Sun, Sep 18, 2016 at 10:15:56PM +0200, Gert Doering wrote: > On Sun, Sep 18, 2016 at 10:20:16AM -0400, Selva Nair wrote: > > Yeah, to me that only confirms my feeling that #ifdef WIN32 is not > > reliable. Much better to use _WIN32 which appears to be defined by all (?)

Re: [Openvpn-devel] [PATCH applied] Automatically cache expected IPs for t_client.sh on the first run

2016-10-04 Thread Gert Doering
ml Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slash

Re: [Openvpn-devel] [PATCH applied] make t_client robust against sudoers misconfiguration

2016-10-04 Thread Gert Doering
Patch has been applied to the following branches commit 8ca29af7c6d4759ce019ec9d0cd3eae4511a6804 (master) commit 0bd4ef0a18c65bfbd4e5b08735d7bb67dd010b97 (release/2.3) Author: Gert Doering Date: Sun Oct 2 15:19:23 2016 +0200 make t_client robust against sudoers misconfiguration

[Openvpn-devel] [PATCH] add POSTINIT_CMD_suf to t_client.sh and sample config

2016-10-04 Thread Gert Doering
We have pre-init and cleanup commands, but some test cases might need or want to run a shell script after openvpn has initialized, but before executing any tests (ifconfig comparison and ping). Example: POSTINIT_CMD_4="sleep 5" on MacOS X for tap tests (IPv6 DAD) Signed-off-by: Gert

Re: [Openvpn-devel] [PATCH applied] add POSTINIT_CMD_suf to t_client.sh and sample config

2016-10-04 Thread Gert Doering
Your patch has been applied to the following branches commit bae1ad7005fd9a1fadeed56370a9ac5422a33fee (master) commit 7891c8ce93b33749ee75ab579aa391bc5eab6e2f (release/2.3) Author: Gert Doering Date: Tue Oct 4 13:38:54 2016 +0200 add POSTINIT_CMD_suf to t_client.sh and sample config

Re: [Openvpn-devel] [PATCH] man page: Update the --cipher section to reflect recommendations after SWEET32

2016-10-05 Thread Gert Doering
and SWEET32. gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025g...@net.informatik

Re: [Openvpn-devel] Slight change to buildbot t_client.sh.in & t_client.rc

2016-10-06 Thread Gert Doering
it would *fail* your tests that succeed today due to compression :-) ) gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89

Re: [Openvpn-devel] Architecture diagram & Theory of Operation documents

2010-11-12 Thread Gert Doering
WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025g...@net.informatik.tu-muenchen.de pgp0uJmVFTiMN.pgp Description: PGP signature

Re: [Openvpn-devel] [PATCH] Removed hardcoded signtool dependency from win/build_all.py

2010-11-12 Thread Gert Doering
en manage > to install the unsigned TUN/TAP driver with some tweaking. Isn't the openvpn.exe signed as well? gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany

Re: [Openvpn-devel] [PATCH 1/6] Use stricter snprintf() formatting in socks_username_password_auth()

2010-11-15 Thread Gert Doering
ck + error above the snprintf() block. gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025

Re: [Openvpn-devel] [PATCH] Use stricter snprintf() formatting in socks_username_password_auth() (v2)

2010-11-15 Thread Gert Doering
ot;Authentiaction not possible."); I'd ack this but for the spelling typo :-) (Sorry, but, well, these things tend to stick...) gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Ge

Re: [Openvpn-devel] how to limite the bandwidth of every client ?

2010-12-11 Thread Gert Doering
ting such a bad thing? > > A: Top-posting. > > Q: What is the most annoying thing in e-mail? gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany

  1   2   3   4   5   6   7   8   9   10   >