Re: [HACKERS] remove wal_level archive

On 2 November 2015 at 14:19, Michael Paquier wrote: > pg_upgradecluster has some logic to switch a parameter value (see > strrepl) That's part of pg_wrapper, not core, though. I'd quite like to see pg_wrapper become part of the PGDG RPMs, but right now AFAIK it's a

Re: [HACKERS] ALTER SYSTEM vs symlink

Andrew Dunstan writes: > I don't know if this was discussed at the time ALTER SYSTEM was > implemented, but I have just discovered that if postgresql.auto.conf is > a symlink to a file elsewhere, ALTER SYSTEM will happily break that link > and write its own local copy.

Re: [HACKERS] ALTER SYSTEM vs symlink

On 11/02/2015 09:36 AM, Tom Lane wrote: Andrew Dunstan writes: I don't know if this was discussed at the time ALTER SYSTEM was implemented, but I have just discovered that if postgresql.auto.conf is a symlink to a file elsewhere, ALTER SYSTEM will happily break that link

Re: [HACKERS] fortnight interval support

On 11/02/2015 09:20 AM, Merlin Moncure wrote: On Sun, Nov 1, 2015 at 2:20 PM, David Fetter wrote: On Sun, Nov 01, 2015 at 01:06:39PM -0500, Tom Lane wrote: David Fetter writes: On Tue, Oct 27, 2015 at 07:30:13PM +, Nathan Wagner wrote: On Wed, Oct

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

On Mon, Nov 2, 2015 at 1:17 PM, Craig Ringer wrote: > Hi all > > I'd like to submit pglogical_output for inclusion in the 9.6 series as > a contrib. Yay, that looks pretty advanced! :-) Still digesting... -- Alex

Re: [HACKERS] ALTER SYSTEM vs symlink

On 2015-11-02 09:43:02 -0500, Stephen Frost wrote: > What this request strikes me as asking for is the same as what I asked > for when this feature was originally going in- there should be a way to > disable it. You can just revoke permissions on the file if necessary. Results in the expected

Re: [HACKERS] ALTER SYSTEM vs symlink

* Andrew Dunstan (and...@dunslane.net) wrote: > On 11/02/2015 09:36 AM, Tom Lane wrote: > >Andrew Dunstan writes: > >>I don't know if this was discussed at the time ALTER SYSTEM was > >>implemented, but I have just discovered that if postgresql.auto.conf is > >>a symlink to a

Re: [HACKERS] fortnight interval support

On Sun, Nov 1, 2015 at 2:20 PM, David Fetter wrote: > On Sun, Nov 01, 2015 at 01:06:39PM -0500, Tom Lane wrote: >> David Fetter writes: >> > On Tue, Oct 27, 2015 at 07:30:13PM +, Nathan Wagner wrote: >> >> On Wed, Oct 28, 2015 at 08:17:25AM +1300, Gavin

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

On 2 November 2015 at 20:17, Craig Ringer wrote: > Hi all > > I'd like to submit pglogical_output for inclusion in the 9.6 series as > a contrib. Here's the protocol documentation discussed in the README. It's asciidoc at the moment, so it can be formatted into something

Re: [HACKERS] ALTER SYSTEM vs symlink

* Andres Freund (and...@anarazel.de) wrote: > On 2015-11-02 09:43:02 -0500, Stephen Frost wrote: > > What this request strikes me as asking for is the same as what I asked > > for when this feature was originally going in- there should be a way to > > disable it. > > You can just revoke

Re: [HACKERS] ALTER SYSTEM vs symlink

Stephen Frost writes: > * Andres Freund (and...@anarazel.de) wrote: >> You can just revoke permissions on the file if necessary. Results in the >> expected >> ERROR: XX000: could not open file "../postgresql.auto.conf": Permission >> denied > Yes, I know, but that's a

Re: [HACKERS] Patent warning about the Greenplum source code

On 1 November 2015 at 07:47, Bruce Momjian wrote: > On Sun, Nov 1, 2015 at 01:27:13AM -0500, Bruce Momjian wrote: > > On Fri, Oct 30, 2015 at 04:47:35AM -0400, Bruce Momjian wrote: > > > Therefore, I caution people from viewing the Greenplum source code as > > > you might see

Re: [HACKERS] Patent warning about the Greenplum source code

On 11/02/2015 02:41 PM, Simon Riggs wrote: On 1 November 2015 at 07:47, Bruce Momjian > wrote: On Sun, Nov 1, 2015 at 01:27:13AM -0500, Bruce Momjian wrote: > On Fri, Oct 30, 2015 at 04:47:35AM -0400, Bruce Momjian wrote: > > Therefore, I

Re: [HACKERS] ALTER SYSTEM vs symlink

* Tom Lane (t...@sss.pgh.pa.us) wrote: > Andrew Dunstan writes: > > I don't know if this was discussed at the time ALTER SYSTEM was > > implemented, but I have just discovered that if postgresql.auto.conf is > > a symlink to a file elsewhere, ALTER SYSTEM will happily break

[HACKERS] ALTER SYSTEM vs symlink

I don't know if this was discussed at the time ALTER SYSTEM was implemented, but I have just discovered that if postgresql.auto.conf is a symlink to a file elsewhere, ALTER SYSTEM will happily break that link and write its own local copy. That strikes me as rather unfriendly. Why not just

Re: [HACKERS] ALTER SYSTEM vs symlink

Robert Haas writes: > On Mon, Nov 2, 2015 at 10:14 AM, Tom Lane wrote: >> While I won't stand in the way if someone is dead set on providing a >> disable switch for ALTER SYSTEM, I fail to see the point of one. > I have not seen much evidence that the

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

On 2 November 2015 at 20:17, Craig Ringer wrote: > Hi all > > I'd like to submit pglogical_output for inclusion in the 9.6 series as > a contrib. A few points are likely to come up in anything but the most cursory examination of the patch. The README alludes to protocol

Re: [HACKERS] ALTER SYSTEM vs symlink

On 11/02/2015 09:24 AM, Stephen Frost wrote: > I certainly look forward to having more fine grained control, to the > point where I'd like to be able to run a system reasonably without an > active superuser login. Having superusers logging into production > running databases is extremely

Re: [HACKERS] ALTER SYSTEM vs symlink

On Mon, Nov 2, 2015 at 11:39 AM, Stephen Frost wrote: > This is all very environment specific. Changes to postgresql.conf, in > many environments, go through a serious of tests before being deployed > by a CM system. How do we accomplish the same kind of tests before >

Re: [HACKERS] remove wal_level archive

On Mon, Nov 2, 2015 at 12:21 AM, Craig Ringer wrote: > We need to keep both, IMO, with 'archive' as an obsolete synonym for > hot_standby. > > Otherwise pg_upgrade will get grumpy, and so will users who migrate > their configurations. Removing options entirely arguably

Re: [HACKERS] Patent warning about the Greenplum source code

On 11/01/2015 06:37 PM, Bruce Momjian wrote: > Let me add that this is more than hypothetical. While we don't think > any of these companies would sue the community for patent infringement, > they could sue users, and the company could be bought by a sinister > company that could enforce those

Re: [HACKERS] ALTER SYSTEM vs symlink

On Mon, Nov 2, 2015 at 10:14 AM, Tom Lane wrote: > Stephen Frost writes: >> * Andres Freund (and...@anarazel.de) wrote: >>> You can just revoke permissions on the file if necessary. Results in the >>> expected >>> ERROR: XX000: could not open file

Re: [HACKERS] WIP: Rework access method interface

Tom Lane wrote: > Probably the least messy way to fix this is to drop that #include and > instead use dummy declarations like "struct PlannerInfo;" and "struct > IndexPath;" here. We could additionally dumb the amcostestimate > declaration down from using "Cost" and "Selectivity" to just saying

Re: [HACKERS] remove wal_level archive

On 11/2/15 12:21 AM, Craig Ringer wrote: On 1 September 2015 at 10:39, Peter Eisentraut wrote: So we've had several rounds of discussions about simplifying replication configuration in general and the wal_level setting in particular. [0][1] [snip] Bike-shedding: In this

Re: [HACKERS] ALTER SYSTEM vs symlink

* Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Andres Freund (and...@anarazel.de) wrote: > >> You can just revoke permissions on the file if necessary. Results in the > >> expected > >> ERROR: XX000: could not open file "../postgresql.auto.conf":

Re: [HACKERS] exposing pg_controldata and pg_config as functions

On 10/30/2015 06:53 AM, Erik Rijkers wrote: >> [2015082503-pgconfig_controldata.diff] > > I tried to build this, and the patch applies cleanly but then a ld error > emerges: I'm sure the patch would need to be rebased, but the last thread died with significant complaints and questions about what

Re: [HACKERS] Request: pg_cancel_backend variant that handles 'idle in transaction' sessions

>> > >> That sounds to be a solution for this problem or otherwise for such a > case > >> can't we completely abort the active transaction and set a flag like > >> PrevCommandFailed/PrevTransFailed and on receiving next message if > >> such a flag is set, then throw an appropriate error. > > > >

Re: [HACKERS] Patch: Implement failover on libpq connect level.

On 10/30/15 9:26 AM, Robert Haas wrote: > That's true, but doesn't allowing every parameter to be multiply > specified greatly increase the implementation complexity for a pretty > marginal benefit? Well, the way I would have approached is that after all the parsing you end up with a list of

Re: [HACKERS] WIP: Rework access method interface

Tom Lane wrote: > I follow your reasoning, but I don't particularly want to make this > patch wait on a large and invasive refactoring of existing headers. Sure. > As a down payment on this problem, maybe we could invent a new planner > header that provides just enough info to support amapi.h

Re: [HACKERS] ALTER SYSTEM vs symlink

On 11/02/2015 08:33 AM, Stephen Frost wrote: > A deeper hook in the ALTER SYSTEM might be another approach, or one > in the GUC system to allow external libraries to control what various > GUCs can be set to (either via ALTER SYSTEM or through regular SET > calls). I have run into multiple

Re: [HACKERS] WIP: Rework access method interface

Alvaro Herrera writes: > Tom Lane wrote: >> As a down payment on this problem, maybe we could invent a new planner >> header that provides just enough info to support amapi.h and fdwapi.h; >> it looks like this would be "typedef struct PlannerInfo PlannerInfo;", >>

Re: [HACKERS] ALTER SYSTEM vs symlink

On 11/02/2015 06:36 AM, Tom Lane wrote: > Andrew Dunstan writes: >> I don't know if this was discussed at the time ALTER SYSTEM was >> implemented, but I have just discovered that if postgresql.auto.conf is >> a symlink to a file elsewhere, ALTER SYSTEM will happily break

Re: [HACKERS] exposing pg_controldata and pg_config as functions

Erik Rijkers wrote: > utils/fmgrtab.o:(.rodata+0x19f78): undefined reference to `_null_' > utils/fmgrtab.o:(.rodata+0x1a078): undefined reference to `_null_' The fix for this is to add a parallel-safe flag to new pg_proc.h lines. -- Álvaro Herrerahttp://www.2ndQuadrant.com/

Re: [HACKERS] fortnight interval support

On 02/11/15 07:06, Tom Lane wrote: David Fetter writes: On Tue, Oct 27, 2015 at 07:30:13PM +, Nathan Wagner wrote: On Wed, Oct 28, 2015 at 08:17:25AM +1300, Gavin Flower wrote: I had actually written: > You trying to get PostgreSQL banned in France??? > > When I was

[HACKERS]

On Mon, Nov 2, 2015 at 10:36 AM, Josh Berkus wrote: > Not as often as you'd think, and it hasn't happened in the database > world yet, for some good reasons. This is all besides the point, > though; PostgreSQL has been accepting contributions from patent-holding > companies

Re: [HACKERS] Patent warning about the Greenplum source code

On Mon, Nov 2, 2015 at 10:36:48AM -0800, Josh Berkus wrote: > > but when Oracle bought Sun, more people > > were concerned. Someone could buy the company _just_ to sue for patent > > infringement --- happens all the time. > > Not as often as you'd think, and it hasn't happened in the database >

Re: [HACKERS] [ADMIN] Replication slots and isolation levels

> 2 нояб. 2015 г., в 23:37, Robert Haas написал(а): > > On Fri, Oct 30, 2015 at 9:49 AM, Vladimir Borodin wrote: >> I’ve tried two ways - bare SELECT in autocommit mode and BEGIN; SELECT; >> ROLLBACK. I first described the problem in thread on

Re: [HACKERS] WIP: Rework access method interface

On 2015-11-02 23:28, Tom Lane wrote: Alvaro Herrera writes: Tom Lane wrote: Regardless of that, I'm a bit skeptical that any of these structs ought to be defined as part of the amapi.h interface. They seem to be making premature judgments as to what an opclass

Re: [HACKERS] NOTIFY in Background Worker

On Sat, Aug 29, 2015 at 12:55 PM, Thomas Munro wrote: > On Sat, Aug 29, 2015 at 9:03 AM, Thomas Munro > wrote: >> >> On Fri, Aug 28, 2015 at 10:30 PM, jacques klein >> wrote: >>> >>> Hello, >>> >>> I

Re: [HACKERS] [ADMIN] Replication slots and isolation levels

On Fri, Oct 30, 2015 at 9:49 AM, Vladimir Borodin wrote: > I’ve tried two ways - bare SELECT in autocommit mode and BEGIN; SELECT; > ROLLBACK. I first described the problem in thread on pgsql-admin@ [0], there > is copy-paste from psql there, but during conversation initial

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

On 11/2/15 8:36 AM, Craig Ringer wrote: Here's the protocol documentation discussed in the README. It's asciidoc at the moment, so it can be formatted into something with readable tables. Is this by chance up on github? It'd be easier to read the final output there than the raw asciidoctor.

Re: [HACKERS] Patch to install config/missing

On Fri, Oct 30, 2015 at 2:42 PM, Jim Nasby wrote: > Currently, config/missing isn't being installed. This can lead to confusing > error messages, such as if Perl isn't found and something needs it [1]. > Attached patch adds it to install and uninstall recipes. I find it

Re: [HACKERS] Request: pg_cancel_backend variant that handles 'idle in transaction' sessions

On 11/2/15 11:15 AM, Pavel Stehule wrote: I have not strong idea about how to solve it well - maybe introduce transaction_idle_timeout and session_idle_timeout? Yes, please. This is a very common problem. I would love a better way to detect (or prevent) clients from being brain-dead about how

Re: [HACKERS] ALTER SYSTEM vs symlink

* Robert Haas (robertmh...@gmail.com) wrote: > On Mon, Nov 2, 2015 at 11:39 AM, Stephen Frost wrote: > > This is all very environment specific. Changes to postgresql.conf, in > > many environments, go through a serious of tests before being deployed > > by a CM system. How

Re: [HACKERS] Dangling Client Backend Process

On 30 October 2015 20:33, Andres Freund Wrote: >On 2015-10-30 10:57:45 -0400, Tom Lane wrote: >> Andres Freund writes: >> > adding a parseInput(conn) into the loop yields the expected >> > FATAL: 57P01: terminating connection due to unexpected postmaster >> > exit Is there

Re: [HACKERS] onlyvalue aggregate (was: First Aggregate Funtion?)

On 28 October 2015 at 16:50, Marko Tiikkaja wrote: > Hi, > > Here's a patch for the aggregate function outlined by Corey Huinker in > CADkLM=foA_oC_Ri23F9PbfLnfwXFbC3Lt8bBzRu3=cb77g9...@mail.gmail.com . +1. I've wanted something like this a few times. Of the names suggested so far,

Re: [HACKERS] WIP: Rework access method interface

Alexander Korotkov writes: > Tom, could you take a look at them? I started to look at this today. (Apologies for the delay, but I came back from San Francisco with a nasty head cold, and wasn't really up to doing anything complicated last week.) The thing that jumps

Re: [HACKERS] ALTER SYSTEM vs symlink

Robert, Tom, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Robert Haas writes: > > I would be willing to wager that a lot more people will hose their > > systems by avoiding ALTER SYSTEM than will do so by using it. > > Well, mumble --- the subtext I thought I was hearing from

Re: [HACKERS] ALTER SYSTEM vs symlink

* Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> Well, mumble --- the subtext I thought I was hearing from Stephen was > >> that he'd not give his DBAs write access on postgresql.conf either. > >> But yes, pushing

Re: [HACKERS] ALTER SYSTEM vs symlink

Stephen Frost writes: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> How is it that we don't need rolcatupdate but we do need a way to shut >> off ALTER SYSTEM? Doesn't compute, IMO. > I'd like the ability to control all of the above, ultimately. I don't > believe that we

Re: [HACKERS] ALTER SYSTEM vs symlink

Stephen Frost writes: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> Well, mumble --- the subtext I thought I was hearing from Stephen was >> that he'd not give his DBAs write access on postgresql.conf either. >> But yes, pushing people away from ALTER SYSTEM and towards manual

Re: [HACKERS] proposal: PL/Pythonu - function ereport

Hello, Here's a detailed review: 1. in PLy_spi_error__init__ you need to check kw for NULL before doing PyDict_Size(kw) otherwise for plpy.SPIError() you get Bad internal call because PyDict_Size expects a real dictionary not NULL 2. a test with just plpy.SPIError() is still missing, this would

Re: [HACKERS] Request: pg_cancel_backend variant that handles 'idle in transaction' sessions

On Mon, Nov 2, 2015 at 1:28 AM, Pavel Stehule wrote: > > > 2015-11-02 5:23 GMT+01:00 Amit Kapila : >> >> On Sun, Nov 1, 2015 at 11:34 PM, Tom Lane wrote: >> > >> > Magnus Hagander writes: >> > > On Sat,

Re: [HACKERS] WIP: Rework access method interface

Alvaro Herrera writes: > Tom Lane wrote: >> Probably the least messy way to fix this is to drop that #include and >> instead use dummy declarations like "struct PlannerInfo;" and "struct >> IndexPath;" here. We could additionally dumb the amcostestimate >> declaration

Re: [HACKERS] Patch to install config/missing

Robert Haas wrote: > On Fri, Oct 30, 2015 at 2:42 PM, Jim Nasby wrote: > > Currently, config/missing isn't being installed. This can lead to confusing > > error messages, such as if Perl isn't found and something needs it [1]. > > Attached patch adds it to install and

Re: [HACKERS] WIP: Rework access method interface

Alvaro Herrera writes: > Tom Lane wrote: >> ... btw, what is the point of catalog/opfam_internal.h? I see you added >> it in b488c580aef4e05f, but it seems quite useless to have split it out >> as a separate header, since only commands/opclasscmds.c uses it. > Oh, that

Re: [HACKERS] WIP: Rework access method interface

... btw, what is the point of catalog/opfam_internal.h? I see you added it in b488c580aef4e05f, but it seems quite useless to have split it out as a separate header, since only commands/opclasscmds.c uses it. My attention got drawn to it because the current patch proposes to #include it in

Re: [HACKERS] Patch to install config/missing

Robert Haas writes: > On Fri, Oct 30, 2015 at 2:42 PM, Jim Nasby wrote: >> Currently, config/missing isn't being installed. This can lead to confusing >> error messages, such as if Perl isn't found and something needs it [1]. >> Attached patch

Re: [HACKERS] ParallelContexts can get confused about which worker is which

On Sun, Nov 1, 2015 at 1:11 AM, Amit Kapila wrote: > If we are going to add a new parameter to BackgroundWorker structure, > then the same needs to be updated in docs [1] as well. Right, good point. > I think adding > a new parameter to this structure might require some

Re: [HACKERS] WIP: Rework access method interface

Tom Lane wrote: > ... btw, what is the point of catalog/opfam_internal.h? I see you added > it in b488c580aef4e05f, but it seems quite useless to have split it out > as a separate header, since only commands/opclasscmds.c uses it. > > My attention got drawn to it because the current patch

Re: [HACKERS] ALTER SYSTEM vs symlink

On Mon, Nov 2, 2015 at 3:41 PM, Stephen Frost wrote: >> Two different methods of restricting ALTER SYSTEM have already been >> discussed on this thread: one using file permissions, and the other >> using ProcessUtility_hook. I personally think that's good enough. > > The

Re: [HACKERS] WIP: Rework access method interface

Tom Lane wrote: > Alvaro Herrera writes: > > Tom Lane wrote: > >> ... btw, what is the point of catalog/opfam_internal.h? I see you added > >> it in b488c580aef4e05f, but it seems quite useless to have split it out > >> as a separate header, since only

Re: [HACKERS] eXtensible Transaction Manager API

On 31 October 2015 at 10:22, konstantin knizhnik wrote: > Hi, > > PostgresPro cluster team wants to announce proposal for eXtensible > Transaction Manager API and reference implementation of distributed > transaction manager (pg_dtm). > pg_dtm is just a standard

Re: [HACKERS] onlyvalue aggregate (was: First Aggregate Funtion?)

On 2 November 2015 at 09:32, Dean Rasheed wrote: > On 28 October 2015 at 16:50, Marko Tiikkaja wrote: > > Hi, > > > > Here's a patch for the aggregate function outlined by Corey Huinker in > >

Re: [HACKERS] WIP: Rework access method interface

Tom Lane wrote: > Alvaro Herrera writes: > > Tom Lane wrote: > >>> ... btw, what is the point of catalog/opfam_internal.h? > > > The whole point of splitting the struct declaration to a new header was > > to get a DDL deparser to examine the list of objects being

Re: [HACKERS] Parallel Seq Scan

On Fri, Oct 30, 2015 at 11:12 PM, Noah Misch wrote: > On Wed, Oct 28, 2015 at 01:04:12AM +0100, Robert Haas wrote: >> Well, OK. That's not strictly a correctness issue, but here's an >> updated patch along the lines you suggested. > >> Finally, have setup_param_list set a new

Re: [HACKERS] WIP: Rework access method interface

Alvaro Herrera writes: > Tom Lane wrote: >> I'm kind of inclined to just let the verifiers read the catalogs for >> themselves. AFAICS, a loop around the results of SearchSysCacheList >> is not going to be significantly more code than what this patch does, >> and it

[HACKERS] Weighted Stats

Folks, I'd like to add weighted statistics to PostgreSQL. While the included weighted_avg() is trivial to calculate using existing machinery, the included weighted_stddev_*() functions are not. I've only done the float8 versions, but if we decide to move forward, I'd be delighted to add the

Re: [HACKERS] Freeze avoidance of very large table.

On Sat, Oct 31, 2015 at 1:32 AM, Amit Kapila wrote: > On Thu, Oct 8, 2015 at 11:05 PM, Simon Riggs wrote: >> >> On 1 October 2015 at 23:30, Josh Berkus wrote: >>> >>> On 10/01/2015 07:43 AM, Robert Haas wrote: >>> > On Thu, Oct

Re: [HACKERS] WIP: Rework access method interface

Alvaro Herrera writes: > Tom Lane wrote: >>> ... btw, what is the point of catalog/opfam_internal.h? > The whole point of splitting the struct declaration to a new header was > to get a DDL deparser to examine the list of objects being created, so > that it could

Re: [HACKERS] Patch to install config/missing

On Nov 2, 2015, at 1:07 PM, Tom Lane wrote: > I wonder how much we need that script at all though. If, say, configure > doesn't find bison, what's so wrong with just defining BISON=bison and > letting the usual shell "bison: command not found" error leak through? +1 This

Re: [HACKERS] extend pgbench expressions with functions

On Fri, Oct 30, 2015 at 1:01 PM, Fabien COELHO wrote: > Here is a v12 which implements the suggestions below. Sorry it's taken me so long to get around to looking at this. Some thoughts on an initial read-through: 1. I think there should really be two patches here, the

Re: [HACKERS] ALTER ... OWNER TO ... vs. ALTER DEFAULT PRIVILEGES

On Sat, Oct 31, 2015 at 10:42 AM, David Fetter wrote: > On Sat, Oct 31, 2015 at 12:16:31AM +0100, Robert Haas wrote: >> On Thu, Oct 29, 2015 at 10:31 PM, David Fetter wrote: >> > Had this been part of the original ALTER DEFAULT PRIVILEGES patch, >> > those

Re: [HACKERS] onlyvalue aggregate (was: First Aggregate Funtion?)

On 2 November 2015 at 10:59, Marko Tiikkaja wrote: > On 11/2/15 9:32 AM, Dean Rasheed wrote: >> >> On 28 October 2015 at 16:50, Marko Tiikkaja wrote: >>> >>> Here's a patch for the aggregate function outlined by Corey Huinker in >>>

Re: [HACKERS] onlyvalue aggregate (was: First Aggregate Funtion?)

On 11/2/15 12:40 PM, Dean Rasheed wrote: I'm not sure what you mean when you say accepting NULLs can hide bugs. I think that if the input values to the aggregate were 1,1,1,NULL,1,1,1 then it should raise an error. ITSM that that is more likely to reveal problems with your underlying data or the

Re: [HACKERS] WIP: Access method extendability

Hi! Thank you for review! On Mon, Sep 7, 2015 at 6:41 PM, Teodor Sigaev wrote: > Some notices: > > 1) create-am.3.patch.gz > As I understand, you didn't add schema name to access method. Why? > Suppose, if we implement SQL-like interface for AM screation/dropping then > we

Re: [HACKERS] onlyvalue aggregate (was: First Aggregate Funtion?)

On 2 November 2015 at 09:10, Simon Riggs wrote: > I think we should avoid using ONLY or VALUE within the names since those > already have other meanings in Postgres. > We already have window functions called first_value, last_value and nth_value, so I think use of "value"

Re: [HACKERS] onlyvalue aggregate (was: First Aggregate Funtion?)

On 11/2/15 9:32 AM, Dean Rasheed wrote: On 28 October 2015 at 16:50, Marko Tiikkaja wrote: Here's a patch for the aggregate function outlined by Corey Huinker in CADkLM=foA_oC_Ri23F9PbfLnfwXFbC3Lt8bBzRu3=cb77g9...@mail.gmail.com . +1. I've wanted something like this a few

[HACKERS] Re: Why not to use 'pg_ctl start -D ../data' to register posgtresql windows service

Yup, I think I totally understand now, the registered postgres service is different from "pg_ctl start". To start the postgres windows service needs privileged prompt (to execute net or sc command) or manually(start or stop in windows service list).After the service is started, it can be

Re: [HACKERS] eXtensible Transaction Manager API

On 02.11.2015 12:01, Simon Riggs wrote: At first I was concerned about recovery, but that looks to be covered. Yes, we have not considered all possible scenarios of working with PostgreSQL. We have tested work with different isolation levels: repeatable read and read committed, but we

Re: [HACKERS] Personal note: changing employers

David, * David Fetter (da...@fetter.org) wrote: > It's great that you're doing what you want to do. I take it that > Crunchy's model involves more FOSS and less special sauce... The short answer is yes, Crunchy is committed to FOSS. Further discussion isn't really appropriate for this list,

Re: [HACKERS] Re: Why not to use 'pg_ctl start -D ../data' to register posgtresql windows service

On Mon, Nov 2, 2015 at 9:30 PM, Michael Paquier wrote: > On Mon, Nov 2, 2015 at 4:27 PM, YuanyuanLiu wrote: >> When we registered postgresql windows service named "postgres-9.4", >> we can start the postgresql server by manually starting the

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

Hi, On 2015-11-02 20:17:21 +0800, Craig Ringer wrote: > I'd like to submit pglogical_output for inclusion in the 9.6 series as > a contrib. Cool! > See the README.md and DESIGN.md in the attached patch for details on > the plugin. I will follow up with a summary in a separate mail, along > with

Re: [HACKERS] eXtensible Transaction Manager API

On 02.11.2015 06:17, Craig Ringer wrote: On 31 October 2015 at 17:22, konstantin knizhnik wrote: Waiting for your feedback For anyone wondering about performance impact, there are some graphs on page 23 of the PDF presentation. I didn't see anything else, and the

Re: [HACKERS] Re: Why not to use 'pg_ctl start -D ../data' to register posgtresql windows service

On Mon, Nov 2, 2015 at 4:27 PM, YuanyuanLiu wrote: > When we registered postgresql windows service named "postgres-9.4", > we can start the postgresql server by manually starting the windows service > , runing command "net stop postgres-9.4" (need user with

Re: [HACKERS] September 2015 Commitfest

On Sun, Nov 1, 2015 at 7:36 PM, Michael Paquier wrote: > On Sun, Nov 1, 2015 at 1:53 AM, Marko Tiikkaja wrote: >> On 10/31/15 12:42 AM, Michael Paquier wrote: >>> >>> So, seeing nothing happening I have done the above, opened 2015-11 CF >>> and closed the

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

On 2 November 2015 at 20:35, Andres Freund wrote: > On 2015-11-02 20:17:21 +0800, Craig Ringer wrote: > >> See the README.md and DESIGN.md in the attached patch for details on >> the plugin. I will follow up with a summary in a separate mail, along >> with a few points I'd

[HACKERS] Building from git source on ubuntu with gssapi

I can't ./configure --with-gssapi from git on ubuntu 14.04.3 because: configure: error: gssapi.h header file is required for GSSAPI If I download the distribution-specific 9.3 source with apt, I find their secret sauce to make it work: ./debian/rules:LDFLAGS+= -Wl,--as-needed

Re: [HACKERS] Request: pg_cancel_backend variant that handles 'idle in transaction' sessions

On Mon, Nov 2, 2015 at 10:45 PM, Pavel Stehule wrote: > > > It is 100% true. But the users can do strange things. If we solve idle > transactions and not idle session, then they are able to increase > max_connections to thousands with happy smile in face. > > I have not

Re: [HACKERS] [BUGS] BUG #12989: pg_size_pretty with negative values

On Sat, Oct 31, 2015 at 2:25 PM, Julien Rouhaud wrote: > I just reviewed your patch, everything looks fine for me. Maybe some > minor cosmetic changes could be made to avoid declaring too many vars, > but I think a committer would have a better idea on this, so I mark >

Re: [HACKERS] proposal: multiple psql option -c

On Sat, Oct 31, 2015 at 2:50 PM, Pavel Stehule wrote: > fixed patch attached The documentation included in this patch doesn't really make it clear why -g is different from or better than -c. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise

Re: [HACKERS] ALTER SYSTEM vs symlink

On Mon, Nov 2, 2015 at 10:13 PM, Amit Kapila wrote: > I think that is the sensible way to deal with this and any other such > parameters. We already have a way to disallow setting of individual > parameters (GUC_DISALLOW_IN_AUTO_FILE) via Alter System. > Currently we

Re: [HACKERS] Freeze avoidance of very large table.

On Tue, Nov 3, 2015 at 5:04 AM, Robert Haas wrote: > > On Sat, Oct 31, 2015 at 1:32 AM, Amit Kapila wrote: > > > > What is your main worry about changing the name of this map, is it > > about more code churn or is it about that we might introduce

Re: [HACKERS] a raft of parallelism-related bug fixes

On Wed, Oct 28, 2015 at 10:23 AM, Robert Haas wrote: > On Sun, Oct 18, 2015 at 12:17 AM, Robert Haas wrote: >>> So reviewing patch 13 isn't possible without prior knowledge. >> >> The basic question for patch 13 is whether ephemeral record types can

Re: [HACKERS] Building from git source on ubuntu with gssapi

Jeff Janes writes: > I can't ./configure --with-gssapi from git on ubuntu 14.04.3 because: > > configure: error: gssapi.h header file is required for GSSAPI > > If I download the distribution-specific 9.3 source with apt, I find > their secret sauce to make it work: > >

Re: [HACKERS] Building from git source on ubuntu with gssapi

Jeff Janes writes: > I can't ./configure --with-gssapi from git on ubuntu 14.04.3 because: > configure: error: gssapi.h header file is required for GSSAPI > If I download the distribution-specific 9.3 source with apt, I find > their secret sauce to make it work: >

Re: [HACKERS] ALTER SYSTEM vs symlink

On Mon, Nov 2, 2015 at 10:17 PM, Tom Lane wrote: > > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> How is it that we don't need rolcatupdate but we do need a way to shut > >> off ALTER SYSTEM? Doesn't compute, IMO. > > > I'd like

Re: [HACKERS] ALTER SYSTEM vs symlink

Robert Haas writes: > On Mon, Nov 2, 2015 at 10:13 PM, Amit Kapila wrote: >> I think that is the sensible way to deal with this and any other such >> parameters. We already have a way to disallow setting of individual >> parameters