Re: [HACKERS] Refectoring of receivelog.c

> On 15 Feb 2016, at 14:46, Magnus Hagander wrote: > > On Mon, Feb 15, 2016 at 7:15 AM, Craig Ringer > wrote: > On 15 February 2016 at 04:48, Magnus Hagander > wrote: > I was working on adding the tar streaming functionality we talked ab

[HACKERS] Leftover member in openssl part of Port struct

When SSL renegotiation was removed in 426746b9 the only consumer of the openssl specific count member in the Port struct was removed, but the member was left together with a few updates to it which are unused. Attached patch removes the leftovers which now serves no purpose unless I’m missing some

Re: [HACKERS] Leftover member in openssl part of Port struct

> On 31 Aug 2016, at 15:12, Tom Lane wrote: > > Daniel Gustafsson writes: >> When SSL renegotiation was removed in 426746b9 the only consumer of the >> openssl >> specific count member in the Port struct was removed, but the member was left >> together w

[HACKERS] Typo in filename identification

The IDENTIFICATION filename in src/backend/storage/ipc/dsm_impl.c is incorrectly labelling the file dsm.c. Patch fixing the typo attached. cheers ./daniel typo-dsm_impl_identification.diff Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

[HACKERS] Typo in libpq-int.h

Ran into a typo in libpq-int.h while reading/hacking: - char *gsslib; /* What GSS librart to use ("gssapi" or + char *gsslib; /* What GSS library to use ("gssapi” or Patch attached. cheers ./daniel typo-libpq-int.diff Descripti

[HACKERS] Make flex/bison checks stricter in Git trees

When running ./configure on a system without Flex/Bison it’s easy to miss the warning that flies past and then run into compilation error instead. When it happened to a colleague yesterday a brief discussion came to the conclusion that it would be neat it the flex and bison checks took the existen

Re: [HACKERS] Make flex/bison checks stricter in Git trees

> On 27 Sep 2016, at 15:49, Tom Lane wrote: > > Daniel Gustafsson writes: >> When running ./configure on a system without Flex/Bison it’s easy to miss the >> warning that flies past and then run into compilation error instead. When it >> happened to a colleague y

[HACKERS] Incorrect comment/doc for poll_query_until

Commit 2a0f89cd717ce6d raised the timeout in poll_query_until() to 180 seconds but left the documentation and comments at the previous value of 90 sec. Patch attached to update documentation and comment to match reality. cheers ./daniel poll_query_until_timeout_doc.diff Description: Binary dat

[HACKERS] WIP: Secure Transport support as OpenSSL alternative on macOS

As noted in 77fb2321-9210-4ad4-b7fc-67623a583...@justatheory.com, OpenSSL is being somewhat dismantled on macOS starting with 10.11 El Capitan. To scratch my own itch I decided to take a stab at adding support for the Secure Transport library. The idea is to make it as much of a drop-in for the O

Re: [HACKERS] WIP: Secure Transport support as OpenSSL alternative on macOS

> On 05 Oct 2016, at 16:45, Stephen Frost wrote: > > Daniel, > > * Daniel Gustafsson (dan...@yesql.se) wrote: >> The main questions raised here are: is it of interest to support multiple SSL >> libraries given the additional support burden and; is supporting Secure &

[HACKERS] Small typo in pageinspect heapfuncs

Spotted a tiny typo in contrib/pageinspect/heapfuncs.c: s/accordindly/accordingly/ cheers ./daniel typo-pageinspect_heapfuncs.diff Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/ma

Re: [HACKERS] Radix tree for character conversion

> On 27 Oct 2016, at 09:23, Kyotaro HORIGUCHI > wrote: > > Hello, thank you very much for the work. My work became quite > easier with it. > > At Tue, 25 Oct 2016 12:23:48 +0300, Heikki Linnakangas > wrote in <08e7892a-d55c-eefe-76e6-7910bc8dd...@iki.fi> >> >> [..] >> The perl scripts are st

Re: [HACKERS] Radix tree for character conversion

> On 04 Nov 2016, at 08:34, Kyotaro HORIGUCHI > wrote: > > Thank you for looling this. And thank you for taking the time to read my patches! > At Mon, 31 Oct 2016 17:11:17 +0100, Daniel Gustafsson wrote > in <3fc648b5-2b7f-4585-9615-207a44b73...@yesql.se> >

Re: [HACKERS] Radix tree for character conversion

> On 07 Nov 2016, at 12:32, Daniel Gustafsson wrote: > >> On 04 Nov 2016, at 08:34, Kyotaro HORIGUCHI >> wrote: >> >> I'm not sure how the discussion about this goes, these patches >> makes me think about coding style of Perl. > > Some of this

Re: [HACKERS] Radix tree for character conversion

> On 08 Nov 2016, at 12:21, Kyotaro HORIGUCHI > wrote: > > Hello, this is the revising patch applies on top of the previous > patch. > > ... > > Finally the attached patch contains most of (virtually all of) > Daniel's suggestion and some modification by pgperltidy. Reading over this it looks

Re: [HACKERS] Radix tree for character conversion

> On 08 Nov 2016, at 17:37, Peter Eisentraut > wrote: > > On 10/31/16 12:11 PM, Daniel Gustafsson wrote: >> I took a small stab at doing some cleaning of the Perl scripts, mainly around >> using the more modern (well, modern as in +15 years old) form for open(..), >&g

Re: [HACKERS] Size vs size_t

> On 16 Mar 2017, at 23:20, Tom Lane wrote: > > Thomas Munro writes: >> Naive replacement in new files (present in master but not in 9.6) with >> the attached script, followed by a couple of manual corrections where >> Size was really an English word in a comment, gets the attached diff. > > In

Re: [HACKERS] perlcritic

> On 21 Mar 2017, at 19:20, David Steele wrote: > > On 3/6/17 12:02 PM, Dagfinn Ilmari Mannsåker wrote: >> ilm...@ilmari.org (Dagfinn Ilmari Mannsåker) writes: >> >>> Hi Peter, >>> >>> Peter Eisentraut writes: >>> I posted this about 18 months ago but then ran out of steam. [ ] Here

Re: [HACKERS] createlang/droplang deprecated

> On 20 Mar 2017, at 01:37, Peter Eisentraut > wrote: > > On 3/18/17 09:00, Peter Eisentraut wrote: >> I just noticed that createlang and droplang have been listed as >> deprecated since PG 9.1. >> >> Do we dare remove them? > > Patch LGTM, +1 cheers ./daniel -- Sent via pgsql-hackers mail

Re: [HACKERS] perlcritic

> On 21 Mar 2017, at 19:20, David Steele wrote: > > On 3/6/17 12:02 PM, Dagfinn Ilmari Mannsåker wrote: >> ilm...@ilmari.org (Dagfinn Ilmari Mannsåker) writes: >> >>> Hi Peter, >>> >>> Peter Eisentraut writes: >>> I posted this about 18 months ago but then ran out of steam. [ ] Here

[HACKERS] Use American English spelling in pg_waldump error message

We use “unrecognize” rather than “unrecognise” in all other error messages in the tree, the attached patch fixes the one place where the latter spelling was used. cheers ./daniel pg_waldump_errmsg.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.

[HACKERS] Multiple TO version in ALTER EXTENSION UPDATE

While reading I noticed that we allow multiple TO in ALTER EXTENSION UPDATE, and defer throwing a syntax error until command processing. Is there a reason for deferring and not handling it in gram.y directly as in the attached patch since it is in fact a syntax error? It yields a different error

[HACKERS] Typo in libpq

There seems to be a typo in libpq as per attached, “..we will loose error messages” should probably be “..we will lose error messages”. cheers ./daniel typo-libpq-loose.diff Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

[HACKERS] Refactoring identifier checks to consistently use strcmp

Testing DefElem options is done with both strcmp() and pg_strcasecmp() a bit mixed. Since the option defnames are all lowercased, either via IDENT, keyword rules or “by hand” with makeString(), using strcmp() is safe (and assumed to be so in quite a lot of places). While it’s not incorrect per se

Re: [HACKERS] Refactoring identifier checks to consistently use strcmp

> On 04 Apr 2017, at 05:52, Alvaro Herrera wrote: > > Daniel Gustafsson wrote: >> Testing DefElem options is done with both strcmp() and pg_strcasecmp() a bit >> mixed. Since the option defnames are all lowercased, either via IDENT, >> keyword >> rules or “

[HACKERS] Typos in comments

Spotted one “paramter” typo and git grep found two more, patch attached with s/paramter/parameter/ for these. cheers ./daniel typo-paramter.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.pos

[HACKERS] Optional message to user when terminating/cancelling backend

When terminating, or cancelling, a backend it’s currently not possible to let the signalled session know *why* it was dropped. This has nagged me in the past and now it happened to come up again, so I took a stab at this. The attached patch implements the ability to pass an optional text message

Re: [HACKERS] Optional message to user when terminating/cancelling backend

> On 21 Jun 2017, at 16:30, Yugo Nagata wrote: > > On Wed, 21 Jun 2017 12:06:33 +0900 > Michael Paquier wrote: > >> On Tue, Jun 20, 2017 at 3:24 AM, Daniel Gustafsson wrote: >>> The message is stored in a new shmem area which is checked when the session >&

Re: [HACKERS] Optional message to user when terminating/cancelling backend

> On 22 Jun 2017, at 10:24, Yugo Nagata wrote: > > On Thu, 22 Jun 2017 09:24:54 +0900 > Michael Paquier wrote: > >> On Wed, Jun 21, 2017 at 11:42 PM, Daniel Gustafsson wrote: >>> The message is truncated in SetBackendCancelMessage() for safety, but >>>

Re: [HACKERS] Multiple TO version in ALTER EXTENSION UPDATE

> On 22 Jun 2017, at 17:02, Tom Lane wrote: > > Robert Haas writes: >> On Wed, Mar 29, 2017 at 11:13 AM, Daniel Gustafsson wrote: >>> While reading I noticed that we allow multiple TO in ALTER >>> EXTENSION >>> UPDATE, and defer throwing a

Re: [HACKERS] Optional message to user when terminating/cancelling backend

> On 22 Jun 2017, at 17:52, Dilip Kumar wrote: > > On Thu, Jun 22, 2017 at 7:18 PM, Daniel Gustafsson wrote: >> Good point. I’ve attached a new version which issues a NOTICE on truncation >> and also addresses all other comments so far in this thread. Thanks a lot >

Re: [HACKERS] psql's \d and \dt are sending their complaints to different output files

> On 19 Jun 2017, at 17:32, Tom Lane wrote: > > So, if we're getting into enforcing consistency in describe.c, there's > lots to do. > > * listDbRoleSettings does this for a server too old to have the desired > feature: > > fprintf(pset.queryFout, > _("No per-databas

Re: [HACKERS] pg_receivewal and messages printed in non-verbose mode

> On 14 Jun 2017, at 06:04, Michael Paquier wrote: > > On Tue, Jun 13, 2017 at 4:50 PM, Craig Ringer wrote: >> On 13 June 2017 at 14:33, Michael Paquier wrote: >>> Those come from stop_streaming in pg_receivewal.c. Shouldn't those >>> messages only show up to the user if --verbose is used? It s

Re: [HACKERS] psql's \d and \dt are sending their complaints to different output files

> On 27 Jul 2017, at 19:40, Tom Lane wrote: > > Daniel Gustafsson writes: >>> On 19 Jun 2017, at 17:32, Tom Lane wrote: >>> So, if we're getting into enforcing consistency in describe.c, there's >>> lots to do. > >> Addressed in attached

[HACKERS] Support for Secure Transport SSL library on macOS as OpenSSL alternative

In https://postgr.es/m/69db7657-3f9d-4d30-8a4b-e06034251...@yesql.se I presented a WIP patch for adding support for the Apple Secure Transport SSL library on macOS as, an alternative to OpenSSL. That patch got put on the backburner for a bit, but I’ve now found the time to make enough progress to

Re: [HACKERS] Support for Secure Transport SSL library on macOS as OpenSSL alternative

> On 03 Aug 2017, at 13:06, Heikki Linnakangas wrote: > > On 08/03/2017 01:02 PM, Daniel Gustafsson wrote: >> >> The frontend has support for using PEM files for certificates and keys. It >> can >> also look up the key for the certificate in a Keychain, or bot

Re: [HACKERS] Support for Secure Transport SSL library on macOS as OpenSSL alternative

> On 03 Aug 2017, at 19:27, Michael Paquier wrote: > > On Thu, Aug 3, 2017 at 12:02 PM, Daniel Gustafsson wrote: >> In https://postgr.es/m/69db7657-3f9d-4d30-8a4b-e06034251...@yesql.se I >> presented a WIP patch for adding support for the Apple Secure Transport SSL >&

Re: [HACKERS] Refactoring identifier checks to consistently use strcmp

> On 16 Aug 2017, at 17:51, Tom Lane wrote: > > Heikki Linnakangas writes: >> This no longer works: > >> postgres=# CREATE TEXT SEARCH DICTIONARY public.simple_dict ( >> TEMPLATE = pg_catalog.simple, >> "STOPWORds" = english >> ); >> ERROR: unrecognized simple dictionary parameter: "ST

Re: [HACKERS] Support for Secure Transport SSL library on macOS as OpenSSL alternative

> On 19 Aug 2017, at 23:13, Thomas Munro wrote: > > On Sun, Aug 20, 2017 at 8:10 AM, Thomas Munro > mailto:thomas.mu...@enterprisedb.com>> wrote: >> On Fri, Aug 18, 2017 at 2:14 AM, Daniel Gustafsson wrote: >>> Attached is an updated set of patches, rebased on t

Re: [HACKERS] Old versions of Test::More

> On 21 Apr 2017, at 15:08, Andrew Dunstan > wrote: > > As we discovered yesterday via jacana, very old versions of Test::More > don't support the note() function. It therefore seems prudent to specify > a minimum version number for the module in those scripts that use the > function. According

Re: [HACKERS] A note about debugging TAP failures

> On 22 Apr 2017, at 23:25, Tom Lane wrote: > > Andres Freund writes: >> On 2017-04-22 16:22:59 -0400, Tom Lane wrote: >>> In the particular case I was interested in here, the test script thought >>> everything was successful :-(. I'm working on fixing that little problem, >>> but I do not beli

Re: [HACKERS] A note about debugging TAP failures

> On 23 Apr 2017, at 00:06, Andres Freund wrote: > > On 2017-04-22 23:59:11 +0200, Daniel Gustafsson wrote: >> Since we have the name of the running testscript, can’t we just add that to >> the >> tempdir to make the name more descriptive? With the attach

Re: [HACKERS] A note about debugging TAP failures

> On 23 Apr 2017, at 15:05, Craig Ringer wrote: > > On 23 Apr. 2017 10:32, "Michael Paquier" <mailto:michael.paqu...@gmail.com>> wrote: > On Sun, Apr 23, 2017 at 7:48 AM, Daniel Gustafsson <mailto:dan...@yesql.se>> wrote: > > Skipping the tem

Re: [HACKERS] A note about debugging TAP failures

> On 24 Apr 2017, at 17:19, Craig Ringer wrote: > > On 24 April 2017 at 20:01, Daniel Gustafsson wrote: > >> I’m np Perl expert though so there might be better/cleaner ways to achieve >> this, in testing it seems to work though. rmtree() is supported at least >>

[HACKERS] Typo in json.c

Spotted while reading code, patch attached. cheers ./daniel typo-json.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Bug when dumping "empty" operator classes

While hacking on pg_upgrade in downstream Greenplum I ran into an error which seems like an old, and obscure, bug in pg_dump (unrelated to pg_upgrade). pg_dump generates incorrect SQL for an operator class which has no operators or procedures, and which has the same column and storage types. While

Re: [HACKERS] Bug when dumping "empty" operator classes

> On 26 May 2017, at 17:08, Tom Lane wrote: > > Daniel Gustafsson writes: >> While hacking on pg_upgrade in downstream Greenplum I ran into an error which >> seems like an old, and obscure, bug in pg_dump (unrelated to pg_upgrade). >> pg_dump generates incorrect SQL

Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256

> On 30 May 2017, at 18:25, Michael Paquier wrote: > > On macos though it is another story, I am not seeing anything: > https://developer.apple.com/reference/security/secure_transport#symbols The Secure Transport documentation unfortunately excel at being incomplete and hard to search in. That

Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256

> On 30 May 2017, at 16:50, Tom Lane wrote: > > Robert Haas writes: >> On Sat, May 27, 2017 at 5:59 PM, Álvaro Hernández Tortosa >> wrote: >>> - tls-unique, as you mentioned, uses two undocumented APIs. This raises a >>> small flag about the stability and future of those APIs. > >> It seems to

[HACKERS] Typo in comment in ecpg datetime.c

Spotted s/fiedls/fields/ in src/interfaces/ecpg/pgtypeslib/datetime.c per the attached patch. cheers ./daniel typo-ecpg_datetime.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] Upcoming commit fest will begin soon

> On 01 Sep 2017, at 05:33, Michael Paquier wrote: > > Another question is: who would like to become the CF manager for this > time? This commit fest is very large, so it is going to be difficult > for one person to do the whole thing, hence at least 2 people would be > welcome. Please note that

Re: [HACKERS] GnuTLS support

> On 01 Sep 2017, at 19:10, Tom Lane wrote: > > Robert Haas writes: >> On Thu, Aug 31, 2017 at 1:52 PM, Andreas Karlsson wrote: > >>> There are currently two failing SSL tests which at least to me seems more >>> like they test specific OpenSSL behaviors rather than something which need >>> to

Re: [HACKERS] GnuTLS support

> On 01 Sep 2017, at 20:00, Robert Haas wrote: > > On Fri, Sep 1, 2017 at 1:10 PM, Tom Lane wrote: >> Robert Haas writes: >>> On Thu, Aug 31, 2017 at 1:52 PM, Andreas Karlsson wrote: I have seen discussions from time to time about OpenSSL and its licensing issues so I decided to see

Re: [HACKERS] adding the commit to a patch's thread

> On 01 Sep 2017, at 15:40, Robert Haas wrote: > > On Fri, Sep 1, 2017 at 4:26 AM, Alvaro Herrera > wrote: >> Erik Rijkers wrote: >>> Would it be possible to change the commitfest a bit and make it possible to >>> add the commit (or commit-message, or hash) to the thread in the >>> commitfest-a

Re: [HACKERS] adding the commit to a patch's thread

> On 03 Sep 2017, at 19:33, Magnus Hagander wrote: > > On Sun, Sep 3, 2017 at 12:00 AM, Daniel Gustafsson <mailto:dan...@yesql.se>> wrote: > > On 01 Sep 2017, at 15:40, Robert Haas > <mailto:robertmh...@gmail.com>> wrote: > > > > On Fri, Sep 1,

Re: [HACKERS] Optional message to user when terminating/cancelling backend

> On 02 Sep 2017, at 02:21, Thomas Munro wrote: > > On Fri, Jun 23, 2017 at 1:48 AM, Daniel Gustafsson wrote: >> Good point. I’ve attached a new version which issues a NOTICE on truncation >> and also addresses all other comments so far in this thread. Thanks a lot >

Re: [HACKERS] adding the commit to a patch's thread

> On 03 Sep 2017, at 21:12, Magnus Hagander wrote: > > On Sun, Sep 3, 2017 at 8:55 PM, Daniel Gustafsson <mailto:dan...@yesql.se>> wrote: > > That leaves us back at parsing/scraping -committers and adding the mailthread. > For this CF I can add the commits manuall

Re: [HACKERS] Refactoring identifier checks to consistently use strcmp

> On 17 Aug 2017, at 11:08, Daniel Gustafsson wrote: > >> On 16 Aug 2017, at 17:51, Tom Lane wrote: >> >> Heikki Linnakangas writes: >>> This no longer works: >> >>> postgres=# CREATE TEXT SEARCH DICTIONARY public.simple_dict ( >&g

Re: [HACKERS] WAL logging problem in 9.4.3?

> On 13 Apr 2017, at 11:42, Kyotaro HORIGUCHI > wrote: > > At Thu, 13 Apr 2017 13:52:40 +0900, Michael Paquier > wrote in > >> On Tue, Apr 11, 2017 at 5:38 PM, Kyotaro HORIGUCHI >> wrote: >>> Sorry, what I have just sent was broken. >> >> You can use PROVE_TESTS when running make check to

Re: [HACKERS] [PROPOSAL] Use SnapshotAny in get_actual_variable_range

> On 18 Aug 2017, at 08:50, Andrey Borodin wrote: > > The following review has been posted through the commitfest application: > make installcheck-world: tested, failed > Implements feature: tested, failed > Spec compliant: tested, failed > Documentation:tested, faile

Re: [HACKERS] Should we cacheline align PGXACT?

> On 04 Apr 2017, at 14:58, David Steele wrote: > > On 4/4/17 8:55 AM, Alexander Korotkov wrote: >> On Mon, Apr 3, 2017 at 9:58 PM, Andres Freund > >>I'm inclined to push this to the next CF, it seems we need a lot more >>benchmarking here. >> >> No objections. > > This submission has

Re: [HACKERS] Making clausesel.c Smarter

> On 09 Apr 2017, at 12:14, David Rowley wrote: > > On 8 April 2017 at 09:33, Claudio Freire wrote: >> Otherwise, the patch LGTM, but I'd like to solve the quadratic >> behavior too... are you going to try? Otherwise I could take a stab at >> it myself. It doesn't seem very difficult. > > I ha

Re: [HACKERS] PoC plpgsql - possibility to force custom or generic plan

> On 08 Apr 2017, at 09:42, Pavel Stehule wrote: > > 2017-04-08 2:30 GMT+02:00 Peter Eisentraut >: > On 4/6/17 14:32, Pavel Stehule wrote: > > I like to see any proposals about syntax or implementation. > > > > Using PRAGMA is one variant - introduced by

Re: [HACKERS] Proposal for changes to recovery.conf API

> On 27 Mar 2017, at 10:27, Simon Riggs wrote: > > On 7 March 2017 at 23:31, Josh Berkus wrote: >> On 03/02/2017 07:13 AM, David Steele wrote: >>> Hi Simon, >>> >>> On 2/25/17 2:43 PM, Simon Riggs wrote: On 25 February 2017 at 13:58, Michael Paquier wrote: > - trigger_file

Re: [HACKERS] A note about debugging TAP failures

> On 05 Sep 2017, at 18:37, Peter Eisentraut > wrote: > > On 4/25/17 11:00, Daniel Gustafsson wrote: >> Makes sense, assuming a “clean slate” to run on seems a reasonable assumption >> for the test and it makes for simpler code in PostgresNode. Updated the >>

Re: [HACKERS] Copyright in partition.h and partition.c

> On 06 Sep 2017, at 02:56, Amit Langote wrote: > > On 2017/09/05 21:14, Tom Lane wrote: >> Amit Langote writes: >>> On 2017/09/05 15:48, Etsuro Fujita wrote: Here is the copyright in partition.h: * Copyright (c) 2007-2017, PostgreSQL Global Development Group I think

Re: [HACKERS] Making clausesel.c Smarter

> On 06 Sep 2017, at 07:13, David Rowley wrote: > > On 6 September 2017 at 00:43, Daniel Gustafsson wrote: >> This patch was moved to the currently open Commitfest. Given the above >> comment, is the last patch in this thread still up for review, or are you >> work

[HACKERS] Commitfest 201709 Progress

We are now a few days in on Commitfest 201709 and there has been lots of activity on the patches. 22% of the patches have been committed* with another 10% being marked Ready for Committer. Thank you all for the hard work! There is still a lot to do though, this fest has a recordbreaking 256 patc

Re: [HACKERS] PoC plpgsql - possibility to force custom or generic plan

> On 08 Sep 2017, at 19:14, Simon Riggs wrote: > > On 6 September 2017 at 07:43, Robert Haas wrote: > >> LET custom_plan_tries = 0 IN SELECT ... > > Tom has pointed me at this proposal, since on another thread I asked > for something very similar. (No need to reprise that discussion, but I > w

Re: [HACKERS] Patches that don't apply or don't compile: 2017-09-12

> On 12 Sep 2017, at 23:54, Tomas Vondra wrote: > > On 09/12/2017 04:14 PM, Aleksander Alekseev wrote: >> Hello, hackers! >> >> Thanks to the work of Thomas Munro now we have a CI for the patches on >> the commitfest [1]. Naturally there is still room for improvement, but >> in any case it's muc

Re: [HACKERS] [WIP] RE: DECLARE STATEMENT setting up a connection in ECPG

> On 30 Mar 2017, at 09:11, Ideriha, Takeshi > wrote: > > Thank you for prompt check! > > >As per above test steps, it doesn't produce the results and doesn't > >generate the error also. I feel this needs to be fixed. > > >As we are at the end of commitfest, it is better you can move it > >t

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

> On 08 May 2017, at 12:02, Fabien COELHO > wrote: > > Hello Jan, > > Please give a number to submitted patches. I think that this was v3. > > The patch does NOT fix various issues I pointed out in my previous review: > > - tabs introduced in "doc/src/sgml/ref/psql-ref.sgml" > - too long help

Re: [HACKERS] PATCH: psql show index with type info

> On 18 Apr 2017, at 05:13, Amos Bird wrote: > > Ah, thanks for the suggestions. I'll revise this patch soon :) Have you had a chance to revise the patch to address the review comments such that the patch can move forward during this Commitfest? cheers ./daniel -- Sent via pgsql-hackers mail

Re: [HACKERS] plpgsql - additional extra checks

> On 08 Apr 2017, at 15:46, David Steele wrote: > >> On 1/13/17 6:55 AM, Marko Tiikkaja wrote: >>> On Fri, Jan 13, 2017 at 2:46 AM, Jim Nasby >> > wrote: >>> >>>On 1/11/17 5:54 AM, Pavel Stehule wrote: >>> >>>+too_many_rows >>>+ >>>

Re: [HACKERS] Faster methods for getting SPI results

> On 12 Sep 2017, at 23:00, Tom Lane wrote: > > Chapman Flack writes: >> On 09/12/2017 03:41 PM, Tom Lane wrote: >>> So the conclusion at the end of the last commitfest was that this patch >>> should be marked Returned With Feedback, and no new work appears to have >>> been done on it since then

Re: [HACKERS] Replication status in logical replication

> On 30 May 2017, at 19:55, Peter Eisentraut > wrote: > > On 5/29/17 22:56, Noah Misch wrote: >> On Fri, May 19, 2017 at 11:33:48AM +0900, Masahiko Sawada wrote: >>> On Wed, Apr 12, 2017 at 5:31 AM, Simon Riggs wrote: Looks like a bug that we should fix in PG10, with backpatch to 9.4 (or >

Re: [HACKERS] Small patch for pg_basebackup argument parsing

> On 05 Jul 2017, at 08:32, Michael Paquier wrote: > > On Wed, Jul 5, 2017 at 2:57 PM, Ryan Murphy wrote: >> I tried to apply your patch to test it (though reading Robert's last comment >> it seems we wish to have it adjusted before committing)... but in any case I >> was not able to apply you

Re: [HACKERS] Patches that don't apply or don't compile: 2017-09-12

> On 13 Sep 2017, at 11:49, Aleksander Alekseev > wrote: > > Hi Tomas, > > I appreciate your feedback, although it doesn't seem to be completely > fair. I would like to stress one thing (and I am speaking only for myself here), this has been feedback and not criticism. Your (and everyone invo

Re: [HACKERS] Bug with pg_basebackup and 'shared' tablespace

> On 15 May 2017, at 07:26, Michael Paquier wrote: > > On Tue, May 2, 2017 at 2:28 AM, Pierre Ducroquet wrote: > >> I will submit this patch in the current commit fest. > > I have not spotted any flaws in the refactored logic. This patch no longer applies, could you take a look at it and subm

Re: [HACKERS] Patch: add --if-exists to pg_recvlogical

> On 09 Sep 2017, at 06:05, Thomas Munro wrote: > > On Sat, Sep 2, 2017 at 5:22 AM, Peter Eisentraut > wrote: >> >> + --if-exists >> + >> + >> +Do not error out when --drop-slot or >> --start are >> +specified and a slot with the specified name does not ex

Re: [HACKERS] [PATCH] Off-by-one error in logical slot resource retention

> On 01 Sep 2017, at 14:28, Aleksander Alekseev > wrote: > > The following review has been posted through the commitfest application: > make installcheck-world: not tested > Implements feature: not tested > Spec compliant: not tested > Documentation:not tested > > H

Re: [HACKERS] VACUUM and ANALYZE disagreeing on what reltuples means

> On 06 Sep 2017, at 09:45, Haribabu Kommi wrote: > > On Tue, Jul 25, 2017 at 9:33 PM, Tomas Vondra > wrote: > On 7/25/17 12:55 AM, Tom Lane wrote: > Tomas Vondra > writes: > It seems to me that VACUUM and ANALYZE somewha

Re: [HACKERS] Allow INSTEAD OF DELETE triggers to modify the tuple for RETURNING

> On 05 Sep 2017, at 10:44, Haribabu Kommi wrote: > > On Mon, Aug 14, 2017 at 6:48 AM, Marko Tiikkaja > wrote: > On Fri, Jul 1, 2016 at 2:12 AM, I wrote: > Currently the tuple returned by INSTEAD OF triggers on DELETEs is only used > to determine whether to pretend that the

Re: [HACKERS] SQL/JSON in PostgreSQL

> On 15 Aug 2017, at 04:30, Peter Eisentraut > wrote: > > On 3/15/17 11:56, David Steele wrote: >>> This patch has been moved to CF 2017-07. >> >> I did not manage to move this patch when I said had. It is now moved. > > Unsurprisingly, this patch needs a major rebase. Can we expect a rebase

Re: [HACKERS] postgres_fdw: evaluate placeholdervars on remote server

> On 15 Aug 2017, at 01:00, Peter Eisentraut > wrote: > > On 4/3/17 22:00, Etsuro Fujita wrote: >> On 2017/04/04 3:21, Andres Freund wrote: >>> On 2017-02-28 21:45:22 +0900, Etsuro Fujita wrote: Here is a patch for $subject. >>> >>> This is a nontrivial patch, submitted just before the sta

Re: [HACKERS] Statement-level rollback

> On 01 Sep 2017, at 13:44, Simon Riggs wrote: > > On 14 August 2017 at 23:58, Peter Eisentraut > wrote: >> On 2/28/17 02:39, Tsunakawa, Takayuki wrote: >>> The code for stored functions is not written yet, but I'd like your >>> feedback for the specification and design based on the current pat

Re: [HACKERS] Renaming PG_GETARG functions (was Re: PG_GETARG_GISTENTRY?)

> On 12 Sep 2017, at 22:07, Tom Lane wrote: > > [ changing subject line to possibly draw more attention ] > > Mark Dilger writes: >>> On Apr 5, 2017, at 9:23 AM, Tom Lane wrote: >>> In short, if you are supposed to write >>> FOO *val = PG_GETARG_FOO(n); >>> then the macro designer blew it

Re: [HACKERS] postgres_fdw: evaluate placeholdervars on remote server

> On 15 Sep 2017, at 17:19, Robert Haas wrote: > > On Fri, Sep 15, 2017 at 10:15 AM, Daniel Gustafsson wrote: >> Have you had a chance to look at this such that we can expect a rebased >> version >> of this patch during the commitfest? > > Frankly, I th

Re: [HACKERS] Should we cacheline align PGXACT?

> On 16 Sep 2017, at 01:51, Alexander Korotkov > wrote: > > On Tue, Sep 5, 2017 at 2:47 PM, Daniel Gustafsson <mailto:dan...@yesql.se>> wrote: > > On 04 Apr 2017, at 14:58, David Steele > <mailto:da...@pgmasters.net>> wrote: > > > > On 4/

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

> On 18 Sep 2017, at 15:31, Jan Michálek wrote: > > I have`t any new version recently, because i was waiting for new version. But > I will have some time on this in next months. How many time I have to next > freeze? The next commitfest runs from 2017-11-01 to 2017-11-30, I will move your patc

Re: [HACKERS] Repetitive code in RI triggers

> On 11 Apr 2017, at 03:41, Peter Eisentraut > wrote: > > On 4/10/17 11:55, Ildar Musin wrote: >> I was looking through the RI triggers code recently and noticed a few >> almost identical functions, e.g. ri_restrict_upd() and >> ri_restrict_del(). The following patch is an attempt to reduce so

Re: [HACKERS] PoC: full merge join on comparison clause

> On 19 Sep 2017, at 15:18, Ashutosh Bapat > wrote: > > On Fri, Aug 25, 2017 at 10:11 PM, Alexander Kuzmenkov > wrote: >> Here is a new version of the patch, rebased to 749c7c41 and with some >> cosmetic changes. >> > > I looked at this patch briefly. This is a useful feature. This isn't a >

[HACKERS] Commitfest 201709 update

all for your contributions to PostgreSQL! Sincerely Daniel Gustafsson CFM201709 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Repetitive code in RI triggers

> On 26 Sep 2017, at 10:51, Maksim Milyutin wrote: > > On 19.09.2017 11:09, Daniel Gustafsson wrote: > >> Removing reviewer Maksim Milyutin from patch entry due to inactivity and >> community account email bouncing. Maksim: if you are indeed reviewing this >>

Re: bgw_type (was Re: [HACKERS] Why does logical replication launcher set application_name?)

> On 31 Aug 2017, at 21:49, Peter Eisentraut > wrote: > > On 5/30/17 23:10, Peter Eisentraut wrote: >> Here is a proposed solution that splits bgw_name into bgw_type and >> bgw_name_extra. bgw_type shows up in pg_stat_activity.backend_type. >> Uses of application_name are removed, because they

Re: [HACKERS] [PATCH] Off-by-one error in logical slot resource retention

> On 15 Sep 2017, at 13:26, Daniel Gustafsson wrote: > >> On 01 Sep 2017, at 14:28, Aleksander Alekseev >> wrote: >> >> The following review has been posted through the commitfest application: >> make installcheck-world: not tested >> Implements f

Re: [HACKERS] PATCH: psql show index with type info

> On 13 Sep 2017, at 01:24, Daniel Gustafsson wrote: > >> On 18 Apr 2017, at 05:13, Amos Bird wrote: >> >> Ah, thanks for the suggestions. I'll revise this patch soon :) > > Have you had a chance to revise the patch to address the review comments such >

Re: [HACKERS] pgbench: faster version of tpcb-like transaction

> On 27 Aug 2017, at 08:37, Fabien COELHO wrote: > > > About the patch: > > I'm generally in favor of providing more options to pgbench, especially if it > can give optimization ideas to the performance conscious user. > > I think that the name should be "tpcb-like-plfunc": the script does no

Re: [HACKERS] ANALYZE command progress checker

> On 05 Apr 2017, at 03:17, Masahiko Sawada wrote: > > On Wed, Apr 5, 2017 at 1:49 AM, Robert Haas wrote: >> On Tue, Apr 4, 2017 at 4:57 AM, Amit Langote >> wrote: >>> Hmm, you're right. It could be counted with a separate variable >>> initialized to 0 and incremented every time we decide to a

Re: [HACKERS] Statement-level rollback

> On 15 Sep 2017, at 16:19, Daniel Gustafsson wrote: > >> On 01 Sep 2017, at 13:44, Simon Riggs wrote: >> >> On 14 August 2017 at 23:58, Peter Eisentraut >> wrote: >>> On 2/28/17 02:39, Tsunakawa, Takayuki wrote: >>>> The code for sto

  1   2   >