what you want.
I think sending a stats message with the number of inserted rows could
make sense.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pg
BOUNDARY, even though there's no reason it couldn't be
> pre-data. That's certainly a change, and I suspect it's not intentional
I think the recent additions actually were intentional, although one
could debate the intentions. ;-)
--
Peter Eisentraut http://www.2ndQ
There is support for COMMENT ON RULE without specifying a table
name, for upgrading from pre-7.3 instances. I think it might be time
for that workaround to go.
Patch attached.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA
d that clears the compiler
warnings under -O3 for me. It seems that they are a subset of what you
are seeing. Plausibly, as compilers are doing more analysis in larger
scopes, we can expect to see more of these.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Developm
empty post-restore.
Yes, by that logic matview refresh should always be last.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make change
On 2/16/17 07:41, Robert Haas wrote:
> Also, it sounds like all of this is intended to work with ranges that
> are stored in different columns rather than with PostgreSQL's built-in
> range types.
Yeah, that should certainly be changed.
--
Peter Eisentraut
t surprised at the limitations that this
feature has, even if Bruce and Simon are. The documentation needs
work, and perhaps the feature itself needs a small tweak here or
there. Just not to a particularly notable degree, given the point we
are in in the release cycle.
--
Peter Geoghegan
--
Sent
On 2/17/17 10:14, Peter Eisentraut wrote:
> Well, it is sort of a libpq connection, and a proper libpq client should
> set the client encoding, and a proper libpq server should do encoding
> conversion accordingly. If we just play along with this, it all works
> correctly.
>
h I disagree with. There is nothing
disappointing to me about this feature, and, as I said, I am
unsurprised that it doesn't support certain things.
--
Peter Geoghegan
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
feature set, yet.
Obviously that general principle is not under discussion. My point, of
course, was that it seems pretty clear to me that this is on the right
side of that fence.
--
Peter Geoghegan
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
method for memory contexts, it looks like you just reset the parent instead.
> But I don't think that would work here.
Are you aware of the fact that tuplesort.c got a second memory context
for 9.6, entirely on performance grounds?
--
Peter Geoghegan
--
Sent via pgsql-hackers ma
2017-02-22 19:43 GMT+01:00 Peter Eisentraut :
> On 2/16/17 07:41, Robert Haas wrote:
>> Also, it sounds like all of this is intended to work with ranges that
>> are stored in different columns rather than with PostgreSQL's built-in
>> range types.
>
> Yeah, that s
an assert. I don't think we need the extra cogitive burden of
> two distinct macros for this.
I think we should just add some Assert(thepointer) where necessary.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Train
putting *fully* dead B-Tree pages in the FSM for
recycling. The interlock with RecentGlobalXmin is what makes it
impossible for VACUUM to generally fully delete pages, *as well as*
mark them as recyclable (put them in the FSM) all at once.
Maybe you get this already, since, as I said, the terminolog
hey should be GRANT'able
> privileges instead of privileges which the owner of the relation or
> database has.
Then you couldn't set up a replication structure involving tables owned
by different users without resorting to blunt instruments like having
everything owned by the same u
developing the background sessions API
for PL/Python. So I'm also wondering here which style people prefer so
I can implement it there.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From 9dccf70110d9d5818318
al one should assume that it is no wider than "int". This
calls into question why any code that uses "long" didn't just use
"int", at least in my mind.
--
Peter Geoghegan
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ason we chose hex over base64?
The reason we changed from the old format to hex was for performance.
We didn't consider base64 at the time, but hex would probably still have
been faster.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA
s made more
likely by the fact that we've made tuplesort faster in the past few
releases (gains which the MAX_KILOBYTES restriction won't impinge on
too much, particularly in Postgres 10). I find that unacceptable, at
least for Postgres 10.
--
Peter Geoghegan
--
Sent via pgsql-hacke
istent about a restriction like this, as
Robert said. Given that fixing this issue will not affect the machine
code generated by compilers for the majority of platforms we support,
doing so seems entirely worthwhile to me.
--
Peter Geoghegan
--
Sent via pgsql-hackers mailing list (pgsql-
2017-02-24 21:25 GMT+01:00 Jim Nasby :
> On 2/24/17 6:40 AM, Peter Moser wrote:
>>
>> Do you think it is better to remove the syntax for ranges expressed in
>> different columns?
>
>
> It's not that hard to construct a range type on-the-fly from 2 columns, so
&g
ut formats for
different data types. The hex format satisfies all of performance, ease
of use, and readability pretty well, I think.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hacke
LL ISOLATION
I think your syntax would read no worse, possibly even better, if you
just used the existing INCLUDING keyword.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing l
not
starting the next one until the first one is finished should be fine.
It will have the same serial behavior that the patch is proposing anyway.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via
On 2/8/17 11:00, Tom Lane wrote:
> Peter Eisentraut writes:
>> Here is a patch to systematically trim the trailing newlines off
>> PQerrorMessage() results in backend uses (dblink, postgres_fdw,
>> libpqwalreceiver).
>
> +1
committed
>> I noticed that there
the directory would stand
out more between all the other pg_* directories in the data directory.
Obviously, users could set the name back to the old one if they want.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Ser
.0, but there might be
non-linear increases in "the serious type of index bloat" as the
proposed new setting was scaled up. I'd be much more worried about
that.
[1] https://archive.org/stream/symmetricconcurr00lani#page/6/mode/2up
--
Peter Geoghegan
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Mon, Jan 16, 2017 at 5:56 PM, Peter Geoghegan wrote:
> On Wed, Oct 12, 2016 at 10:16 AM, Heikki Linnakangas wrote:
>> The number of *input* tapes we can use in each merge pass is still limited,
>> by the memory needed for the tape buffers and the merge heap, but only one
&g
l.org/wiki/Parallel_External_Sort#bt_estimated_nblocks.28.29_function_in_pageinspect
[3]
https://www.postgresql.org/message-id/CAMkU=1y_qp+QUPGk=JBJSTtcYQpW2k=v2lmytzko_8ftuuy...@mail.gmail.com
[4]
https://www.postgresql.org/message-id/cam3swzr6c+1cwghc40g9z5thfe3u2xbv55w5-tertfeooaz...@mail.gmail.com
--
Peter Geo
ling and some tidying up.
Related to this is also the patch in
<https://www.postgresql.org/message-id/d100f62a-0606-accc-693b-cdc6d16b9...@2ndquadrant.com>
as a resource control mechanism.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote
ctions, this is quite a small patch. There is a bit of
reduce/reduce parser mystery, to keep the reviewer entertained. (The
equivalent could be implemented for aggregates and operators, but I
haven't done that here yet.)
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreS
endently. The main point right
now is to get away from the DSSSL toolchain.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make c
hread.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>From 2e1fc0b0c50452bac91461a2317c28a8718fe89f Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Sun, 25 Dec 2016 12:00:00 -0500
Subject: [PATCH v2 1/2] dbl
The SQL standard defines a separate error code for nextval exhausting
the sequence space. I haven't found any discussion of this in the
archives, so it seems this was just not considered or not yet in
existence when the error codes were introduced. Here is a patch to
correct it.
--
lity testing (Windows!).
(changed subject copyNode -> copyObject (was excited about castNode at
the time))
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>From a6cccd06e22cbd4d84da1c2d1b085c68ae3d8a9a Mon S
gone away. Here is an updated patch. The testing
instructions below still apply. Especially welcome would be ideas on
how to address some of the places I have marked with ## no critic.
On 8/31/15 23:57, Peter Eisentraut wrote:
> We now have 80+ Perl files in our tree, and it's growi
or Cassandra distribution, they also come with a
log or logs directory.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To
clog, cough, cough) I think if
we invent nonstandard names, it will be more confusing, not less.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.o
ation.
Best regards,
Anton, Michael, Johann, Peter
NORMALIZE
This is an exemplary walkthrough of a te
On 2/22/17 18:24, Jim Nasby wrote:
> On 2/22/17 12:29 PM, Peter Eisentraut wrote:
>> On 2/22/17 10:14, Jim Nasby wrote:
>>> CREATE MATERIALIZED VIEW tmv AS SELECT * FROM pg_subscription;
>>> SELECT 0
>>>
>>> IOW, you can create matviews that depend o
be treated by
>> the way.
>
> Yes, I think that is correct approach. I have attached a patch where I
> add completion for \h ALTER and \h DROP.
Instead of creating another copy of list_ALTER, let's use the
words_after_create list and write a version of
create_command_gen
On 2/27/17 06:34, Dagfinn Ilmari Mannsåker wrote:
> ilm...@ilmari.org (Dagfinn Ilmari Manns�ker) writes:
>
>> Here's an updated patch wich adds it as a separate stanza.
>
> I've added this to the current commit fest:
> https://commitfest.postgresql.org/13/1043/
https://commitfest.postgresql.org/13/
> <https://commitfest.postgresql.org/13/>
> Here are also some rough guidelines about submitting a
> patch:
> https://wiki.postgresql.org/wiki/Submitting
hose as well.
This thread is in the commit fest, but I think there is no current patch.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresq
to fix it.
I'm in favor of changing it, but it could theoretically break someone's
code. I don't know what the practical use for these functions is.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
y of
session processes, but there are no other ways to log the activity of
autovacuum. Why are the existing settings not sufficient for this purpose?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent
m view for every kind of
command? What if someone comes up with a progress checker for CREATE
INDEX, REINDEX, CLUSTER, etc.?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing li
eplacement character from ? to instead
> be a parameter (like $1).
Hmm, I think this could confuse people into thinking that the queries
displayed were in fact prepared queries.
Maybe we could gather some more ideas.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreS
evise it?
Some of the information in there, such as the use of the FmgrInfo and
FunctionCallInfoData structs, doesn't seem to appear anywhere else in
that amount of detail, so it would be a loss to just delete the file, I
think. Perhaps just lightly editing out the "I propose to do this" t
itly when you start a transaction block.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://ww
saction and their apps (client programs and stored procedures) can
> continue the transaction with a different SQL statement.
Can you provide some references on how other systems provide this feature?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7
ged.
The current markup looks fine (to me) with the minimal default/non-web
stylesheet, so the issue is somewhere else.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (
On 3/1/17 09:12, Josh Soref wrote:
> On Mar 1, 2017 9:06 AM, "Peter Eisentraut"
> <mailto:peter.eisentr...@2ndquadrant.com>> wrote:
>
> On 2/6/17 06:03, Heikki Linnakangas wrote:
> > Ah, yes please. Post them over and I'll have a look at tho
server. dblink can assume it's a PostgreSQL server, but it's
not clear how to generalize that.
Some kind of node or connection registry (i.e., "native" servers) might
be a better feature to think about here.
--
Peter Eisentraut http://www.2ndQuadrant.com/
Po
On 1/12/17 09:36, Tom Lane wrote:
> Peter Eisentraut writes:
>> On 1/11/17 11:25 PM, Tom Lane wrote:
>>> +1 for the concept, but I'm a bit worried about putting atooid() in
>>> postgres_ext.h. That's going to impose on the namespace of libpq-using
&g
On 2/27/17 22:27, Kyotaro HORIGUCHI wrote:
> This patch adds a GUC to put a limit to the number of segments
> that replication slots can keep.
Please measure it in size, not in number of segments.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 S
rror when too old LSN is requested so we'd continue replication,
> hiding data loss.
In general, we would need a much more evident and strict way to discover
when this condition is hit. Like a "full" column in
pg_stat_replication_slot, and refusing connections to the slot
On 3/1/17 09:51, Alvaro Herrera wrote:
> Peter Eisentraut wrote:
>> On 2/22/17 19:35, Jim Nasby wrote:
>>> pg_get_object_address() currently returns a field called subobjid, while
>>> pg_depend calls that objsubid. I'm guessing that wasn't on purpose
&
do an unnecessary wildcard match at the end, and disable
> metachar interpretation in the substituted range.
>
> Still needs applying to pg9.6 and pg10.
committed to master and 9.6
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Rem
how would you decide access for physical replication? Since physical
replication is not to a database, you need a way to call it out
separately if your pg_hba.conf style is to enumerate databases.
What we could do to make things simpler is to include "replication" in
the "all"
could wrap the SPI_tuptable into a
Python object and implement __getitem__ or __iter__ to emulate sequence
or mapping access.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers maili
ng
> pg_stat_reset() (Christopher)
>
> It's true that pg_stat_reset() doesn't reset the nonexistent
> pg_statistics table. But it doesn't reset pg_statistic either. IIUC,
> it resets the data gathered by the statistics collector, which is
> something else altogether.
hen we might get a TID with invalid
> ip_posid. I've handled that by defining and using separate macros which
> skip the validation. This doesn't seem any worse than what we are
> already doing.
I wonder why we allow that. Shouldn't the tid type reject input that
has
On Thu, Mar 2, 2017 at 5:50 AM, Robert Haas wrote:
> On Wed, Mar 1, 2017 at 12:58 AM, Peter Geoghegan wrote:
>> * This scales based on output size (projected index size), not input
>> size (heap scan input). Apparently, that's what we always do right
>> now.
>
>
On Thu, Mar 2, 2017 at 8:25 AM, Peter Eisentraut
wrote:
> I wonder why we allow that. Shouldn't the tid type reject input that
> has ip_posid == 0?
InvalidOffsetNumber (that is, 0) is something that I wouldn't like to
bet doesn't make it out to disk at some point. I kn
On Fri, Mar 3, 2017 at 9:01 AM, Andres Freund wrote:
> On 2017-03-03 11:54:06 -0500, David Steele wrote:
>> Given that this landed on March 28 with no discussion beforehand, I
>> recommend that we immediately move this patch to the 2017-07 CF.
>
> Seconded.
+1
--
Peter
/thinko in the first patch which is now fixed.
>>
>
> And of course I missed the xlog->wal rename, sigh. Fixed.
all three committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent vi
es the following log
>> entries:
> Hi, thanks for report.
>
> Looks like I missed AfterTriggerBeginQuery/AfterTriggerEndQuery when
> moving the executor stuff around. Attached should fix it.
This has been fixed.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQ
CREATE/ALTER SUBSCRIPTION as
> this refers to remote objects defined in subconninfo.
> - authorize read access to public for all columns of pg_subscription
> except subconninfo
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA
publication.
> Perhaps that's intentional?
I came across this the other day as well. It's not clear what the best
way for this to behave would be. Another option would be to check the
then-current inheritance relationships in the output plugin.
--
Peter Eisentraut http://www.2n
a range of
values for each index, a little like a BRIN index build. This range is
what you go on to use to do a cheap index-scan-based B-Tree VACUUM.
This could have far far less I/O, though has obvious risks that we
need to worry about. That's work for another release, of course.
--
Pete
at all. This might have been
a leftover from an earlier version of the patch.
See attached patch that removes the length value.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>From 11b1ecf696294b891dff36d
e important. (I wonder if that will require
wal_keep_segments to change somehow.)
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To
On Fri, Mar 3, 2017 at 11:37 AM, Peter Geoghegan wrote:
> Please verify my understanding of your thought process: We don't have
> to freeze indexes at all, ever, so if we see index bloat as a separate
> problem, we also see that there is no need to *link* index needs to
> the
e
> it gets copied-and-pasted or otherwise misinterpreted?
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your
On Fri, Mar 3, 2017 at 11:49 AM, Peter Geoghegan wrote:
>> Please verify my understanding of your thought process: We don't have
>> to freeze indexes at all, ever, so if we see index bloat as a separate
>> problem, we also see that there is no need to *link* index n
rrectness of CIC - a relatively infrequent operation - on the
> assumption that no VM bits can be set concurrenty due to the SUE lock.
I agree.
FWIW, the extra time that CIC takes over a plain CI is much reduced these days.
--
Peter Geoghegan
--
Sent via pgsql-hackers mailing list (pgsql-ha
lock on the heap
relation (i.e. vacuuming it) after the first CIC transaction ends, but
before the second CIC transaction begins?
--
Peter Geoghegan
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Mar 3, 2017 at 2:41 PM, Peter Geoghegan wrote:
> In other words, the number of B-Tree pages that the last VACUUM
> deleted, and thus made eligible to recycle by the next VACUUM has no
> relationship with the number of pages the next VACUUM will itself end
> up deleting, in gen
On 3/3/17 14:51, Petr Jelinek wrote:
> On 03/03/17 20:37, Peter Eisentraut wrote:
>> On 2/27/17 00:23, Kyotaro HORIGUCHI wrote:
>>> Yeah, the patch sends converted string with the length of the
>>> orignal length. Usually encoding conversion changes the length of
>
On 3/3/17 19:16, Tom Lane wrote:
> Peter Eisentraut writes:
>> Use asynchronous connect API in libpqwalreceiver
>
> Buildfarm member bowerbird has been failing in the pg_rewind test since
> this patch went in. It looks like it's failing to complete connections
> from t
s consider which markup style is better, but the problem
is that it's hard to enforce either way going forward. So we need to
find the root of the problem.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
class.relfrozenxid/pg_database.datfrozenxid are advanced past
opaque->btpo.xact. While I can't see this explained anywhere, I'm
pretty sure that that's supposed to be impossible, which this patch
changes.
--
Peter Geoghegan
--
Sent via pgsql-hackers mailing list (pgsql-hacke
mmands
not fully portable, improper fsync support, poor error handling, lack of
integration with synchronous replication, inability to handle multiple
actions properly.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training &
ve just
fixed the parsing of the existing syntax. We can discuss syntax changes
separately. The second patch I have committed after some editing. I
think it was generated on top of the existing data copy patch, so it was
a bit of a mess.
--
Peter Eisentraut http://www.2ndQua
> reviewing the aspects of it that touch on whether parallelism is being
> done right, but I would like to have some help on the sorting end of
> things.
Your covering those aspects seems like something that would make this
an easier sell to another reviewer. Thanks!
--
Peter Geoghe
dex size than current heap size.
I agree with everything else you've said, I think.
--
Peter Geoghegan
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
stimate.
I don't really know what minimum amount of memory to insist workers
have, which is why I provisionally chose one of those GUCs as the
threshold.
Any better ideas?
--
Peter Geoghegan
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subsc
index size, not table size. I can
change it to be table size, based on what you said. But the workMem
related cap, which probably won't end up being applied all that often
in practice, *should* still do something with projected index size,
since that really is what we're sorting, whic
allude to would be better.
The other problem is that this measures execution time, which can vary
for reasons other than plan. I would have expected that the cost
numbers are tracked somehow.
There is also the issue of generic vs specific plans, which this
approach might be papering over.
Needs m
is patch appeared in this CF at all.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ing both issues.
Can we have a test case for page_checksum(), or is that too difficult to
get running deterministicly?
Also, perhaps page_checksum() doesn't need to be superuser-only, but I
can see arguments for keeping it that way for consistency.
--
Peter Eisentraut http:/
On 3/1/17 08:36, Peter Eisentraut wrote:
> On 2/22/17 18:24, Jim Nasby wrote:
>>> Yes, by that logic matview refresh should always be last.
>>
>> Patches for head attached.
>>
>> RLS was the first item added after DO_REFRESH_MATVIEW, which was added
>> in
xmax changes, but we have other
> bits that change even on index pages (say pd_lsn).
>
> So I'm afraid that's not going to fly.
Then just run it and throw away the result. See sql/page.sql for some
examples.
--
Peter Eisentraut http://www.2ndQuadrant.com
o
maximize the chances of that happening, but it's still generally quite
possible (e.g. pg_stat_statements never swaps constants in a query
like "SELECT 5, pg_stat_statements_reset()"). This means that we
cannot really say that this buys us a machine-readable query text
format, at least no
inal index [1], to let the cost model cap
the initial determination when maintenance_work_mem is just too low.
(This cap will rarely be applied in practice, as I said.)
[1]
https://wiki.postgresql.org/wiki/Parallel_External_Sort#bt_estimated_nblocks.28.29_function_in_pageinspect
--
Peter Geoghegan
ls are arcane such that it might as
well be that simple most of the time. Even if you have time to listen
to me explain it all, which you clearly don't, you're still probably
not going to be able to apply what you've learned in a way that helps
you.
--
Peter Geoghegan
--
Sent via
On Sat, Mar 4, 2017 at 2:15 PM, Peter Geoghegan wrote:
> So, I agree with Robert that we should actually use heap size for the
> main, initial determination of # of workers to use, but we still need
> to estimate the size of the final index [1], to let the cost model cap
>
ing to
backpatch this.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On 3/5/17 16:10, Jim Nasby wrote:
> BTW, did you backpatch as well? The function was added in 9.5.
> Presumably we wouldn't normally do that, but if we think this is unused
> enough maybe it's worth it.
It's a catalog change, so we can't backpatch it.
--
Peter
801 - 900 of 12751 matches
Mail list logo
