Re: [HACKERS] Insufficient attention to security in contrib (mostly)

2007-08-29 Thread Josh Berkus
On Tuesday 28 August 2007 15:38, Tom Lane wrote: Therefore, I propose the same choices as before for table-size (no restriction) and database-size (must have CONNECT priv), and this for tablespace-size: you must have the ability to create tables in the target tablespace.  This could be either

Re: [HACKERS] reviving dead buildfarm animals

2007-08-29 Thread Josh Berkus
Tom, I notice that five different buildfarm members are about to slide off the HEAD list for not having reported in within a month.  Do we have any process for pestering their owners to revive them?  If the hardware went south, or there was some other deliberate decision to retire them,

Re: [HACKERS] reviving dead buildfarm animals

2007-08-29 Thread Stefan Kaltenbrunner
Tom Lane wrote: I notice that five different buildfarm members are about to slide off the HEAD list for not having reported in within a month. Do we have any process for pestering their owners to revive them? If the hardware went south, or there was some other deliberate decision to retire

Re: [HACKERS] [GENERAL] Undetected corruption of table files

2007-08-29 Thread Florian Weimer
* Alban Hertroys: If you have a proper production database server, your memory has error checking, and your RAID controller has something of the kind as well. To my knowledge, no readily available controller performs validation on reads (not even for RAID-1 or RAID-10, where it would be

Re: [HACKERS] initdb failed on Windows 2000

2007-08-29 Thread Yoshiyuki Asaba
Hi, From: Yoshiyuki Asaba [EMAIL PROTECTED] Subject: [HACKERS] initdb failed on Windows 2000 Date: Mon, 27 Aug 2007 20:46:35 +0900 (JST) I have compiled PostgreSQL 8.2.4 with MinGW on Windows 2000. Then I have executed initdb as Administrator. However initdb failed with the following message.

Re: [HACKERS] Contrib modules documentation online

2007-08-29 Thread Nikolay Samokhvalov
There is a problem with line feeds for contrib/xml2: http://www.nan-tic.com/ftp/pgdoc/xml2.html As for idea itself, I find it very useful (besides usability improvements, it would help to promote Postgres advanced features). On 8/29/07, Albert Cervera i Areny [EMAIL PROTECTED] wrote: I've been

Re: [HACKERS] initdb failed on Windows 2000

2007-08-29 Thread Andrew Dunstan
Yoshiyuki Asaba wrote: I have compiled PostgreSQL 8.2.4 with MinGW on Windows 2000. Then I have executed initdb as Administrator. However initdb failed with the following message. The program postgres is needed by initdb but was not found in the same directory as

Re: [HACKERS] initdb failed on Windows 2000

2007-08-29 Thread Yoshiyuki Asaba
Hi, From: Andrew Dunstan [EMAIL PROTECTED] Subject: Re: [HACKERS] initdb failed on Windows 2000 Date: Wed, 29 Aug 2007 08:57:55 -0400 What do you want us to do about it? Isn't this a case of don't do that, then? Run initdb as some other user. We don't let you run initdb as root on Unix, so

Re: [HACKERS] initdb failed on Windows 2000

2007-08-29 Thread Andrew Dunstan
Yoshiyuki Asaba wrote: Administrator can run initdb on Windows XP, Server 2003 and Vista. Is this right? Well, I gave up on trying to get Vista to work, and I found I needed a non-Administrator user to run my new buildfarm member on XP-Pro, so I am means sure it is right. cheers

Re: [HACKERS] MSVC build system

2007-08-29 Thread David Boreham
Magnus Hagander wrote: David Boreham wrote: To add my 2d worth to this: after working on a few very large projects that built on both Unix and Windows my preference is to use a single autotools-based build for both, with a script called cccl that translates cc-style arguments for Microsoft's

[HACKERS] Dictionary chaining and stop words

2007-08-29 Thread Heikki Linnakangas
It's nice to be able to chain tsearch dictionaries, but I find that it's not as flexible as it should be. Currently we have these dictionaries built-in: dict_simple - lowercases and checks against stop word list, accepts everything not in stop word list dict_synonym - replaces with synonym, if

Re: [HACKERS] initdb failed on Windows 2000

2007-08-29 Thread Andrew Dunstan
I wrote: so I am means sure it is right. I meant, of course, so I am by no means sure it is right That's what I get for multitasking. cheers andrew ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings

Re: [HACKERS] Dictionary chaining and stop words

2007-08-29 Thread Tom Lane
Heikki Linnakangas [EMAIL PROTECTED] writes: There's clearly need for transforming a word and passing on the transformed version to the next dictionary. dict_thesaurus does exactly that by supporting a subdictionary which is called before invoking the thesaurus, but it should be generic

Re: [HACKERS] Dictionary chaining and stop words

2007-08-29 Thread Oleg Bartunov
Heikki, we know about this ( I call it filtering), but we leave it for the future after we'll have everything in core. The more demonstrative example is well-known accent-removal problem. I used to recommend to preprocess string before tsearch2, but there is a problem with headline() when this

[HACKERS] StringInfo misc. issues

2007-08-29 Thread NikhilS
Hi, I palloc0'ed a variable of type StringInfo and without doing an initStringInfo() (forgot to do it i.e.) tried to append some stuff to it using appendStringInfo(). It went into a tight loop within the function enlargeStringInfo() at: while (needed newlen) Must be a common enough case for a

Re: [HACKERS] reviving dead buildfarm animals

2007-08-29 Thread Tom Lane
Stefan Kaltenbrunner [EMAIL PROTECTED] writes: Maybe we should have a way for buildfarm owners to be able to tag animals and/or builds with a bit of status information in such cases ? +1 regards, tom lane ---(end of

Re: [HACKERS] StringInfo misc. issues

2007-08-29 Thread Andrew Dunstan
NikhilS wrote: I also found the absence of a function like resetStringInfo() a bit puzzling. A found a lot of places where the code was resetting the len field to 0 and assigning '\0' to the data field to reset the variable. This seems to be the only missing API which will be needed

Re: [HACKERS] StringInfo misc. issues

2007-08-29 Thread Alvaro Herrera
Andrew Dunstan escribió: NikhilS wrote: I also found the absence of a function like resetStringInfo() a bit puzzling. A found a lot of places where the code was resetting the len field to 0 and assigning '\0' to the data field to reset the variable. This seems to be the only missing

Re: [HACKERS] StringInfo misc. issues

2007-08-29 Thread Tom Lane
NikhilS [EMAIL PROTECTED] writes: The attached patch should fix this. And break other things, no doubt. needed = 0 is a perfectly valid edge case and mustn't be rejected here. (In fact, I doubt you'd even get through the regression tests with this patch ... how much did you test it?) The real

[HACKERS] correct behavior of ANALYZE ...

2007-08-29 Thread Hans-Juergen Schoenig
i came across some interesting behavior of pg_stats and i am not sure if this is something we should treat the way we do it. consider: test_hans=# select * from pg_stats where attname = 'id' and tablename = 't_testhugo'; schemaname | tablename | attname | null_frac | avg_width |

Re: [HACKERS] correct behavior of ANALYZE ...

2007-08-29 Thread Tom Lane
Hans-Juergen Schoenig [EMAIL PROTECTED] writes: i came across some interesting behavior of pg_stats and i am not sure if this is something we should treat the way we do it. Setting target zero means expend no work on this column. In my book that includes not doing anything to any pre-existing

Re: [HACKERS] Contrib modules documentation online

2007-08-29 Thread Josh Berkus
Albert, (crossed over to -docs, where it really belongs) I've been working on converting the current README files for all contrib modules into sgml and add it to the documentation. There are still some fixes to do but i'd like to have some feedback. Indeed, it wasn't agreed to have all if

[HACKERS] Advice on MyXactMade* flags, MyLastRecPtr, pendingDeletes and lazy XID assignment

2007-08-29 Thread Florian G. Pflug
Hi When we lazily assign XIDs, we gain another flag beside the existing MyXactMadeTempRelUpdates, MyXactMadeXLogEntry, MyLastRecPtr and smgr's pendingDeletes to tell what kind of actions a transaction performed. Adding TransactionIsIsValid(GetCurrentTransactionIdIfAny()) on top of that makes

Re: [HACKERS] Contrib modules documentation online

2007-08-29 Thread Decibel!
On Wed, Aug 29, 2007 at 10:09:07AM -0700, Josh Berkus wrote: Albert, (crossed over to -docs, where it really belongs) I've been working on converting the current README files for all contrib modules into sgml and add it to the documentation. There are still some fixes to do but i'd

Re: [DOCS] [HACKERS] Contrib modules documentation online

2007-08-29 Thread Tom Lane
Josh Berkus [EMAIL PROTECTED] writes: If we go ahead with this, I'll commit to doing a contrib README cleanup so the doc system works better. Why wouldn't we just remove the README files altogether? I can't see maintaining duplicate sets of documentation. regards, tom

Re: [DOCS] [HACKERS] Contrib modules documentation online

2007-08-29 Thread Joshua D. Drake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Tom Lane wrote: Josh Berkus [EMAIL PROTECTED] writes: If we go ahead with this, I'll commit to doing a contrib README cleanup so the doc system works better. Why wouldn't we just remove the README files altogether? I can't see maintaining

Re: [DOCS] [HACKERS] Contrib modules documentation online

2007-08-29 Thread Neil Conway
On Wed, 2007-08-29 at 13:53 -0400, Tom Lane wrote: Why wouldn't we just remove the README files altogether? I can't see maintaining duplicate sets of documentation. I agree that duplication is bad, but I think README files in the individual contrib directories is useful and worth keeping: if

Re: [DOCS] [HACKERS] Contrib modules documentation online

2007-08-29 Thread Andrew Dunstan
Tom Lane wrote: Josh Berkus [EMAIL PROTECTED] writes: If we go ahead with this, I'll commit to doing a contrib README cleanup so the doc system works better. Why wouldn't we just remove the README files altogether? I can't see maintaining duplicate sets of documentation.

Re: [DOCS] [HACKERS] Contrib modules documentation online

2007-08-29 Thread Mario Gonzalez
On 29/08/2007, Neil Conway [EMAIL PROTECTED] wrote: I wonder if it would be possible to keep the master version of the contrib docs as SGML, and generate plaintext READMEs from it during the documentation build. Hello Neil, I think I'm doing something similar but not with README files.

Re: [HACKERS] Advice on MyXactMade* flags, MyLastRecPtr, pendingDeletes and lazy XID assignment

2007-08-29 Thread Tom Lane
Florian G. Pflug [EMAIL PROTECTED] writes: I propose to do the following in my lazy XID assignment patch - can anyone see a hole in that? Cleaning up this area seems like a good idea. Just FYI, one reason why there are so many LastRec pointer variables is that the WAL record format used to

[HACKERS] Representation of ResourceOwnerIds (transient XIDs) in system views (lazy xid assignment)

2007-08-29 Thread Florian G. Pflug
Hi Since generating transient XIDs (named ResourceOwnerIDs in my patch, since their lifetime is coupled to the lifetime of a transaction's toplevel resource owner) seems to be to way to go for lazx xid assignment, I need to find a way to represent them in the pg_locks view. ResourceOwnerIds are

Re: [HACKERS] Contrib modules documentation online

2007-08-29 Thread Greg Smith
On Wed, 29 Aug 2007, Josh Berkus wrote: Guys, would it be out of the question to do this in 8.3? Please please? Are you suggesting to add an additional piece of work to the already behind schedule 8.3 timeline when there's already this idea floating around to overhaul the entire contrib

Re: [HACKERS] Advice on MyXactMade* flags, MyLastRecPtr, pendingDeletes and lazy XID assignment

2007-08-29 Thread Florian G. Pflug
Tom Lane wrote: Florian G. Pflug [EMAIL PROTECTED] writes: I propose to do the following in my lazy XID assignment patch - can anyone see a hole in that? One comment is that at the time we make an entry into smgr's pending-deletes list, I think we might not have acquired an XID yet --- if I

Re: [DOCS] [HACKERS] Contrib modules documentation online

2007-08-29 Thread Scott Marlowe
On 8/29/07, Mario Gonzalez [EMAIL PROTECTED] wrote: On 29/08/2007, Neil Conway [EMAIL PROTECTED] wrote: I wonder if it would be possible to keep the master version of the contrib docs as SGML, and generate plaintext READMEs from it during the documentation build. Hello Neil, I think

Re: [HACKERS] Representation of ResourceOwnerIds (transient XIDs) in system views (lazy xid assignment)

2007-08-29 Thread Tom Lane
Florian G. Pflug [EMAIL PROTECTED] writes: Since generating transient XIDs (named ResourceOwnerIDs in my patch, since their lifetime is coupled to the lifetime of a transaction's toplevel resource owner) seems to be to way to go for lazx xid assignment, I need to find a way to represent them

Re: [HACKERS] Advice on MyXactMade* flags, MyLastRecPtr, pendingDeletes and lazy XID assignment

2007-08-29 Thread Tom Lane
Florian G. Pflug [EMAIL PROTECTED] writes: Tom Lane wrote: One thought here is that it's not clear that we really need a concept of transaction-controlled vs not-transaction-controlled xlog records anymore. I've thinking about keeping XLOG_NO_TRAN, and doing if (!no_tran)

Re: [DOCS] [HACKERS] Contrib modules documentation online

2007-08-29 Thread Michael Glaesemann
On Aug 29, 2007, at 13:27 , Andrew Dunstan wrote: Also, let's recall what has previously been discussed for contrib, namely that we break it out into standard modules (think Perl standard modules) and other tools, and that we abandon the wholly misleading contrib name altogether. I really

Re: [HACKERS] Contrib modules documentation online

2007-08-29 Thread Josh Berkus
Greg, Are you suggesting to add an additional piece of work to the already behind schedule 8.3 timeline when there's already this idea floating around to overhaul the entire contrib structure in 8.4, which may very well make much of that work redundant? Albert's work is cool and all, but

Re: [HACKERS] Representation of ResourceOwnerIds (transient XIDs) in system views (lazy xid assignment)

2007-08-29 Thread Florian G. Pflug
Tom Lane wrote: Florian G. Pflug [EMAIL PROTECTED] writes: Since generating transient XIDs (named ResourceOwnerIDs in my patch, since their lifetime is coupled to the lifetime of a transaction's toplevel resource owner) seems to be to way to go for lazx xid assignment, I need to find a way to

Re: [HACKERS] Advice on MyXactMade* flags, MyLastRecPtr, pendingDeletes and lazy XID assignment

2007-08-29 Thread Florian G. Pflug
Tom Lane wrote: Florian G. Pflug [EMAIL PROTECTED] writes: Tom Lane wrote: One thought here is that it's not clear that we really need a concept of transaction-controlled vs not-transaction-controlled xlog records anymore. I've thinking about keeping XLOG_NO_TRAN, and doing if (!no_tran)

Re: [HACKERS] Contrib modules documentation online

2007-08-29 Thread Andrew Dunstan
Josh Berkus wrote: Greg, Are you suggesting to add an additional piece of work to the already behind schedule 8.3 timeline when there's already this idea floating around to overhaul the entire contrib structure in 8.4, which may very well make much of that work redundant? Albert's work

[HACKERS] Why is there a tsquery data type?

2007-08-29 Thread Bruce Momjian
Why does text search need a tsquery data type? I realize it needs tsvector so it can create indexes and updated trigger columns, but it seems tsquery could instead just be a simple text string. -- Bruce Momjian [EMAIL PROTECTED] http://momjian.us EnterpriseDB

Re: [HACKERS] Contrib modules documentation online

2007-08-29 Thread Brar Piening
Josh Berkus wrote: Having the contrib stuff in the main docs would remove one of the largest barriers to people knowing about the contrib features. Using PostgreSQL since Version 7.1.3 and reading this List since - I dont't know exactly but my current archives start in 2003 which was the

Re: [DOCS] [HACKERS] Contrib modules documentation online

2007-08-29 Thread Alvaro Herrera
Scott Marlowe escribió: Could the contrib README files couldn't be generated from the same source as the docs (i.e. sgml) and then put into the appropriate contrib/module/ directory. Sure they can. We already do that for INSTALL for example. -- Alvaro Herrera

[HACKERS] int8 INT64_IS_BUSTED

2007-08-29 Thread Florian G. Pflug
Hi I'm confused about whether int8s work on a machine on which INT64_IS_BUSTED. My reading of the code suggests that int8 will be available, but be, well, busted in such a machine. For example, int8mul seems as if I'd just return the wrong answer on such a machine. Or are platforms with

[HACKERS] text search function renaming

2007-08-29 Thread Oleg Bartunov
Hi there, I notice, that not all functions were renamed, for example, strip(), setweight(), numnode() Is this intentional ? Regards, Oleg _ Oleg Bartunov, Research Scientist, Head of AstroNet

Re: [HACKERS] Contrib modules documentation online

2007-08-29 Thread Greg Smith
On Wed, 29 Aug 2007, Josh Berkus wrote: Further, you know we don't finish the docs until beta. Ever. In that context, as long as the documentation cleanup doesn't slow the schedule for when beta starts I think it would be a great thing to slip into 8.3. In fact, if those are going

Re: [DOCS] [HACKERS] Contrib modules documentation online

2007-08-29 Thread Scott Marlowe
On 8/29/07, Alvaro Herrera [EMAIL PROTECTED] wrote: Scott Marlowe escribió: Could the contrib README files couldn't be generated from the same source as the docs (i.e. sgml) and then put into the appropriate contrib/module/ directory. Sure they can. We already do that for INSTALL for

[HACKERS] Re: Advice on MyXactMade* flags, MyLastRecPtr, pendingDeletes and lazy XID assignment

2007-08-29 Thread Simon Riggs
On Wed, 2007-08-29 at 19:32 +0200, Florian G. Pflug wrote: I propose to do the following in my lazy XID assignment patch The lazy XID assignment seems to be the key to unlocking this whole area. - can anyone see a hole in that? .) Get rid of MyLastRecPtr and MyXactMadeTempRelUpdates.

Re: [HACKERS] Representation of ResourceOwnerIds (transient XIDs) in system views (lazy xid assignment)

2007-08-29 Thread Tom Lane
Florian G. Pflug [EMAIL PROTECTED] writes: What about the following. .) Remove the right-hand side XID from pg_locks (The one holder or waiter of the lock). It seems to make more sense to store a RID here, Yeah, we have to do that since there might not *be* an XID holding the lock. But I

Re: [HACKERS] [ADMIN] reindexdb hangs

2007-08-29 Thread Alvaro Herrera
Tom Lane wrote: I examined cluster.c and it does seem to be missing a check too. I'm not sure where to add one though; the best choice would be the place where the list of rels is built, but that scans only pg_index, so it doesn't have access to the namespace of each rel. So one idea

Re: [HACKERS] int8 INT64_IS_BUSTED

2007-08-29 Thread Neil Conway
On Wed, 2007-08-29 at 22:41 +0200, Florian G. Pflug wrote: Or are platforms with INT64_IS_BUSTED no longer supported, and are all those #ifdefs only legacy code? Personally I think we should head in that direction: if we enable integer datetimes by default in 8.4 (per earlier discussion), such

Re: [DOCS] [HACKERS] Contrib modules documentation online

2007-08-29 Thread Tom Lane
Josh Berkus [EMAIL PROTECTED] writes: Further, you know we don't finish the docs until beta. Ever. Right, working on docs is a standard beta-period activity. I think Greg is suggesting that right now is not the time to think about improving contrib docs --- right now is the time to keep our

Re: [HACKERS] Representation of ResourceOwnerIds (transient XIDs) in system views (lazy xid assignment)

2007-08-29 Thread Florian G. Pflug
Tom Lane wrote: Florian G. Pflug [EMAIL PROTECTED] writes: What about the following. .) Remove the right-hand side XID from pg_locks (The one holder or waiter of the lock). It seems to make more sense to store a RID here, Yeah, we have to do that since there might not *be* an XID holding

Re: [HACKERS] Why is there a tsquery data type?

2007-08-29 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Why does text search need a tsquery data type? I realize it needs tsvector so it can create indexes and updated trigger columns, but it seems tsquery could instead just be a simple text string. By that logic, we don't need any data types other than

Re: [HACKERS] Contrib modules documentation online

2007-08-29 Thread Albert Cervera i Areny
I'm very strongly in favor of having this documentation. However, I think it might make sense to put Contrib Modules as a section under either Reference or Appendices. Also, I don't think it's necessary to make each command option a separate subchapter, but I can see how that would be hard

Re: [HACKERS] int8 INT64_IS_BUSTED

2007-08-29 Thread Tom Lane
Florian G. Pflug [EMAIL PROTECTED] writes: I'm confused about whether int8s work on a machine on which INT64_IS_BUSTED. My reading of the code suggests that int8 will be available, but be, well, busted in such a machine. The datatype exists, but it's really only int32. For example, int8mul

Re: [HACKERS] text search function renaming

2007-08-29 Thread Tom Lane
Oleg Bartunov [EMAIL PROTECTED] writes: I notice, that not all functions were renamed, for example, strip(), setweight(), numnode() Is this intentional ? Yeah, I thought those were OK as-is, since they only apply to tsearch-specific data types. regards, tom lane

Re: [HACKERS] Contrib modules documentation online

2007-08-29 Thread Andrew Dunstan
Albert Cervera i Areny wrote: I'm very strongly in favor of having this documentation. However, I think it might make sense to put Contrib Modules as a section under either Reference or Appendices. Also, I don't think it's necessary to make each command option a separate subchapter, but I

Re: [HACKERS] [ADMIN] reindexdb hangs

2007-08-29 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: Tom Lane wrote: Yeah, an extra fetch of the pg_class row doesn't seem all that nice. I think you'd want to check it in approximately the same two places where pg_class_ownercheck() is applied (one for the 1-xact and one for the multi-xact path).

Re: [HACKERS] int8 INT64_IS_BUSTED

2007-08-29 Thread Florian G. Pflug
Tom Lane wrote: Florian G. Pflug [EMAIL PROTECTED] writes: I'm confused about whether int8s work on a machine on which INT64_IS_BUSTED. My reading of the code suggests that int8 will be available, but be, well, busted in such a machine. The datatype exists, but it's really only int32. For

Re: [HACKERS] Why is there a tsquery data type?

2007-08-29 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Why does text search need a tsquery data type? I realize it needs tsvector so it can create indexes and updated trigger columns, but it seems tsquery could instead just be a simple text string. By that logic, we don't need any data

Re: [HACKERS] int8 INT64_IS_BUSTED

2007-08-29 Thread Tom Lane
Florian G. Pflug [EMAIL PROTECTED] writes: I still think int8mul is buggy. It calculates result as arg1 * arg2, and then checks for an overflow by dividing again, and seeing if the right answer comes out. Which sounds good. But it *skips* that check if both arguments fit into an int32 - check

Re: [HACKERS] Representation of ResourceOwnerIds (transient XIDs) in system views (lazy xid assignment)

2007-08-29 Thread Tom Lane
Florian G. Pflug [EMAIL PROTECTED] writes: What about a string representation? Something like sessionId/localTransactionId? Should we ever decide that indeed this *should* get it's own datatype, a string representation would allow for a very painless transition... Yeah, that's probably the

Re: [HACKERS] Why is there a tsquery data type?

2007-08-29 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: By that logic, we don't need any data types other than text. What is tsquery giving us that text would not? A preprocessed representation that can be compared to tsvector efficiently. Now, if you'd asked whether we need *both* tsvector

Re: [HACKERS] Advice on MyXactMade* flags, MyLastRecPtr, pendingDeletes and lazy XID assignment

2007-08-29 Thread Florian G. Pflug
Tom Lane wrote: One comment is that at the time we make an entry into smgr's pending-deletes list, I think we might not have acquired an XID yet --- if I understand your patch correctly, a CREATE TABLE would acquire an XID when it makes its first catalog insertion, and that happens after

Re: [HACKERS] Advice on MyXactMade* flags, MyLastRecPtr, pendingDeletes and lazy XID assignment

2007-08-29 Thread Tom Lane
Florian G. Pflug [EMAIL PROTECTED] writes: One comment is that at the time we make an entry into smgr's pending-deletes list, I think we might not have acquired an XID yet Hm.. I was just going to implement this, but I'm now wondering if thats really worth it. Basically what you'd give up is

Re: [HACKERS] Advice on MyXactMade* flags, MyLastRecPtr, pendingDeletes and lazy XID assignment

2007-08-29 Thread Florian G. Pflug
Tom Lane wrote: Florian G. Pflug [EMAIL PROTECTED] writes: One comment is that at the time we make an entry into smgr's pending-deletes list, I think we might not have acquired an XID yet Hm.. I was just going to implement this, but I'm now wondering if thats really worth it. Basically

Re: [HACKERS] Why is there a tsquery data type?

2007-08-29 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: By that logic, we don't need any data types other than text. What is tsquery giving us that text would not? A preprocessed representation that can be compared to tsvector efficiently. Now, if you'd asked

[HACKERS] Some more msvc++ 8.2.4 build feedback

2007-08-29 Thread Charlie Savage
In addition to the encoding issues I have with the 8.2.4 MSVC++ build (see previous email), there are some other issues that I've run into: 1. The custom build step that generates DEF files for DLLS using a perl script does not work. The perl script runs, and a slew of symbol information is

[HACKERS] msvc++ build of 8.2.4 and encodings

2007-08-29 Thread Charlie Savage
Hope this is the right place for this post... I'm been trying out the msvc++ build scripts for postgresql 8.2.4 on my development laptop (using window xp pro). I noticed the sort orders of queries changed. Investigating more, encodings don't seem to be working as expected. Using a MSVC++

Re: [HACKERS] Some more msvc++ 8.2.4 build feedback

2007-08-29 Thread Andrew Dunstan
Charlie Savage wrote: Out of curiosity, will the MSVC++ build become the default for 8.3 on Windows or will it remain MSYS for a bit longer? There is no such thing as a default build. As far as I am concerned we will support MSys into the indefinite future. cheers andrew

Re: [HACKERS] msvc++ build of 8.2.4 and encodings

2007-08-29 Thread Charlie Savage
Using a MSYS build: CREATE DATABASE test1 WITH ENCODING = 'utf8'; show all lc_collate;en_US.UTF-8 lc_ctype;en_US.UTF-8 lc_messages;C lc_monetary;C lc_numeric;C lc_time;C Sorry, the above output is for Linux (Fedora Core 6). With an MSYS build on my XP laptop its: lc_collate;C

Re: [HACKERS] msvc++ build of 8.2.4 and encodings

2007-08-29 Thread Andrew Dunstan
Charlie Savage wrote: Hope this is the right place for this post... I'm been trying out the msvc++ build scripts for postgresql 8.2.4 on my development laptop (using window xp pro). I noticed the sort orders of queries changed. Investigating more, encodings don't seem to be working as

Re: [HACKERS] Some more msvc++ 8.2.4 build feedback

2007-08-29 Thread Andrew Dunstan
Joshua D. Drake wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andrew Dunstan wrote: Charlie Savage wrote: Out of curiosity, will the MSVC++ build become the default for 8.3 on Windows or will it remain MSYS for a bit longer? There is no such thing as a default

Re: [HACKERS] msvc++ build of 8.2.4 and encodings

2007-08-29 Thread Charlie Savage
Hi Andrew, Thank for the reply. In both cases, the database clusters were created like this: initdb ---locale=c --encoding=utf8; That seems most unlikely - without the superfluous dash it should set both lc_collate and lc_ctype to C. Ah, sorry, that was a typo. If you actually try it:

Re: [HACKERS] Advice on MyXactMade* flags, MyLastRecPtr, pendingDeletes and lazy XID assignment

2007-08-29 Thread Tom Lane
Florian G. Pflug [EMAIL PROTECTED] writes: And I'm quite tempted to not flush the XLOG at all during ABORT, and to only force synchronous commits if one of the to-be-deleted files is non-temporary. +1 on the first, but -1 on the second, because we'd have to track whether deleted files are temp