Tom Lane wrote:
Brendan Jurd [EMAIL PROTECTED] writes:
On 8/15/07, Tom Lane [EMAIL PROTECTED] wrote:
For example, log_line_prefix is misnamed under this rule, and ought to
be logging_line_prefix. Similarly, redirect_stderr would become
logging_something --- I'd prefer
On Aug 18, 2007, at 20:44 , Andrew Dunstan wrote:
Logging_collector won the day. I have just committed CSVlogs with
that change.
Congrats!
A couple last-minute correx:
http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/
func.sgml?r1=1.385r2=1.386
s/log collector if
Michael Glaesemann wrote:
On Aug 18, 2007, at 20:44 , Andrew Dunstan wrote:
Logging_collector won the day. I have just committed CSVlogs with
that change.
Congrats!
A couple last-minute correx:
thanks. fixed.
cheers
andrew
---(end of
Heikki,
Should we change the ordering of pg_settings?
Well, an unfixed issue in pg_settings is that the category/subcategory
relationship got represented by a non-atomic field which makes sorting on
that difficult.
--
--Josh
Josh Berkus
PostgreSQL @ Sun
San Francisco
Andrew Dunstan wrote:
Tom Lane wrote:
Andrew Dunstan [EMAIL PROTECTED] writes:
Before I wrap up the CSVlog stuff, we need to decide whether or not to
change the name of the redirect_stderr setting, and if so to what. The
reason is that with CSVlogs it will no longer apply just
Bruce Momjian wrote:
Andrew Dunstan wrote:
I suggest redirect_logs, although it's arguably too general as it
doesn't apply to syslog/eventlog.
Perhaps it should be named analogously to stats_start_collector,
ie think of the syslogger process as a log collector. I don't
much
Alvaro Herrera wrote:
Bruce Momjian wrote:
Andrew Dunstan wrote:
I suggest redirect_logs, although it's arguably too general as it
doesn't apply to syslog/eventlog.
Perhaps it should be named analogously to stats_start_collector,
ie think of the syslogger process as a
Bruce Momjian wrote:
Alvaro Herrera wrote:
Bruce Momjian wrote:
Andrew Dunstan wrote:
I suggest redirect_logs, although it's arguably too general as it
doesn't apply to syslog/eventlog.
Perhaps it should be named analogously to stats_start_collector,
ie think
Alvaro Herrera wrote:
That sounds like you want to log when the collector starts, which is not
the case and is confusing -- what collector is it talking about? This
is about starting the log collector.
Yea, good point. I was just wondering because I don't see 'start' used
in anywhere
Andrew Dunstan wrote:
Alvaro Herrera wrote:
That sounds like you want to log when the collector starts, which is not
the case and is confusing -- what collector is it talking about? This
is about starting the log collector.
Yea, good point. I was just wondering because I
On Tue, Aug 14, 2007 at 11:42 AM, in message [EMAIL PROTECTED],
Andrew Dunstan [EMAIL PROTECTED] wrote:
Alvaro Herrera wrote:
In other places we just name the feature that's to be
started, for example we don't use start_autovacuum.
How about just log_collector then?
+1
Unambiguous and
Bruce Momjian wrote:
Andrew Dunstan wrote:
Alvaro Herrera wrote:
That sounds like you want to log when the collector starts, which is not
the case and is confusing -- what collector is it talking about? This
is about starting the log collector.
Yea, good point. I
The problem here is that log seems to be a verb in log_collector
which is what makes it confusing. So we need another verb to make it
clear that log is not one. This is not a problem with autovacuum
because that one cannot be confused with a verb.
start_log_collector still gets my vote.
Josh Berkus [EMAIL PROTECTED] writes:
The problem here is that log seems to be a verb in log_collector
which is what makes it confusing. So we need another verb to make it
clear that log is not one. This is not a problem with autovacuum
because that one cannot be confused with a verb.
Josh Berkus wrote:
The problem here is that log seems to be a verb in log_collector
which is what makes it confusing. So we need another verb to make it
clear that log is not one. This is not a problem with autovacuum
because that one cannot be confused with a verb.
start_log_collector
On Aug 14, 2007, at 12:40 , Tom Lane wrote:
Josh Berkus [EMAIL PROTECTED] writes:
The problem here is that log seems to be a verb in log_collector
which is what makes it confusing. So we need another verb to
make it
clear that log is not one. This is not a problem with
autovacuum
Michael Glaesemann [EMAIL PROTECTED] writes:
AIUI, if the-GUC-yet-to-be-named is not enabled, no logging is done
at all: messages are just sent to stderr. Why something simple like
enable_logging or start_logger?
Um, that's still logging by my definition. I could live with
start_logger,
Heikki Linnakangas wrote:
Josh Berkus wrote:
The problem here is that log seems to be a verb in log_collector
which is what makes it confusing. So we need another verb to make it
clear that log is not one. This is not a problem with autovacuum
because that one cannot be confused with a
On 8/15/07, Tom Lane [EMAIL PROTECTED] wrote:
For example, log_line_prefix is misnamed under this rule, and ought to
be logging_line_prefix. Similarly, redirect_stderr would become
logging_something --- I'd prefer logging_start_collector but could
live with logging_collector (or maybe
With so many people trying to paint this particular bikeshed, my
suggestion to Andrew is to commit the patch as is and leave the rename
for a later patch.
--
Alvaro Herrera http://www.amazon.com/gp/registry/DXLWNGRJD34J
Jude: I wish humans laid eggs
Ringlord: Why would you want
Brendan Jurd [EMAIL PROTECTED] writes:
On 8/15/07, Tom Lane [EMAIL PROTECTED] wrote:
For example, log_line_prefix is misnamed under this rule, and ought to
be logging_line_prefix. Similarly, redirect_stderr would become
logging_something --- I'd prefer logging_start_collector but could
live
On 8/15/07, Tom Lane [EMAIL PROTECTED] wrote:
Brendan Jurd [EMAIL PROTECTED] writes:
The consistent prefix idea sounds good; does logging_enable jive
with your proposal?
I dislike it. I claim that logging to plain stderr (without the
syslogger process) is still logging. Logging to syslog
Tom Lane wrote:
Andrew Dunstan [EMAIL PROTECTED] writes:
Before I wrap up the CSVlog stuff, we need to decide whether or not to
change the name of the redirect_stderr setting, and if so to what. The
reason is that with CSVlogs it will no longer apply just to stderr (we
will require it to
Andrew Dunstan [EMAIL PROTECTED] writes:
Before I wrap up the CSVlog stuff, we need to decide whether or not to
change the name of the redirect_stderr setting, and if so to what. The
reason is that with CSVlogs it will no longer apply just to stderr (we
will require it to be on for CSVlogs,
24 matches
Mail list logo
