Re: Can't add repository on development installation
Yes, this is for the 1.1 development series. It's the HEAD from
github.
I tried running ./reviewboard/manage.py registerscmtools, but was
met with this error:
Unable to load SCMTool svn = reviewboard.scmtools.svn:SVNTool:
(Djblets 0.5.6.dev (/home/rroblak/workspace/djblets), Requirement.parse
('Djblets=0.5.6'))Unable to load SCMTool git =
reviewboard.scmtools.git:GitTool: (Djblets 0.5.6.dev (/home/rroblak/
workspace/djblets), Requirement.parse('Djblets=0.5.6'))Unable to load
SCMTool bzr = reviewboard.scmtools.bzr:BZRTool: (Djblets 0.5.6.dev (/
home/rroblak/workspace/djblets), Requirement.parse('Djblets=0.5.6'))
Unable to load SCMTool cvs = reviewboard.scmtools.cvs:CVSTool:
(Djblets 0.5.6.dev (/home/rroblak/workspace/djblets), Requirement.parse
('Djblets=0.5.6'))Unable to load SCMTool perforce =
reviewboard.scmtools.perforce:PerforceTool: (Djblets 0.5.6.dev (/home/
rroblak/workspace/djblets), Requirement.parse('Djblets=0.5.6'))Unable
to load SCMTool clearcase =
reviewboard.scmtools.clearcase:ClearCaseTool: (Djblets 0.5.6.dev (/
home/rroblak/workspace/djblets), Requirement.parse('Djblets=0.5.6'))
Unable to load SCMTool hg = reviewboard.scmtools.hg:HgTool: (Djblets
0.5.6.dev (/home/rroblak/workspace/djblets), Requirement.parse
('Djblets=0.5.6'))
I tracked this down to the version specified in djblets/Djblets.egg-
info/PKG-INFO. I changed the version in this file from 0.5.6.dev to
0.5.6 and this error went away. Seems like either the version should
be changed so it doesn't kill the Requirement parser, or the
Requirement parser should be changed so that it doesn't die on non-
numeric versions.
After changing the version to 0.5.6 in djblets/Djblets.egg-info/PKG-
INFO, I tried to run registerscmtools again, but was met with this
error:
Unable to load SCMTool svn = reviewboard.scmtools.svn:SVNTool: django-
evolutionUnable to load SCMTool git =
reviewboard.scmtools.git:GitTool: django-evolutionUnable to load
SCMTool bzr = reviewboard.scmtools.bzr:BZRTool: django-evolutionUnable
to load SCMTool cvs = reviewboard.scmtools.cvs:CVSTool: django-
evolutionUnable to load SCMTool perforce =
reviewboard.scmtools.perforce:PerforceTool: django-evolutionUnable to
load SCMTool clearcase = reviewboard.scmtools.clearcase:ClearCaseTool:
django-evolutionUnable to load SCMTool hg =
reviewboard.scmtools.hg:HgTool: django-evolution
To fix this I uninstalled my previous django-evolution installation
(installed via SVN checkout as described here:
http://code.google.com/p/django-evolution/)
and reinstalled using your egg (easy_install -f http://
downloads.review-board.org/mirror/ django_evolution). I'm not sure
why my SVN installation didn't work. When I uninstalled the SVN
installation completely I was given a terse 'django-evolution not
found' error, so it seems as though the django-evolution package was
installed in some capacity, though somehow incorrectly. At any rate,
you may want to make a note of the django-evolution dependency in the
developer documentation (I realize it's already in the admin
documentation-- perhaps refactoring a separate 'dependencies' page
would be helpful?). Also, publicizing how to install your
django_evolution egg may be of help to some.
After getting django-evolution installed properly I was able to run
registerscmtools without a hitch. However, I am still getting a
global name '_' is not defined validation error on the Add
repository page. It appears that this error is being caught
upstream, as it is presented as a form validation error. Accordingly,
there is no associated stack trace (unless there is some method of
grabbing stack traces on form validation errors that I am not aware
of). I've attached a screenshot to a separate email sent to your
email address so that you can see exactly what I'm getting.
Thanks for your help.
Ryan
On Dec 13, 12:48 am, Christian Hammond chip...@chipx86.com wrote:
Hi Ryan,
Is this using the 1.1 development series?
The BackwardsIncompatibleChanges entry on this is quite old. What's really
happening is that we're just not importing _ in whatever file we need it.
Can you send me the backtrace on this?
Since you're seeing the _ error, you're really seeing that it failed to
create the repository, due to some sort of validation error. Once I have the
backtrace, I should be able to fix this and let you know roughly what it
should have reported.
As for the missing entries in the drop-down, you'll need to run:
./reviewboard/manage.py registerscmtools
That should register all the SCMTools so you can use them properly. I'll
make a note to add that to the docs.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Sun, Dec 13, 2009 at 12:36 AM, Ryan Oblak rrob...@gmail.com wrote:
Hi all,
I'm trying to setup a local development installation of Review Board.
As per
http://www.reviewboard.org/docs/codebase/dev/getting-started/#review-...
I
How to make forcing pre-commit review
Hi,all, It seems that the ReviewBoard help Review code with a Human positive process, But somtimes a programmer may lazy to make code review process and commit his code directly. So is there any way to force all RB users in a ReviewGroup to make pre-commit review? say, If somebody write new code and commit to CVS without doing pre-commit review request, or if not all his Reviewers admit his commit, His cvs commit operation would come into false. Best Regards! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How to make forcing pre-commit review
With CVS you can write pre-commit scripts. In our repository, we are required to input a valid defect ID as the first item in the commit log. CVS looks up that defect ID and checks for the results of a review request. Alternatively, you could require the developers to include the review id in the commit log, then it is easy to look it up on reviewboard. Scott On Mon, Dec 14, 2009 at 6:49 AM, JohnHenry qhlonl...@163.com wrote: Hi,all, It seems that the ReviewBoard help Review code with a Human positive process, But somtimes a programmer may lazy to make code review process and commit his code directly. So is there any way to force all RB users in a ReviewGroup to make pre-commit review? say, If somebody write new code and commit to CVS without doing pre-commit review request, or if not all his Reviewers admit his commit, His cvs commit operation would come into false. Best Regards! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: One or more fields had errors: fields: 'path': 'This field is required.'
Which version of Review Board is this running right now? I've seen this
recently on the 1.1 alpha nightlies.
Also, what repository type is this? It could indicate a missing dependency.
The error checking/reporting for that on 1.0.x is pretty bad, but improved
in 1.1.
Is this only happening to some people and not everyone?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Mon, Dec 14, 2009 at 7:32 AM, Thilo-Alexander Ginkel th...@ginkel.comwrote:
Hello everyone,
I am currently somewhat stuck figuring out the cause of an error that
some colleagues are getting in response to the
/api/json/reviewrequests/id/diff/new/ call when posting a new review
request:
{u'fields': {u'path': [u'This field is required.']}, u'stat': u'fail',
u'err': {u'msg': u'One or more fields had errors', u'code': 105}}
I did some debugging on the server side and it seems that in new_diff
in json.py the form.is_valid() call returns false. I also enhanced
post-review with some debugging code and can see that the following
request is dispatched to the server:
Posting API request: path=api/json/reviewrequests/id/diff/new/,
fields={}, files={'path': {'content': u'diff', 'filename': 'diff'}}
Any idea what may be wrong here?
Thanks,
Thilo
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard using with WebUI, diff file is not recogonized.
You'll need cvs diff -uN. It's best just to use post-review though. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sun, Dec 13, 2009 at 7:18 PM, JohnHenry qhlonl...@163.com wrote: Hi, all, I tried the use ReviewBoard to create a review request through WebUI, I had tried to create diff file with cvs diff myfile' command, But when uploading this file to create reviewrequest , RB reports: The selected file does not appear to be a diff; Then I used command cvs diff --ifdef=unified myfile to generate the diff file, But this time the report is also as said above. What is the reason? Best Regards! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: About the relationship between ReviewBoard Server and CVS
Hi,
You will need cvs on the server, definitely. The 1.1 alpha series won't let
you create a CVS repository without having it. You'll also need it on the
client running post-review.
The base path should be None in this case. It's really only needed for
Subversion.
Can you show me the Repository entries you have configured in the
administration UI in Review Board?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
2009/12/14 JohnHenry qhlonl...@163.com
Hi,
The detailed error info is:
-
[jo...@dev2 test]$ post-review --debug --username=Johnl1 --
password=Johnl1 myTestCode.c
svn info
repository info: Path: cvs_gz:/export/home/cvsroot, Base path: None,
Supports changesets: False
cvs diff -uN myTestCode.c
Looking for '192.168.3.20 /' cookie in
/data1/John1/.post-review-cookies.txt
Couldn't load cookie file: '/data1/John1/.post-review-cookies.txt' does
not look like a Netscape format cookies file
== Review Board Login Required
Enter username and password for Review Board at http://192.168.3.20:8080/
Logging in with username John1
HTTP POSTing to http://192.168.3.20:8080/api/json/accounts/login/:
{'username': 'John1', 'password': '**'}
Logged in.
Attempting to create review request for None
HTTP POSTing to http://192.168.3.20:8080/api/json/reviewrequests/new/:
{'repository_path': 'cvs_gz:/export/home/cvsroot'}
Error creating review request: The repository path specified is not in
the list of known repositories (code 206)
-
My question is : Why the Base path value of mine is None? does it
have relationship with my problem code 206? if it does, Then how to
set this Base path in Review Board?
I have not installed CVS or SVN, I am using an account on an exist CVS
server. Must I have to install a independent CVS for the ReviewBoard?
Best Regards!
On 12月14日, 下午5时53分, Christian Hammond chip...@chipx86.com wrote:
Hi,
The Path or Mirror Path for the Repository entry in the admin UI in
Review
Board must be exactly what post-review is trying to report. So, in your
case, it should be cvs_gz/export/home/cvsoot. I'm hoping to add fuzzy
matching in the future (so as to make it possible to use aliases for
domains, be more flexible with IP addresses and usernames, etc.), but for
now it must be an exact match.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
2009/12/14 JohnHenry qhlonl...@163.com
Hi,
This problem has been resolved; in the .reviewboardrc , I set the
REVIEWBOARD_URL ashttp://192.168.3.20:8080/reviewboard;after I
delete the reviewboard ,login is successful now. But I stil can not
use RB yet, Error info:
Error creating review request: The repository path specified is not in
the list of known repositories (code 206);
I found my previous Repository setting is the parent dir of actual
Repository dir. So I have reset the Repository path on web
UI: :pserver:myn...@192.168.3.151:/export/home/cvsroot/test
But still, The info is : {'repository_path': 'cvs_gz:/export/home/
cvsroot'} the cvs_gz value is not changed at all, Why?
Best Regards!
On Dec 12, 5:25 pm, Christian Hammond chip...@chipx86.com wrote:
The .post-review-cookies.txt file is where the HTTP cookie with the
authentication token is stored. This prevents needing to log in after
the
first post-review (generally)
read more
If you go tohttp://192.168.3.20:8080/reviewboard/api/json/inyour
browser,
what do you see?
The two paths you saw should be correct (though, there shouldn't be a
period
at the end). One is the page you go to in your browser for logging in
with
the web UI. The other is the one that tools like post-review can call
to
log
in programatically.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
2009/12/11 JohnHenry qhlonl...@163.com
more detailed infomation from debug(data) in RBTools-02.beta2-
py2.5.egg, process_json function:
svn info
repository info: Path: cvs_gz:/export/home/cvsroot, Base path:
None,
Supports changesets: False
cvs diff -uN myUCMobile.c reviewboard.jpg
Looking for '192.168.2.20 /reviewboard/' cookie in
/data/John1/.post-review-cookies.txt
Couldn't load cookie file: [Errno 2] No such file or directory:
'/data/John1/.post-review-cookies.txt'
== Review Board Login Required
Enter username and password for Review Board at
http://192.168.3.20:8080/reviewboard/
Logging in with username John1
HTTP POSTing to
Re: One or more fields had errors: fields: 'path': 'This field is required.'
It should just be the field constraints from those FileFields. We don't do any custom validation checks in those forms that I can see. It could potentially fail if the diff itself is empty, even though the name is populated. Are they uploading using post-review? Might be worth seeing what post-review --output-diff shows. Or otherwise, just making sure the diff is non-empty. Short of that, I wouldn't be able to see off-hand without seeing the code and doing my own debugging. Though it's probably not the cause, it also might be worth checking if there are any proxy settings getting in the way. We used to run into some issues with users who were going through the proxy for the Review Board server (despite it being within the network), and some stuff broke along the way. Though I don't believe we hit file upload issues. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Dec 14, 2009 at 1:52 PM, Thilo-Alexander Ginkel th...@ginkel.comwrote: On Monday 14 December 2009 22:28:35 Christian Hammond wrote: Which version of Review Board is this running right now? I've seen this recently on the 1.1 alpha nightlies. It's a slightly patched 1.0.5.1. Also, what repository type is this? It could indicate a missing dependency. The error checking/reporting for that on 1.0.x is pretty bad, but improved in 1.1. It's a custom SCM, so I cannot rule out that the bug is in my code. Dependencies should not be an issue, though, as the SCM client code is mostly self-contained and does all of its communication with the SCM via HTTP. Do you have an idea what may be causing form.is_valid() to return false? Is it just the mandatory field constraints, which are being checked? The weird thing is, that according to my client-side dump the 'path' attribute is populated correctly. Is this only happening to some people and not everyone? Yes. Regards, Thilo -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Installation problem
I am getting the same issue: r...@scubuntuvm1:~# python --version Python 2.5.2 r...@scubuntuvm1:~# lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description:Ubuntu 8.04.3 LTS Release:8.04 Codename: hardy r...@scubuntuvm1:~# uname -r 2.6.24-23-generic On Dec 14, 2:26 pm, Christian Hammond chip...@chipx86.com wrote: Hi, The manual updates page is old and generally isn't seen anymore. We'll need to update the text to reference rb-site instead of manage.py. The error definitely seems to be that PIL isn't installed correctly. Yes, easy_install should get it, but perhaps something went wrong. What version of Python is being used on the system? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Dec 14, 2009 at 12:07 PM, Dregel dre...@gmail.com wrote: Hi, After following the installation guide, I got RB kind of working on centos but when I go to default page I get the message: Manual server updates required The suggestion is to run manage.py. After some investigation I found someone that recommended a rb-site upgrade instead and that command reveals a problem: []# rb-site -d upgrade /var/www/reviewboard Rebuilding directory structure Updating database. This may take a while. Error: One or more models did not validate: reviews.screenshot: image: To use ImageFields, you need to install the Python Imaging Library. Get it at http://www.pythonware.com/products/pil/ . What gives? I thought PIL was correctly installed when running easy_install but it's not working. Any suggestions? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Installation problem
From a python prompt, type: import PIL If that fails, then PIL is not installed on the system. If it does work, then we need to investigate why your Python isn't seeing it. I assume you've done a web server restart since installing Review Board? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Dec 14, 2009 at 4:03 PM, nshenry03 nshenr...@gmail.com wrote: I am getting the same issue: r...@scubuntuvm1:~# python --version Python 2.5.2 r...@scubuntuvm1:~# lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description:Ubuntu 8.04.3 LTS Release:8.04 Codename: hardy r...@scubuntuvm1:~# uname -r 2.6.24-23-generic On Dec 14, 2:26 pm, Christian Hammond chip...@chipx86.com wrote: Hi, The manual updates page is old and generally isn't seen anymore. We'll need to update the text to reference rb-site instead of manage.py. The error definitely seems to be that PIL isn't installed correctly. Yes, easy_install should get it, but perhaps something went wrong. What version of Python is being used on the system? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Dec 14, 2009 at 12:07 PM, Dregel dre...@gmail.com wrote: Hi, After following the installation guide, I got RB kind of working on centos but when I go to default page I get the message: Manual server updates required The suggestion is to run manage.py. After some investigation I found someone that recommended a rb-site upgrade instead and that command reveals a problem: []# rb-site -d upgrade /var/www/reviewboard Rebuilding directory structure Updating database. This may take a while. Error: One or more models did not validate: reviews.screenshot: image: To use ImageFields, you need to install the Python Imaging Library. Get it at http://www.pythonware.com/products/pil/ . What gives? I thought PIL was correctly installed when running easy_install but it's not working. Any suggestions? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.comreviewboard%252bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: About the relationship between ReviewBoard Server and CVS
OK, I am using ReviewBoardV1.05 My Repository setting on Administrator
UI is as follows:
Name: NewProductCode
Path: :perver:jo...@192.168.3.151:/export/home/
cvsroot
Mirror Path: /cvs_gz/export/home/cvsroot
Repository Type: CVS
Username: myCVS_account
Password: myCVS_password
And, The machine of ReviewBoardServer is 192.168.3.20, Which had
installed cvs client but no CVS server(as you can see ,server is on
the 192.168.3.151 machine),That is all. Thanks for your suggesion.
Best Regards!
On Dec 15, 5:35 am, Christian Hammond chip...@chipx86.com wrote:
Hi,...
read more
You will need cvs on the server, definitely. The 1.1 alpha series won't let
you create a CVS repository without having it. You'll also need it on the
client running post-review.
The base path should be None in this case. It's really only needed for
Subversion.
Can you show me the Repository entries you have configured in the
administration UI in Review Board?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
2009/12/14 JohnHenry qhlonl...@163.com
Hi,
The detailed error info is:
-
[jo...@dev2 test]$ post-review --debug --username=Johnl1 --
password=Johnl1 myTestCode.c
svn info
repository info: Path: cvs_gz:/export/home/cvsroot, Base path: None,
Supports changesets: False
cvs diff -uN myTestCode.c
Looking for '192.168.3.20 /' cookie in
/data1/John1/.post-review-cookies.txt
Couldn't load cookie file: '/data1/John1/.post-review-cookies.txt' does
not look like a Netscape format cookies file
== Review Board Login Required
Enter username and password for Review Board athttp://192.168.3.20:8080/
Logging in with username John1
HTTP POSTing tohttp://192.168.3.20:8080/api/json/accounts/login/:
{'username': 'John1', 'password': '**'}
Logged in.
Attempting to create review request for None
HTTP POSTing tohttp://192.168.3.20:8080/api/json/reviewrequests/new/:
{'repository_path': 'cvs_gz:/export/home/cvsroot'}
Error creating review request: The repository path specified is not in
the list of known repositories (code 206)
--
My question is : Why the Base path value of mine is None? does it
have relationship with my problem code 206? if it does, Then how to
set this Base path in Review Board?
I have not installed CVS or SVN, I am using an account on an exist CVS
server. Must I have to install a independent CVS for the ReviewBoard?
Best Regards!
On 12月14日, 下午5时53分, Christian Hammond chip...@chipx86.com wrote:
Hi,
The Path or Mirror Path for the Repository entry in the admin UI in
Review
Board must be exactly what post-review is trying to report. So, in your
case, it should be cvs_gz/export/home/cvsoot. I'm hoping to add fuzzy
matching in the future (so as to make it possible to use aliases for
domains, be more flexible with IP addresses and usernames, etc.), but for
now it must be an exact match.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
2009/12/14 JohnHenry qhlonl...@163.com
Hi,
This problem has been resolved; in the .reviewboardrc , I set the
REVIEWBOARD_URL ashttp://192.168.3.20:8080/reviewboard;afterI
delete the reviewboard ,login is successful now. But I stil can not
use RB yet, Error info:
Error creating review request: The repository path specified is not in
the list of known repositories (code 206);
I found my previous Repository setting is the parent dir of actual
Repository dir. So I have reset the Repository path on web
UI: :pserver:myn...@192.168.3.151:/export/home/cvsroot/test
But still, The info is : {'repository_path': 'cvs_gz:/export/home/
cvsroot'} the cvs_gz value is not changed at all, Why?
Best Regards!
On Dec 12, 5:25 pm, Christian Hammond chip...@chipx86.com wrote:
The .post-review-cookies.txt file is where the HTTP cookie with the
authentication token is stored. This prevents needing to log in after
the
first post-review (generally)
read more
If you go tohttp://192.168.3.20:8080/reviewboard/api/json/inyour
browser,
what do you see?
The two paths you saw should be correct (though, there shouldn't be a
period
at the end). One is the page you go to in your browser for logging in
with
the web UI. The other is the one that tools like post-review can call
to
log
in programatically.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
2009/12/11
Re: ReviewBoard using with WebUI, diff file is not recogonized.
Thanks for reply, It works now. Best Regards! On Dec 15, 5:29 am, Christian Hammond chip...@chipx86.com wrote: You'll need cvs diff -uN. It's best just to use post-review though. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Sun, Dec 13, 2009 at 7:18 PM, JohnHenry qhlonl...@163.com wrote: Hi, all, I tried the use ReviewBoard to create a review request through WebUI, I had tried to create diff file with cvs diff myfile' command, But when uploading this file to create reviewrequest , RB reports: The selected file does not appear to be a diff; Then I used command cvs diff --ifdef=unified myfile to generate the diff file, But this time the report is also as said above. What is the reason? Best Regards! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en- Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: About the relationship between ReviewBoard Server and CVS
With your help, I can use WebUI pre-commit review now. But why the
post-review can't find Base
Path of repository?
Regards!
On Dec 15, 5:35 am, Christian Hammond chip...@chipx86.com wrote:
Hi,...
read more
You will need cvs on the server, definitely. The 1.1 alpha series won't let
you create a CVS repository without having it. You'll also need it on the
client running post-review.
The base path should be None in this case. It's really only needed for
Subversion.
Can you show me the Repository entries you have configured in the
administration UI in Review Board?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
2009/12/14 JohnHenry qhlonl...@163.com
Hi,
The detailed error info is:
-
[jo...@dev2 test]$ post-review --debug --username=Johnl1 --
password=Johnl1 myTestCode.c
svn info
repository info: Path: cvs_gz:/export/home/cvsroot, Base path: None,
Supports changesets: False
cvs diff -uN myTestCode.c
Looking for '192.168.3.20 /' cookie in
/data1/John1/.post-review-cookies.txt
Couldn't load cookie file: '/data1/John1/.post-review-cookies.txt' does
not look like a Netscape format cookies file
== Review Board Login Required
Enter username and password for Review Board athttp://192.168.3.20:8080/
Logging in with username John1
HTTP POSTing tohttp://192.168.3.20:8080/api/json/accounts/login/:
{'username': 'John1', 'password': '**'}
Logged in.
Attempting to create review request for None
HTTP POSTing tohttp://192.168.3.20:8080/api/json/reviewrequests/new/:
{'repository_path': 'cvs_gz:/export/home/cvsroot'}
Error creating review request: The repository path specified is not in
the list of known repositories (code 206)
--
My question is : Why the Base path value of mine is None? does it
have relationship with my problem code 206? if it does, Then how to
set this Base path in Review Board?
I have not installed CVS or SVN, I am using an account on an exist CVS
server. Must I have to install a independent CVS for the ReviewBoard?
Best Regards!
On 12月14日, 下午5时53分, Christian Hammond chip...@chipx86.com wrote:
Hi,
The Path or Mirror Path for the Repository entry in the admin UI in
Review
Board must be exactly what post-review is trying to report. So, in your
case, it should be cvs_gz/export/home/cvsoot. I'm hoping to add fuzzy
matching in the future (so as to make it possible to use aliases for
domains, be more flexible with IP addresses and usernames, etc.), but for
now it must be an exact match.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
2009/12/14 JohnHenry qhlonl...@163.com
Hi,
This problem has been resolved; in the .reviewboardrc , I set the
REVIEWBOARD_URL ashttp://192.168.3.20:8080/reviewboard;afterI
delete the reviewboard ,login is successful now. But I stil can not
use RB yet, Error info:
Error creating review request: The repository path specified is not in
the list of known repositories (code 206);
I found my previous Repository setting is the parent dir of actual
Repository dir. So I have reset the Repository path on web
UI: :pserver:myn...@192.168.3.151:/export/home/cvsroot/test
But still, The info is : {'repository_path': 'cvs_gz:/export/home/
cvsroot'} the cvs_gz value is not changed at all, Why?
Best Regards!
On Dec 12, 5:25 pm, Christian Hammond chip...@chipx86.com wrote:
The .post-review-cookies.txt file is where the HTTP cookie with the
authentication token is stored. This prevents needing to log in after
the
first post-review (generally)
read more
If you go tohttp://192.168.3.20:8080/reviewboard/api/json/inyour
browser,
what do you see?
The two paths you saw should be correct (though, there shouldn't be a
period
at the end). One is the page you go to in your browser for logging in
with
the web UI. The other is the one that tools like post-review can call
to
log
in programatically.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
2009/12/11 JohnHenry qhlonl...@163.com
more detailed infomation from debug(data) in RBTools-02.beta2-
py2.5.egg, process_json function:
svn info
repository info: Path: cvs_gz:/export/home/cvsroot, Base path:
None,
Supports changesets: False
cvs diff -uN myUCMobile.c reviewboard.jpg
Looking for '192.168.2.20 /reviewboard/' cookie in
/data/John1/.post-review-cookies.txt
Couldn't load cookie file: [Errno 2] No such
Re: About the relationship between ReviewBoard Server and CVS
Another problem is When I am using CVS repository, the debug info
report is :
svn info
On Dec 15, 5:35 am, Christian Hammond chip...@chipx86.com wrote:
Hi,...
read more
You will need cvs on the server, definitely. The 1.1 alpha series won't let
you create a CVS repository without having it. You'll also need it on the
client running post-review.
The base path should be None in this case. It's really only needed for
Subversion.
Can you show me the Repository entries you have configured in the
administration UI in Review Board?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
2009/12/14 JohnHenry qhlonl...@163.com
Hi,
The detailed error info is:
-
[jo...@dev2 test]$ post-review --debug --username=Johnl1 --
password=Johnl1 myTestCode.c
svn info
repository info: Path: cvs_gz:/export/home/cvsroot, Base path: None,
Supports changesets: False
cvs diff -uN myTestCode.c
Looking for '192.168.3.20 /' cookie in
/data1/John1/.post-review-cookies.txt
Couldn't load cookie file: '/data1/John1/.post-review-cookies.txt' does
not look like a Netscape format cookies file
== Review Board Login Required
Enter username and password for Review Board athttp://192.168.3.20:8080/
Logging in with username John1
HTTP POSTing tohttp://192.168.3.20:8080/api/json/accounts/login/:
{'username': 'John1', 'password': '**'}
Logged in.
Attempting to create review request for None
HTTP POSTing tohttp://192.168.3.20:8080/api/json/reviewrequests/new/:
{'repository_path': 'cvs_gz:/export/home/cvsroot'}
Error creating review request: The repository path specified is not in
the list of known repositories (code 206)
--
My question is : Why the Base path value of mine is None? does it
have relationship with my problem code 206? if it does, Then how to
set this Base path in Review Board?
I have not installed CVS or SVN, I am using an account on an exist CVS
server. Must I have to install a independent CVS for the ReviewBoard?
Best Regards!
On 12月14日, 下午5时53分, Christian Hammond chip...@chipx86.com wrote:
Hi,
The Path or Mirror Path for the Repository entry in the admin UI in
Review
Board must be exactly what post-review is trying to report. So, in your
case, it should be cvs_gz/export/home/cvsoot. I'm hoping to add fuzzy
matching in the future (so as to make it possible to use aliases for
domains, be more flexible with IP addresses and usernames, etc.), but for
now it must be an exact match.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
2009/12/14 JohnHenry qhlonl...@163.com
Hi,
This problem has been resolved; in the .reviewboardrc , I set the
REVIEWBOARD_URL ashttp://192.168.3.20:8080/reviewboard;afterI
delete the reviewboard ,login is successful now. But I stil can not
use RB yet, Error info:
Error creating review request: The repository path specified is not in
the list of known repositories (code 206);
I found my previous Repository setting is the parent dir of actual
Repository dir. So I have reset the Repository path on web
UI: :pserver:myn...@192.168.3.151:/export/home/cvsroot/test
But still, The info is : {'repository_path': 'cvs_gz:/export/home/
cvsroot'} the cvs_gz value is not changed at all, Why?
Best Regards!
On Dec 12, 5:25 pm, Christian Hammond chip...@chipx86.com wrote:
The .post-review-cookies.txt file is where the HTTP cookie with the
authentication token is stored. This prevents needing to log in after
the
first post-review (generally)
read more
If you go tohttp://192.168.3.20:8080/reviewboard/api/json/inyour
browser,
what do you see?
The two paths you saw should be correct (though, there shouldn't be a
period
at the end). One is the page you go to in your browser for logging in
with
the web UI. The other is the one that tools like post-review can call
to
log
in programatically.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
2009/12/11 JohnHenry qhlonl...@163.com
more detailed infomation from debug(data) in RBTools-02.beta2-
py2.5.egg, process_json function:
svn info
repository info: Path: cvs_gz:/export/home/cvsroot, Base path:
None,
Supports changesets: False
cvs diff -uN myUCMobile.c reviewboard.jpg
Looking for '192.168.2.20 /reviewboard/' cookie in
/data/John1/.post-review-cookies.txt
Couldn't load cookie file: [Errno 2] No such file or directory:
Re: About the relationship between ReviewBoard Server and CVS
Hi, Christian,
I have changed the source of Postreview.py, and now the post-
review can work fine. I found that in class CVSClient, the function
get_repository_info, It use socket.getfqdn(host) to replace the host
of repository_path; So I managed to keep the repository_path
unchanged. Though I don't quite catche what the socket.getfqdn(host)
mean, But keep the repository_path will finally works. Now I can use
post-review to generate reviewrequest. But if you can give me more
guidance about the reason, I will be much thanks. And I need your help
about ReviewBoard rebuild method, If I changed some source of
reviewboard, then how to rebuild this project to apply my change? I
think Reviewboard is a server application based on Django, There must
be some difference between it's rebuild and the change on post-review
code. Need your suggestion.
Best Regards!
Hi,...
read more
You will need cvs on the server, definitely. The 1.1 alpha series won't let
you create a CVS repository without having it. You'll also need it on the
client running post-review.
The base path should be None in this case. It's really only needed for
Subversion.
Can you show me the Repository entries you have configured in the
administration UI in Review Board?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
2009/12/14 JohnHenry qhlonl...@163.com
Hi,
The detailed error info is:
-
[jo...@dev2 test]$ post-review --debug --username=Johnl1 --
password=Johnl1 myTestCode.c
svn info
repository info: Path: cvs_gz:/export/home/cvsroot, Base path: None,
Supports changesets: False
cvs diff -uN myTestCode.c
Looking for '192.168.3.20 /' cookie in
/data1/John1/.post-review-cookies.txt
Couldn't load cookie file: '/data1/John1/.post-review-cookies.txt' does
not look like a Netscape format cookies file
== Review Board Login Required
Enter username and password for Review Board athttp://192.168.3.20:8080/
Logging in with username John1
HTTP POSTing tohttp://192.168.3.20:8080/api/json/accounts/login/:
{'username': 'John1', 'password': '**'}
Logged in.
Attempting to create review request for None
HTTP POSTing tohttp://192.168.3.20:8080/api/json/reviewrequests/new/:
{'repository_path': 'cvs_gz:/export/home/cvsroot'}
Error creating review request: The repository path specified is not in
the list of known repositories (code 206)
--
My question is : Why the Base path value of mine is None? does it
have relationship with my problem code 206? if it does, Then how to
set this Base path in Review Board?
I have not installed CVS or SVN, I am using an account on an exist CVS
server. Must I have to install a independent CVS for the ReviewBoard?
Best Regards!
On 12月14日, 下午5时53分, Christian Hammond chip...@chipx86.com wrote:
Hi,
The Path or Mirror Path for the Repository entry in the admin UI in
Review
Board must be exactly what post-review is trying to report. So, in your
case, it should be cvs_gz/export/home/cvsoot. I'm hoping to add fuzzy
matching in the future (so as to make it possible to use aliases for
domains, be more flexible with IP addresses and usernames, etc.), but for
now it must be an exact match.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
2009/12/14 JohnHenry qhlonl...@163.com
Hi,
This problem has been resolved; in the .reviewboardrc , I set the
REVIEWBOARD_URL ashttp://192.168.3.20:8080/reviewboard;afterI
delete the reviewboard ,login is successful now. But I stil can not
use RB yet, Error info:
Error creating review request: The repository path specified is not in
the list of known repositories (code 206);
I found my previous Repository setting is the parent dir of actual
Repository dir. So I have reset the Repository path on web
UI: :pserver:myn...@192.168.3.151:/export/home/cvsroot/test
But still, The info is : {'repository_path': 'cvs_gz:/export/home/
cvsroot'} the cvs_gz value is not changed at all, Why?
Best Regards!
On Dec 12, 5:25 pm, Christian Hammond chip...@chipx86.com wrote:
The .post-review-cookies.txt file is where the HTTP cookie with the
authentication token is stored. This prevents needing to log in after
the
first post-review (generally)
read more
If you go tohttp://192.168.3.20:8080/reviewboard/api/json/inyour
browser,
what do you see?
The two paths you saw should be correct (though, there shouldn't be a
period
at the end). One is the page you go to in your browser for logging in
with
the web UI. The other is the one that tools like post-review can call
to
Re: About the relationship between ReviewBoard Server and CVS
The getfqdn call essentially gets the fully-qualified domain (so,
foo.example.com instead of just foo, for instance).
We recently added support for Perforce to check against all aliases,
including what's reported locally. We should add this for CVS as well.
I don't really know what you mean by rebuild method. Do you mean you want to
know how to update a review request when you change the code you're writing
for your project? If so, then you can use the -r parameter of post-review.
For example, to update review request #42 with your latest code changes,
run:
post-review -r 42
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
2009/12/14 JohnHenry qhlonl...@163.com
Hi, Christian,
I have changed the source of Postreview.py, and now the post-
review can work fine. I found that in class CVSClient, the function
get_repository_info, It use socket.getfqdn(host) to replace the host
of repository_path; So I managed to keep the repository_path
unchanged. Though I don't quite catche what the socket.getfqdn(host)
mean, But keep the repository_path will finally works. Now I can use
post-review to generate reviewrequest. But if you can give me more
guidance about the reason, I will be much thanks. And I need your help
about ReviewBoard rebuild method, If I changed some source of
reviewboard, then how to rebuild this project to apply my change? I
think Reviewboard is a server application based on Django, There must
be some difference between it's rebuild and the change on post-review
code. Need your suggestion.
Best Regards!
Hi,...
read more
You will need cvs on the server, definitely. The 1.1 alpha series won't
let
you create a CVS repository without having it. You'll also need it on the
client running post-review.
The base path should be None in this case. It's really only needed for
Subversion.
Can you show me the Repository entries you have configured in the
administration UI in Review Board?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
2009/12/14 JohnHenry qhlonl...@163.com
Hi,
The detailed error info is:
-
[jo...@dev2 test]$ post-review --debug --username=Johnl1 --
password=Johnl1 myTestCode.c
svn info
repository info: Path: cvs_gz:/export/home/cvsroot, Base path:
None,
Supports changesets: False
cvs diff -uN myTestCode.c
Looking for '192.168.3.20 /' cookie in
/data1/John1/.post-review-cookies.txt
Couldn't load cookie file: '/data1/John1/.post-review-cookies.txt'
does
not look like a Netscape format cookies file
== Review Board Login Required
Enter username and password for Review Board athttp://
192.168.3.20:8080/
Logging in with username John1
HTTP POSTing tohttp://192.168.3.20:8080/api/json/accounts/login/:
{'username': 'John1', 'password': '**'}
Logged in.
Attempting to create review request for None
HTTP POSTing tohttp://
192.168.3.20:8080/api/json/reviewrequests/new/:
{'repository_path': 'cvs_gz:/export/home/cvsroot'}
Error creating review request: The repository path specified is not in
the list of known repositories (code 206)
--
My question is : Why the Base path value of mine is None? does it
have relationship with my problem code 206? if it does, Then how to
set this Base path in Review Board?
I have not installed CVS or SVN, I am using an account on an exist CVS
server. Must I have to install a independent CVS for the ReviewBoard?
Best Regards!
On 12月14日, 下午5时53分, Christian Hammond chip...@chipx86.com wrote:
Hi,
The Path or Mirror Path for the Repository entry in the admin UI in
Review
Board must be exactly what post-review is trying to report. So, in
your
case, it should be cvs_gz/export/home/cvsoot. I'm hoping to add
fuzzy
matching in the future (so as to make it possible to use aliases for
domains, be more flexible with IP addresses and usernames, etc.), but
for
now it must be an exact match.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
2009/12/14 JohnHenry qhlonl...@163.com
Hi,
This problem has been resolved; in the .reviewboardrc , I set the
REVIEWBOARD_URL ashttp://192.168.3.20:8080/reviewboard;afterI
delete the reviewboard ,login is successful now. But I stil can
not
use RB yet, Error info:
Error creating review request: The repository path specified is not
in
the list of known repositories (code 206);
I found my previous Repository setting is the parent dir of
actual
Repository dir. So I have
Re: About the relationship between ReviewBoard Server and CVS
Hi, Christian,
Thanks for replay. I said rebuild because I am using the directly
installed ReviewBoard, I don't know it's compiling form souce process.
If I want to change some python source code of ReviewBoard, Then how
to compile the ReviewBoard again, and do I need to reinstall the
compile result again for use? Sorry for my bad English expression.
Best Regards!
On Dec 15, 1:50 pm, Christian Hammond chip...@chipx86.com wrote:
The getfqdn call essentially gets the fully-qualified domain (so,
foo.example.com instead of just foo, for instance)
read more
We recently added support for Perforce to check against all aliases,
including what's reported locally. We should add this for CVS as well.
I don't really know what you mean by rebuild method. Do you mean you want to
know how to update a review request when you change the code you're writing
for your project? If so, then you can use the -r parameter of post-review.
For example, to update review request #42 with your latest code changes,
run:
post-review -r 42
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
2009/12/14 JohnHenry qhlonl...@163.com
Hi, Christian,
I have changed the source of Postreview.py, and now the post-
review can work fine. I found that in class CVSClient, the function
get_repository_info, It use socket.getfqdn(host) to replace the host
of repository_path; So I managed to keep the repository_path
unchanged. Though I don't quite catche what the socket.getfqdn(host)
mean, But keep the repository_path will finally works. Now I can use
post-review to generate reviewrequest. But if you can give me more
guidance about the reason, I will be much thanks. And I need your help
about ReviewBoard rebuild method, If I changed some source of
reviewboard, then how to rebuild this project to apply my change? I
think Reviewboard is a server application based on Django, There must
be some difference between it's rebuild and the change on post-review
code. Need your suggestion.
Best Regards!
Hi,...
read more
You will need cvs on the server, definitely. The 1.1 alpha series won't
let
you create a CVS repository without having it. You'll also need it on the
client running post-review.
The base path should be None in this case. It's really only needed for
Subversion.
Can you show me the Repository entries you have configured in the
administration UI in Review Board?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
2009/12/14 JohnHenry qhlonl...@163.com
Hi,
The detailed error info is:
-
[jo...@dev2 test]$ post-review --debug --username=Johnl1 --
password=Johnl1 myTestCode.c
svn info
repository info: Path: cvs_gz:/export/home/cvsroot, Base path:
None,
Supports changesets: False
cvs diff -uN myTestCode.c
Looking for '192.168.3.20 /' cookie in
/data1/John1/.post-review-cookies.txt
Couldn't load cookie file: '/data1/John1/.post-review-cookies.txt'
does
not look like a Netscape format cookies file
== Review Board Login Required
Enter username and password for Review Board athttp://
192.168.3.20:8080/
Logging in with username John1
HTTP POSTing tohttp://192.168.3.20:8080/api/json/accounts/login/:
{'username': 'John1', 'password': '**'}
Logged in.
Attempting to create review request for None
HTTP POSTing tohttp://
192.168.3.20:8080/api/json/reviewrequests/new/:
{'repository_path': 'cvs_gz:/export/home/cvsroot'}
Error creating review request: The repository path specified is not in
the list of known repositories (code 206)
---
My question is : Why the Base path value of mine is None? does it
have relationship with my problem code 206? if it does, Then how to
set this Base path in Review Board?
I have not installed CVS or SVN, I am using an account on an exist CVS
server. Must I have to install a independent CVS for the ReviewBoard?
Best Regards!
On 12月14日, 下午5时53分, Christian Hammond chip...@chipx86.com wrote:
Hi,
The Path or Mirror Path for the Repository entry in the admin UI in
Review
Board must be exactly what post-review is trying to report. So, in
your
case, it should be cvs_gz/export/home/cvsoot. I'm hoping to add
fuzzy
matching in the future (so as to make it possible to use aliases for
domains, be more flexible with IP addresses and usernames, etc.), but
for
now it must be an exact match.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
Re: About the relationship between ReviewBoard Server and CVS
Oh, I see. Thank you very much！
Best Regards!
On 12月15日, 下午2时13分, Christian Hammond chip...@chipx86.com wrote:
Review Board is in Python, and doesn't actually need to be compiled.
However, to do any real development (with the expectation of contributing
back to the project) you'll need to have a copy of the source tree and
develop from there. There's some instructions at:
http://www.reviewboard.org/docs/codebase/dev/getting-started/
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
2009/12/14 JohnHenry qhlonl...@163.com
Hi, Christian,
Thanks for replay. I said rebuild because I am using the directly
installed ReviewBoard, I don't know it's compiling form souce process.
If I want to change some python source code of ReviewBoard, Then how
to compile the ReviewBoard again, and do I need to reinstall the
compile result again for use? Sorry for my bad English expression.
Best Regards!
On Dec 15, 1:50 pm, Christian Hammond chip...@chipx86.com wrote:
The getfqdn call essentially gets the fully-qualified domain (so,
foo.example.com instead of just foo, for instance)
read more
We recently added support for Perforce to check against all aliases,
including what's reported locally. We should add this for CVS as well.
I don't really know what you mean by rebuild method. Do you mean you want
to
know how to update a review request when you change the code you're
writing
for your project? If so, then you can use the -r parameter of
post-review.
For example, to update review request #42 with your latest code changes,
run:
post-review -r 42
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
2009/12/14 JohnHenry qhlonl...@163.com
Hi, Christian,
I have changed the source of Postreview.py, and now the post-
review can work fine. I found that in class CVSClient, the function
get_repository_info, It use socket.getfqdn(host) to replace the host
of repository_path; So I managed to keep the repository_path
unchanged. Though I don't quite catche what the socket.getfqdn(host)
mean, But keep the repository_path will finally works. Now I can use
post-review to generate reviewrequest. But if you can give me more
guidance about the reason, I will be much thanks. And I need your help
about ReviewBoard rebuild method, If I changed some source of
reviewboard, then how to rebuild this project to apply my change? I
think Reviewboard is a server application based on Django, There must
be some difference between it's rebuild and the change on post-review
code. Need your suggestion.
Best Regards!
Hi,...
read more
You will need cvs on the server, definitely. The 1.1 alpha series
won't
let
you create a CVS repository without having it. You'll also need it on
the
client running post-review.
The base path should be None in this case. It's really only needed
for
Subversion.
Can you show me the Repository entries you have configured in the
administration UI in Review Board?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
2009/12/14 JohnHenry qhlonl...@163.com
Hi,
The detailed error info is:
-
[jo...@dev2 test]$ post-review --debug --username=Johnl1 --
password=Johnl1 myTestCode.c
svn info
repository info: Path: cvs_gz:/export/home/cvsroot, Base path:
None,
Supports changesets: False
cvs diff -uN myTestCode.c
Looking for '192.168.3.20 /' cookie in
/data1/John1/.post-review-cookies.txt
Couldn't load cookie file:
'/data1/John1/.post-review-cookies.txt'
does
not look like a Netscape format cookies file
== Review Board Login Required
Enter username and password for Review Board athttp://
192.168.3.20:8080/
Logging in with username John1
HTTP POSTing tohttp://
192.168.3.20:8080/api/json/accounts/login/:
{'username': 'John1', 'password': '**'}
Logged in.
Attempting to create review request for None
HTTP POSTing tohttp://
192.168.3.20:8080/api/json/reviewrequests/new/:
{'repository_path': 'cvs_gz:/export/home/cvsroot'}
Error creating review request: The repository path specified is not
in
the list of known repositories (code 206)
---
My question is : Why the Base path value of mine is None? does
it
have relationship with my problem code 206? if it does, Then how
to
set this Base path in Review Board?
I have not
About Error occured when print view diff on User WebUI of ReviewBoard
Hi,
I have tried to post a review request and publish it using one
User, But in the Reviewers' UI, when He cilck the view diff link on
the top-right, There will be some error infomation:
**
The patch to 'mySouceTest.c' didn't apply cleanly. The temporary files
have been left in '/tmp/reviewboard.zX0n4M' for debugging purposes.
`patch` returned: patching file /tmp/reviewboard.zX0n4M/tmphNZpB0
patch: malformed patch at line 25: - exit(1);
Traceback (most recent call last):
File /data1/John1/bin/develop_tools/python/python2.5/lib/python2.5/
site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/
views.py, line 153, in view_diff
interdiffset, highlighting, True)
File /data1/John1/bin/develop_tools/python/python2.5/lib/python2.5/
site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/
diffutils.py, line 623, in get_diff_files
large_data=True)
File /data1/qiaohl/bin/develop_tools/python/python2.5/lib/python2.5/
site-packages/Djblets-0.5.6-py2.5.egg/djblets/util/misc.py, line 162,
in cache_memoize
data = lookup_callable()
File /data1/John1/bin/develop_tools/python/python2.5/lib/python2.5/
site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/
diffutils.py, line 622, in lambda
enable_syntax_highlighting),
File /data1/John1/bin/develop_tools/python/python2.5/lib/python2.5/
site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/
diffutils.py, line 345, in get_chunks
new = get_patched_file(old, filediff)
File /data1/John1l/bin/develop_tools/python/python2.5/lib/python2.5/
site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/
diffutils.py, line 261, in get_patched_file
return patch(filediff.diff, buffer, filediff.dest_file)
File /data1/John1/bin/develop_tools/python/python2.5/lib/python2.5/
site-packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/
diffutils.py, line 129, in patch
(filename, tempdir, patch_output))
Exception: The patch to 'myUCMobile.c' didn't apply cleanly. The
temporary files have been left in '/tmp/reviewboard.zX0n4M' for
debugging purposes.
`patch` returned: patching file /tmp/reviewboard.zX0n4M/tmphNZpB0
patch: malformed patch at line 25: - exit(1);
***
Need suggestion.
And, If I want to make a new reivewrequest with a new file that has
never been commited to CVS repository before ,The info would be as
follows:
--
Review request draft saved
Uploading diff, size: 50
HTTP POSTing to
http://192.168.3.20:8080/api/json/reviewrequests/9/diff/new/: {}
{fields: {path: [The diff file is empty]}, stat: fail, err:
{msg: One or more fields had errors, code: 105}}
Error uploading diff: One or more fields had errors (105)
{'fields': {'path': ['The diff file is empty']}, 'stat': 'fail', 'err':
{'msg': 'One or more fields had errors', 'code': 105}}
Your review request still exists, but the diff is not attached
In that case , Can the reviewer see the source code in the new file of
ReviewRequestor's any way?
Best Regards!
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
