Unable to login to RB Site as any user
Hi, I recently changed the IP Address of my Linux Box hosting the RB Site. Post to this, I am unable to login as any user. I tried to reset the password using : $ rb-site manage /path/to/site shell from django.contrib.auth.models import User u = User.objects.get(username=admin) u.set_password(the new password) u.save() But still cannot login. I am using : OS : Ubuntu 10.04 LTS - 32 bit Web Server : Apache/2.2.14 (Ubuntu) Database : MySQL - 5.1.41-3ubuntu12 Python : 2.6.5 RB : 1.5.2 Djblets : 0.6.7-py2.6 django.VERSION : (1, 2, 1, 'final', 0) I also have AD / LDAP Authentification enabled The /path/to/site/conf/settings_local.py is : # Database configuration DATABASE_ENGINE = 'mysql' DATABASE_NAME = 'reviewboard' DATABASE_USER = 'root' DATABASE_PASSWORD = 'xyzpcs' DATABASE_HOST = 'localhost' DATABASE_PORT = '' # The /etc/apache2/sites-enabled/rb_site.conf is == VirtualHost *:80 ServerName cr.mydomain.com DocumentRoot /path/to/site/htdocs # Error handlers ErrorDocument 500 /errordocs/500.html # Serve django pages Location / PythonPath ['/path/to/site/conf'] + sys.path SetEnv DJANGO_SETTINGS_MODULE reviewboard.settings SetEnv PYTHON_EGG_CACHE /path/to/site/tmp/egg_cache SetEnv HOME /path/to/site/data SetHandler mod_python PythonHandler django.core.handlers.modpython PythonAutoReload Off PythonDebug Off # Used to run multiple mod_python sites in the same apache PythonInterpreter reviewboard_cr_digi_com /Location # Serve static media without running it through mod_python # (overrides the above) Location /media SetHandler None /Location Location /errordocs SetHandler None /Location Directory /path/to/site/htdocs AllowOverride All /Directory # Alias static media requests to filesystem Alias /media /path/to/site/htdocs/media Alias /errordocs /path/to/site/htdocs/errordocs /VirtualHost == There are no errors in the Apache RB Site Logs Please help me resolve this -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
ReviewMate
I just noticed that ElementRiver has an eclipse based plugin for code reviews. It could be nice to start reviews right in the IDE but ReviewBoard has a lot of essential features too. An integration would be interesting... http://support.elementriver.com/discussions/reviewmate/2-reviewboard-integration -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Feedback for Screen Shot Captions
Done. http://code.google.com/p/reviewboard/issues/detail?id=1966 On Jan 28, 8:12 pm, Christian Hammond chip...@chipx86.com wrote: I agree. Would you mind filing a bug on that? Christian On Friday, January 28, 2011, Daniel da.s...@gmail.com wrote: When I upload multiple screenshots using the drag and drop feature, it'd be really nice if the caption would default to the filename instead of 'no name'. Thanks! -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Problems with multi-page reviews
Hi, First of all, thanks for a great review tool. We have been using ReviewBoard for over a year now and it has become an invaluable tool for us. We recently got a new server and I took the opportunity to update our ReviewBoard installation to 1.5.2 (from a really ancient 1.0alpha version) On the new server, reviewboard is integrated with Apache and is much faster than the old version. However, I am having a problem with reviews with a large number of files so reviewboard splits the diffs accross multiple pages. Just viewing the diffs on each of the pages is fine, but if I add some review comments, so that there is an unpublished review and then try changing to a different page ReviewBoard seems to hang and top shows httpd at 100% CPU on the server. Trying another operation in this state causes a 500 error from the server, in the logs when that happens it shows that the database is locked (trace below). Restarting Apache seems to be the only way to clear the problem. If I publish the review before changing pages then there is no problem. The problem only seems to occur if I try to change pages with an unpublished review open. Has anyone else seen this problem or have any suggestions? Reviewboard is installed on Linux (using easy_install) with python 2.4 and using an sqlite database. Traceback from the logs when accessing reviewboard while waiting for the diff pages to change: Traceback (most recent call last): File /usr/lib/python2.4/site-packages/Django-1.2.4-py2.4.egg/django/core/handlers/base.py, line 100, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/lib/python2.4/site-packages/Django-1.2.4-py2.4.egg/django/views/decorators/cache.py, line 78, in _wrapped_view_func response = view_func(request, *args, **kwargs) File /usr/lib/python2.4/site-packages/ReviewBoard-1.5.2-py2.4.egg/reviewboard/webapi/decorators.py, line 61, in _view response = view_func(*args, **kwargs) File /usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/djblets/webapi/decorators.py, line 88, in _checklogin return view_func(*args, **kwargs) File /usr/lib/python2.4/site-packages/Django-1.2.4-py2.4.egg/django/views/decorators/http.py, line 37, in inner return func(request, *args, **kwargs) File /usr/lib/python2.4/site-packages/ReviewBoard-1.5.2-py2.4.egg/reviewboard/webapi/json.py, line 931, in review_draft_save review.publish(user=request.user) File /usr/lib/python2.4/site-packages/ReviewBoard-1.5.2-py2.4.egg/reviewboard/reviews/models.py, line 1145, in publish self.save() File /usr/lib/python2.4/site-packages/ReviewBoard-1.5.2-py2.4.egg/reviewboard/reviews/models.py, line 1132, in save super(Review, self).save() File /usr/lib/python2.4/site-packages/Django-1.2.4-py2.4.egg/django/db/models/base.py, line 456, in save self.save_base(using=using, force_insert=force_insert, force_update=force_update) File /usr/lib/python2.4/site-packages/Django-1.2.4-py2.4.egg/django/db/models/base.py, line 556, in save_base transaction.commit_unless_managed(using=using) File /usr/lib/python2.4/site-packages/Django-1.2.4-py2.4.egg/django/db/transaction.py, line 175, in commit_unless_managed connection._commit() File /usr/lib/python2.4/site-packages/Django-1.2.4-py2.4.egg/django/db/backends/__init__.py, line 32, in _commit return self.connection.commit() OperationalError: database is locked -- David Dibben -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Unable to login to RB Site as any user
Authentication will be going through your AD server. Sounds like some configuration or communication problem there? You should be able to log in as the original admin user. If so, turn on logging (assuming it's off) and see if it says there are issues talking to your AD server. Christian On Monday, January 31, 2011, Prashant mas...@gmail.com wrote: Hi, I recently changed the IP Address of my Linux Box hosting the RB Site. Post to this, I am unable to login as any user. I tried to reset the password using : $ rb-site manage /path/to/site shell from django.contrib.auth.models import User u = User.objects.get(username=admin) u.set_password(the new password) u.save() But still cannot login. I am using : OS : Ubuntu 10.04 LTS - 32 bit Web Server : Apache/2.2.14 (Ubuntu) Database : MySQL - 5.1.41-3ubuntu12 Python : 2.6.5 RB : 1.5.2 Djblets : 0.6.7-py2.6 django.VERSION : (1, 2, 1, 'final', 0) I also have AD / LDAP Authentification enabled The /path/to/site/conf/settings_local.py is : # Database configuration DATABASE_ENGINE = 'mysql' DATABASE_NAME = 'reviewboard' DATABASE_USER = 'root' DATABASE_PASSWORD = 'xyzpcs' DATABASE_HOST = 'localhost' DATABASE_PORT = '' # The /etc/apache2/sites-enabled/rb_site.conf is == VirtualHost *:80 ServerName cr.mydomain.com DocumentRoot /path/to/site/htdocs # Error handlers ErrorDocument 500 /errordocs/500.html # Serve django pages Location / PythonPath ['/path/to/site/conf'] + sys.path SetEnv DJANGO_SETTINGS_MODULE reviewboard.settings SetEnv PYTHON_EGG_CACHE /path/to/site/tmp/egg_cache SetEnv HOME /path/to/site/data SetHandler mod_python PythonHandler django.core.handlers.modpython PythonAutoReload Off PythonDebug Off # Used to run multiple mod_python sites in the same apache PythonInterpreter reviewboard_cr_digi_com /Location # Serve static media without running it through mod_python # (overrides the above) Location /media SetHandler None /Location Location /errordocs SetHandler None /Location Directory /path/to/site/htdocs AllowOverride All /Directory # Alias static media requests to filesystem Alias /media /path/to/site/htdocs/media Alias /errordocs /path/to/site/htdocs/errordocs /VirtualHost == There are no errors in the Apache RB Site Logs Please help me resolve this -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Problems with multi-page reviews
Hi David. Well that doesn't sound so good. Can't say I've seen that, but will see if I can repro it. What database are you using? Can you turn on logging and see what the last entries are when this happens? Christian On Monday, January 31, 2011, David Dibben dib...@ieee.org wrote: Hi, First of all, thanks for a great review tool. We have been using ReviewBoard for over a year now and it has become an invaluable tool for us. We recently got a new server and I took the opportunity to update our ReviewBoard installation to 1.5.2 (from a really ancient 1.0alpha version) On the new server, reviewboard is integrated with Apache and is much faster than the old version. However, I am having a problem with reviews with a large number of files so reviewboard splits the diffs accross multiple pages. Just viewing the diffs on each of the pages is fine, but if I add some review comments, so that there is an unpublished review and then try changing to a different page ReviewBoard seems to hang and top shows httpd at 100% CPU on the server. Trying another operation in this state causes a 500 error from the server, in the logs when that happens it shows that the database is locked (trace below). Restarting Apache seems to be the only way to clear the problem. If I publish the review before changing pages then there is no problem. The problem only seems to occur if I try to change pages with an unpublished review open. Has anyone else seen this problem or have any suggestions? Reviewboard is installed on Linux (using easy_install) with python 2.4 and using an sqlite database. Traceback from the logs when accessing reviewboard while waiting for the diff pages to change: Traceback (most recent call last): File /usr/lib/python2.4/site-packages/Django-1.2.4-py2.4.egg/django/core/handlers/base.py, line 100, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/lib/python2.4/site-packages/Django-1.2.4-py2.4.egg/django/views/decorators/cache.py, line 78, in _wrapped_view_func response = view_func(request, *args, **kwargs) File /usr/lib/python2.4/site-packages/ReviewBoard-1.5.2-py2.4.egg/reviewboard/webapi/decorators.py, line 61, in _view response = view_func(*args, **kwargs) File /usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/djblets/webapi/decorators.py, line 88, in _checklogin return view_func(*args, **kwargs) File /usr/lib/python2.4/site-packages/Django-1.2.4-py2.4.egg/django/views/decorators/http.py, line 37, in inner return func(request, *args, **kwargs) File /usr/lib/python2.4/site-packages/ReviewBoard-1.5.2-py2.4.egg/reviewboard/webapi/json.py, line 931, in review_draft_save review.publish(user=request.user) File /usr/lib/python2.4/site-packages/ReviewBoard-1.5.2-py2.4.egg/reviewboard/reviews/models.py, line 1145, in publish self.save() File /usr/lib/python2.4/site-packages/ReviewBoard-1.5.2-py2.4.egg/reviewboard/reviews/models.py, line 1132, in save super(Review, self).save() File /usr/lib/python2.4/site-packages/Django-1.2.4-py2.4.egg/django/db/models/base.py, line 456, in save self.save_base(using=using, force_insert=force_insert, force_update=force_update) File /usr/lib/python2.4/site-packages/Django-1.2.4-py2.4.egg/django/db/models/base.py, line 556, in save_base transaction.commit_unless_managed(using=using) File /usr/lib/python2.4/site-packages/Django-1.2.4-py2.4.egg/django/db/transaction.py, line 175, in commit_unless_managed connection._commit() File /usr/lib/python2.4/site-packages/Django-1.2.4-py2.4.egg/django/db/backends/__init__.py, line 32, in _commit return self.connection.commit() OperationalError: database is locked -- David Dibben -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ReviewMate
Hi Daniel, We actually had an Eclipse plugin a while back, but there was nobody to continue maintaining it so it fell apart (and definitely won't work in RB 1.6). ReviewMate seems interesting. I need to look at that more. Can't tell if it's a competitor or a possible integration point, but it might be worth us talking to them. Though -- this sounds like bragging but it's not intended to -- all of our competitors out there are well aware of us. I'm surprised ReviewMate isn't. Maybe they're just really new and working in isolation. Christian On Monday, January 31, 2011, Daniel da.s...@gmail.com wrote: I just noticed that ElementRiver has an eclipse based plugin for code reviews. It could be nice to start reviews right in the IDE but ReviewBoard has a lot of essential features too. An integration would be interesting... http://support.elementriver.com/discussions/reviewmate/2-reviewboard-integration -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
post-review failing
hi, I am new to setting up reviewboard. I am using SVN, mySql, and I
am able to submit review request manually by creating the diff file
and attaching it to the review request.
I am trying to use post-review with pre-committed code in order to
automate the creation of the diff file.
I been trying a few settings to no avail.
I've attached the debug log to see if something may make sense to you.
my svn path is http://subversion.corp.respond.com/svn/inter/trunk
and my repository on ReviewBoard is http://subversion.corp.respond.com/svn/inter
it would also help if you could tell me from what dir i need to run
post-review..
thank you
RBTools 0.3
Home = C:\Users\pflores\AppData\Roaming
svn info
diff --version
repository info: Path: http://subversion.corp.respond.com/svn, Base path:
/inter/trunk/ui, Supports change
sets: False
svn propget reviewboard:url C:\Users\pflores\workspace\ui
svn diff --diff-cmd=diff
svn info resources/services/thisserver/popHtmlMenu.inc
HTTP GETting http://corpxdeskavyas.us.respond.com:8082/reviewboard/api/info/
Using the new web API
HTTP GETting
http://corpxdeskavyas.us.respond.com:8082/reviewboard/api/repositories/
HTTP GETting
http://corpxdeskavyas.us.respond.com:8082/reviewboard/api/repositories/1/
HTTP GETting
http://corpxdeskavyas.us.respond.com:8082/reviewboard/api/repositories/1/info/
repository info: Path: http://subversion.corp.respond.com/svn/inter, Base
path: /trunk/ui, Supports changeset
Attempting to create review request on
http://subversion.corp.respond.com/svn/inter for None
HTTP POSTing to
http://corpxdeskavyas.us.respond.com:8082/reviewboard/api/review-requests/:
{'repository': u'htt
respond.com/svn/inter'}
Review request created
Uploading diff, size: 92394
HTTP POSTing to
http://corpxdeskavyas.us.respond.com:8082/reviewboard/api/review-requests/22/diffs/:
{'basedir':
Got API Error 207 (HTTP code 400): The file was not found in the repository
Error data: {u'stat': u'fail', u'file':
u'/inter/trunk/ui/resources/services/thisserver/popHtmlMenu.inc', u'err
le was not found in the repository', u'code': 207}, u'revision':
u'128233'}
Error uploading diff
Your review request still exists, but the diff is not attached.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: post-review failing
Hi,
This looks to be a configuration issue.
I assume the root of the SVN repository is /svn, and inter is a directory
within that, am I correct?
Review Board's repository configuration needs to point to the very root of
the SVN repository, rather than a directory within it. What's happening is
that it thinks /svn/inter is the root, but post-review knows that inter
is a directory within it. So, post-review is building the full path
/inter/trunk/... and Review Board is looking for that path in
/svn/inter, causing a lookup of inter/inter/trunk/
So if you change Review Board to use /svn instead, it should work.
Let me know if that works!
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Mon, Jan 31, 2011 at 4:48 PM, pabloa pablo.flo...@gmail.com wrote:
hi, I am new to setting up reviewboard. I am using SVN, mySql, and I
am able to submit review request manually by creating the diff file
and attaching it to the review request.
I am trying to use post-review with pre-committed code in order to
automate the creation of the diff file.
I been trying a few settings to no avail.
I've attached the debug log to see if something may make sense to you.
my svn path is http://subversion.corp.respond.com/svn/inter/trunk
and my repository on ReviewBoard is
http://subversion.corp.respond.com/svn/inter
it would also help if you could tell me from what dir i need to run
post-review..
thank you
RBTools 0.3
Home = C:\Users\pflores\AppData\Roaming
svn info
diff --version
repository info: Path: http://subversion.corp.respond.com/svn, Base
path: /inter/trunk/ui, Supports change
sets: False
svn propget reviewboard:url C:\Users\pflores\workspace\ui
svn diff --diff-cmd=diff
svn info resources/services/thisserver/popHtmlMenu.inc
HTTP GETting
http://corpxdeskavyas.us.respond.com:8082/reviewboard/api/info/
Using the new web API
HTTP GETting
http://corpxdeskavyas.us.respond.com:8082/reviewboard/api/repositories/
HTTP GETting
http://corpxdeskavyas.us.respond.com:8082/reviewboard/api/repositories/1/
HTTP GETting
http://corpxdeskavyas.us.respond.com:8082/reviewboard/api/repositories/1/info/
repository info: Path: http://subversion.corp.respond.com/svn/inter,
Base path: /trunk/ui, Supports changeset
Attempting to create review request on
http://subversion.corp.respond.com/svn/inter for None
HTTP POSTing to
http://corpxdeskavyas.us.respond.com:8082/reviewboard/api/review-requests/:
{'repository': u'htt
respond.com/svn/inter'}
Review request created
Uploading diff, size: 92394
HTTP POSTing to
http://corpxdeskavyas.us.respond.com:8082/reviewboard/api/review-requests/22/diffs/:
{'basedir':
Got API Error 207 (HTTP code 400): The file was not found in the
repository
Error data: {u'stat': u'fail', u'file':
u'/inter/trunk/ui/resources/services/thisserver/popHtmlMenu.inc', u'err
le was not found in the repository', u'code': 207}, u'revision':
u'128233'}
Error uploading diff
Your review request still exists, but the diff is not attached.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Cannot add repository with cvs ext in 1.5.2 on RHEL5
Hi Christian, I think i know what the issue is. The CVS server does not accept ssh connection without the command option. It does not allow to login into the shell. The way to get the CVS data would be to invoke the SSH connection along with the cvs command. From the code, i see that you login into the server and then execute the command. Any way we can workaround this issue? I am sure I cannot get the CVS server to allow login into shell. Thanks for the help Praveen -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Cannot add repository with cvs ext in 1.5.2 on RHEL5
Work will need to be done to implement this in rbssh. I'll work a bit on it and, if I can get that and another rbssh bug fixed in the next few days, I'll get a release out. Sorry for the delay. This is a new piece of code needed to work around some other large problems, but I know it's blocking you. An alternative would be to go back to 1.5.1 for now until we have this working (but it will also mean you can't use an uploaded SSH key, due to limitations in OpenSSH). Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Jan 31, 2011 at 9:05 PM, praveen kumar kodaliprav...@gmail.comwrote: Hi Christian, I think i know what the issue is. The CVS server does not accept ssh connection without the command option. It does not allow to login into the shell. The way to get the CVS data would be to invoke the SSH connection along with the cvs command. From the code, i see that you login into the server and then execute the command. Any way we can workaround this issue? I am sure I cannot get the CVS server to allow login into shell. Thanks for the help Praveen -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Issue 1961 in reviewboard: Git SSH repository: Cannot spawn rbssh
Comment #8 on issue 1961 by anthony@gmail.com: Git SSH repository: Cannot spawn rbssh http://code.google.com/p/reviewboard/issues/detail?id=1961 I tried uploading a key but RB is trying to load the key from the home directory still. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1961 in reviewboard: Git SSH repository: Cannot spawn rbssh
Comment #9 on issue 1961 by anthony@gmail.com: Git SSH repository: Cannot spawn rbssh http://code.google.com/p/reviewboard/issues/detail?id=1961 Ahh.. generate_user_key in sshutils.py just returns the found key in the home directory even if a key is uploaded. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1967 in reviewboard: post-review 0.3 unexpected diff behaviour and git repository fatal error
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1967 by shaheen@quanteragroup.com: post-review 0.3 unexpected
diff behaviour and git repository fatal error
http://code.google.com/p/reviewboard/issues/detail?id=1967
*NOTE: Do not post confidential information in this bug report.*
What version are you running?
Review Board 1.5.2 on the server
RBTools 0.3 on the Windows Client
What's the URL of the page containing the problem?
http://private-domain/api/review-requests/x/diffs (where x is a number)
What steps will reproduce the problem?
Environment
-Python, Setuptools were installed.
-Used easy_install to install RBTools.
-I'm using msysgit Git with unix tools installed.
-I set the reviewboard.url configuration key in Git.
-I also created a .reviewboardrc file under 'Home' in
C:\Users\username\AppData\Roaming with the same value for the
REVIEWBOARD_URL parameter.
-I read in the release notes that RBTools 0.3 uses the Git diff, so I did
not install GNU's DiffUtils.
1. I'm using Git, and I had not yet pulled down the latest code from
master, but had made my own changes since the last pull.
2. I invoked post-review and was greeted with the There don't seem to be
any diffs! message.
3. I re-ran post-review several more times, including with the debug
option, but I didn't see anything that stood out.
4. I executed git diff which correctly output the changes I had made since
my last pull.
5. I decided to pull from master and re-ran post-review. Surprisingly,
post-review got further along, but not all the way. The debug option
revealed that it created a review request but when uploading diff of size
9680, an error occured;
GOT API Error 105 (HTTP code 400): One or more fields had errors
Error data: {u'fields': {u'path': [ufatal: Not a git
repository 'None'\n]}, u'stat': u'fail', u'err' : u'One or more fields
had errors', u'code': 105}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with -output-diff and --debug for more information.
Your review request still exists, but the diff is not attached.
6. When I invoke the diff command (git diff --no-color --full-index
--no-ext-diff 3b1d3ee1c56b62fc01be53d6f74e11fb1b2fd0e4..refs/heads/master)
as reported by post-review with the debug option, I get a different output
than I expect. I get the diff between the latest two pushed commits. None
of my local changes are shown in the diff.
7. As a last effort, I ran git diff my_diff_file and used that file as a
parameter to --diff-filename=my_diff_file. I can tell a different diff than
in 5 was posted to the server because the size was reported to be 845.
However, I received the same error.
What is the expected output? What do you see instead?
So, there are a few things to point out here.
-Not a git repository in the error is alarming. Is it referring to
incorrect configuration of the Git repository on the server side? I am
unfamiliar with the flow of events. If post-review is generating a diff on
the client-side, what is the Review Board server attempting to do with Git
repository.
-How come the git diff command run by post-review is not diff'ing MY local
changes...
What operating system are you using? What browser?
Windows 7
Firefox
Please provide any additional information below.
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1967 in reviewboard: post-review 0.3 unexpected diff behaviour and git repository fatal error
Comment #1 on issue 1967 by shaheen@quanteragroup.com: post-review 0.3 unexpected diff behaviour and git repository fatal error http://code.google.com/p/reviewboard/issues/detail?id=1967 In the Review Board administration portal, I have a repository with the following fields filled out; -name -show this repository -hosting service: Custom -repo type: Git -path: git@remotehost:username/project/repo.git and that's it. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1961 in reviewboard: Git SSH repository: Cannot spawn rbssh
Comment #11 on issue 1961 by anthony@gmail.com: Git SSH repository: Cannot spawn rbssh http://code.google.com/p/reviewboard/issues/detail?id=1961 After I hit save to save the ssh git repository, the SSH session just seems to die for some reason and then RB times out. Here's the RB log. 2011-01-31 15:35:03,733 - DEBUG - GitTool: Attempting ssh connection with host: xxx..com, username: joeuser 2011-01-31 15:35:03,733 - DEBUG - starting thread (client mode): 0x5caf250L 2011-01-31 15:35:03,795 - INFO - Connected (version 2.0, client OpenSSH_5.2) 2011-01-31 15:35:03,826 - DEBUG - kex algos:['diffie-hellman-group-exchange-sha256', 'diffie-hellman-group-exchange-sha1', 'diffie-hellman-group14-sha1', 'diffie-hellman-group1-sha1'] server key:['ssh-rsa', 'ssh-dss'] client encrypt:['aes128-ctr', 'aes192-ctr', 'aes256-ctr', 'arcfour256', 'arcfour128', 'aes128-cbc', '3des-cbc', 'blowfish-cbc', 'cast128-cbc', 'aes192-cbc', 'aes256-cbc', 'arcfour', 'rijndael-...@lysator.liu.se'] server encrypt:['aes128-ctr', 'aes192-ctr', 'aes256-ctr', 'arcfour256', 'arcfour128', 'aes128-cbc', '3des-cbc', 'blowfish-cbc', 'cast128-cbc', 'aes192-cbc', 'aes256-cbc', 'arcfour', 'rijndael-...@lysator.liu.se'] client mac:['hmac-md5', 'hmac-sha1', 'umac...@openssh.com', 'hmac-ripemd160', 'hmac-ripemd...@openssh.com', 'hmac-sha1-96', 'hmac-md5-96'] server mac:['hmac-md5', 'hmac-sha1', 'umac...@openssh.com', 'hmac-ripemd160', 'hmac-ripemd...@openssh.com', 'hmac-sha1-96', 'hmac-md5-96'] client compress:['none', 'z...@openssh.com'] server compress:['none', 'z...@openssh.com'] client lang:[''] server lang:[''] kex follows?False 2011-01-31 15:35:03,826 - DEBUG - Ciphers agreed: local=aes128-ctr, remote=aes128-ctr 2011-01-31 15:35:03,826 - DEBUG - using kex diffie-hellman-group1-sha1; server key type ssh-rsa; cipher: local aes128-ctr, remote aes128-ctr; mac: local hmac-sha1, remote hmac-sha1; compression: local none, remote none 2011-01-31 15:35:03,999 - DEBUG - Switch to new keys ... 2011-01-31 15:35:03,999 - DEBUG - Trying discovered key 2f58fb0653805cffea0cdec82455c096 in D:\ReviewBoard\data/.ssh/id_rsa 2011-01-31 15:35:04,029 - DEBUG - userauth is OK 2011-01-31 15:35:04,686 - INFO - Authentication (publickey) successful! 2011-01-31 15:35:04,795 - DEBUG - EOF in transport thread -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1963 in reviewboard: HTTP 500 when posting/updating review request via post-review
Comment #5 on issue 1963 by chip...@gmail.com: HTTP 500 when posting/updating review request via post-review http://code.google.com/p/reviewboard/issues/detail?id=1963 We should handle it gracefully. As for debugging the server connection, it appears to be entirely an issue on your end, so there's not much I can do to debug it. It's absolutely not standard behavior. Many people use SVN and this call happens all the time, but this is the first bug report I've seen on this. Try doing a 'svn info' on the repository from a terminal on the server repeatedly. See where it fails. Also try turning on logging on Review Board and see what's in the log file when it happens. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1965 in reviewboard: Installed ReviewBoard on CentOS 5.5, rebooted CentOS, ReviewBoard now fails.
Updates: Status: NeedInfo Comment #1 on issue 1965 by chip...@gmail.com: Installed ReviewBoard on CentOS 5.5, rebooted CentOS, ReviewBoard now fails. http://code.google.com/p/reviewboard/issues/detail?id=1965 At first glance, it looks like you may have an e-mail address on some user in that target list which isn't a valid e-mail address (no @ or the field itself is blank). Might want to go through those users and make sure those are correct. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1965 in reviewboard: Installed ReviewBoard on CentOS 5.5, rebooted CentOS, ReviewBoard now fails.
Comment #2 on issue 1965 by kusem...@gmail.com: Installed ReviewBoard on CentOS 5.5, rebooted CentOS, ReviewBoard now fails. http://code.google.com/p/reviewboard/issues/detail?id=1965 Actually, these errors are what shows up when mysql server isn't running - uhm, what? well, anyway, started the mysql server and all errors are gone and the app is working (happened 5 minutes ago.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1965 in reviewboard: Installed ReviewBoard on CentOS 5.5, rebooted CentOS, ReviewBoard now fails.
Updates: Status: SetupIssue Comment #3 on issue 1965 by chip...@gmail.com: Installed ReviewBoard on CentOS 5.5, rebooted CentOS, ReviewBoard now fails. http://code.google.com/p/reviewboard/issues/detail?id=1965 Hah, well that is weird. Maybe Django's e-mail code ended up getting passed some error message from trying to access the database. Who knows. Guess I'll close this out :) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1961 in reviewboard: Git SSH repository: Cannot spawn rbssh
Comment #12 on issue 1961 by chip...@gmail.com: Git SSH repository: Cannot spawn rbssh http://code.google.com/p/reviewboard/issues/detail?id=1961 For the key, it specifically looks for id_dsa or id_rsa. It sounds like maybe it was still either looking in the wrong location, or you manually copied a file there? Anyway, the SSH session isn't supposed to be up for too long, as it just runs a small command to get some info, but it seems this is failing. It's probably something specific to the Windows implementation of rbssh, as getting this right on Windows is far, far more tricky than on Linux/Mac, unfortunately. I have no immediate answer. Until I get a chance to debug this on a Windows system and see if I can reproduce it, the only thing I can suggest is to modify rbssh to do some debugging (you can set DEBUG to True in there and add additional logging with debug(sometihng)), or, ideally, move your server to Linux. Review Board works far better in many ways on Linux than it does on Windows, due to the many dependencies we use being primarily tested on Linux. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1967 in reviewboard: post-review 0.3 unexpected diff behaviour and git repository fatal error
Comment #3 on issue 1967 by shaheen@quanteragroup.com: post-review 0.3 unexpected diff behaviour and git repository fatal error http://code.google.com/p/reviewboard/issues/detail?id=1967 Thank you for your reply. I realize the oversight now with regards to only providing a path and not a mirror (and need a local clone of the repository). Does Review Board keep the local clone in sync with the master, or do I need to manually/automate pull downs? I tried the diff when my changes were in the 'working copy' or uncommitted. But I also tried the diff after a commit (but not a push) as I understood Review Board was conceived with intent of using it pre-commit, and I had the same problem. I will create a blog post with regards to the points you mentioned and some other helpful hints I compiled along the way. I found it difficult to find resources on using post-review in comparison to other SE tools I have had to setup in the past. Your help is definitely appreciated. I read that you managed to work on this FT at some point, is that still the case? After making the configuration changes on the server-side, I was able to submit a review of uncommited changes by providing a diff file (which I produced using git diff --no-color --full-index --no-ext-diff). I'm not currently utilizing any branching techniques, I simply modify my clone of master, so I'm wondering if that has anything to do with my remaining issue ; not being able to post a review request without manually overriding the diff created by post-review. For example, with SVN, you can simply run post-review and all uncommitted files in the tree are incorporated in the diff. Forgive me I'm missing the obvious, I'm new to Git. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1967 in reviewboard: post-review 0.3 unexpected diff behaviour and git repository fatal error
Updates: Status: SetupIssue Owner: chipx86 Labels: -Type-Defect Type-Support Comment #4 on issue 1967 by chip...@gmail.com: post-review 0.3 unexpected diff behaviour and git repository fatal error http://code.google.com/p/reviewboard/issues/detail?id=1967 Review Board doesn't manage your clone at all. What some people do is have a post-commit hook somewhere in the upstream repository that triggers an update on the Review Board server, or have the RB server mount the other clone remotely. We tend to point people toward the cgit/gitweb/etc method, as that's more reliable, and has the added benefit of having a repository browser set up, which can be useful. Review Board was designed for pre-commit, but, more specifically, pre-commit on repositories like Subversion and Perforce. It's a bit different with Git. Really, it's more changes that aren't on the upstream repository rather than changes not committed somewhere. When using Git, what we do is commit the change to a branch, and then run post-review. It will post the commits between the remote and HEAD. (If you pass --guess-summary and --guess-description, it will also provide some defaults for your review request). However, if your change is on master 9or some other branch tracking a remote branch), it will fail, because it's trying to go up the chain until it finds something on a branch tracking a remote. In the case of commits on master, it will find master itself, decide there's nothing to diff, and fail. Generally, it's advisable for Git not to commit to master unless you intend for that to be pushed immediately. Changes not immediately being pushed upstream should nearly always start on a topic branch. If there are specific things you'd like our docs to cover, let me know. You can file a bug calling out those areas. I'll try to get to it the next time I'm working on the docs. I'm assuming FT means full time? I've never been full-time on this. All the Review Board work I do is completely in spare time, outside of my day job. Despite misconceptions, Review Board was never a VMware product, and I never worked on it as part of my day job. We do try to get as much done as possible, though. I certainly do spend a good number of hours per day on it. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
