Re: post-review error Unable to parse diff header:
Hi,
I just got the same error after upgrading post-review. What I found out is
that the subprocess.stdout that is read for the diff command contains a
newline (\n) right after the second filename in the diff header. Kind of
weird...
No fix or explanation found yet.
Regards,
Florian
2008/10/16 Joshua Slominski [EMAIL PROTECTED]
Can you post the debug output?
Sent from my iPhone
On Oct 15, 2008, at 6:00 PM, AndyP [EMAIL PROTECTED] wrote:
Well I have a .reviewboardrc with valid stuff in it. I modified (just
now) the script too with the same data but it didn't work.
I really suspect that that the 'execute' command isn't working right.
Note that it gets past that if I change those Popen calls from 'True'
back to 'False'.
If they are 'False' it can't find the repository, and if it is 'True'
it can't execute the diff (per the original posts in this thread).
Thanks,
On Oct 15, 2:01 pm, Joshua Slominski [EMAIL PROTECTED] wrote:
I seen that error when i forgot to put in my review board URL in
post-review. Also be sure that post-review is using the correct
SCM tool.
It defaults to SVN if it can't find anything else.
On Wed, Oct 15, 2008 at 4:48 PM, AndyP [EMAIL PROTECTED] wrote:
That didn't work for me out of the box. The two Popen() statements
are different than the version that I had (v0.7 that worked), but
when
I changed it to True I got a different error:
The current directory does not contain a checkout from a supported
source code repository.
Looking at this further, it appears that the only real difference is
the way the execute command is created:
v0.7
data = execute('p4 info', ignore_errors=True)
v0.8
data = execute([p4, info], ignore_errors=True)
On Oct 15, 12:45 pm, Joshua Slominski [EMAIL PROTECTED]
wrote:- Hide quoted text -
- Show quoted text -
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Review Board with Git work flow
Hi, I use git internally and want to use RB to review code changes before submitting to our repo. We have a central repository which holds the main code. Developers pull from this repo and work with their local checkouts. After hacking their internal repos, when the code is in a consistent shape, they push to the repo. Ideally our work flow should be 1. Developers pull from main repo 2. Developers hack, make multiple commits in local repo 3. Developers push code 4. Push uploads the patches to RB. 5. Reviewers review the diff and suggest changes etc code goes back and forth between dev and RB 6. Reviewers approve the code 7. RB pushes the code to main repo, with proper commit messages etc Is such a work flow possible in RB? If not approximations would also be most welcome. raj --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Problem setting Syntax Highlighting option
Syntax highlighting should be on by default once you turn it on system-wide. If not, we need to figure out a fix. Are you using mod_python? What happens if you set it and then restart the server? Does it stick? Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Wed, Oct 15, 2008 at 7:02 AM, fts1050 [EMAIL PROTECTED] wrote: I installed the Pygments library, as a result, I was able to turn on syntax highlighting in gthe admin interface. When I hit save the notification said my setting was changed successfully, but the setting now appears unset again after the save occurred. I repeated this and no change. I am not sure if this is simply UI issue or if something is really silently failing in this step. I did turn on syntax highlighting on my profile, and even after log in and log out, the syntax highlighting did not work (according to Pygments, we are using languages that are supported for syntax highlighting). No syntax highlighting has occured. So my first question is, where can I start looking to troubleshoot? My next question is, is there anyway to set, by default, the syntax highlighting to on for each profile (instead of off by default?) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
changing django settings with djblets.siteconfig
Hi, I've got a question about how djblets.siteconfig handles changes in the settings.py and settings_local.py files. After upgrading to r1537 (and introducing djblets.siteconfig), as I understand, a SiteConfiguration object has been created (and stored in the db) that reflects the existing state of settings.py and setting_local.py. If I later make changes to settings_local.py (for example, changing the cache backend), it's not reflected in the SiteConfiguration object, and ReviewBoard never sees this change. There also doesn't seem to be an easy way to update this field (the settings admin interface doesn't include it). This shouldn't be this cumbersome. I get a feeling that I missed something... Thanks, Eyal --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
email notifications - questions and possible issue
I was wondering what all the events that cause an email trigger. My guess would be: 1.)When a review goes live (to everyone who is on the review) 2.)When a review gets closed (set submitted) 3.)Anytime a review is published by any of the reviewers 4.)When a diff is updated 5.)More:? (Can you confirm all of the events that trigger an email,if possible?) I haven't had a chance to test all of these, but the one I have been working with the most is #3, and I have seen this work, but at times I don't get any emails.. I can't seem to figure out why. Any thoughts? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Getting error after adding Repository as Subversion and clicking New Review Request button.
Getting error ImportError at /r/new/ pysvn was built against newer (svn, apr, etc.) libraries then the ones installed on this system. / usr/lib/python2.5/site-packages/pysvn/_pysvn_2_5.so: undefined symbol: _ZN2Py19PythonExtensionBase12rich_compareERKNS_6ObjectEi after adding Repository. Pl help me . --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Important: Who's running directly out of an SVN checkout?
We'll look into a solution for this. We know we need to be able to give users an alternate directory for media installation, so that you can have multiple instances with their own uploaded directories. This will at leas take that part out of the egg directory. I'm trying to figure out the best way of doing this, but it'll probably involve a script that does much of the installation for you and then sets up a directory hierarchy with the media directory inside it, with symlinks pointing to the installed copy of Review Board. But of course we'll need to solve the issue of the ReviewBoard egg directory first. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Thu, Oct 16, 2008 at 12:52 AM, Terry Zhong [EMAIL PROTECTED] wrote: The problem is we're trying to use latest SVN checkouts and keep updating it. I'm using my own install scripts, just wraps a direct SVN checkout. I tried eggs, but it installs RB to somewhere like [/usr/lib/python2.5/site-packages/ReviewBoard-0.9.dev_r1537-py2.5.egg/ reviewboard] This path changes everytime I upgrade to latest SVN revision, can caused great problem for Apache config file, like [Alias /reviewboard/media /usr/lib/python2.5/site-packages/reviewboard/ htdocs/media] Same problem happens to Djblets. When I install Django as egg, it just installs into: [/usr/lib/python2.5/site-packages/django] Much easier for path finding. If I have to soft link media path by hand, why not use a script and do a svn export, which can work automatically. Christian Hammond wrote: Hi everyone. We need to know who is still running Review Board directly out of a SVN checkout, rather than through an installed copy (by way of make install). We're trying to transition away from Makefiles for installation and toward Python eggs. However, this requires a few changes in our SVN tree: 1) Most everything currently in the top-level reviewboard directory will move into a subdirectory. This means directories such as reviews, scmtools, etc. Directories such as contrib will stay where they are. This will break any python paths you have set up if you're running out of a SVN checkout. 2) We'll no longer include Djblets or Django-Evolution directly in the SVN tree. These should be installed as separate packages. We'll make this easy to do. 3) All Makefiles will be removed in favor of setup.py. Python eggs will make installation far easier. Once we've transitioned over fully, installing or upgrading Review Board will only require running easy_install ReviewBoard on the command line, or running sudo setup.py install in an SVN checkout. The Django, Djblets and Django-Evolution dependencies will be fetched and installed automatically for you. Before we start to do the final work needed for this, we'd like to know what kind of impact this will have on people. If you're using make install you should be fine (though you'll have to stop using make install and start using setup.py). If people could let us know if they are running directly out of an SVN checkout, it would help. And we'd advise transitioning to a proper installation as soon as possible. Thanks! Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
diff view - looking to do full file reviews not a diff between two version
In the diff viewer, for new files, only one version of the file is show (because only 1 exists). I would like our code reviews to be more about reviewing a file in a given state, not simply a diff. Is there anyway to create your diff so that the diff viewer will only show a single version of the file, as specified by the diff file? This would avoid the side by side of the same file, which I am sure is extremely useful, but for how we work, is something we'd like to be able to bypass if we could. By the way, this is ideal for reviewers who are looking at the code for the first time, who need to review the entire file, not just the diff from version X to Y. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: diff view - looking to do full file reviews not a diff between two version
It just hit me too, that you can just click the expand changes link in the diff viewer header, there's nothing stopping you from reviewing parts that didn't change, we do it all the time... just make sure to hit that link, otherwise the comments that are in old sections won't be displayed --Christian or Dave-- as an enhancement, how hard would it be to set auto expand as either a user or global setting? Jeff O|||O Help me and the Leukemia and Lymphoma society fight blood cancers: http://pages.teamintraining.org/dm/tucson08/jandros On Thu, Oct 16, 2008 at 10:17 AM, Jeff Andros [EMAIL PROTECTED] wrote: There are two ways to do this: 1. if you manually diff your current file against a file that doesn't exist (there may be a flag you need to set on your diff program), it will generate a diff against a new file, then you just need to adjust the diff header to make it right... we've got a simple script that does this for our perforce repo 2. I haven't tried it, but there's a revision range argument on post-review. Last I knew, this doesn't work for all SCM's, but it should eventually. just supply a revision number like 0. (this has been suggested before I think) HTH Jeff O|||O Help me and the Leukemia and Lymphoma society fight blood cancers: http://pages.teamintraining.org/dm/tucson08/jandros On Thu, Oct 16, 2008 at 7:59 AM, fts1050 [EMAIL PROTECTED]wrote: In the diff viewer, for new files, only one version of the file is show (because only 1 exists). I would like our code reviews to be more about reviewing a file in a given state, not simply a diff. Is there anyway to create your diff so that the diff viewer will only show a single version of the file, as specified by the diff file? This would avoid the side by side of the same file, which I am sure is extremely useful, but for how we work, is something we'd like to be able to bypass if we could. By the way, this is ideal for reviewers who are looking at the code for the first time, who need to review the entire file, not just the diff from version X to Y. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: diff view - looking to do full file reviews not a diff between two version
There are two ways to do this: 1. if you manually diff your current file against a file that doesn't exist (there may be a flag you need to set on your diff program), it will generate a diff against a new file, then you just need to adjust the diff header to make it right... we've got a simple script that does this for our perforce repo 2. I haven't tried it, but there's a revision range argument on post-review. Last I knew, this doesn't work for all SCM's, but it should eventually. just supply a revision number like 0. (this has been suggested before I think) HTH Jeff O|||O Help me and the Leukemia and Lymphoma society fight blood cancers: http://pages.teamintraining.org/dm/tucson08/jandros On Thu, Oct 16, 2008 at 7:59 AM, fts1050 [EMAIL PROTECTED] wrote: In the diff viewer, for new files, only one version of the file is show (because only 1 exists). I would like our code reviews to be more about reviewing a file in a given state, not simply a diff. Is there anyway to create your diff so that the diff viewer will only show a single version of the file, as specified by the diff file? This would avoid the side by side of the same file, which I am sure is extremely useful, but for how we work, is something we'd like to be able to bypass if we could. By the way, this is ideal for reviewers who are looking at the code for the first time, who need to review the entire file, not just the diff from version X to Y. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: email notifications - questions and possible issue
We send emails on 1, 3 and 4. There's an open bug about 2, but no immediate ETA for fixing it. -David On Thu, Oct 16, 2008 at 7:01 AM, fts1050 [EMAIL PROTECTED] wrote: I was wondering what all the events that cause an email trigger. My guess would be: 1.)When a review goes live (to everyone who is on the review) 2.)When a review gets closed (set submitted) 3.)Anytime a review is published by any of the reviewers 4.)When a diff is updated 5.)More:? (Can you confirm all of the events that trigger an email,if possible?) I haven't had a chance to test all of these, but the one I have been working with the most is #3, and I have seen this work, but at times I don't get any emails.. I can't seem to figure out why. Any thoughts? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: email notifications - questions and possible issue
Thanks for the response, any thoughts on why those emails only work sometimes? Has anyone else had this issue besides me? On Thu, Oct 16, 2008 at 1:37 PM, David Trowbridge [EMAIL PROTECTED]wrote: We send emails on 1, 3 and 4. There's an open bug about 2, but no immediate ETA for fixing it. -David On Thu, Oct 16, 2008 at 7:01 AM, fts1050 [EMAIL PROTECTED] wrote: I was wondering what all the events that cause an email trigger. My guess would be: 1.)When a review goes live (to everyone who is on the review) 2.)When a review gets closed (set submitted) 3.)Anytime a review is published by any of the reviewers 4.)When a diff is updated 5.)More:? (Can you confirm all of the events that trigger an email,if possible?) I haven't had a chance to test all of these, but the one I have been working with the most is #3, and I have seen this work, but at times I don't get any emails.. I can't seem to figure out why. Any thoughts? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: diff view - looking to do full file reviews not a diff between two version
Thanks! I actually used revision range and it worked out well. It thinks it's a new file which is exactly what I wanted. I suspect that sometimes I will want to see the diff, but its nice to have the flexibility to do both. Thanks for the feedback! On Oct 16, 1:22 pm, Jeff Andros [EMAIL PROTECTED] wrote: It just hit me too, that you can just click the expand changes link in the diff viewer header, there's nothing stopping you from reviewing parts that didn't change, we do it all the time... just make sure to hit that link, otherwise the comments that are in old sections won't be displayed --Christian or Dave-- as an enhancement, how hard would it be to set auto expand as either a user or global setting? Jeff O|||O Help me and the Leukemia and Lymphoma society fight blood cancers:http://pages.teamintraining.org/dm/tucson08/jandros On Thu, Oct 16, 2008 at 10:17 AM, Jeff Andros [EMAIL PROTECTED] wrote: There are two ways to do this: 1. if you manually diff your current file against a file that doesn't exist (there may be a flag you need to set on your diff program), it will generate a diff against a new file, then you just need to adjust the diff header to make it right... we've got a simple script that does this for our perforce repo 2. I haven't tried it, but there's a revision range argument on post-review. Last I knew, this doesn't work for all SCM's, but it should eventually. just supply a revision number like 0. (this has been suggested before I think) HTH Jeff O|||O Help me and the Leukemia and Lymphoma society fight blood cancers: http://pages.teamintraining.org/dm/tucson08/jandros On Thu, Oct 16, 2008 at 7:59 AM, fts1050 [EMAIL PROTECTED]wrote: In the diff viewer, for new files, only one version of the file is show (because only 1 exists). I would like our code reviews to be more about reviewing a file in a given state, not simply a diff. Is there anyway to create your diff so that the diff viewer will only show a single version of the file, as specified by the diff file? This would avoid the side by side of the same file, which I am sure is extremely useful, but for how we work, is something we'd like to be able to bypass if we could. By the way, this is ideal for reviewers who are looking at the code for the first time, who need to review the entire file, not just the diff from version X to Y. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Problem setting Syntax Highlighting option
We saw some settings weirdness like that in a new installation. I'm trying to figure it out, but I'm not sure yet. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Thu, Oct 16, 2008 at 11:47 AM, fts1050 [EMAIL PROTECTED] wrote: Ok, strange. It works now, but I didn't do anything. (the box is not under my control so a restart my have occurred without me having to do it). However, in the admin interface, it still appears unset. Also, for new profiles, I always have to set it manually (which I am not sure if that is intentional or not, or if it is because I am having some sort of issue). I guess I don't care as long as it works, its just weird. Something is still not right but I'll put it on the low priority list for now. On Oct 16, 5:30 am, Christian Hammond [EMAIL PROTECTED] wrote: Syntax highlighting should be on by default once you turn it on system-wide. If not, we need to figure out a fix. Are you using mod_python? What happens if you set it and then restart the server? Does it stick? Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Wed, Oct 15, 2008 at 7:02 AM, fts1050 [EMAIL PROTECTED] wrote: I installed the Pygments library, as a result, I was able to turn on syntax highlighting in gthe admin interface. When I hit save the notification said my setting was changed successfully, but the setting now appears unset again after the save occurred. I repeated this and no change. I am not sure if this is simply UI issue or if something is really silently failing in this step. I did turn on syntax highlighting on my profile, and even after log in and log out, the syntax highlighting did not work (according to Pygments, we are using languages that are supported for syntax highlighting). No syntax highlighting has occured. So my first question is, where can I start looking to troubleshoot? My next question is, is there anyway to set, by default, the syntax highlighting to on for each profile (instead of off by default?) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Upgrading issues
We've been running reviewboard now internally for 6 months or so now, and I was going to create a new server for a much wider audience. I made the mistake of trying to both upgrade to the latest version, plus moving to a new machine. I got the server set up rather easily (I thought) . I've been having issues with the post-review script (another discussion thread), so I decided to try to use the older (v0.7) script. It doesn't just work. I was getting an error from the server that it couldn't import P4 (perforce). The line in perforce.py says: import P4 I compared the two servers I have, and the only differences that I have are in the reviewboard scripts. It appears that someone changed perforce.py to uppercase - P4 instead of p4. Ok I thought - I'll just copy the p4 python script to P4.py. Well - now there are other significant errors, and I can only assume that something is very wrong now. Here is an excerpt from the error (after renaming p4.py to P4.py) Request Method: POST Request URL: http://revboard.corp.good.com/reviewboard/api/json/reviewrequests/new/ Exception Type: TypeError Exception Value: 'int' object is not callable Exception Location: /usr/local/src/reviewboard/scmtools/perforce.py in _connect, line 39 Python Executable: /usr/bin/python Python Version: 2.5.2 Line 39 of perforce.py says: if not self.p4.connected(): Note that in this case, it is lowercased again! I'm really hoping that the tools aren't developed on Windows machines, because on Ubuntu linux... I'm pretty sure that case matters. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Upgrading issues
You need to upgrade your perforce API on the server to 07.3 or 08.1 -David On Thu, Oct 16, 2008 at 2:51 PM, AndyP [EMAIL PROTECTED] wrote: We've been running reviewboard now internally for 6 months or so now, and I was going to create a new server for a much wider audience. I made the mistake of trying to both upgrade to the latest version, plus moving to a new machine. I got the server set up rather easily (I thought) . I've been having issues with the post-review script (another discussion thread), so I decided to try to use the older (v0.7) script. It doesn't just work. I was getting an error from the server that it couldn't import P4 (perforce). The line in perforce.py says: import P4 I compared the two servers I have, and the only differences that I have are in the reviewboard scripts. It appears that someone changed perforce.py to uppercase - P4 instead of p4. Ok I thought - I'll just copy the p4 python script to P4.py. Well - now there are other significant errors, and I can only assume that something is very wrong now. Here is an excerpt from the error (after renaming p4.py to P4.py) Request Method: POST Request URL: http://revboard.corp.good.com/reviewboard/api/json/reviewrequests/new/ Exception Type: TypeError Exception Value: 'int' object is not callable Exception Location: /usr/local/src/reviewboard/scmtools/perforce.py in _connect, line 39 Python Executable: /usr/bin/python Python Version: 2.5.2 Line 39 of perforce.py says: if not self.p4.connected(): Note that in this case, it is lowercased again! I'm really hoping that the tools aren't developed on Windows machines, because on Ubuntu linux... I'm pretty sure that case matters. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Important: Who's running directly out of an SVN checkout?
We are running out of an SVN checkout as well. Maybe that is the reason my upgrade doesn't work - I was following the instructions on the wiki to set up a new machine, and have been having significant issues. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: diff view - looking to do full file reviews not a diff between two version
If a user clicks Expand Changes, we remember that for future diffs. So, users only need to ever do it once. There's no global setting for this, but I suppose it could be added if someone wanted to write a patch. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Thu, Oct 16, 2008 at 10:22 AM, Jeff Andros [EMAIL PROTECTED] wrote: It just hit me too, that you can just click the expand changes link in the diff viewer header, there's nothing stopping you from reviewing parts that didn't change, we do it all the time... just make sure to hit that link, otherwise the comments that are in old sections won't be displayed --Christian or Dave-- as an enhancement, how hard would it be to set auto expand as either a user or global setting? Jeff O|||O Help me and the Leukemia and Lymphoma society fight blood cancers: http://pages.teamintraining.org/dm/tucson08/jandros On Thu, Oct 16, 2008 at 10:17 AM, Jeff Andros [EMAIL PROTECTED] wrote: There are two ways to do this: 1. if you manually diff your current file against a file that doesn't exist (there may be a flag you need to set on your diff program), it will generate a diff against a new file, then you just need to adjust the diff header to make it right... we've got a simple script that does this for our perforce repo 2. I haven't tried it, but there's a revision range argument on post-review. Last I knew, this doesn't work for all SCM's, but it should eventually. just supply a revision number like 0. (this has been suggested before I think) HTH Jeff O|||O Help me and the Leukemia and Lymphoma society fight blood cancers: http://pages.teamintraining.org/dm/tucson08/jandros On Thu, Oct 16, 2008 at 7:59 AM, fts1050 [EMAIL PROTECTED]wrote: In the diff viewer, for new files, only one version of the file is show (because only 1 exists). I would like our code reviews to be more about reviewing a file in a given state, not simply a diff. Is there anyway to create your diff so that the diff viewer will only show a single version of the file, as specified by the diff file? This would avoid the side by side of the same file, which I am sure is extremely useful, but for how we work, is something we'd like to be able to bypass if we could. By the way, this is ideal for reviewers who are looking at the code for the first time, who need to review the entire file, not just the diff from version X to Y. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Problem setting Syntax Highlighting option
Thanks for the kind words :) It's really nice to hear feedback like this, and certainly encourages us to continue working hard on the product. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Thu, Oct 16, 2008 at 1:04 PM, Nancy Bennett [EMAIL PROTECTED]wrote: No worries. I'll keep my eyes peeled for updates, I'm sure you guys will get a fix soon. By the way, I am really impressed with this tool. We evaluated Crucible first and decided to pass as there were too many quirks and annoyances for the price they were asking. Both your tool and theirs have some neat features, but I think I like yours better overall. It's amazing how on par your tool is with theirs given how much Crucible costs. We're excited to start using this over here!! Keep up the good work! On Thu, Oct 16, 2008 at 3:49 PM, Christian Hammond [EMAIL PROTECTED]wrote: We saw some settings weirdness like that in a new installation. I'm trying to figure it out, but I'm not sure yet. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Thu, Oct 16, 2008 at 11:47 AM, fts1050 [EMAIL PROTECTED]wrote: Ok, strange. It works now, but I didn't do anything. (the box is not under my control so a restart my have occurred without me having to do it). However, in the admin interface, it still appears unset. Also, for new profiles, I always have to set it manually (which I am not sure if that is intentional or not, or if it is because I am having some sort of issue). I guess I don't care as long as it works, its just weird. Something is still not right but I'll put it on the low priority list for now. On Oct 16, 5:30 am, Christian Hammond [EMAIL PROTECTED] wrote: Syntax highlighting should be on by default once you turn it on system-wide. If not, we need to figure out a fix. Are you using mod_python? What happens if you set it and then restart the server? Does it stick? Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Wed, Oct 15, 2008 at 7:02 AM, fts1050 [EMAIL PROTECTED] wrote: I installed the Pygments library, as a result, I was able to turn on syntax highlighting in gthe admin interface. When I hit save the notification said my setting was changed successfully, but the setting now appears unset again after the save occurred. I repeated this and no change. I am not sure if this is simply UI issue or if something is really silently failing in this step. I did turn on syntax highlighting on my profile, and even after log in and log out, the syntax highlighting did not work (according to Pygments, we are using languages that are supported for syntax highlighting). No syntax highlighting has occured. So my first question is, where can I start looking to troubleshoot? My next question is, is there anyway to set, by default, the syntax highlighting to on for each profile (instead of off by default?) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: email notifications - questions and possible issue
They should work every time. I'm not sure why it would only be part of the time. Do some operations work and others don't, or is it more sporadic than that? Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Thu, Oct 16, 2008 at 10:54 AM, Nancy Bennett [EMAIL PROTECTED]wrote: Thanks for the response, any thoughts on why those emails only work sometimes? Has anyone else had this issue besides me? On Thu, Oct 16, 2008 at 1:37 PM, David Trowbridge [EMAIL PROTECTED]wrote: We send emails on 1, 3 and 4. There's an open bug about 2, but no immediate ETA for fixing it. -David On Thu, Oct 16, 2008 at 7:01 AM, fts1050 [EMAIL PROTECTED] wrote: I was wondering what all the events that cause an email trigger. My guess would be: 1.)When a review goes live (to everyone who is on the review) 2.)When a review gets closed (set submitted) 3.)Anytime a review is published by any of the reviewers 4.)When a diff is updated 5.)More:? (Can you confirm all of the events that trigger an email,if possible?) I haven't had a chance to test all of these, but the one I have been working with the most is #3, and I have seen this work, but at times I don't get any emails.. I can't seem to figure out why. Any thoughts? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: changing django settings with djblets.siteconfig
This is probably a small design flaw. We're populating these settings in the SiteConfiguration entry in the database with whatever was in settings.py, settings_local.py or Django's default settings file, but that gives users no way to override in settings_local.py. Since we are populating it, we're going to need to provide equivalent settings in the admin UI. If you can file a bug on what exactly you need to change (cache backend and whatever else), I'll get to it soon. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Thu, Oct 16, 2008 at 6:32 AM, eyal [EMAIL PROTECTED] wrote: Hi, I've got a question about how djblets.siteconfig handles changes in the settings.py and settings_local.py files. After upgrading to r1537 (and introducing djblets.siteconfig), as I understand, a SiteConfiguration object has been created (and stored in the db) that reflects the existing state of settings.py and setting_local.py. If I later make changes to settings_local.py (for example, changing the cache backend), it's not reflected in the SiteConfiguration object, and ReviewBoard never sees this change. There also doesn't seem to be an easy way to update this field (the settings admin interface doesn't include it). This shouldn't be this cumbersome. I get a feeling that I missed something... Thanks, Eyal --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Getting error after adding Repository as Subversion and clicking New Review Request button.
What distro is this? It sounds like you're just going to need a pysvn compiled on that system against your current Python. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Thu, Oct 16, 2008 at 5:35 AM, Dev [EMAIL PROTECTED] wrote: Getting error ImportError at /r/new/ pysvn was built against newer (svn, apr, etc.) libraries then the ones installed on this system. / usr/lib/python2.5/site-packages/pysvn/_pysvn_2_5.so: undefined symbol: _ZN2Py19PythonExtensionBase12rich_compareERKNS_6ObjectEi after adding Repository. Pl help me . --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Issue 637 in reviewboard: E-mail review participants when Set Submitted is set or unset
Issue 637: E-mail review participants when Set Submitted is set or unset http://code.google.com/p/reviewboard/issues/detail?id=637 Comment #1 by jamesdlin: I would hope that this would be optional if it were implemented. I wouldn't want the extra email. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 637 in reviewboard: E-mail review participants when Set Submitted is set or unset
Issue 637: E-mail review participants when Set Submitted is set or unset http://code.google.com/p/reviewboard/issues/detail?id=637 Comment #2 by chipx86: Yeah, it will be optional if we end up doing it, likely disabled by default. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 693 in reviewboard: ability to attach a comment when clicking [Submitted]
Issue 693: ability to attach a comment when clicking [Submitted]
http://code.google.com/p/reviewboard/issues/detail?id=693
New issue report by [EMAIL PROTECTED]:
I'd like to be able to attach a comment when clicking [Submitted] to
close out a review. I generally want to tag the review with the
changeset number that checked it in.
Currently, pending review edits are committed when you click
[Submitted]. This technically satisfies my wish, but it's rather
counter-intuitive. Also, it sends email to reviewers. That's not 100%
bad but should be a per-user option with values: { never [default];
only on reviews I was requested to review; only on reviews I've actually
commented on }.
UI: clicking [Submitted] pops up a comment edit window; if you [Publish]
immediately, it goes in with no comment; if you type a comment, it
appears in the list of review comments just like other comments, but
visually marked (e.g. [Submitted] in the header line).
[ It would be nice to integrate this with bug tracking version control
systems so submission changeset info could be captured automatically.
But this would be incredibly difficult even if reviewboard was tightly
bound to a single bug tracker vcs: was it closed because this fix was
checked in, a fix elsewhere pinched off this code path, we decided it
wasn't a bug or wasn't important? So this is useless wishlist stuff. ]
Issue attributes:
Status: New
Owner:
Labels: Type-Defect Priority-Medium
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
Issue 667 in reviewboard: Cannot mark item with a star when in list
Issue 667: Cannot mark item with a star when in list http://code.google.com/p/reviewboard/issues/detail?id=667 Comment #4 by thinkfly: Same problem, with Django r9231 and Review Board r1537. All star columns in lists are not working, though it reflects correct status of starred or not. Mouse on it and a hand cursor appears, but click does nothing. It should trigger the star from off to on or from on to off. However the star works in review request detail page[/r/123], where it is the only place I find that star works. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 694 in reviewboard: Group List Incorrectly Display iPhone Edition
Issue 694: Group List Incorrectly Display iPhone Edition http://code.google.com/p/reviewboard/issues/detail?id=694 New issue report by thinkfly: *NOTE: Do not post confidential information in this bug report.* What's the URL of the page containing the problem? /groups/ What steps will reproduce the problem? 1. Go there What is the expected output? What do you see instead? Actual: Groups in the list have URL pointed to iphone edition.[/iphone/ groups/group_name/] Expected: [/groups/group_name/] What operating system are you using? What browser? IE7 and Opera tested. Please provide any additional information below. Review Board r1537 and Django r9231 Issue attributes: Status: New Owner: Labels: Type-Defect Priority-Medium -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 695 in reviewboard: Admin Logout URL
Issue 695: Admin Logout URL http://code.google.com/p/reviewboard/issues/detail?id=695 New issue report by thinkfly: *NOTE: Do not post confidential information in this bug report.* What's the URL of the page containing the problem? /admin/settings/general/ What steps will reproduce the problem? 1. Go to Admin page, the Change password and Logout works 2. Click on Settings What is the expected output? What do you see instead? Expected: URL should still be [/admin/db/logout] Actual: [/admin/settings/general/logout] Or: [/admin/settings/diffs/logout] if you're seeing Diff View Settings What operating system are you using? What browser? IE7 and Opera tested. Please provide any additional information below. Review Board r1537 and Django r9231 Issue attributes: Status: New Owner: Labels: Type-Defect Priority-Medium -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
