Hi Lukasz,
We intentionally don't show line endings. For most repositories, most
setups, line endings are not a stable concept. That is, the line ending you
check into a repository is not necessarily the line ending you get when it
comes back out. It often depends on the platform, the type of repo
Hello all RB developers and users,
We have some problems with Review Board diff viewer.
First one is related with line-endings.
We add lots of files with text lines endings Unix-styled (LF) in first
revision and then convert them into CR-LF (Windows) without changing its
contents in second revi
anbag, Inc. - https://www.beanbaginc.com
-Original Message-
From: n Tomar
Reply: reviewboard@googlegroups.com >
Date: June 2, 2015 at 11:28:00 AM
To: reviewboard@googlegroups.com >
Cc: anir...@anirudhsanjeev.org >
Subject: Re: Want to use ReviewBoard's side-by-side diffvie
Hi,
I want to use the diff functionality of reviewboard as it efficiently
shows the moved code also. But Iam not sure whether I can be used in my
application as it appears from the above conversation that diff code was
earlier dependent on other modules in the reviewboard.
Please suggest if i
Specifically "There are unapplied evolutions for diffviewer." It
> appeared in a red color which made me think it might be a problem.
>
> On Fri, Jul 29, 2011 at 3:51 PM, Christian Hammond
> wrote:
> > Hi Joe,
> >
> > Nothing in there looks problematic to me. W
Specifically "There are unapplied evolutions for diffviewer." It
appeared in a red color which made me think it might be a problem.
On Fri, Jul 29, 2011 at 3:51 PM, Christian Hammond wrote:
> Hi Joe,
>
> Nothing in there looks problematic to me. What concerned you? Jus
iew Board from 1.6 RC1 to 1.6 RC2
> There are unapplied evolutions for diffviewer.
> Installing custom SQL ...
> Installing indexes ...
> No fixtures found.
> Evolution successful.
> Resetting in-database caches.
> Upgrade complete.
>
>
> After restarting my web ser
I just upgraded from 1.6RC1 to 1.6RC2 and when I ran rb-site upgrade, I got
the following output:
Rebuilding directory structure
Updating database. This may take a while.
Creating tables ...
Upgrading Review Board from 1.6 RC1 to 1.6 RC2
There are unapplied evolutions for diffviewer.
Installing
Christian Hammond wrote:
What version of patch are you guys running?
I'm running Ubuntu 8.04.3 LTS - I have patch 2.5.9
ing...@reviews:~$ cat /etc/*elease*
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=8.04
DISTRIB_CODENAME=hardy
DISTRIB_DESCRIPTION="Ubuntu 8.04.3 LTS"
ing...@reviews:~$
n Wed, Apr 28, 2010 at 1:41 PM, Chris Clark wrote:
> Jan Koprowski wrote:
>
>> When I make review for file where some changes was made near last
>> line and it have not new line at end of file diffviewer crush :/ I'm
>> thinking about adding one more "fake" ne
Jan Koprowski wrote:
When I make review for file where some changes was made near last
line and it have not new line at end of file diffviewer crush :/ I'm
thinking about adding one more "fake" new line sign at the end
everytime. Is this patch will be submitted if I create on
Hi!
When I make review for file where some changes was made near last
line and it have not new line at end of file diffviewer crush :/ I'm
thinking about adding one more "fake" new line sign at the end
everytime. Is this patch will be submitted if I create one?
Greetings from
ithin Review Board (such as
the scmtools and accounts modules).
That being said, with some changes to make the diffviewer's dependencies on
the accounts module a bit more flexible, you could potentially just depend
on the reviewboard codebase and use the diffviewer module directly from
that. It doe
Hello,
I have questions about the diffviewer feature of reviewboard.
Is it going to be forked off reviewboard and become a separate MIT-
licensed django app? I could see that the code was moved around a bit
to make it a separate app, but it that the direction it is taking?
My second question
Hi,
Thank you for the detailed and informative reply.
I had a closer look at the Review Board diff algorithm and was rather
overwhelmed. Re-using the code for my simple purpose would be overkill.
But there still isn't any tool to work on the unified diff format in python.
I found some respite wit
tics, but it'll get it wrong part of the time. Review Board used
to do this before our Myers differ (as Python's difflib doesn't generate
"replace" information), and it was just bad.
If you do go the route of parsing the diffs and need to parse it into files,
you can loo
ewBoard codebase which I am using only as
reference.
I looked in the diffviewer app, but that seems to be rather large and
daunting. Most other implementations seem to be quite inferior to
ReviewBoard's implementation of the same. Python's difflib's HTML table
generator is enough for
Hi,
Review Board's diff viewer is modular (well, in theory, but we've only used
it in Review Board). It should be usable in another project, though it
requires other pieces of the Review Board codebase (like the SCMTools, admin
settings, and accounts code). If you required Review Board as a depend
Hi,
I'm writing an open-source project in django. It's like pastebin for
patches where each patch gets it's own review thread. Think
reviewboard, but where each patch gets it's own url for review, and it
is project-agnostic. A user can upload/paste a patch and get a link.
This is primarily being d
While tracking down some caching issues we're having, I noticed that
build_diff_fragment in diffviewer/views.py isn't using the large_data
option to cache_memoize. Should it be? (That's not a rhetorical
question.)
I doubt this is the source of the problems we're having,
20 matches
Mail list logo
