Re: Review Request 46445: Refactor get_stack_to_component() method

[Jayush Luniya]

> On April 23, 2016, 6:09 a.m., Jayush Luniya wrote:
> > Ship It!

Committed to trunk. Please close review!


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46445/#review130249
---


On April 22, 2016, 10:54 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46445/
> ---
> 
> (Updated April 22, 2016, 10:54 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-15609
> https://issues.apache.org/jira/browse/AMBARI-15609
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The original intention of the get_stack_to_component function was to have a 
> dictionary where the key was the stack name.
> At service level we always return the same key no matter what, then we should 
> just return the string with the component name and no need to check 
> params.stack_name
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 193138b 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_client.py
>  8f94a59 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py
>  e210a11 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
>  3715e61 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  ae760cb 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
>  fa869be 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
>  d4935fe 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py
>  cf8d864 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
>  b56efa2 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
>  4b4a876 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
>  4efa739 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py
>  93816e3 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  1e0c605 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
>  e3b0070 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
>  9929b02 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  bb6f1ca 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py
>  65cc4fb 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
>  c8ec843 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py
>  99c214d 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
>  a87042a 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
>  ee82e79 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
>  bea00ed 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  fe05ff6 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
>  6924040 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py
>  5f22bba 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py
>  0a37161 
>   
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout_client.py
>  1fa4625 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
>  d7e9e4d 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  31cf9e9 
>   
> ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py
>  90a5514 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  66ae76e 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py
>  43ecd07 
>   
> ambari-server/src/main/resources/common-services/RANGER/0

Re: Review Request 46445: Refactor get_stack_to_component() method

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46445/#review130249
---


Ship it!




Ship It!

- Jayush Luniya


On April 22, 2016, 10:54 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46445/
> ---
> 
> (Updated April 22, 2016, 10:54 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-15609
> https://issues.apache.org/jira/browse/AMBARI-15609
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The original intention of the get_stack_to_component function was to have a 
> dictionary where the key was the stack name.
> At service level we always return the same key no matter what, then we should 
> just return the string with the component name and no need to check 
> params.stack_name
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 193138b 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_client.py
>  8f94a59 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py
>  e210a11 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
>  3715e61 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  ae760cb 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
>  fa869be 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
>  d4935fe 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py
>  cf8d864 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
>  b56efa2 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
>  4b4a876 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
>  4efa739 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py
>  93816e3 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  1e0c605 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
>  e3b0070 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
>  9929b02 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  bb6f1ca 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py
>  65cc4fb 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
>  c8ec843 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py
>  99c214d 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
>  a87042a 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
>  ee82e79 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
>  bea00ed 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  fe05ff6 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
>  6924040 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py
>  5f22bba 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py
>  0a37161 
>   
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout_client.py
>  1fa4625 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
>  d7e9e4d 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  31cf9e9 
>   
> ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py
>  90a5514 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  66ae76e 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py
>  43ecd07 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py
>  2382d9c 
>   
> ambari-server/src/main

Review Request 46600: Config calculations used by LLAP app.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46600/
---

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-16078.patch
https://issues.apache.org/jira/browse/AMBARI-16078.patch


Repository: ambari


Description
---

Config calculations used by LLAP app.
- Calculated in Stack advisor code whenever (1). HSI is enabled, or (2). change 
done to slider HSI slider "% of Cluster Capacity" , or (3). change done to 
slider HSI slider 'Number of Daemon Instances'
- 
- caluclations are not done if the overall cluster state is not conduciv for 
meaningful run of LLAP.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 fe05ff6 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 a044fda 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
 816e207 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 21d1109 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
4da21fa 

Diff: https://reviews.apache.org/r/46600/diff/


Testing
---


Thanks,

Swapan Shridhar

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46583/#review130241
---


Ship it!




Ship It!

- Sumit Mohanty


On April 22, 2016, 9:12 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46583/
> ---
> 
> (Updated April 22, 2016, 9:12 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Oliver Szabo, 
> Sumit Mohanty, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-16072
> https://issues.apache.org/jira/browse/AMBARI-16072
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When adding a service to a Kerberized cluster and click install nothing 
> happens on the UI and i see the following error in the ambari server logs
> 
> ```
> 20 Apr 2016 16:03:56,818  INFO [qtp-ambari-client-2764] 
> KerberosHelperImpl:735 - Adding identity for JOURNALNODE to auth to local 
> mapping
> 20 Apr 2016 16:03:56,818  INFO [qtp-ambari-client-2764] 
> KerberosHelperImpl:735 - Adding identity for METRICS_COLLECTOR to auth to 
> local mapping
> 20 Apr 2016 16:03:56,857  INFO [qtp-ambari-client-2764] StackAdvisorRunner:47 
> - Script=/var/lib/ambari-server/resources/scripts/stack_advisor.py, 
> actionDirectory=/var/run/ambari-server/stack-recommendations/323, 
> command=recommend-configurations
> 20 Apr 2016 16:03:56,860  INFO [qtp-ambari-client-2764] StackAdvisorRunner:61 
> - Stack-advisor 
> output=/var/run/ambari-server/stack-recommendations/323/stackadvisor.out, 
> error=/var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> 20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:69 
> - Stack advisor output files
> 20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:70 
> - advisor script stdout: StackAdvisor implementation for stack HDP, 
> version 2.0.6 was loaded
> StackAdvisor implementation for stack HDP, version 2.1 was loaded
> StackAdvisor implementation for stack HDP, version 2.2 was loaded
> StackAdvisor implementation for stack HDP, version 2.3 was loaded
> StackAdvisor implementation for stack HDP, version 2.4 was loaded
> Returning HDP24StackAdvisor implementation
> Error occured in stack advisor.
> Error details: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:71 
> - advisor script stderr: Traceback (most recent call last):
>   File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, 
> in 
> main(sys.argv)
>   File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 109, 
> in main
> result = stackAdvisor.recommendConfigurations(services, hosts)
>   File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", 
> line 570, in recommendConfigurations
> calculation(configurations, clusterSummary, services, hosts)
>   File 
> "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py",
>  line 627, in recommendAmsConfigurations
> if set(amsCollectorHosts).intersection(dn_hosts):
> TypeError: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,918  INFO [qtp-ambari-client-2764] 
> AbstractResourceProvider:802 - Caught an exception while updating host 
> components, retrying : org.apache.ambari.server.AmbariException: Stack 
> Advisor reported an error: TypeError: 'NoneType' object is not iterable
> StdOut file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.out
> 
> StdErr file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> ```
> 
> # Solution
> Pass to the stack advisor information about all installed services where each 
> component is installed (component host map)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  dca81c5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  84f0bac 
> 
> Diff: https://reviews.apache.org/r/46583/diff/
> 
> 
> Testing
> ---
> 
> Manually tested using the UI and BP.
> 
> # Local test results: PENDING
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 46595: MR service check failed during EU (Intermittent)

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46595/#review130228
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 23, 2016, 12:11 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46595/
> ---
> 
> (Updated April 23, 2016, 12:11 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-16075
> https://issues.apache.org/jira/browse/AMBARI-16075
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The kinit'ed ticket appears to be expiring between calls.  Use the caching 
> kinit executor method to re-kinit if needed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py
>  3edfd7b 
>   
> ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py
>  8d79deb 
> 
> Diff: https://reviews.apache.org/r/46595/diff/
> 
> 
> Testing
> ---
> 
> Manual tested upgrade to make sure service check still worked.  Automated 
> python:
> 
> --
> Total run:995
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 46595: MR service check failed during EU (Intermittent)

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46595/
---

Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-16075
https://issues.apache.org/jira/browse/AMBARI-16075


Repository: ambari


Description
---

The kinit'ed ticket appears to be expiring between calls.  Use the caching 
kinit executor method to re-kinit if needed.


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py
 3edfd7b 
  
ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py
 8d79deb 

Diff: https://reviews.apache.org/r/46595/diff/


Testing
---

Manual tested upgrade to make sure service check still worked.  Automated 
python:

--
Total run:995
Total errors:0
Total failures:0
OK


Thanks,

Nate Cole

Review Request 46585: Show number of PXFs Live widget on main dashboard

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46585/
---

Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, 
jun aoki, and Lav Jain.


Bugs: AMBARI-16074
https://issues.apache.org/jira/browse/AMBARI-16074


Repository: ambari


Description
---

Show number of PXFs Live widget on main dashboard


Diffs
-

  ambari-web/app/assets/test/tests.js 33e7f1c 
  ambari-web/app/mappers/components_state_mapper.js 755c0f5 
  ambari-web/app/messages.js 907d9ae 
  ambari-web/app/views.js 6bb2774 
  ambari-web/app/views/main/dashboard/widgets.js 067607f 
  ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js bec98c6 
  ambari-web/app/views/main/dashboard/widgets/pxf_live.js PRE-CREATION 
  ambari-web/test/views/main/dashboard/widgets/pxf_live_test.js PRE-CREATION 

Diff: https://reviews.apache.org/r/46585/diff/


Testing
---

Manually Tested

Added Unit test.

Unit test Results:

  27538 tests complete (22 seconds)
  154 tests pending
  
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 01:11 min
[INFO] Finished at: 2016-04-22T16:50:37-07:00
[INFO] Final Memory: 12M/310M
[INFO] 


Thanks,

Matt

Re: Review Request 46592: Add a quick link to Grafana dashboards from Hive Service page

[Srimanth Gunturi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46592/#review130219
---


Ship it!




Ship It!

- Srimanth Gunturi


On April 22, 2016, 11:17 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46592/
> ---
> 
> (Updated April 22, 2016, 11:17 p.m.)
> 
> 
> Review request for Ambari, Di Li, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-16076
> https://issues.apache.org/jira/browse/AMBARI-16076
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Hive Dashboard (Grafana) link in Hive service page->Quick links Action
> 
> At present, All quick links of a service are mapped to only one master 
> component of the service. Also this mapping is done in FE. As part of this 
> task the mapping of a link to a master component is now done in quick link 
> stack definition. So we can now have quick links on a service page linking to 
> different component hosts driven from stack. If host component is not yet 
> installed on the cluster then quick link won't appear.
> 
> Also seperate protocol defination can be made for every single quick link.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java
>  8800b3a 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/quicklinks/quicklinks.json
>  1c276c0 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json
>  48a3efe 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/quicklinks/quicklinks.json
>  b6281f7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/quicklinks/quicklinks.json
>  5568122 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/quicklinks/quicklinks.json
>  a4216e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/quicklinks/quicklinks.json
>  621fe8a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/quicklinks-mapred/quicklinks.json
>  36f71b5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/quicklinks/quicklinks.json
>  56c54b8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/quicklinks/quicklinks.json
>  42611d6 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ACCUMULO/quicklinks/quicklinks.json
>  36e67c2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/quicklinks/quicklinks.json
>  37e95cf 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/quicklinks/quicklinks.json
>  9863dc4 
>   ambari-web/app/controllers/wizard/step6_controller.js 3adc636 
>   ambari-web/app/controllers/wizard/step7_controller.js 2f78adf 
>   ambari-web/app/models/quicklinks/quick_links_config.js c9b2709 
>   ambari-web/app/views/common/quick_view_link_view.js dcaacb8 
>   ambari-web/test/views/common/quick_link_view_test.js 32b050b 
> 
> Diff: https://reviews.apache.org/r/46592/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on the cluster.
> Verified all ambari-web unit tests passes:
> 
>   27527 tests complete (31 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130191
---




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
(line 44)


*return componentName in ('HAWQMASTER', 'HAWQSTANDBY')*



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
(line 118)


There is some additional logic for HAWQ mentioned in 
recommendHDFSConfigurations: 
https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py#L368-#L370
 

I believe this would still work from the HDP 2.3 stack advisor. Would you 
like to move it here?



ambari-server/src/main/resources/stacks/service_advisor.py (line 48)


stackadvisor is being passed to many of the service advisor functions for 
using some utility functions like isLocalHost()

These utility functions should ideally reside outside both stack advisor 
and service advisor.



ambari-server/src/main/resources/stacks/stack_advisor.py (line 419)


If component A of service SA is co-located based on how component B of 
service SB is laid out, and services list is ['SA', 'SB'], then host assignment 
for A comes before B, which would be incorrect.

SB's components should be recommended first, then SA's components, because 
A depends on host assignment of B.



ambari-server/src/main/resources/stacks/stack_advisor.py (line 576)


createServiceAdvisor is called multiple times, in 
componentLayoutValidations, recommendComponentLayout, etc. 

Is it not possible to call it once, and cache it and use it again?



ambari-server/src/main/resources/stacks/stack_advisor.py (line 654)


How is this different from the function defined on line 586 (right side)?


- Matt


On April 22, 2016, 11:27 a.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 22, 2016, 11:27 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush 
> Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a65541 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 
>   ambari-server/src/test/pytho

Review Request 46592: Add a quick link to Grafana dashboards from Hive Service page

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46592/
---

Review request for Ambari, Di Li, Srimanth Gunturi, and Yusaku Sako.


Bugs: AMBARI-16076
https://issues.apache.org/jira/browse/AMBARI-16076


Repository: ambari


Description
---

Add Hive Dashboard (Grafana) link in Hive service page->Quick links Action

At present, All quick links of a service are mapped to only one master 
component of the service. Also this mapping is done in FE. As part of this task 
the mapping of a link to a master component is now done in quick link stack 
definition. So we can now have quick links on a service page linking to 
different component hosts driven from stack. If host component is not yet 
installed on the cluster then quick link won't appear.

Also seperate protocol defination can be made for every single quick link.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java 
8800b3a 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/quicklinks/quicklinks.json
 1c276c0 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json
 48a3efe 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/quicklinks/quicklinks.json
 b6281f7 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/quicklinks/quicklinks.json
 5568122 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/quicklinks/quicklinks.json
 a4216e3 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/quicklinks/quicklinks.json
 621fe8a 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/quicklinks-mapred/quicklinks.json
 36f71b5 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/quicklinks/quicklinks.json
 56c54b8 
  
ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/quicklinks/quicklinks.json
 42611d6 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/ACCUMULO/quicklinks/quicklinks.json
 36e67c2 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/quicklinks/quicklinks.json
 37e95cf 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/quicklinks/quicklinks.json
 9863dc4 
  ambari-web/app/controllers/wizard/step6_controller.js 3adc636 
  ambari-web/app/controllers/wizard/step7_controller.js 2f78adf 
  ambari-web/app/models/quicklinks/quick_links_config.js c9b2709 
  ambari-web/app/views/common/quick_view_link_view.js dcaacb8 
  ambari-web/test/views/common/quick_link_view_test.js 32b050b 

Diff: https://reviews.apache.org/r/46592/diff/


Testing
---

Manually tested on the cluster.
Verified all ambari-web unit tests passes


Thanks,

Jaimin Jetly

Re: Review Request 46592: Add a quick link to Grafana dashboards from Hive Service page

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46592/
---

(Updated April 22, 2016, 11:17 p.m.)


Review request for Ambari, Di Li, Srimanth Gunturi, and Yusaku Sako.


Bugs: AMBARI-16076
https://issues.apache.org/jira/browse/AMBARI-16076


Repository: ambari


Description
---

Add Hive Dashboard (Grafana) link in Hive service page->Quick links Action

At present, All quick links of a service are mapped to only one master 
component of the service. Also this mapping is done in FE. As part of this task 
the mapping of a link to a master component is now done in quick link stack 
definition. So we can now have quick links on a service page linking to 
different component hosts driven from stack. If host component is not yet 
installed on the cluster then quick link won't appear.

Also seperate protocol defination can be made for every single quick link.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java 
8800b3a 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/quicklinks/quicklinks.json
 1c276c0 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json
 48a3efe 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/quicklinks/quicklinks.json
 b6281f7 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/quicklinks/quicklinks.json
 5568122 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/quicklinks/quicklinks.json
 a4216e3 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/quicklinks/quicklinks.json
 621fe8a 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/quicklinks-mapred/quicklinks.json
 36f71b5 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/quicklinks/quicklinks.json
 56c54b8 
  
ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/quicklinks/quicklinks.json
 42611d6 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/ACCUMULO/quicklinks/quicklinks.json
 36e67c2 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/quicklinks/quicklinks.json
 37e95cf 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/quicklinks/quicklinks.json
 9863dc4 
  ambari-web/app/controllers/wizard/step6_controller.js 3adc636 
  ambari-web/app/controllers/wizard/step7_controller.js 2f78adf 
  ambari-web/app/models/quicklinks/quick_links_config.js c9b2709 
  ambari-web/app/views/common/quick_view_link_view.js dcaacb8 
  ambari-web/test/views/common/quick_link_view_test.js 32b050b 

Diff: https://reviews.apache.org/r/46592/diff/


Testing (updated)
---

Manually tested on the cluster.
Verified all ambari-web unit tests passes:

  27527 tests complete (31 seconds)
  154 tests pending


Thanks,

Jaimin Jetly

Re: Review Request 46445: Refactor get_stack_to_component() method

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46445/
---

(Updated April 22, 2016, 10:54 p.m.)


Review request for Ambari, Alejandro Fernandez and Jayush Luniya.


Bugs: AMBARI-15609
https://issues.apache.org/jira/browse/AMBARI-15609


Repository: ambari


Description
---

The original intention of the get_stack_to_component function was to have a 
dictionary where the key was the stack name.
At service level we always return the same key no matter what, then we should 
just return the string with the component name and no need to check 
params.stack_name


Diffs (updated)
-

  ambari-common/src/main/python/resource_management/libraries/script/script.py 
193138b 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_client.py
 8f94a59 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py
 e210a11 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
 3715e61 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
 ae760cb 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
 fa869be 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
 d4935fe 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py
 cf8d864 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
 b56efa2 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
 4b4a876 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
 4efa739 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py
 93816e3 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
 1e0c605 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
 e3b0070 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
 9929b02 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
 bb6f1ca 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py
 65cc4fb 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
 c8ec843 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py
 99c214d 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
 a87042a 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
 ee82e79 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
 bea00ed 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 fe05ff6 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
 6924040 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py
 5f22bba 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py
 0a37161 
  
ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout_client.py
 1fa4625 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
 d7e9e4d 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
 31cf9e9 
  
ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py
 90a5514 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
 66ae76e 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py
 43ecd07 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py
 2382d9c 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py
 e13affc 
  
ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py
 ba76259 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py
 7a7f086 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_client.py
 740c442 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_thrift_server.py
 f3742be 
  
ambari-server/src/main/resources/com

Re: Review Request 46547: Create "/hadoop/llap/local" on each host and disk in Kerberized cluster for LLAP

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46547/#review130209
---


Ship it!




LGTM.

- Swapan Shridhar


On April 22, 2016, 10:24 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46547/
> ---
> 
> (Updated April 22, 2016, 10:24 p.m.)
> 
> 
> Review request for Ambari, Siddharth Seth and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-16031
> https://issues.apache.org/jira/browse/AMBARI-16031
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - In non-kerberized cluster, hive.llap.daemon.work.dir will point to : 
> "${yarn.nodemanager.local-dirs}”
> - In kerberized cluster, we need to create "/hadoop/llap/local" on each node 
> and disk and have "hive.llap.daemon.work.dirs" point to it.
> - It's similar to the way yarn.nodemanager.local-dirs is created.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/kerberos.json
>  872bfac 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml 
> 10e6405 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
>  6837c27 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  19dbb60 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  735d8cb 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json 
> a03a1b7 
>   ambari-web/app/controllers/main/service/item.js 5707882 
>   ambari-web/app/messages.js 6c0049d 
>   ambari-web/app/models/host_component.js b4a369e 
>   ambari-web/app/views/main/service/item.js 51f9bdd 
>   ambari-web/test/views/main/service/item_test.js 085eaad 
> 
> Diff: https://reviews.apache.org/r/46547/diff/
> 
> 
> Testing
> ---
> 
> Verified on cluster with HDP 2.4, Hive Server Interactive + LLAP, and then 
> kerberized.
> 
> Python unit tests passed,
> --
> Total run:976
> Total errors:0
> Total failures:0
> OK
> 
> on ambari-web, mvn test passed,
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 39.952 s
> [INFO] Finished at: 2016-04-21T15:55:34-07:00
> [INFO] Final Memory: 36M/3926M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 46547: Create "/hadoop/llap/local" on each host and disk in Kerberized cluster for LLAP

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46547/
---

(Updated April 22, 2016, 10:24 p.m.)


Review request for Ambari, Siddharth Seth and Swapan Shridhar.


Summary (updated)
-

Create "/hadoop/llap/local" on each host and disk in Kerberized cluster for LLAP


Bugs: AMBARI-16031
https://issues.apache.org/jira/browse/AMBARI-16031


Repository: ambari


Description
---

- In non-kerberized cluster, hive.llap.daemon.work.dir will point to : 
"${yarn.nodemanager.local-dirs}”
- In kerberized cluster, we need to create "/hadoop/llap/local" on each node 
and disk and have "hive.llap.daemon.work.dirs" point to it.
- It's similar to the way yarn.nodemanager.local-dirs is created.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/kerberos.json 
872bfac 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml 
10e6405 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
 6837c27 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 19dbb60 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
 735d8cb 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json 
a03a1b7 
  ambari-web/app/controllers/main/service/item.js 5707882 
  ambari-web/app/messages.js 6c0049d 
  ambari-web/app/models/host_component.js b4a369e 
  ambari-web/app/views/main/service/item.js 51f9bdd 
  ambari-web/test/views/main/service/item_test.js 085eaad 

Diff: https://reviews.apache.org/r/46547/diff/


Testing
---

Verified on cluster with HDP 2.4, Hive Server Interactive + LLAP, and then 
kerberized.

Python unit tests passed,
--
Total run:976
Total errors:0
Total failures:0
OK

on ambari-web, mvn test passed,
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 39.952 s
[INFO] Finished at: 2016-04-21T15:55:34-07:00
[INFO] Final Memory: 36M/3926M
[INFO] 


Thanks,

Alejandro Fernandez

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

[Robert Levas]

> On April 22, 2016, 4:58 p.m., Aravindan Vijayan wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java,
> >  line 2433
> > 
> >
> > I meant this method.
> 
> Robert Levas wrote:
> I did a bit of searching in the code and didn't see anything obvious.  I 
> search for methods the returned `Map>` and none seemd to 
> return a map of components to host names given the cluster object. The 
> closest method that resembles it is 
> `org.apache.ambari.server.api.services.stackadvisor.StackAdvisorBlueprintProcessor#gatherComponentsHostsMap`
>  but it builds the map using data from a Blueprint, not from the existing 
> cluster data. 
> 
> I suppose I can move this method somewhere, but I am not sure where... 
> maybe the Cluster object?
> 
> Aravindan Vijayan wrote:
> I am ok with the method staying in this class.

After thinking about it... I'll move it.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46583/#review130178
---


On April 22, 2016, 5:12 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46583/
> ---
> 
> (Updated April 22, 2016, 5:12 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Oliver Szabo, 
> Sumit Mohanty, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-16072
> https://issues.apache.org/jira/browse/AMBARI-16072
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When adding a service to a Kerberized cluster and click install nothing 
> happens on the UI and i see the following error in the ambari server logs
> 
> ```
> 20 Apr 2016 16:03:56,818  INFO [qtp-ambari-client-2764] 
> KerberosHelperImpl:735 - Adding identity for JOURNALNODE to auth to local 
> mapping
> 20 Apr 2016 16:03:56,818  INFO [qtp-ambari-client-2764] 
> KerberosHelperImpl:735 - Adding identity for METRICS_COLLECTOR to auth to 
> local mapping
> 20 Apr 2016 16:03:56,857  INFO [qtp-ambari-client-2764] StackAdvisorRunner:47 
> - Script=/var/lib/ambari-server/resources/scripts/stack_advisor.py, 
> actionDirectory=/var/run/ambari-server/stack-recommendations/323, 
> command=recommend-configurations
> 20 Apr 2016 16:03:56,860  INFO [qtp-ambari-client-2764] StackAdvisorRunner:61 
> - Stack-advisor 
> output=/var/run/ambari-server/stack-recommendations/323/stackadvisor.out, 
> error=/var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> 20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:69 
> - Stack advisor output files
> 20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:70 
> - advisor script stdout: StackAdvisor implementation for stack HDP, 
> version 2.0.6 was loaded
> StackAdvisor implementation for stack HDP, version 2.1 was loaded
> StackAdvisor implementation for stack HDP, version 2.2 was loaded
> StackAdvisor implementation for stack HDP, version 2.3 was loaded
> StackAdvisor implementation for stack HDP, version 2.4 was loaded
> Returning HDP24StackAdvisor implementation
> Error occured in stack advisor.
> Error details: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:71 
> - advisor script stderr: Traceback (most recent call last):
>   File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, 
> in 
> main(sys.argv)
>   File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 109, 
> in main
> result = stackAdvisor.recommendConfigurations(services, hosts)
>   File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", 
> line 570, in recommendConfigurations
> calculation(configurations, clusterSummary, services, hosts)
>   File 
> "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py",
>  line 627, in recommendAmsConfigurations
> if set(amsCollectorHosts).intersection(dn_hosts):
> TypeError: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,918  INFO [qtp-ambari-client-2764] 
> AbstractResourceProvider:802 - Caught an exception while updating host 
> components, retrying : org.apache.ambari.server.AmbariException: Stack 
> Advisor reported an error: TypeError: 'NoneType' object is not iterable
> StdOut file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.out
> 
> StdErr file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> ```
> 
> # Solution
> Pass to the stack advisor information about all installed services where each 
> component is installed (component host map)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/j

Re: Review Request 46445: Refactor get_stack_to_component() method

[Juanjo Marron]

> On April 22, 2016, 6:27 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/script/script.py,
> >  line 155
> > 
> >
> > Should add "pass" for it to be a complete function
> 
> Jayush Luniya wrote:
> +1

Thanks both for the review.

Anyway I need to recreate the patch and test it again since it is now creating 
conflicts with this JIRA:
https://issues.apache.org/jira/browse/AMBARI-16014 which has been committed 
yesterday


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46445/#review130152
---


On April 20, 2016, 4:35 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46445/
> ---
> 
> (Updated April 20, 2016, 4:35 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-15609
> https://issues.apache.org/jira/browse/AMBARI-15609
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The original intention of the get_stack_to_component function was to have a 
> dictionary where the key was the stack name.
> At service level we always return the same key no matter what, then we should 
> just return the string with the component name and no need to check 
> params.stack_name
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 31d7b2a 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_client.py
>  ebfacf2 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py
>  1004d23 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
>  14a12d3 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  a5990a2 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
>  75b5de4 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
>  86bf3b6 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py
>  1bd99da 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
>  b72e648 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
>  5833773 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
>  37dd0a1 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py
>  7d639ec 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  ffaf4ea 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
>  9f62d29 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
>  ac73eaf 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  c8acae3 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py
>  ca2e3ef 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
>  4a6f144 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py
>  6c41fc2 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
>  6af0cd3 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
>  8adff0a 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
>  9ba8619 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  9d011a0 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
>  482f0be 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py
>  41074db 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py
>  aa5ce1f 
>   
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout_client.py
>  d39b66a 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
>  dc08f0b 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/pa

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Tim Thorpe]

> On April 22, 2016, 6:15 p.m., Jayush Luniya wrote:
> >
> 
> Alexander Denissov wrote:
> So, what will be the rules for SA logic inheritance ?
> 
> When MYSERVICE/2.0.0 ships and needs to reuse the stack_advisor logic 
> from MYSERVICE/1.0.0 -- will we:
> - rely on stack inheritance ?
> - rely on SA inheritance within MYSERVICE ?
> - combination of these ?
> 
> Tim Thorpe wrote:
> There will be no implicit inheritance.  If you want to use inheritance 
> you can but it will be left up to the service to handle it with code like:
> 
> SCRIPT_DIR = os.path.dirname(os.path.abspath(file))
> PARENT_DIR = os.path.join(SCRIPT_DIR, '../../../2.2/services/YARN/')
> PARENT_FILE = os.path.join(PARENT_DIR, 'service_advisor.py')
> 
> try:
>   with open(PARENT_FILE, 'rb') as fp:
> service_advisor = imp.load_module('service_advisor', fp, PARENT_FILE, 
> ('.py', 'rb', imp.PY_SOURCE))
> except Exception as e:
>   traceback.print_exc()
>   print "Failed to load parent"
> 
> 
> class 
> HDP23MAPREDUCE2ServiceAdvisor(service_advisor.HDP22MAPREDUCE2ServiceAdvisor):

So I guess the answer to your question is none of those.


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130141
---


On April 22, 2016, 6:27 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 22, 2016, 6:27 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush 
> Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a65541 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 6c9fd46 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> ---
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Tim Thorpe]

> On April 22, 2016, 6:15 p.m., Jayush Luniya wrote:
> >
> 
> Alexander Denissov wrote:
> So, what will be the rules for SA logic inheritance ?
> 
> When MYSERVICE/2.0.0 ships and needs to reuse the stack_advisor logic 
> from MYSERVICE/1.0.0 -- will we:
> - rely on stack inheritance ?
> - rely on SA inheritance within MYSERVICE ?
> - combination of these ?

There will be no implicit inheritance.  If you want to use inheritance you can 
but it will be left up to the service to handle it with code like:

SCRIPT_DIR = os.path.dirname(os.path.abspath(file))
PARENT_DIR = os.path.join(SCRIPT_DIR, '../../../2.2/services/YARN/')
PARENT_FILE = os.path.join(PARENT_DIR, 'service_advisor.py')

try:
  with open(PARENT_FILE, 'rb') as fp:
service_advisor = imp.load_module('service_advisor', fp, PARENT_FILE, 
('.py', 'rb', imp.PY_SOURCE))
except Exception as e:
  traceback.print_exc()
  print "Failed to load parent"


class 
HDP23MAPREDUCE2ServiceAdvisor(service_advisor.HDP22MAPREDUCE2ServiceAdvisor):


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130141
---


On April 22, 2016, 6:27 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 22, 2016, 6:27 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush 
> Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a65541 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 6c9fd46 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> ---
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

[Aravindan Vijayan]

> On April 22, 2016, 8:58 p.m., Aravindan Vijayan wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java,
> >  line 2433
> > 
> >
> > I meant this method.
> 
> Robert Levas wrote:
> I did a bit of searching in the code and didn't see anything obvious.  I 
> search for methods the returned `Map>` and none seemd to 
> return a map of components to host names given the cluster object. The 
> closest method that resembles it is 
> `org.apache.ambari.server.api.services.stackadvisor.StackAdvisorBlueprintProcessor#gatherComponentsHostsMap`
>  but it builds the map using data from a Blueprint, not from the existing 
> cluster data. 
> 
> I suppose I can move this method somewhere, but I am not sure where... 
> maybe the Cluster object?

I am ok with the method staying in this class.


- Aravindan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46583/#review130178
---


On April 22, 2016, 9:12 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46583/
> ---
> 
> (Updated April 22, 2016, 9:12 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Oliver Szabo, 
> Sumit Mohanty, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-16072
> https://issues.apache.org/jira/browse/AMBARI-16072
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When adding a service to a Kerberized cluster and click install nothing 
> happens on the UI and i see the following error in the ambari server logs
> 
> ```
> 20 Apr 2016 16:03:56,818  INFO [qtp-ambari-client-2764] 
> KerberosHelperImpl:735 - Adding identity for JOURNALNODE to auth to local 
> mapping
> 20 Apr 2016 16:03:56,818  INFO [qtp-ambari-client-2764] 
> KerberosHelperImpl:735 - Adding identity for METRICS_COLLECTOR to auth to 
> local mapping
> 20 Apr 2016 16:03:56,857  INFO [qtp-ambari-client-2764] StackAdvisorRunner:47 
> - Script=/var/lib/ambari-server/resources/scripts/stack_advisor.py, 
> actionDirectory=/var/run/ambari-server/stack-recommendations/323, 
> command=recommend-configurations
> 20 Apr 2016 16:03:56,860  INFO [qtp-ambari-client-2764] StackAdvisorRunner:61 
> - Stack-advisor 
> output=/var/run/ambari-server/stack-recommendations/323/stackadvisor.out, 
> error=/var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> 20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:69 
> - Stack advisor output files
> 20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:70 
> - advisor script stdout: StackAdvisor implementation for stack HDP, 
> version 2.0.6 was loaded
> StackAdvisor implementation for stack HDP, version 2.1 was loaded
> StackAdvisor implementation for stack HDP, version 2.2 was loaded
> StackAdvisor implementation for stack HDP, version 2.3 was loaded
> StackAdvisor implementation for stack HDP, version 2.4 was loaded
> Returning HDP24StackAdvisor implementation
> Error occured in stack advisor.
> Error details: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:71 
> - advisor script stderr: Traceback (most recent call last):
>   File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, 
> in 
> main(sys.argv)
>   File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 109, 
> in main
> result = stackAdvisor.recommendConfigurations(services, hosts)
>   File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", 
> line 570, in recommendConfigurations
> calculation(configurations, clusterSummary, services, hosts)
>   File 
> "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py",
>  line 627, in recommendAmsConfigurations
> if set(amsCollectorHosts).intersection(dn_hosts):
> TypeError: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,918  INFO [qtp-ambari-client-2764] 
> AbstractResourceProvider:802 - Caught an exception while updating host 
> components, retrying : org.apache.ambari.server.AmbariException: Stack 
> Advisor reported an error: TypeError: 'NoneType' object is not iterable
> StdOut file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.out
> 
> StdErr file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> ```
> 
> # Solution
> Pass to the stack advisor information about all installed services where each 
> component is installed (component host map)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  dca81c5

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

[Robert Levas]

> On April 22, 2016, 4:58 p.m., Aravindan Vijayan wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java,
> >  line 2433
> > 
> >
> > I meant this method.

I did a bit of searching in the code and didn't see anything obvious.  I search 
for methods the returned `Map>` and none seemd to return a 
map of components to host names given the cluster object. The closest method 
that resembles it is 
`org.apache.ambari.server.api.services.stackadvisor.StackAdvisorBlueprintProcessor#gatherComponentsHostsMap`
 but it builds the map using data from a Blueprint, not from the existing 
cluster data. 

I suppose I can move this method somewhere, but I am not sure where... maybe 
the Cluster object?


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46583/#review130178
---


On April 22, 2016, 5:12 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46583/
> ---
> 
> (Updated April 22, 2016, 5:12 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Oliver Szabo, 
> Sumit Mohanty, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-16072
> https://issues.apache.org/jira/browse/AMBARI-16072
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When adding a service to a Kerberized cluster and click install nothing 
> happens on the UI and i see the following error in the ambari server logs
> 
> ```
> 20 Apr 2016 16:03:56,818  INFO [qtp-ambari-client-2764] 
> KerberosHelperImpl:735 - Adding identity for JOURNALNODE to auth to local 
> mapping
> 20 Apr 2016 16:03:56,818  INFO [qtp-ambari-client-2764] 
> KerberosHelperImpl:735 - Adding identity for METRICS_COLLECTOR to auth to 
> local mapping
> 20 Apr 2016 16:03:56,857  INFO [qtp-ambari-client-2764] StackAdvisorRunner:47 
> - Script=/var/lib/ambari-server/resources/scripts/stack_advisor.py, 
> actionDirectory=/var/run/ambari-server/stack-recommendations/323, 
> command=recommend-configurations
> 20 Apr 2016 16:03:56,860  INFO [qtp-ambari-client-2764] StackAdvisorRunner:61 
> - Stack-advisor 
> output=/var/run/ambari-server/stack-recommendations/323/stackadvisor.out, 
> error=/var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> 20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:69 
> - Stack advisor output files
> 20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:70 
> - advisor script stdout: StackAdvisor implementation for stack HDP, 
> version 2.0.6 was loaded
> StackAdvisor implementation for stack HDP, version 2.1 was loaded
> StackAdvisor implementation for stack HDP, version 2.2 was loaded
> StackAdvisor implementation for stack HDP, version 2.3 was loaded
> StackAdvisor implementation for stack HDP, version 2.4 was loaded
> Returning HDP24StackAdvisor implementation
> Error occured in stack advisor.
> Error details: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:71 
> - advisor script stderr: Traceback (most recent call last):
>   File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, 
> in 
> main(sys.argv)
>   File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 109, 
> in main
> result = stackAdvisor.recommendConfigurations(services, hosts)
>   File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", 
> line 570, in recommendConfigurations
> calculation(configurations, clusterSummary, services, hosts)
>   File 
> "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py",
>  line 627, in recommendAmsConfigurations
> if set(amsCollectorHosts).intersection(dn_hosts):
> TypeError: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,918  INFO [qtp-ambari-client-2764] 
> AbstractResourceProvider:802 - Caught an exception while updating host 
> components, retrying : org.apache.ambari.server.AmbariException: Stack 
> Advisor reported an error: TypeError: 'NoneType' object is not iterable
> StdOut file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.out
> 
> StdErr file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> ```
> 
> # Solution
> Pass to the stack advisor information about all installed services where each 
> component is installed (component host map)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  dca81c5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  84f0bac

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46583/#review130184
---


Ship it!




Ship It!

- Oliver Szabo


On April 22, 2016, 9:12 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46583/
> ---
> 
> (Updated April 22, 2016, 9:12 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Oliver Szabo, 
> Sumit Mohanty, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-16072
> https://issues.apache.org/jira/browse/AMBARI-16072
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When adding a service to a Kerberized cluster and click install nothing 
> happens on the UI and i see the following error in the ambari server logs
> 
> ```
> 20 Apr 2016 16:03:56,818  INFO [qtp-ambari-client-2764] 
> KerberosHelperImpl:735 - Adding identity for JOURNALNODE to auth to local 
> mapping
> 20 Apr 2016 16:03:56,818  INFO [qtp-ambari-client-2764] 
> KerberosHelperImpl:735 - Adding identity for METRICS_COLLECTOR to auth to 
> local mapping
> 20 Apr 2016 16:03:56,857  INFO [qtp-ambari-client-2764] StackAdvisorRunner:47 
> - Script=/var/lib/ambari-server/resources/scripts/stack_advisor.py, 
> actionDirectory=/var/run/ambari-server/stack-recommendations/323, 
> command=recommend-configurations
> 20 Apr 2016 16:03:56,860  INFO [qtp-ambari-client-2764] StackAdvisorRunner:61 
> - Stack-advisor 
> output=/var/run/ambari-server/stack-recommendations/323/stackadvisor.out, 
> error=/var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> 20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:69 
> - Stack advisor output files
> 20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:70 
> - advisor script stdout: StackAdvisor implementation for stack HDP, 
> version 2.0.6 was loaded
> StackAdvisor implementation for stack HDP, version 2.1 was loaded
> StackAdvisor implementation for stack HDP, version 2.2 was loaded
> StackAdvisor implementation for stack HDP, version 2.3 was loaded
> StackAdvisor implementation for stack HDP, version 2.4 was loaded
> Returning HDP24StackAdvisor implementation
> Error occured in stack advisor.
> Error details: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:71 
> - advisor script stderr: Traceback (most recent call last):
>   File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, 
> in 
> main(sys.argv)
>   File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 109, 
> in main
> result = stackAdvisor.recommendConfigurations(services, hosts)
>   File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", 
> line 570, in recommendConfigurations
> calculation(configurations, clusterSummary, services, hosts)
>   File 
> "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py",
>  line 627, in recommendAmsConfigurations
> if set(amsCollectorHosts).intersection(dn_hosts):
> TypeError: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,918  INFO [qtp-ambari-client-2764] 
> AbstractResourceProvider:802 - Caught an exception while updating host 
> components, retrying : org.apache.ambari.server.AmbariException: Stack 
> Advisor reported an error: TypeError: 'NoneType' object is not iterable
> StdOut file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.out
> 
> StdErr file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> ```
> 
> # Solution
> Pass to the stack advisor information about all installed services where each 
> component is installed (component host map)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  dca81c5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  84f0bac 
> 
> Diff: https://reviews.apache.org/r/46583/diff/
> 
> 
> Testing
> ---
> 
> Manually tested using the UI and BP.
> 
> # Local test results: PENDING
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46583/#review130178
---




ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 (line 2433)


I meant this method.


- Aravindan Vijayan


On April 22, 2016, 8:47 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46583/
> ---
> 
> (Updated April 22, 2016, 8:47 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Oliver Szabo, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16072
> https://issues.apache.org/jira/browse/AMBARI-16072
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When adding a service to a Kerberized cluster and click install nothing 
> happens on the UI and i see the following error in the ambari server logs
> 
> ```
> 20 Apr 2016 16:03:56,818  INFO [qtp-ambari-client-2764] 
> KerberosHelperImpl:735 - Adding identity for JOURNALNODE to auth to local 
> mapping
> 20 Apr 2016 16:03:56,818  INFO [qtp-ambari-client-2764] 
> KerberosHelperImpl:735 - Adding identity for METRICS_COLLECTOR to auth to 
> local mapping
> 20 Apr 2016 16:03:56,857  INFO [qtp-ambari-client-2764] StackAdvisorRunner:47 
> - Script=/var/lib/ambari-server/resources/scripts/stack_advisor.py, 
> actionDirectory=/var/run/ambari-server/stack-recommendations/323, 
> command=recommend-configurations
> 20 Apr 2016 16:03:56,860  INFO [qtp-ambari-client-2764] StackAdvisorRunner:61 
> - Stack-advisor 
> output=/var/run/ambari-server/stack-recommendations/323/stackadvisor.out, 
> error=/var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> 20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:69 
> - Stack advisor output files
> 20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:70 
> - advisor script stdout: StackAdvisor implementation for stack HDP, 
> version 2.0.6 was loaded
> StackAdvisor implementation for stack HDP, version 2.1 was loaded
> StackAdvisor implementation for stack HDP, version 2.2 was loaded
> StackAdvisor implementation for stack HDP, version 2.3 was loaded
> StackAdvisor implementation for stack HDP, version 2.4 was loaded
> Returning HDP24StackAdvisor implementation
> Error occured in stack advisor.
> Error details: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:71 
> - advisor script stderr: Traceback (most recent call last):
>   File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, 
> in 
> main(sys.argv)
>   File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 109, 
> in main
> result = stackAdvisor.recommendConfigurations(services, hosts)
>   File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", 
> line 570, in recommendConfigurations
> calculation(configurations, clusterSummary, services, hosts)
>   File 
> "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py",
>  line 627, in recommendAmsConfigurations
> if set(amsCollectorHosts).intersection(dn_hosts):
> TypeError: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,918  INFO [qtp-ambari-client-2764] 
> AbstractResourceProvider:802 - Caught an exception while updating host 
> components, retrying : org.apache.ambari.server.AmbariException: Stack 
> Advisor reported an error: TypeError: 'NoneType' object is not iterable
> StdOut file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.out
> 
> StdErr file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> ```
> 
> # Solution
> Pass to the stack advisor information about all installed services where each 
> component is installed (component host map)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  dca81c5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  84f0bac 
> 
> Diff: https://reviews.apache.org/r/46583/diff/
> 
> 
> Testing
> ---
> 
> Manually tested using the UI and BP.
> 
> # Local test results: PENDING
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46583/#review130176
---


Ship it!




This looks like a general utility method. Can we check if something similar is 
not already present in StackAdvisorResourceProvider or somewhere else?

If there is no such method, we can go with this.

- Aravindan Vijayan


On April 22, 2016, 8:47 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46583/
> ---
> 
> (Updated April 22, 2016, 8:47 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Oliver Szabo, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16072
> https://issues.apache.org/jira/browse/AMBARI-16072
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When adding a service to a Kerberized cluster and click install nothing 
> happens on the UI and i see the following error in the ambari server logs
> 
> ```
> 20 Apr 2016 16:03:56,818  INFO [qtp-ambari-client-2764] 
> KerberosHelperImpl:735 - Adding identity for JOURNALNODE to auth to local 
> mapping
> 20 Apr 2016 16:03:56,818  INFO [qtp-ambari-client-2764] 
> KerberosHelperImpl:735 - Adding identity for METRICS_COLLECTOR to auth to 
> local mapping
> 20 Apr 2016 16:03:56,857  INFO [qtp-ambari-client-2764] StackAdvisorRunner:47 
> - Script=/var/lib/ambari-server/resources/scripts/stack_advisor.py, 
> actionDirectory=/var/run/ambari-server/stack-recommendations/323, 
> command=recommend-configurations
> 20 Apr 2016 16:03:56,860  INFO [qtp-ambari-client-2764] StackAdvisorRunner:61 
> - Stack-advisor 
> output=/var/run/ambari-server/stack-recommendations/323/stackadvisor.out, 
> error=/var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> 20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:69 
> - Stack advisor output files
> 20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:70 
> - advisor script stdout: StackAdvisor implementation for stack HDP, 
> version 2.0.6 was loaded
> StackAdvisor implementation for stack HDP, version 2.1 was loaded
> StackAdvisor implementation for stack HDP, version 2.2 was loaded
> StackAdvisor implementation for stack HDP, version 2.3 was loaded
> StackAdvisor implementation for stack HDP, version 2.4 was loaded
> Returning HDP24StackAdvisor implementation
> Error occured in stack advisor.
> Error details: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:71 
> - advisor script stderr: Traceback (most recent call last):
>   File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, 
> in 
> main(sys.argv)
>   File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 109, 
> in main
> result = stackAdvisor.recommendConfigurations(services, hosts)
>   File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", 
> line 570, in recommendConfigurations
> calculation(configurations, clusterSummary, services, hosts)
>   File 
> "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py",
>  line 627, in recommendAmsConfigurations
> if set(amsCollectorHosts).intersection(dn_hosts):
> TypeError: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,918  INFO [qtp-ambari-client-2764] 
> AbstractResourceProvider:802 - Caught an exception while updating host 
> components, retrying : org.apache.ambari.server.AmbariException: Stack 
> Advisor reported an error: TypeError: 'NoneType' object is not iterable
> StdOut file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.out
> 
> StdErr file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> ```
> 
> # Solution
> Pass to the stack advisor information about all installed services where each 
> component is installed (component host map)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  dca81c5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  84f0bac 
> 
> Diff: https://reviews.apache.org/r/46583/diff/
> 
> 
> Testing
> ---
> 
> Manually tested using the UI and BP.
> 
> # Local test results: PENDING
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

[Alexandr Antonenko]

> On April 22, 2016, 5:30 p.m., Alexandr Antonenko wrote:
> > if we will ask BE and create task for them, this will mean move this out of 
> > 2.4. As BE is pretty heavy loaded with tasks
> 
> Zhe (Joe) Wang wrote:
> Agree. That's why I use FE to set the initial value.
> 
> Alexandr Antonenko wrote:
> This is pretty clear as for me, I say let's commit it. After this I will 
> create ticket that will do a little refactoring of this. Andrii T will handle 
> it

Discussed that with Andrii T


- Alexandr


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46405/#review130129
---


On April 21, 2016, 6:50 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46405/
> ---
> 
> (Updated April 21, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Jaimin Jetly, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15519
> https://issues.apache.org/jira/browse/AMBARI-15519
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the cluster where some nodes are in the maintenance mode Add Service 
> Wizard doesn't track this.
> So, user may select host in the maintenance mode to install some master 
> component. And this component won't be installed (only record in the DB will 
> be created for it).
> Another situation:
> there is some cluster where all nodes are in the maintenance mode. In this 
> case ASW is almost useless. Because all new components won't be installed 
> while it works.
> 
> ASW should track hosts in the maintenance mode and warn user about adding 
> components on them (Steps "Assign Masters", "Assign Slaves and Clients").
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard.js 52fb241 
>   ambari-web/app/mixins/wizard/assign_master_components.js e4c5295 
> 
> Diff: https://reviews.apache.org/r/46405/diff/
> 
> 
> Testing
> ---
> 
> Modified unit test.
> Local ambari-web test passed.
> 25680 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

[Zhe (Joe) Wang]

> On April 22, 2016, 5:30 p.m., Alexandr Antonenko wrote:
> > if we will ask BE and create task for them, this will mean move this out of 
> > 2.4. As BE is pretty heavy loaded with tasks
> 
> Zhe (Joe) Wang wrote:
> Agree. That's why I use FE to set the initial value.
> 
> Alexandr Antonenko wrote:
> This is pretty clear as for me, I say let's commit it. After this I will 
> create ticket that will do a little refactoring of this. Andrii T will handle 
> it
> 
> Alexandr Antonenko wrote:
> Discussed that with Andrii T

Cool. Thanks.


- Zhe (Joe)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46405/#review130129
---


On April 21, 2016, 6:50 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46405/
> ---
> 
> (Updated April 21, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Jaimin Jetly, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15519
> https://issues.apache.org/jira/browse/AMBARI-15519
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the cluster where some nodes are in the maintenance mode Add Service 
> Wizard doesn't track this.
> So, user may select host in the maintenance mode to install some master 
> component. And this component won't be installed (only record in the DB will 
> be created for it).
> Another situation:
> there is some cluster where all nodes are in the maintenance mode. In this 
> case ASW is almost useless. Because all new components won't be installed 
> while it works.
> 
> ASW should track hosts in the maintenance mode and warn user about adding 
> components on them (Steps "Assign Masters", "Assign Slaves and Clients").
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard.js 52fb241 
>   ambari-web/app/mixins/wizard/assign_master_components.js e4c5295 
> 
> Diff: https://reviews.apache.org/r/46405/diff/
> 
> 
> Testing
> ---
> 
> Modified unit test.
> Local ambari-web test passed.
> 25680 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

[Alexandr Antonenko]

> On April 22, 2016, 5:30 p.m., Alexandr Antonenko wrote:
> > if we will ask BE and create task for them, this will mean move this out of 
> > 2.4. As BE is pretty heavy loaded with tasks
> 
> Zhe (Joe) Wang wrote:
> Agree. That's why I use FE to set the initial value.

This is pretty clear as for me, I say let's commit it. After this I will create 
ticket that will do a little refactoring of this. Andrii T will handle it


- Alexandr


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46405/#review130129
---


On April 21, 2016, 6:50 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46405/
> ---
> 
> (Updated April 21, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Jaimin Jetly, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15519
> https://issues.apache.org/jira/browse/AMBARI-15519
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the cluster where some nodes are in the maintenance mode Add Service 
> Wizard doesn't track this.
> So, user may select host in the maintenance mode to install some master 
> component. And this component won't be installed (only record in the DB will 
> be created for it).
> Another situation:
> there is some cluster where all nodes are in the maintenance mode. In this 
> case ASW is almost useless. Because all new components won't be installed 
> while it works.
> 
> ASW should track hosts in the maintenance mode and warn user about adding 
> components on them (Steps "Assign Masters", "Assign Slaves and Clients").
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard.js 52fb241 
>   ambari-web/app/mixins/wizard/assign_master_components.js e4c5295 
> 
> Diff: https://reviews.apache.org/r/46405/diff/
> 
> 
> Testing
> ---
> 
> Modified unit test.
> Local ambari-web test passed.
> 25680 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46583/
---

(Updated April 22, 2016, 4:47 p.m.)


Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Oliver Szabo, 
and Sumit Mohanty.


Bugs: AMBARI-16072
https://issues.apache.org/jira/browse/AMBARI-16072


Repository: ambari


Description
---

When adding a service to a Kerberized cluster and click install nothing happens 
on the UI and i see the following error in the ambari server logs

```
20 Apr 2016 16:03:56,818  INFO [qtp-ambari-client-2764] KerberosHelperImpl:735 
- Adding identity for JOURNALNODE to auth to local mapping
20 Apr 2016 16:03:56,818  INFO [qtp-ambari-client-2764] KerberosHelperImpl:735 
- Adding identity for METRICS_COLLECTOR to auth to local mapping
20 Apr 2016 16:03:56,857  INFO [qtp-ambari-client-2764] StackAdvisorRunner:47 - 
Script=/var/lib/ambari-server/resources/scripts/stack_advisor.py, 
actionDirectory=/var/run/ambari-server/stack-recommendations/323, 
command=recommend-configurations
20 Apr 2016 16:03:56,860  INFO [qtp-ambari-client-2764] StackAdvisorRunner:61 - 
Stack-advisor 
output=/var/run/ambari-server/stack-recommendations/323/stackadvisor.out, 
error=/var/run/ambari-server/stack-recommendations/323/stackadvisor.err
20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:69 - 
Stack advisor output files
20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:70 - 
advisor script stdout: StackAdvisor implementation for stack HDP, version 
2.0.6 was loaded
StackAdvisor implementation for stack HDP, version 2.1 was loaded
StackAdvisor implementation for stack HDP, version 2.2 was loaded
StackAdvisor implementation for stack HDP, version 2.3 was loaded
StackAdvisor implementation for stack HDP, version 2.4 was loaded
Returning HDP24StackAdvisor implementation
Error occured in stack advisor.
Error details: 'NoneType' object is not iterable
20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:71 - 
advisor script stderr: Traceback (most recent call last):
  File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, 
in 
main(sys.argv)
  File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 109, 
in main
result = stackAdvisor.recommendConfigurations(services, hosts)
  File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", 
line 570, in recommendConfigurations
calculation(configurations, clusterSummary, services, hosts)
  File 
"/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py",
 line 627, in recommendAmsConfigurations
if set(amsCollectorHosts).intersection(dn_hosts):
TypeError: 'NoneType' object is not iterable
20 Apr 2016 16:03:56,918  INFO [qtp-ambari-client-2764] 
AbstractResourceProvider:802 - Caught an exception while updating host 
components, retrying : org.apache.ambari.server.AmbariException: Stack Advisor 
reported an error: TypeError: 'NoneType' object is not iterable
StdOut file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.out

StdErr file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.err
```

# Solution
Pass to the stack advisor information about all installed services where each 
component is installed (component host map)


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 dca81c5 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
 84f0bac 

Diff: https://reviews.apache.org/r/46583/diff/


Testing
---

Manually tested using the UI and BP.

# Local test results: PENDING

# Jenkins test results: PENDING


Thanks,

Robert Levas

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46583/
---

(Updated April 22, 2016, 4:46 p.m.)


Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Oliver Szabo, 
and Sumit Mohanty.


Bugs: AMBARI-16079
https://issues.apache.org/jira/browse/AMBARI-16079


Repository: ambari


Description (updated)
---

When adding a service to a Kerberized cluster and click install nothing happens 
on the UI and i see the following error in the ambari server logs

```
20 Apr 2016 16:03:56,818  INFO [qtp-ambari-client-2764] KerberosHelperImpl:735 
- Adding identity for JOURNALNODE to auth to local mapping
20 Apr 2016 16:03:56,818  INFO [qtp-ambari-client-2764] KerberosHelperImpl:735 
- Adding identity for METRICS_COLLECTOR to auth to local mapping
20 Apr 2016 16:03:56,857  INFO [qtp-ambari-client-2764] StackAdvisorRunner:47 - 
Script=/var/lib/ambari-server/resources/scripts/stack_advisor.py, 
actionDirectory=/var/run/ambari-server/stack-recommendations/323, 
command=recommend-configurations
20 Apr 2016 16:03:56,860  INFO [qtp-ambari-client-2764] StackAdvisorRunner:61 - 
Stack-advisor 
output=/var/run/ambari-server/stack-recommendations/323/stackadvisor.out, 
error=/var/run/ambari-server/stack-recommendations/323/stackadvisor.err
20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:69 - 
Stack advisor output files
20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:70 - 
advisor script stdout: StackAdvisor implementation for stack HDP, version 
2.0.6 was loaded
StackAdvisor implementation for stack HDP, version 2.1 was loaded
StackAdvisor implementation for stack HDP, version 2.2 was loaded
StackAdvisor implementation for stack HDP, version 2.3 was loaded
StackAdvisor implementation for stack HDP, version 2.4 was loaded
Returning HDP24StackAdvisor implementation
Error occured in stack advisor.
Error details: 'NoneType' object is not iterable
20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:71 - 
advisor script stderr: Traceback (most recent call last):
  File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, 
in 
main(sys.argv)
  File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 109, 
in main
result = stackAdvisor.recommendConfigurations(services, hosts)
  File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", 
line 570, in recommendConfigurations
calculation(configurations, clusterSummary, services, hosts)
  File 
"/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py",
 line 627, in recommendAmsConfigurations
if set(amsCollectorHosts).intersection(dn_hosts):
TypeError: 'NoneType' object is not iterable
20 Apr 2016 16:03:56,918  INFO [qtp-ambari-client-2764] 
AbstractResourceProvider:802 - Caught an exception while updating host 
components, retrying : org.apache.ambari.server.AmbariException: Stack Advisor 
reported an error: TypeError: 'NoneType' object is not iterable
StdOut file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.out

StdErr file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.err
```

# Solution
Pass to the stack advisor information about all installed services where each 
component is installed (component host map)


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 dca81c5 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
 84f0bac 

Diff: https://reviews.apache.org/r/46583/diff/


Testing
---

Manually tested using the UI and BP.

# Local test results: PENDING

# Jenkins test results: PENDING


Thanks,

Robert Levas

Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46583/
---

Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Oliver Szabo, 
and Sumit Mohanty.


Bugs: AMBARI-16079
https://issues.apache.org/jira/browse/AMBARI-16079


Repository: ambari


Description
---

When adding a service to a Kerberized cluster and click install nothing happens 
on the UI and i see the following error in the ambari server logs

```
20 Apr 2016 16:03:56,818  INFO [qtp-ambari-client-2764] KerberosHelperImpl:735 
- Adding identity for JOURNALNODE to auth to local mapping
20 Apr 2016 16:03:56,818  INFO [qtp-ambari-client-2764] KerberosHelperImpl:735 
- Adding identity for METRICS_COLLECTOR to auth to local mapping
20 Apr 2016 16:03:56,857  INFO [qtp-ambari-client-2764] StackAdvisorRunner:47 - 
Script=/var/lib/ambari-server/resources/scripts/stack_advisor.py, 
actionDirectory=/var/run/ambari-server/stack-recommendations/323, 
command=recommend-configurations
20 Apr 2016 16:03:56,860  INFO [qtp-ambari-client-2764] StackAdvisorRunner:61 - 
Stack-advisor 
output=/var/run/ambari-server/stack-recommendations/323/stackadvisor.out, 
error=/var/run/ambari-server/stack-recommendations/323/stackadvisor.err
20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:69 - 
Stack advisor output files
20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:70 - 
advisor script stdout: StackAdvisor implementation for stack HDP, version 
2.0.6 was loaded
StackAdvisor implementation for stack HDP, version 2.1 was loaded
StackAdvisor implementation for stack HDP, version 2.2 was loaded
StackAdvisor implementation for stack HDP, version 2.3 was loaded
StackAdvisor implementation for stack HDP, version 2.4 was loaded
Returning HDP24StackAdvisor implementation
Error occured in stack advisor.
Error details: 'NoneType' object is not iterable
20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:71 - 
advisor script stderr: Traceback (most recent call last):
  File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, 
in 
main(sys.argv)
  File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 109, 
in main
result = stackAdvisor.recommendConfigurations(services, hosts)
  File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", 
line 570, in recommendConfigurations
calculation(configurations, clusterSummary, services, hosts)
  File 
"/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py",
 line 627, in recommendAmsConfigurations
if set(amsCollectorHosts).intersection(dn_hosts):
TypeError: 'NoneType' object is not iterable
20 Apr 2016 16:03:56,918  INFO [qtp-ambari-client-2764] 
AbstractResourceProvider:802 - Caught an exception while updating host 
components, retrying : org.apache.ambari.server.AmbariException: Stack Advisor 
reported an error: TypeError: 'NoneType' object is not iterable
StdOut file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.out

StdErr file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.err
```


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 dca81c5 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
 84f0bac 

Diff: https://reviews.apache.org/r/46583/diff/


Testing
---

Manually tested using the UI and BP.

# Local test results: PENDING

# Jenkins test results: PENDING


Thanks,

Robert Levas

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

[Jayush Luniya]

> On April 20, 2016, 8:03 a.m., Jayush Luniya wrote:
> > Ship It!
> 
> Masahiro Tanaka wrote:
> Thank you, could you commit this?
> 
> Jayush Luniya wrote:
> Ok will commit today.

Committed. Can you please close the review?


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45676/#review129706
---


On April 22, 2016, 9:35 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45676/
> ---
> 
> (Updated April 22, 2016, 9:35 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, jun aoki, Jayush 
> Luniya, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-15678
> https://issues.apache.org/jira/browse/AMBARI-15678
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If yarn app state is not state or yarn app finalStatus is not succeeded, YARN 
> service check should fail.
> But in the YARN service_check.py, it doesn't fail because raise statement is 
> in try block and there is only `pass` in except block.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  e8d98ab 
> 
> Diff: https://reviews.apache.org/r/45676/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 46568: AMBARI-13349 Create a keytab for Ranger Service for performing Name Lookup to Components

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46568/#review130168
---


Ship it!




Ship It!

- Jayush Luniya


On April 22, 2016, 1:36 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46568/
> ---
> 
> (Updated April 22, 2016, 1:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Jonathan Hurley, Jayush Luniya, Robert Levas, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-13349
> https://issues.apache.org/jira/browse/AMBARI-13349
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add kerberos support to RANGER service for stack 2.5 onwards
> 
> Changes includes:
> 1) Create keytabs and principals for RANGER_ADMIN, RANGER_USERSYNC and 
> RANGER_TAGSYNC component.
> 2) Adding new alerts.json file for stack 2.5 which will use kerberos 
> principal and keytab for web type alert.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  36df2e8 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  2e9123f 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/alerts/alert_ranger_admin_passwd_check.py
>  ad95980 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  175115d 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  9f31983 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  f4bd028 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-admin-site.xml
>  d533dbc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-tagsync-site.xml
>  9ffc59f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-ugsync-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/kerberos.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46568/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger service with kerberos enabled for stack 2.5
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 46565: AMBARI-16035 Add support for Rolling and Express Upgrade for Ranger Tagsync

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46565/#review130167
---


Ship it!




Ship It!

- Jayush Luniya


On April 22, 2016, 10:51 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46565/
> ---
> 
> (Updated April 22, 2016, 10:51 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Jonathan Hurley, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16035
> https://issues.apache.org/jira/browse/AMBARI-16035
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> RANGER_TAGSYNC is a new SLAVE component for RANGER service which needs to be 
> included in the Rolling and Express Upgrades for stack 2.5 to 2.5 +
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  175115d 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py
>  e8effb8 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py
>  43ecd07 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  9f31983 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 4da21fa 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  0e1b30c 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 7a6e302 
> 
> Diff: https://reviews.apache.org/r/46565/diff/
> 
> 
> Testing
> ---
> 
> 1) Tested Upgrade for 2.5.x to 2.5.y with and without RANGER_TAGSYNC 
> component.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Alexander Denissov]

> On April 22, 2016, 6:15 p.m., Jayush Luniya wrote:
> >

So, what will be the rules for SA logic inheritance ?

When MYSERVICE/2.0.0 ships and needs to reuse the stack_advisor logic from 
MYSERVICE/1.0.0 -- will we:
- rely on stack inheritance ?
- rely on SA inheritance within MYSERVICE ?
- combination of these ?


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130141
---


On April 22, 2016, 6:27 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 22, 2016, 6:27 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush 
> Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a65541 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 6c9fd46 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> ---
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 46445: Refactor get_stack_to_component() method

[Jayush Luniya]

> On April 22, 2016, 6:27 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/script/script.py,
> >  line 155
> > 
> >
> > Should add "pass" for it to be a complete function

+1


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46445/#review130152
---


On April 20, 2016, 4:35 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46445/
> ---
> 
> (Updated April 20, 2016, 4:35 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-15609
> https://issues.apache.org/jira/browse/AMBARI-15609
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The original intention of the get_stack_to_component function was to have a 
> dictionary where the key was the stack name.
> At service level we always return the same key no matter what, then we should 
> just return the string with the component name and no need to check 
> params.stack_name
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 31d7b2a 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_client.py
>  ebfacf2 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py
>  1004d23 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
>  14a12d3 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  a5990a2 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
>  75b5de4 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
>  86bf3b6 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py
>  1bd99da 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
>  b72e648 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
>  5833773 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
>  37dd0a1 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py
>  7d639ec 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  ffaf4ea 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
>  9f62d29 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
>  ac73eaf 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  c8acae3 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py
>  ca2e3ef 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
>  4a6f144 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py
>  6c41fc2 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
>  6af0cd3 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
>  8adff0a 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
>  9ba8619 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  9d011a0 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
>  482f0be 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py
>  41074db 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py
>  aa5ce1f 
>   
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout_client.py
>  d39b66a 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
>  dc08f0b 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  c7107c9 
>   
> ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py
>  81db437 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.p

Re: Review Request 46445: Refactor get_stack_to_component() method

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46445/#review130163
---




ambari-common/src/main/python/resource_management/libraries/script/script.py 


+1


- Jayush Luniya


On April 20, 2016, 4:35 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46445/
> ---
> 
> (Updated April 20, 2016, 4:35 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-15609
> https://issues.apache.org/jira/browse/AMBARI-15609
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The original intention of the get_stack_to_component function was to have a 
> dictionary where the key was the stack name.
> At service level we always return the same key no matter what, then we should 
> just return the string with the component name and no need to check 
> params.stack_name
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 31d7b2a 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_client.py
>  ebfacf2 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py
>  1004d23 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
>  14a12d3 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  a5990a2 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
>  75b5de4 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
>  86bf3b6 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py
>  1bd99da 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
>  b72e648 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
>  5833773 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
>  37dd0a1 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py
>  7d639ec 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  ffaf4ea 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
>  9f62d29 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
>  ac73eaf 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  c8acae3 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py
>  ca2e3ef 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
>  4a6f144 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py
>  6c41fc2 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
>  6af0cd3 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
>  8adff0a 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
>  9ba8619 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  9d011a0 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
>  482f0be 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py
>  41074db 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py
>  aa5ce1f 
>   
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout_client.py
>  d39b66a 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
>  dc08f0b 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  c7107c9 
>   
> ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py
>  81db437 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  8e41c2c 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py
>  79316f9 
>   
> ambari-server/src/mai

Re: Review Request 46509: Remove performing service check during "Remove Standby Wizard"

[Alexander Denissov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46509/#review130162
---


Ship it!




Ship It!

- Alexander Denissov


On April 21, 2016, 11:01 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46509/
> ---
> 
> (Updated April 21, 2016, 11:01 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16024
> https://issues.apache.org/jira/browse/AMBARI-16024
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Users will need to remove the HAWQ Standby Master using "Remove Standby 
> Wizard" after enabling HDFS HA.
> So the service check may fail during the wizard as the HAWQ catalog might be 
> still pointing to the old filespace.
> 
> 
> Diffs
> -
> 
>   
> ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/step3_controller.js
>  5bcf34f 
> 
> Diff: https://reviews.apache.org/r/46509/diff/
> 
> 
> Testing
> ---
> 
> yes.
>   25660 tests complete (29 seconds)
>   154 tests pending
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 46.511 s
> [INFO] Finished at: 2016-04-21T16:03:11-07:00
> [INFO] Final Memory: 14M/331M
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Re: Review Request 46562: View Configuration Simplification

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46562/
---

(Updated April 22, 2016, 7:32 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Changes
---

Fixed test


Bugs: AMBARI-16037
https://issues.apache.org/jira/browse/AMBARI-16037


Repository: ambari


Description
---

Added view service definition which contains the service dependecy configs and 
related configuration required for services. Each view can define dependency on 
these services. 
Added Remote cluster definition where user will be able to configure it once 
and view instances can be linked to any one of them. Thus, the configurations 
will be created once and used multiple times.


Diffs (updated)
-

  ambari-admin/src/main/resources/ui/admin-web/app/index.html fa911a6 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js
 962b795 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/RemoteClusterInstanceCtrl.js
 PRE-CREATION 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/RemoteClusterListCtrl.js
 PRE-CREATION 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js
 d46a30f 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
e95ebdb 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js 4fc4ea6 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/RemoteCluster.js
 PRE-CREATION 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/View.js 
cbe11e4 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/create.html 
20ccadb 
  ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html 
b41abc8 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listClusters.html
 PRE-CREATION 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/viewClusters.html
 PRE-CREATION 
  ambari-admin/src/main/resources/ui/admin-web/app/views/leftNavbar.html 
9bc54ff 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 eed2703 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ViewClusterInstanceResourceDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ViewServiceResourceDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewClusterInstanceService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewServiceService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 dc53172 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
 c7dc117 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewClusterInstanceResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
 6523962 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewServiceResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewVersionResourceProvider.java
 1bf750b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 5a8476d 
  
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcher.java
 907588d 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewClusterConfigurationDao.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewServiceDAO.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewClusterConfigurationEntity.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewClusterConfigurationPropertyEntity.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewClusterConfigurationPropertyEntityPK.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewClusterServiceEntity.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewClusterServiceEntityPK.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java
 29dc2a7 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
 2555f93 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewParameterEntity.java
 5419d58 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/Vi

Re: Review Request 46475: Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46475/#review130159
---




ambari-web/app/messages.js (line 2842)


Message as "Invalid widget name. Only alphanumerics, underscores, hyphens, 
percentage and spaces are allowed."



ambari-web/app/messages.js (line 2844)


Message as "Invalid input. Only alphanumerics, underscores, hyphens, 
percentage and spaces are allowed."


- Di Li


On April 21, 2016, 10:51 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46475/
> ---
> 
> (Updated April 21, 2016, 10:51 p.m.)
> 
> 
> Review request for Ambari, Andrii Tkach and Di Li.
> 
> 
> Bugs: AMBARI-15979
> https://issues.apache.org/jira/browse/AMBARI-15979
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ISSUE:
> The UI validation at present checks only the length of the user input for 
> widget_name and description fields. All characters are allowed to be stored 
> in the database through them. A more strict UI validation that limits the 
> type of characters entered for these fields will provide a good first line of 
> defense. 
> 
> Steps to reproduce:
> 1. Make sure you have Ambari Metrics service installed on your cluster.
> 2. On the Dashboard, select any service that makes use of Ambari Metrics, say 
> HDFS.
> 3. In the "Metrics" section, click the "Actions" button in the top-right 
> corner, and select "Create a new widget" option from the drop-down. 
> (attachment: create_widget_button_location.tiff)
> 4. Create widget pop-up is displayed. 
> 5. On Step-1, select any type for the widget and click "Next". (attachment: 
> create_widget_step1.tiff)
> 6. On Step-2, select any valid metrics parameter and click "Next". 
> (attachment: create_widget_step2.tiff)
> 7. On Step-3, for widget_name and description fields, you can enter any 
> character. No validation is present to check the contents. The only 
> validation present checks the length of the input text. 
> (attachments:
> create_widget_step3.tiff, 
> original_characters_allowed_for_name_and_description.tiff,
> original_length_validation_for_name.tiff,
> original_length_validation_for_description.tiff )
> 
> 
> FIX:
> The UI validation is enhanced by checking the content of the input for name 
> and description.
> The patch attached allows only alphanumeric, underscore, hyphen, space and 
> percentage symbol to be valid characters for both fields.
> The % symbol is added as part of the white-list as there are existing widgets 
> that contain % symbols in their names. In order to keep the characters in the 
> name consistent, this was decided.
> The description could probably have a little more flexibility in terms of 
> characters allowed. Any suggestions to update this validation would be 
> helpful.
> The warning message template is also updated to conform to the existing norms 
> used in several Ambari pop-ups (e.g. Manage Config Groups, Manage Alert 
> Groups).
> 
> The images attached (starting with "fixed_") show how the fix appears with 
> the patch.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/widgets/create/step3_controller.js 
> dd7a93f 
>   ambari-web/app/messages.js 6c0049d 
>   ambari-web/app/templates/main/service/widgets/create/step3.hbs 9f431af 
>   
> ambari-web/test/controllers/main/service/widgets/create/step3_controller_test.js
>  6f92142 
> 
> Diff: https://reviews.apache.org/r/46475/diff/
> 
> 
> Testing
> ---
> 
> Tests are added that check the validate functions added for widget name and 
> description.
> Both widget name and description are tested for:
> 1. all valid characters
> 2. invalid characters
> 3. length of input
> 4. empty string
> 
> Ambari-Web tests with the patch:
> 25671 tests complete (33 seconds)
> 154 tests pending
> 
> 
> File Attachments
> 
> 
> AMBARI-15979-inlineError.patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/04/21/03bc972a-b076-4520-948b-3a204082eca0__AMBARI-15979-inlineError.patch
> AMBARI-15979-topError.patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/04/21/8b4e9a7b-96cb-4a17-9c9c-56e59b5fd349__AMBARI-15979-topError.patch
> 
> 
> Thanks,
> 
> Keta Patel
> 
>

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Tim Thorpe]

> On April 22, 2016, 6:15 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py,
> >  line 31
> > 
> >
> > Lets say we have 
> > common-services/MYSERVICE/1.0.0
> >   |__ service_advisor.py
> > common-services/MYSERVICE/2.0.0 (<- extends 
> > common-services/MYSERVICE/1.0.0)
> >   |__ service_advisor.py  
> > 
> > stacks/HDP/2.3/services/MYSERVICE (<- extends 
> > common-services/MYSERVICE/1.0.0)
> >   |__ service_advisor.py
> > 
> > stacks/HDP/2.5/services/MYSERVICE (<- extends 
> > common-services/MYSERVICE/2.0.0)
> >   |__ service_advisor.py
> >   
> > I believe we wont support any sort of inheritance between them? I am ok 
> > with keeping things simple right now but we should call out this limitation 
> > and that there could be certain duplication.
> 
> Jayush Luniya wrote:
> Sorry the formatting went off after publishing :(
> 
> Tim Thorpe wrote:
> Hi Jayush, you are right there won't be any automatic inheritance but I 
> don't think that's really a bad thing.  You can still have explicit 
> inheritance with code like this:
> 
> SCRIPT_DIR = os.path.dirname(os.path.abspath(__file__))
> PARENT_DIR = os.path.join(SCRIPT_DIR, '../../../2.2/services/YARN/')
> PARENT_FILE = os.path.join(PARENT_DIR, 'service_advisor.py')
> 
> try:
>   with open(PARENT_FILE, 'rb') as fp:
> service_advisor = imp.load_module('service_advisor', fp, PARENT_FILE, 
> ('.py', 'rb', imp.PY_SOURCE))
> except Exception as e:
>   traceback.print_exc()
>   print "Failed to load parent"
> 
> 
> class 
> HDP23MAPREDUCE2ServiceAdvisor(service_advisor.HDP22MAPREDUCE2ServiceAdvisor):
> 
> Jayush Luniya wrote:
> Lets just document this in the abstract service_advisor.py. Since stack 
> advisor supports such inheritance, just want to make sure that we call this 
> out and devs dont assume it will just work :)

I'll add that in when I do my documentation changes.


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130141
---


On April 22, 2016, 6:27 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 22, 2016, 6:27 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush 
> Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a65541 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Tim Thorpe]

> On April 22, 2016, 5:10 p.m., Srimanth Gunturi wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java,
> >  line 77
> > 
> >
> > Trying to think if we really need to expose the 'advisor_name' and 
> > 'advisor_path' in the stack-service API response? The files will be at 
> > known locations anyways and used when available... similar to the stack's 
> > advisor_path/advisor_name. 
> > 
> > I am thinking this can work without adding these 2 properties to a 
> > stack-service.
> 
> Tim Thorpe wrote:
> The reason this works for the stack is because the stack_advisor.py in 
> the scripts directory attempts to load all the stack_advisor.py files.  It 
> uses the stack name, stack version and parent versions to determine what to 
> load.  It starts with the oldest version and keeps loading until the most 
> recent version.  In order to do this for services, we'd need to know the some 
> sort of information to determine what to load from where.  I could have added 
> something similar so that it would look into the stack versions and then 
> somehow look to common services if that was required.  In my code I was 
> testing with HAWQ and PXF with their service advisor's being loaded from the 
> common-services directory.  It seemed much easier to me at least to get the 
> service_advisor.py location and calculate the advisor name in the java code 
> when reading the stack and services (StackManager/StackModule/StackDirectory 
> etc...).  This way I know exactly where to load the py file and exactly what 
> class name t
 o use.
> 
> Srimanth Gunturi wrote:
> Yes, I agree that it makes it easy to determine location of files. But if 
> you look at it from pure API perspective, it is not useful for any caller 
> except ambari-server - None of the callers have access to those paths/files 
> except ambari-server. It is ambari-server's internals exposed outside just 
> for its own consumption. Also, like the stack's service-advisor.py, the 
> service's files can be dynamically located and loaded.
> 
> If it is a question of efficiency, we can cache the result so that for a 
> stack-version's service we only determine this once.
> 
> My vote would be to not have these properties on the stack service's 
> response.

Instead of adding them to the stack service's response, I can inject it only 
for the stack advisor calls.  I'll work on making the change.


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130123
---


On April 22, 2016, 6:27 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 22, 2016, 6:27 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush 
> Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/s

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Jayush Luniya]

> On April 22, 2016, 6:15 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py,
> >  line 31
> > 
> >
> > Lets say we have 
> > common-services/MYSERVICE/1.0.0
> >   |__ service_advisor.py
> > common-services/MYSERVICE/2.0.0 (<- extends 
> > common-services/MYSERVICE/1.0.0)
> >   |__ service_advisor.py  
> > 
> > stacks/HDP/2.3/services/MYSERVICE (<- extends 
> > common-services/MYSERVICE/1.0.0)
> >   |__ service_advisor.py
> > 
> > stacks/HDP/2.5/services/MYSERVICE (<- extends 
> > common-services/MYSERVICE/2.0.0)
> >   |__ service_advisor.py
> >   
> > I believe we wont support any sort of inheritance between them? I am ok 
> > with keeping things simple right now but we should call out this limitation 
> > and that there could be certain duplication.
> 
> Jayush Luniya wrote:
> Sorry the formatting went off after publishing :(
> 
> Tim Thorpe wrote:
> Hi Jayush, you are right there won't be any automatic inheritance but I 
> don't think that's really a bad thing.  You can still have explicit 
> inheritance with code like this:
> 
> SCRIPT_DIR = os.path.dirname(os.path.abspath(__file__))
> PARENT_DIR = os.path.join(SCRIPT_DIR, '../../../2.2/services/YARN/')
> PARENT_FILE = os.path.join(PARENT_DIR, 'service_advisor.py')
> 
> try:
>   with open(PARENT_FILE, 'rb') as fp:
> service_advisor = imp.load_module('service_advisor', fp, PARENT_FILE, 
> ('.py', 'rb', imp.PY_SOURCE))
> except Exception as e:
>   traceback.print_exc()
>   print "Failed to load parent"
> 
> 
> class 
> HDP23MAPREDUCE2ServiceAdvisor(service_advisor.HDP22MAPREDUCE2ServiceAdvisor):

Lets just document this in the abstract service_advisor.py. Since stack advisor 
supports such inheritance, just want to make sure that we call this out and 
devs dont assume it will just work :)


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130141
---


On April 22, 2016, 6:27 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 22, 2016, 6:27 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush 
> Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a65541 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 
>   am

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Srimanth Gunturi]

> On April 22, 2016, 5:10 p.m., Srimanth Gunturi wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java,
> >  line 77
> > 
> >
> > Trying to think if we really need to expose the 'advisor_name' and 
> > 'advisor_path' in the stack-service API response? The files will be at 
> > known locations anyways and used when available... similar to the stack's 
> > advisor_path/advisor_name. 
> > 
> > I am thinking this can work without adding these 2 properties to a 
> > stack-service.
> 
> Tim Thorpe wrote:
> The reason this works for the stack is because the stack_advisor.py in 
> the scripts directory attempts to load all the stack_advisor.py files.  It 
> uses the stack name, stack version and parent versions to determine what to 
> load.  It starts with the oldest version and keeps loading until the most 
> recent version.  In order to do this for services, we'd need to know the some 
> sort of information to determine what to load from where.  I could have added 
> something similar so that it would look into the stack versions and then 
> somehow look to common services if that was required.  In my code I was 
> testing with HAWQ and PXF with their service advisor's being loaded from the 
> common-services directory.  It seemed much easier to me at least to get the 
> service_advisor.py location and calculate the advisor name in the java code 
> when reading the stack and services (StackManager/StackModule/StackDirectory 
> etc...).  This way I know exactly where to load the py file and exactly what 
> class name t
 o use.

Yes, I agree that it makes it easy to determine location of files. But if you 
look at it from pure API perspective, it is not useful for any caller except 
ambari-server - None of the callers have access to those paths/files except 
ambari-server. It is ambari-server's internals exposed outside just for its own 
consumption. Also, like the stack's service-advisor.py, the service's files can 
be dynamically located and loaded.

If it is a question of efficiency, we can cache the result so that for a 
stack-version's service we only determine this once.

My vote would be to not have these properties on the stack service's response.


- Srimanth


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130123
---


On April 22, 2016, 6:27 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 22, 2016, 6:27 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush 
> Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari

Re: Review Request 46445: Refactor get_stack_to_component() method

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46445/#review130152
---


Fix it, then Ship it!





ambari-common/src/main/python/resource_management/libraries/script/script.py 


Should add "pass" for it to be a complete function


- Alejandro Fernandez


On April 20, 2016, 4:35 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46445/
> ---
> 
> (Updated April 20, 2016, 4:35 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-15609
> https://issues.apache.org/jira/browse/AMBARI-15609
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The original intention of the get_stack_to_component function was to have a 
> dictionary where the key was the stack name.
> At service level we always return the same key no matter what, then we should 
> just return the string with the component name and no need to check 
> params.stack_name
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 31d7b2a 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_client.py
>  ebfacf2 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py
>  1004d23 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
>  14a12d3 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  a5990a2 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
>  75b5de4 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
>  86bf3b6 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py
>  1bd99da 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
>  b72e648 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
>  5833773 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
>  37dd0a1 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py
>  7d639ec 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  ffaf4ea 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
>  9f62d29 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
>  ac73eaf 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  c8acae3 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py
>  ca2e3ef 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
>  4a6f144 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py
>  6c41fc2 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
>  6af0cd3 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
>  8adff0a 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
>  9ba8619 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  9d011a0 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
>  482f0be 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py
>  41074db 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py
>  aa5ce1f 
>   
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout_client.py
>  d39b66a 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
>  dc08f0b 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  c7107c9 
>   
> ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py
>  81db437 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  8e41c2c 
>   
> ambari-server/src/main/resources/common-services/RANGER/0

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Tim Thorpe]

> On April 22, 2016, 6:15 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py,
> >  line 31
> > 
> >
> > Lets say we have 
> > common-services/MYSERVICE/1.0.0
> >   |__ service_advisor.py
> > common-services/MYSERVICE/2.0.0 (<- extends 
> > common-services/MYSERVICE/1.0.0)
> >   |__ service_advisor.py  
> > 
> > stacks/HDP/2.3/services/MYSERVICE (<- extends 
> > common-services/MYSERVICE/1.0.0)
> >   |__ service_advisor.py
> > 
> > stacks/HDP/2.5/services/MYSERVICE (<- extends 
> > common-services/MYSERVICE/2.0.0)
> >   |__ service_advisor.py
> >   
> > I believe we wont support any sort of inheritance between them? I am ok 
> > with keeping things simple right now but we should call out this limitation 
> > and that there could be certain duplication.
> 
> Jayush Luniya wrote:
> Sorry the formatting went off after publishing :(

Hi Jayush, you are right there won't be any automatic inheritance but I don't 
think that's really a bad thing.  You can still have explicit inheritance with 
code like this:

SCRIPT_DIR = os.path.dirname(os.path.abspath(__file__))
PARENT_DIR = os.path.join(SCRIPT_DIR, '../../../2.2/services/YARN/')
PARENT_FILE = os.path.join(PARENT_DIR, 'service_advisor.py')

try:
  with open(PARENT_FILE, 'rb') as fp:
service_advisor = imp.load_module('service_advisor', fp, PARENT_FILE, 
('.py', 'rb', imp.PY_SOURCE))
except Exception as e:
  traceback.print_exc()
  print "Failed to load parent"


class 
HDP23MAPREDUCE2ServiceAdvisor(service_advisor.HDP22MAPREDUCE2ServiceAdvisor):


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130141
---


On April 22, 2016, 4:39 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 22, 2016, 4:39 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Sumit Mohanty, Srimanth Gunturi, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a65541 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 6c9fd46 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> ---
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> 

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Tim Thorpe]

> On April 22, 2016, 5:58 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/stacks/stack_advisor.py, line 473
> > 
> >
> > I might be missing something, but it doesnt look like we are using 
> > getHostsForSlaveComponent

Yep I missed something in that patch, when I updated an older patch over some 
later code.  The createComponentLayoutRecommendations code should have the 
client/slave section like this:
for service in services["services"]:
  slaveClientComponents = [component for component in service["components"]
   if self.isSlaveComponent(component) or 
self.isClientComponent(component)]
  serviceAdvisor = self.createServiceAdvisor(service)
  for component in slaveClientComponents:
componentName = component["StackServiceComponents"]["component_name"]
hostsForComponent = []
if serviceAdvisor is None:
  hostsForComponent = self.getHostsForSlaveComponent(services, hosts, 
component, hostsList, hostsComponentsMap)
else:
  hostsForComponent = serviceAdvisor.getHostsForSlaveComponent(self, 
services, hosts, component, hostsList, hostsComponentsMap)


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130138
---


On April 22, 2016, 4:39 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 22, 2016, 4:39 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Sumit Mohanty, Srimanth Gunturi, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a65541 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 6c9fd46 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> ---
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Jayush Luniya]

> On April 22, 2016, 5:18 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py,
> >  line 19
> > 
> >
> > Please add Pivotal folks to the review to look at this. Also since the 
> > patch is a bit old, please verify and revise the patch to include any 
> > latest changes.
> 
> Tim Thorpe wrote:
> I will update the patch to the latest once I get all the feedback 
> including the Pivotal folks.  Otherwise, I'm going to be updating the patch 
> many times before I get to the point where it can be accept for commit.  Can 
> you please let me know who I should add from Pivotal?  Thanks

https://reviews.apache.org/users/bhuvnesh2703/
https://reviews.apache.org/users/adenissov/
https://reviews.apache.org/users/odiachenko/


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130126
---


On April 22, 2016, 4:39 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 22, 2016, 4:39 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Sumit Mohanty, Srimanth Gunturi, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a65541 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 6c9fd46 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> ---
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Jayush Luniya]

> On April 22, 2016, 5:33 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/stacks/stack_advisor.py, line 522
> > 
> >
> > loadServiceAdvisor() instead?
> 
> Tim Thorpe wrote:
> If I follow the tradition of the scripts/stack_advisor.py, I guess I 
> should call it def instantiateServiceAdvisor().  Any one of those names are 
> fine by me.  create or instantiate are more accurate names I think, because 
> it actually does both load the script and create an instance.

instantiateServiceAdvisor() is fine.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130131
---


On April 22, 2016, 4:39 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 22, 2016, 4:39 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Sumit Mohanty, Srimanth Gunturi, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a65541 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 6c9fd46 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> ---
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 46565: AMBARI-16035 Add support for Rolling and Express Upgrade for Ranger Tagsync

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46565/#review130148
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 22, 2016, 10:51 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46565/
> ---
> 
> (Updated April 22, 2016, 10:51 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Jonathan Hurley, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16035
> https://issues.apache.org/jira/browse/AMBARI-16035
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> RANGER_TAGSYNC is a new SLAVE component for RANGER service which needs to be 
> included in the Rolling and Express Upgrades for stack 2.5 to 2.5 +
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  175115d 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py
>  e8effb8 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py
>  43ecd07 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  9f31983 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 4da21fa 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  0e1b30c 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 7a6e302 
> 
> Diff: https://reviews.apache.org/r/46565/diff/
> 
> 
> Testing
> ---
> 
> 1) Tested Upgrade for 2.5.x to 2.5.y with and without RANGER_TAGSYNC 
> component.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 46434: DataNode and RegionServer during upgrade are reported as "failed" incorrectly

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46434/#review130144
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/upgrade.py
 (line 46)


Can we change the sleep time to 30 and retries to 20?


- Alejandro Fernandez


On April 22, 2016, 12:42 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46434/
> ---
> 
> (Updated April 22, 2016, 12:42 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Miklos Gergely, Oliver Szabo, 
> Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-15991
> https://issues.apache.org/jira/browse/AMBARI-15991
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If upgrade process takes longer than expected, DataNode and RegionServer is 
> reported as failed. It happens because it needs more time to finish update.
> 
> The fix for RegionServer checks if the process is running and if it is so, 
> then it is not considered as a failure.
> For DataNode the process is also checked and if it is running then check is 
> repeated 2 times with 5 minutes wait. I had a limitation here, python scripts 
> are allowed to run for 20 minutes by default and this checking takes 16 mins 
> (2 minutes initial check, 5 minutes sleep if there is a failure, 2 minutes 
> regaular check, 5 minutes sleep, 2 minutes final check).
> If more time is needed, then default value of *server.task.timeout* and 
> number of repetition in 5 minutes check should be increased.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/upgrade.py
>  01a8156 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode_upgrade.py
>  8f36001 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  7ad9f39 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 
> 8d187ec 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 78b8171 
> 
> Diff: https://reviews.apache.org/r/46434/diff/
> 
> 
> Testing
> ---
> 
> I did manual testing on this:
> For RegionServer the process check is tested.
> For DataNodes I made an intentional exception to see if it keeps waiting. 
> (this is how I ran into the 20 minutes server task timeout)
> 
> --
> Total run:970
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 46484: Enhance Health Check for the Cluster before upgrading.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46484/#review130145
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 21, 2016, 11:14 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46484/
> ---
> 
> (Updated April 21, 2016, 11:14 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan 
> Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-16005
> https://issues.apache.org/jira/browse/AMBARI-16005
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enhance Health Check for the Cluster before upgrading.
> 
> * check for alerts (perhaps don't start RU/EU if any blocker alerts).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  3e957b1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java 
> PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/HealthCheckTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46484/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Jayush Luniya]

> On April 22, 2016, 6:15 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py,
> >  line 31
> > 
> >
> > Lets say we have 
> > common-services/MYSERVICE/1.0.0
> >   |__ service_advisor.py
> > common-services/MYSERVICE/2.0.0 (<- extends 
> > common-services/MYSERVICE/1.0.0)
> >   |__ service_advisor.py  
> > 
> > stacks/HDP/2.3/services/MYSERVICE (<- extends 
> > common-services/MYSERVICE/1.0.0)
> >   |__ service_advisor.py
> > 
> > stacks/HDP/2.5/services/MYSERVICE (<- extends 
> > common-services/MYSERVICE/2.0.0)
> >   |__ service_advisor.py
> >   
> > I believe we wont support any sort of inheritance between them? I am ok 
> > with keeping things simple right now but we should call out this limitation 
> > and that there could be certain duplication.

Sorry the formatting went off after publishing :(


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130141
---


On April 22, 2016, 4:39 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 22, 2016, 4:39 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Sumit Mohanty, Srimanth Gunturi, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a65541 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 6c9fd46 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> ---
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130141
---




ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
(line 31)


Lets say we have 
common-services/MYSERVICE/1.0.0
  |__ service_advisor.py
common-services/MYSERVICE/2.0.0 (<- extends common-services/MYSERVICE/1.0.0)
  |__ service_advisor.py  

stacks/HDP/2.3/services/MYSERVICE (<- extends 
common-services/MYSERVICE/1.0.0)
  |__ service_advisor.py

stacks/HDP/2.5/services/MYSERVICE (<- extends 
common-services/MYSERVICE/2.0.0)
  |__ service_advisor.py
  
I believe we wont support any sort of inheritance between them? I am ok 
with keeping things simple right now but we should call out this limitation and 
that there could be certain duplication.


- Jayush Luniya


On April 22, 2016, 4:39 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 22, 2016, 4:39 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Sumit Mohanty, Srimanth Gunturi, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a65541 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 6c9fd46 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> ---
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46152/
---

(Updated April 22, 2016, 6:02 p.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert 
Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Changes
---

- updated python tests


Bugs: AMBARI-15865
https://issues.apache.org/jira/browse/AMBARI-15865


Repository: ambari


Description
---

Create a small ambari solr client (and rpm/deb), for logsearch solr.
The goal is the create a client which can be used for another services to 
access zookeeper/solr and create their own collections in logsearch solr. (e.g. 
for ATLAS or RANGER)


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
 1544ffe 
  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/control
 b853f13 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/postinst
 21a01fa 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/postrm 
21a01fa 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/posttrm
 21a01fa 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/preinst
 21a01fa 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/prerm 
21a01fa 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientException.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractRetryCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractSolrRetryCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractZookeeperRetryCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CheckConfigZkCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateShardCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/DownloadConfigZkCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/GetShardsCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/ListCollectionCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/UploadConfigZkCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/util/ShardUtils.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/log4j.properties
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCloudCli.sh
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java
 PRE-CREATION 
  ambari-logsearch/pom.xml 475de9f 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
 93311fb 
  
ambari-server/src/main/re

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130138
---




ambari-server/src/main/resources/stacks/stack_advisor.py (line 458)


I might be missing something, but it doesnt look like we are using 
getHostsForSlaveComponent


- Jayush Luniya


On April 22, 2016, 4:39 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 22, 2016, 4:39 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Sumit Mohanty, Srimanth Gunturi, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a65541 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 6c9fd46 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> ---
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Tim Thorpe]

> On April 22, 2016, 5:33 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/stacks/stack_advisor.py, line 522
> > 
> >
> > loadServiceAdvisor() instead?

If I follow the tradition of the scripts/stack_advisor.py, I guess I should 
call it def instantiateServiceAdvisor().  Any one of those names are fine by 
me.  create or instantiate are more accurate names I think, because it actually 
does both load the script and create an instance.


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130131
---


On April 22, 2016, 4:39 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 22, 2016, 4:39 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Sumit Mohanty, Srimanth Gunturi, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a65541 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 6c9fd46 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> ---
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

[Zhe (Joe) Wang]

> On April 22, 2016, 5:30 p.m., Alexandr Antonenko wrote:
> > if we will ask BE and create task for them, this will mean move this out of 
> > 2.4. As BE is pretty heavy loaded with tasks

Agree. That's why I use FE to set the initial value.


- Zhe (Joe)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46405/#review130129
---


On April 21, 2016, 6:50 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46405/
> ---
> 
> (Updated April 21, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Jaimin Jetly, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15519
> https://issues.apache.org/jira/browse/AMBARI-15519
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the cluster where some nodes are in the maintenance mode Add Service 
> Wizard doesn't track this.
> So, user may select host in the maintenance mode to install some master 
> component. And this component won't be installed (only record in the DB will 
> be created for it).
> Another situation:
> there is some cluster where all nodes are in the maintenance mode. In this 
> case ASW is almost useless. Because all new components won't be installed 
> while it works.
> 
> ASW should track hosts in the maintenance mode and warn user about adding 
> components on them (Steps "Assign Masters", "Assign Slaves and Clients").
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard.js 52fb241 
>   ambari-web/app/mixins/wizard/assign_master_components.js e4c5295 
> 
> Diff: https://reviews.apache.org/r/46405/diff/
> 
> 
> Testing
> ---
> 
> Modified unit test.
> Local ambari-web test passed.
> 25680 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Tim Thorpe]

> On April 22, 2016, 5:10 p.m., Srimanth Gunturi wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java,
> >  line 77
> > 
> >
> > Trying to think if we really need to expose the 'advisor_name' and 
> > 'advisor_path' in the stack-service API response? The files will be at 
> > known locations anyways and used when available... similar to the stack's 
> > advisor_path/advisor_name. 
> > 
> > I am thinking this can work without adding these 2 properties to a 
> > stack-service.

The reason this works for the stack is because the stack_advisor.py in the 
scripts directory attempts to load all the stack_advisor.py files.  It uses the 
stack name, stack version and parent versions to determine what to load.  It 
starts with the oldest version and keeps loading until the most recent version. 
 In order to do this for services, we'd need to know the some sort of 
information to determine what to load from where.  I could have added something 
similar so that it would look into the stack versions and then somehow look to 
common services if that was required.  In my code I was testing with HAWQ and 
PXF with their service advisor's being loaded from the common-services 
directory.  It seemed much easier to me at least to get the service_advisor.py 
location and calculate the advisor name in the java code when reading the stack 
and services (StackManager/StackModule/StackDirectory etc...).  This way I know 
exactly where to load the py file and exactly what class name to use.


> On April 22, 2016, 5:10 p.m., Srimanth Gunturi wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java,
> >  line 88
> > 
> >
> > I think we can make this work without adding new properties to 
> > stack-service resource.

see my comment above.


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130123
---


On April 22, 2016, 4:39 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 22, 2016, 4:39 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Sumit Mohanty, Srimanth Gunturi, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a65541 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 
>   ambari-server/src/test/python/stacks/2.3/common/te

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Tim Thorpe]

> On April 22, 2016, 5:18 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py,
> >  line 19
> > 
> >
> > Please add Pivotal folks to the review to look at this. Also since the 
> > patch is a bit old, please verify and revise the patch to include any 
> > latest changes.

I will update the patch to the latest once I get all the feedback including the 
Pivotal folks.  Otherwise, I'm going to be updating the patch many times before 
I get to the point where it can be accept for commit.  Can you please let me 
know who I should add from Pivotal?  Thanks


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130126
---


On April 22, 2016, 4:39 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 22, 2016, 4:39 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Sumit Mohanty, Srimanth Gunturi, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a65541 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 6c9fd46 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> ---
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Tim Thorpe]

> On April 22, 2016, 5:15 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/stacks/service_advisor.py, line 24
> > 
> >
> > Add documentation for all functions here.

I will make sure I document all the functions in the service advisor.


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130124
---


On April 22, 2016, 4:39 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 22, 2016, 4:39 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Sumit Mohanty, Srimanth Gunturi, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a65541 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 6c9fd46 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> ---
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130131
---




ambari-server/src/main/resources/stacks/stack_advisor.py (line 507)


loadServiceAdvisor() instead?


- Jayush Luniya


On April 22, 2016, 4:39 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 22, 2016, 4:39 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Sumit Mohanty, Srimanth Gunturi, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a65541 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 6c9fd46 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> ---
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46405/#review130129
---



if we will ask BE and create task for them, this will mean move this out of 
2.4. As BE is pretty heavy loaded with tasks

- Alexandr Antonenko


On April 21, 2016, 6:50 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46405/
> ---
> 
> (Updated April 21, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Jaimin Jetly, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15519
> https://issues.apache.org/jira/browse/AMBARI-15519
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the cluster where some nodes are in the maintenance mode Add Service 
> Wizard doesn't track this.
> So, user may select host in the maintenance mode to install some master 
> component. And this component won't be installed (only record in the DB will 
> be created for it).
> Another situation:
> there is some cluster where all nodes are in the maintenance mode. In this 
> case ASW is almost useless. Because all new components won't be installed 
> while it works.
> 
> ASW should track hosts in the maintenance mode and warn user about adding 
> components on them (Steps "Assign Masters", "Assign Slaves and Clients").
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard.js 52fb241 
>   ambari-web/app/mixins/wizard/assign_master_components.js e4c5295 
> 
> Diff: https://reviews.apache.org/r/46405/diff/
> 
> 
> Testing
> ---
> 
> Modified unit test.
> Local ambari-web test passed.
> 25680 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130126
---




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
(line 19)


Please add Pivotal folks to the review to look at this. Also since the 
patch is a bit old, please verify and revise the patch to include any latest 
changes.


- Jayush Luniya


On April 22, 2016, 4:39 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 22, 2016, 4:39 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Sumit Mohanty, Srimanth Gunturi, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a65541 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 6c9fd46 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> ---
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130124
---




ambari-server/src/main/resources/stacks/service_advisor.py (line 24)


Add documentation for all functions here.


- Jayush Luniya


On April 22, 2016, 4:39 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 22, 2016, 4:39 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Sumit Mohanty, Srimanth Gunturi, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a65541 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 6c9fd46 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> ---
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Srimanth Gunturi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130123
---




ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
 (line 77)


Trying to think if we really need to expose the 'advisor_name' and 
'advisor_path' in the stack-service API response? The files will be at known 
locations anyways and used when available... similar to the stack's 
advisor_path/advisor_name. 

I am thinking this can work without adding these 2 properties to a 
stack-service.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
 (line 88)


I think we can make this work without adding new properties to 
stack-service resource.


- Srimanth Gunturi


On April 22, 2016, 4:39 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 22, 2016, 4:39 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Sumit Mohanty, Srimanth Gunturi, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a65541 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 6c9fd46 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> ---
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

[Zhe (Joe) Wang]

> On April 22, 2016, 4 p.m., Andrii Tkach wrote:
> > ambari-web/app/controllers/wizard.js, line 749
> > 
> >
> > I don't think that's good approach to set maintenance_state to not 
> > installed hosts, it may cause confusion in the future.

1. Well, maintenance_state is OFF means that the host is not in maintainance, 
which is technically true in installation scenario.
2. We could, of course, ask BE to send the maintainance_state, while they are 
sending other properties (i.e. cpu, memory, os_type).
3. However, since we know that BE will always send maintenance_state: "OFF" 
during the installation, I think we could set it directly without create 
another BE JIRA to ask them to provide it.
4. After all, this tempprary model will be discarded after the installation. 
And it's quite safe to say, the host will remain the maintenance_state to be 
OFF during the installation.


- Zhe (Joe)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46405/#review130109
---


On April 21, 2016, 6:50 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46405/
> ---
> 
> (Updated April 21, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Jaimin Jetly, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15519
> https://issues.apache.org/jira/browse/AMBARI-15519
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the cluster where some nodes are in the maintenance mode Add Service 
> Wizard doesn't track this.
> So, user may select host in the maintenance mode to install some master 
> component. And this component won't be installed (only record in the DB will 
> be created for it).
> Another situation:
> there is some cluster where all nodes are in the maintenance mode. In this 
> case ASW is almost useless. Because all new components won't be installed 
> while it works.
> 
> ASW should track hosts in the maintenance mode and warn user about adding 
> components on them (Steps "Assign Masters", "Assign Slaves and Clients").
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard.js 52fb241 
>   ambari-web/app/mixins/wizard/assign_master_components.js e4c5295 
> 
> Diff: https://reviews.apache.org/r/46405/diff/
> 
> 
> Testing
> ---
> 
> Modified unit test.
> Local ambari-web test passed.
> 25680 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 46544: AMBARI-16028: Namenode marked as INITIAL standby could potentially never start if other namenode is down

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46544/#review130117
---


Ship it!




Ship It!

- Robert Nettleton


On April 21, 2016, 10:24 p.m., Jayush Luniya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46544/
> ---
> 
> (Updated April 21, 2016, 10:24 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Robert Nettleton, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16028
> https://issues.apache.org/jira/browse/AMBARI-16028
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. During Namenode HA blueprint deployment, we configure the name nodes to 
> start in active/standby mode based on the following properties
>  {
> "hadoop-env": {
>   "properties" : {
> "dfs_ha_initial_namenode_active" : "host1",
> "dfs_ha_initial_namenode_standby" : "host2”
>   }
> }
>   }
> 2. The current logic is to always bootstrap the name node marked as standby.
> 3. This will lead to the Namenode marked as Standby to never start under the 
> following situation
> 
> - Cluster is deployed successfully
> - Both name nodes are stopped
> - Start the name node marked as standby. Namenode will never start.
> - This is because the standby name node will try to bootstrap again.
> - However to bootstrap a name node an active name node is required. Based on 
> the HDFS logic the first step done when bootstrapping is to connect to the 
> Active Namenode.
> - Also there is no need to bootstrap here as the name node should already be 
> bootstrapped and should come back up as “Active"
> 
> 
> Fix:
> - The fix is to maintain a bootstrap marker file (similar to the way we keep 
> a name node formatted marker file)
> - In the INITIAL_START phase (during cluster deployment) we will always force 
> bootstrap so as to enforce the name node marked as Standby to wait for the 
> Active name node to come up, bootstrap and start in STANDBY node.
> - Once we are out of INITIAL_START phase, we will bootstrap only if this name 
> node has not been bootstrapped in the past.
> - We will not enforce bootstrapping only in the INITIAL_START phase because 
> there is a possibility during cluster deployment that both name nodes don’t 
> start and hence bootstrapping out of INITIAL_START phase would be required in 
> this case.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
>  8b6c924 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  d8ff3c5 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 1c08d57 
> 
> Diff: https://reviews.apache.org/r/46544/diff/
> 
> 
> Testing
> ---
> 
> Verified scenarios on live cluster.
> 
> mvn clean test -DskipSurefireTests
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 54.784s
> [INFO] Finished at: Thu Apr 21 15:22:52 PDT 2016
> [INFO] Final Memory: 64M/1172M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jayush Luniya
> 
>

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/
---

(Updated April 22, 2016, 4:39 p.m.)


Review request for Ambari, Jayush Luniya, Sumit Mohanty, Srimanth Gunturi, and 
Yusaku Sako.


Bugs: AMBARI-15226
https://issues.apache.org/jira/browse/AMBARI-15226


Repository: ambari


Description
---

Currently the stack advisor is defined under each stack version such as 
HDP/2.3. The problem with this is that it restricts the services that can be 
added to the stack. If a custom service is to be added, they would need to 
modify the stack advisor. If the configuration recommendation and validation 
can be done at the service level then the custom service could just include 
their own recommendations and validations separately.


Diffs (updated)
-

  ambari-server/src/main/assemblies/server.xml e1a4919 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 df65010 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
 00c8696 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
 ca1968e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
 6c6fa91 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
 636de37 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
 d574d60 
  ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
b7e09a9 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
 d27e52a 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
db95fec 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
PRE-CREATION 
  ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
PRE-CREATION 
  ambari-server/src/main/resources/properties.json eac0dbd 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
0130483 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
3a65541 
  ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 
  ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 6c9fd46 

Diff: https://reviews.apache.org/r/44210/diff/


Testing
---

Ran all the non java unit tests.  

Total run:945
Total errors:0
Total failures:0

Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
their service advisors were called.


Thanks,

Tim Thorpe

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46405/#review130111
---




ambari-web/app/mixins/wizard/assign_master_components.js (line 979)


We can check that maintenance_state is OFF, only when host has this 
property.


- Andrii Tkach


On April 21, 2016, 6:50 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46405/
> ---
> 
> (Updated April 21, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Jaimin Jetly, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15519
> https://issues.apache.org/jira/browse/AMBARI-15519
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the cluster where some nodes are in the maintenance mode Add Service 
> Wizard doesn't track this.
> So, user may select host in the maintenance mode to install some master 
> component. And this component won't be installed (only record in the DB will 
> be created for it).
> Another situation:
> there is some cluster where all nodes are in the maintenance mode. In this 
> case ASW is almost useless. Because all new components won't be installed 
> while it works.
> 
> ASW should track hosts in the maintenance mode and warn user about adding 
> components on them (Steps "Assign Masters", "Assign Slaves and Clients").
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard.js 52fb241 
>   ambari-web/app/mixins/wizard/assign_master_components.js e4c5295 
> 
> Diff: https://reviews.apache.org/r/46405/diff/
> 
> 
> Testing
> ---
> 
> Modified unit test.
> Local ambari-web test passed.
> 25680 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 46571: Add ability to log .out files into the agent log

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46571/#review130110
---


Ship it!




nice feature

- Alejandro Fernandez


On April 22, 2016, 2:21 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46571/
> ---
> 
> (Updated April 22, 2016, 2:21 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16042
> https://issues.apache.org/jira/browse/AMBARI-16042
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We need an ability to obtain out files content (pre-start) in task logs. 
> Which later can be piped to /var/log/syslog.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 8b5de40 
>   ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 
> 4ea2c7c 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/show_logs.py
>  bb2e12c 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 193138b 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py
>  e210a11 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
>  533d3ec 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py
>  d98384b 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  ae760cb 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
>  d4935fe 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py
>  cf8d864 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
>  4b4a876 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
>  4efa739 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py
>  93816e3 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  1e0c605 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
>  9929b02 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  bb6f1ca 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py
>  65cc4fb 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
>  c8ec843 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
>  3558681 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
>  ee82e79 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
>  bea00ed 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  fe05ff6 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
>  6924040 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py
>  5f22bba 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py
>  0a37161 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  31cf9e9 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  66ae76e 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py
>  43ecd07 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py
>  2382d9c 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py
>  e13affc 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py
>  7a7f086 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_thrift_server.py
>  f3742be 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/drpc_server.py
>  acd7529 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py
>  296b78f 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus_prod.py
> 

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46405/#review130109
---




ambari-web/app/controllers/wizard.js (line 749)


I don't think that's good approach to set maintenance_state to not 
installed hosts, it may cause confusion in the future.


- Andrii Tkach


On April 21, 2016, 6:50 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46405/
> ---
> 
> (Updated April 21, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Jaimin Jetly, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15519
> https://issues.apache.org/jira/browse/AMBARI-15519
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the cluster where some nodes are in the maintenance mode Add Service 
> Wizard doesn't track this.
> So, user may select host in the maintenance mode to install some master 
> component. And this component won't be installed (only record in the DB will 
> be created for it).
> Another situation:
> there is some cluster where all nodes are in the maintenance mode. In this 
> case ASW is almost useless. Because all new components won't be installed 
> while it works.
> 
> ASW should track hosts in the maintenance mode and warn user about adding 
> components on them (Steps "Assign Masters", "Assign Slaves and Clients").
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard.js 52fb241 
>   ambari-web/app/mixins/wizard/assign_master_components.js e4c5295 
> 
> Diff: https://reviews.apache.org/r/46405/diff/
> 
> 
> Testing
> ---
> 
> Modified unit test.
> Local ambari-web test passed.
> 25680 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46152/
---

(Updated April 22, 2016, 3:07 p.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert 
Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Changes
---

- added "add shard" command (and add shard during create collection if needed) 
and check configuration does exist in zookeeper or not
- added solr_cloud_util for ambari-commons -> to use solrCloudCli from stack 
definitions
- added logsearch solr client for logsearch service definition
- removed appender from rpm/deb build (its enough to use it as a dependency)


Bugs: AMBARI-15865
https://issues.apache.org/jira/browse/AMBARI-15865


Repository: ambari


Description
---

Create a small ambari solr client (and rpm/deb), for logsearch solr.
The goal is the create a client which can be used for another services to 
access zookeeper/solr and create their own collections in logsearch solr. (e.g. 
for ATLAS or RANGER)


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
 1544ffe 
  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/control
 b853f13 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/postinst
 21a01fa 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/postrm 
21a01fa 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/posttrm
 21a01fa 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/preinst
 21a01fa 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/prerm 
21a01fa 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientException.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractRetryCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractSolrRetryCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractZookeeperRetryCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CheckConfigZkCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateShardCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/DownloadConfigZkCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/GetShardsCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/ListCollectionCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/UploadConfigZkCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/util/ShardUtils.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/log4j.properties
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrC

Re: Review Request 46571: Add ability to log .out files into the agent log

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46571/#review130093
---


Ship it!




Ship It!

- Dmytro Sen


On Апрель 22, 2016, 2:21 п.п., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46571/
> ---
> 
> (Updated Апрель 22, 2016, 2:21 п.п.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16042
> https://issues.apache.org/jira/browse/AMBARI-16042
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We need an ability to obtain out files content (pre-start) in task logs. 
> Which later can be piped to /var/log/syslog.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 8b5de40 
>   ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 
> 4ea2c7c 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/show_logs.py
>  bb2e12c 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 193138b 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py
>  e210a11 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
>  533d3ec 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py
>  d98384b 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  ae760cb 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
>  d4935fe 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py
>  cf8d864 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
>  4b4a876 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
>  4efa739 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py
>  93816e3 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  1e0c605 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
>  9929b02 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  bb6f1ca 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py
>  65cc4fb 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
>  c8ec843 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
>  3558681 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
>  ee82e79 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
>  bea00ed 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  fe05ff6 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
>  6924040 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py
>  5f22bba 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py
>  0a37161 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  31cf9e9 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  66ae76e 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py
>  43ecd07 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py
>  2382d9c 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py
>  e13affc 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py
>  7a7f086 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_thrift_server.py
>  f3742be 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/drpc_server.py
>  acd7529 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py
>  296b78f 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus_prod.py
>  108b8c1 
>

Re: Review Request 46571: Add ability to log .out files into the agent log

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46571/#review130092
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On April 22, 2016, 5:21 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46571/
> ---
> 
> (Updated April 22, 2016, 5:21 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16042
> https://issues.apache.org/jira/browse/AMBARI-16042
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We need an ability to obtain out files content (pre-start) in task logs. 
> Which later can be piped to /var/log/syslog.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 8b5de40 
>   ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 
> 4ea2c7c 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/show_logs.py
>  bb2e12c 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 193138b 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py
>  e210a11 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
>  533d3ec 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py
>  d98384b 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  ae760cb 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
>  d4935fe 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py
>  cf8d864 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
>  4b4a876 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
>  4efa739 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py
>  93816e3 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  1e0c605 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
>  9929b02 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  bb6f1ca 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py
>  65cc4fb 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
>  c8ec843 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
>  3558681 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
>  ee82e79 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
>  bea00ed 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  fe05ff6 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
>  6924040 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py
>  5f22bba 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py
>  0a37161 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  31cf9e9 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  66ae76e 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py
>  43ecd07 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py
>  2382d9c 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py
>  e13affc 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py
>  7a7f086 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_thrift_server.py
>  f3742be 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/drpc_server.py
>  acd7529 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py
>  296b78f 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus_prod.py
>  108b

Re: Review Request 46571: Add ability to log .out files into the agent log

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46571/
---

(Updated April 22, 2016, 2:20 p.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-16042
https://issues.apache.org/jira/browse/AMBARI-16042


Repository: ambari


Description (updated)
---

We need an ability to obtain out files content (pre-start) in task logs. Which 
later can be piped to /var/log/syslog.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
8b5de40 
  ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 
4ea2c7c 
  
ambari-common/src/main/python/resource_management/libraries/functions/show_logs.py
 bb2e12c 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 
193138b 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py
 e210a11 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
 533d3ec 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py
 d98384b 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
 ae760cb 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
 d4935fe 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py
 cf8d864 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
 4b4a876 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
 4efa739 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py
 93816e3 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
 1e0c605 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
 9929b02 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
 bb6f1ca 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py
 65cc4fb 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
 c8ec843 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 3558681 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
 ee82e79 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
 bea00ed 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 fe05ff6 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
 6924040 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py
 5f22bba 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py
 0a37161 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
 31cf9e9 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
 66ae76e 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py
 43ecd07 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py
 2382d9c 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py
 e13affc 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py
 7a7f086 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_thrift_server.py
 f3742be 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/drpc_server.py
 acd7529 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py
 296b78f 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus_prod.py
 108b8c1 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py
 db921cb 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py
 c1a0f04 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py
 0577e4b 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/ui_server.py
 b7fec9b 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
 3b4d134 
  
ambari-server/src/main/resources/common-serv

Review Request 46571: Add ability to log .out files into the agent log

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46571/
---

Review request for Ambari and Alejandro Fernandez.


Bugs: AMBARI-16042
https://issues.apache.org/jira/browse/AMBARI-16042


Repository: ambari


Description
---


Diffs
-

  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
8b5de40 
  ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 
4ea2c7c 
  
ambari-common/src/main/python/resource_management/libraries/functions/show_logs.py
 bb2e12c 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 
193138b 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py
 e210a11 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
 533d3ec 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py
 d98384b 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
 ae760cb 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
 d4935fe 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py
 cf8d864 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
 4b4a876 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
 4efa739 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py
 93816e3 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
 1e0c605 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
 9929b02 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
 bb6f1ca 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py
 65cc4fb 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
 c8ec843 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 3558681 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
 ee82e79 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
 bea00ed 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 fe05ff6 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
 6924040 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py
 5f22bba 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py
 0a37161 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
 31cf9e9 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
 66ae76e 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py
 43ecd07 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py
 2382d9c 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py
 e13affc 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py
 7a7f086 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_thrift_server.py
 f3742be 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/drpc_server.py
 acd7529 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py
 296b78f 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus_prod.py
 108b8c1 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py
 db921cb 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py
 c1a0f04 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py
 0577e4b 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/ui_server.py
 b7fec9b 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
 3b4d134 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py
 9b8c5c0 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
 6837c27 
  
ambari-se

Re: Review Request 46568: AMBARI-13349 Create a keytab for Ranger Service for performing Name Lookup to Components

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46568/#review130091
---


Ship it!





ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-admin-site.xml
 (lines 72 - 79)


It may not be necessary to add the kerberos princial and keytab properties 
to this file.  The properites will be added when kerberos is enabled.

If they exist in this file then when kerberos is disabled, they wont be 
removed, they will be set to the empty string.  Either is ok, I just wanted you 
to be aware of this.


- Robert Levas


On April 22, 2016, 9:36 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46568/
> ---
> 
> (Updated April 22, 2016, 9:36 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Jonathan Hurley, Jayush Luniya, Robert Levas, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-13349
> https://issues.apache.org/jira/browse/AMBARI-13349
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add kerberos support to RANGER service for stack 2.5 onwards
> 
> Changes includes:
> 1) Create keytabs and principals for RANGER_ADMIN, RANGER_USERSYNC and 
> RANGER_TAGSYNC component.
> 2) Adding new alerts.json file for stack 2.5 which will use kerberos 
> principal and keytab for web type alert.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  36df2e8 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  2e9123f 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/alerts/alert_ranger_admin_passwd_check.py
>  ad95980 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  175115d 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  9f31983 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  f4bd028 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-admin-site.xml
>  d533dbc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-tagsync-site.xml
>  9ffc59f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-ugsync-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/kerberos.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46568/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger service with kerberos enabled for stack 2.5
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Review Request 46568: AMBARI-13349 Create a keytab for Ranger Service for performing Name Lookup to Components

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46568/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
Jonathan Hurley, Jayush Luniya, Robert Levas, and Velmurugan Periasamy.


Bugs: AMBARI-13349
https://issues.apache.org/jira/browse/AMBARI-13349


Repository: ambari


Description
---

Add kerberos support to RANGER service for stack 2.5 onwards

Changes includes:
1) Create keytabs and principals for RANGER_ADMIN, RANGER_USERSYNC and 
RANGER_TAGSYNC component.
2) Adding new alerts.json file for stack 2.5 which will use kerberos principal 
and keytab for web type alert.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 36df2e8 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 2e9123f 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/alerts/alert_ranger_admin_passwd_check.py
 ad95980 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 175115d 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 9f31983 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 f4bd028 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/alerts.json 
PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-admin-site.xml
 d533dbc 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-tagsync-site.xml
 9ffc59f 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-ugsync-site.xml
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/kerberos.json 
PRE-CREATION 

Diff: https://reviews.apache.org/r/46568/diff/


Testing
---

Tested Ranger service with kerberos enabled for stack 2.5


Thanks,

Mugdha Varadkar

Re: Review Request 46562: View Configuration Simplification

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46562/#review130087
---



Before anyone tries to review this code, is there a feature branch where this 
work is being developed? Trying to review 4 pages of diffs is extremely 
cumbersome and prone to errors. This scope of work really needs to be put into 
a feature branch with individual Jira commits.

- Jonathan Hurley


On April 22, 2016, 8:23 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46562/
> ---
> 
> (Updated April 22, 2016, 8:23 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16037
> https://issues.apache.org/jira/browse/AMBARI-16037
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added view service definition which contains the service dependecy configs 
> and related configuration required for services. Each view can define 
> dependency on these services. 
> Added Remote cluster definition where user will be able to configure it once 
> and view instances can be linked to any one of them. Thus, the configurations 
> will be created once and used multiple times.
> 
> 
> Diffs
> -
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/index.html fa911a6 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js
>  962b795 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/RemoteClusterInstanceCtrl.js
>  PRE-CREATION 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/RemoteClusterListCtrl.js
>  PRE-CREATION 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js
>  d46a30f 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
> e95ebdb 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js 4fc4ea6 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/RemoteCluster.js
>  PRE-CREATION 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/View.js 
> cbe11e4 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/create.html
>  20ccadb 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html 
> b41abc8 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listClusters.html
>  PRE-CREATION 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/viewClusters.html
>  PRE-CREATION 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/leftNavbar.html 
> 9bc54ff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  eed2703 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ViewClusterInstanceResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ViewServiceResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewClusterInstanceService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewServiceService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  dc53172 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  c7dc117 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewClusterInstanceResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
>  6523962 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewServiceResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewVersionResourceProvider.java
>  1bf750b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  5a8476d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcher.java
>  907588d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewClusterConfigurationDao.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewServiceDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewClusterConfigurationEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewCluste

Re: Review Request 46434: DataNode and RegionServer during upgrade are reported as "failed" incorrectly

[Daniel Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46434/
---

(Updated ápr. 22, 2016, 12:42 du)


Review request for Ambari, Alejandro Fernandez, Miklos Gergely, Oliver Szabo, 
Sandor Magyari, and Sebastian Toader.


Changes
---

Review fixes


Bugs: AMBARI-15991
https://issues.apache.org/jira/browse/AMBARI-15991


Repository: ambari


Description
---

If upgrade process takes longer than expected, DataNode and RegionServer is 
reported as failed. It happens because it needs more time to finish update.

The fix for RegionServer checks if the process is running and if it is so, then 
it is not considered as a failure.
For DataNode the process is also checked and if it is running then check is 
repeated 2 times with 5 minutes wait. I had a limitation here, python scripts 
are allowed to run for 20 minutes by default and this checking takes 16 mins (2 
minutes initial check, 5 minutes sleep if there is a failure, 2 minutes 
regaular check, 5 minutes sleep, 2 minutes final check).
If more time is needed, then default value of *server.task.timeout* and number 
of repetition in 5 minutes check should be increased.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/upgrade.py
 01a8156 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode_upgrade.py
 8f36001 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
 7ad9f39 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 
8d187ec 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 78b8171 

Diff: https://reviews.apache.org/r/46434/diff/


Testing
---

I did manual testing on this:
For RegionServer the process check is tested.
For DataNodes I made an intentional exception to see if it keeps waiting. (this 
is how I ran into the 20 minutes server task timeout)

--
Total run:970
Total errors:0
Total failures:0
OK


Thanks,

Daniel Gergely

Re: Review Request 46484: Enhance Health Check for the Cluster before upgrading.

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46484/#review130081
---



One other thing is that you'll want to check against the maintenance mode of 
the current alert as well. If they put a host/component into maintenance mode, 
then we shouldn't warn on alerts which are affected.

- Jonathan Hurley


On April 21, 2016, 7:14 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46484/
> ---
> 
> (Updated April 21, 2016, 7:14 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan 
> Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-16005
> https://issues.apache.org/jira/browse/AMBARI-16005
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enhance Health Check for the Cluster before upgrading.
> 
> * check for alerts (perhaps don't start RU/EU if any blocker alerts).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  3e957b1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java 
> PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/HealthCheckTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46484/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Review Request 46562: View Configuration Simplification

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46562/
---

Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-16037
https://issues.apache.org/jira/browse/AMBARI-16037


Repository: ambari


Description
---

Added view service definition which contains the service dependecy configs and 
related configuration required for services. Each view can define dependency on 
these services. 
Added Remote cluster definition where user will be able to configure it once 
and view instances can be linked to any one of them. Thus, the configurations 
will be created once and used multiple times.


Diffs
-

  ambari-admin/src/main/resources/ui/admin-web/app/index.html fa911a6 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js
 962b795 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/RemoteClusterInstanceCtrl.js
 PRE-CREATION 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/RemoteClusterListCtrl.js
 PRE-CREATION 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js
 d46a30f 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
e95ebdb 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js 4fc4ea6 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/RemoteCluster.js
 PRE-CREATION 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/View.js 
cbe11e4 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/create.html 
20ccadb 
  ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html 
b41abc8 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listClusters.html
 PRE-CREATION 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/viewClusters.html
 PRE-CREATION 
  ambari-admin/src/main/resources/ui/admin-web/app/views/leftNavbar.html 
9bc54ff 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 eed2703 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ViewClusterInstanceResourceDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ViewServiceResourceDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewClusterInstanceService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewServiceService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 dc53172 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
 c7dc117 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewClusterInstanceResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
 6523962 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewServiceResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewVersionResourceProvider.java
 1bf750b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 5a8476d 
  
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcher.java
 907588d 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewClusterConfigurationDao.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewServiceDAO.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewClusterConfigurationEntity.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewClusterConfigurationPropertyEntity.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewClusterConfigurationPropertyEntityPK.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewClusterServiceEntity.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewClusterServiceEntityPK.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java
 29dc2a7 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
 2555f93 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewParameterEntity.java
 5419d58 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewServiceEntity.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/

Review Request 46565: AMBARI-16035 Add support for Rolling and Express Upgrade for Ranger Tagsync

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46565/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
Jonathan Hurley, Jayush Luniya, and Velmurugan Periasamy.


Bugs: AMBARI-16035
https://issues.apache.org/jira/browse/AMBARI-16035


Repository: ambari


Description
---

RANGER_TAGSYNC is a new SLAVE component for RANGER service which needs to be 
included in the Rolling and Express Upgrades for stack 2.5 to 2.5 +


Diffs
-

  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 175115d 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py
 e8effb8 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py
 43ecd07 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 9f31983 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
4da21fa 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
 0e1b30c 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
7a6e302 

Diff: https://reviews.apache.org/r/46565/diff/


Testing
---

1) Tested Upgrade for 2.5.x to 2.5.y with and without RANGER_TAGSYNC component.


Thanks,

Mugdha Varadkar

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46405/#review130071
---


Ship it!




Ship It!

- Alexandr Antonenko


On April 21, 2016, 6:50 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46405/
> ---
> 
> (Updated April 21, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Jaimin Jetly, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15519
> https://issues.apache.org/jira/browse/AMBARI-15519
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On the cluster where some nodes are in the maintenance mode Add Service 
> Wizard doesn't track this.
> So, user may select host in the maintenance mode to install some master 
> component. And this component won't be installed (only record in the DB will 
> be created for it).
> Another situation:
> there is some cluster where all nodes are in the maintenance mode. In this 
> case ASW is almost useless. Because all new components won't be installed 
> while it works.
> 
> ASW should track hosts in the maintenance mode and warn user about adding 
> components on them (Steps "Assign Masters", "Assign Slaves and Clients").
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard.js 52fb241 
>   ambari-web/app/mixins/wizard/assign_master_components.js e4c5295 
> 
> Diff: https://reviews.apache.org/r/46405/diff/
> 
> 
> Testing
> ---
> 
> Modified unit test.
> Local ambari-web test passed.
> 25680 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 46560: Add logging for problems in ambari-agent Controller and ActionQueue

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46560/#review130065
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On April 22, 2016, 12:44 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46560/
> ---
> 
> (Updated April 22, 2016, 12:44 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-16036
> https://issues.apache.org/jira/browse/AMBARI-16036
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py a0596a2 
>   ambari-agent/src/main/python/ambari_agent/Controller.py 40114ca 
>   ambari-agent/src/main/python/ambari_agent/HeartbeatHandlers.py 7a9797d 
> 
> Diff: https://reviews.apache.org/r/46560/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 46560: Add logging for problems in ambari-agent Controller and ActionQueue

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46560/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-16036
https://issues.apache.org/jira/browse/AMBARI-16036


Repository: ambari


Description
---


Diffs
-

  ambari-agent/src/main/python/ambari_agent/ActionQueue.py a0596a2 
  ambari-agent/src/main/python/ambari_agent/Controller.py 40114ca 
  ambari-agent/src/main/python/ambari_agent/HeartbeatHandlers.py 7a9797d 

Diff: https://reviews.apache.org/r/46560/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

[Masahiro Tanaka]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45676/
---

(Updated 4月 22, 2016, 9:35 a.m.)


Review request for Ambari, Andrew Onischuk, Jaimin Jetly, jun aoki, Jayush 
Luniya, and Vitalyi Brodetskyi.


Bugs: AMBARI-15678
https://issues.apache.org/jira/browse/AMBARI-15678


Repository: ambari


Description
---

If yarn app state is not state or yarn app finalStatus is not succeeded, YARN 
service check should fail.
But in the YARN service_check.py, it doesn't fail because raise statement is in 
try block and there is only `pass` in except block.


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
 e8d98ab 

Diff: https://reviews.apache.org/r/45676/diff/


Testing
---

mvn clean test


Thanks,

Masahiro Tanaka

Re: Review Request 46484: Enhance Health Check for the Cluster before upgrading.

[Dmitro Lisnichenko]

> On April 21, 2016, 8:57 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java,
> >  line 67
> > 
> >
> > I thought we were going to filter for only a handful of alerts based on 
> > the name.
> > E.g., out of disk space, ambari performance, etc.

Finally we decided to warn about all alerts (as stated by Jonathan in last 
comment of jira)


- Dmitro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46484/#review129931
---


On April 21, 2016, 2:14 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46484/
> ---
> 
> (Updated April 21, 2016, 2:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan 
> Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-16005
> https://issues.apache.org/jira/browse/AMBARI-16005
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enhance Health Check for the Cluster before upgrading.
> 
> * check for alerts (perhaps don't start RU/EU if any blocker alerts).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  3e957b1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java 
> PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/HealthCheckTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46484/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>