date:20160519


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47526/#review134100
---


Ship it!




Ship It!

- Ashwin Rajeev


On May 19, 2016, 10:22 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47526/
> ---
> 
> (Updated May 19, 2016, 10:22 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16675
> https://issues.apache.org/jira/browse/AMBARI-16675
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earliar : hive jobs with referrer only as 'job' were being shown in history 
> 
> In this patch : all the jobs including sample, explain, visual explain will 
> be shown which was the cause for recent jobs not showning.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/Aggregator.java
>  e646fd7 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js 
> 9584508 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/routes/history.js 
> 848bee8 
> 
> Diff: https://reviews.apache.org/r/47526/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47525: Hive View : Upload table still shows file name after the upload is done


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47525/#review134099
---


Fix it, then Ship it!




Fix it then ship it


contrib/views/hive/src/main/resources/ui/hive-web/app/components/file-upload.js 
(line 30)


Remove logging


- Ashwin Rajeev


On May 19, 2016, 10:22 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47525/
> ---
> 
> (Updated May 19, 2016, 10:22 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16726
> https://issues.apache.org/jira/browse/AMBARI-16726
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : The UI does not get cleared properly after the upload. It still 
> shows file name.
> 
> In this patch : the UI will no longer show the old file name if the upload is 
> successfull.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/components/file-upload.js
>  1cd05ae 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  361de7b 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
>  eb95292 
> 
> Diff: https://reviews.apache.org/r/47525/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47524: Hive view : For Upload Table, 'default' DB should be selected by default


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47524/#review134097
---


Ship it!




Ship It!

- Ashwin Rajeev


On May 19, 2016, 10:22 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47524/
> ---
> 
> (Updated May 19, 2016, 10:22 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16429
> https://issues.apache.org/jira/browse/AMBARI-16429
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : first db in the list was selected or was kept empty.
> 
> In this patch : 'default' hive db will be selected.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  361de7b 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
>  eb95292 
> 
> Diff: https://reviews.apache.org/r/47524/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47527: Hive view : Upload Table- marks column as INT since first 6 rows have INT values.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47527/#review134096
---


Ship it!




Fix it then ship it

- Ashwin Rajeev


On May 19, 2016, 10:23 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47527/
> ---
> 
> (Updated May 19, 2016, 10:23 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16418
> https://issues.apache.org/jira/browse/AMBARI-16418
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : datatype of a column was decided based on maximum number of 
> occurence of a datatype, even if other values do not have same datatype.
> 
> In this patch : even if 1 of the value in the preview rows do not conform to 
> a datatype then it is rejected.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java
>  b6b000a 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/DataParser.java
>  7eae679 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/IParser.java
>  6056e73 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/ParseUtils.java
>  a17346f 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/Parser.java
>  1644c13 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/CSVParser.java
>  56cff58 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/json/JSONParser.java
>  1d61798 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/xml/XMLParser.java
>  74bf272 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/CSVParserTest.java
>  fb4c4da 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserCSVTest.java
>  99f758b 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserJSONTest.java
>  79166bb 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserXMLTest.java
>  4199257 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/JsonParserTest.java
>  38ed225 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/XMLParserTest.java
>  d048a62 
> 
> Diff: https://reviews.apache.org/r/47527/diff/
> 
> 
> Testing
> ---
> 
> extra test cases added for this algorithm of detection of datatype. existing 
> test cases changed to conform new algorithm.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47527: Hive view : Upload Table- marks column as INT since first 6 rows have INT values.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47527/#review134095
---




contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/Parser.java
 (line 111)


IS this exception severe from the users perspective, if yes then log at the 
error level



contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/Parser.java
 (line 140)


Same here


- Ashwin Rajeev


On May 19, 2016, 10:23 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47527/
> ---
> 
> (Updated May 19, 2016, 10:23 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16418
> https://issues.apache.org/jira/browse/AMBARI-16418
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : datatype of a column was decided based on maximum number of 
> occurence of a datatype, even if other values do not have same datatype.
> 
> In this patch : even if 1 of the value in the preview rows do not conform to 
> a datatype then it is rejected.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java
>  b6b000a 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/DataParser.java
>  7eae679 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/IParser.java
>  6056e73 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/ParseUtils.java
>  a17346f 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/Parser.java
>  1644c13 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/CSVParser.java
>  56cff58 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/json/JSONParser.java
>  1d61798 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/xml/XMLParser.java
>  74bf272 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/CSVParserTest.java
>  fb4c4da 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserCSVTest.java
>  99f758b 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserJSONTest.java
>  79166bb 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserXMLTest.java
>  4199257 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/JsonParserTest.java
>  38ed225 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/XMLParserTest.java
>  d048a62 
> 
> Diff: https://reviews.apache.org/r/47527/diff/
> 
> 
> Testing
> ---
> 
> extra test cases added for this algorithm of detection of datatype. existing 
> test cases changed to conform new algorithm.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47595: Implement in ams collector batch insert operations to ams-hbase

2016-05-19 Thread Sid Wagle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47595/#review134093
---




ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 (line 557)


Any reason for chosing 3 seconds vs 5 ?


- Sid Wagle


On May 19, 2016, 2:43 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47595/
> ---
> 
> (Updated May 19, 2016, 2:43 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-16766
> https://issues.apache.org/jira/browse/AMBARI-16766
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Check if there is performance boost after replacing insert operations with 
> bulk loading. 
> If yes, implement and provide switch property for enabling/disabling this 
> feature.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  974f951 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/MetricsCacheCommitter.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  52ab083 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  683e5d4 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessorTest.java
>  290a98a 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TestMetadataManager.java
>  06c71c5 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  a7fd9c8 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
>  8f369f7 
> 
> Diff: https://reviews.apache.org/r/47595/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 47595: Implement in ams collector batch insert operations to ams-hbase

2016-05-19 Thread Sid Wagle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47595/#review134092
---


Fix it, then Ship it!





ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
 (line 205)


Lets rename to cacheComitInterval vs sending



ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
 (line 232)


again we should call this commit vs send.



ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
 (line 695)


Lets use >= instead, sicne not sure if size() is threadsafe



ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
 (line 52)


Rename to evict or commit.



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 (line 557)


Units should be clear from name or description of property.


- Sid Wagle


On May 19, 2016, 2:43 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47595/
> ---
> 
> (Updated May 19, 2016, 2:43 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-16766
> https://issues.apache.org/jira/browse/AMBARI-16766
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Check if there is performance boost after replacing insert operations with 
> bulk loading. 
> If yes, implement and provide switch property for enabling/disabling this 
> feature.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  974f951 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/MetricsCacheCommitter.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  52ab083 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  683e5d4 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessorTest.java
>  290a98a 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TestMetadataManager.java
>  06c71c5 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  a7fd9c8 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
>  8f369f7 
> 
> Diff: https://reviews.apache.org/r/47595/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 47631: 'Configure Ambari Identity' fails when enabling Kerberos on non-root Ambari server

2016-05-19 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47631/
---

Review request for Ambari, Jonathan Hurley, Nate Cole, Sandor Magyari, and 
Sumit Mohanty.


Bugs: AMBARI-16787
https://issues.apache.org/jira/browse/AMBARI-16787


Repository: ambari


Description
---

Configure Ambari Identity phase of Enable Kerberos Wizard fails since Ambari 
does not have permission perform some root-level file system tasks like chown. 

STR:
1. Install Ambari, executing as non-root
2. Create cluster (Zookeeper-only is fine)
3. Enable Kerberos (any KDC is fine)


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 15bd2d9 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIndetityServerAction.java
 bbc7246 
  
ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java
 b5d2b70 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/kerberos.json c5ebe20 
  
ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java
 fc27eda 

Diff: https://reviews.apache.org/r/47631/diff/


Testing
---

Manually tested in cluster using UI and using Blueprints where Ambari was 
executed as root and non-root users.

# Local test results: 

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 1:12:58.862s
[INFO] Finished at: Thu May 19 23:23:12 EDT 2016
[INFO] Final Memory: 59M/1410M
[INFO] 


# Jenkins test results: PENDING


Thanks,

Robert Levas

Re: Review Request 47332: Upgrade pack changes to work with Storm 1.0

2016-05-19 Thread Sriharsha Chintalapani


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47332/
---

(Updated May 20, 2016, 3:11 a.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.


Bugs: AMBARI-16648
https://issues.apache.org/jira/browse/AMBARI-16648


Repository: ambari


Description
---

Upgrade pack changes to work with Storm 1.0


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 7873853 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
1cd2ffa 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 7d67f8e 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
9c6a02d 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
a7dbba3 

Diff: https://reviews.apache.org/r/47332/diff/


Testing
---


Thanks,

Sriharsha Chintalapani

Re: Review Request 47621: AMBARI-16784. Remove 'org.apache.atlas.hive.hook.HiveHook' from Hive2/hive-site.xml config hive.exec.post.hooks as Atlas is not supported by Hive2.

2016-05-19 Thread Sumit Mohanty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47621/#review134085
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 (line 97)


convert it to a function and remove it from the exclude list. Its seems odd 
in that list as this property is not being deleted.

You can add a unit test too - sample test attached to JIRA 16784


- Sumit Mohanty


On May 20, 2016, 1:50 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47621/
> ---
> 
> (Updated May 20, 2016, 1:50 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16784
> https://issues.apache.org/jira/browse/AMBARI-16784
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - As hive2/hive-site.xml only contains the new + the changed props compared 
> to hive/hive-site.xml, we merge hive/hive-site.xml and hive2/hive-site.xml 
> and store it in hive2/hive-site.xml.
> - Thus, as part of the merge, specifically for Hive2/hive-site.xml config 
> 'hive.exec.post.hooks', it gets the hook for Atlas from Hive1/hive-site.xml, 
> if Atlas is installed. As Atlas is not supported by Hive2, we need to remove 
> it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  8e49cf0 
> 
> Diff: https://reviews.apache.org/r/47621/diff/
> 
> 
> Testing
> ---
> 
> Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Review Request 47627: hawq_standby_address_host property should be removed from configuration if HAWQSTANDBY component does not exist in BP

2016-05-19 Thread bhuvnesh chaudhary


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47627/
---

Review request for Ambari, Alexander Denissov, Matt, and Robert Nettleton.


Bugs: AMBARI-16786
https://issues.apache.org/jira/browse/AMBARI-16786


Repository: ambari


Description
---

hawq_standby_address_host property should be removed from configuration if 
HAWQSTANDBY component does not exist in BP


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 1ddc4e1 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 5c6aeaf 

Diff: https://reviews.apache.org/r/47627/diff/


Testing
---

yes. test case added.


Thanks,

bhuvnesh chaudhary

Re: Review Request 47428: Changes to Phoenix QueryServer Kerberos configuration

2016-05-19 Thread Josh Elser


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47428/
---

(Updated May 20, 2016, 2:06 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Levas.


Bugs: AMBARI-16171
https://issues.apache.org/jira/browse/AMBARI-16171


Repository: ambari


Description
---

The up-coming version of Phoenix will contain some new functionality to support 
Kerberos authentication of clients via SPNEGO with the Phoenix Query Server 
(PQS).

Presently, Ambari will configure PQS to use the hbase service keytab which will 
result in the SPNEGO authentication failing as the RFC requires that the 
"primary" component of the Kerberos principal for the server is "HTTP". Thus, 
we need to ensure that we switch PQS over to use the spnego.service.keytab as 
the keytab and "HTTP/_HOST@REALM" as the principal.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
 2e857ed 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 41f538e 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json 
c9536f8 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 20fa50f 

Diff: https://reviews.apache.org/r/47428/diff/


Testing (updated)
---

Unit testing, verified upgrade from 2.2.2


Thanks,

Josh Elser

Re: Review Request 47583: Remove useless log dir definition in Spark Ambari definition

2016-05-19 Thread Saisai Shao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47583/
---

(Updated May 20, 2016, 1:59 a.m.)


Review request for Ambari and Sumit Mohanty.


Bugs: AMBARI-16759
https://issues.apache.org/jira/browse/AMBARI-16759


Repository: ambari


Description
---

Remove useless log dir definition in Spark Ambari definition


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml
 8a5117a 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
 c5f3eb6 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_spark.py
 eca8534 

Diff: https://reviews.apache.org/r/47583/diff/


Testing
---

Local manual test


Thanks,

Saisai Shao

Review Request 47626: Atlas HA configuration Property Changed

2016-05-19 Thread Tom Beerbower


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47626/
---

Review request for Ambari, Erik Bergenholtz and John Speidel.


Bugs: AMBARI-16781
https://issues.apache.org/jira/browse/AMBARI-16781


Repository: ambari


Description
---

The Atlas HA properties to designate ha hosts has changed from:
atlas.server.host.id to atlas.server.address.id this causes Atlas to not be 
able to start in HA mode. The following changes need to be made:

- resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py 
- 
resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 21bc0c5 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
 53c1369 

Diff: https://reviews.apache.org/r/47626/diff/


Testing
---

manual check Atlas HA - verify configs

mvn clean test


Thanks,

Tom Beerbower

Re: Review Request 47621: AMBARI-16784. Remove 'org.apache.atlas.hive.hook.HiveHook' from Hive2/hive-site.xml config hive.exec.post.hooks as Atlas is not supported by Hive2.

2016-05-19 Thread Swapan Shridhar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47621/
---

(Updated May 20, 2016, 1:50 a.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Changes
---

Updated description.


Bugs: AMBARI-16784
https://issues.apache.org/jira/browse/AMBARI-16784


Repository: ambari


Description (updated)
---

- As hive2/hive-site.xml only contains the new + the changed props compared to 
hive/hive-site.xml, we merge hive/hive-site.xml and hive2/hive-site.xml and 
store it in hive2/hive-site.xml.
- Thus, as part of the merge, specifically for Hive2/hive-site.xml config 
'hive.exec.post.hooks', it gets the hook for Atlas from Hive1/hive-site.xml, if 
Atlas is installed. As Atlas is not supported by Hive2, we need to remove it.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 8e49cf0 

Diff: https://reviews.apache.org/r/47621/diff/


Testing
---

Python UT passes.


Thanks,

Swapan Shridhar

Review Request 47621: AMBARI-16784. Remove 'org.apache.atlas.hive.hook.HiveHook' from Hive2/hive-site.xml config hive.exec.post.hooks as Atlas is not supported by Hive2.

2016-05-19 Thread Swapan Shridhar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47621/
---

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-16784
https://issues.apache.org/jira/browse/AMBARI-16784


Repository: ambari


Description
---

- As hive2/hive-site.xml only contains the new + the changed props compared to 
hive/hive-site.xml, we need to merge hive/hive-site.xml and hive2/hive-site.xml 
and store it in hive2/hive-site.xml.
- As part of the merge, specifically for Hive2/hive-site.xml config 
'hive.exec.post.hooks' gets the hook for Atlas from Hive1/hive-site.xml, if 
Atlas is installed. As Atlas is not supported by Hive2, we need to remove it.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 8e49cf0 

Diff: https://reviews.apache.org/r/47621/diff/


Testing
---

Python UT passes.


Thanks,

Swapan Shridhar

Re: Review Request 47560: clean up import * for Kerberos service scripts in common-services

2016-05-19 Thread Juanjo Marron



> On May 19, 2016, 9:51 p.m., Jayush Luniya wrote:
> > Ship It!
> 
> Jayush Luniya wrote:
> @Juanjo 
> Committed all your patches.

Thanks a lot Jayush
More coming


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47560/#review134050
---


On May 18, 2016, 10:14 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47560/
> ---
> 
> (Updated May 18, 2016, 10:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16645
> https://issues.apache.org/jira/browse/AMBARI-16645
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for Hive service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
>  e06b13f 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
>  906d521 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/service_check.py
>  7c09171 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/status_params.py
>  bbae4a3 
> 
> Diff: https://reviews.apache.org/r/47560/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> Kerberos client installation 
> 
> Hadoop QA added a comment - 7 minutes ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12803967/AMBARI-16645.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6885//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6885//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-05-19 Thread Jianfeng (Jeff) Zhang


Hi Jayush，

Could you help take a look at it ? Thanks.


Best Regard,
Jeff Zhang


From: Jianfeng Zhang >
Date: Thursday, May 19, 2016 at 10:22 AM
To: Jayush Luniya >, 
Sumit Mohanty >, 
Alejandro Fernandez 
>
Cc: Jeff Zhang >, Ambari 
>
Subject: Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave 
component of Spark


Hi Jayush,

I try to verify it on blueprints,  but fails with 2 problems.
One is when setup hw repo, another is when registering blueprint. Here’s the 
errors I get, could you guide me what steps I miss here ? Thanks

Setup hw repo.


curl -X PUT  -u admin:admin -d @repo.json -H 'X-Requested-By: ambari' 
http://jzhang-test3-1.openstacklocal:8080/api/v1/stacks/HDP/versions/2.5/operating_systems/centos6/repositories/hw_repo


Error I get:

{

  "status" : 404,

  "message" : "org.apache.ambari.server.controller.spi.NoSuchResourceException: 
The specified resource doesn't exist: Stack data, stackName=HDP, 
stackVersion=2.5, osType=centos6, repoId=hw_repo”

}


Register blueprint


curl -X POST -u admin:admin -d @dev_cluster.json -H 'X-Requested-By: ambari' 
http://jzhang-test3-1.openstacklocal:8080/api/v1/blueprints/dev_cluster


Error I get


{

  "status" : 400,

  "message" : "Blueprint configuration validation failed: Missing required 
properties.  Specify a value for these properties in the blueprint 
configuration. {host_group_1={kerberos-env=[kdc_type, kdc_hosts, 
encryption_types, realm, ldap_url, container_dn]}}”

}



Attach are the request body file for these 2 cases.




Best Regard,
Jeff Zhang


From: Jayush Luniya 
> on behalf of 
Jayush Luniya >
Reply-To: Jayush Luniya 
>
Date: Thursday, May 19, 2016 at 7:53 AM
To: Jayush Luniya >, 
Sumit Mohanty >, 
Alejandro Fernandez 
>
Cc: Jeff Zhang >, Ambari 
>
Subject: Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave 
component of Spark

This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/46727/


@Jeff
Can you verify that blueprint deployment of the cluster without Livy Server 
works?

Guide on Blueprints
https://cwiki.apache.org/confluence/display/AMBARI/Blueprints


- Jayush Luniya


On May 18th, 2016, 11:10 a.m. UTC, Jeff Zhang wrote:

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.
By Jeff Zhang.

Updated May 18, 2016, 11:10 a.m.

Bugs: AMBARI-15612
Repository: ambari
Description

Add Livy to HDP 2.5 as slave component of Spark.

Move the spark stack definiation to commoon-services and then


Testing

Manully verify it. Livy is installed correctly in non-secure and secure cluster.


Diffs

  *   
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 (2e18443)
  *   
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 (9e9cadc)
  *   
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_server.py
 (PRE-CREATION)
  *   
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_service.py
 (PRE-CREATION)
  *   
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
 (c5f3eb6)
  *   
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py
 (694f046)
  *   
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
 (PRE-CREATION)
  *   
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py
 (86e7f7d)
  *   
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 (3ec5d05)
  *   
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
(6e506a0)
  *   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
(f7e15aa)
  *   
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-conf.xml
 (PRE-CREATION)
  *   
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-env.xml
 (PRE-CREATION)
  *   
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-log4j-properties.xml
 (PRE-CREATION)
  *

Review Request 47619: clean up import * for MAHOUT service scripts in common-services

2016-05-19 Thread Juanjo Marron


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47619/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.


Bugs: AMBARI-16671
https://issues.apache.org/jira/browse/AMBARI-16671


Repository: ambari


Description
---

Python code at at common-services level used generic imports form 
resource_management (from resource_management import *)
Ideally, for easier code tracking and performance, these import should be more 
specific, such as: 
from resource_management.libraries.script.script import Script
from resource_management.core.resources.system import Directory
This patch cleans up import * from resource_management for Hive service scripts 
in common-services


Diffs
-

  
ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout.py
 f2c3c18 
  
ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py
 b6fc153 
  
ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py
 11a85e1 

Diff: https://reviews.apache.org/r/47619/diff/


Testing
---

Pass mvn clean test -DskipSurefireTests
MAHOUT fresh installation and service check

Hadoop QA added a comment - 2 hours ago
-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12804463/AMBARI-16671.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6906//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6906//console


Thanks,

Juanjo  Marron

Re: Review Request 47565: AMBARI-16751: Refresh stale host entity reference when deleting a service

2016-05-19 Thread Nahappan Somasundaram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47565/
---

(Updated May 19, 2016, 3:04 p.m.)


Review request for Ambari, Myroslav Papirkovskyy, Sumit Mohanty, and Sid Wagle.


Changes
---

1. Fixed HostComponentDesiredStateDAOTest.java to use findById().
2. Updated the Unit test section.


Bugs: AMBARI-16751
https://issues.apache.org/jira/browse/AMBARI-16751


Repository: ambari


Description
---

AMBARI-16751: Refresh stale host entity reference when deleting a service


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentDesiredStateDAO.java
 46da9dacf0e1c48249a83a167d5903f0ec100f7c 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostComponentDesiredStateDAOTest.java
 b7a0677bcdd5ced0de9fd2bfcb7f290a6f6fe648 

Diff: https://reviews.apache.org/r/47565/diff/


Testing (updated)
---

** 1. mvn clean install **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [7.380s]
[INFO] Apache Ambari Project POM . SUCCESS [0.036s]
[INFO] Ambari Web  SUCCESS [23.544s]
[INFO] Ambari Views .. SUCCESS [1.061s]
[INFO] Ambari Admin View . SUCCESS [21.344s]
[INFO] ambari-metrics  SUCCESS [0.602s]
[INFO] Ambari Metrics Common . SUCCESS [0.912s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [2.140s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [1.109s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [0.996s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [2.969s]
[INFO] Ambari Metrics Collector .. SUCCESS [10.957s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.705s]
[INFO] Ambari Metrics Grafana  SUCCESS [1.289s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:31.486s]
[INFO] Ambari Server . SUCCESS [2:27.145s]
[INFO] Ambari Functional Tests ... SUCCESS [1.128s]
[INFO] Ambari Agent .. SUCCESS [23.899s]
[INFO] Ambari Client . SUCCESS [0.047s]
[INFO] Ambari Python Client .. SUCCESS [0.993s]
[INFO] Ambari Groovy Client .. SUCCESS [2.117s]
[INFO] Ambari Shell .. SUCCESS [0.078s]
[INFO] Ambari Python Shell ... SUCCESS [0.717s]
[INFO] Ambari Groovy Shell ... SUCCESS [0.841s]
[INFO] ambari-logsearch .. SUCCESS [0.191s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.223s]
[INFO] Ambari Logsearch Solr Client .. SUCCESS [1.043s]
[INFO] Ambari Logsearch Portal ... SUCCESS [5.856s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [2.262s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.119s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 5:55.888s
[INFO] Finished at: Wed May 18 16:42:38 PDT 2016
[INFO] Final Memory: 290M/1262M
[INFO] 

** 2. mvn test -Dtest=HostComponentDesiredStateDAOTest -DskipPythonTests **

---
 T E S T S
---
Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true
Running org.apache.ambari.server.orm.dao.HostComponentDesiredStateDAOTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.209 sec - in 
org.apache.ambari.server.orm.dao.HostComponentDesiredStateDAOTest

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 24.701s
[INFO] Finished at: Thu May 19 14:59:41 PDT 2016
[INFO] Final Memory: 57M/1024M
[INFO] 


Thanks,

Nahappan Somasundaram

Re: Review Request 47616: Remove ams-ssl-client from HAWQ metainfo.xml


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47616/#review134055
---


Ship it!




Ship It!

- Lav Jain


On May 19, 2016, 9:50 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47616/
> ---
> 
> (Updated May 19, 2016, 9:50 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav 
> Jain.
> 
> 
> Bugs: AMBARI-16783
> https://issues.apache.org/jira/browse/AMBARI-16783
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove ams-ssl-client from HAWQ metainfo.xml
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml 
> 1ea2ed1 
> 
> Diff: https://reviews.apache.org/r/47616/diff/
> 
> 
> Testing
> ---
> 
> Manually  tested.
> 
> 
> Thanks,
> 
> Matt
> 
>

Re: Review Request 47560: clean up import * for Kerberos service scripts in common-services



> On May 19, 2016, 9:51 p.m., Jayush Luniya wrote:
> > Ship It!

@Juanjo 
Committed all your patches.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47560/#review134050
---


On May 18, 2016, 10:14 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47560/
> ---
> 
> (Updated May 18, 2016, 10:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16645
> https://issues.apache.org/jira/browse/AMBARI-16645
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for Hive service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
>  e06b13f 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
>  906d521 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/service_check.py
>  7c09171 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/status_params.py
>  bbae4a3 
> 
> Diff: https://reviews.apache.org/r/47560/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> Kerberos client installation 
> 
> Hadoop QA added a comment - 7 minutes ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12803967/AMBARI-16645.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6885//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6885//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47560: clean up import * for Kerberos service scripts in common-services


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47560/#review134050
---


Ship it!




Ship It!

- Jayush Luniya


On May 18, 2016, 10:14 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47560/
> ---
> 
> (Updated May 18, 2016, 10:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16645
> https://issues.apache.org/jira/browse/AMBARI-16645
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for Hive service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
>  e06b13f 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
>  906d521 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/service_check.py
>  7c09171 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/status_params.py
>  bbae4a3 
> 
> Diff: https://reviews.apache.org/r/47560/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> Kerberos client installation 
> 
> Hadoop QA added a comment - 7 minutes ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12803967/AMBARI-16645.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6885//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6885//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Review Request 47616: Remove ams-ssl-client from HAWQ metainfo.xml


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47616/
---

Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav Jain.


Bugs: AMBARI-16783
https://issues.apache.org/jira/browse/AMBARI-16783


Repository: ambari


Description
---

Remove ams-ssl-client from HAWQ metainfo.xml


Diffs
-

  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml 
1ea2ed1 

Diff: https://reviews.apache.org/r/47616/diff/


Testing
---

Manually  tested.


Thanks,

Matt

Re: Review Request 47541: clean up import * for HBase service scripts in common-services


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47541/#review134048
---


Ship it!




Ship It!

- Jayush Luniya


On May 18, 2016, 4:41 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47541/
> ---
> 
> (Updated May 18, 2016, 4:41 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16408
> https://issues.apache.org/jira/browse/AMBARI-16408
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for Hive service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  d2f28f5 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
>  f35a570 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_decommission.py
>  022465a 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
>  840411f 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
>  4001912 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_service.py
>  a6904f6 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_upgrade.py
>  2dc9883 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_windows.py
>  7d634cb 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py
>  6ecb58e 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/upgrade.py
>  b1a19e6 
> 
> Diff: https://reviews.apache.org/r/47541/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> Hbase fresh installation and service check
> 
> Hadoop QA added a comment - 2 hours ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12803349/AMBARI-16408.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6878//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6878//console
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47613: API output show protocol as http on 'https' and SSL enabled Ambari server


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47613/
---

(Updated May 19, 2016, 5:33 p.m.)


Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-16782
https://issues.apache.org/jira/browse/AMBARI-16782


Repository: ambari


Description
---

When the product was moved to Jetty v9, the API ssl connector was not updated 
to ensure the URI was processed as 'https' instead of 'http'


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 db66961 

Diff: https://reviews.apache.org/r/47613/diff/


Testing (updated)
---

No changed tests.  Manual testing.  Automated:

Tests run: 4352, Failures: 0, Errors: 0, Skipped: 34

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 38:03.568s
[INFO] Finished at: Thu May 19 17:29:11 EDT 2016
[INFO] Final Memory: 34M/780M
[INFO] 


Thanks,

Nate Cole

Re: Review Request 47477: clean up import * for HDFS service scripts in common-services


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47477/#review134042
---


Ship it!




Ship It!

- Jayush Luniya


On May 18, 2016, 4:49 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47477/
> ---
> 
> (Updated May 18, 2016, 4:49 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16362
> https://issues.apache.org/jira/browse/AMBARI-16362
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for HDFS service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  79c32e4 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py
>  1264284 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
>  d9b76b8 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_datanode.py
>  a22fb99 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py
>  500ed15 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
>  9c5a124 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  b37f413 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_windows.py
>  da00985 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py
>  737ae04 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
>  30eee07 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
>  ceee738 
> 
> Diff: https://reviews.apache.org/r/47477/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> HDFS fresh installation and service check
> Hadoop QA:
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12803107/AMBARI-16362.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6870//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6870//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47475: clean up import * for Hive service scripts in common-services


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47475/#review134041
---


Ship it!




Ship It!

- Jayush Luniya


On May 18, 2016, 4:48 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47475/
> ---
> 
> (Updated May 18, 2016, 4:48 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16189
> https://issues.apache.org/jira/browse/AMBARI-16189
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for Hive service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat.py
>  45dcbe7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py
>  b37698e 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py
>  07b4095 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
>  da49450 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  e8532da 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
>  d0dd9bb 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_server.py
>  851dc02 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py
>  8b98ed1 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_users.py
>  c023548 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_utils.py
>  5006b56 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_windows.py
>  880fdb5 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/service_check.py
>  f7304f7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
>  3acbc7b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
>  34687c4 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py
>  c24db4c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
>  8e80d48 
> 
> Diff: https://reviews.apache.org/r/47475/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> HIVE fresh installation and service check
> 
> 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6869
> 
> 
> Hadoop QA added a comment - 8 minutes ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12802696/AMBARI-16189.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6869//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6869//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services



> On May 19, 2016, 7:31 p.m., Jayush Luniya wrote:
> > Ship It!

Committed patch in trunk and branch-2.4


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/#review134014
---


On May 19, 2016, 3:23 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45169/
> ---
> 
> (Updated May 19, 2016, 3:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush 
> Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-15388
> https://issues.apache.org/jira/browse/AMBARI-15388
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the upgrade is defined as a series of xml files specific to the 
> current stack version and the target stack version. Each upgrade xml defines 
> the overall sequence of the upgrade and what needs to be done for each 
> service. It would both easier to maintain and easier to add new services, if 
> the services themselves could specify what should be done during their 
> upgrade.
> 
> There are two ways to make these changes, the alternate approach would be to 
> only make the java changes and not split the upgrade xml files.  This would 
> still allow new services to add themselves into the upgrade.  The benefit of 
> this is that for the stack services you only have one upgrade xml file.  The 
> problem with that is it is easier for a particular service to have 
> unintentional changes between upgrade xml files.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  7f7a49e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  8a7b42b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> f781574 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java
>  13d5047 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> 5a18b3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  88f6e19 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 43cefb9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
>  b860731 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
>  3325469 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
>  67d7fdb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java
>  5cda422 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 6b74af0 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 9fb2bba 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 1e040e6 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> e3bc7a3 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 6e27da6 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> d755516 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerMiscTest.java
>  dda1e7a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
>  15be8b4 
>   
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/upgrades/HDP/2.2.0/upgrade_test_15388.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_15388.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/repos/hdp.json
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/repos/repoinfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/repos/version-2.2.0.4-123.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/role_command_order.json
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/services/HDFS/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/services/HDFS/upgrades/HDP/2.2.0/upgrade_test_15388.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/upgrades/config-upgrade.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/upgrades/upgrade_test_15388.xml
>  PRE-CREATION 
> 
> Diff:

Re: Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor

2016-05-19 Thread bhuvnesh chaudhary


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47580/#review134032
---


Ship it!




Ship It!

- bhuvnesh chaudhary


On May 19, 2016, 6:58 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47580/
> ---
> 
> (Updated May 19, 2016, 6:58 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav 
> Jain.
> 
> 
> Bugs: AMBARI-16752
> https://issues.apache.org/jira/browse/AMBARI-16752
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In service install wizard, pxf-hbase.jar should be added to the 
> HBASE_CLASSPATH (recommendation and validation)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> e2510eb 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47580/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> 
> Unit tests added.
> 
> ```
> test_createComponentLayoutRecommendations_hawq_1_Host 
> (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> test_createComponentLayoutRecommendations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT does not get recommended during Add Service Wizard, 
> when HAWQ has already been installed ... ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, 
> when HAWQ is selected for installation ... ok
> test_createComponentLayoutRecommendations_hawqsegment_cluster_install 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Cluster Install 
> Wizard, when HAWQ is selected for installation ... ok
> test_createComponentLayoutRecommendations_no_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components ... ok
> test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF does not get recommended during Add Service Wizard, when PXF 
> has already been installed ... ok
> test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF gets recommended correctly during Add Service Wizard, when PXF 
> is selected for installation ... ok
> test_createComponentLayoutRecommendations_pxf_cluster_install 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF gets recommended correctly during Cluster Install Wizard, when 
> PXF is selected for installation ... ok
> test_getComponentLayoutValidations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test layout validations for HAWQ components on a 3-node cluster ... ok
> test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test validation warning for HAWQ segment not colocated with DATANODE ... ok
> test_getComponentLayoutValidations_nohawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components on a 3-node cluster ... ok
> test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test NO warning is generated when PXF is co-located with NAMENODE and 
> DATANODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE or 
> DATANODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_nn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE or 
> DATANODE ... ok
> test_getComponentLayoutValidations_sparkts_no_hive 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test SparkTS is picked when Hive is not installed ... ok
> test_getComponentLayoutValidations_sparkts_with_hive 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test SparkTS is picked when Hive is installed ... ok
> test_noRiskyDictLookups (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> test_recommendFalconConfigurations

Re: Review Request 47613: API output show protocol as http on 'https' and SSL enabled Ambari server

2016-05-19 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47613/#review134031
---


Ship it!




Ship It!

- Jonathan Hurley


On May 19, 2016, 4:24 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47613/
> ---
> 
> (Updated May 19, 2016, 4:24 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-16782
> https://issues.apache.org/jira/browse/AMBARI-16782
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When the product was moved to Jetty v9, the API ssl connector was not updated 
> to ensure the URI was processed as 'https' instead of 'http'
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  db66961 
> 
> Diff: https://reviews.apache.org/r/47613/diff/
> 
> 
> Testing
> ---
> 
> No changed tests.  Manual testing.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 47446: Logsearch color codes works only for upper case log levels.

2016-05-19 Thread Don Bosco Durai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47446/#review134027
---


Ship it!




Ship It!

- Don Bosco Durai


On May 17, 2016, 8:35 a.m., Dharmesh Makwana wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47446/
> ---
> 
> (Updated May 17, 2016, 8:35 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco 
> Durai, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16698
> https://issues.apache.org/jira/browse/AMBARI-16698
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Patch contains:
> Fix for log level color code doesn't show up, if log levels are not in upper 
> case.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/ViewUtils.js
>  ba21b65 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/ComparisonView.js
>  8ad0c4b 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/LogFileView.js
>  2d19d78 
> 
> Diff: https://reviews.apache.org/r/47446/diff/
> 
> 
> Testing
> ---
> 
> Setup logsearch on 3 node cluster and tested the above features.
> 
> 
> Thanks,
> 
> Dharmesh Makwana
> 
>

Review Request 47613: API output show protocol as http on 'https' and SSL enabled Ambari server


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47613/
---

Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-16782
https://issues.apache.org/jira/browse/AMBARI-16782


Repository: ambari


Description
---

When the product was moved to Jetty v9, the API ssl connector was not updated 
to ensure the URI was processed as 'https' instead of 'http'


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 db66961 

Diff: https://reviews.apache.org/r/47613/diff/


Testing
---

No changed tests.  Manual testing.  Automated pending.


Thanks,

Nate Cole

Re: Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor



> On May 19, 2016, 10:14 a.m., Lav Jain wrote:
> > ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py, line 
> > 29
> > 
> >
> > Not sure if loading of PXFServiceAdvisor is necessary. The test should 
> > call stackAdvisor directly and that should automatically load PXF service 
> > advisor for the corresponding routines.

Unit test would call service_advisor, and stack_advisor loading will be deleted 
in the future.

This would be fixed after https://issues.apache.org/jira/browse/AMBARI-16663


- Matt


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47580/#review133974
---


On May 19, 2016, 11:58 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47580/
> ---
> 
> (Updated May 19, 2016, 11:58 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav 
> Jain.
> 
> 
> Bugs: AMBARI-16752
> https://issues.apache.org/jira/browse/AMBARI-16752
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In service install wizard, pxf-hbase.jar should be added to the 
> HBASE_CLASSPATH (recommendation and validation)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> e2510eb 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47580/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> 
> Unit tests added.
> 
> ```
> test_createComponentLayoutRecommendations_hawq_1_Host 
> (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> test_createComponentLayoutRecommendations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT does not get recommended during Add Service Wizard, 
> when HAWQ has already been installed ... ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, 
> when HAWQ is selected for installation ... ok
> test_createComponentLayoutRecommendations_hawqsegment_cluster_install 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Cluster Install 
> Wizard, when HAWQ is selected for installation ... ok
> test_createComponentLayoutRecommendations_no_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components ... ok
> test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF does not get recommended during Add Service Wizard, when PXF 
> has already been installed ... ok
> test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF gets recommended correctly during Add Service Wizard, when PXF 
> is selected for installation ... ok
> test_createComponentLayoutRecommendations_pxf_cluster_install 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF gets recommended correctly during Cluster Install Wizard, when 
> PXF is selected for installation ... ok
> test_getComponentLayoutValidations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test layout validations for HAWQ components on a 3-node cluster ... ok
> test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test validation warning for HAWQ segment not colocated with DATANODE ... ok
> test_getComponentLayoutValidations_nohawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components on a 3-node cluster ... ok
> test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test NO warning is generated when PXF is co-located with NAMENODE and 
> DATANODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE or 
> DATANODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_nn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn

Re: Review Request 47524: Hive view : For Upload Table, 'default' DB should be selected by default


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47524/#review134024
---


Ship it!




Ship It!

- Rohit Choudhary


On May 19, 2016, 10:22 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47524/
> ---
> 
> (Updated May 19, 2016, 10:22 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16429
> https://issues.apache.org/jira/browse/AMBARI-16429
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : first db in the list was selected or was kept empty.
> 
> In this patch : 'default' hive db will be selected.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  361de7b 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
>  eb95292 
> 
> Diff: https://reviews.apache.org/r/47524/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47525: Hive View : Upload table still shows file name after the upload is done


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47525/#review134023
---


Ship it!




Ship It!

- Rohit Choudhary


On May 19, 2016, 10:22 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47525/
> ---
> 
> (Updated May 19, 2016, 10:22 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16726
> https://issues.apache.org/jira/browse/AMBARI-16726
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : The UI does not get cleared properly after the upload. It still 
> shows file name.
> 
> In this patch : the UI will no longer show the old file name if the upload is 
> successfull.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/components/file-upload.js
>  1cd05ae 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  361de7b 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
>  eb95292 
> 
> Diff: https://reviews.apache.org/r/47525/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47379: PXF operations considers the agent status


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47379/#review134022
---




ambari-web/app/controllers/main/service/item.js (line 1008)


App.HostComponentStatus.started instead of 'STARTED' (in case the constant 
is updated to include 'STARTING')


- Lav Jain


On May 14, 2016, 12:27 a.m., Goutam Tadi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47379/
> ---
> 
> (Updated May 14, 2016, 12:27 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
> Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-16670
> https://issues.apache.org/jira/browse/AMBARI-16670
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PXF operations considers the agent status
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/item.js 9250bfc 
>   ambari-web/app/models/host_component.js 569879f 
>   ambari-web/test/controllers/main/service/item_test.js 383aa2f 
> 
> Diff: https://reviews.apache.org/r/47379/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> User should be able to do the following ops on PXF:
> Start PXF slaves if one or more slaves are down
> Stop PXF slaves if one or more slaves are up
> Start disabled if all agents are up
> Stop disabled if all agents are down
> Service Check disabled if one or more slaves are down
> Service Check enabled if all agents are up
> 
> 
> Thanks,
> 
> Goutam Tadi
> 
>

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46962/#review134020
---



Can we used TypedQuery instead of list and subsequent conversions?

- Rohit Choudhary


On May 19, 2016, 6:43 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46962/
> ---
> 
> (Updated May 19, 2016, 6:43 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16242
> https://issues.apache.org/jira/browse/AMBARI-16242
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : 
> the id for dynamic entity was created in the application with the use of 
> instance data for that view. This data is dependent on users and created 
> separate sequences for each user. So the id for one user was also generated 
> for other user. Hence the data in db of one user was getting overriden by 
> other user. 
> 
> In this patch : 
> Now the id is generated using table_sequence techique of JPA. table for 
> sequence is ambari_sequence. UpgradeCatalog240.java will add the current 
> sequence number for existing tables and for new table the sequence name will 
> be added automatically. As sequence size of 50 is provided for better 
> performances
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  41f538e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/persistence/DataStoreImpl.java
>  0ed260d 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/persistence/DataStoreStorage.java
>  1e8f07f 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java
>  f7f883b 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/DataStoreStorage.java
>  7ae7721 
> 
> Diff: https://reviews.apache.org/r/46962/diff/
> 
> 
> Testing
> ---
> 
> Following manual testing has been done.
> 1. upgrade script creates correct current sequences. Done by manually 
> upgrading old ambari with existing views. Next job will allocate 50 more ids
> 2. for new tables the entry in ambari_sequence is automatically added and the 
> ids will start from 1.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47379: PXF operations considers the agent status


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47379/#review134021
---




ambari-web/app/controllers/main/service/item.js (line 1000)


Does it make sense to create isServiceCheckDisabled function here and move 
the PXF logic from host_component.js?


- Lav Jain


On May 14, 2016, 12:27 a.m., Goutam Tadi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47379/
> ---
> 
> (Updated May 14, 2016, 12:27 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
> Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-16670
> https://issues.apache.org/jira/browse/AMBARI-16670
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PXF operations considers the agent status
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/item.js 9250bfc 
>   ambari-web/app/models/host_component.js 569879f 
>   ambari-web/test/controllers/main/service/item_test.js 383aa2f 
> 
> Diff: https://reviews.apache.org/r/47379/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> User should be able to do the following ops on PXF:
> Start PXF slaves if one or more slaves are down
> Stop PXF slaves if one or more slaves are up
> Start disabled if all agents are up
> Stop disabled if all agents are down
> Service Check disabled if one or more slaves are down
> Service Check enabled if all agents are up
> 
> 
> Thanks,
> 
> Goutam Tadi
> 
>

Re: Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47580/#review134019
---


Ship it!




Ship It!

- Lav Jain


On May 19, 2016, 6:58 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47580/
> ---
> 
> (Updated May 19, 2016, 6:58 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav 
> Jain.
> 
> 
> Bugs: AMBARI-16752
> https://issues.apache.org/jira/browse/AMBARI-16752
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In service install wizard, pxf-hbase.jar should be added to the 
> HBASE_CLASSPATH (recommendation and validation)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> e2510eb 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47580/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> 
> Unit tests added.
> 
> ```
> test_createComponentLayoutRecommendations_hawq_1_Host 
> (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> test_createComponentLayoutRecommendations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT does not get recommended during Add Service Wizard, 
> when HAWQ has already been installed ... ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, 
> when HAWQ is selected for installation ... ok
> test_createComponentLayoutRecommendations_hawqsegment_cluster_install 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Cluster Install 
> Wizard, when HAWQ is selected for installation ... ok
> test_createComponentLayoutRecommendations_no_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components ... ok
> test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF does not get recommended during Add Service Wizard, when PXF 
> has already been installed ... ok
> test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF gets recommended correctly during Add Service Wizard, when PXF 
> is selected for installation ... ok
> test_createComponentLayoutRecommendations_pxf_cluster_install 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF gets recommended correctly during Cluster Install Wizard, when 
> PXF is selected for installation ... ok
> test_getComponentLayoutValidations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test layout validations for HAWQ components on a 3-node cluster ... ok
> test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test validation warning for HAWQ segment not colocated with DATANODE ... ok
> test_getComponentLayoutValidations_nohawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components on a 3-node cluster ... ok
> test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test NO warning is generated when PXF is co-located with NAMENODE and 
> DATANODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE or 
> DATANODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_nn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE or 
> DATANODE ... ok
> test_getComponentLayoutValidations_sparkts_no_hive 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test SparkTS is picked when Hive is not installed ... ok
> test_getComponentLayoutValidations_sparkts_with_hive 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test SparkTS is picked when Hive is installed ... ok
> test_noRiskyDictLookups (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> test_recommendFalconConfigurations

Re: Review Request 47467: Hive View does not work with multi-bytes characters


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47467/#review134016
---


Ship it!




Ship It!

- Rohit Choudhary


On May 17, 2016, 3:27 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47467/
> ---
> 
> (Updated May 17, 2016, 3:27 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16713
> https://issues.apache.org/jira/browse/AMBARI-16713
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Writing bytes instead of String to stream.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsUtil.java
>  bd01ead 
> 
> Diff: https://reviews.apache.org/r/47467/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47537: View log files should pickup ambari-server log directory path


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47537/#review134015
---


Ship it!




Ship It!

- Rohit Choudhary


On May 18, 2016, 3:07 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47537/
> ---
> 
> (Updated May 18, 2016, 3:07 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16734
> https://issues.apache.org/jira/browse/AMBARI-16734
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : views had to hardcode the log directory as the variable 
> ambari.log.dir was not available inside view.log4j.properties file.
> 
> In this patch : view.log4j.properties of view can now use all the ambari 
> properties including ambari.log.dir of ambari's log4j.properties
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> 6d4ef82 
> 
> Diff: https://reviews.apache.org/r/47537/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/#review134014
---


Ship it!




Ship It!

- Jayush Luniya


On May 19, 2016, 3:23 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45169/
> ---
> 
> (Updated May 19, 2016, 3:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush 
> Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-15388
> https://issues.apache.org/jira/browse/AMBARI-15388
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the upgrade is defined as a series of xml files specific to the 
> current stack version and the target stack version. Each upgrade xml defines 
> the overall sequence of the upgrade and what needs to be done for each 
> service. It would both easier to maintain and easier to add new services, if 
> the services themselves could specify what should be done during their 
> upgrade.
> 
> There are two ways to make these changes, the alternate approach would be to 
> only make the java changes and not split the upgrade xml files.  This would 
> still allow new services to add themselves into the upgrade.  The benefit of 
> this is that for the stack services you only have one upgrade xml file.  The 
> problem with that is it is easier for a particular service to have 
> unintentional changes between upgrade xml files.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  7f7a49e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  8a7b42b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> f781574 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java
>  13d5047 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> 5a18b3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  88f6e19 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 43cefb9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
>  b860731 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
>  3325469 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
>  67d7fdb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java
>  5cda422 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 6b74af0 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 9fb2bba 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 1e040e6 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> e3bc7a3 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 6e27da6 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> d755516 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerMiscTest.java
>  dda1e7a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
>  15be8b4 
>   
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/upgrades/HDP/2.2.0/upgrade_test_15388.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_15388.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/repos/hdp.json
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/repos/repoinfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/repos/version-2.2.0.4-123.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/role_command_order.json
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/services/HDFS/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/services/HDFS/upgrades/HDP/2.2.0/upgrade_test_15388.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/upgrades/config-upgrade.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/upgrades/upgrade_test_15388.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45169/diff/
> 
> 
> Testing
> ---
> 
> Manual testing so far.  I

Re: Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47580/
---

(Updated May 19, 2016, 11:58 a.m.)

Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav Jain.

Bugs: AMBARI-16752
https://issues.apache.org/jira/browse/AMBARI-16752

Repository: ambari

Description
---

In service install wizard, pxf-hbase.jar should be added to the HBASE_CLASSPATH
(recommendation and validation)

Diffs (updated)
-

ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py
e2510eb
ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py
PRE-CREATION

Diff: https://reviews.apache.org/r/47580/diff/

Testing
---

Manually Tested.

Unit tests added.

```
test_createComponentLayoutRecommendations_hawq_1_Host
(test_stack_advisor.TestHDP23StackAdvisor) ... ok
test_createComponentLayoutRecommendations_hawq_3_Hosts
(test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok
test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed
(test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSEGMENT does not get recommended during Add Service Wizard, when
HAWQ has already been installed ... ok
test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed
(test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard,
when HAWQ is selected for installation ... ok
test_createComponentLayoutRecommendations_hawqsegment_cluster_install
(test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSEGMENT gets recommended correctly during Cluster Install Wizard,
when HAWQ is selected for installation ... ok
test_createComponentLayoutRecommendations_no_hawq_3_Hosts
(test_stack_advisor.TestHDP23StackAdvisor)
Test no failures when there are no HAWQ components ... ok
test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed
(test_stack_advisor.TestHDP23StackAdvisor)
Test that PXF does not get recommended during Add Service Wizard, when PXF has
already been installed ... ok
test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed
(test_stack_advisor.TestHDP23StackAdvisor)
Test that PXF gets recommended correctly during Add Service Wizard, when PXF is
selected for installation ... ok
test_createComponentLayoutRecommendations_pxf_cluster_install
(test_stack_advisor.TestHDP23StackAdvisor)
Test that PXF gets recommended correctly during Cluster Install Wizard, when
PXF is selected for installation ... ok
test_getComponentLayoutValidations_hawq_3_Hosts
(test_stack_advisor.TestHDP23StackAdvisor)
Test layout validations for HAWQ components on a 3-node cluster ... ok
test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode
(test_stack_advisor.TestHDP23StackAdvisor)
Test validation warning for HAWQ segment not colocated with DATANODE ... ok
test_getComponentLayoutValidations_nohawq_3_Hosts
(test_stack_advisor.TestHDP23StackAdvisor)
Test no failures when there are no HAWQ components on a 3-node cluster ... ok
test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn
(test_stack_advisor.TestHDP23StackAdvisor)
Test NO warning is generated when PXF is co-located with NAMENODE and DATANODE
... ok
test_getComponentLayoutValidations_pxf_not_co_located_with_dn
(test_stack_advisor.TestHDP23StackAdvisor)
Test warning is generated when PXF is not co-located with NAMENODE or DATANODE
... ok
test_getComponentLayoutValidations_pxf_not_co_located_with_nn
(test_stack_advisor.TestHDP23StackAdvisor)
Test warning is generated when PXF is not co-located with NAMENODE ... ok
test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn
(test_stack_advisor.TestHDP23StackAdvisor)
Test warning is generated when PXF is not co-located with NAMENODE or DATANODE
... ok
test_getComponentLayoutValidations_sparkts_no_hive
(test_stack_advisor.TestHDP23StackAdvisor)
Test SparkTS is picked when Hive is not installed ... ok
test_getComponentLayoutValidations_sparkts_with_hive
(test_stack_advisor.TestHDP23StackAdvisor)
Test SparkTS is picked when Hive is installed ... ok
test_noRiskyDictLookups (test_stack_advisor.TestHDP23StackAdvisor) ... ok
test_recommendFalconConfigurations (test_stack_advisor.TestHDP23StackAdvisor)
... ok
test_recommendHAWQConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ...
ok
test_recommendHBASEConfigurations (test_stack_advisor.TestHDP23StackAdvisor)
... ok
test_recommendHDFSConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ...
ok
test_recommendHiveConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ...
ok
test_recommendHiveConfigurations_with_atlas
(test_stack_advisor.TestHDP23StackAdvisor) ... ok
test_recommendKAFKAConfigurations

Re: Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47580/
---

(Updated May 19, 2016, 11:55 a.m.)


Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav Jain.


Bugs: AMBARI-16752
https://issues.apache.org/jira/browse/AMBARI-16752


Repository: ambari


Description
---

In service install wizard, pxf-hbase.jar should be added to the HBASE_CLASSPATH 
(recommendation and validation)


Diffs (updated)
-

  ambari-admin/src/main/resources/ui/admin-web/app/index.html 9344f15 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersEditCtrl.js
 5420ae5 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
3ed2687 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/DeregisterClusterModal.js
 174c0d6 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/RemoteCluster.js
 1c5f588 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
 2481d59 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/modals/deregisterClusterModal.html
 e6c67ca 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/editRemoteClusterPage.html
 8979cba 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/list.html 
7f525e8 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/modals/changePassword.html
 55611a0 
  ambari-agent/src/main/python/ambari_agent/RecoveryManager.py 87d9483 
  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin.py
 260f018 
  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
 0fb017d 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 
0dcbea8 
  ambari-server/conf/unix/ambari.properties 9f1692e 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 f5e8f39 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
 9c2db1c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 b60592d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
 36be39e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProvider.java
 6f2a134 
  ambari-server/src/main/python/ambari_server/serverSetup.py f01465d 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
 119f2c7 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 b9b49e9 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py
 abb47e5 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
 9094f7f 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py
 e3aff9d 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 abb8469 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
 a1ffc5e 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
 716b612 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 f285853 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py
 81a4e3e 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
 7a68a32 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py
 3a9f51e 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 5d454de 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py
 d4eb6b9 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 dd3a692 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
 2f091a5 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 b76bc89 
  ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
e2510eb 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 d4418e0 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py
 3dc4914 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
 0a39219

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

2016-05-19 Thread Nitiraj Rathore

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46962/
---

(Updated May 19, 2016, 6:43 p.m.)

Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar,
Rohit Choudhary, and Ashwin Rajeev.

Changes
---

did further changes as per review comments.

Bugs: AMBARI-16242
https://issues.apache.org/jira/browse/AMBARI-16242

Repository: ambari

Description
---

Earlier :
the id for dynamic entity was created in the application with the use of
instance data for that view. This data is dependent on users and created
separate sequences for each user. So the id for one user was also generated for
other user. Hence the data in db of one user was getting overriden by other
user.

In this patch :
Now the id is generated using table_sequence techique of JPA. table for
sequence is ambari_sequence. UpgradeCatalog240.java will add the current
sequence number for existing tables and for new table the sequence name will be
added automatically. As sequence size of 50 is provided for better performances

Diffs (updated)
-

ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
41f538e

ambari-server/src/main/java/org/apache/ambari/server/view/persistence/DataStoreImpl.java
0ed260d

contrib/views/hive/src/main/java/org/apache/ambari/view/hive/persistence/DataStoreStorage.java
1e8f07f

contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java
f7f883b

contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/DataStoreStorage.java
7ae7721

Diff: https://reviews.apache.org/r/46962/diff/

Testing
---

Following manual testing has been done.
1. upgrade script creates correct current sequences. Done by manually upgrading
old ambari with existing views. Next job will allocate 50 more ids
2. for new tables the entry in ambari_sequence is automatically added and the
ids will start from 1.

Thanks,

Nitiraj Rathore

Re: Review Request 47379: PXF operations considers the agent status


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47379/#review134003
---




ambari-web/app/models/host_component.js (line 298)


The logic for disabled can be extracted into a separate function.


- Lav Jain


On May 14, 2016, 12:27 a.m., Goutam Tadi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47379/
> ---
> 
> (Updated May 14, 2016, 12:27 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
> Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-16670
> https://issues.apache.org/jira/browse/AMBARI-16670
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PXF operations considers the agent status
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/item.js 9250bfc 
>   ambari-web/app/models/host_component.js 569879f 
>   ambari-web/test/controllers/main/service/item_test.js 383aa2f 
> 
> Diff: https://reviews.apache.org/r/47379/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> User should be able to do the following ops on PXF:
> Start PXF slaves if one or more slaves are down
> Stop PXF slaves if one or more slaves are up
> Start disabled if all agents are up
> Stop disabled if all agents are down
> Service Check disabled if one or more slaves are down
> Service Check enabled if all agents are up
> 
> 
> Thanks,
> 
> Goutam Tadi
> 
>

Re: Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor

2016-05-19 Thread Alexander Denissov


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47580/#review133977
---




ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
(line 74)


I would check only for presence of pxf-hbase.jar string, in case users edit 
the content with extra information



ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
(line 84)


here as well, just check for the jar



ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
(line 86)


pxf-hbase.jar -- h is missing


- Alexander Denissov


On May 19, 2016, 6:11 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47580/
> ---
> 
> (Updated May 19, 2016, 6:11 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav 
> Jain.
> 
> 
> Bugs: AMBARI-16752
> https://issues.apache.org/jira/browse/AMBARI-16752
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In service install wizard, pxf-hbase.jar should be added to the 
> HBASE_CLASSPATH (recommendation and validation)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> e2510eb 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47580/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> 
> Unit tests added.
> 
> Hadoop QA:
> ```
> +1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12804840/AMBARI-16752-trunk-orig.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 1 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6889//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6889//console
> This message is automatically generated.
> ```
> 
> 
> Thanks,
> 
> Matt
> 
>

Review Request 47611: AMBARI-16779 Zeppelin Ambari stack does not handle log4j configuration

2016-05-19 Thread Renjith Kamath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47611/
---

Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
Luniya, Rohit Choudhary, and Sumit Mohanty.


Bugs: AMBARI-16779
https://issues.apache.org/jira/browse/AMBARI-16779


Repository: ambari


Description
---

Add support for editing log4j properies


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
 268f5d6 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 d079096 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
 da260c2 

Diff: https://reviews.apache.org/r/47611/diff/


Testing
---

tested on centos


Thanks,

Renjith Kamath

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

2016-05-19 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/#review134000
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 19, 2016, 3:23 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45169/
> ---
> 
> (Updated May 19, 2016, 3:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush 
> Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-15388
> https://issues.apache.org/jira/browse/AMBARI-15388
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the upgrade is defined as a series of xml files specific to the 
> current stack version and the target stack version. Each upgrade xml defines 
> the overall sequence of the upgrade and what needs to be done for each 
> service. It would both easier to maintain and easier to add new services, if 
> the services themselves could specify what should be done during their 
> upgrade.
> 
> There are two ways to make these changes, the alternate approach would be to 
> only make the java changes and not split the upgrade xml files.  This would 
> still allow new services to add themselves into the upgrade.  The benefit of 
> this is that for the stack services you only have one upgrade xml file.  The 
> problem with that is it is easier for a particular service to have 
> unintentional changes between upgrade xml files.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  7f7a49e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  8a7b42b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> f781574 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java
>  13d5047 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> 5a18b3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  88f6e19 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 43cefb9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
>  b860731 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
>  3325469 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
>  67d7fdb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java
>  5cda422 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 6b74af0 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 9fb2bba 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 1e040e6 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> e3bc7a3 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 6e27da6 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> d755516 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerMiscTest.java
>  dda1e7a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
>  15be8b4 
>   
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/upgrades/HDP/2.2.0/upgrade_test_15388.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_15388.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/repos/hdp.json
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/repos/repoinfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/repos/version-2.2.0.4-123.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/role_command_order.json
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/services/HDFS/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/services/HDFS/upgrades/HDP/2.2.0/upgrade_test_15388.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/upgrades/config-upgrade.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/upgrades/upgrade_test_15388.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45169/diff/
> 
> 
> Testing
> ---
> 
> Manual testing so far.

Re: Review Request 47460: Explain script on pig views encountered an IOExecption


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47460/#review133999
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On May 17, 2016, 3 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47460/
> ---
> 
> (Updated May 17, 2016, 3 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16707
> https://issues.apache.org/jira/browse/AMBARI-16707
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changed url formation for explian script
> 
> 
> Diffs
> -
> 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/jobs/JobResourceManager.java
>  2bd5745 
> 
> Diff: https://reviews.apache.org/r/47460/diff/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47460: Explain script on pig views encountered an IOExecption


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47460/#review133998
---


Ship it!




Ship It!

- Ashwin Rajeev


On May 17, 2016, 3 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47460/
> ---
> 
> (Updated May 17, 2016, 3 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16707
> https://issues.apache.org/jira/browse/AMBARI-16707
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changed url formation for explian script
> 
> 
> Diffs
> -
> 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/jobs/JobResourceManager.java
>  2bd5745 
> 
> Diff: https://reviews.apache.org/r/47460/diff/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47459: ADLS as default FS is not supported for any views


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47459/#review133997
---


Ship it!




Ship It!

- Rohit Choudhary


On May 17, 2016, 2:58 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47459/
> ---
> 
> (Updated May 17, 2016, 2:58 p.m.)
> 
> 
> Review request for Ambari, Chris Nauroth, DIPAYAN BHOWMICK, Nitiraj Rathore, 
> Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16706
> https://issues.apache.org/jira/browse/AMBARI-16706
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added adl related properties
> 
> 
> Diffs
> -
> 
>   contrib/views/utils/pom.xml c15afad 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/ValidatorUtils.java
>  c936355 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
>  8b45cd6 
> 
> Diff: https://reviews.apache.org/r/47459/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47514: Kerberos wizard gets reset and does not remember selections/data entered in previous step when you click on Back

2016-05-19 Thread Alexandr Antonenko



> On May 18, 2016, 9:15 p.m., Alexandr Antonenko wrote:
> > Ship It!
> 
> Anita Jebaraj wrote:
> Thank you Alex, can you please help me to push the changes

no problem.

yes ofc, I will commit


- Alexandr


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47514/#review133814
---


On May 18, 2016, 7:05 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47514/
> ---
> 
> (Updated May 18, 2016, 7:05 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-15951
> https://issues.apache.org/jira/browse/AMBARI-15951
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Navigate to Admin->Kerberos. Click on Enable Kerberos.
> 2. In the wizard, select Existing Active Directory for e.g.
> 3. Check all the pre-requisites.
> 4. Click on Next to get to the Configure Kerberos page.
> 5. Click on Back.
> 6. The type of KDC radio button gets reset to Existing MIT KDC.
> 7. Same thing happens if you Navigate to Install and Test Kerberos Client 
> page and navigate back to the second or first page of the wizard.
> 
> Expected results:
> Like other wizards such as Add Service Wizard, the wizard should remember 
> selections/data when navigating back in the wizard.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 7f561dd 
>   ambari-web/app/views/main/admin/kerberos/step1_view.js 2e7c4cf 
>   ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js 
> fda2ab4 
> 
> Diff: https://reviews.apache.org/r/47514/diff/
> 
> 
> Testing
> ---
> 
> Ran mvn test
> 27719 tests complete (32 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 47590: Zero valued bars are thicker than bars with value in thousands in the Log search Log Level histograms

2016-05-19 Thread Oliver Szabo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47590/#review133995
---


Ship it!




- Oliver Szabo


On May 19, 2016, 3:20 p.m., Dharmesh Makwana wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47590/
> ---
> 
> (Updated May 19, 2016, 3:20 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco 
> Durai, Jaimin Jetly, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit 
> Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16768
> https://issues.apache.org/jira/browse/AMBARI-16768
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Zero valued bars are showing instead of bars having values greater than zero.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dashboard/HostListView.js
>  9c426f5 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/EventHistoryLayoutView.js
>  bde62c0 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/LogFileView.js
>  850bb6b 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/troubleshoot/TroubleShootLayoutView.js
>  bbdb653 
>   ambari-logsearch/ambari-logsearch-portal/src/main/webapp/styles/style.css 
> 85b2249 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/styles/style_v2.css 
> 58a3d04 
> 
> Diff: https://reviews.apache.org/r/47590/diff/
> 
> 
> Testing
> ---
> 
> Setup logsearch on 3 node cluster and tested the above features.
> 
> 
> Thanks,
> 
> Dharmesh Makwana
> 
>

Re: Review Request 47514: Kerberos wizard gets reset and does not remember selections/data entered in previous step when you click on Back

2016-05-19 Thread Anita Jebaraj



> On May 18, 2016, 9:15 p.m., Alexandr Antonenko wrote:
> > Ship It!

Thank you Alex, can you please help me to push the changes


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47514/#review133814
---


On May 18, 2016, 7:05 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47514/
> ---
> 
> (Updated May 18, 2016, 7:05 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-15951
> https://issues.apache.org/jira/browse/AMBARI-15951
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Navigate to Admin->Kerberos. Click on Enable Kerberos.
> 2. In the wizard, select Existing Active Directory for e.g.
> 3. Check all the pre-requisites.
> 4. Click on Next to get to the Configure Kerberos page.
> 5. Click on Back.
> 6. The type of KDC radio button gets reset to Existing MIT KDC.
> 7. Same thing happens if you Navigate to Install and Test Kerberos Client 
> page and navigate back to the second or first page of the wizard.
> 
> Expected results:
> Like other wizards such as Add Service Wizard, the wizard should remember 
> selections/data when navigating back in the wizard.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 7f561dd 
>   ambari-web/app/views/main/admin/kerberos/step1_view.js 2e7c4cf 
>   ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js 
> fda2ab4 
> 
> Diff: https://reviews.apache.org/r/47514/diff/
> 
> 
> Testing
> ---
> 
> Ran mvn test
> 27719 tests complete (32 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 47604: View URLs: UX edits #4


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47604/#review133993
---


Ship it!




Fix it then ship it

- Ashwin Rajeev


On May 19, 2016, 4:38 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47604/
> ---
> 
> (Updated May 19, 2016, 4:38 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16771
> https://issues.apache.org/jira/browse/AMBARI-16771
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> minor UX changes for short URL
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js
>  2b1fb3b 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
> d7dc9c7 
>   ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 0ad183c 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html 
> 3a69a50 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
>  2481d59 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listUrls.html
>  e0b8a4e 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/urls/create.html 
> c98ec3e 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/urls/edit.html 
> 9e0ef4c 
> 
> Diff: https://reviews.apache.org/r/47604/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 47596: HiveServer interactive - incorrect default memory value

2016-05-19 Thread Sebastian Toader


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47596/#review133991
---




ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 (line 433)


I think its better to introduce a variable here through which the default 
value of this property can be linked to the default value of 
```yarn.scheduler.minimum-allocation-mb``` so it doesn't has to be changed in 
two places if the default value changes.

As an example look at ```{{storm_thrift_transport}}``` in storm-site.xml 
and storm's params_linux.py


- Sebastian Toader


On May 19, 2016, 6:55 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47596/
> ---
> 
> (Updated May 19, 2016, 6:55 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16776
> https://issues.apache.org/jira/browse/AMBARI-16776
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Default value of hive.llap.daemon.yarn.container.mb is not aligned to 
> yarn.scheduler.minimum-allocation-mb
> If the former one is less than the latter one, then hive server interactive 
> wont start. So the default values must be in a proper relation.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  db5f616 
> 
> Diff: https://reviews.apache.org/r/47596/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 2:15.746s
> [INFO] Finished at: Thu May 19 18:52:43 CEST 2016
> [INFO] Final Memory: 58M/1120M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 47604: View URLs: UX edits #4


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47604/#review133992
---




ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js
 (line 446)


pls remove console.log


- Ashwin Rajeev


On May 19, 2016, 4:38 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47604/
> ---
> 
> (Updated May 19, 2016, 4:38 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16771
> https://issues.apache.org/jira/browse/AMBARI-16771
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> minor UX changes for short URL
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js
>  2b1fb3b 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
> d7dc9c7 
>   ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 0ad183c 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html 
> 3a69a50 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
>  2481d59 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listUrls.html
>  e0b8a4e 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/urls/create.html 
> c98ec3e 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/urls/edit.html 
> 9e0ef4c 
> 
> Diff: https://reviews.apache.org/r/47604/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 47445: Remote Cluster: UX edits #1


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47445/
---

(Updated May 19, 2016, 5:27 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.


Bugs: AMBARI-16697
https://issues.apache.org/jira/browse/AMBARI-16697


Repository: ambari


Description
---

Made JS/HTML changes for addressing all the issues.


Diffs (updated)
-

  ambari-admin/src/main/resources/ui/admin-web/app/index.html a4a5b28 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersEditCtrl.js
 20eb552 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
d7dc9c7 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/DeregisterClusterModal.js
 PRE-CREATION 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/RemoteCluster.js
 e4826e6 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/modals/deregisterClusterModal.html
 PRE-CREATION 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/editRemoteClusterPage.html
 b5890bf 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/list.html 
e386ffd 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/modals/changePassword.html
 a05e13d 

Diff: https://reviews.apache.org/r/47445/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 47605: AMBARI-16446 Ranger audit properties should be configured to use Ambari installed Solr (LogSearch)

2016-05-19 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47605/#review133983
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
 (line 78)


Why not always do the import?


- Alejandro Fernandez


On May 19, 2016, 5:22 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47605/
> ---
> 
> (Updated May 19, 2016, 5:22 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam 
> Borad, Jaimin Jetly, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16446
> https://issues.apache.org/jira/browse/AMBARI-16446
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> From stack 2.5 onwards Ranger Service is dependent on Logsearch for Solr 
> instance.
> Enable Audit to Solr and populate Ranger Audit properties with that Solr 
> instance.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  2e18443 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  9e9cadc 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  408418c 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  c015367 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  fabe2fb 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
>  ef05604 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-env.xml
>  43975af 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/metainfo.xml 
> 59451b2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  3ec5d05 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> f7e15aa 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 11aac72 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-secured.json 
> b6d7d5b 
> 
> Diff: https://reviews.apache.org/r/47605/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger installation with Logsearch on centos 6.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47580/#review133985
---



Should we create a services/PXF directory under 
ambari-server/src/test/python/stacks or continue to put the common-services 
tests under 2.3 stack?

- Lav Jain


On May 19, 2016, 6:11 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47580/
> ---
> 
> (Updated May 19, 2016, 6:11 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav 
> Jain.
> 
> 
> Bugs: AMBARI-16752
> https://issues.apache.org/jira/browse/AMBARI-16752
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In service install wizard, pxf-hbase.jar should be added to the 
> HBASE_CLASSPATH (recommendation and validation)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> e2510eb 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47580/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> 
> Unit tests added.
> 
> Hadoop QA:
> ```
> +1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12804840/AMBARI-16752-trunk-orig.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 1 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6889//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6889//console
> This message is automatically generated.
> ```
> 
> 
> Thanks,
> 
> Matt
> 
>

Review Request 47605: AMBARI-16446 Ranger audit properties should be configured to use Ambari installed Solr (LogSearch)

2016-05-19 Thread Mugdha Varadkar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47605/
---

Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam Borad, 
Jaimin Jetly, Jayush Luniya, and Velmurugan Periasamy.


Bugs: AMBARI-16446
https://issues.apache.org/jira/browse/AMBARI-16446


Repository: ambari


Description
---

>From stack 2.5 onwards Ranger Service is dependent on Logsearch for Solr 
>instance.
Enable Audit to Solr and populate Ranger Audit properties with that Solr 
instance.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 2e18443 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 9e9cadc 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 408418c 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
 c015367 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 fabe2fb 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
 ef05604 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-env.xml
 43975af 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/metainfo.xml 
59451b2 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 3ec5d05 
  ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
f7e15aa 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
11aac72 
  ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-secured.json 
b6d7d5b 

Diff: https://reviews.apache.org/r/47605/diff/


Testing
---

Tested Ranger installation with Logsearch on centos 6.


Thanks,

Mugdha Varadkar

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

2016-05-19 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46962/#review133976
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 (line 266)


Please remove redundant spaces.
Your IDE can format this to change,

"if( x ) {"   =>  "if (x) {"

"}catch" => "} catch"

etc.



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 (line 312)


Catch NumberFormatException instead


- Alejandro Fernandez


On May 17, 2016, 10:10 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46962/
> ---
> 
> (Updated May 17, 2016, 10:10 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16242
> https://issues.apache.org/jira/browse/AMBARI-16242
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : 
> the id for dynamic entity was created in the application with the use of 
> instance data for that view. This data is dependent on users and created 
> separate sequences for each user. So the id for one user was also generated 
> for other user. Hence the data in db of one user was getting overriden by 
> other user. 
> 
> In this patch : 
> Now the id is generated using table_sequence techique of JPA. table for 
> sequence is ambari_sequence. UpgradeCatalog240.java will add the current 
> sequence number for existing tables and for new table the sequence name will 
> be added automatically. As sequence size of 50 is provided for better 
> performances
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  1f3b1d3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/persistence/DataStoreImpl.java
>  0ed260d 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/persistence/DataStoreStorage.java
>  1e8f07f 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java
>  f7f883b 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/DataStoreStorage.java
>  7ae7721 
> 
> Diff: https://reviews.apache.org/r/46962/diff/
> 
> 
> Testing
> ---
> 
> Following manual testing has been done.
> 1. upgrade script creates correct current sequences. Done by manually 
> upgrading old ambari with existing views. Next job will allocate 50 more ids
> 2. for new tables the entry in ambari_sequence is automatically added and the 
> ids will start from 1.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 46950: AMBARI-16231: mapreduce.jobhistory.http.policy & mapreduce.jobhistory.webapp.https.address property are not respected

2016-05-19 Thread Vishal Ghugare



> On May 18, 2016, 1:40 a.m., Dmytro Sen wrote:
> > Ship It!
> 
> Vishal Ghugare wrote:
> Thank you so much Dmytro! I would really appreciate if you can commit 
> these changes on my behalf to trunk ( I am not a committer).Thanks again.
> 
> Dmytro Sen wrote:
> Committed to trunk and branch-2.4
> Vishal, thank you for contributing.
> Please close this review board.

Thank you!


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46950/#review133710
---


On May 17, 2016, 11:25 a.m., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46950/
> ---
> 
> (Updated May 17, 2016, 11:25 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen and Sid Wagle.
> 
> 
> Bugs: AMBARI-16231
> https://issues.apache.org/jira/browse/AMBARI-16231
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari 2.2:
> Configure SSL for MapReduce by setting these properties in mapred-site.xml
> mapreduce.jobhistory.http.policy=HTTPS_ONLY
> mapreduce.jobhistory.webapp.https.address=host:https_port
> These properties are not respected and as a result JMX uses http protocol 
> instead of https.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
>  55e49d9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
>  a5700a9 
> 
> Diff: https://reviews.apache.org/r/46950/diff/
> 
> 
> Testing
> ---
> 
> One new test added to JMXHostProviderTest
> 
> 
> Thanks,
> 
> Vishal Ghugare
> 
>

Re: Review Request 47580: Add pxf-hbase.jar to HBASE_CLASSPATH through service_advisor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47580/#review133974
---




ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py (line 29)


Not sure if loading of PXFServiceAdvisor is necessary. The test should call 
stackAdvisor directly and that should automatically load PXF service advisor 
for the corresponding routines.


- Lav Jain


On May 19, 2016, 6:11 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47580/
> ---
> 
> (Updated May 19, 2016, 6:11 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav 
> Jain.
> 
> 
> Bugs: AMBARI-16752
> https://issues.apache.org/jira/browse/AMBARI-16752
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In service install wizard, pxf-hbase.jar should be added to the 
> HBASE_CLASSPATH (recommendation and validation)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> e2510eb 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47580/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> 
> Unit tests added.
> 
> Hadoop QA:
> ```
> +1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12804840/AMBARI-16752-trunk-orig.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 1 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6889//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6889//console
> This message is automatically generated.
> ```
> 
> 
> Thanks,
> 
> Matt
> 
>

Review Request 47596: HiveServer interactive - incorrect default memory value

2016-05-19 Thread Daniel Gergely


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47596/
---

Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and 
Sebastian Toader.


Bugs: AMBARI-16776
https://issues.apache.org/jira/browse/AMBARI-16776


Repository: ambari


Description
---

Default value of hive.llap.daemon.yarn.container.mb is not aligned to 
yarn.scheduler.minimum-allocation-mb
If the former one is less than the latter one, then hive server interactive 
wont start. So the default values must be in a proper relation.


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 db5f616 

Diff: https://reviews.apache.org/r/47596/diff/


Testing
---

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 2:15.746s
[INFO] Finished at: Thu May 19 18:52:43 CEST 2016
[INFO] Final Memory: 58M/1120M
[INFO] 


Thanks,

Daniel Gergely

Review Request 47604: View URLs: UX edits #4


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47604/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.


Bugs: AMBARI-16771
https://issues.apache.org/jira/browse/AMBARI-16771


Repository: ambari


Description
---

minor UX changes for short URL


Diffs
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js
 2b1fb3b 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
d7dc9c7 
  ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 0ad183c 
  ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html 
3a69a50 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
 2481d59 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listUrls.html
 e0b8a4e 
  ambari-admin/src/main/resources/ui/admin-web/app/views/urls/create.html 
c98ec3e 
  ambari-admin/src/main/resources/ui/admin-web/app/views/urls/edit.html 9e0ef4c 

Diff: https://reviews.apache.org/r/47604/diff/


Testing
---

manually tested


Thanks,

Pallav Kulshreshtha

Re: Review Request 47488: Ambari copies jdbc driver jar into hadoop/lib and haoop-yarn/lib

2016-05-19 Thread Dmytro Grinenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47488/#review133964
---


Ship it!




Ship It!

- Dmytro Grinenko


On May 19, 2016, 4:14 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47488/
> ---
> 
> (Updated May 19, 2016, 4:14 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Mugdha Varadkar, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16716
> https://issues.apache.org/jira/browse/AMBARI-16716
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PROBLEM:
> Ambari copies the jdbc driver (be it mysql or oracle) into 
> /usr/hdp/xxx/hadoop/lib and /usr/hdp/xxx/hadoop-yarn/lib, this can cause 
> problem for hive and other components, as user updates the jar inside 
> /usr/hdp/xx/hive/lib, but those on the hadoop and yarn lib are also in the 
> classpath.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin.py
>  3eb8591 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  d653000 
>   ambari-server/conf/unix/ambari.properties 239a731 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  bf11bf6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  bb58670 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  5e51f5f 
>   ambari-server/src/main/python/ambari_server/serverSetup.py 217d988 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  32a36a7 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py
>  1e860d9 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  784da9c 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py
>  f660562 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  30ffc8f 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
>  d0dd9bb 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
>  daf0301 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  9f5d799 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py
>  7515e9b 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  37bd77c 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py
>  3a3ecfe 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  d1268a1 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py
>  64e2060 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  d69339e 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
>  3060353 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  75924c5 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  408418c 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py
>  fe208de 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  5ec5525 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  c33d9da 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py
>  658e69f 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py
>  799447b 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  9fc0971 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py
>  1dd85e9 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  3306cf2 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/setup_ranger_yarn.py
>  1f61d41 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
>  8fc1a64 
> 
>

Re: Review Request 47488: Ambari copies jdbc driver jar into hadoop/lib and haoop-yarn/lib

2016-05-19 Thread Vitalyi Brodetskyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47488/
---

(Updated Травень 19, 2016, 4:14 після полудня)


Review request for Ambari, Andrew Onischuk, Mugdha Varadkar, and Sumit Mohanty.


Bugs: AMBARI-16716
https://issues.apache.org/jira/browse/AMBARI-16716


Repository: ambari


Description
---

PROBLEM:
Ambari copies the jdbc driver (be it mysql or oracle) into 
/usr/hdp/xxx/hadoop/lib and /usr/hdp/xxx/hadoop-yarn/lib, this can cause 
problem for hive and other components, as user updates the jar inside 
/usr/hdp/xx/hive/lib, but those on the hadoop and yarn lib are also in the 
classpath.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin.py
 3eb8591 
  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
 d653000 
  ambari-server/conf/unix/ambari.properties 239a731 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 bf11bf6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
 bb58670 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 5e51f5f 
  ambari-server/src/main/python/ambari_server/serverSetup.py 217d988 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 32a36a7 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py
 1e860d9 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
 784da9c 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py
 f660562 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 30ffc8f 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
 d0dd9bb 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
 daf0301 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 9f5d799 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py
 7515e9b 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
 37bd77c 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py
 3a3ecfe 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 d1268a1 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py
 64e2060 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 d69339e 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
 3060353 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 75924c5 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 408418c 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py
 fe208de 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
 5ec5525 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
 c33d9da 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py
 658e69f 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py
 799447b 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 9fc0971 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py
 1dd85e9 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 3306cf2 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/setup_ranger_yarn.py
 1f61d41 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
 8fc1a64 

Diff: https://reviews.apache.org/r/47488/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 47599: Add validation for alert name edit

2016-05-19 Thread Alexandr Antonenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47599/#review133961
---


Ship it!




Ship It!

- Alexandr Antonenko


On May 19, 2016, 4:02 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47599/
> ---
> 
> (Updated May 19, 2016, 4:02 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-16737
> https://issues.apache.org/jira/browse/AMBARI-16737
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, when you edit alert names, on the Ambari dashboard, there is no 
> validation and you can enter characters such as \, < etc.
> You can aslo enter more than 255 characters, the UI shows no indication of 
> error and accepts more than 255 characters. However, an exception is thrown 
> on the server side because the database column only allows 255 characters. 
> The UI should restrict this. The value in the UI gets reset to what it was 
> before you added more than 255 characters since the update failed.
>  
> Added UI validation to the alert name field.
> Also set the maxLength to 255 characters.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/messages.js 74f918d 
>   ambari-web/app/styles/alerts.less 50246e6 
>   ambari-web/app/templates/main/alerts/definition_details.hbs cda1193 
>   ambari-web/app/utils/validator.js 2906749 
>   ambari-web/app/views/main/alerts/definition_details_view.js 656021c 
>   ambari-web/test/views/main/alerts/definition_details_view_test.js a98b66b 
> 
> Diff: https://reviews.apache.org/r/47599/diff/
> 
> 
> Testing
> ---
> 
> Added new test case in definition_details_view_test.js
> Also, tested manually.
> Ran ambari-web mvn test without errors.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

2016-05-19 Thread Tim Thorpe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/
---

(Updated May 19, 2016, 3:23 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, 
and Nate Cole.


Changes
---

Switched the  tag to be  and .  
This distinguishes between the two possible meanings the  tag used to 
have.  UpgradePackTest has a test to check that a new group can be added after 
an existing group and at the same time entries in the new group can be ordered 
using the  tag, if the same group is mentioned in 
several service upgrade xml files (although the actual test just adds the same 
group twice in a service upgrade xml file).


Bugs: AMBARI-15388
https://issues.apache.org/jira/browse/AMBARI-15388


Repository: ambari


Description
---

Currently the upgrade is defined as a series of xml files specific to the 
current stack version and the target stack version. Each upgrade xml defines 
the overall sequence of the upgrade and what needs to be done for each service. 
It would both easier to maintain and easier to add new services, if the 
services themselves could specify what should be done during their upgrade.

There are two ways to make these changes, the alternate approach would be to 
only make the java changes and not split the upgrade xml files.  This would 
still allow new services to add themselves into the upgrade.  The benefit of 
this is that for the stack services you only have one upgrade xml file.  The 
problem with that is it is easier for a particular service to have 
unintentional changes between upgrade xml files.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
 7f7a49e 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
 8a7b42b 
  ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
f781574 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 
13d5047 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
5a18b3f 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
 88f6e19 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
43cefb9 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
 b860731 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
 3325469 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
 67d7fdb 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java
 5cda422 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
6b74af0 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
9fb2bba 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
1e040e6 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
e3bc7a3 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
6e27da6 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
d755516 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerMiscTest.java
 dda1e7a 
  
ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
 15be8b4 
  
ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/upgrades/HDP/2.2.0/upgrade_test_15388.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_15388.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/metainfo.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/repos/hdp.json
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/repos/repoinfo.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/repos/version-2.2.0.4-123.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/role_command_order.json
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/services/HDFS/metainfo.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/services/HDFS/upgrades/HDP/2.2.0/upgrade_test_15388.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/upgrades/config-upgrade.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/upgrades/upgrade_test_15388.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/45169/diff/


Testing
---

Manual testing so far.  I have the code read the upgrade xml and all of its 
service specific xml files, built the upgrade pack and then write

Review Request 47597: Ambari to not install rpcbind package unless NFSGateway component is included


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47597/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-16777
https://issues.apache.org/jira/browse/AMBARI-16777


Repository: ambari


Description
---

The HDFS service definition includes rpcbind, which is needed for NFSGateway
component.



Pulling the rpcbind package can be problematic in certain environments, where
other rpcbind dependencies are pulled (like Systemd).

Ambari should avoid pulling the rpcbind package unless the NFSGateway
component is being installed.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
 1ffbbde 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml 
0edbaac 

Diff: https://reviews.apache.org/r/47597/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 47590: Zero valued bars are thicker than bars with value in thousands in the Log search Log Level histograms

2016-05-19 Thread Dharmesh Makwana


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47590/
---

Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco 
Durai, Jaimin Jetly, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit 
Mohanty, and Sebastian Toader.


Bugs: AMBARI-16768
https://issues.apache.org/jira/browse/AMBARI-16768


Repository: ambari


Description
---

Zero valued bars are showing instead of bars having values greater than zero.


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dashboard/HostListView.js
 9c426f5 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/EventHistoryLayoutView.js
 bde62c0 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/LogFileView.js
 850bb6b 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/troubleshoot/TroubleShootLayoutView.js
 bbdb653 
  ambari-logsearch/ambari-logsearch-portal/src/main/webapp/styles/style.css 
85b2249 
  ambari-logsearch/ambari-logsearch-portal/src/main/webapp/styles/style_v2.css 
58a3d04 

Diff: https://reviews.apache.org/r/47590/diff/


Testing
---

Setup logsearch on 3 node cluster and tested the above features.


Thanks,

Dharmesh Makwana

Review Request 47595: Implement in ams collector batch insert operations to ams-hbase

2016-05-19 Thread Dmytro Sen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47595/
---

Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-16766
https://issues.apache.org/jira/browse/AMBARI-16766


Repository: ambari


Description
---

Check if there is performance boost after replacing insert operations with bulk 
loading. 
If yes, implement and provide switch property for enabling/disabling this 
feature.


Diffs
-

  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
 974f951 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/MetricsCacheCommitter.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
 52ab083 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
 683e5d4 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessorTest.java
 290a98a 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TestMetadataManager.java
 06c71c5 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 a7fd9c8 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
 8f369f7 

Diff: https://reviews.apache.org/r/47595/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 47018: [preview] "ambari-server upgrade" shouldn't automatically add stack configs


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47018/#review133941
---




ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 
(line 46)


bad import?



ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 
(line 298)


Make a constant or read it from XML (if you define XSD location within XML)



ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 
(lines 308 - 312)


formatting



ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 
(lines 315 - 317)


Seems awfully specific.  We know when we're parsing config XML, can this be 
done there?  Also, should we be defining the XML to use the XSD instead of 
back-checking it?



ambari-server/src/main/java/org/apache/ambari/server/state/PropertyUpgradeBehavior.java
 (line 25)


Javadoc



ambari-server/src/main/resources/property-schema.xsd (lines 41 - 42)


Requiring both?  Both should be optional I would think so that we can add 
exceptions, not the-rule.



ambari-server/src/main/resources/property-schema.xsd (lines 68 - 70)


All 3 required?



ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
 (line 77)


no *



script.sh (lines 1 - 5)


What is this?


- Nate Cole


On May 18, 2016, 1:11 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47018/
> ---
> 
> (Updated May 18, 2016, 1:11 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16272
> https://issues.apache.org/jira/browse/AMBARI-16272
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Today, "ambari-server upgrade" will automatically add stack configs.
> However, it also causes problems when default properties or properties with 
> default value such as "localhost" end up being added.
> 
> This led to many bugs. E.g., cluster with NameNode HA shouldn't automatically 
> add dfs.namenode.secondary.http-address
> 
> This logic today will even add new config types. E.g., add ranger-env even 
> though Ranger is not installed. If the customer then upgrades the stack from 
> HDP 2.2 to 2.3, and then adds Ranger, they can get the wrong configs.
> If we change this behavior, it's good to do so in a major release such as 2.4
> 
> We add required xml tags/attributes to properties:
> 
>   prop_name
>   prop_val
>   
>   
> 
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  fb3ae69 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 
> 8a352bd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 854dd0b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
> 34b3ba1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyUpgradeBehavior.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  2e857ed 
>   ambari-server/src/main/resources/property-schema.xsd PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java
>  a4a3108 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
>  8f53f6a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/PropertyInfoTest.java
>  b11c5d8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ServicePropertiesTest.java
>  PRE-CREATION 
>   ambari-server/src/test/resources/propertiesFile.xsd PRE-CREATION 
>   script.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47018/diff/
> 
> 
> Testing
> ---
> 
> patch preview for now. Feedback is welcome
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 47545: Rename atlas lineage configurations

2016-05-19 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47545/#review133948
---


Ship it!




This looks good, but you should probably test an upgrade scenario where Ambari 
version 2.2.2 with Atlas (from HDP 2.5) is installed and then upgraded to 
Ambari 2.4.0.  It may be the case that this is not a possible path, I forget 
which versions of HDP are avaialbe before Ambari 2.4.0.

- Robert Levas


On May 19, 2016, 6:36 a.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47545/
> ---
> 
> (Updated May 19, 2016, 6:36 a.m.)
> 
> 
> Review request for Ambari, Erik Bergenholtz, John Speidel, and Robert Levas.
> 
> 
> Bugs: AMBARI-16730
> https://issues.apache.org/jira/browse/AMBARI-16730
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As part of ATLAS-713, the following changes are required in atlas 
> configuration that is set by Ambari:
> 
> 1 atlas.lineage.hive.table.schema.query.Table renamed to 
> atlas.lineage.schema.query.Table
> 2 atlas.lineage.hive.table.schema.query.hive_table renamed to 
> atlas.lineage.schema.query.hive_table
> 3 delete unused lineage configs
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
>  2dab35a 
> 
> Diff: https://reviews.apache.org/r/47545/diff/
> 
> 
> Testing
> ---
> 
> manual test Atlas install
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Re: Review Request 47417: Replace '*' to hdp version in lzo packages


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47417/#review133942
---


Ship it!




Ship It!

- Andrew Onischuk


On May 17, 2016, 10:24 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47417/
> ---
> 
> (Updated May 17, 2016, 10:24 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16683
> https://issues.apache.org/jira/browse/AMBARI-16683
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As i understood(according to discussion with Andrew O) we had some jira for 
> '*' to hdp version replacement in all packages. But here it was not replaced:
> {code}
> def get_lzo_packages(stack_version_unformatted):
>   lzo_packages = []
>  
>   if OSCheck.is_redhat_family() or OSCheck.is_suse_family():
> lzo_packages += ["lzo", "hadoop-lzo-native"]
>   elif OSCheck.is_ubuntu_family():
> lzo_packages += ["liblzo2-2"]
> 
>   if stack_version_unformatted and 
> check_stack_feature(StackFeature.ROLLING_UPGRADE, stack_version_unformatted):
> lzo_packages += ["hadooplzo_*"]
>   else:
> lzo_packages += ["hadoop-lzo"]
> 
>   return lzo_packages
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py
>  e189d62 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/install_params.py
>  fe488c3 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  784da9c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  75924c5 
>   ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json 
> 47ab0a3 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json f0e5208 
>   ambari-server/src/test/python/stacks/2.0.6/configs/nn_ru_lzo.json d44b002 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json 
> b163a61 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py
>  6c7fe18 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 
> c36b428 
>   
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json
>  7b07d87 
>   ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 
> cf84bb7 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json 
> 7e5346c 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 1c75d65 
> 
> Diff: https://reviews.apache.org/r/47417/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 47531: Ambari APIs should allow using case insensitive host names


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47531/#review133940
---




ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryParser.java
 (lines 101 - 103)


What about any endpoint that takes host names embedded in json? Is that 
covered here?

A fundamental change like this requires several unit tests covering 
QueryParser and predicate processors.  Also add tests for the Request endpoint 
that take hostnames in the body (as opposed to the URL).



ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 (line 61)


What exceptions are you expecting here?  You're already null checking a 
bunch of stuff.  A TODO like this should be taken care of in this patch.


- Nate Cole


On May 18, 2016, 6 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47531/
> ---
> 
> (Updated May 18, 2016, 6 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Nate Cole, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari stores all hostnames in lower-case irrespective of the case in name 
> associated with the host. While this is OK for internal usage it causes 
> confusion to the users or the tools that look up hostname using standard 
> commands such as"hostname -f".
> The API should be modified to allow hostnames in case insensitive fashion. 
> E.g.
> api/v1/hosts/HostA and api/v1/hosts/hosta both should point to the same host
> calls that user filter where they specify hostnames should also allow case 
> insensitive comparison
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryParser.java
>  3af90ba 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  9c864b6 
> 
> Diff: https://reviews.apache.org/r/47531/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 47592: AMBARI-16772 Zeppelin restart with Ambari fails - according to Ambari

2016-05-19 Thread Renjith Kamath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47592/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Rohit Choudhary, 
and Sumit Mohanty.


Bugs: AMBARI-16772
https://issues.apache.org/jira/browse/AMBARI-16772


Repository: ambari


Description
---

- fix update_zeppelin_interpreter by removing unauthorized api call to zeppelin

error log in jira issue


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 d079096 

Diff: https://reviews.apache.org/r/47592/diff/


Testing
---

tested on centos 6.4


Thanks,

Renjith Kamath

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

2016-05-19 Thread Tim Thorpe

> On May 17, 2016, 5:39 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java,
> >  line 844
> > 
> >
> > The after tag is overloaded. Meaning it could mean insert this service 
> > after another service in some place and in some places it could mean insert 
> > this  group after another group. I am wondering if there would be a case 
> > where we would need a combination (example: Create a new group that is not 
> > in the stack upgrade pack and add 2 new services to this group in a 
> > specific order). 
> > 
> > Instead of leaving the  tag to interpretation, why not be 
> > explicit as ,  etc. That way we can 
> > support combinations
> 
> Jayush Luniya wrote:
> Example:
> 
> 
>   CORE_MASTERS
>   
> MY_MASTER_1
>   
> 
> 
> 
> 
>   CORE_MASTERS
>   MY_SERVICE_1  
>   
> MY_MASTER_2
>   
> 
>  
>  Alterative
> 
>
>   CORE_MASTERS
>   
> MY_MASTER_1
>   
> 
> 
> 
> 
>   CORE_MASTERS
>   
> MY_SERVICE_1  
> MY_MASTER_2
>   
> 
> 
> Tim Thorpe wrote:
> With custom services they should just be able to create two new groups 
> rather than try to combine them into one.  If there really is a need for the 
> a new group that spans multiple services, then it is probably a candidate for 
> inclusion in the main upgrade xml.  You can even include an empty group in 
> the main upgrade xml like:
> 
> 
> 
> Jayush Luniya wrote:
> RE: If there really is a need for the a new group that spans multiple 
> services, then it is probably a candidate for inclusion in the main upgrade 
> xml.
> Well these services are add-on services meaning say not part of HDP stack 
> itself (example: HAWQ and PFX add-on services on HDP stack). So putting them 
> in stack upgrade pack wouldnt be right. 
> 
> Yes these can be in 2 separate groups, but that would be because of this 
> restriction.
> 
> Besides its also confusing when we overload the same property element. 
> For example the group name in upgrade pack could be the service name itself 
> like below, so  STORM could mean after service STORM or after 
> group STORM :) 
> 
> 
> https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml#L356-L364
> 
>   true
>   
> NIMBUS
> SUPERVISOR
> STORM_UI_SERVER
> DRPC_SERVER
>   
> 

Currently, I'm looping through all the groups from the main upgrade xml.  I add 
those to a  map.  This means the group from the main 
upgrade xml (if there was one) will be the first group in the list.  This is 
important because I know those groups are already internally ordered.  By that 
I mean there services/priorities/stages do NOT need to be shifted in the 
overall order (all insertions into that order are determined by the subsequent 
groups in the list).

Currently when I process the service upgade xml files, for each group if the 
group name already exists in the map then this means the group existed in the 
main upgrade xml and the entries (services/priorities/stages) will be inserted 
into the original entry order based on the  tag.  If the group name 
doesn't exist, it is added with its group as the first group in the list.  In 
this case I never expect another group with the same name to be added to that 
list.

The missing piece is with this change I need to reorder the List in 
the map to find a group that doesn't have an  and if all 
groups do have that tag, then I guess I have an error situation.  Adding 
explicit tags for  and  would make it 
easier to understand.  I would prefer to limit it to two tags  
and  rather than split the  into 
separate tags for services/priorities/stages.

- Tim

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/#review133556
---

On May 18, 2016, 6:26 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45169/
> ---
> 
> (Updated May 18, 2016, 6:26 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush 
> Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-15388
> https://issues.apache.org/jira/browse/AMBARI-15388
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the upgrade is defined as a series of xml files

Re: Review Request 47529: AMBARI-16727 Add sleep time after stop of Ranger Admin for better handling of EU


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47529/#review133935
---


Ship it!




Ship It!

- Andrew Onischuk


On May 19, 2016, 11:56 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47529/
> ---
> 
> (Updated May 19, 2016, 11:56 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam 
> Borad, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16727
> https://issues.apache.org/jira/browse/AMBARI-16727
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding sleep time of 15 seconds after execution of stop command as Ranger 
> Admin process requires time to stop. Once the logic for pid is available from 
> Ranger code, will update the code.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> eca7825 
> 
> Diff: https://reviews.apache.org/r/47529/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger on centos 6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 47529: AMBARI-16727 Add sleep time after stop of Ranger Admin for better handling of EU

2016-05-19 Thread Mugdha Varadkar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47529/
---

(Updated May 19, 2016, 11:56 a.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam Borad, 
Jayush Luniya, and Velmurugan Periasamy.


Changes
---

Address Andrew's comment


Bugs: AMBARI-16727
https://issues.apache.org/jira/browse/AMBARI-16727


Repository: ambari


Description
---

Adding sleep time of 15 seconds after execution of stop command as Ranger Admin 
process requires time to stop. Once the logic for pid is available from Ranger 
code, will update the code.


Diffs (updated)
-

  ambari-common/src/main/python/resource_management/libraries/script/script.py 
eca7825 

Diff: https://reviews.apache.org/r/47529/diff/


Testing
---

Tested Ranger on centos 6


Thanks,

Mugdha Varadkar

Re: Review Request 46950: AMBARI-16231: mapreduce.jobhistory.http.policy & mapreduce.jobhistory.webapp.https.address property are not respected

2016-05-19 Thread Dmytro Sen



> On Май 18, 2016, 8:40 д.п., Dmytro Sen wrote:
> > Ship It!
> 
> Vishal Ghugare wrote:
> Thank you so much Dmytro! I would really appreciate if you can commit 
> these changes on my behalf to trunk ( I am not a committer).Thanks again.

Committed to trunk and branch-2.4
Vishal, thank you for contributing.
Please close this review board.


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46950/#review133710
---


On Май 17, 2016, 6:25 п.п., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46950/
> ---
> 
> (Updated Май 17, 2016, 6:25 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen and Sid Wagle.
> 
> 
> Bugs: AMBARI-16231
> https://issues.apache.org/jira/browse/AMBARI-16231
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari 2.2:
> Configure SSL for MapReduce by setting these properties in mapred-site.xml
> mapreduce.jobhistory.http.policy=HTTPS_ONLY
> mapreduce.jobhistory.webapp.https.address=host:https_port
> These properties are not respected and as a result JMX uses http protocol 
> instead of https.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
>  55e49d9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
>  a5700a9 
> 
> Diff: https://reviews.apache.org/r/46950/diff/
> 
> 
> Testing
> ---
> 
> One new test added to JMXHostProviderTest
> 
> 
> Thanks,
> 
> Vishal Ghugare
> 
>

Re: Review Request 47529: AMBARI-16727 Add sleep time after stop of Ranger Admin for better handling of EU


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47529/#review133933
---




ambari-common/src/main/python/resource_management/libraries/script/script.py 
(line 661)


let's call it services_to_skip


- Andrew Onischuk


On May 19, 2016, 11:30 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47529/
> ---
> 
> (Updated May 19, 2016, 11:30 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam 
> Borad, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16727
> https://issues.apache.org/jira/browse/AMBARI-16727
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding sleep time of 15 seconds after execution of stop command as Ranger 
> Admin process requires time to stop. Once the logic for pid is available from 
> Ranger code, will update the code.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> eca7825 
> 
> Diff: https://reviews.apache.org/r/47529/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger on centos 6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 47529: AMBARI-16727 Add sleep time after stop of Ranger Admin for better handling of EU

2016-05-19 Thread Mugdha Varadkar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47529/
---

(Updated May 19, 2016, 11:30 a.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam Borad, 
Jayush Luniya, and Velmurugan Periasamy.


Changes
---

Address Alejandro Fernandez comment and Adding Ranger KMS also to skip 
self.status(env)


Bugs: AMBARI-16727
https://issues.apache.org/jira/browse/AMBARI-16727


Repository: ambari


Description
---

Adding sleep time of 15 seconds after execution of stop command as Ranger Admin 
process requires time to stop. Once the logic for pid is available from Ranger 
code, will update the code.


Diffs (updated)
-

  ambari-common/src/main/python/resource_management/libraries/script/script.py 
eca7825 

Diff: https://reviews.apache.org/r/47529/diff/


Testing
---

Tested Ranger on centos 6


Thanks,

Mugdha Varadkar

Re: Review Request 47097: Tez View : Update namespace to use version info


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47097/#review133932
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On May 8, 2016, 6:02 p.m., Sreenath Somarajapuram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47097/
> ---
> 
> (Updated May 8, 2016, 6:02 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-16300
> https://issues.apache.org/jira/browse/AMBARI-16300
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - am webService namespaces just uses v2 of Tez webservice
> - Update the namespaces path to use other versions
> 
> 
> Diffs
> -
> 
>   contrib/views/tez/src/main/resources/ui/ambari-scripts/init-view.js 4b7d94d 
> 
> Diff: https://reviews.apache.org/r/47097/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sreenath Somarajapuram
> 
>

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46962/#review133929
---


Ship it!




Ship It!

- Ashwin Rajeev


On May 17, 2016, 10:10 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46962/
> ---
> 
> (Updated May 17, 2016, 10:10 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16242
> https://issues.apache.org/jira/browse/AMBARI-16242
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : 
> the id for dynamic entity was created in the application with the use of 
> instance data for that view. This data is dependent on users and created 
> separate sequences for each user. So the id for one user was also generated 
> for other user. Hence the data in db of one user was getting overriden by 
> other user. 
> 
> In this patch : 
> Now the id is generated using table_sequence techique of JPA. table for 
> sequence is ambari_sequence. UpgradeCatalog240.java will add the current 
> sequence number for existing tables and for new table the sequence name will 
> be added automatically. As sequence size of 50 is provided for better 
> performances
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  1f3b1d3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/persistence/DataStoreImpl.java
>  0ed260d 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/persistence/DataStoreStorage.java
>  1e8f07f 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java
>  f7f883b 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/DataStoreStorage.java
>  7ae7721 
> 
> Diff: https://reviews.apache.org/r/46962/diff/
> 
> 
> Testing
> ---
> 
> Following manual testing has been done.
> 1. upgrade script creates correct current sequences. Done by manually 
> upgrading old ambari with existing views. Next job will allocate 50 more ids
> 2. for new tables the entry in ambari_sequence is automatically added and the 
> ids will start from 1.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47445: Remote Cluster: UX edits #1

2016-05-19 Thread Gaurav Nagar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47445/#review133925
---


Ship it!




Ship It!

- Gaurav Nagar


On May 17, 2016, 6:02 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47445/
> ---
> 
> (Updated May 17, 2016, 6:02 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj 
> Rathore.
> 
> 
> Bugs: AMBARI-16697
> https://issues.apache.org/jira/browse/AMBARI-16697
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Made JS/HTML changes for addressing all the issues.
> 
> 
> Diffs
> -
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/index.html a4a5b28 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersEditCtrl.js
>  20eb552 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
> d7dc9c7 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/DeregisterClusterModal.js
>  PRE-CREATION 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/RemoteCluster.js
>  e4826e6 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/modals/deregisterClusterModal.html
>  PRE-CREATION 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/editRemoteClusterPage.html
>  b5890bf 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/list.html
>  e386ffd 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/modals/changePassword.html
>  a05e13d 
> 
> Diff: https://reviews.apache.org/r/47445/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 47290: [Hive view] Break in UI for Query Settings in Firefox

2016-05-19 Thread Gaurav Nagar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47290/#review133924
---


Ship it!




Ship It!

- Gaurav Nagar


On May 12, 2016, 6:35 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47290/
> ---
> 
> (Updated May 12, 2016, 6:35 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj 
> Rathore.
> 
> 
> Bugs: AMBARI-16626
> https://issues.apache.org/jira/browse/AMBARI-16626
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Make some CSS changes to fix the browser compatibilty.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss 
> 8f60595 
> 
> Diff: https://reviews.apache.org/r/47290/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 47535: Splitting command output or component's .out before logging to ambari-agent log



> On May 18, 2016, 6:23 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/ambari_commons/str_utils.py, line 85
> > 
> >
> > Deoes the last fragment also need a newline?
> 
> Andrew Onischuk wrote:
> I remove new lines at the end of every fragment. We don't them at the end 
> of fragment.

For the reference the code to remove them is:
chunks.append(chunk[:-1]) # removes last /n


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47535/#review133784
---


On May 18, 2016, 1:37 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47535/
> ---
> 
> (Updated May 18, 2016, 1:37 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-16732
> https://issues.apache.org/jira/browse/AMBARI-16732
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 85389f9 
>   ambari-common/src/main/python/ambari_commons/str_utils.py 83fc29d 
> 
> Diff: https://reviews.apache.org/r/47535/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 47535: Splitting command output or component's .out before logging to ambari-agent log



> On May 18, 2016, 6:23 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/ambari_commons/str_utils.py, line 85
> > 
> >
> > Deoes the last fragment also need a newline?

I remove new lines at the end of every fragment. We don't them at the end of 
fragment.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47535/#review133784
---


On May 18, 2016, 1:37 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47535/
> ---
> 
> (Updated May 18, 2016, 1:37 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-16732
> https://issues.apache.org/jira/browse/AMBARI-16732
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 85389f9 
>   ambari-common/src/main/python/ambari_commons/str_utils.py 83fc29d 
> 
> Diff: https://reviews.apache.org/r/47535/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 47524: Hive view : For Upload Table, 'default' DB should be selected by default


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47524/#review133921
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On May 18, 2016, 6:12 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47524/
> ---
> 
> (Updated May 18, 2016, 6:12 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav 
> Kulshreshtha.
> 
> 
> Bugs: AMBARI-16429
> https://issues.apache.org/jira/browse/AMBARI-16429
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : first db in the list was selected or was kept empty.
> 
> In this patch : 'default' hive db will be selected.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  361de7b 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
>  eb95292 
> 
> Diff: https://reviews.apache.org/r/47524/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47544: Storm REST metrics are not available when ui.port is changed

2016-05-19 Thread Vitalyi Brodetskyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47544/#review133920
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On May 18, 2016, 5:25 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47544/
> ---
> 
> (Updated May 18, 2016, 5:25 p.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-16742
> https://issues.apache.org/jira/browse/AMBARI-16742
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **STR**:  
> Change storm-site/ui.port
> 
> **Result**:  
> Some metrics are unavailable in the Storm summary
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProvider.java
>  c579705 
>   ambari-server/src/main/resources/common-services/STORM/0.10.0/metrics.json 
> 3d0fdd3 
>   ambari-server/src/main/resources/common-services/STORM/0.9.3/metrics.json 
> 2b46faf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProviderTest.java
>  de3bc82 
> 
> Diff: https://reviews.apache.org/r/47544/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 47525: Hive View : Upload table still shows file name after the upload is done


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47525/#review133919
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On May 18, 2016, 6:26 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47525/
> ---
> 
> (Updated May 18, 2016, 6:26 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav 
> Kulshreshtha.
> 
> 
> Bugs: AMBARI-16726
> https://issues.apache.org/jira/browse/AMBARI-16726
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : The UI does not get cleared properly after the upload. It still 
> shows file name.
> 
> In this patch : the UI will no longer show the old file name if the upload is 
> successfull.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/components/file-upload.js
>  1cd05ae 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
>  361de7b 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
>  eb95292 
> 
> Diff: https://reviews.apache.org/r/47525/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47526: Hive View : History tab in hive view does not show recent jobs


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47526/#review133918
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On May 18, 2016, 7:36 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47526/
> ---
> 
> (Updated May 18, 2016, 7:36 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav 
> Kulshreshtha.
> 
> 
> Bugs: AMBARI-16675
> https://issues.apache.org/jira/browse/AMBARI-16675
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earliar : hive jobs with referrer only as 'job' were being shown in history 
> 
> In this patch : all the jobs including sample, explain, visual explain will 
> be shown which was the cause for recent jobs not showning.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/Aggregator.java
>  e646fd7 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js 
> 9584508 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/routes/history.js 
> 848bee8 
> 
> Diff: https://reviews.apache.org/r/47526/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47537: View log files should pickup ambari-server log directory path