[Impala-ASF-CR] Detect bad OpenJDK version and install last known good

2018-10-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11838 ) Change subject: Detect bad OpenJDK version and install last known good .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7786: Start HMS and Sentry in debug mode in the minicluster

2018-10-30 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11826 ) Change subject: IMPALA-7786: Start HMS and Sentry in debug mode in the minicluster .. Patch Set 3: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7786: Start HMS and Sentry in debug mode in the minicluster

2018-10-30 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11826 ) Change subject: IMPALA-7786: Start HMS and Sentry in debug mode in the minicluster .. Patch Set 2: (1 comment) Seems fine except

[Impala-ASF-CR] [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files

2018-10-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11517 ) Change subject: [WIP] IMPALA-6932: Speed up scans for sequence datasets with many files .. Patch Set 3: > This can't be tested on

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 7: (14 comments) Thanks for the updates!

[Impala-ASF-CR] IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata

2018-10-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11794 ) Change subject: IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata .. Patch Set 4: > Yes,

[Impala-ASF-CR] IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata

2018-10-29 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11794 ) Change subject: IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata .. Patch Set 4:

[Impala-ASF-CR] test-with-docker: allow built images to be used with "docker run" easily.

2018-10-26 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11781 ) Change subject: test-with-docker: allow built images to be used with "docker run" easily. .. Patch Set 2: Code-Review+2 Adding up

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11731 ) Change subject: IMPALA-7698: Add centos support to bootstrap_system. .. Patch Set 7: Code-Review+2 Carrying +2. -- To view, visit

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-25 Thread Philip Zeyliger (Code Review)
Hello Quanlong Huang, Laszlo Gaal, Jim Apple, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11731 to look at the new patch set (#6). Change subject: IMPALA-7698: Add centos support to

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11731 ) Change subject: IMPALA-7698: Add centos support to bootstrap_system. .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-25 Thread Philip Zeyliger (Code Review)
Hello Quanlong Huang, Laszlo Gaal, Jim Apple, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11731 to look at the new patch set (#5). Change subject: IMPALA-7698: Add centos support to

[Impala-ASF-CR] IMPALA-7714: remove unsafe code from signal handlers

2018-10-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11777 ) Change subject: IMPALA-7714: remove unsafe code from signal handlers .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] test-with-docker: decrease image size by "de-duping" HDFS.

2018-10-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11782 Change subject: test-with-docker: decrease image size by "de-duping" HDFS. .. test-with-docker: decrease image size by "de-duping"

[Impala-ASF-CR] test-with-docker: allow built images to be used with "docker run" easily.

2018-10-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11781 Change subject: test-with-docker: allow built images to be used with "docker run" easily. .. test-with-docker: allow built images to

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11731 ) Change subject: IMPALA-7698: Add centos support to bootstrap_system. .. Patch Set 4: (6 comments) Good news--the ORC / timestamp

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-24 Thread Philip Zeyliger (Code Review)
Hello Quanlong Huang, Laszlo Gaal, Jim Apple, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11731 to look at the new patch set (#4). Change subject: IMPALA-7698: Add centos support to

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-23 Thread Philip Zeyliger (Code Review)
Hello Quanlong Huang, Laszlo Gaal, Jim Apple, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11731 to look at the new patch set (#3). Change subject: IMPALA-7698: Add centos support to

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11731 ) Change subject: IMPALA-7698: Add centos support to bootstrap_system. .. Patch Set 1: (10 comments) Thanks for the reviews!

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-23 Thread Philip Zeyliger (Code Review)
Hello Quanlong Huang, Laszlo Gaal, Jim Apple, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11731 to look at the new patch set (#2). Change subject: IMPALA-7698: Add centos support to

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 2: (6 comments) Thanks! The outline here looks

[Impala-ASF-CR] test-with-docker: add --env option to pass through env variables

2018-10-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11730 ) Change subject: test-with-docker: add --env option to pass through env variables .. Patch Set 2: (4 comments)

[Impala-ASF-CR] test-with-docker: add --env option to pass through env variables

2018-10-23 Thread Philip Zeyliger (Code Review)
Hello Laszlo Gaal, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11730 to look at the new patch set (#3). Change subject: test-with-docker: add --env option to pass through env variables

[Impala-ASF-CR] IMPALA-7668: Proper clean up of URLClassLoader

2018-10-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11594 ) Change subject: IMPALA-7668: Proper clean up of URLClassLoader .. Patch Set 2: Code-Review+2 (2 comments) Thanks. Looks fine to

[Impala-ASF-CR] test-with-docker: add --env option to pass through env variables

2018-10-22 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11730 ) Change subject: test-with-docker: add --env option to pass through env variables .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-5031: make codegen ubsan available by environment variable

2018-10-22 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11742 ) Change subject: IMPALA-5031: make codegen ubsan available by environment variable .. Patch Set 1: Code-Review+2 It took me a while

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11731 ) Change subject: IMPALA-7698: Add centos support to bootstrap_system. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11731 ) Change subject: IMPALA-7698: Add centos support to bootstrap_system. .. Patch Set 1: I triggered

[Impala-ASF-CR] test-with-docker: add --env option to pass through env variables

2018-10-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11730 Change subject: test-with-docker: add --env option to pass through env variables .. test-with-docker: add --env option to pass

[Impala-ASF-CR] IMPALA-7698: Add centos support to bootstrap system.

2018-10-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11731 Change subject: IMPALA-7698: Add centos support to bootstrap_system. .. IMPALA-7698: Add centos support to bootstrap_system.

[Impala-ASF-CR] IMPALA-7713: Add test coverage for catalogd restart when authorization is enabled

2018-10-16 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11696 ) Change subject: IMPALA-7713: Add test coverage for catalogd restart when authorization is enabled .. Patch Set 4: Code-Review+2 (2

[Impala-ASF-CR] IMPALA-7713: Add test coverage for catalogd restart when authorization is enabled

2018-10-16 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11696 ) Change subject: IMPALA-7713: Add test coverage for catalogd restart when authorization is enabled .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7713: Add test coverage for catalogd restart when authorization is enabled

2018-10-16 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11696 ) Change subject: IMPALA-7713: Add test coverage for catalogd restart when authorization is enabled .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-7709: Add options to restart catalogd and statestored in start-impala-cluster.py

2018-10-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11687 ) Change subject: IMPALA-7709: Add options to restart catalogd and statestored in start-impala-cluster.py .. Patch Set 3:

[Impala-ASF-CR] IMPALA-7708: Switch to faster deflater compression level for incr stats

2018-10-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11685 ) Change subject: IMPALA-7708: Switch to faster deflater compression level for incr stats .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7709: Add options to restart catalogd and statestored in start-impala-cluster.py

2018-10-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11687 ) Change subject: IMPALA-7709: Add options to restart catalogd and statestored in start-impala-cluster.py .. Patch Set 2: (2

[Impala-ASF-CR] IMPALA-7709: Add options to restart catalogd and statestored in start-impala-cluster.py

2018-10-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11687 ) Change subject: IMPALA-7709: Add options to restart catalogd and statestored in start-impala-cluster.py .. Patch Set 1:

[Impala-ASF-CR] IMPALA-7708: Switch to faster deflater compression strategy for incr stats

2018-10-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11685 ) Change subject: IMPALA-7708: Switch to faster deflater compression strategy for incr stats .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5031: Undefined uninitialized bool read

2018-10-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11682 ) Change subject: IMPALA-5031: Undefined uninitialized bool read .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7272: Fix crash in StringMinMaxFilter

2018-10-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11650 ) Change subject: IMPALA-7272: Fix crash in StringMinMaxFilter .. Patch Set 1: Nice catch. I'd be interested in a way that we could

[Impala-ASF-CR] IMPALA-7681. Add Azure Blob File System (ADLS Gen2) support.

2018-10-09 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11630 ) Change subject: IMPALA-7681. Add Azure Blob File System (ADLS Gen2) support. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7661: Increase the sleep time in test reconnect

2018-10-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11589 ) Change subject: IMPALA-7661: Increase the sleep time in test_reconnect .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7668: Proper clean up of URLClassLoader

2018-10-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11594 ) Change subject: IMPALA-7668: Proper clean up of URLClassLoader .. Patch Set 1: > (1 comment) I just realized the leak is actually

[Impala-ASF-CR] IMPALA-7626: Throttle catalog partial RPC requests

2018-10-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11561 ) Change subject: IMPALA-7626: Throttle catalog partial RPC requests .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-7668: Proper clean up of URLClassLoader

2018-10-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11594 ) Change subject: IMPALA-7668: Proper clean up of URLClassLoader .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Report the top 5 slowest test steps when running on S3

2018-10-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11574 ) Change subject: Report the top 5 slowest test steps when running on S3 .. Patch Set 1: Seems reasonable. I've got no objection here

[Impala-ASF-CR] IMPALA-7349: Add Admission control support for automatically setting per host memory limit for a query

2018-10-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11157 ) Change subject: IMPALA-7349: Add Admission control support for automatically setting per host memory limit for a query .. Patch Set

[Impala-ASF-CR] Prettify the timeline produced by test-with-docker.py

2018-10-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11578 ) Change subject: Prettify the timeline produced by test-with-docker.py .. Patch Set 2: Code-Review+2 I think you could move removing

[Impala-ASF-CR] IMPALA-7349: Add Admission control support for automatically setting per host memory limit for a query

2018-10-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11157 ) Change subject: IMPALA-7349: Add Admission control support for automatically setting per host memory limit for a query .. Patch Set

[Impala-ASF-CR] IMPALA-7626: Throttle catalog partial RPC requests

2018-10-03 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11561 ) Change subject: IMPALA-7626: Throttle catalog partial RPC requests .. Patch Set 6: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7581: timeout backend tests after 2 hours

2018-10-03 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11533 ) Change subject: IMPALA-7581: timeout backend tests after 2 hours .. Patch Set 1: Code-Review+2 (2 comments) Just question about

[Impala-ASF-CR] IMPALA-7626: Throttle catalog partial RPC requests

2018-10-03 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11561 ) Change subject: IMPALA-7626: Throttle catalog partial RPC requests .. Patch Set 5: (3 comments) Looks fine to me. It's a little

[Impala-ASF-CR] Use NDV=1 for a Column with all nulls

2018-10-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11528 ) Change subject: Use NDV=1 for a Column with all nulls .. Patch Set 10: Code-Review+1 (3 comments) Looks great to me; thanks for

[Impala-ASF-CR] WIP IMPALA-7626: Throttle partial RPC requests

2018-10-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11561 ) Change subject: WIP IMPALA-7626: Throttle partial RPC requests .. Patch Set 2: (1 comment) It seems like this change limits the

[Impala-ASF-CR] Revert "IMPALA-7527: add fetch-from-catalogd cache info to profile"

2018-10-01 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11560 ) Change subject: Revert "IMPALA-7527: add fetch-from-catalogd cache info to profile" .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7629: Re-enable erroneously disabled TestClientSsl tests.

2018-10-01 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11530 ) Change subject: IMPALA-7629: Re-enable erroneously disabled TestClientSsl tests. .. Patch Set 3: Code-Review+2 Carrying +2. Testing

[Impala-ASF-CR] IMPALA-7629: Re-enable erroneously disabled TestClientSsl tests.

2018-10-01 Thread Philip Zeyliger (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11530 to look at the new patch set (#3). Change subject: IMPALA-7629: Re-enable erroneously disabled TestClientSsl tests.

[Impala-ASF-CR] IMPALA-6073: Fail on misconfigured CLASSPATH.

2018-10-01 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has abandoned this change. ( http://gerrit.cloudera.org:8080/8327 ) Change subject: IMPALA-6073: Fail on misconfigured CLASSPATH. .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/8327 To

[Impala-ASF-CR] Revert "IMPALA-7622: adds profile metrics when fetching incremental stats"

2018-10-01 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11551 ) Change subject: Revert "IMPALA-7622: adds profile metrics when fetching incremental stats" .. Patch Set 1: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-7310: All-null columns give wrong estimates in planner

2018-09-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11528 ) Change subject: IMPALA-7310: All-null columns give wrong estimates in planner .. Patch Set 6: (18 comments) I'm still working

[Impala-ASF-CR] IMPALA-7531: Daemon level catalog cache metrics

2018-09-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11511 ) Change subject: IMPALA-7531: Daemon level catalog cache metrics .. Patch Set 4: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6990: TestClientSsl.test tls v12 failing due to Python SSL error

2018-09-26 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10529 ) Change subject: IMPALA-6990: TestClientSsl.test_tls_v12 failing due to Python SSL error .. Patch Set 5: I don't think that was the

[Impala-ASF-CR] IMPALA-7629: Re-enable erroneously disabled TestClientSsl tests.

2018-09-26 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11530 Change subject: IMPALA-7629: Re-enable erroneously disabled TestClientSsl tests. .. IMPALA-7629: Re-enable erroneously disabled

[Impala-ASF-CR] IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics.

2018-09-26 Thread Philip Zeyliger (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11468 to look at the new patch set (#9). Change subject: IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics.

[Impala-ASF-CR] IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics.

2018-09-26 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11468 ) Change subject: IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics. .. Patch Set 9: Code-Review+2

[Impala-ASF-CR] IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics.

2018-09-26 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11468 ) Change subject: IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics. .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-7531: Daemon level catalog cache metrics

2018-09-26 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11511 ) Change subject: IMPALA-7531: Daemon level catalog cache metrics .. Patch Set 3: (3 comments) Took another pass. I had to scratch

[Impala-ASF-CR] IMPALA-7531: Daemon level catalog cache metrics

2018-09-26 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11511 ) Change subject: IMPALA-7531: Daemon level catalog cache metrics .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Added dumping of minidumps to finalize.sh

2018-09-26 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11490 ) Change subject: Added dumping of minidumps to finalize.sh .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics.

2018-09-26 Thread Philip Zeyliger (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11468 to look at the new patch set (#8). Change subject: IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics.

[Impala-ASF-CR] IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics.

2018-09-26 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11468 ) Change subject: IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics. .. Patch Set 6: (1 comment) Thanks

[Impala-ASF-CR] IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics.

2018-09-26 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11468 ) Change subject: IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics. .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics.

2018-09-26 Thread Philip Zeyliger (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11468 to look at the new patch set (#7). Change subject: IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics.

[Impala-ASF-CR] IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics.

2018-09-26 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11468 ) Change subject: IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics. .. Patch Set 6: (19 comments)

[Impala-ASF-CR] IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics.

2018-09-26 Thread Philip Zeyliger (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11468 to look at the new patch set (#6). Change subject: IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics.

[Impala-ASF-CR] IMPALA-7624: Workaround docker/kernel bug causing test-with-docker to sometimes hang.

2018-09-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11481 ) Change subject: IMPALA-7624: Workaround docker/kernel bug causing test-with-docker to sometimes hang. .. Patch Set 2: Code-Review+2

[Impala-ASF-CR] IMPALA-7624: Workaround docker/kernel bug causing test-with-docker to sometimes hang.

2018-09-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11481 ) Change subject: IMPALA-7624: Workaround docker/kernel bug causing test-with-docker to sometimes hang. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7624: Workaround docker/kernel bug causing test-with-docker to sometimes hang.

2018-09-25 Thread Philip Zeyliger (Code Review)
Hello Laszlo Gaal, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11481 to look at the new patch set (#2). Change subject: IMPALA-7624: Workaround docker/kernel bug causing test-with-docker to sometimes hang.

[Impala-ASF-CR] IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics.

2018-09-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11468 ) Change subject: IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics. .. Patch Set 5: (4 comments) I

[Impala-ASF-CR] IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics.

2018-09-25 Thread Philip Zeyliger (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11468 to look at the new patch set (#5). Change subject: IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics.

[Impala-ASF-CR] IMPALA-7531: Daemon level catalog cache metrics

2018-09-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11511 ) Change subject: IMPALA-7531: Daemon level catalog cache metrics .. Patch Set 1: (3 comments)

[Impala-ASF-CR] Added dumping of minidumps to finalize.sh

2018-09-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11490 ) Change subject: Added dumping of minidumps to finalize.sh .. Patch Set 5: (6 comments) Minor comments. We're inconsistent here

[Impala-ASF-CR] Make IMPALA KUDU * variables override-able

2018-09-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11499 ) Change subject: Make IMPALA_KUDU_* variables override-able .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Ignore auto-generated sentry-site*.xml

2018-09-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11500 ) Change subject: Ignore auto-generated sentry-site*.xml .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Workaround docker/kernel bug causing test-with-docker to sometimes hang.

2018-09-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11481 Change subject: Workaround docker/kernel bug causing test-with-docker to sometimes hang. .. Workaround docker/kernel bug causing

[Impala-ASF-CR] Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

2018-09-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11478 ) Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep". .. Patch Set 4:

[Impala-ASF-CR] Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

2018-09-19 Thread Philip Zeyliger (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11478 to look at the new patch set (#4). Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

[Impala-ASF-CR] IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics.

2018-09-19 Thread Philip Zeyliger (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11468 to look at the new patch set (#4). Change subject: IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics.

[Impala-ASF-CR] Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

2018-09-19 Thread Philip Zeyliger (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11478 to look at the new patch set (#2). Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

[Impala-ASF-CR] IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics.

2018-09-19 Thread Philip Zeyliger (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11468 to look at the new patch set (#3). Change subject: IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics.

[Impala-ASF-CR] IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics.

2018-09-19 Thread Philip Zeyliger (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11468 to look at the new patch set (#2). Change subject: IMPALA-7596. Adding JvmPauseMonitor (and other GC) metrics to Impala metrics.

[Impala-ASF-CR] Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep".

2018-09-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11478 Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them showing up in "git grep". .. Mark certain vendored

[Impala-ASF-CR] IMPALA-7488: Fix hang in test cancellation

2018-09-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11465 ) Change subject: IMPALA-7488: Fix hang in test_cancellation .. Patch Set 1: Code-Review+2 Nice find! -- To view, visit

[Impala-ASF-CR] IMPALA-7576: Add a timeout for all E2E tests

2018-09-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11447 ) Change subject: IMPALA-7576: Add a timeout for all E2E tests .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7576: Add a timeout for all E2E tests

2018-09-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11447 ) Change subject: IMPALA-7576: Add a timeout for all E2E tests .. Patch Set 2: Code-Review+2 (1 comment) Thanks for tackling this!

[Impala-ASF-CR] IMPALA-7569: [DOCS] Removed "safety valves" from docs

2018-09-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11438 ) Change subject: IMPALA-7569: [DOCS] Removed "safety valves" from docs .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Avoid python26-ism in get query locations()

2018-09-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11419 Change subject: Avoid python26-ism in get_query_locations() .. Avoid python26-ism in get_query_locations() A recent change used a

[Impala-ASF-CR] IMPALA-7426: Use Mann-Whitney U to compare benchmarks

2018-09-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11194 ) Change subject: IMPALA-7426: Use Mann-Whitney U to compare benchmarks .. Patch Set 4: Code-Review+2 Thanks! -- To view, visit

[Impala-ASF-CR] IMPALA-7499: build against CDH Kudu

2018-09-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11363 ) Change subject: IMPALA-7499: build against CDH Kudu .. Patch Set 3: Code-Review+2 -- To view, visit

<    1   2   3   4   5   6   7   8   9   >