[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-7449: Fix network throughput calculation of DataStreamSender

2018-08-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11241 ) Change subject: IMPALA-7449: Fix network throughput calculation of DataStreamSender .. Patch Set 2: (1 comment) http://gerrit.clou

[Impala-ASF-CR] IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor

2018-08-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11232 ) Change subject: IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor .. Patch Set 4: Code-Review+1

[Impala-ASF-CR] IMPALA-376: add built-in functions for parsing JSON

2018-08-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10950 ) Change subject: IMPALA-376: add built-in functions for parsing JSON .. Patch Set 9: (12 comments) Thanks for taking this on! It i

[Impala-ASF-CR] IMPALA-7457. statestore: allow filtering by key prefix

2018-08-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11253 ) Change subject: IMPALA-7457. statestore: allow filtering by key prefix .. Patch Set 1: High level question: are string keys the right

[Impala-ASF-CR] tests: ensure consistent logging format across tests

2018-08-17 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11225 ) Change subject: tests: ensure consistent logging format across tests .. Patch Set 1: Code-Review+2 (1 comment) Than you for doing thi

[Impala-ASF-CR] tests: remove unused failure injector test library

2018-08-17 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11226 ) Change subject: tests: remove unused failure_injector test library .. Patch Set 1: Code-Review+2 We know where we can find it, so sure

[native-toolchain-CR] IMPALA-6772: add ORC 1.5.2

2018-08-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11254 Change subject: IMPALA-6772: add ORC 1.5.2 .. IMPALA-6772: add ORC 1.5.2 This version has some fixes that are needed for Impala. ORC 1

[Impala-ASF-CR] IMPALA-2422: Fix escaping in the LIKE clause

2018-08-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/10910 ) Change subject: IMPALA-2422: Fix escaping in the LIKE clause .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/10910 To unsubscribe

[Impala-ASF-CR] tests: ensure consistent logging format across tests

2018-08-17 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11225 ) Change subject: tests: ensure consistent logging format across tests .. Patch Set 1: > Patch Set 1: Code-Review+2 > > (1 comment) > > Th

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-17 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11183 to look at the new patch set (#6). Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-17 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11183 to look at the new patch set (#7). Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11183 ) Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions .. Patch Set 8: Build started: https:/

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11183 ) Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions .. Patch Set 8: Sorry for the large number o

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. IMPALA-7343: Update SentryProxy to use Sentry bulk API Prior to

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11183 ) Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions .. Patch Set 6: Build Failed https://

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 6: Code-Review+1 (1 comment) Thanks for the ref

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11183 ) Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions .. Patch Set 7: Build Failed https://

[Impala-ASF-CR] IMPALA-7345: Add the OWNER privilege

2018-08-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11245 ) Change subject: IMPALA-7345: Add the OWNER privilege .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-6989: Implement SHOW GRANT USER statement

2018-08-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11244 ) Change subject: IMPALA-6989: Implement SHOW GRANT USER statement .. Patch Set 2: (1 comment) looks fine.. main question is naming con

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 6: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-08-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 1: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 6: Code-Review+2 (2 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-7407: Fix test cancellation failure on KeyboardInterrupt

2018-08-17 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11255 Change subject: IMPALA-7407: Fix test_cancellation failure on KeyboardInterrupt .. IMPALA-7407: Fix test_cancellation failure on Keybo

[Impala-ASF-CR] IMPALA-7407: Fix test cancellation failure on KeyboardInterrupt

2018-08-17 Thread Thomas Marshall (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11255 to look at the new patch set (#2). Change subject: IMPALA-7407: Fix test_cancellation failure on KeyboardInterrupt

[Impala-ASF-CR] IMPALA-7457. statestore: allow filtering by key prefix

2018-08-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11253 ) Change subject: IMPALA-7457. statestore: allow filtering by key prefix .. Patch Set 1: > High level question: are string keys the right

[Impala-ASF-CR] IMPALA-7407: Fix test cancellation failure on KeyboardInterrupt

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11255 ) Change subject: IMPALA-7407: Fix test_cancellation failure on KeyboardInterrupt .. Patch Set 2: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-7407: Fix test cancellation failure on KeyboardInterrupt

2018-08-17 Thread Thomas Marshall (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11255 to look at the new patch set (#3). Change subject: IMPALA-7407: Fix test_cancellation failure on KeyboardInterrupt

[Impala-ASF-CR] IMPALA-7453. Intern HdfsStorageDescriptors

2018-08-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11236 ) Change subject: IMPALA-7453. Intern HdfsStorageDescriptors .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor

2018-08-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11232 ) Change subject: IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor .. Patch Set 4: Code-Review+2 --

[Impala-ASF-CR] IMPALA-7457. statestore: allow filtering by key prefix

2018-08-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11253 ) Change subject: IMPALA-7457. statestore: allow filtering by key prefix .. Patch Set 1: Code-Review+1 (1 comment) Thanks for the expla

[Impala-ASF-CR] IMPALA-7407: Fix test cancellation failure on KeyboardInterrupt

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11255 ) Change subject: IMPALA-7407: Fix test_cancellation failure on KeyboardInterrupt .. Patch Set 1: Build Failed https://jenkins.

[Impala-ASF-CR] IMPALA-7407: Fix test cancellation failure on KeyboardInterrupt

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11255 ) Change subject: IMPALA-7407: Fix test_cancellation failure on KeyboardInterrupt .. Patch Set 2: Build Failed https://jenkins.

[Impala-ASF-CR] IMPALA-7449: Fix network throughput calculation of DataStreamSender

2018-08-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11241 ) Change subject: IMPALA-7449: Fix network throughput calculation of DataStreamSender .. Patch Set 2: (1 comment) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-7407: Fix test cancellation failure on KeyboardInterrupt

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11255 ) Change subject: IMPALA-7407: Fix test_cancellation failure on KeyboardInterrupt .. Patch Set 3: Build Failed https://jenkins.

[Impala-ASF-CR] IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor

2018-08-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11232 ) Change subject: IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor .. IMPALA-7406. Avoid memory

[Impala-ASF-CR] IMPALA-7407: Fix test cancellation failure on KeyboardInterrupt

2018-08-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11255 ) Change subject: IMPALA-7407: Fix test_cancellation failure on KeyboardInterrupt .. Patch Set 3: (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. IMPALA-7343: Update SentryProxy to use Sentry bulk API Prior to

[Impala-ASF-CR] IMPALA-7345: Add the OWNER privilege

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11245 ) Change subject: IMPALA-7345: Add the OWNER privilege .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-7345: Add the OWNER privilege

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11245 ) Change subject: IMPALA-7345: Add the OWNER privilege .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verif

[Impala-ASF-CR] IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11183 ) Change subject: IMPALA-7417: Speed up sub-second unix time->TimestampValue conversions .. Patch Set 8: Verified-1 Build faile

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 7: Code-Review+2 (1 comment) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-7407: Fix test cancellation failure on KeyboardInterrupt

2018-08-17 Thread Thomas Marshall (Code Review)
Hello Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11255 to look at the new patch set (#4). Change subject: IMPALA-7407: Fix test_cancellation failure on KeyboardInterrupt

[Impala-ASF-CR] IMPALA-7407: Fix test cancellation failure on KeyboardInterrupt

2018-08-17 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11255 ) Change subject: IMPALA-7407: Fix test_cancellation failure on KeyboardInterrupt .. Patch Set 4: (1 comment) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 8: Code-Review+2 (1 comment) Carry Vuk's +2. http

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 9: Code-Review+2 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. IMPALA-7343: Update SentryProxy to use Sentry bulk API Prior to

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 9: Build started: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-7407: Fix test cancellation failure on KeyboardInterrupt

2018-08-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11255 ) Change subject: IMPALA-7407: Fix test_cancellation failure on KeyboardInterrupt .. Patch Set 4: Code-Review+2 (2 comments) http://ge

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 7: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-7407: Fix test cancellation failure on KeyboardInterrupt

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11255 ) Change subject: IMPALA-7407: Fix test_cancellation failure on KeyboardInterrupt .. Patch Set 4: Build Failed https://jenkins.

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 8: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-110: Support for multiple DISTINCT

2018-08-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10771 ) Change subject: IMPALA-110: Support for multiple DISTINCT .. Patch Set 5: (13 comments) I'm a +2 on the backend part. I took a look a

[Impala-ASF-CR] IMPALA-6989: Implement SHOW GRANT USER statement

2018-08-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11244 ) Change subject: IMPALA-6989: Implement SHOW GRANT USER statement .. Patch Set 4: (1 comment) > Patch Set 2: > > (1 comment) > > looks

[Impala-ASF-CR] IMPALA-6989: Implement SHOW GRANT USER statement

2018-08-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11244 ) Change subject: IMPALA-6989: Implement SHOW GRANT USER statement .. IMPALA-6989: Implement SHOW GRANT USER statement This patch implement

[Impala-ASF-CR] IMPALA-6989: Implement SHOW GRANT USER statement

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11244 ) Change subject: IMPALA-6989: Implement SHOW GRANT USER statement .. Patch Set 4: Build Successful https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-7345: Add the OWNER privilege

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11245 ) Change subject: IMPALA-7345: Add the OWNER privilege .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/ge

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 9: Verified-1 Build failed: https://jenkin

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 3: Code-Review+2 (1 comment) http://ger

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 9: > Patch Set 9: Verified-1 > > Build failed: http

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 9: Build started: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-7453. Intern HdfsStorageDescriptors

2018-08-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11236 ) Change subject: IMPALA-7453. Intern HdfsStorageDescriptors .. Patch Set 2: (1 comment) Added a new test assertion http://gerrit.cloude

[Impala-ASF-CR] IMPALA-7453. Intern HdfsStorageDescriptors

2018-08-17 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11236 to look at the new patch set (#3). Change subject: IMPALA-7453. Intern HdfsStorageDescriptors ...

[Impala-ASF-CR] IMPALA-7453. Intern HdfsStorageDescriptors

2018-08-17 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11236 to look at the new patch set (#4). Change subject: IMPALA-7453. Intern HdfsStorageDescriptors ...

[Impala-ASF-CR] IMPALA-7453. Intern HdfsStorageDescriptors

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11236 ) Change subject: IMPALA-7453. Intern HdfsStorageDescriptors .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit

[Impala-ASF-CR] IMPALA-7453. Intern HdfsStorageDescriptors

2018-08-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11236 ) Change subject: IMPALA-7453. Intern HdfsStorageDescriptors .. Patch Set 4: (r4 is just a rebase to resolve some conflicts against trunk)

[Impala-ASF-CR] tests: ensure consistent logging format across tests

2018-08-17 Thread Todd Lipcon (Code Review)
Hello Michael Brown, Philip Zeyliger, David Knupp, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11225 to look at the new patch set (#2). Change subject: tests: ensure consistent logging format across tests ..

[Impala-ASF-CR] tests: ensure consistent logging format across tests

2018-08-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11225 ) Change subject: tests: ensure consistent logging format across tests .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] tests: ensure consistent logging format across tests

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11225 ) Change subject: tests: ensure consistent logging format across tests .. Patch Set 2: Build started: https://jenkins.impala.io/

[Impala-ASF-CR] Revert "IMPALA-7412: width bucket() function overflows too easily"

2018-08-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11265 Change subject: Revert "IMPALA-7412: width_bucket() function overflows too easily" .. Revert "IMPALA-7412: width_bucket() function over

[Impala-ASF-CR] Revert "IMPALA-7412: width bucket() function overflows too easily"

2018-08-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11265 ) Change subject: Revert "IMPALA-7412: width_bucket() function overflows too easily" .. Patch Set 1: Code-Review+2 -- To view, visit h

[Impala-ASF-CR] Revert "IMPALA-7412: width bucket() function overflows too easily"

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11265 ) Change subject: Revert "IMPALA-7412: width_bucket() function overflows too easily" .. Patch Set 2: Build started: https://jen

[Impala-ASF-CR] Revert "IMPALA-7412: width bucket() function overflows too easily"

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11265 ) Change subject: Revert "IMPALA-7412: width_bucket() function overflows too easily" .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7453. Intern HdfsStorageDescriptors

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11236 ) Change subject: IMPALA-7453. Intern HdfsStorageDescriptors .. Patch Set 3: Build Successful https://jenkins.impala.io/job/ger

[Impala-ASF-CR] IMPALA-7453. Intern HdfsStorageDescriptors

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11236 ) Change subject: IMPALA-7453. Intern HdfsStorageDescriptors .. Patch Set 4: Build Successful https://jenkins.impala.io/job/ger

[Impala-ASF-CR] IMPALA-7449: Fix network throughput calculation of DataStreamSender

2018-08-17 Thread Michael Ho (Code Review)
Hello Lars Volker, Csaba Ringhofer, Impala Public Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11241 to look at the new patch set (#3). Change subject: IMPALA-7449: Fix network throughput calculation of DataStreamSender ..

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-17 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 3: (1 comment) http://gerrit.cloudera

[Impala-ASF-CR] tests: ensure consistent logging format across tests

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11225 ) Change subject: tests: ensure consistent logging format across tests .. Patch Set 2: Build Successful https://jenkins.impala.

[Impala-ASF-CR] [DRAFT] IMPALA-6189: Add thread watchdogs for HDFS IO calls

2018-08-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10696 ) Change subject: [DRAFT] IMPALA-6189: Add thread watchdogs for HDFS IO calls .. Patch Set 4: Any news on this? We continue to have a

[Impala-ASF-CR] tests: ensure consistent logging format across tests

2018-08-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11225 ) Change subject: tests: ensure consistent logging format across tests .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-17 Thread Zoram Thanga (Code Review)
Hello Michael Ho, anujphadke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11234 to look at the new patch set (#4). Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions.

[Impala-ASF-CR] Revert "IMPALA-7412: width bucket() function overflows too easily"

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11265 ) Change subject: Revert "IMPALA-7412: width_bucket() function overflows too easily" .. Patch Set 1: Build Successful https://

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 4: Code-Review+2 -- To view, visit http

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 4: Build started: https://jen

[Impala-ASF-CR] IMPALA-7449: Fix network throughput calculation of DataStreamSender

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11241 ) Change subject: IMPALA-7449: Fix network throughput calculation of DataStreamSender .. Patch Set 3: Build Failed https://jen

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 4: Build Successful https://

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 9: Build failed: https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-7453. Intern HdfsStorageDescriptors

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11236 ) Change subject: IMPALA-7453. Intern HdfsStorageDescriptors .. Patch Set 4: Verified-1 Build failed: https://jenkins.impala.io/

[Impala-ASF-CR] tests: remove unused failure injector test library

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11226 ) Change subject: tests: remove unused failure_injector test library .. Patch Set 2: Build started: https://jenkins.impala.io/jo

[Impala-ASF-CR] tests: ensure consistent logging format across tests

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11225 ) Change subject: tests: ensure consistent logging format across tests .. Patch Set 2: Verified+1 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-7436: initial fetch-from-catalogd implementation

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11182 ) Change subject: IMPALA-7436: initial fetch-from-catalogd implementation .. Patch Set 7: Build started: https://jenkins.impala.

[Impala-ASF-CR] Revert "IMPALA-7412: width bucket() function overflows too easily"

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11265 ) Change subject: Revert "IMPALA-7412: width_bucket() function overflows too easily" .. Revert "IMPALA-7412: width_bucke

[Impala-ASF-CR] Revert "IMPALA-7412: width bucket() function overflows too easily"

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11265 ) Change subject: Revert "IMPALA-7412: width_bucket() function overflows too easily" .. Patch Set 2: Verified+1 -- To view, vi

[Impala-ASF-CR] IMPALA-7345: Add the OWNER privilege

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11245 ) Change subject: IMPALA-7345: Add the OWNER privilege .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-7345: Add the OWNER privilege

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11245 ) Change subject: IMPALA-7345: Add the OWNER privilege .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verif

[Impala-ASF-CR] IMPALA-7345: Add the OWNER privilege

2018-08-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11245 ) Change subject: IMPALA-7345: Add the OWNER privilege .. Patch Set 3: > Patch Set 3: Verified-1 > > Build failed: https://jenkins.impala

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. IMPALA-7444: Improve logging of

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 4: Verified+1 -- To view, vi

  1   2   >