[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9797 ) Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9797 ) Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true .. Patch Set 4: Code-Review+2 Carry +2. Fixed clang-tidy

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9797 to look at the new patch set (#4). Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true

[Impala-ASF-CR] IMPALA-6747: Automate diagnostics collection.

2018-03-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9815 ) Change subject: IMPALA-6747: Automate diagnostics collection. .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-6747: Automate diagnostics collection.

2018-03-26 Thread Bharath Vissapragada (Code Review)
Hello Lars Volker, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9815 to look at the new patch set (#2). Change subject: IMPALA-6747: Automate diagnostics collection. ..

[Impala-ASF-CR] IMPALA-4123 (prep): Parquet column reader cleanup

2018-03-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9799 ) Change subject: IMPALA-4123 (prep): Parquet column reader cleanup .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6747: Automate diagnostics collection.

2018-03-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9815 ) Change subject: IMPALA-6747: Automate diagnostics collection. .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9797 ) Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6747: Automate diagnostics collection.

2018-03-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9815 Change subject: IMPALA-6747: Automate diagnostics collection. .. IMPALA-6747: Automate diagnostics collection. This commit adds

[Impala-ASF-CR] Use "mvn -B" in builds to avoid dowloading progress bars in logs.

2018-03-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9792 ) Change subject: Use "mvn -B" in builds to avoid dowloading progress bars in logs. .. Patch Set 1: Verified+1 -- To view,

[Impala-ASF-CR] Use "mvn -B" in builds to avoid dowloading progress bars in logs.

2018-03-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9792 ) Change subject: Use "mvn -B" in builds to avoid dowloading progress bars in logs. .. Use "mvn -B" in builds to avoid

[Impala-ASF-CR] IMPALA-6719: Reset metadata database name case sensitivity

2018-03-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/9788 ) Change subject: IMPALA-6719: Reset metadata database name case sensitivity .. IMPALA-6719: Reset metadata database name case sensitivity

[Impala-ASF-CR](2.x) IMPALA-6743: bump from 2.11 to 2.12

2018-03-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9809 ) Change subject: IMPALA-6743: bump from 2.11 to 2.12 .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-6743: bump from 2.11 to 2.12

2018-03-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9809 ) Change subject: IMPALA-6743: bump from 2.11 to 2.12 .. IMPALA-6743: bump from 2.11 to 2.12 Next release is 2.12 so

[Impala-ASF-CR] KUDU-2374: Add RpcContext::GetTimeReceived()

2018-03-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9807 ) Change subject: KUDU-2374: Add RpcContext::GetTimeReceived() .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] KUDU-2374: Add RpcContext::GetTimeReceived()

2018-03-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9807 ) Change subject: KUDU-2374: Add RpcContext::GetTimeReceived() .. KUDU-2374: Add RpcContext::GetTimeReceived() This

[Impala-ASF-CR] IMPALA-6510: [DOCS] Remove refresh after connect

2018-03-26 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9813 Change subject: IMPALA-6510: [DOCS] Remove refresh_after_connect .. IMPALA-6510: [DOCS] Remove refresh_after_connect Removed

[Impala-ASF-CR] IMPALA-4123 (prep): Parquet column reader cleanup

2018-03-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9799 ) Change subject: IMPALA-4123 (prep): Parquet column reader cleanup .. Patch Set 2: Carry +1. Running tests just to get clang-tidy

[Impala-ASF-CR] IMPALA-4123 (prep): Parquet column reader cleanup

2018-03-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9799 ) Change subject: IMPALA-4123 (prep): Parquet column reader cleanup .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-4123 (prep): Parquet column reader cleanup

2018-03-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9799 ) Change subject: IMPALA-4123 (prep): Parquet column reader cleanup .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-4123 (prep): Parquet column reader cleanup

2018-03-26 Thread Tim Armstrong (Code Review)
Hello Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9799 to look at the new patch set (#2). Change subject: IMPALA-4123 (prep): Parquet column reader cleanup ..

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 5: (13 comments)

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. IMPALA-6685: Improve profiles in

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 5: (1 comment) Thanks, I fixed a few other comments

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-26 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#6). Change subject: IMPALA-5842: Write page index in Parquet files

[Impala-ASF-CR] IMPALA-6719: Reset metadata database name case sensitivity

2018-03-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9788 ) Change subject: IMPALA-6719: Reset metadata database name case sensitivity .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9797 ) Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9797 ) Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true .. Patch Set 3: Code-Review+2 Carry +2 -- To view,

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9797 to look at the new patch set (#3). Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9797 ) Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Use "mvn -B" in builds to avoid dowloading progress bars in logs.

2018-03-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9792 ) Change subject: Use "mvn -B" in builds to avoid dowloading progress bars in logs. .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-03-26 Thread Zoltan Borok-Nagy (Code Review)
Hello Attila Jeges, Dimitris Tsirogiannis, Tim Armstrong, Csaba Ringhofer, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9005 to look at the new patch set (#17). Change subject: IMPALA-6314: Add run time scalar subquery check

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-03-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-6719: Reset metadata database name case sensitivity

2018-03-26 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9788 ) Change subject: IMPALA-6719: Reset metadata database name case sensitivity .. Patch Set 2: (2 comments)

[Impala-ASF-CR] [experimental] Clang Tidy Diff trial balloon

2018-03-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9751 ) Change subject: [experimental] Clang Tidy Diff trial balloon .. Patch Set 1: (1 comment)

[Impala-ASF-CR] [experimental] Clang Tidy Diff trial balloon

2018-03-26 Thread Joe McDonnell (Code Review)
Hello Jim Apple, Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9751 to look at the new patch set (#2). Change subject: [experimental] Clang Tidy Diff trial balloon

[Impala-ASF-CR] IMPALA-6338: Fix flaky test profile fragment instances

2018-03-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9718 ) Change subject: IMPALA-6338: Fix flaky test_profile_fragment_instances .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-6719: Reset metadata database name case sensitivity

2018-03-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9788 ) Change subject: IMPALA-6719: Reset metadata database name case sensitivity .. IMPALA-6719: Reset metadata database name case sensitivity

[Impala-ASF-CR](2.x) IMPALA-6743: bump from 2.11 to 2.12

2018-03-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9809 ) Change subject: IMPALA-6743: bump from 2.11 to 2.12 .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9797 ) Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-6743: bump from 2.11 to 2.12

2018-03-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9809 ) Change subject: IMPALA-6743: bump from 2.11 to 2.12 .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6731: Use private index in bootstrap virtualenv

2018-03-26 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9798 ) Change subject: IMPALA-6731: Use private index in bootstrap_virtualenv .. IMPALA-6731: Use private index in bootstrap_virtualenv

[Impala-ASF-CR] IMPALA-6731: Use private index in bootstrap virtualenv

2018-03-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9798 ) Change subject: IMPALA-6731: Use private index in bootstrap_virtualenv .. Patch Set 4: Verified+1 PS1 had passed a private build. Since

[Impala-ASF-CR] IMPALA-6731: Use private index in bootstrap virtualenv

2018-03-26 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9798 ) Change subject: IMPALA-6731: Use private index in bootstrap_virtualenv .. Patch Set 4: Code-Review+2 To the extent this is

[Impala-ASF-CR] IMPALA-6614: ClientRequestState should use HS2 TOperationState

2018-03-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9501 ) Change subject: IMPALA-6614: ClientRequestState should use HS2 TOperationState .. IMPALA-6614: ClientRequestState

[Impala-ASF-CR] IMPALA-6614: ClientRequestState should use HS2 TOperationState

2018-03-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9501 ) Change subject: IMPALA-6614: ClientRequestState should use HS2 TOperationState .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-6743: bump from 2.11 to 2.12

2018-03-26 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9809 Change subject: IMPALA-6743: bump from 2.11 to 2.12 .. IMPALA-6743: bump from 2.11 to 2.12 Next release is 2.12 so update the 2.x

[Impala-ASF-CR] KUDU-2374: Add RpcContext::GetTimeReceived()

2018-03-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9807 ) Change subject: KUDU-2374: Add RpcContext::GetTimeReceived() .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6715,IMPALA-6736: fix stress TPC workload selection

2018-03-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9758 ) Change subject: IMPALA-6715,IMPALA-6736: fix stress TPC workload selection .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6715,IMPALA-6736: fix stress TPC workload selection

2018-03-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9758 ) Change subject: IMPALA-6715,IMPALA-6736: fix stress TPC workload selection .. IMPALA-6715,IMPALA-6736: fix stress TPC

[Impala-ASF-CR] IMPALA-6724: Incorrect exception handling in create/drop function statements

2018-03-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Incorrect exception handling in create/drop function statements .. IMPALA-6724: Incorrect exception handling

[Impala-ASF-CR] IMPALA-6724: Incorrect exception handling in create/drop function statements

2018-03-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Incorrect exception handling in create/drop function statements .. IMPALA-6724: Incorrect exception handling

[Impala-ASF-CR] KUDU-2374: Add RpcContext::GetTimeReceived()

2018-03-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9807 ) Change subject: KUDU-2374: Add RpcContext::GetTimeReceived() .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] KUDU-2374: Add RpcContext::GetTimeReceived()

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9807 ) Change subject: KUDU-2374: Add RpcContext::GetTimeReceived() .. Patch Set 1: Clean cherry-pick. -- To view, visit

[Impala-ASF-CR] KUDU-2374: Add RpcContext::GetTimeReceived()

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has removed Todd Lipcon from this change. ( http://gerrit.cloudera.org:8080/9807 ) Change subject: KUDU-2374: Add RpcContext::GetTimeReceived() .. Removed reviewer Todd Lipcon. -- To view, visit

[Impala-ASF-CR] KUDU-2374: Add RpcContext::GetTimeReceived()

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9807 ) Change subject: KUDU-2374: Add RpcContext::GetTimeReceived() .. Removed reviewer Kudu Jenkins. -- To view, visit

[Impala-ASF-CR] KUDU-2374: Add RpcContext::GetTimeReceived()

2018-03-26 Thread Michael Ho (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9807 to review the following change. Change subject: KUDU-2374: Add RpcContext::GetTimeReceived() ..

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9797 ) Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9797 to look at the new patch set (#2). Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true

[Impala-ASF-CR] IMPALA-6731: Use private index in bootstrap virtualenv

2018-03-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9798 ) Change subject: IMPALA-6731: Use private index in bootstrap_virtualenv .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6731: Use private index in bootstrap virtualenv

2018-03-26 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9798 ) Change subject: IMPALA-6731: Use private index in bootstrap_virtualenv .. Patch Set 4: I've always been a little perplexed by the

[Impala-ASF-CR] IMPALA-6649: Add fine-graned ALTER privilege

2018-03-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9805 ) Change subject: IMPALA-6649: Add fine-graned ALTER privilege .. Patch Set 1: (16 comments)

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 4: (12 comments)

[Impala-ASF-CR] IMPALA-6724: Incorrect exception handling in create function statement

2018-03-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Incorrect exception handling in create function statement .. Patch Set 3: Tim, you are correct. We could

[Impala-ASF-CR] IMPALA-6731: Use private index in bootstrap virtualenv

2018-03-26 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9798 ) Change subject: IMPALA-6731: Use private index in bootstrap_virtualenv .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6641: Support more separators between date and time in default timestamp format

2018-03-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9725 ) Change subject: IMPALA-6641: Support more separators between date and time in default timestamp format .. IMPALA-6641:

[Impala-ASF-CR] IMPALA-6641: Support more separators between date and time in default timestamp format

2018-03-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9725 ) Change subject: IMPALA-6641: Support more separators between date and time in default timestamp format .. Patch Set 4:

[Impala-ASF-CR] IMPALA-6731: Use private index in bootstrap virtualenv

2018-03-26 Thread Lars Volker (Code Review)
Hello Philip Zeyliger, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9798 to look at the new patch set (#4). Change subject: IMPALA-6731: Use private index in bootstrap_virtualenv

[Impala-ASF-CR] IMPALA-6731: Use private index in bootstrap virtualenv

2018-03-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9798 ) Change subject: IMPALA-6731: Use private index in bootstrap_virtualenv .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6731: Use private index in bootstrap virtualenv

2018-03-26 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9798 ) Change subject: IMPALA-6731: Use private index in bootstrap_virtualenv .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6649: Add fine-graned ALTER privilege

2018-03-26 Thread Adam Holley (Code Review)
Adam Holley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9805 Change subject: IMPALA-6649: Add fine-graned ALTER privilege .. IMPALA-6649: Add fine-graned ALTER privilege Updated support and analysis

[Impala-ASF-CR] IMPALA-6724: Incorrect exception handling in create function statement

2018-03-26 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Incorrect exception handling in create function statement .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4123 (prep): Parquet column reader cleanup

2018-03-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9799 ) Change subject: IMPALA-4123 (prep): Parquet column reader cleanup .. Patch Set 1: Code-Review+1 (6 comments) My suggestions are

[Impala-ASF-CR] IMPALA-6724: Incorrect exception handling in create function statement

2018-03-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Incorrect exception handling in create function statement .. Patch Set 3: Oh ok, that makes a lot of

[Impala-ASF-CR] IMPALA-6731: Use private index in bootstrap virtualenv

2018-03-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9798 ) Change subject: IMPALA-6731: Use private index in bootstrap_virtualenv .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-6731: Use private index in bootstrap virtualenv

2018-03-26 Thread Lars Volker (Code Review)
Hello Philip Zeyliger, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9798 to look at the new patch set (#3). Change subject: IMPALA-6731: Use private index in bootstrap_virtualenv

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 4: (5 comments) Minor comments on the clang-tidy fixes

[Impala-ASF-CR] IMPALA-6614: ClientRequestState should use HS2 TOperationState

2018-03-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9501 ) Change subject: IMPALA-6614: ClientRequestState should use HS2 TOperationState .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-6731: Use private index in bootstrap virtualenv

2018-03-26 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9798 ) Change subject: IMPALA-6731: Use private index in bootstrap_virtualenv .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6724: Incorrect exception handling in create function statement

2018-03-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Incorrect exception handling in create function statement .. Patch Set 3: I think our hands could be

[Impala-ASF-CR] IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search

2018-03-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9770 ) Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search .. Patch Set 6: I didn't review the code in

[Impala-ASF-CR] IMPALA-6715,IMPALA-6736: fix stress TPC workload selection

2018-03-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9758 ) Change subject: IMPALA-6715,IMPALA-6736: fix stress TPC workload selection .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-6715,IMPALA-6736: fix stress TPC workload selection

2018-03-26 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9758 ) Change subject: IMPALA-6715,IMPALA-6736: fix stress TPC workload selection .. Patch Set 5: Code-Review+2 Sorry, meant to complete my

[Impala-ASF-CR] IMPALA-6724: Incorrect exception handling in create function statement

2018-03-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Incorrect exception handling in create function statement .. Patch Set 3: Doesn't this allow a bunch of

[Impala-ASF-CR] IMPALA-6715,IMPALA-6736: fix stress TPC workload selection

2018-03-26 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9758 ) Change subject: IMPALA-6715,IMPALA-6736: fix stress TPC workload selection .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-6715,IMPALA-6736: fix stress TPC workload selection

2018-03-26 Thread Michael Brown (Code Review)
Hello Nithya Janarthanan, David Knupp, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9758 to look at the new patch set (#5). Change subject: IMPALA-6715,IMPALA-6736: fix stress TPC workload selection

[Impala-ASF-CR] IMPALA-6715,IMPALA-6736: fix stress TPC workload selection

2018-03-26 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9758 ) Change subject: IMPALA-6715,IMPALA-6736: fix stress TPC workload selection .. Patch Set 4: (2 comments) Feel free to commit

[Impala-ASF-CR] IMPALA-6731: Use private index in bootstrap virtualenv

2018-03-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9798 ) Change subject: IMPALA-6731: Use private index in bootstrap_virtualenv .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6731: Use private index in bootstrap virtualenv

2018-03-26 Thread Lars Volker (Code Review)
Hello David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9798 to look at the new patch set (#2). Change subject: IMPALA-6731: Use private index in bootstrap_virtualenv ..

[Impala-ASF-CR] IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search

2018-03-26 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9770 Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search .. IMPALA-5721,IMPALA-6717,IMPALA-6738: improve

[Impala-ASF-CR] IMPALA-6724: Incorrect exception handling in create function statement

2018-03-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Incorrect exception handling in create function statement .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6724: Incorrect exception handling in create function statement

2018-03-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Incorrect exception handling in create function statement .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 5: (16 comments) Thanks Csaba! (and I also updated my

[Impala-ASF-CR] IMPALA-6724: Incorrect exception handling in create function statement

2018-03-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Incorrect exception handling in create function statement .. IMPALA-6724: Incorrect exception handling in

[Impala-ASF-CR] IMPALA-6724: Incorrect exception handling in create function statement

2018-03-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Incorrect exception handling in create function statement .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-26 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#5). Change subject: IMPALA-5842: Write page index in Parquet files

[Impala-ASF-CR] IMPALA-7631: Use private index in bootstrap virtualenv

2018-03-26 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9798 ) Change subject: IMPALA-7631: Use private index in bootstrap_virtualenv .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6724: Incorrect exception handling in create function statement

2018-03-26 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Incorrect exception handling in create function statement .. Patch Set 2: (1 comment)

  1   2   >