[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests

2018-05-04 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10269 ) Change subject: IMPALA-6802 (part 2): Clean up authorization tests .. Patch Set 4: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6802 (part 3): Clean up authorization tests

2018-05-11 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10358 ) Change subject: IMPALA-6802 (part 3): Clean up authorization tests .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6802 (part 3): Clean up authorization tests

2018-05-11 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10358 ) Change subject: IMPALA-6802 (part 3): Clean up authorization tests .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6802 (part 3): Clean up authorization tests

2018-05-15 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10358 ) Change subject: IMPALA-6802 (part 3): Clean up authorization tests .. Patch Set 2: (9 comments) Taking over for Fredy while he's out.

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-05-17 Thread Adam Holley (Code Review)
Adam Holley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10442 Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. IMPALA-6802 (part 4): Clean up authorization tests The third part

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-05-23 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-05-23 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. IMPALA-6802 (part 4): Clean up authorization tests The fourth part

[Impala-ASF-CR] IMPALA-6802 (part 3): Clean up authorization tests

2018-05-15 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10358 ) Change subject: IMPALA-6802 (part 3): Clean up authorization tests .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6802 (part 3): Clean up authorization tests

2018-05-15 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10358 ) Change subject: IMPALA-6802 (part 3): Clean up authorization tests .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-06-08 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. IMPALA-6802 (part 4): Clean up authorization tests The fourth part

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-06-12 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. Patch Set 4: Code-Review+1 Carry +1 -- To view, visit

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-06-12 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. IMPALA-6802 (part 4): Clean up authorization tests The fourth part

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-06-12 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. Patch Set 3: Code-Review+1 (6 comments) updated. carry +1

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-06-15 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. IMPALA-6802 (part 4): Clean up authorization tests The fourth part

[Impala-ASF-CR] IMPALA-7016: Implement ALTER DATABASE SET OWNER

2018-06-05 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10471 ) Change subject: IMPALA-7016: Implement ALTER DATABASE SET OWNER .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-6909: [DOCS] SET ROW FORMAT in ALTER TABLE

2018-06-04 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10452 ) Change subject: IMPALA-6909: [DOCS] SET ROW FORMAT in ALTER TABLE .. Patch Set 1: Code-Review+1 Looks good. -- To view, visit

[Impala-ASF-CR] IMPALA-6802 (part 5): Clean up authorization tests

2018-06-25 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10799 ) Change subject: IMPALA-6802 (part 5): Clean up authorization tests .. Patch Set 2: Code-Review+1 (1 comment) Just 1 nit.

[Impala-ASF-CR] IMPALA-3956 - Impala shell should ignore variables in comments

2018-06-22 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10784 ) Change subject: IMPALA-3956 - Impala shell should ignore variables in comments .. IMPALA-3956 - Impala shell should ignore variables in

[Impala-ASF-CR] IMPALA-3956 - Impala shell should ignore variables in comments

2018-06-22 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10784 ) Change subject: IMPALA-3956 - Impala shell should ignore variables in comments .. IMPALA-3956 - Impala shell should ignore variables in

[Impala-ASF-CR] IMPALA-3956 - Impala shell should ignore variables in comments

2018-06-22 Thread Adam Holley (Code Review)
Adam Holley has removed Taras Bobrovytsky from this change. ( http://gerrit.cloudera.org:8080/10784 ) Change subject: IMPALA-3956 - Impala shell should ignore variables in comments .. Removed reviewer Taras Bobrovytsky. -- To

[Impala-ASF-CR] IMPALA-6918: Implement COMMENT ON COLUMN

2018-07-02 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10754 ) Change subject: IMPALA-6918: Implement COMMENT ON COLUMN .. Patch Set 5: Code-Review+1 Only nit is in the commit message, the database

[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests

2018-05-03 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10269 ) Change subject: IMPALA-6802 (part 2): Clean up authorization tests .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6802 (part 2): Clean up authorization tests

2018-05-03 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10269 ) Change subject: IMPALA-6802 (part 2): Clean up authorization tests .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command

2018-01-06 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command .. IMPALA-4323: "SET ROW FORMAT" option added to

[Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command

2018-01-06 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command .. Patch Set 1: (4 comments) Updated patch 1.

[Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command

2018-01-06 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command .. IMPALA-4323: "SET ROW FORMAT" option added to

[Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command

2018-01-06 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command .. Patch Set 3: (10 comments) Applied changes as

[Impala-ASF-CR] IMPALA-6371: Additional check for delimiters

2018-01-07 Thread Adam Holley (Code Review)
Adam Holley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8959 Change subject: IMPALA-6371: Additional check for delimiters .. IMPALA-6371: Additional check for delimiters The check validates the

[Impala-ASF-CR] IMPALA-6371: Additional check for delimiters

2018-01-08 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8959 ) Change subject: IMPALA-6371: Additional check for delimiters .. Patch Set 1: Jenkins build successfully run here:

[Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command

2018-01-10 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command .. Patch Set 7: (5 comments) Minor updates for

[Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command

2018-01-10 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command .. IMPALA-4323: "SET ROW FORMAT" option added to

[Impala-ASF-CR] IMPALA-6371: Additional check for delimiters

2018-01-10 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8959 ) Change subject: IMPALA-6371: Additional check for delimiters .. Patch Set 3: (5 comments) Applied fixes.

[Impala-ASF-CR] IMPALA-6371: Additional check for delimiters

2018-01-10 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/8959 ) Change subject: IMPALA-6371: Additional check for delimiters .. IMPALA-6371: Additional check for delimiters The check validates the

[Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command

2018-01-10 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command .. Patch Set 5: (6 comments) Applied updates.

[Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command

2018-01-10 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command .. IMPALA-4323: "SET ROW FORMAT" option added to

[Impala-ASF-CR] IMPALA-6371: Additional check for delimiters

2018-01-08 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8959 ) Change subject: IMPALA-6371: Additional check for delimiters .. IMPALA-6371: Additional check for delimiters The check validates the

[Impala-ASF-CR] IMPALA-6371: Additional check for delimiters

2018-01-08 Thread Adam Holley (Code Review)
Adam Holley has restored this change. ( http://gerrit.cloudera.org:8080/8959 ) Change subject: IMPALA-6371: Additional check for delimiters .. Restored -- To view, visit http://gerrit.cloudera.org:8080/8959 To unsubscribe,

[Impala-ASF-CR] IMPALA-6371: Additional check for delimiters

2018-01-08 Thread Adam Holley (Code Review)
Adam Holley has abandoned this change. ( http://gerrit.cloudera.org:8080/8959 ) Change subject: IMPALA-6371: Additional check for delimiters .. Abandoned Misplaced length check. -- To view, visit

[Impala-ASF-CR] IMPALA-6371: Additional check for delimiters

2018-01-08 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8959 ) Change subject: IMPALA-6371: Additional check for delimiters .. IMPALA-6371: Additional check for delimiters The check validates the

[Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command

2018-01-12 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command .. Patch Set 9: (3 comments) Applied changes.

[Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command

2018-01-11 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command .. IMPALA-4323: "SET ROW FORMAT" option added to

[Impala-ASF-CR] IMPALA-6479: Update DESCRIBE to respect column privileges

2018-02-09 Thread Adam Holley (Code Review)
Adam Holley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9276 Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges .. IMPALA-6479: Update DESCRIBE to respect column privileges

[Impala-ASF-CR] IMPALA-6479: Update DESCRIBE to respect column privileges

2018-02-13 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9276 ) Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges .. Patch Set 1: Original patch build:

[Impala-ASF-CR] IMPALA-6479: Update DESCRIBE to respect column privileges

2018-02-13 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9276 ) Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges .. Patch Set 1: (1 comment) Quick clarification.

[Impala-ASF-CR] Added the "SET ROW FORMAT" option to the "ALTER TABLE" command.

2018-01-02 Thread Adam Holley (Code Review)
Adam Holley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8928 Change subject: Added the "SET ROW FORMAT" option to the "ALTER TABLE" command. .. Added the "SET ROW FORMAT" option to the "ALTER TABLE"

[Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command

2018-01-03 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command .. Patch Set 3: (2 comments) The build has run

[Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command

2018-01-03 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command .. IMPALA-4323: "SET ROW FORMAT" option added to

[Impala-ASF-CR] IMPALA-3956 - Impala shell should ignore variables in comments

2018-06-21 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10784 ) Change subject: IMPALA-3956 - Impala shell should ignore variables in comments .. Patch Set 1: Ran on python 2.6 and 2.7 -- To view,

[Impala-ASF-CR] IMPALA-3956 - Impala shell should ignore variables in comments

2018-06-21 Thread Adam Holley (Code Review)
Adam Holley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10784 Change subject: IMPALA-3956 - Impala shell should ignore variables in comments .. IMPALA-3956 - Impala shell should ignore variables in

[Impala-ASF-CR] IMPALA-7398: Add logged in user alias for effective user

2018-08-10 Thread Adam Holley (Code Review)
Adam Holley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11184 Change subject: IMPALA-7398: Add logged_in_user alias for effective_user .. IMPALA-7398: Add logged_in_user alias for effective_user

[Impala-ASF-CR] IMPALA-7345: Add the OWNER privilege

2018-08-15 Thread Adam Holley (Code Review)
Adam Holley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11245 Change subject: IMPALA-7345: Add the OWNER privilege .. IMPALA-7345: Add the OWNER privilege This patch adds the OWNER privilege to the

[Impala-ASF-CR] IMPALA-7345: Add the OWNER privilege

2018-08-15 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11245 ) Change subject: IMPALA-7345: Add the OWNER privilege .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-6989: Implement SHOW GRANT USER statement

2018-08-16 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11244 ) Change subject: IMPALA-6989: Implement SHOW GRANT USER statement .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-16 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7343: Update SentryProxy to use Sentry bulk API

2018-08-16 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 ) Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API .. Patch Set 4: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7027: Mulitple varchar cast fails with distinct

2018-08-13 Thread Adam Holley (Code Review)
Adam Holley has abandoned this change. ( http://gerrit.cloudera.org:8080/10858 ) Change subject: IMPALA-7027: Mulitple varchar cast fails with distinct .. Abandoned Removing for now to revisit approach. -- To view, visit

[Impala-ASF-CR] IMPALA-7466: Improve readability of describe authorization tests

2018-08-20 Thread Adam Holley (Code Review)
Adam Holley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11278 Change subject: IMPALA-7466: Improve readability of describe authorization tests .. IMPALA-7466: Improve readability of describe

[Impala-ASF-CR] IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER statements

2018-08-20 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11279 ) Change subject: IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER statements .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER statements

2018-08-21 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11279 ) Change subject: IMPALA-7344: Restrict ALTER DATABASE/TABLE SET OWNER statements .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7466: Improve readability of describe authorization tests

2018-08-21 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11278 ) Change subject: IMPALA-7466: Improve readability of describe authorization tests .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7502: ALTER TABLE RENAME should require ALL on the old table

2018-08-28 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11344 ) Change subject: IMPALA-7502: ALTER TABLE RENAME should require ALL on the old table .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7466: Improve readability of describe authorization tests

2018-08-21 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11278 ) Change subject: IMPALA-7466: Improve readability of describe authorization tests .. IMPALA-7466: Improve readability of describe

[Impala-ASF-CR] IMPALA-7466: Improve readability of describe authorization tests

2018-08-21 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11278 ) Change subject: IMPALA-7466: Improve readability of describe authorization tests .. Patch Set 1: (11 comments)

[Impala-ASF-CR] IMPALA-7466: Improve readability of describe authorization tests

2018-08-21 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11278 ) Change subject: IMPALA-7466: Improve readability of describe authorization tests .. IMPALA-7466: Improve readability of describe

[Impala-ASF-CR] IMPALA-7325: Incorrect SHOW CREATE VIEW with built-in functions

2018-07-20 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10995 ) Change subject: IMPALA-7325: Incorrect SHOW CREATE VIEW with built-in functions .. Patch Set 2: Code-Review+1 (1 comment) Good after

[Impala-ASF-CR] IMPALA-7217: Incorrect UPDATE/DELETE authorization privilege

2018-07-19 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10966 ) Change subject: IMPALA-7217: Incorrect UPDATE/DELETE authorization privilege .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7342: Add initial support for user-level permissions

2018-07-25 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11039 ) Change subject: IMPALA-7342: Add initial support for user-level permissions .. Patch Set 8: (5 comments)

[Impala-ASF-CR] IMPALA-7342: Add initial support for user-level permissions

2018-07-25 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11039 ) Change subject: IMPALA-7342: Add initial support for user-level permissions .. Patch Set 10: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7342: Add initial support for user-level permissions

2018-07-25 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11039 ) Change subject: IMPALA-7342: Add initial support for user-level permissions .. Patch Set 13: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-01 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#18). ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. IMPALA-7074: Update OWNER privilege on CREATE,

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-01 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. Patch Set 17: (22 comments)

[Impala-ASF-CR] IMPALA-7074 WIP: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-01 Thread Adam Holley (Code Review)
Adam Holley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11314 Change subject: IMPALA-7074 WIP: Update OWNER privilege on CREATE, DROP, and SET OWNER .. IMPALA-7074 WIP: Update OWNER privilege on

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-05 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#21). ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. IMPALA-7074: Update OWNER privilege on CREATE,

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-05 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. Patch Set 20: (3 comments) carry +1

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-05 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. Patch Set 21: Code-Review+1 carry +1 -- To

[Impala-ASF-CR] [DOCS] Additional updates to the fine-grained priv

2018-09-05 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11386 ) Change subject: [DOCS] Additional updates to the fine-grained priv .. Patch Set 1: (2 comments)

[Impala-ASF-CR] [DOCS] Additional updates to the fine-grained priv

2018-09-05 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11386 ) Change subject: [DOCS] Additional updates to the fine-grained priv .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-06 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. Patch Set 23: (16 comments)

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-06 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#24). ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. IMPALA-7074: Update OWNER privilege on CREATE,

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-06 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#22). ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. IMPALA-7074: Update OWNER privilege on CREATE,

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-06 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#23). ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. IMPALA-7074: Update OWNER privilege on CREATE,

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-07 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#27). ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. IMPALA-7074: Update OWNER privilege on CREATE,

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-07 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. Patch Set 23: (4 comments)

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-07 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#25). ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. IMPALA-7074: Update OWNER privilege on CREATE,

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-07 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#26). ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. IMPALA-7074: Update OWNER privilege on CREATE,

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-04 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#20). ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. IMPALA-7074: Update OWNER privilege on CREATE,

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-04 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. Patch Set 19: (1 comment)

[Impala-ASF-CR] IMPALA-6919: [DOCS] Document the COMMENT ON statement

2018-09-04 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11370 ) Change subject: IMPALA-6919: [DOCS] Document the COMMENT ON statement .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-09 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#28). ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. IMPALA-7074: Update OWNER privilege on CREATE,

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-10 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#29). ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. IMPALA-7074: Update OWNER privilege on CREATE,

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-10 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. Patch Set 29: (8 comments)

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-10 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#30). ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. IMPALA-7074: Update OWNER privilege on CREATE,

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-10 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. Patch Set 30: (3 comments)

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-10 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. Patch Set 30: (7 comments) Running test builds,

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-10 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. Patch Set 30: (2 comments) Missed a couple of

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-10 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#31). ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. IMPALA-7074: Update OWNER privilege on CREATE,

[Impala-ASF-CR] IMPALA-7027: Mulitple varchar cast fails with distinct

2018-07-10 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10858 ) Change subject: IMPALA-7027: Mulitple varchar cast fails with distinct .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-7275: Create tbl auth error should not show table

2018-07-10 Thread Adam Holley (Code Review)
Adam Holley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10919 Change subject: IMPALA-7275: Create tbl auth error should not show table .. IMPALA-7275: Create tbl auth error should not show table The

[Impala-ASF-CR] IMPALA-7275: Create table authorization error should not show table name

2018-07-11 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10919 ) Change subject: IMPALA-7275: Create table authorization error should not show table name .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-7275: Create table authorization error should not show table name

2018-07-11 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/10919 ) Change subject: IMPALA-7275: Create table authorization error should not show table name .. IMPALA-7275: Create table authorization error

  1   2   3   >