[Impala-ASF-CR] Update version to 3.1.0-SNAPSHOT

2018-05-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10360 ) Change subject: Update version to 3.1.0-SNAPSHOT .. Patch Set 2: --help -- To view, visit http://gerrit.cloudera.org:8080/10360

[Impala-ASF-CR] Update version to 3.1.0-SNAPSHOT

2018-05-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10360 ) Change subject: Update version to 3.1.0-SNAPSHOT .. Patch Set 2: test -- To view, visit http://gerrit.cloudera.org:8080/10360 To

[Impala-ASF-CR](2.x) IMPALA-6972: Disable parallel dataload on MINICLUSTER PROFILE=2

2018-05-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10367 ) Change subject: IMPALA-6972: Disable parallel dataload on MINICLUSTER_PROFILE=2 .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Fix diagnostics path to not include the parent dir structure

2018-05-09 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10347 ) Change subject: Fix diagnostics path to not include the parent dir structure .. Patch Set 2: Code-Review+2 (2 comments)

[Impala-ASF-CR] Fix diagnostics path to not include the parent dir structure

2018-05-09 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10347 ) Change subject: Fix diagnostics path to not include the parent dir structure .. Patch Set 2: Kim Jun Chul, If you want to discuss

[Impala-ASF-CR] test-with-docker: work with git worktree

2018-05-09 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10335 ) Change subject: test-with-docker: work with git worktree .. Patch Set 1: For small changes, I think we think it's fine to avoid the

[Impala-ASF-CR] Remove IMPALA THRIFT JAVA VERSION and untested Darwin Thrift versions.

2018-05-09 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10361 ) Change subject: Remove IMPALA_THRIFT_JAVA_VERSION and untested Darwin Thrift versions. .. Patch Set 1: In terms of additional

[Impala-ASF-CR] Remove IMPALA THRIFT JAVA VERSION and untested Darwin Thrift versions.

2018-05-09 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10361 Change subject: Remove IMPALA_THRIFT_JAVA_VERSION and untested Darwin Thrift versions. .. Remove IMPALA_THRIFT_JAVA_VERSION and

[Impala-ASF-CR] IMPALA-6972: Disable parallel dataload on MINICLUSTER PROFILE=2

2018-05-09 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10306 ) Change subject: IMPALA-6972: Disable parallel dataload on MINICLUSTER_PROFILE=2 .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6972: Disable parallel dataload on 2.x

2018-05-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10306 ) Change subject: IMPALA-6972: Disable parallel dataload on 2.x .. Patch Set 2: Code-Review+2 (1 comment) Note nit about the commit

[Impala-ASF-CR] IMPALA-6070: Adding ASAN, --tail to test-with-docker.

2018-05-08 Thread Philip Zeyliger (Code Review)
Hello Lars Volker, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10319 to look at the new patch set (#2). Change subject: IMPALA-6070: Adding ASAN, --tail to test-with-docker.

[Impala-ASF-CR] IMPALA-6070: Adding ASAN, --tail to test-with-docker.

2018-05-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10319 ) Change subject: IMPALA-6070: Adding ASAN, --tail to test-with-docker. .. Patch Set 1: (4 comments)

[Impala-ASF-CR] test-with-docker: work with git worktree

2018-05-07 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10335 Change subject: test-with-docker: work with git worktree .. test-with-docker: work with git worktree This commit adds a little of

[Impala-ASF-CR] test-with-docker: exit properly on failures

2018-05-07 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10318 ) Change subject: test-with-docker: exit properly on failures .. test-with-docker: exit properly on failures If the build was

[Impala-ASF-CR] test-with-docker: exit properly on failures

2018-05-07 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10318 ) Change subject: test-with-docker: exit properly on failures .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Move admission-controller and catalog metrics into own groups

2018-05-07 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10302 ) Change subject: Move admission-controller and catalog metrics into own groups .. Patch Set 2: Code-Review+2 Works for me. -- To

[Impala-ASF-CR] IMPALA-6966: sort table memory by size in catalogd web UI

2018-05-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10292 ) Change subject: IMPALA-6966: sort table memory by size in catalogd web UI .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Move admission-controller and catalog metrics into own groups

2018-05-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10302 ) Change subject: Move admission-controller and catalog metrics into own groups .. Patch Set 2: Does this break any tools that are

[Impala-ASF-CR] IMPALA-6070: Adding ASAN, --tail to test-with-docker.

2018-05-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10319 Change subject: IMPALA-6070: Adding ASAN, --tail to test-with-docker. .. IMPALA-6070: Adding ASAN, --tail to test-with-docker. *

[Impala-ASF-CR] test-with-docker: exit properly on failures

2018-05-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10318 ) Change subject: test-with-docker: exit properly on failures .. Patch Set 1: Verified+1 GVO doesn't run this, so I'm marking it as

[Impala-ASF-CR] test-with-docker: exit properly on failures

2018-05-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10318 Change subject: test-with-docker: exit properly on failures .. test-with-docker: exit properly on failures If the build was failing,

[Impala-ASF-CR] IMPALA-6949: Add the option to start the minicluster with EC enabled

2018-05-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10275 ) Change subject: IMPALA-6949: Add the option to start the minicluster with EC enabled .. Patch Set 4: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-05-03 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 11: Fredy, Can you leave pointers in the patch code to

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-05-03 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 11: > how much longer will we realistically commit

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-05-03 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 11: If there's a bug in sqlparse, have we filed it with

[Impala-ASF-CR] IMPALA-6949: Add the option to start the minicluster with EC enabled

2018-05-03 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10275 ) Change subject: IMPALA-6949: Add the option to start the minicluster with EC enabled .. Patch Set 3: Code-Review+2 (5 comments)

[Impala-ASF-CR] IMPALA-5737: Tighten minicluster memory limit

2018-05-01 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10277 ) Change subject: IMPALA-5737: Tighten minicluster memory limit .. Patch Set 1: Thanks for working on this. >From a flaky test

[Impala-ASF-CR] IMPALA-6949: Add the option to start the minicluster with EC enabled

2018-05-01 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10275 ) Change subject: IMPALA-6949: Add the option to start the minicluster with EC enabled .. Patch Set 2: (4 comments)

[Impala-ASF-CR] Speed up Python dependencies.

2018-05-01 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10234 ) Change subject: Speed up Python dependencies. .. Patch Set 5: Code-Review+2 (3 comments) I impelemented your suggestions. I ran

[Impala-ASF-CR] Speed up Python dependencies.

2018-05-01 Thread Philip Zeyliger (Code Review)
Hello Taras Bobrovytsky, Lars Volker, Michael Brown, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10234 to look at the new patch set (#5). Change subject: Speed up Python dependencies.

[Impala-ASF-CR](asf-site) Adding issues-all mailing list.

2018-05-01 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10257 ) Change subject: Adding issues-all mailing list. .. Adding issues-all mailing list. Thanks to INFRA-16440, we now have a

[Impala-ASF-CR](asf-site) Adding issues-all mailing list.

2018-05-01 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10257 ) Change subject: Adding issues-all mailing list. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10257

[Impala-ASF-CR] Speed up Python dependencies.

2018-04-30 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10234 ) Change subject: Speed up Python dependencies. .. Patch Set 3: (2 comments)

[Impala-ASF-CR] Speed up Python dependencies.

2018-04-30 Thread Philip Zeyliger (Code Review)
Hello Taras Bobrovytsky, Lars Volker, Michael Brown, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10234 to look at the new patch set (#4). Change subject: Speed up Python dependencies.

[Impala-ASF-CR](asf-site) Adding issues-all mailing list.

2018-04-30 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10257 Change subject: Adding issues-all mailing list. .. Adding issues-all mailing list. Thanks to INFRA-16440, we now have a mailing list

[Impala-ASF-CR] Speed up Python dependencies.

2018-04-30 Thread Philip Zeyliger (Code Review)
Hello Taras Bobrovytsky, Lars Volker, Michael Brown, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10234 to look at the new patch set (#3). Change subject: Speed up Python dependencies.

[Impala-ASF-CR] Speed up Python dependencies.

2018-04-30 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10234 ) Change subject: Speed up Python dependencies. .. Patch Set 2: (3 comments) I'm re-running tests on the updated patch.

[Impala-ASF-CR](2.x) IMPALA-6070: Further improvements to test-with-docker.

2018-04-30 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10248 ) Change subject: IMPALA-6070: Further improvements to test-with-docker. .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6951: Revert "Warn about Hadoop / Java version incompatibility"

2018-04-30 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10238 ) Change subject: IMPALA-6951: Revert "Warn about Hadoop / Java version incompatibility" .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] Speed up Python dependencies.

2018-04-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10234 ) Change subject: Speed up Python dependencies. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] Speed up Python dependencies.

2018-04-27 Thread Philip Zeyliger (Code Review)
Hello Taras Bobrovytsky, Michael Brown, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10234 to look at the new patch set (#2). Change subject: Speed up Python dependencies.

[Impala-ASF-CR] Speed up Python dependencies.

2018-04-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10234 Change subject: Speed up Python dependencies. .. Speed up Python dependencies. This parallelizes downloading some Python libraries,

[Impala-ASF-CR] IMPALA-6913: Simple parser for Impala profile logs.

2018-04-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9265 ) Change subject: IMPALA-6913: Simple parser for Impala profile logs. .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-6913: Simple parser for Impala profile logs.

2018-04-25 Thread Philip Zeyliger (Code Review)
Hello Bharath Vissapragada, David Knupp, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9265 to look at the new patch set (#5). Change subject: IMPALA-6913: Simple parser for Impala profile logs.

[Impala-ASF-CR] IMPALA-6740: Fix flaky test cancellation

2018-04-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10177 ) Change subject: IMPALA-6740: Fix flaky test_cancellation .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6740: Fix flaky test cancellation

2018-04-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10177 ) Change subject: IMPALA-6740: Fix flaky test_cancellation .. Patch Set 2: Code-Review+2 It's totally academic, but if you want to

[Impala-ASF-CR] IMPALA-6070: Further improvements to test-with-docker.

2018-04-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10123 ) Change subject: IMPALA-6070: Further improvements to test-with-docker. .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-6070: Further improvements to test-with-docker.

2018-04-24 Thread Philip Zeyliger (Code Review)
Hello Laszlo Gaal, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10123 to look at the new patch set (#3). Change subject: IMPALA-6070: Further improvements to test-with-docker.

[Impala-ASF-CR] IMPALA-6913: Simple parser for Impala profile logs.

2018-04-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9265 ) Change subject: IMPALA-6913: Simple parser for Impala profile logs. .. Patch Set 3: (2 comments) I added a tiny bit of cmdline

[Impala-ASF-CR] IMPALA-6913: Simple parser for Impala profile logs.

2018-04-24 Thread Philip Zeyliger (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9265 to look at the new patch set (#4). Change subject: IMPALA-6913: Simple parser for Impala profile logs.

[Impala-ASF-CR] IMPALA-6913: Simple parser for Impala profile logs.

2018-04-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9265 ) Change subject: IMPALA-6913: Simple parser for Impala profile logs. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6913: Simple parser for Impala profile logs.

2018-04-23 Thread Philip Zeyliger (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9265 to look at the new patch set (#3). Change subject: IMPALA-6913: Simple parser for Impala profile logs.

[Impala-ASF-CR] IMPALA-6070: Further improvements to test-with-docker.

2018-04-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10123 ) Change subject: IMPALA-6070: Further improvements to test-with-docker. .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-6070: Further improvements to test-with-docker.

2018-04-23 Thread Philip Zeyliger (Code Review)
Hello Laszlo Gaal, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10123 to look at the new patch set (#2). Change subject: IMPALA-6070: Further improvements to test-with-docker.

[Impala-ASF-CR] IMPALA-6899: Optimize the HDFS commands used in dataload

2018-04-20 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10120 ) Change subject: IMPALA-6899: Optimize the HDFS commands used in dataload .. Patch Set 3: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-6898: Avoid duplicate Kudu load during full dataload

2018-04-20 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10128 ) Change subject: IMPALA-6898: Avoid duplicate Kudu load during full dataload .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6917: Limit impalad mem-limit to 12GB.

2018-04-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10051 ) Change subject: IMPALA-6917: Limit impalad mem-limit to 12GB. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6070: Further improvements to test-with-docker.

2018-04-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10123 Change subject: IMPALA-6070: Further improvements to test-with-docker. .. IMPALA-6070: Further improvements to test-with-docker.

[Impala-ASF-CR] IMPALA-6878: SentryServicePinger should not print stacktrace at every retry

2018-04-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10108 ) Change subject: IMPALA-6878: SentryServicePinger should not print stacktrace at every retry .. Patch Set 2: Code-Review+2 Thanks

[Impala-ASF-CR] IMPALA-6878: SentryServicePinger should not print stacktrace at every retry

2018-04-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10108 ) Change subject: IMPALA-6878: SentryServicePinger should not print stacktrace at every retry .. Patch Set 1: (1 comment)

[Impala-ASF-CR](2.x) IMPALA-6863: Make pip download.py honor redirects.

2018-04-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10093 ) Change subject: IMPALA-6863: Make pip_download.py honor redirects. .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6749: Implement ALTER DATABASE SET DBPROPERTIES

2018-04-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10085 ) Change subject: IMPALA-6749: Implement ALTER DATABASE SET DBPROPERTIES .. Patch Set 4: I'm happy to be overridden, but I think

[Impala-ASF-CR] IMPALA-6863: Make pip download.py honor redirects.

2018-04-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10083 ) Change subject: IMPALA-6863: Make pip_download.py honor redirects. .. IMPALA-6863: Make pip_download.py honor redirects. As

[Impala-ASF-CR] Allow bootstrap system.sh to work on existing impala/ repo

2018-04-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10068 ) Change subject: Allow bootstrap_system.sh to work on existing impala/ repo .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Allow bootstrap system.sh to work on existing impala/ repo

2018-04-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10068 ) Change subject: Allow bootstrap_system.sh to work on existing impala/ repo .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6749: Implement ALTER DATABASE SET DBPROPERTIES

2018-04-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10085 ) Change subject: IMPALA-6749: Implement ALTER DATABASE SET DBPROPERTIES .. Patch Set 4: Why are we exposing this? I'm worried that

[Impala-ASF-CR] IMPALA-6863: Make pip download.py honor redirects.

2018-04-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10083 ) Change subject: IMPALA-6863: Make pip_download.py honor redirects. .. Patch Set 3: Verified+1 Code-Review+2 Whoops; thanks.

[Impala-ASF-CR] IMPALA-686: Make pip download.py honor redirects.

2018-04-16 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10083 ) Change subject: IMPALA-686: Make pip_download.py honor redirects. .. Patch Set 2: I started

[Impala-ASF-CR] IMPALA-686: Make pip download.py honor redirects.

2018-04-16 Thread Philip Zeyliger (Code Review)
Hello Lars Volker, Fredy Wijaya, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10083 to look at the new patch set (#2). Change subject: IMPALA-686: Make pip_download.py honor redirects.

[Impala-ASF-CR] Use redirection-aware downloader for pip download.py.

2018-04-16 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10083 Change subject: Use redirection-aware downloader for pip_download.py. .. Use redirection-aware downloader for pip_download.py. As

[Impala-ASF-CR] Allow bootstrap system.sh to work on existing impala/ repo

2018-04-16 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10068 ) Change subject: Allow bootstrap_system.sh to work on existing impala/ repo .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-6845: TestHdfsQueries causes some tests to be run twice

2018-04-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10053 ) Change subject: IMPALA-6845: TestHdfsQueries causes some tests to be run twice .. Patch Set 4: Nice find! If you add something

[Impala-ASF-CR] Allow bootstrap system.sh to work on existing impala/ repo

2018-04-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10068 ) Change subject: Allow bootstrap_system.sh to work on existing impala/ repo .. Patch Set 1: (1 comment) I think you and Fredy need

[Impala-ASF-CR] IMPALA-6850: Print actual error message on Sentry error

2018-04-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10064 ) Change subject: IMPALA-6850: Print actual error message on Sentry error .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6372: Go parallel for Hive dataload

2018-04-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8894 ) Change subject: IMPALA-6372: Go parallel for Hive dataload .. Patch Set 10: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6747: Automate diagnostics collection.

2018-04-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10056 ) Change subject: IMPALA-6747: Automate diagnostics collection. .. Patch Set 1: I also used the following command to verify that

[Impala-ASF-CR] IMPALA-6747: Automate diagnostics collection.

2018-04-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10056 ) Change subject: IMPALA-6747: Automate diagnostics collection. .. Patch Set 1: Code-Review+2 This is an unrevert. I helped review

[Impala-ASF-CR] IMPALA-6790: Upgrade sqlparse to 0.1.19

2018-04-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10044 ) Change subject: IMPALA-6790: Upgrade sqlparse to 0.1.19 .. Patch Set 1: > Patch Set 1: > > One potential problem is that I know

[Impala-ASF-CR] IMPALA-6917: Limit impalad mem-limit to 12GB.

2018-04-12 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10051 Change subject: IMPALA-6917: Limit impalad mem-limit to 12GB. .. IMPALA-6917: Limit impalad mem-limit to 12GB. This changes the

[Impala-ASF-CR] Fix test query concurrency exception handling.

2018-04-12 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10049 Change subject: Fix test_query_concurrency exception handling. .. Fix test_query_concurrency exception handling. Fixes use of an

[Impala-ASF-CR] IMPALA-6809: Allow bootstrap system.sh in non ~/Impala directory

2018-04-12 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9994 ) Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory .. Patch Set 6: (1 comment) One more quick thing.

[Impala-ASF-CR](2.x) IMPALA-5717: Support for reading ORC data files

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9988 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 1: Thanks for pro-actively doing the cherry-pick. I

[Impala-ASF-CR](2.x) IMPALA-6805: Show current database in Impala shell prompt

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10024 ) Change subject: IMPALA-6805: Show current database in Impala shell prompt .. IMPALA-6805: Show current database in Impala

[Impala-ASF-CR](2.x) IMPALA-6805: Show current database in Impala shell prompt

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10024 ) Change subject: IMPALA-6805: Show current database in Impala shell prompt .. Patch Set 2: Verified+1 Code-Review+2 I ran

[Impala-ASF-CR] IMPALA-6837: allow multiple networks for distcc server

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10029 ) Change subject: IMPALA-6837: allow multiple networks for distcc server .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6809: Allow bootstrap system.sh in non ~/Impala directory

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9994 ) Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory .. Patch Set 3: (3 comments) Seems fine. I've got

[Impala-ASF-CR] Add --partial ok to compare branches.py.

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10025 ) Change subject: Add --partial_ok to compare_branches.py. .. Patch Set 1: Verified+1 GVD is not helpful with this script, so I'm

[Impala-ASF-CR](2.x) Add --partial ok to compare branches.py.

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10027 Change subject: Add --partial_ok to compare_branches.py. .. Add --partial_ok to compare_branches.py. This change lets

[Impala-ASF-CR](2.x) Add --partial ok to compare branches.py.

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10027 ) Change subject: Add --partial_ok to compare_branches.py. .. Add --partial_ok to compare_branches.py. This change lets

[Impala-ASF-CR](2.x) Add --partial ok to compare branches.py.

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10027 ) Change subject: Add --partial_ok to compare_branches.py. .. Patch Set 1: Verified+1 Code-Review+2 Clean pick. -- To view, visit

[Impala-ASF-CR] Add --partial ok to compare branches.py.

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10025 ) Change subject: Add --partial_ok to compare_branches.py. .. Add --partial_ok to compare_branches.py. This change lets

[Impala-ASF-CR] IMPALA-4631: loosen monotonic clock DCHECK

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10026 ) Change subject: IMPALA-4631: loosen monotonic clock DCHECK .. Patch Set 1: Code-Review+2 (2 comments) Weird. +2 but see my

[Impala-ASF-CR] Add --partial ok to compare branches.py.

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10025 Change subject: Add --partial_ok to compare_branches.py. .. Add --partial_ok to compare_branches.py. This change lets

[Impala-ASF-CR] IMPALA-6811: Increase timeout on S3 for test exchange delays

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9995 ) Change subject: IMPALA-6811: Increase timeout on S3 for test_exchange_delays .. Patch Set 2: Somewhere along the way, you mentioned

[Impala-ASF-CR] Move some test spilling debug actions to exhaustive

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9976 ) Change subject: Move some test_spilling debug actions to exhaustive .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] Move some test spilling debug actions to exhaustive

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9976 ) Change subject: Move some test_spilling debug actions to exhaustive .. Patch Set 2: Code-Review+2 (2 comments) Alex Behm pointed

[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control

2018-04-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9964 ) Change subject: IMPALA-5814: Remove startup flag to disable admission control .. Patch Set 2: Code-Review+1 All the changes looked

[Impala-ASF-CR](2.x) Updating ignored commits.

2018-04-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9971 ) Change subject: Updating ignored_commits. .. Updating ignored_commits. Cherrypicking was stuck due to two changes needing to

[Impala-ASF-CR](2.x) Updating ignored commits.

2018-04-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9971 Change subject: Updating ignored_commits. .. Updating ignored_commits. Cherrypicking was stuck due to two changes needing to have

[Impala-ASF-CR](2.x) Updating ignored commits.

2018-04-10 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9971 ) Change subject: Updating ignored_commits. .. Patch Set 1: Verified+1 I ran cherry-pick successfully with this. GVO wouldn't do

<    1   2   3   4   5   6   7   8   9   >