Lars Volker has posted comments on this change.
Change subject: Impala-992: Rerun past queries from history in shell
..
Patch Set 2:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/7674/2//COMMIT_MSG
Commit Message:
PS2,
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5109: Increase range of backend latency histogram
..
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1059/
--
To
Impala Public Jenkins has posted comments on this change.
Change subject: Fix link to Hadoop ADLS page
..
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/147/
--
To view, visit
Impala Public Jenkins has posted comments on this change.
Change subject: [DOCS] Fold some lines
..
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/148/
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2
..
Patch Set 2:
(2 comments)
Looks good, just had minor comments.
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7678
Change subject: IMPALA-5644: Reject queries if min reservation is too large
..
IMPALA-5644: Reject queries if min reservation is too
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5787: Dropped status in KuduTableSink::Send()
..
Patch Set 1: Code-Review+2
(1 comment)
I'm OK with making this change now, but there are a bunch of
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7677
Change subject: IMPALA-5477: Fix minidump-2-core tool
..
IMPALA-5477: Fix minidump-2-core tool
This change bumps the toolchain version to
Jim Apple has posted comments on this change.
Change subject: IMPALA-5764: Allow overriding packaged components
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7581/2/bin/impala-config.sh
File
Michael Brown has posted comments on this change.
Change subject: Impala-992: Rerun past queries from history in shell
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7674/2/shell/impala_shell.py
File
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5764: Allow overriding packaged components
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7581/2/bin/impala-config.sh
File
Thomas Tauber-Marshall has posted comments on this change.
Change subject: IMPALA-5477: Fix minidump-2-core tool
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7677
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5776: Write partial tuple to the correct mempool
..
Patch Set 2:
(6 comments)
This is already easier to understand but I'm hoping we can avoid adding
Impala Public Jenkins has submitted this change and it was merged.
Change subject: Fix link to Hadoop ADLS page
..
Fix link to Hadoop ADLS page
At the time I added the original link, the
URL with /current2/ was correct. Now
Impala Public Jenkins has posted comments on this change.
Change subject: Fix link to Hadoop ADLS page
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7672
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5109: Increase range of backend latency histogram
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7676
To unsubscribe,
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4833: Compute precise per-host reservation size
..
Patch Set 8:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/7630/8/be/src/scheduling/query-schedule.h
Sailesh Mukil has posted comments on this change.
Change subject: Impala-992: Rerun past queries from history in shell
..
Patch Set 2:
(3 comments)
Could you add some tests for this too?
Have a look at
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4737: Prevent SIGUSR1 from killing daemons when
minidumps are disabled
..
Patch Set 2: Code-Review+2
--
To view, visit
Alex Behm has posted comments on this change.
Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7643
To unsubscribe,
Alex Behm has posted comments on this change.
Change subject: IMPALA-5776: Write partial tuple to the correct mempool
..
Patch Set 4: Code-Review+1
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5598: Fix excessive dumping in MemLimitExceeded
..
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7597/3/be/src/runtime/mem-tracker.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5769: Add periodic minidump cleanup
..
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/7605/2/tests/custom_cluster/test_breakpad.py
File
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5116: Remove deprecated hash_* types in gutil
..
IMPALA-5116: Remove deprecated hash_* types in gutil
The following class templates are
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5116: Remove deprecated hash_* types in gutil
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7414
To unsubscribe,
Tianyi Wang has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7674
Change subject: Impala-992: Rerun past queries from history in shell
..
Impala-992: Rerun past queries from history in shell
This patch
Impala Public Jenkins has submitted this change and it was merged.
Change subject: [DOCS] Fold some lines
..
[DOCS] Fold some lines
Putting on a separate line causes an extra
leading blank line in PDF output. (I think
Impala Public Jenkins has posted comments on this change.
Change subject: [DOCS] Fold some lines
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7417
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types
..
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7526/8/be/src/codegen/llvm-codegen.cc
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5776: Write partial tuple to the correct mempool
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7639/4/be/src/exec/hdfs-text-scanner.h
Lars Volker has posted comments on this change.
Change subject: IMPALA-4737: Prevent SIGUSR1 from killing daemons when
minidumps are disabled
..
Patch Set 3: Code-Review+2
Rebased, carrying Tim's +2.
--
To view, visit
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4737: Prevent SIGUSR1 from killing daemons when
minidumps are disabled
..
Patch Set 3:
Build started:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5776: Write partial tuple to the correct mempool
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7639/4/be/src/exec/hdfs-text-scanner.h
Tianyi Wang has uploaded a new patch set (#3).
Change subject: IMPALA-992: Rerun past queries from history in shell
..
IMPALA-992: Rerun past queries from history in shell
This patch adds a new command "rerun" and shortcut "@"
John Russell has posted comments on this change.
Change subject: IMPALA-5309: [DOCS] Add TABLESAMPLE clause to SELECT statement
..
Patch Set 1:
For my TABLESAMPLE examples, I used a trivial amount of data just to make it
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5598: Fix excessive dumping in MemLimitExceeded
..
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1063/
--
To
Lars Volker has posted comments on this change.
Change subject: IMPALA-992: Rerun past queries from history in shell
..
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7674/4/shell/impala_shell.py
File
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5787: Dropped status in KuduTableSink::Send()
..
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1064/
--
To
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7682
Change subject: IMPALA-5316: [DOCS] Document last_day() function
..
IMPALA-5316: [DOCS] Document last_day() function
Change-Id:
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-5776: Write partial tuple to the correct mempool
..
Patch Set 4:
(2 comments)
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5109: Increase range of backend latency histogram
..
IMPALA-5109: Increase range of backend latency histogram
Tiny change to increase
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5109: Increase range of backend latency histogram
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7676
To
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7597
to look at the new patch set (#4).
Change subject: IMPALA-5598: Fix excessive dumping in MemLimitExceeded
..
Joe McDonnell has posted comments on this change.
Change subject: IMPALA-5598: Fix excessive dumping in MemLimitExceeded
..
Patch Set 3:
(2 comments)
Also rebased to the latest.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types
..
Patch Set 12:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/7526/12/be/src/codegen/codegen-anyval.cc
Hello Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7605
to look at the new patch set (#3).
Change subject: IMPALA-5769: Add periodic minidump cleanup
..
IMPALA-5769: Add
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3200: More end-to-end tests
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7668/2/tests/verifiers/metric_verifier.py
File
Lars Volker has posted comments on this change.
Change subject: IMPALA-5769: Add periodic minidump cleanup
..
Patch Set 2:
(4 comments)
Thanks for the reviews. Please see PS3.
Tianyi Wang has uploaded a new patch set (#5).
Change subject: IMPALA-992: Rerun past queries from history in shell
..
IMPALA-992: Rerun past queries from history in shell
This patch adds a new command "rerun" and shortcut "@"
Tianyi Wang has uploaded a new patch set (#5).
Change subject: IMPALA-992: Rerun past queries from history in shell
..
IMPALA-992: Rerun past queries from history in shell
This patch adds a new command "rerun" and shortcut "@"
Hello Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7675
to look at the new patch set (#3).
Change subject: IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2
..
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2
..
Patch Set 2:
(2 comments)
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7679
Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version
..
IMPALA-5800: Configure Squeasel's cipher suite and
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5598: Fix excessive dumping in MemLimitExceeded
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7597
To unsubscribe, visit
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-992: Rerun past queries from history in shell
..
Patch Set 4:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/7674/2//COMMIT_MSG
Commit Message:
PS2,
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7681
Change subject: IMPALA-4833: Compute precise per-host reservation size, pt2
..
IMPALA-4833: Compute precise per-host reservation size,
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4833: Compute precise per-host reservation size, pt2
..
Patch Set 1: Code-Review+1
This looks good to me, but let's still discuss.
--
To view, visit
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-992: Rerun past queries from history in shell
..
Patch Set 7: Code-Review+1
(1 comment)
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5477: Fix minidump-2-core tool
..
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1061/
--
To view, visit
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4737: Prevent SIGUSR1 from killing daemons when
minidumps are disabled
..
Patch Set 2:
Build started:
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-992: Rerun past queries from history in shell
..
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7674/4/shell/impala_shell.py
File
Lars Volker has posted comments on this change.
Change subject: IMPALA-992: Rerun past queries from history in shell
..
Patch Set 5:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/7674/5//COMMIT_MSG
Commit Message:
Line 9:
Tianyi Wang has uploaded a new patch set (#7).
Change subject: IMPALA-992: Rerun past queries from history in shell
..
IMPALA-992: Rerun past queries from history in shell
This patch adds a new command "rerun" and a shortcut
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-992: Rerun past queries from history in shell
..
Patch Set 5:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/7674/5//COMMIT_MSG
Commit Message:
Line 9:
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-992: Rerun past queries from history in shell
..
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7674/7/tests/shell/test_shell_interactive.py
Hello Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7674
to look at the new patch set (#8).
Change subject: IMPALA-992: Rerun past queries from history in shell
..
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5644: Reject queries if min reservation is too large
..
Patch Set 1:
(4 comments)
The overall approach makes sense to me. Commented on the aspects of it
Tianyi Wang has uploaded a new patch set (#4).
Change subject: IMPALA-992: Rerun past queries from history in shell
..
IMPALA-992: Rerun past queries from history in shell
This patch adds a new command "rerun" and shortcut "@"
Tianyi Wang has uploaded a new patch set (#4).
Change subject: IMPALA-992: Rerun past queries from history in shell
..
IMPALA-992: Rerun past queries from history in shell
This patch adds a new command "rerun" and shortcut "@"
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7680
Change subject: IMPALA-5309: [DOCS] Add TABLESAMPLE clause to SELECT statement
..
IMPALA-5309: [DOCS] Add TABLESAMPLE clause to SELECT
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5769: Add periodic minidump cleanup
..
Patch Set 3: Code-Review+2
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7675
To unsubscribe,
Tim Armstrong has uploaded a new patch set (#3).
Change subject: IMPALA-3200: More end-to-end tests
..
IMPALA-3200: More end-to-end tests
* Test that query startup fails if there is insufficient reservation on
one backend.
*
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3200: More end-to-end tests
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7668/2/tests/verifiers/metric_verifier.py
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7253/9/be/src/util/runtime-profile.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 9:
Yeah we could drop it for Status return values. We would keep it for bool or
other return values
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4737: Prevent SIGUSR1 from killing daemons when
minidumps are disabled
..
Patch Set 3: Verified+1
--
To view, visit
Lars Volker has posted comments on this change.
Change subject: IMPALA-992: Rerun past queries from history in shell
..
Patch Set 9: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7674
To unsubscribe, visit
Lars Volker has posted comments on this change.
Change subject: IMPALA-5769: Add periodic minidump cleanup
..
Patch Set 4: Code-Review+2
Needed a rebase. Carrying Tim's +2.
--
To view, visit
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5769: Add periodic minidump cleanup
..
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1070/
--
To view, visit
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2
..
Patch Set 3: Verified-1
Build failed:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3200: More end-to-end tests
..
Patch Set 5: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/7668
To unsubscribe, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7679/1//COMMIT_MSG
Commit
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version
..
IMPALA-5800: Configure Squeasel's cipher suite and TLS version
* Import Squeasel from
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version
..
Patch Set 1:
(1 comment)
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3200: More end-to-end tests
..
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1069/
--
To view, visit
Hello Jim Apple, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7253
to look at the new patch set (#11).
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2
..
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1067/
--
To
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 11:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1068/
--
To view,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: support [[nodiscard]] on Status
..
Patch Set 11: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/7253
To unsubscribe,
Greg Rahn has posted comments on this change.
Change subject: IMPALA-5316: [DOCS] Document last_day() function
..
Patch Set 1: Code-Review+1
LGTM. Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/7682
To
Hello Michael Ho, Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7526
to look at the new patch set (#13).
Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types
Tim Armstrong has uploaded a new patch set (#4).
Change subject: IMPALA-3200: More end-to-end tests
..
IMPALA-3200: More end-to-end tests
* Test that query startup fails if there is insufficient reservation on
one backend.
*
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5477: Fix minidump-2-core tool
..
IMPALA-5477: Fix minidump-2-core tool
This change bumps the toolchain version to include a fix for
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5477: Fix minidump-2-core tool
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7677
To unsubscribe, visit
Hello Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7674
to look at the new patch set (#9).
Change subject: IMPALA-992: Rerun past queries from history in shell
..
Tianyi Wang has uploaded a new patch set (#9).
Change subject: IMPALA-992: Rerun past queries from history in shell
..
IMPALA-992: Rerun past queries from history in shell
This patch adds a new command "rerun" and a shortcut
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-992: Rerun past queries from history in shell
..
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7674/8/tests/shell/test_shell_interactive.py
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4737: Prevent SIGUSR1 from killing daemons when
minidumps are disabled
..
IMPALA-4737: Prevent SIGUSR1 from killing daemons when
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5316: [DOCS] Document last_day() function
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7682
To unsubscribe, visit
1 - 100 of 131 matches
Mail list logo
