[Impala-ASF-CR] IMPALA-5756: start memory maintenance thread after metric creation

2017-08-02 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5756: start memory maintenance thread after metric creation .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-5742: De-allocate buffer in parquet-reader on exit

2017-08-02 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5742: De-allocate buffer in parquet-reader on exit .. Patch Set 2: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/7572 To

[Impala-ASF-CR] IMPALA-5742: De-allocate buffer in parquet-reader on exit

2017-08-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5742: De-allocate buffer in parquet-reader on exit .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/975/ -- To

[Impala-ASF-CR] IMPALA-5756: start memory maintenance thread after metric creation

2017-08-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5756: start memory maintenance thread after metric creation .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-5742: De-allocate buffer in parquet-reader on exit

2017-08-02 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5742: De-allocate buffer in parquet-reader on exit .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7572/1/be/src/util/parquet-reader.cc

[Impala-ASF-CR] IMPALA-5742: De-allocate buffer in parquet-reader on exit

2017-08-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5742: De-allocate buffer in parquet-reader on exit .. Patch Set 1: Code-Review+1 (2 comments)

[Impala-ASF-CR] Revert "IMPALA-5658: addtl. process/system-wide memory metrics"

2017-08-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Revert "IMPALA-5658: addtl. process/system-wide memory metrics" .. Patch Set 2: Posted the alternative fix here: https://gerrit.cloudera.org/#/c/7573 -- To

[Impala-ASF-CR] IMPALA-5756: start memory maintenance thread after metric creation

2017-08-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7573 Change subject: IMPALA-5756: start memory maintenance thread after metric creation .. IMPALA-5756: start memory maintenance thread

[Impala-ASF-CR] Revert "IMPALA-5658: addtl. process/system-wide memory metrics"

2017-08-02 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Revert "IMPALA-5658: addtl. process/system-wide memory metrics" .. Patch Set 2: sounds good - let me give you a 'conditional +2'? since you've started a GVO I

[Impala-ASF-CR] Revert "IMPALA-5658: addtl. process/system-wide memory metrics"

2017-08-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Revert "IMPALA-5658: addtl. process/system-wide memory metrics" .. Patch Set 2: I mainly wanted to be sure that I unblocked people tomorrow. It looked like the

[Impala-ASF-CR] Revert "IMPALA-5658: addtl. process/system-wide memory metrics"

2017-08-02 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Revert "IMPALA-5658: addtl. process/system-wide memory metrics" .. Patch Set 2: Thanks for jumping on the broken build. Just wondering why a revert was in

[Impala-ASF-CR] Revert "IMPALA-5658: addtl. process/system-wide memory metrics"

2017-08-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Revert "IMPALA-5658: addtl. process/system-wide memory metrics" .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/973/

[Impala-ASF-CR] Revert "IMPALA-5658: addtl. process/system-wide memory metrics"

2017-08-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7571 Change subject: Revert "IMPALA-5658: addtl. process/system-wide memory metrics" .. Revert "IMPALA-5658: addtl. process/system-wide

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. Patch Set 16: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7530 To unsubscribe,

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. IMPALA-3894: Change the behavior parsing date "YY" This patch change the behavor when

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-08-02 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/7061/5//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5744: Add dummy 'use krpc' flag and create DataStream interface

2017-08-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#6). Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface .. IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface This patch

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-08-02 Thread John Sherman (Code Review)
John Sherman has uploaded a new patch set (#5). Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer - Previously

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size agg intermediate types

2017-08-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size agg intermediate types .. Patch Set 6: (5 comments) Looks good to me, though I'm leaving the codegen stuff for Michael to

[Impala-ASF-CR] IMPALA-1575: Yield admission control resources at query end

2017-08-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-1575: Yield admission control resources at query end .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-1575: Yield admission control resources at query end

2017-08-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#3). Change subject: IMPALA-1575: Yield admission control resources at query end .. IMPALA-1575: Yield admission control resources at query end Currently, a query does not release

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). Change subject: IMPALA-5572: Timestamp codegen for text scanner .. IMPALA-5572: Timestamp codegen for text scanner Currently codegen is disabled when scanning text tables with

[Impala-ASF-CR] IMPALA-5602: Fix kudu queries being incorrectly optimized as small query

2017-08-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5602: Fix kudu queries being incorrectly optimized as small query .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-08-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. Patch Set 7: I did a pass and think it makes sense. Took me a while just to page the code back in, hadn't

[Impala-ASF-CR] IMPALA-5602: Fix kudu queries being incorrectly optimized as small query

2017-08-02 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-5602: Fix kudu queries being incorrectly optimized as small query .. Patch Set 2: > Do you have a test for the case when the table is missing stats? I

[Impala-ASF-CR] IMPALA-5602: Fix kudu queries being incorrectly optimized as small query

2017-08-02 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new patch set (#2). Change subject: IMPALA-5602: Fix kudu queries being incorrectly optimized as small query .. IMPALA-5602: Fix kudu queries being incorrectly optimized as small query Fix a bug

[Impala-ASF-CR] IMPALA-5602: Fix kudu queries being incorrectly optimized as small query

2017-08-02 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new patch set (#2). Change subject: IMPALA-5602: Fix kudu queries being incorrectly optimized as small query .. IMPALA-5602: Fix kudu queries being incorrectly optimized as small query Fix a bug

[Impala-ASF-CR] IMPALA-5744: Add dummy 'use krpc' flag and create DataStream interface

2017-08-02 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface .. Patch Set 5: (7 comments)

[native-toolchain-CR] IMPALA-5743: Allow TLS version configuration

2017-08-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5743: Allow TLS version configuration .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7558 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5546: Allow creating unpartitioned Kudu tables

2017-08-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5546: Allow creating unpartitioned Kudu tables .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5744: Add dummy 'use krpc' flag and create DataStream interface

2017-08-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface .. Patch Set 5: (10 comments)

[Impala-ASF-CR] IMPALA-5725: coalesce() with outer join incorrectly rewritten

2017-08-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5725: coalesce() with outer join incorrectly rewritten .. Patch Set 2: Code-Review+2 carrying my +2... I think we can commit this. Alex should weigh in

[Impala-ASF-CR] IMPALA-5725: coalesce() with outer join incorrectly rewritten

2017-08-02 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5725: coalesce() with outer join incorrectly rewritten .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-5725: coalesce() with outer join incorrectly rewritten

2017-08-02 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7567 to look at the new patch set (#2). Change subject: IMPALA-5725: coalesce() with outer join incorrectly rewritten

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. Patch Set 16: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/972/ -- To view,

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. Patch Set 16: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7530 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3200: more buffer pool end-to-end tests

2017-08-02 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3200: more buffer pool end-to-end tests .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7552 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3200: more buffer pool end-to-end tests

2017-08-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3200: more buffer pool end-to-end tests .. Patch Set 5: (7 comments) If I understood correctly, the concern is that someone will skip it on core

[Impala-ASF-CR] IMPALA-3200: more buffer pool end-to-end tests

2017-08-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#6). Change subject: IMPALA-3200: more buffer pool end-to-end tests .. IMPALA-3200: more buffer pool end-to-end tests This adds most of the end-to-end tests described in the test

[Impala-ASF-CR] Bump Kudu version to 1c0276a

2017-08-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to 1c0276a .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7565 To unsubscribe, visit

[Impala-ASF-CR] Bump Kudu version to 1c0276a

2017-08-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Bump Kudu version to 1c0276a .. Bump Kudu version to 1c0276a Change-Id: I7e4bf59595dd483ac12f4f9c4b8a7da8c5c43e91 Reviewed-on:

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#16). Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. IMPALA-3894: Change the behavior parsing date "YY" This patch change the behavor when running

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Tianyi Wang (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7530 to look at the new patch set (#16). Change subject: IMPALA-3894: Change the behavior parsing date "YY" ..

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Tianyi Wang (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7530 to look at the new patch set (#15). Change subject: IMPALA-3894: Change the behavior parsing date "YY" ..

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/7530/14/be/src/runtime/timestamp-parse-util.h

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. Patch Set 14: (1 comment) Thanks! Looks really good, just 1 more change, sorry I didn't think of it

[Impala-ASF-CR] IMPALA-3200: more buffer pool end-to-end tests

2017-08-02 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3200: more buffer pool end-to-end tests .. Patch Set 5: (7 comments) General comment: For some of the end-to-end tests, you've used workloads that will

[Impala-ASF-CR] IMPALA-5725: coalesce() with outer join incorrectly rewritten

2017-08-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5725: coalesce() with outer join incorrectly rewritten .. Patch Set 1: Code-Review+2 (3 comments) Nice, I think this looks good. I think we can commit

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-08-02 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#14). Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. IMPALA-3894: Change the behavior parsing date "YY" This patch change the behavor when running

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Tianyi Wang (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7530 to look at the new patch set (#14). Change subject: IMPALA-3894: Change the behavior parsing date "YY" ..

[native-toolchain-CR] IMPALA-5743: Allow TLS version configuration

2017-08-02 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5743: Allow TLS version configuration .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/7530/13/be/src/runtime/timestamp-parse-util.h

[native-toolchain-CR] IMPALA-5743: Allow TLS version configuration

2017-08-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5743: Allow TLS version configuration .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5725: coalesce() with outer join incorrectly rewritten

2017-08-02 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/7567 Change subject: IMPALA-5725: coalesce() with outer join incorrectly rewritten .. IMPALA-5725: coalesce() with outer join

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. Patch Set 13: (6 comments)

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#13). Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. IMPALA-3894: Change the behavior parsing date "YY" This patch change the behavor when running

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Tianyi Wang (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7530 to look at the new patch set (#13). Change subject: IMPALA-3894: Change the behavior parsing date "YY" ..

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Tianyi Wang (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7530 to look at the new patch set (#12). Change subject: IMPALA-3894: Change the behavior parsing date "YY" ..

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Tianyi Wang (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7530 to look at the new patch set (#11). Change subject: IMPALA-3894: Change the behavior parsing date "YY" ..

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Tianyi Wang (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7530 to look at the new patch set (#10). Change subject: IMPALA-3894: Change the behavior parsing date "YY" ..

[Impala-ASF-CR] IMPALA-3200: more buffer pool end-to-end tests

2017-08-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-3200: more buffer pool end-to-end tests .. IMPALA-3200: more buffer pool end-to-end tests This adds most of the end-to-end tests described in the test

[Impala-ASF-CR] IMPALA-3200: more buffer pool end-to-end tests

2017-08-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-3200: more buffer pool end-to-end tests .. IMPALA-3200: more buffer pool end-to-end tests This adds most of the end-to-end tests described in the test

[Impala-ASF-CR] Bump Kudu version to 1c0276a

2017-08-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to 1c0276a .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/971/ -- To view, visit

[Impala-ASF-CR] Bump Kudu version to 1c0276a

2017-08-02 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/7565 Change subject: Bump Kudu version to 1c0276a .. Bump Kudu version to 1c0276a Change-Id:

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. Patch Set 9: (1 comment) I followed up with Greg, he said there's no right behavior when you don't