Henry Robinson has posted comments on this change.
Change subject: IMPALA-5540: Revert Sentry version back to 5.13
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7247
To unsubscribe, visit
Hello Impala Public Jenkins, Michael Ho, Sailesh Mukil, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7226
to look at the new patch set (#4).
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch
(de)serialization
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6952
Change subject: Remove libevent from toolchain
..
Remove libevent from toolchain
Only Thrift ever needed libevent, and it no longer
Henry Robinson has uploaded a new patch set (#2).
Change subject: Remove redundant libevent flag when building Thrift
..
Remove redundant libevent flag when building Thrift
--with-libevent was specified twice, and overridden by
Henry Robinson has posted comments on this change.
Change subject: Remove redundant libevent flag when building Thrift
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6904/1/source/thrift/build.sh
File
Henry Robinson has posted comments on this change.
Change subject: Remove redundant libevent flag when building Thrift
..
Patch Set 1:
Yep - mentioned in the commit msg "Libevent is not required for Thrift if the
non-blocking
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5349: flaky NoDirsAllocationError test
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/6953
To unsubscribe, visit
Henry Robinson has submitted this change and it was merged.
Change subject: Remove redundant libevent flag when building Thrift
..
Remove redundant libevent flag when building Thrift
--with-libevent was specified twice, and
Henry Robinson has posted comments on this change.
Change subject: Remove redundant libevent flag when building Thrift
..
Patch Set 2: Verified+1
Passed a full toolchain build.
--
To view, visit
Henry Robinson has submitted this change and it was merged.
Change subject: Remove libevent from toolchain
..
Remove libevent from toolchain
Only Thrift ever needed libevent, and it no longer needs it, so save the
time
Henry Robinson has posted comments on this change.
Change subject: Remove libevent from toolchain
..
Patch Set 1: Verified+1
Passed a full toolchain build.
--
To view, visit http://gerrit.cloudera.org:8080/6952
To
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4890/5143: Coordinator race involving TearDown()
..
Patch Set 1:
(1 comment)
Patch looks pretty reasonable, will finish shortly.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4890/5143: Coordinator race involving TearDown()
..
Patch Set 1:
(2 comments)
Where does ReleaseResources() get called for DML queries? It used to be
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5358: Fix repeatable table sample.
..
Patch Set 1:
Ok, thanks - I think you mean that inputParts was arbitrarily ordered, so the
bug was
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5358: Fix repeatable table sample.
..
Patch Set 1: Code-Review+2
Was there a REPEAT(..) clause that could have picked this up that we could put
in a
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4890/5143: Coordinator race involving TearDown()
..
Patch Set 2: Code-Review+1
(1 comment)
I think there would be some benefit in having
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5375: Builds on CentOS 6.4 failing with broken python
dependencies
..
Patch Set 1:
(3 comments)
Can you mention the testing you do (when it's
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4890/5143: Coordinator race involving TearDown()
..
Patch Set 2:
Will wait for final patch before signing off.
What was the reason behind moving
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5331: Use new libHDFS API to address "Unknown Error 255"
..
Patch Set 1:
I think the more information the better. If we can determine that one of those
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6904
Change subject: Remove redundant libevent flag when building Thrift
..
Remove redundant libevent flag when building Thrift
Henry Robinson has posted comments on this change.
Change subject: Print Kudu native client version on Impala web UI
..
Patch Set 1:
Did you think about making this a metric instead? I see the value in making
this easy to
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5391: remove C++11 from UDF header
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7024
To unsubscribe, visit
Hello Dimitris Tsirogiannis,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7045
to look at the new patch set (#2).
Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after
metadata loading
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after
metadata loading
..
Patch Set 2:
Rebased and included an unsquashed fix.
--
To view, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after
metadata loading
..
Patch Set 3:
(1 comment)
Hello Dimitris Tsirogiannis,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7045
to look at the new patch set (#3).
Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after
metadata loading
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after
metadata loading
..
Patch Set 1:
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4892: Session ID included in error message
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7054/1/be/src/service/impala-server.cc
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4892: Session ID included in error message
..
Patch Set 1:
(1 comment)
Thanks for the patch! Just one minor comment.
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7036
Change subject: IMPALA-5377: Impala may crash if given a fragment instance
while restarting
..
IMPALA-5377: Impala may crash if given
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5388: Don't retry RPC calls on TSSLException
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7063/1/be/src/runtime/client-cache.h
File
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7045
Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after
metadata loading
..
IMPALA-5056: Ensure analysis uses 'fresh'
Hello Dimitris Tsirogiannis,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7045
to look at the new patch set (#4).
Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after
metadata loading
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after
metadata loading
..
Patch Set 3:
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7077/1/be/src/common/status.h
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit
..
Patch Set 3: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/7077
To
Hello Marcel Kornacker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5720
to look at the new patch set (#11).
Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore
services to KRPC
Henry Robinson has uploaded a new patch set (#7).
Change subject: IMPALA-4669: [KRPC] Import RPC library from kudu@314c9d8
..
IMPALA-4669: [KRPC] Import RPC library from kudu@314c9d8
Change-Id:
Henry Robinson has uploaded a new patch set (#7).
Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from
kudu@314c9d8
..
IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8
The security
Hello Matthew Jacobs, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5715
to look at the new patch set (#11).
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7103
Change subject: IMPALA-4856: Port data stream service to KRPC
..
IMPALA-4856: Port data stream service to KRPC
This patch ports the
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5714
to look at the new patch set (#7).
Change subject: IMPALA-4669: [KUTIL] Import kudu_util library from kudu@314c9d8
Hello Dimitris Tsirogiannis,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7045
to look at the new patch set (#5).
Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after
metadata loading
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7106
Change subject: IMPALA-5454: Work around template rendering bug in /memz
..
IMPALA-5454: Work around template rendering bug in /memz
A
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5388: Only retry RPC on lost connection in send call
..
Patch Set 9: Code-Review+1
(6 comments)
Thanks - I think this is a great improvement.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after
metadata loading
..
Patch Set 6: Code-Review+2
Rebase
--
To view, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5377: Impala may crash if given a fragment instance
while restarting
..
Patch Set 1:
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads
..
Patch Set 3: Code-Review+2
(2 comments)
Carry +2
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5411: Avoid log spew from GetRuntimeProfileStr
..
Patch Set 1: Code-Review+2
I had no idea that Expected() existed... thanks!
--
To view, visit
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6951
to look at the new patch set (#3).
Change subject: IMPALA-5350: Tidy up thread groups for finst exec threads
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7036
to look at the new patch set (#2).
Change subject: IMPALA-5377: Impala may crash if given a fragment instance
while restarting
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5435: Increase runtime filter test timeouts (again)
..
Patch Set 1:
Passed an ASAN build.
--
To view, visit http://gerrit.cloudera.org:8080/7097
To
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4892: Session ID included in error message
..
Patch Set 3: Code-Review+2
(1 comment)
Looks good - please fix the long line, then I'll commit. Thanks!
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5454: Work around template rendering bug in /memz
..
Patch Set 1:
Anyone want to give a +2 here? I don't think it needs deep expertise, so any
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5221: Fix TSaslTransport negotiation order
..
Patch Set 1:
(11 comments)
Looks pretty good. Have you confirmed this works with LDAP as well as GSSAPI?
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4892: Session ID included in error message
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7054/4/be/src/service/impala-hs2-server.cc
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5388: Only retry RPC on lost connection in send call
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7063/4/be/src/rpc/thrift-util.cc
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5388: Only retry RPC on lost connection in send call
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7063/4/be/src/rpc/thrift-util.cc
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4892: Session ID included in error message
..
Patch Set 2:
Thanks Steve!
This is fine to go in as is. I noticed that there are a few other places in
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7077
Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit
..
IMPALA-5433: Mark single-argument Status c'tors as
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit
..
IMPALA-5433: Mark single-argument Status c'tors as explicit
Avoid unexpected errors by marking
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after
metadata loading
..
Patch Set 4:
(2 comments)
Will post a new patch when I'm sure I'm addressing
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7097
Change subject: IMPALA-5435: Increase runtime filter test timeouts (again)
..
IMPALA-5435: Increase runtime filter test timeouts
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5435: Increase runtime filter test timeouts (again)
..
Patch Set 1:
No, I haven't tried (the issue is flakey in ASAN builds anyhow). If I'm able
I'll
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5389: simplify BufferDescriptor lifetime
..
Patch Set 1: Code-Review+1
(5 comments)
This does seem more understandable to me. Just some small
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5495: Improve error message if no impalad role is
configured
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7167/1//COMMIT_MSG
Commit
Hello anujphadke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7167
to look at the new patch set (#2).
Change subject: IMPALA-5495: Improve error message if no impalad role is
configured
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-5481: Clarify RowDescriptor ownership
..
IMPALA-5481: Clarify RowDescriptor ownership
RowDescriptors are originally allocated in-line with the exec node
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5481: Clarify RowDescriptor ownership
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7206/2/be/src/runtime/row-batch.cc
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5481: Clarify RowDescriptor ownership
..
Patch Set 2:
I have an ASAN build running - have run this on a cluster and locally with a
heavy workload and
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5481: Clarify RowDescriptor ownership
..
Patch Set 2:
Because this change is almost entirely mechanical, I let clang-format run over
it as well, hence
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5481: Clarify RowDescriptor ownership
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7206/2//COMMIT_MSG
Commit Message:
PS2, Line 18:
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5481: Clarify RowDescriptor ownership
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7206/2/be/src/runtime/data-stream-recvr.h
File
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-5481: Clarify RowDescriptor ownership
..
IMPALA-5481: Clarify RowDescriptor ownership
RowDescriptors are originally allocated in-line with the exec node
Hello Impala Public Jenkins, Michael Ho, Matthew Jacobs, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5715
to look at the new patch set (#16).
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
Hello Impala Public Jenkins, Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5714
to look at the new patch set (#10).
Change subject: IMPALA-4669: [KUTIL] Import kudu_util library from kudu@314c9d8
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [KUTIL] Import kudu_util library from kudu@314c9d8
..
Patch Set 10: Code-Review+2
Carry +2, updated LICENSE.txt and rat_exclude_files.txt to pass
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
..
Patch Set 15:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5715/15/be/src/kudu/util/logging.cc
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5481: Clarify RowDescriptor ownership
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7206/2/be/src/exec/data-sink.h
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5481: Clarify RowDescriptor ownership
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7206/3/be/src/exec/data-sink.h
File
Henry Robinson has uploaded a new patch set (#4).
Change subject: IMPALA-5481: Clarify RowDescriptor ownership
..
IMPALA-5481: Clarify RowDescriptor ownership
RowDescriptors are originally allocated in-line with the exec node
Henry Robinson has uploaded a new patch set (#6).
Change subject: IMPALA-5481: Clarify RowDescriptor ownership
..
IMPALA-5481: Clarify RowDescriptor ownership
RowDescriptors are originally allocated in-line with the exec node
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4856: Port data stream service to KRPC
..
Patch Set 1:
This patch passes core, exhaustive and ASAN tests. It can execute 32 concurrent
streams of
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5506: Add stdin description to help information of
query_file option
..
Patch Set 2: Code-Review+2
Thanks!
--
To view, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5492: Fix incorrect newline character in the LDAP
message within impala-shell introduction
..
Patch Set 3: Code-Review+2
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5506: Add stdin description to help information of
query_file option
..
Patch Set 1:
(1 comment)
Thanks for doing this!
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7186
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
..
IMPALA-4669: [KUTIL] Add kudu_util library to the build.
A
Henry Robinson has abandoned this change.
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
..
Abandoned
Wrong Change-Id.
--
To view, visit http://gerrit.cloudera.org:8080/7186
To unsubscribe, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
..
Patch Set 13:
Fixed a few compilation errors on RHEL5 (see env_posix.cc for almost all of
them).
Hello Matthew Jacobs, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5715
to look at the new patch set (#15).
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
..
Patch Set 13:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/5715/13/be/src/common/logging.cc
Hello Matthew Jacobs, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5715
to look at the new patch set (#14).
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
..
Patch Set 13:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5715/13/be/src/kudu/util/minidump.cc
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [KUTIL] Import kudu_util library from kudu@314c9d8
..
Patch Set 9: Code-Review+2
Carry +2.
--
To view, visit
Henry Robinson has posted comments on this change.
Change subject: Support gcc 6.3.0 and 7.1.0
..
Patch Set 2: Code-Review+2
That Thrift bug was some ugly code :/
--
To view, visit http://gerrit.cloudera.org:8080/7156
To
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7167
Change subject: IMPALA-5495: Improve error message if no impalad role configured
..
IMPALA-5495: Improve error message if no impalad
Henry Robinson has posted comments on this change.
Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore
services to KRPC
..
Patch Set 11:
(1 comment)
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-4856: Port data stream service to KRPC
..
IMPALA-4856: Port data stream service to KRPC
This patch ports the data-flow parts of ImpalaInternalService to
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4856: Port data stream service to KRPC
..
Patch Set 2:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/7103/2/be/src/rpc/rpc.h
File be/src/rpc/rpc.h:
Hello Marcel Kornacker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5720
to look at the new patch set (#13).
Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore
services to KRPC
701 - 800 of 874 matches
Mail list logo
