Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3586 (Part 1): Implement Union Pass Through
..
Patch Set 4:
(15 comments)
I think this is looking pretty good. It turns out to hit a lot of interesting
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows
..
Patch Set 9: Code-Review+1
(1 comment)
I'm happy that the issue I mentioned is fixed. I
Tim Armstrong has uploaded a new patch set (#3).
Change subject: IMPALA-3748: Part 1: Clean up resource estimation in planner
..
IMPALA-3748: Part 1: Clean up resource estimation in planner
This is in preparation to use this
Hello Michael Ho,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5161
to look at the new patch set (#14).
Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs
..
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs
..
Patch Set 15:
(6 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4868: Fix flaky
TestRequestPoolService.testUpdatingConfigs
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5876
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5811/5//COMMIT_MSG
Commit Message:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-1430: enable codegen for native UDAs
..
Patch Set 13:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5161/13/be/src/exprs/scalar-fn-call.h
File
Tim Armstrong has submitted this change and it was merged.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
IMPALA-3909: Populate min/max statistics in Parquet writer
Change-Id:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 12: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5611
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows
..
Patch Set 9:
I added logging just to double-check that the deep copy flag was present - it
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool
..
Patch Set 4:
(37 comments)
Tim Armstrong has uploaded a new patch set (#5).
Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool
..
IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool
Add a copy of BufferedTupleStream that
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4809: Add Stability for codegen constants
..
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/5848/1//COMMIT_MSG
Commit Message:
PS1, Line
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5850
Change subject: IMPALA-4808: old hash join can reference invalid memory
..
IMPALA-4808: old hash join can reference invalid memory
The
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4808: old hash join can reference invalid memory
..
Patch Set 1:
It looks like on the original CR there was some discussion about whether this
was
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool
..
Patch Set 4:
(5 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 9:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs
..
Patch Set 18:
The full test run caught a gap in my pre-review testing - the input argument
types
Hello Impala Public Jenkins, Michael Ho, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5161
to look at the new patch set (#18).
Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3748: Part 1: Clean up resource estimation in planner
..
Patch Set 4:
(5 comments)
Some minor cleanup and tests fixes
Tim Armstrong has uploaded a new patch set (#5).
Change subject: IMPALA-3748: Part 1: Clean up resource estimation in planner
..
IMPALA-3748: Part 1: Clean up resource estimation in planner
This is in preparation to use this
Tim Armstrong has uploaded a new patch set (#4).
Change subject: IMPALA-3748: Part 1: Clean up resource estimation in planner
..
IMPALA-3748: Part 1: Clean up resource estimation in planner
This is in preparation to use this
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5940
Change subject: IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky
..
IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky
The test
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4895: Memory limit exceeded in test_outer_joins
..
Patch Set 1:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs
..
Patch Set 19:
(1 comment)
Hello Impala Public Jenkins, Michael Ho, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5161
to look at the new patch set (#20).
Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs
..
Patch Set 19:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs
..
Patch Set 22: Code-Review+2
carry +2
--
To view, visit http://gerrit.cloudera.org:8080/5161
To
Hello Impala Public Jenkins, Michael Ho, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5161
to look at the new patch set (#21).
Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs
..
Patch Set 20:
(2 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs
..
Patch Set 16: Code-Review+2
carry
--
To view, visit http://gerrit.cloudera.org:8080/5161
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs
..
Patch Set 15:
(4 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs
..
Patch Set 17: Code-Review+2
Rebase
--
To view, visit http://gerrit.cloudera.org:8080/5161
To
Hello Michael Ho, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5161
to look at the new patch set (#16).
Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4731: Crash when sorting on non-deterministic expr
..
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/5914/1//COMMIT_MSG
Commit Message:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with
codegen
..
Patch Set 2:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3748: add query-wide resource acquisition step
..
Patch Set 5:
Removed the unnecessary call to Prepare() as discussed.
--
To view, visit
Hello Marcel Kornacker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5739
to look at the new patch set (#5).
Change subject: IMPALA-3748: add query-wide resource acquisition step
..
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3748: add query-wide resource acquisition step
..
Patch Set 4:
Talked offline with Marcel - he pointed out that we shouldn't need to call
Prepare() from
Tim Armstrong has uploaded a new patch set (#12).
Change subject: IMPALA-1430: enable codegen for native UDAs
..
IMPALA-1430: enable codegen for native UDAs
This uses the existing infrastructure for codegening builtin UDAs and
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5772
Change subject: IMPALA-4801: fix heap use after free for MemTracker
..
IMPALA-4801: fix heap use after free for MemTracker
This is a
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-1430: enable codegen for native UDAs
..
Patch Set 11:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5161/11/be/src/exprs/agg-fn-evaluator.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-1430: enable codegen for native UDAs
..
Patch Set 13: Code-Review+1
carry +1
--
To view, visit http://gerrit.cloudera.org:8080/5161
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-1430: enable codegen for native UDAs
..
Patch Set 12:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5161/12/be/src/exprs/agg-fn-evaluator.cc
File
Hello Michael Ho,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5161
to look at the new patch set (#13).
Change subject: IMPALA-1430: enable codegen for native UDAs
..
IMPALA-1430:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows
..
Patch Set 6:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 6:
(13 comments)
Thanks , I think this will be easier to move forward.
I think to make
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4801: fix heap use after free for MemTracker
..
Patch Set 2: Code-Review+1
Carry +1
--
To view, visit http://gerrit.cloudera.org:8080/5772
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4801: fix heap use after free for MemTracker
..
Patch Set 1:
(1 comment)
Hello Thomas Tauber-Marshall,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5772
to look at the new patch set (#2).
Change subject: IMPALA-4801: fix heap use after free for MemTracker
..
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows
..
Patch Set 8:
I believe the current patchset still has the resource transfer bug (unless I
Tim Armstrong has submitted this change and it was merged.
Change subject: IMPALA-3748: add query-wide resource acquisition step
..
IMPALA-3748: add query-wide resource acquisition step
This adds a Prepare() method to
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3748: add query-wide resource acquisition step
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5739/6/be/src/runtime/query-state.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3748: add query-wide resource acquisition step
..
Patch Set 6: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/5739
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4729: Implement REPLACE()
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5776/2/be/src/exprs/string-functions-ir.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4801: fix heap use after free for MemTracker
..
Patch Set 3: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/5772
To
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5788
Change subject: IMPALA-4820: avoid writing unencrypted data during write
cancellation
..
IMPALA-4820: avoid writing unencrypted data
Tim Armstrong has posted comments on this change.
Change subject: Add a build flag for the undefined behavior sanitizer, aka
"ubsan".
..
Patch Set 4: Code-Review+1
(4 comments)
Just a few minor things from my point of view.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool
..
Patch Set 17:
(1 comment)
Hello Impala Public Jenkins, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5584
to look at the new patch set (#18).
Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool
..
Patch Set 18: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/5584
To
Tim Armstrong has posted comments on this change.
Change subject: [DOCS] Add several items to "known issues" page
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5809
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4820: avoid writing unencrypted data during write
cancellation
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5788/1//COMMIT_MSG
Tim Armstrong has uploaded a new patch set (#4).
Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool
..
IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool
Add a copy of BufferedTupleStream that
Tim Armstrong has uploaded a new patch set (#2).
Change subject: IMPALA-4820: avoid writing unencrypted data during write
cancellation
..
IMPALA-4820: avoid writing unencrypted data during write cancellation
The bug was that
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4820: avoid writing unencrypted data during write
cancellation
..
Patch Set 3: Code-Review+2
Carry +2
--
To view, visit
Tim Armstrong has submitted this change and it was merged.
Change subject: IMPALA-4820: avoid writing unencrypted data during write
cancellation
..
IMPALA-4820: avoid writing unencrypted data during write cancellation
The bug
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with
codegen
..
Patch Set 4:
I think it may have been accidentally disabled by the single node
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4617: remove IsConstant() analysis from be
..
Patch Set 10: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/5415
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5611
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 7:
(2 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 7: Code-Review+1
(9 comments)
Tim Armstrong has uploaded a new patch set (#9).
Change subject: IMPALA-4617: remove IsConstant() analysis from be
..
IMPALA-4617: remove IsConstant() analysis from be
This change avoids the need to duplicate the logic in
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3586 (Part 1): Implement Union Pass Through
..
Patch Set 2:
(6 comments)
Need to look at fe and tests, but had some comments on the backend.
Tim Armstrong has uploaded a new patch set (#15).
Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool
..
IMPALA-3202: implement spill-to-disk in new buffer pool
See https://goo.gl/0zuy97 for a high-level
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool
..
Patch Set 13:
(10 comments)
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5584
to look at the new patch set (#17).
Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool
..
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool
..
Patch Set 16:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool
..
Patch Set 17: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/5584
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 2:
(1 comment)
It seems like we really need to talk through the big picture of what to
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5801
Change subject: PREVIEW: IMPALA-4678: port backend exec to use buffer pool
..
PREVIEW: IMPALA-4678: port backend exec to use buffer pool
Tim Armstrong has uploaded a new patch set (#2).
Change subject: PREVIEW: IMPALA-4678: port backend exec to use buffer pool
..
PREVIEW: IMPALA-4678: port backend exec to use buffer pool
Create global BufferPool at startup.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool
..
Patch Set 12:
(22 comments)
Tim Armstrong has uploaded a new patch set (#13).
Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool
..
IMPALA-3202: implement spill-to-disk in new buffer pool
See https://goo.gl/0zuy97 for a high-level
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 6:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 6:
(1 comment)
One final issue. I'm assuming that we're going to rename
Hello Thomas Tauber-Marshall,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5683
to look at the new patch set (#4).
Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit
..
Patch Set 3:
(2 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-1430: enable codegen for native UDAs
..
Patch Set 10:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/5161/10/be/src/exprs/agg-fn-evaluator.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4678: move query MemTracker into QueryState
..
Patch Set 11: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/5630
To
Tim Armstrong has uploaded a new patch set (#11).
Change subject: IMPALA-1430: enable codegen for native UDAs
..
IMPALA-1430: enable codegen for native UDAs
This uses the existing infrastructure for codegening builtin UDAs and
Hello Impala Public Jenkins, Thomas Tauber-Marshall, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5683
to look at the new patch set (#6).
Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit
..
Patch Set 6: Code-Review+2
There was a mistake in merging when I rebased. Fixed it.
--
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with
codegen
..
Patch Set 1:
(8 comments)
The general approach looks good - mainly the comments are
Tim Armstrong has posted comments on this change.
Change subject: Add doc for MT_DOP query option.
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5652/1/docs/topics/impala_mt_dop.xml
File
Hello Thomas Tauber-Marshall, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5683
to look at the new patch set (#5).
Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 2:
(12 comments)
I need to read through the test code but I thought I'd flush out my
Tim Armstrong has uploaded a new patch set (#9).
Change subject: IMPALA-4678: move query MemTracker into QueryState
..
IMPALA-4678: move query MemTracker into QueryState
The query MemTracker for query execution is now owned
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4678: move query MemTracker into QueryState
..
Patch Set 4:
(1 comment)
I didn't mean to push out PS8 - PS9 reverts the PS8 change.
1 - 100 of 2851 matches
Mail list logo
