[Impala-ASF-CR] IMPALA-5052: Read and write signed integer logical types in Parquet

2017-11-14 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8548 ) Change subject: IMPALA-5052: Read and write signed integer logical types in Parquet .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-5976: Remove equivalence class computation in FE

2017-11-14 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8317 ) Change subject: IMPALA-5976: Remove equivalence class computation in FE .. Patch Set 6: (24 comments)

[Impala-ASF-CR] IMPALA-5976: Remove equivalence class computation in FE

2017-11-14 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/8317 ) Change subject: IMPALA-5976: Remove equivalence class computation in FE .. IMPALA-5976: Remove equivalence class computation in FE

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-09 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8498 ) Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter .. Patch Set 4: The change in base64 decoding broke a test

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-09 Thread Tianyi Wang (Code Review)
Hello Sailesh Mukil, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8498 to look at the new patch set (#4). Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

[Impala-ASF-CR] IMPALA-6121: remove I/O mgr request context cache

2017-11-08 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8408 ) Change subject: IMPALA-6121: remove I/O mgr request context cache .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-08 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8498 ) Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-08 Thread Tianyi Wang (Code Review)
Hello Sailesh Mukil, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8498 to look at the new patch set (#3). Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-08 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8498 ) Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-08 Thread Tianyi Wang (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8498 to look at the new patch set (#2). Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter ..

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-08 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-08 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter

2017-11-08 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8498 Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter .. IMPALA-6164: Fix stale query profile in

[Impala-ASF-CR] IMPALA-2281: Replace FNV with FastHash in exchange nodes

2017-11-07 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8417 ) Change subject: IMPALA-2281: Replace FNV with FastHash in exchange nodes .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-2281: Replace FNV with FastHash in exchange nodes

2017-11-07 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/8417 ) Change subject: IMPALA-2281: Replace FNV with FastHash in exchange nodes .. IMPALA-2281: Replace FNV with FastHash in exchange nodes FNV

[Impala-ASF-CR] IMPALA-2281: Replace FNV with FastHash in exchange nodes

2017-11-07 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/8417 ) Change subject: IMPALA-2281: Replace FNV with FastHash in exchange nodes .. IMPALA-2281: Replace FNV with FastHash in exchange nodes FNV

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-03 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-5976: Remove equivalence class computation in FE

2017-11-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8317 ) Change subject: IMPALA-5976: Remove equivalence class computation in FE .. Patch Set 4: (62 comments)

[Impala-ASF-CR] IMPALA-5976: Remove equivalence class computation in FE

2017-11-02 Thread Tianyi Wang (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8317 to look at the new patch set (#4). Change subject: IMPALA-5976: Remove equivalence class computation in FE ..

[Impala-ASF-CR] IMPALA-6121: remove I/O mgr request context cache

2017-11-01 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8408 ) Change subject: IMPALA-6121: remove I/O mgr request context cache .. Patch Set 5: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6080: clean up table descriptor handling

2017-10-31 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8330 ) Change subject: IMPALA-6080: clean up table descriptor handling .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6118: Fix assertion failure in coordinator bloom filter updating

2017-10-30 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8410 ) Change subject: IMPALA-6118: Fix assertion failure in coordinator bloom filter updating .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-6118: Fix assertion failure in coordinator bloom filter updating

2017-10-30 Thread Tianyi Wang (Code Review)
Hello Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8410 to look at the new patch set (#3). Change subject: IMPALA-6118: Fix assertion failure in coordinator bloom filter updating

[Impala-ASF-CR] IMPALA-5541: Reject BATCH SIZE greater than 65536

2017-10-30 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8419 Change subject: IMPALA-5541: Reject BATCH_SIZE greater than 65536 .. IMPALA-5541: Reject BATCH_SIZE greater than 65536 Setting a very

[Impala-ASF-CR] IMPALA-2281: Replace FNV with FastHash in exchange nodes

2017-10-30 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8417 ) Change subject: IMPALA-2281: Replace FNV with FastHash in exchange nodes .. IMPALA-2281: Replace FNV with FastHash in exchange nodes FNV

[Impala-ASF-CR] IMPALA-2281: Replace FNV with FastHash in exchange nodes

2017-10-30 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8417 Change subject: IMPALA-2281: Replace FNV with FastHash in exchange nodes .. IMPALA-2281: Replace FNV with FastHash in exchange nodes FNV

[Impala-ASF-CR] IMPALA-6118: Fix assertion failure in coordinator bloom filter updating

2017-10-29 Thread Tianyi Wang (Code Review)
Tianyi Wang has restored this change. ( http://gerrit.cloudera.org:8080/8410 ) Change subject: IMPALA-6118: Fix assertion failure in coordinator bloom filter updating .. Restored -- To view, visit

[Impala-ASF-CR] IMPALA-6118: Fix assertion failure in coordinator bloom filter updating

2017-10-29 Thread Tianyi Wang (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8410 to look at the new patch set (#2). Change subject: IMPALA-6118: Fix assertion failure in coordinator bloom filter updating

[Impala-ASF-CR] IMPALA-6118: Fix assertion failure in coordinator bloom filter updating

2017-10-29 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8410 ) Change subject: IMPALA-6118: Fix assertion failure in coordinator bloom filter updating .. Patch Set 1: Changed to tracking size() --

[Impala-ASF-CR] IMPALA-6118: Fix assertion failure in coordinator bloom filter updating

2017-10-27 Thread Tianyi Wang (Code Review)
Tianyi Wang has abandoned this change. ( http://gerrit.cloudera.org:8080/8410 ) Change subject: IMPALA-6118: Fix assertion failure in coordinator bloom filter updating .. Abandoned -- To view, visit

[Impala-ASF-CR] IMPALA-6118: Fix assertion failure in coordinator bloom filter updating

2017-10-27 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8410 ) Change subject: IMPALA-6118: Fix assertion failure in coordinator bloom filter updating .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6118: Fix assertion failure in coordinator bloom filter updating

2017-10-27 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8410 ) Change subject: IMPALA-6118: Fix assertion failure in coordinator bloom filter updating .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6118: Fix assertion failure in coordinator bloom filter updating

2017-10-27 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8410 Change subject: IMPALA-6118: Fix assertion failure in coordinator bloom filter updating .. IMPALA-6118: Fix assertion failure in

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-27 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. Patch Set 6: Sorry I forgot to handle some error. -- To view,

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-27 Thread Tianyi Wang (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8226 to look at the new patch set (#6). Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-26 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-26 Thread Tianyi Wang (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8226 to look at the new patch set (#5). Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-26 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-26 Thread Tianyi Wang (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8226 to look at the new patch set (#4). Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-25 Thread Tianyi Wang (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8226 to look at the new patch set (#3). Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-25 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-25 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. Patch Set 2: Reimplemented according to the above discussion. --

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-25 Thread Tianyi Wang (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8226 to look at the new patch set (#2). Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows

[Impala-ASF-CR] IMPALA-2758: Change BufferedTupleStream::GetRows to returning multi batches

2017-10-25 Thread Tianyi Wang (Code Review)
Tianyi Wang has restored this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Change BufferedTupleStream::GetRows to returning multi batches .. Restored -- To view, visit

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-25 Thread Tianyi Wang (Code Review)
Tianyi Wang has abandoned this change. ( http://gerrit.cloudera.org:8080/8385 ) Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. Abandoned Sorry this should be in https://gerrit.cloudera.org/c/8226/ -- To

[Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows

2017-10-25 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8385 Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows .. IMPALA-2758: Remove BufferedTupleStream::GetRows This patch removes

[Impala-ASF-CR] IMPALA-5976: Remove equivalence class computation in FE

2017-10-24 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8317 ) Change subject: IMPALA-5976: Remove equivalence class computation in FE .. Patch Set 2: (46 comments)

[Impala-ASF-CR] IMPALA-5976: Remove equivalence class computation in FE

2017-10-24 Thread Tianyi Wang (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8317 to look at the new patch set (#3). Change subject: IMPALA-5976: Remove equivalence class computation in FE ..

[Impala-ASF-CR] IMPALA-5976: Remove equivalence class computation in FE

2017-10-24 Thread Tianyi Wang (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8317 to look at the new patch set (#2). Change subject: IMPALA-5976: Remove equivalence class computation in FE ..

[Impala-ASF-CR] IMPALA-6099: Fix crash in CheckForAlwaysFalse()

2017-10-24 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8369 Change subject: IMPALA-6099: Fix crash in CheckForAlwaysFalse() .. IMPALA-6099: Fix crash in CheckForAlwaysFalse() Filter states indexed

[Impala-ASF-CR] IMPALA-6060: Check the return value of JNI exception handling functions

2017-10-24 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8334 ) Change subject: IMPALA-6060: Check the return value of JNI exception handling functions .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-6060: Check the return value of JNI exception handling functions

2017-10-24 Thread Tianyi Wang (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8334 to look at the new patch set (#4). Change subject: IMPALA-6060: Check the return value of JNI exception handling functions

[Impala-ASF-CR] IMPALA-6060: Check the return value of JNI exception handling functions

2017-10-23 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8334 ) Change subject: IMPALA-6060: Check the return value of JNI exception handling functions .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-6060: Check the return value of JNI exception handling functions

2017-10-23 Thread Tianyi Wang (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8334 to look at the new patch set (#3). Change subject: IMPALA-6060: Check the return value of JNI exception handling functions

[Impala-ASF-CR] IMPALA-6060: Check the return value of JNI exception handling functions

2017-10-23 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8334 ) Change subject: IMPALA-6060: Check the return value of JNI exception handling functions .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-6060: Check the return value of JNI exception handling functions

2017-10-23 Thread Tianyi Wang (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8334 to look at the new patch set (#2). Change subject: IMPALA-6060: Check the return value of JNI exception handling functions

[Impala-ASF-CR] IMPALA-6060: Check the return value of JNI exception handling functions

2017-10-20 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8334 ) Change subject: IMPALA-6060: Check the return value of JNI exception handling functions .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-19 Thread Tianyi Wang (Code Review)
Hello Thomas Tauber-Marshall, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8170 to look at the new patch set (#8). Change subject: IMPALA-5789: Add always_false flag in bloom filter

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-19 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8170 ) Change subject: IMPALA-5789: Add always_false flag in bloom filter .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-19 Thread Tianyi Wang (Code Review)
Hello Thomas Tauber-Marshall, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8170 to look at the new patch set (#7). Change subject: IMPALA-5789: Add always_false flag in bloom filter

[Impala-ASF-CR] IMPALA-6060: Check the return value of JNI exception handling functions

2017-10-19 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8334 Change subject: IMPALA-6060: Check the return value of JNI exception handling functions .. IMPALA-6060: Check the return value of JNI

[Impala-ASF-CR] IMPALA-2758: Change BufferedTupleStream::GetRows to returning multi batches

2017-10-18 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Change BufferedTupleStream::GetRows to returning multi batches .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5976: Remove equivalent class computation in FE

2017-10-18 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8317 Change subject: IMPALA-5976: Remove equivalent class computation in FE .. IMPALA-5976: Remove equivalent class computation in FE

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-13 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8170 ) Change subject: IMPALA-5789: Add always_false flag in bloom filter .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-13 Thread Tianyi Wang (Code Review)
Hello Thomas Tauber-Marshall, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8170 to look at the new patch set (#6). Change subject: IMPALA-5789: Add always_false flag in bloom filter

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-13 Thread Tianyi Wang (Code Review)
Hello Thomas Tauber-Marshall, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8170 to look at the new patch set (#5). Change subject: IMPALA-5789: Add always_false flag in bloom filter

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-10 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8170 ) Change subject: IMPALA-5789: Add always_false flag in bloom filter .. Patch Set 4: (6 comments)

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-10 Thread Tianyi Wang (Code Review)
Hello Thomas Tauber-Marshall, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8170 to look at the new patch set (#4). Change subject: IMPALA-5789: Add always_false flag in bloom filter

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-09 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8170 ) Change subject: IMPALA-5789: Add always_false flag in bloom filter .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-09 Thread Tianyi Wang (Code Review)
Hello Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8170 to look at the new patch set (#3). Change subject: IMPALA-5789: Add always_false flag in bloom filter

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-06 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8170 ) Change subject: IMPALA-5789: Add always_false flag in bloom filter .. Patch Set 2: > Patch Set 1: > > (2 comments) > > Will wait for the

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-06 Thread Tianyi Wang (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8170 to look at the new patch set (#2). Change subject: IMPALA-5789: Add always_false flag in bloom filter ..

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-06 Thread Tianyi Wang (Code Review)
Tianyi Wang has restored this change. ( http://gerrit.cloudera.org:8080/8170 ) Change subject: IMPALA-5789: Add always_false flag in bloom filter .. Restored -- To view, visit http://gerrit.cloudera.org:8080/8170 To

[Impala-ASF-CR] IMPALA-2758: Change BufferedTupleStream::GetRows to returning multi batches

2017-10-06 Thread Tianyi Wang (Code Review)
Tianyi Wang has abandoned this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Change BufferedTupleStream::GetRows to returning multi batches .. Abandoned Need to sync up with Tim before moving

[Impala-ASF-CR] IMPALA-2758: Change BufferedTupleStream::GetRows to returning multi batches

2017-10-06 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Change BufferedTupleStream::GetRows to returning multi batches .. Patch Set 1: > Patch Set 1: > > > (1

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-10-06 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/7805 ) Change subject: IMPALA-5425: Add test for validating input when setting query options .. Patch Set 14: > Uploaded patch set 14. Rebase

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-10-06 Thread Tianyi Wang (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7805 to look at the new patch set (#14). Change subject: IMPALA-5425: Add test for validating input when setting query options

[Impala-ASF-CR] IMPALA-2758: Change BufferedTupleStream::GetRows to returning multi batches

2017-10-06 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 ) Change subject: IMPALA-2758: Change BufferedTupleStream::GetRows to returning multi batches .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-2758: Change BufferedTupleStream::GetRows to returning multi batches

2017-10-06 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8226 Change subject: IMPALA-2758: Change BufferedTupleStream::GetRows to returning multi batches .. IMPALA-2758: Change

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-03 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8170 ) Change subject: IMPALA-5789: Add always_false flag in bloom filter .. Patch Set 1: (3 comments) > Patch Set 1: > > (2 comments) > >

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-03 Thread Tianyi Wang (Code Review)
Tianyi Wang has abandoned this change. ( http://gerrit.cloudera.org:8080/8170 ) Change subject: IMPALA-5789: Add always_false flag in bloom filter .. Abandoned More tests are needed -- To view, visit

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-10-02 Thread Tianyi Wang (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7805 to look at the new patch set (#13). Change subject: IMPALA-5425: Add test for validating input when setting query options

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-10-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/7805 ) Change subject: IMPALA-5425: Add test for validating input when setting query options .. Patch Set 12: (16 comments)

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-10-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/7805 ) Change subject: IMPALA-5425: Add test for validating input when setting query options .. IMPALA-5425: Add test for validating input when

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-09-29 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/7805 ) Change subject: IMPALA-5425: Add test for validating input when setting query options .. Patch Set 10: (12 comments) > Patch Set 10:

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-09-29 Thread Tianyi Wang (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7805 to look at the new patch set (#11). Change subject: IMPALA-5425: Add test for validating input when setting query options

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-09-28 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8170 Change subject: IMPALA-5789: Add always_false flag in bloom filter .. IMPALA-5789: Add always_false flag in bloom filter This patch adds

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-09-28 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/7805 ) Change subject: IMPALA-5425: Add test for validating input when setting query options .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-09-28 Thread Tianyi Wang (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7805 to look at the new patch set (#10). Change subject: IMPALA-5425: Add test for validating input when setting query options

[Impala-ASF-CR] IMPALA-992: [DOCS] Document impala-shell 'rerun' command

2017-09-28 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8044 ) Change subject: IMPALA-992: [DOCS] Document impala-shell 'rerun' command .. Patch Set 2: Code-Review+1 Looks good to me. -- To view,

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-09-25 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/6535 ) Change subject: IMPALA-2550: Switch to per-query exec rpc .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-09-25 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/6535 ) Change subject: IMPALA-2550: Switch to per-query exec rpc .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-5416: Fix an impala-shell command recursion bug

2017-09-21 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8063 ) Change subject: IMPALA-5416: Fix an impala-shell command recursion bug .. Patch Set 7: Rebased again. -- To view, visit

[Impala-ASF-CR] IMPALA-5966: Fix the result file location of PlannerTest

2017-09-21 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8113 ) Change subject: IMPALA-5966: Fix the result file location of PlannerTest .. Patch Set 2: > Did you try it manually and confirm that it

[Impala-ASF-CR] IMPALA-5416: Fix an impala-shell command recursion bug

2017-09-20 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5416: Fix an impala-shell command recursion bug .. Patch Set 5: > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1242/ It seems to be

[Impala-ASF-CR] IMPALA-5966: Fix the result file location of PlannerTest

2017-09-20 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5966: Fix the result file location of PlannerTest .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5966: Fix the result file location of PlannerTest

2017-09-20 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). Change subject: IMPALA-5966: Fix the result file location of PlannerTest .. IMPALA-5966: Fix the result file location of PlannerTest The Plannertest result files should be written

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-09-20 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5425: Add test for validating input when setting query options .. Patch Set 8: (4 comments)

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-09-20 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#9). Change subject: IMPALA-5425: Add test for validating input when setting query options .. IMPALA-5425: Add test for validating input when setting query options This patch adds

[Impala-ASF-CR] IMPALA-5966: Fix the result file location of PlannerTest

2017-09-20 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/8113 Change subject: IMPALA-5966: Fix the result file location of PlannerTest .. IMPALA-5966: Fix the result file location of PlannerTest The

  1   2   3   4   >