[kudu-CR] Make fuzz-itest run serially

2016-12-06 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5398 to review the following change. Change subject: Make fuzz-itest run serially .. Make fuzz-itest run serially This test

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 12: (5 comments) http://gerrit.cloudera.org:8080/#/c/5045/12/src/kudu/integration-tests/t

[kudu-CR] KUDU-861 Support changing default, storage attributes

2016-12-06 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4310 to look at the new patch set (#17). Change subject: KUDU-861 Support changing default, storage attributes .. KUDU-8

[kudu-CR] KUDU-861 Support changing default, storage attributes

2016-12-06 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4310 to look at the new patch set (#16). Change subject: KUDU-861 Support changing default, storage attributes .. KUDU-8

[kudu-CR] KUDU-861 Support changing default, storage attributes

2016-12-06 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4310 to look at the new patch set (#15). Change subject: KUDU-861 Support changing default, storage attributes .. KUDU-8

[kudu-CR] Reduce default client tablet locations cache TTL

2016-12-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Reduce default client tablet locations cache TTL .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5397/1//COMMIT_MSG Commit Message:

[kudu-CR] KUDU-1792 It is possible to overwrite range partitions

2016-12-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1792 It is possible to overwrite range partitions .. Patch Set 2: Code-Review+2 Looks good though we do need to fix those Python tests. -- To view, visit htt

[kudu-CR] KUDU-1792 It is possible to overwrite range partitions

2016-12-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1792 It is possible to overwrite range partitions .. Patch Set 1: (4 comments) It looks like the python failures might be legitimate, in which case there are

[kudu-CR] KUDU-1792 It is possible to overwrite range partitions

2016-12-06 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5395 to look at the new patch set (#2). Change subject: KUDU-1792 It is possible to overwrite range partitions .. KUDU-1

[kudu-CR] Reduce default client tablet locations cache TTL

2016-12-06 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5397 to review the following change. Change subject: Reduce default client tablet locations cache TTL .. Reduce

[kudu-CR] [build] Update syntax of gen version info.py

2016-12-06 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/5396 Change subject: [build] Update syntax of gen_version_info.py .. [build] Update syntax of gen_version_info.py Got bit by a SyntaxError he

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-798 (part 5) Correct safe time advancement .. Patch Set 27: (1 comment) http://gerrit.cloudera.org:8080/#/c/5240/27/src/kudu/consensus/raft_consensus.cc File

[kudu-CR] rpc: show outbound call state in /rpcz dump

2016-12-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: show outbound call state in /rpcz dump .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5371/1/src/kudu/rpc/rpc_introspection.proto File src/k

[kudu-CR] KUDU-1792 It is possible to overwrite range partitions

2016-12-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1792 It is possible to overwrite range partitions .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5395/1/src/kudu/integration-tests/alter_tab

[kudu-CR] KUDU-1792 It is possible to overwrite range partitions

2016-12-06 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5395 to review the following change. Change subject: KUDU-1792 It is possible to overwrite range partitions

[kudu-CR] util: add file cache

2016-12-06 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5146 to look at the new patch set (#10). Change subject: util: add file cache .. util: add file cache This

[kudu-CR] util: add file cache

2016-12-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: util: add file cache .. Patch Set 10: > Don't merge yet, I've found a race that needs to be addressed. The race has been fixed. This new implementation revives the

[kudu-CR] block manager: start using the file cache

2016-12-06 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5147 to look at the new patch set (#7). Change subject: block manager: start using the file cache .. block manager: star

[kudu-CR] block manager: start using the file cache

2016-12-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: block manager: start using the file cache .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5147/4/src/kudu/fs/block_manager.cc File src/kudu/fs/bloc

[kudu-CR] util: add file cache

2016-12-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: util: add file cache .. Patch Set 8: (9 comments) http://gerrit.cloudera.org:8080/#/c/5146/8/src/kudu/util/cache.cc File src/kudu/util/cache.cc: PS8, Line 499: Ca

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 12: Verified+1 Apparently log-rolling-itest is flaky. -- To view, visit http://gerrit.clo

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/5045/6/src/kudu/tserver/ts_tablet_mana

[kudu-CR] KUDU-1785. Fix potential crash in TabletCopySourceSession

2016-12-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1785. Fix potential crash in TabletCopySourceSession .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/5363/2/src/kudu/integration-tests/tablet

[kudu-CR] [docs] Add missing krb deps to the SLES12 and Ubuntu instructions

2016-12-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [docs] Add missing krb deps to the SLES12 and Ubuntu instructions .. Patch Set 3: Code-Review+2 I suspect we also need krb5-user and krb5-workstation on SLES12 (ma

[kudu-CR] [docs] Add missing krb deps to the SLES12 and Ubuntu instructions

2016-12-06 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5130 to look at the new patch set (#3). Change subject: [docs] Add missing krb deps to the SLES12 and Ubuntu instructions ..

[kudu-CR] [docs] Add krb5-devel to the SLES12 instructions

2016-12-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [docs] Add krb5-devel to the SLES12 instructions .. Patch Set 2: > Do you know off-hand what exactly I need to add for Ubuntu? Else I > don't want this to rot. li

[kudu-CR] KUDU-1791: tighten up read only usage in log block manager

2016-12-06 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-1791: tighten up read only usage in log block manager .. KUDU-1791: tighten up read only usage in log block manager Over time we had introduced a coup

[kudu-CR] [docs] Add krb5-devel to the SLES12 instructions

2016-12-06 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [docs] Add krb5-devel to the SLES12 instructions .. Patch Set 2: > This is still relevant. We discussed it on slack on November 17th > around 12:45pm. Th

[kudu-CR] WIP KUDU-1127 Don't hang scanner threads waiting for safe time

2016-12-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP KUDU-1127 Don't hang scanner threads waiting for safe time .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5305/4/src/kudu/integration-tests

[kudu-CR] KUDU-1791: tighten up read only usage in log block manager

2016-12-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1791: tighten up read only usage in log block manager .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5383 To unsubscribe, vi

[kudu-CR] KUDU-1791: tighten up read only usage in log block manager

2016-12-06 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5383 to look at the new patch set (#3). Change subject: KUDU-1791: tighten up read only usage in log block manager .. KU

[kudu-CR] log block manage: tighten up read only usage

2016-12-06 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5383 to look at the new patch set (#2). Change subject: log block manage: tighten up read only usage .. log block manage

[kudu-CR] log block manage: tighten up read only usage

2016-12-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log block manage: tighten up read only usage .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5383/1/src/kudu/fs/log_block_manager.cc File src/kudu

[kudu-CR] log block manage: tighten up read only usage

2016-12-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: log block manage: tighten up read only usage .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5383/1/src/kudu/fs/log_block_manager.cc File src/kud

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-06 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 6: (3 comments) LGTM, couple of nits. http://gerrit.cloudera.org:8080/#/c/5045/6/src/kud

[kudu-CR] KUDU-1785. Fix potential crash in TabletCopySourceSession

2016-12-06 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1785. Fix potential crash in TabletCopySourceSession .. Patch Set 4: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/5363/4/src/kudu/integrati

[kudu-CR] log block manage: tighten up read only usage

2016-12-06 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5383 to review the following change. Change subject: log block manage: tighten up read only usage .. log block

[kudu-CR] client: don't log retriable scanner errors

2016-12-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: client: don't log retriable scanner errors .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5380 To unsubscribe, visit http://gerrit

[kudu-CR] client: don't log retriable scanner errors

2016-12-06 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: client: don't log retriable scanner errors .. client: don't log retriable scanner errors Retriable scanner errors are a normal part of life. Prior to this

[kudu-CR] KUDU-1789. Fix ScannerKeepAlive leaking RPCs when scanner is already expired

2016-12-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1789. Fix ScannerKeepAlive leaking RPCs when scanner is already expired .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5379

[kudu-CR] KUDU-1789. Fix ScannerKeepAlive leaking RPCs when scanner is already expired

2016-12-06 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-1789. Fix ScannerKeepAlive leaking RPCs when scanner is already expired .. KUDU-1789. Fix ScannerKeepAlive leaking RPCs when scanner is already expire

[kudu-CR] KUDU-1785. Fix potential crash in TabletCopySourceSession

2016-12-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1785. Fix potential crash in TabletCopySourceSession .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5363/2/src/kudu/integration

[kudu-CR] Silence gcc warning on TimeManager::GetSafeTimeUnlocked()

2016-12-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Silence gcc warning on TimeManager::GetSafeTimeUnlocked() .. Silence gcc warning on TimeManager::GetSafeTimeUnlocked() gcc is issuing this warning

[kudu-CR] KUDU-1785. Fix potential crash in TabletCopySourceSession

2016-12-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1785. Fix potential crash in TabletCopySourceSession .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5363/2//COMMIT_MSG Commit Message: PS2,

[kudu-CR] KUDU-1785. Fix potential crash in TabletCopySourceSession

2016-12-06 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5363 to look at the new patch set (#4). Change subject: KUDU-1785. Fix potential crash in TabletCopySourceSession .. KUD

[kudu-CR] Update partition syntax for single value range partitions

2016-12-06 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Update partition syntax for single value range partitions .. Update partition syntax for single value range partitions Impala is going to use the singular

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-06 Thread Mike Percy (Code Review)
Hello Dinesh Bhat, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5045 to look at the new patch set (#11). Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async ..

[kudu-CR] [ExternalMiniClusterITestBase] move some methods into .cc

2016-12-06 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: [ExternalMiniClusterITestBase] move some methods into .cc .. [ExternalMiniClusterITestBase] move some methods into .cc Separated implementation of the exte

[kudu-CR] [ExternalMiniClusterITestBase] move some methods into .cc

2016-12-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [ExternalMiniClusterITestBase] move some methods into .cc .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5367 To unsubscribe, visi

[kudu-CR] [ExternalMiniClusterITestBase] move some methods into .cc

2016-12-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [ExternalMiniClusterITestBase] move some methods into .cc .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5367/2//COMMIT_MSG Commit Message: Line

[kudu-CR] [ExternalMiniClusterITestBase] move some methods into .cc

2016-12-06 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5367 to look at the new patch set (#3). Change subject: [ExternalMiniClusterITestBase] move some methods into .cc ...

[kudu-CR] [i-tests] separated implementation of the ext mini-cluster

2016-12-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [i-tests] separated implementation of the ext mini-cluster .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5367/2//COMMIT_MSG Commit Message:

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-06 Thread Mike Percy (Code Review)
Hello Dinesh Bhat, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5045 to look at the new patch set (#10). Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async ..

[kudu-CR] [consensus] KUDU-1613: Fix replica eviction failure for WRONG SERVER UUID

2016-12-06 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5111 to look at the new patch set (#7). Change subject: [consensus] KUDU-1613: Fix replica eviction failure for WRONG_SERVER_UUID ..

[kudu-CR] [consensus] KUDU-1613: Fix replica eviction failure for WRONG SERVER UUID

2016-12-06 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [consensus] KUDU-1613: Fix replica eviction failure for WRONG_SERVER_UUID .. Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/5111/5//COMMIT_MSG Com

[kudu-CR] [consensus] KUDU-1613: Fix replica eviction failure for WRONG SERVER UUID

2016-12-06 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5111 to look at the new patch set (#6). Change subject: [consensus] KUDU-1613: Fix replica eviction failure for WRONG_SERVER_UUID ..

[kudu-CR] Update partition syntax for single value range partitions

2016-12-06 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Update partition syntax for single value range partitions .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5368 To unsubscri

[kudu-CR] client: don't log retriable scanner errors

2016-12-06 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: client: don't log retriable scanner errors .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5380 To unsubscribe, visit http:

[kudu-CR] KUDU-1789. Fix ScannerKeepAlive leaking RPCs when scanner is already expired

2016-12-06 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1789. Fix ScannerKeepAlive leaking RPCs when scanner is already expired .. Patch Set 1: Code-Review+2 Really nice find. -- To view, visit http://ger

[kudu-CR] KUDU-1785. Fix potential crash in TabletCopySourceSession

2016-12-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1785. Fix potential crash in TabletCopySourceSession .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/5363/2/src/kudu/integration-tests/tablet

[kudu-CR] KUDU-1785. Fix potential crash in TabletCopySourceSession

2016-12-06 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5363 to look at the new patch set (#3). Change subject: KUDU-1785. Fix potential crash in TabletCopySourceSession .. KUD

[kudu-CR] Output more info when a snapshot scan fails due to history gc

2016-12-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Output more info when a snapshot scan fails due to history gc .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5374 To unsubscribe,

[kudu-CR] rpc: show outbound call state in /rpcz dump

2016-12-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: rpc: show outbound call state in /rpcz dump .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5371/1/src/kudu/rpc/rpc_introspection.pro

[kudu-CR] Output more info when a snapshot scan fails due to history gc

2016-12-06 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Output more info when a snapshot scan fails due to history gc .. Output more info when a snapshot scan fails due to history gc This just adds some niceties

[kudu-CR] WIP integration test for snapshot scans

2016-12-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP integration test for snapshot scans .. Patch Set 8: (2 comments) need to look at this in some more detail tomorrow. definitely needs some updates on comments

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 5) Correct safe time advancement .. Patch Set 27: (1 comment) http://gerrit.cloudera.org:8080/#/c/5240/27/src/kudu/consensus/raft_consensus

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-798 (part 5) Correct safe time advancement .. Patch Set 27: (10 comments) http://gerrit.cloudera.org:8080/#/c/5240/27//COMMIT_MSG Commit Message: PS27, Line

[kudu-CR] [i-tests] separated implementation of the ext mini-cluster

2016-12-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [i-tests] separated implementation of the ext mini-cluster .. Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/5367/2//COMMIT_MSG Commit

[kudu-CR] KUDU-1608: Catalog manager can stop retrying DeleteTablet upon fatal errors

2016-12-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1608: Catalog manager can stop retrying DeleteTablet upon fatal errors .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5357/1//COMMIT_MSG Com

[kudu-CR] Silence gcc warning on TimeManager::GetSafeTimeUnlocked()

2016-12-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Silence gcc warning on TimeManager::GetSafeTimeUnlocked() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5381 To unsubscribe, vis

[kudu-CR] Silence gcc warning on TimeManager::GetSafeTimeUnlocked()

2016-12-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5381 Change subject: Silence gcc warning on TimeManager::GetSafeTimeUnlocked() .. Silence gcc warning on TimeManager::GetSafeTimeUnlocke

[kudu-CR] KUDU-1776: Fix "kudu remote replica copy" binding to wildcard address

2016-12-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1776: Fix "kudu remote_replica copy" binding to wildcard address .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/5378/1//COMMIT_MSG Commit

[kudu-CR] WIP integration test for snapshot scans

2016-12-06 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5375 to look at the new patch set (#8). Change subject: WIP integration test for snapshot scans .. WIP integration test

[kudu-CR] client: don't log retriable scanner errors

2016-12-06 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5380 to review the following change. Change subject: client: don't log retriable scanner errors .. client: don't log retriab

[kudu-CR] KUDU-1789. Fix ScannerKeepAlive leaking RPCs when scanner is already expired

2016-12-06 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5379 to review the following change. Change subject: KUDU-1789. Fix ScannerKeepAlive leaking RPCs when scanner is already expired ..

[kudu-CR] WIP integration test for snapshot scans

2016-12-06 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5375 to look at the new patch set (#7). Change subject: WIP integration test for snapshot scans .. WIP integration test

[kudu-CR] WIP integration test for snapshot scans

2016-12-06 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5375 to look at the new patch set (#6). Change subject: WIP integration test for snapshot scans .. WIP integration test

[kudu-CR] Output more info when a snapshot scan fails due to history gc

2016-12-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Output more info when a snapshot scan fails due to history gc .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5374 To unsubscribe,

[kudu-CR] KUDU-1776: Fix "kudu remote replica copy" binding to wildcard address

2016-12-06 Thread Dinesh Bhat (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5378 to review the following change. Change subject: KUDU-1776: Fix "kudu remote_replica copy" binding to wildcard address

[kudu-CR] WIP integration test for snapshot scans

2016-12-06 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5375 to look at the new patch set (#5). Change subject: WIP integration test for snapshot scans .. WIP integration test

[kudu-CR] WIP integration test for snapshot scans

2016-12-06 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5375 to look at the new patch set (#4). Change subject: WIP integration test for snapshot scans .. WIP integration test

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-06 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#27). Change subject: KUDU-798 (part 5) Correct safe time advancement .. KUDU-798 (pa

[kudu-CR] WIP integration test for snapshot scans

2016-12-06 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5375 to look at the new patch set (#3). Change subject: WIP integration test for snapshot scans .. WIP integration test