[kudu-CR] [authn token expire-itest] minor clean-up

2017-05-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#2). Change subject: [authn_token_expire-itest] minor clean-up .. [authn_token_expire-itest] minor clean-up This patch contains a couple of updates on authn_token_expire-itest: *

[kudu-CR] [authn token expire-itest] minor clean-up

2017-05-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6987 Change subject: [authn_token_expire-itest] minor clean-up .. [authn_token_expire-itest] minor clean-up This patch contains a couple of

[kudu-CR] KUDU-2021 test for negotiation timeout on Master RPCs

2017-05-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2021 test for negotiation timeout on Master RPCs .. Patch Set 8: Verified+1 Flakes: 1. Port conflict while running

[kudu-CR] KUDU-1911 add more helpful error message when required tool arguments are missing

2017-05-24 Thread Sam Okrent (Code Review)
Sam Okrent has uploaded a new change for review. http://gerrit.cloudera.org:8080/6986 Change subject: KUDU-1911 add more helpful error message when required tool arguments are missing .. KUDU-1911 add more helpful error

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 35: (1 comment) http://gerrit.cloudera.org:8080/#/c/6636/35/src/kudu/fs/block_manager-test.cc File

[kudu-CR] KUDU-2021 test for negotiation timeout on Master RPCs

2017-05-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2021 test for negotiation timeout on Master RPCs .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/6927/6//COMMIT_MSG Commit Message: Line

[kudu-CR] KUDU-2021 test for negotiation timeout on Master RPCs

2017-05-24 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6927 to look at the new patch set (#8). Change subject: KUDU-2021 test for negotiation timeout on Master RPCs ..

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-24 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#38). Change subject: KUDU-1952 Remove round-robin for block placement ..

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-24 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#37). Change subject: KUDU-1952 Remove round-robin for block placement ..

[kudu-CR] KUDU-1580 retry tserver RPC if negotiation times out

2017-05-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: KUDU-1580 retry tserver RPC if negotiation times out .. KUDU-1580 retry tserver RPC if negotiation times out This patch addresses KUDU-1580, i.e. with

[kudu-CR] consensus: consolidate Raft thread pools

2017-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: consensus: consolidate Raft thread pools .. Patch Set 4: I ran raft_consensus-itest in slow mode 1000 times. All of them passed. -- To view, visit

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-24 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#36). Change subject: KUDU-1952 Remove round-robin for block placement ..

[kudu-CR] server: move apply pool into ServerBase

2017-05-24 Thread Adar Dembo (Code Review)
Hello Dan Burkert, David Ribeiro Alves, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6984 to look at the new patch set (#2). Change subject: server: move apply_pool into ServerBase

[kudu-CR] threadpool: token-based task sequencing

2017-05-24 Thread Adar Dembo (Code Review)
Hello Dan Burkert, David Ribeiro Alves, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6874 to look at the new patch set (#4). Change subject: threadpool: token-based task sequencing

[kudu-CR] threadpool: new test for pools with no max threads

2017-05-24 Thread Adar Dembo (Code Review)
Hello Dan Burkert, David Ribeiro Alves, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6945 to look at the new patch set (#5). Change subject: threadpool: new test for pools with no max_threads

[kudu-CR] consensus: consolidate Raft thread pools

2017-05-24 Thread Adar Dembo (Code Review)
Hello Dan Burkert, David Ribeiro Alves, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6946 to look at the new patch set (#4). Change subject: consensus: consolidate Raft thread pools

[kudu-CR] server: move apply pool into ServerBase

2017-05-24 Thread Adar Dembo (Code Review)
Hello Dan Burkert, David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6984 to review the following change. Change subject: server: move apply_pool into ServerBase

[kudu-CR] consensus: consolidate Raft thread pools

2017-05-24 Thread Adar Dembo (Code Review)
Hello Dan Burkert, David Ribeiro Alves, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6946 to look at the new patch set (#3). Change subject: consensus: consolidate Raft thread pools

[kudu-CR] KUDU-1580 retry tserver RPC if negotiation times out

2017-05-24 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1580 retry tserver RPC if negotiation times out .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6926 To unsubscribe, visit

[kudu-CR] KUDU-1034 client does not failover due to timeout

2017-05-24 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1034 client does not failover due to timeout .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6924 To unsubscribe, visit

[kudu-CR] KUDU-2021 retry master RPC if negotiation times out

2017-05-24 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-2021 retry master RPC if negotiation times out .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/6927/6//COMMIT_MSG Commit Message: Line 7:

[kudu-CR] KUDU-1580 retry tserver RPC if negotiation times out

2017-05-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1580 retry tserver RPC if negotiation times out .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6926/7/src/kudu/rpc/outbound_call.cc File

[kudu-CR] consensus: consolidate Raft thread pools

2017-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: consensus: consolidate Raft thread pools .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6946/2/src/kudu/consensus/consensus_peers.h File

[kudu-CR] KUDU-1034 client does not failover due to timeout

2017-05-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1034 client does not failover due to timeout .. Patch Set 6: (2 comments)

[kudu-CR] KUDU-1034 client does not failover due to timeout

2017-05-24 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6924 to look at the new patch set (#7). Change subject: KUDU-1034 client does not failover due to timeout ..

[kudu-CR] KUDU-1580 retry tserver RPC if negotiation times out

2017-05-24 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6926 to look at the new patch set (#9). Change subject: KUDU-1580 retry tserver RPC if negotiation times out

[kudu-CR] KUDU-1580 retry tserver RPC if negotiation times out

2017-05-24 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1580 retry tserver RPC if negotiation times out .. Patch Set 8: Code-Review+2 (1 comment)

[kudu-CR] threadpool: token-based task sequencing

2017-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: threadpool: token-based task sequencing .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/6874/3/src/kudu/util/threadpool-test.cc File

[kudu-CR] KUDU-1034 client does not failover due to timeout

2017-05-24 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1034 client does not failover due to timeout .. Patch Set 6: Code-Review+1 (1 comment)

[kudu-CR] KUDU-1034 client does not failover due to timeout

2017-05-24 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6924 to look at the new patch set (#6). Change subject: KUDU-1034 client does not failover due to timeout .. KUDU-1034

[kudu-CR] KUDU-1580 retry tserver RPC if negotiation times out

2017-05-24 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6926 to look at the new patch set (#8). Change subject: KUDU-1580 retry tserver RPC if negotiation times out ..

[kudu-CR] KUDU-1988: add support for advertised host:port info.

2017-05-24 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1988: add support for advertised host:port info. .. KUDU-1988: add support for advertised host:port info. Prior to this change, it was difficult to

[kudu-CR] KUDU-1034 client does not failover due to timeout

2017-05-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1034 client does not failover due to timeout .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6924/4/src/kudu/rpc/retriable_rpc.h File

[kudu-CR] KUDU-1988: add support for advertised host:port info.

2017-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1988: add support for advertised host:port info. .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6827 To unsubscribe, visit

[kudu-CR] KUDU-1988: add support for advertised host:port info.

2017-05-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1988: add support for advertised host:port info. .. Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/6827/12//COMMIT_MSG Commit Message:

[kudu-CR] KUDU-1988: add support for advertised host:port info.

2017-05-24 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6827 to look at the new patch set (#13). Change subject: KUDU-1988: add support for advertised host:port info. ..

[kudu-CR] KUDU-1988: add support for advertised host:port info.

2017-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1988: add support for advertised host:port info. .. Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/6827/12//COMMIT_MSG Commit Message: PS12,

[kudu-CR] KUDU-1988: add support for advertised host:port info.

2017-05-24 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6827 to look at the new patch set (#12). Change subject: KUDU-1988: add support for advertised host:port info. ..

[kudu-CR] KUDU-1580 retry tserver RPC if negotiation times out

2017-05-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1580 retry tserver RPC if negotiation times out .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6926/7/src/kudu/rpc/outbound_call.cc File

[kudu-CR] KUDU-1580 retry tserver RPC if negotiation times out

2017-05-24 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1580 retry tserver RPC if negotiation times out .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/6926/7/src/kudu/rpc/outbound_call.cc File

[kudu-CR] KUDU-1860: ksck doesn't identify tablets that are evicted but still in config

2017-05-24 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: KUDU-1860: ksck doesn't identify tablets that are evicted but still in config .. KUDU-1860: ksck doesn't identify tablets that are evicted but still in

[kudu-CR] KUDU-1034 client does not failover due to timeout

2017-05-24 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1034 client does not failover due to timeout .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6924/4/src/kudu/rpc/retriable_rpc.h File

[kudu-CR] KUDU-1988: add support for advertised host:port info.

2017-05-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1988: add support for advertised host:port info. .. Patch Set 10: (35 comments) http://gerrit.cloudera.org:8080/#/c/6827/10//COMMIT_MSG Commit Message:

[kudu-CR] KUDU-1988: add support for advertised host:port info.

2017-05-24 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6827 to look at the new patch set (#11). Change subject: KUDU-1988: add support for advertised host:port info. ..

[kudu-CR] docs: clarify that max cell size applies to uncompressed size

2017-05-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: docs: clarify that max cell size applies to uncompressed size .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6977 To

[kudu-CR] KUDU-1755 Part 2: Improve table on-disk size metric

2017-05-24 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#3). Change subject: KUDU-1755 Part 2: Improve table on-disk size metric ..

[kudu-CR] KUDU-1034 client does not failover due to timeout

2017-05-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1034 client does not failover due to timeout .. Patch Set 4: (3 comments)

[kudu-CR] KUDU-1860: ksck doesn't identify tablets that are evicted but still in config

2017-05-24 Thread Will Berkeley (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6772 to look at the new patch set (#11). Change subject: KUDU-1860: ksck doesn't identify tablets that are evicted but still in config

[kudu-CR] KUDU-1860: ksck doesn't identify tablets that are evicted but still in config

2017-05-24 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1860: ksck doesn't identify tablets that are evicted but still in config .. Patch Set 10: (1 comment)

[kudu-CR] KUDU-1034 client does not failover due to timeout

2017-05-24 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1034 client does not failover due to timeout .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/6924/4/src/kudu/rpc/retriable_rpc.h File

[kudu-CR] KUDU-1034 client does not failover due to timeout

2017-05-24 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1034 client does not failover due to timeout .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-1034 client does not failover due to timeout

2017-05-24 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6924 to look at the new patch set (#5). Change subject: KUDU-1034 client does not failover due to timeout .. KUDU-1034

[kudu-CR] KUDU-1580 retry tserver RPC if negotiation times out

2017-05-24 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6926 to look at the new patch set (#7). Change subject: KUDU-1580 retry tserver RPC if negotiation times out ..

[kudu-CR] KUDU-1034 client does not failover due to timeout

2017-05-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1034 client does not failover due to timeout .. Patch Set 4: (3 comments)

[kudu-CR] KUDU-1580 retry tserver RPC if negotiation times out

2017-05-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1580 retry tserver RPC if negotiation times out .. Patch Set 6: (4 comments) > (4 comments) > > I'm not sure what the purpose is of

[kudu-CR] KUDU-1860: ksck doesn't identify tablets that are evicted but still in config

2017-05-24 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1860: ksck doesn't identify tablets that are evicted but still in config .. Patch Set 10: Code-Review+1 (3 comments)

[kudu-CR] KUDU-1580 retry tserver RPC if negotiation times out

2017-05-24 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1580 retry tserver RPC if negotiation times out .. Patch Set 6: (4 comments) I'm not sure what the purpose is of NEGOTIATION_TIMED_OUT in the current patch.

[kudu-CR] KUDU-1988: add support for advertised host:port info.

2017-05-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1988: add support for advertised host:port info. .. Patch Set 10: (10 comments) http://gerrit.cloudera.org:8080/#/c/6827/10/src/kudu/master/master.cc File

[kudu-CR] KUDU-1860: ksck doesn't identify tablets that are evicted but still in config

2017-05-24 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1860: ksck doesn't identify tablets that are evicted but still in config .. Patch Set 7: (8 comments) Both of your comments about more testing are things

[kudu-CR] KUDU-1034 client does not failover due to timeout

2017-05-24 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1034 client does not failover due to timeout .. Patch Set 4: (3 comments)

[kudu-CR] Fix flaky test TestRestartWithOrphanedReplicates

2017-05-24 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Fix flaky test TestRestartWithOrphanedReplicates .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6976/1//COMMIT_MSG Commit Message: PS1, Line 12:

[kudu-CR] Fix flaky test TestRestartWithOrphanedReplicates

2017-05-24 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. Change subject: Fix flaky test TestRestartWithOrphanedReplicates .. Patch Set 2: (3 comments)

[kudu-CR] Fix flaky test TestRestartWithOrphanedReplicates

2017-05-24 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. Change subject: Fix flaky test TestRestartWithOrphanedReplicates .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6976/1//COMMIT_MSG Commit Message: PS1,

[kudu-CR] KUDU-1988: add support for advertised host:port info.

2017-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1988: add support for advertised host:port info. .. Patch Set 10: (19 comments) http://gerrit.cloudera.org:8080/#/c/6827/10/src/kudu/server/CMakeLists.txt

[kudu-CR] Fix flaky test TestRestartWithOrphanedReplicates

2017-05-24 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Fix flaky test TestRestartWithOrphanedReplicates .. Patch Set 2: Code-Review+1 (3 comments) Change looks good, I have a few nitpicky comments about, well,

[kudu-CR] KUDU-1988: add support for advertised host:port info.

2017-05-24 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-1988: add support for advertised host:port info. .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/6827/10//COMMIT_MSG Commit Message: Line 7:

[kudu-CR] Fix flaky test TestRestartWithOrphanedReplicates

2017-05-24 Thread Edward Fancher (Code Review)
Edward Fancher has uploaded a new patch set (#2). Change subject: Fix flaky test TestRestartWithOrphanedReplicates .. Fix flaky test TestRestartWithOrphanedReplicates Looks like the test was setting a fault injection flag

[kudu-CR] KUDU-1755 Part 2: Improve table on-disk size metric

2017-05-24 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve table on-disk size metric .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6968/1/src/kudu/tablet/tablet_replica.cc

[kudu-CR] KUDU-1755 Part 2: Improve table on-disk size metric

2017-05-24 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#2). Change subject: KUDU-1755 Part 2: Improve table on-disk size metric ..

[kudu-CR] Fix flaky test

2017-05-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Fix flaky test .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6976/1//COMMIT_MSG Commit Message: PS1, Line 7: Fix flaky test it would be

[kudu-CR] docs: clarify that max cell size applies to uncompressed size

2017-05-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: docs: clarify that max cell size applies to uncompressed size .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6977/2/docs/known_issues.adoc File

[kudu-CR] docs: clarify that max cell size applies to uncompressed size

2017-05-24 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6977 to look at the new patch set (#3). Change subject: docs: clarify that max cell size applies to uncompressed size ..

[kudu-CR] docs: clarify that max cell size applies to uncompressed size

2017-05-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: docs: clarify that max cell size applies to uncompressed size .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6977/2/docs/known_issues.adoc File

[kudu-CR] docs: clarify that max cell size applies to uncompressed size

2017-05-24 Thread Dan Burkert (Code Review)
Hello Ambreen Kazi, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6977 to review the following change. Change subject: docs: clarify that max cell size applies to uncompressed size

[kudu-CR] KUDU-1988: add support for advertised host:port info.

2017-05-24 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6827 to look at the new patch set (#10). Change subject: KUDU-1988: add support for advertised host:port info. ..

[kudu-CR] Fix flaky test

2017-05-24 Thread Edward Fancher (Code Review)
Edward Fancher has restored this change. Change subject: Fix flaky test .. Restored -- To view, visit http://gerrit.cloudera.org:8080/6976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType:

[kudu-CR] KUDU-871 (part 1). Refactor to make cmeta a first class object

2017-05-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-871 (part 1). Refactor to make cmeta a first class object .. Patch Set 1: (6 comments) some nits while skimming through

[kudu-CR] KUDU-1988: add support for advertised host:port info.

2017-05-24 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6827 to look at the new patch set (#9). Change subject: KUDU-1988: add support for advertised host:port info. ..

[kudu-CR] Fix flaky test

2017-05-24 Thread Edward Fancher (Code Review)
Edward Fancher has abandoned this change. Change subject: Fix flaky test .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/6976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType:

[kudu-CR] Fix flaky test

2017-05-24 Thread Edward Fancher (Code Review)
Edward Fancher has uploaded a new change for review. http://gerrit.cloudera.org:8080/6976 Change subject: Fix flaky test .. Fix flaky test Looks like the test was setting a fault injection flag before the setup which was

[kudu-CR] KUDU-1988: add support for advertised host:port info.

2017-05-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1988: add support for advertised host:port info. .. Patch Set 8: Patrik indicated he's tied up today, and I want to make sure this lands in time for 1.4, so

[kudu-CR] KUDU-1755 Part 1: Improve tablet on disk size metric

2017-05-24 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6967 to look at the new patch set (#2). Change subject: KUDU-1755 Part 1: Improve tablet on disk size metric ..

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-05-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 35: (28 comments)

[kudu-CR] KUDU-1125 (part 1) catalog manager: try to avoid unnecessarily rewriting tablet info

2017-05-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1125 (part 1) catalog_manager: try to avoid unnecessarily rewriting tablet info .. Patch Set 3: (3 comments)