[kudu-CR] Adjust kerberos renewal logic to avoid tickets with NULL 'renew till' timestamp

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Adjust kerberos renewal logic to avoid tickets with NULL 'renew_till' timestamp .. Patch Set 2: (1 comment)

[kudu-CR] Adjust kerberos renewal logic to avoid tickets with NULL 'renew till' timestamp

2017-08-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: Adjust kerberos renewal logic to avoid tickets with NULL 'renew_till' timestamp .. Patch Set 2: (5 comments)

[kudu-CR] Adjust kerberos renewal logic to avoid tickets with NULL 'renew till' timestamp

2017-08-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). Change subject: Adjust kerberos renewal logic to avoid tickets with NULL 'renew_till' timestamp .. Adjust kerberos renewal logic to avoid tickets with NULL 'renew_till' timestamp

[kudu-CR] KUDU-1894 fixed deadlock in client.Connection

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1894 fixed deadlock in client.Connection .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/6960/10/src/kudu/consensus/raft_consensus.cc File

[kudu-CR] KUDU-2095 - Add `keepAlive` method to Java API

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2095 - Add `keepAlive` method to Java API .. Patch Set 3: (14 comments) http://gerrit.cloudera.org:8080/#/c/7749/3//COMMIT_MSG Commit Message: PS3, Line

[kudu-CR] Adjust kerberos renewal logic to avoid tickets with NULL 'renew till' timestamp

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Adjust kerberos renewal logic to avoid tickets with NULL 'renew_till' timestamp .. Patch Set 1: (5 comments)

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 10: (9 comments) http://gerrit.cloudera.org:8080/#/c/6960/10/src/kudu/consensus/raft_consensus.cc File

[kudu-CR] [build-support] IWYU build configuration for Jenkins

2017-08-21 Thread Alexey Serbin (Code Review)
Hello Dan Burkert, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7750 to look at the new patch set (#8). Change subject: [build-support] IWYU build configuration for Jenkins

[kudu-CR] util: remove old failure detector and resettable heartbeater code

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: util: remove old failure detector and resettable heartbeater code .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7736 To

[kudu-CR] consensus: use periodic timers for failure detection

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: use periodic timers for failure detection .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7735 To unsubscribe, visit

[kudu-CR] rpc: periodic timers

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: periodic timers .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7733 To unsubscribe, visit

[kudu-CR] consensus peers: replace bespoke Raft heartbeat logic with periodic timers

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus_peers: replace bespoke Raft heartbeat logic with periodic timers .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7734

[kudu-CR] rpc: periodic timers

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: periodic timers .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7733/2/src/kudu/rpc/periodic-test.cc File src/kudu/rpc/periodic-test.cc:

[kudu-CR](branch-1.4.x) KUDU-1942. Kerberos fails to log in on hostnames with capital letters

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital letters .. Patch Set 1: Verified+1 Unrelated flake -- To view, visit

[kudu-CR] KUDU-2032 (part 2): propagate master hostnames into client

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-2032 (part 2): propagate master hostnames into client .. KUDU-2032 (part 2): propagate master hostnames into client This changes the client code to

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 10: I think the failure was caused by already-flaky java tests but I am investigating. I'd like to figure out how

[kudu-CR] KUDU-2095 - Add `keepAlive` method to Java API

2017-08-21 Thread Anonymous Coward (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7749 to look at the new patch set (#3). Change subject: KUDU-2095 - Add `keepAlive` method to Java API .. KUDU-2095 -

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-21 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7207 to look at the new patch set (#21). Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. KUDU-1943:

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-21 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 21: (30 comments) http://gerrit.cloudera.org:8080/#/c/7207/19//COMMIT_MSG Commit Message: PS19, Line

[kudu-CR] disk failure: don't open tablets on failed disks

2017-08-21 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7766 to look at the new patch set (#3). Change subject: disk failure: don't open tablets on failed disks .. disk

[kudu-CR] [build-support] IWYU build configuration for Jenkins

2017-08-21 Thread Alexey Serbin (Code Review)
Hello Dan Burkert, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7750 to look at the new patch set (#6). Change subject: [build-support] IWYU build configuration for Jenkins

[kudu-CR] disk failure: add persistent disk states

2017-08-21 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#24). Change subject: disk failure: add persistent disk states .. disk failure: add

[kudu-CR] rpc: periodic timers

2017-08-21 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: rpc: periodic timers .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7733/2/src/kudu/rpc/periodic.cc File src/kudu/rpc/periodic.cc: Line 38:

[kudu-CR] consensus peers: replace bespoke Raft heartbeat logic with periodic timers

2017-08-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: consensus_peers: replace bespoke Raft heartbeat logic with periodic timers .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7734/2//COMMIT_MSG

[kudu-CR] rpc: periodic timers

2017-08-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: rpc: periodic timers .. Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/7733/2/src/kudu/rpc/periodic-test.cc File src/kudu/rpc/periodic-test.cc:

[kudu-CR] consensus: use periodic timers for failure detection

2017-08-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: consensus: use periodic timers for failure detection .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/7735/2/src/kudu/consensus/raft_consensus.cc

[kudu-CR] consensus: use periodic timers for failure detection

2017-08-21 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7735 to look at the new patch set (#3). Change subject: consensus: use periodic timers for failure detection ..

[kudu-CR] rpc: periodic timers

2017-08-21 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7733 to look at the new patch set (#3). Change subject: rpc: periodic timers .. rpc: periodic timers This patch

[kudu-CR] util: remove old failure detector and resettable heartbeater code

2017-08-21 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7736 to look at the new patch set (#3). Change subject: util: remove old failure detector and resettable heartbeater code

[kudu-CR] consensus peers: replace bespoke Raft heartbeat logic with periodic timers

2017-08-21 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7734 to look at the new patch set (#3). Change subject: consensus_peers: replace bespoke Raft heartbeat logic with periodic timers

[kudu-CR] KUDU-1894 fixed deadlock in client.Connection

2017-08-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1894 fixed deadlock in client.Connection .. Patch Set 2: Code-Review-1 (1 comment)

[kudu-CR] disk failure: don't open tablets on failed disks

2017-08-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: don't open tablets on failed disks .. Patch Set 2: This is currently dependent on https://gerrit.cloudera.org/#/c/7440/, which will change given

[kudu-CR] disk failure: don't open tablets on failed disks

2017-08-21 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#2). Change subject: disk failure: don't open tablets on failed disks .. disk failure: don't open tablets on failed disks Currently Kudu servers open the FS layout with failed disks.

[kudu-CR] consensus: Tablet copy should clear last-logged opid from superblock

2017-08-21 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: consensus: Tablet copy should clear last-logged opid from superblock .. consensus: Tablet copy should clear last-logged opid from superblock Keeping

[kudu-CR] consensus: Tablet copy should clear last-logged opid from superblock

2017-08-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: consensus: Tablet copy should clear last-logged opid from superblock .. Patch Set 5: Verified+1 The failure in this build was caused by a host error, as seen in

[kudu-CR] consensus: Improve contract for API to fetch last-logged op id

2017-08-21 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: consensus: Improve contract for API to fetch last-logged op id .. consensus: Improve contract for API to fetch last-logged op id It's important that we

[kudu-CR] KUDU-1894 fixed deadlock in client.Connection

2017-08-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#2). Change subject: KUDU-1894 fixed deadlock in client.Connection .. KUDU-1894 fixed deadlock in client.Connection Due to the reverse order of acquiring the Connection.lock and

[kudu-CR] KUDU-1894 fixed deadlock in client.Connection

2017-08-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1894 fixed deadlock in client.Connection .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/7765/1//COMMIT_MSG Commit Message: Line 13:

[kudu-CR] [java] fixed deadlock in client.Connection

2017-08-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java] fixed deadlock in client.Connection .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7765/1//COMMIT_MSG Commit Message: Line 13: This

[kudu-CR] KUDU-1407: reassign failed tablets

2017-08-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1407: reassign failed tablets .. Patch Set 15: Just rebased this in my series of start-time failure-handling patches, since it's necessary for

[kudu-CR] avoid opening tablets on failed disks

2017-08-21 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7766 Change subject: avoid opening tablets on failed disks .. avoid opening tablets on failed disks Currently Kudu servers can start up with

[kudu-CR] [java] fixed deadlock in client.Connection

2017-08-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/7765 Change subject: [java] fixed deadlock in client.Connection .. [java] fixed deadlock in client.Connection Due to the reverse order of

[kudu-CR] KUDU-2032 (part 2): propagate master hostnames into client

2017-08-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2032 (part 2): propagate master hostnames into client .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7692 To unsubscribe,

[kudu-CR] [java] Include Spark/Scala base version in kudu-spark-tools

2017-08-21 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: [java] Include Spark/Scala base version in kudu-spark-tools .. [java] Include Spark/Scala base version in kudu-spark-tools Renames the kudu-spark-tools

[kudu-CR](branch-1.4.x) KUDU-1942. Kerberos fails to log in on hostnames with capital letters

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/7763 Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital letters .. KUDU-1942. Kerberos fails to log in on hostnames

[kudu-CR](branch-1.3.x) KUDU-1942. Kerberos fails to log in on hostnames with capital letters

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/7764 Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital letters .. KUDU-1942. Kerberos fails to log in on hostnames

[kudu-CR] KUDU-2032 (part 2): propagate master hostnames into client

2017-08-21 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7692 to look at the new patch set (#8). Change subject: KUDU-2032 (part 2): propagate master hostnames into client

[kudu-CR] consensus: Tablet copy should clear last-logged opid from superblock

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: Tablet copy should clear last-logged opid from superblock .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7718 To

[kudu-CR] consensus: Improve contract for API to fetch last-logged op id

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: Improve contract for API to fetch last-logged op id .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7717 To

[kudu-CR] consensus: Improve contract for API to fetch last-logged op id

2017-08-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: consensus: Improve contract for API to fetch last-logged op id .. Patch Set 4: I had to manually rebase on top of Alexey's IWYU patch. The conflicts were very

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-21 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6960 to look at the new patch set (#10). Change subject: KUDU-871. Support tombstoned voting .. KUDU-871. Support

[kudu-CR] consensus: Tablet copy should clear last-logged opid from superblock

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: Tablet copy should clear last-logged opid from superblock .. Patch Set 4: Code-Review+2 Got it, sorry for the confusion. -- To view, visit

[kudu-CR] consensus: Improve contract for API to fetch last-logged op id

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: Improve contract for API to fetch last-logged op id .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7717 To

[kudu-CR] Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a .. Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a This commit had some

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-08-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#10). Change subject: Kudu Consistency Blog Post Pt1 .. Kudu Consistency Blog Post Pt1 This is the first part of multi-part blog post series about consistency in Kudu. It's hard

[kudu-CR] [tools] Add summary-only mode to ksck

2017-08-21 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [tools] Add summary-only mode to ksck .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7759/2/src/kudu/tools/ksck.cc File

[kudu-CR] Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a .. Patch Set 2: Verified+1 Pushing without waiting for tests since this unbreaks build (ensured that

[kudu-CR] [tools] Add summary-only mode to ksck

2017-08-21 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new patch set (#2). Change subject: [tools] Add summary-only mode to ksck .. [tools] Add summary-only mode to ksck This patch add a -summary_only flag to ksck, which suppresses all output except for

[kudu-CR] [tools] Add summary-only mode to ksck

2017-08-21 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [tools] Add summary-only mode to ksck .. Patch Set 1: Verified+1 Build failure due to KUDU-1736 (certainly unrelated to this patch). -- To view, visit

[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

2017-08-21 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1811: C++ client: use larger batches when fetching scan tokens .. Patch Set 5: (2 comments) Overall I think this is a good change, but I wonder if it

[kudu-CR] Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a

2017-08-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7762 To

[kudu-CR] Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a

2017-08-21 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7762 to look at the new patch set (#2). Change subject: Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a ..

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 20: (30 comments) http://gerrit.cloudera.org:8080/#/c/7207/19//COMMIT_MSG Commit Message: PS19,

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-08-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#9). Change subject: Kudu Consistency Blog Post Pt1 .. Kudu Consistency Blog Post Pt1 This is the first part of multi-part blog post series about consistency in Kudu. It's hard

[kudu-CR] consensus peers: replace bespoke Raft heartbeat logic with periodic timers

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus_peers: replace bespoke Raft heartbeat logic with periodic timers .. Patch Set 2: (1 comment)

[kudu-CR] Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a

2017-08-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a .. Patch Set 1: (1 comment)

[kudu-CR] Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7762/1/src/kudu/rpc/connection_id.cc

[kudu-CR] KUDU-1811: C++ client: use larger batches when fetching scan tokens

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1811: C++ client: use larger batches when fetching scan tokens .. Patch Set 5: (2 comments) just a couple nits. I also added Dan who knows this code a bit

[kudu-CR] consensus peers: replace bespoke Raft heartbeat logic with periodic timers

2017-08-21 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: consensus_peers: replace bespoke Raft heartbeat logic with periodic timers .. Patch Set 2: (1 comment)

[kudu-CR] Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a

2017-08-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a .. Patch Set 1: (1 comment)

[kudu-CR] consensus: use periodic timers for failure detection

2017-08-21 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: consensus: use periodic timers for failure detection .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7735/2/src/kudu/consensus/raft_consensus.cc

[kudu-CR] KUDU-2032 (part 2): propagate master hostnames into client

2017-08-21 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7692 to look at the new patch set (#7). Change subject: KUDU-2032 (part 2): propagate master hostnames into client

[kudu-CR] util: remove old failure detector and resettable heartbeater code

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: util: remove old failure detector and resettable heartbeater code .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7736 To

[kudu-CR] Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a

2017-08-21 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7762 to review the following change. Change subject: Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a ..

[kudu-CR] consensus peers: replace bespoke Raft heartbeat logic with periodic timers

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus_peers: replace bespoke Raft heartbeat logic with periodic timers .. Patch Set 2: (1 comment)

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-08-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#8). Change subject: Kudu Consistency Blog Post Pt1 .. Kudu Consistency Blog Post Pt1 This is the first part of multi-part blog post series about consistency in Kudu. It's hard

[kudu-CR] KUDU-2032 (part 2): propagate master hostnames into client

2017-08-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2032 (part 2): propagate master hostnames into client .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7692 To unsubscribe,

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-08-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#7). Change subject: Kudu Consistency Blog Post Pt1 .. Kudu Consistency Blog Post Pt1 This is the first part of multi-part blog post series about consistency in Kudu. It's hard

[kudu-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies This modifies the

[kudu-CR] [build-support] IWYU build configuration for Jenkins

2017-08-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [build-support] IWYU build configuration for Jenkins .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7750 To unsubscribe, visit

[kudu-CR] consensus: use periodic timers for failure detection

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: use periodic timers for failure detection .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7735/2/src/kudu/consensus/raft_consensus.cc

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-08-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Kudu Consistency Blog Post Pt1 .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/7019/6//COMMIT_MSG Commit Message: PS6, Line 25: dralves-server

[kudu-CR] disk failure: add persistent disk states

2017-08-21 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#22). Change subject: disk failure: add persistent disk states .. disk failure: add

[kudu-CR] consensus peers: replace bespoke Raft heartbeat logic with periodic timers

2017-08-21 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: consensus_peers: replace bespoke Raft heartbeat logic with periodic timers .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-08-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7687 To

[kudu-CR] consensus peers: replace bespoke Raft heartbeat logic with periodic timers

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus_peers: replace bespoke Raft heartbeat logic with periodic timers .. Patch Set 2: Code-Review+1 (1 comment)

[kudu-CR] [build-support] IWYU build configuration for Jenkins

2017-08-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [build-support] IWYU build configuration for Jenkins .. Patch Set 4: (1 comment)

[kudu-CR] [build-support] IWYU build configuration for Jenkins

2017-08-21 Thread Alexey Serbin (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7750 to look at the new patch set (#5). Change subject: [build-support] IWYU build configuration for Jenkins

[kudu-CR] rpc: periodic timers

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: periodic timers .. Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/7733/2/src/kudu/rpc/periodic-test.cc File src/kudu/rpc/periodic-test.cc:

[kudu-CR] rpc: periodic timers

2017-08-21 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: rpc: periodic timers .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7733/2/src/kudu/rpc/periodic.cc File src/kudu/rpc/periodic.cc: Line 38:

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-08-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#6). Change subject: Kudu Consistency Blog Post Pt1 .. Kudu Consistency Blog Post Pt1 This is the first part of multi-part blog post series about consistency in Kudu. It's hard

[kudu-CR] [iwyu] first pass

2017-08-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [iwyu] first pass .. [iwyu] first pass Updated C++ source files in accordance with some of the recommendations from include-what-you-use (IWYU) tool:

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-08-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#5). Change subject: Kudu Consistency Blog Post Pt1 .. Kudu Consistency Blog Post Pt1 This is the first part of multi-part blog post series about consistency in Kudu. It's hard

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-08-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#4). Change subject: Kudu Consistency Blog Post Pt1 .. Kudu Consistency Blog Post Pt1 This is the first part of multi-part blog post series about consistency in Kudu. It's hard

[kudu-CR] consensus: Improve contract for API to fetch last-logged op id

2017-08-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: consensus: Improve contract for API to fetch last-logged op id .. Patch Set 3: (2 comments)

[kudu-CR] rpc: periodic timers

2017-08-21 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: rpc: periodic timers .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7733/2/src/kudu/rpc/periodic-test.cc File src/kudu/rpc/periodic-test.cc:

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-21 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 20: (26 comments) http://gerrit.cloudera.org:8080/#/c/7207/19//COMMIT_MSG Commit Message: PS19, Line

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-21 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7207 to look at the new patch set (#20). Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. KUDU-1943:

[kudu-CR] [java] KUDU-2103 Canonicalize hostnames in client

2017-08-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java] KUDU-2103 Canonicalize hostnames in client .. Patch Set 1: (5 comments)

  1   2   >