[kudu-CR] thread: improve performance of starting threads

2017-10-10 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, David Ribeiro Alves, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8257 to look at the new patch set (#2). Change subject: thread: improve performance of starting threads ...

[kudu-CR] KUDU-2187. Don't hold threadpool lock while creating threads

2017-10-10 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, David Ribeiro Alves, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8256 to look at the new patch set (#2). Change subject: KUDU-2187. Don't hold threadpool lock while creating threads ..

[kudu-CR] KUDU-2187. Don't hold threadpool lock while creating threads

2017-10-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8256 ) Change subject: KUDU-2187. Don't hold threadpool lock while creating threads .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:808

[kudu-CR] KUDU-2187. Don't hold threadpool lock while creating threads

2017-10-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8256 ) Change subject: KUDU-2187. Don't hold threadpool lock while creating threads .. Patch Set 1: (2 comments) http://gerrit.cloudera

[kudu-CR] thread: improve performance of starting threads

2017-10-10 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8257 to review the following change. Change subject: thread: improve performance of starting threads .. thread: improve perf

[kudu-CR] KUDU-2187. Don't hold threadpool lock while creating threads

2017-10-10 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8256 to review the following change. Change subject: KUDU-2187. Don't hold threadpool lock while creating threads .. KUDU-21

[kudu-CR] mini-kdc: two workarounds to help Java tests pass in more environments

2017-10-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8253 ) Change subject: mini-kdc: two workarounds to help Java tests pass in more environments .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2055 [part 4]: refactor BM to remove BlockManager::DeleteBlock

2017-10-10 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8219 to look at the new patch set (#3). Change subject: KUDU-2055 [part 4]: refactor BM to remove BlockManager::DeleteBlock .

[kudu-CR] KUDU-2055 [part 4]: refactor BM to remove BlockManager::DeleteBlock

2017-10-10 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8219 ) Change subject: KUDU-2055 [part 4]: refactor BM to remove BlockManager::DeleteBlock .. Patch Set 2: (5 comments) http://gerrit.cloudera.org

[kudu-CR] catalog manager: fix DDL race

2017-10-10 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8254 to look at the new patch set (#2). Change subject: catalog manager: fix DDL race .. catalog ma

[kudu-CR] KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction

2017-10-10 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8144 ) Change subject: KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction .. Patch Set 11: (1 comment) http://gerr

[kudu-CR] KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction

2017-10-10 Thread Hao Hao (Code Review)
Hello Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8144 to look at the new patch set (#11). Change subject: KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction

[kudu-CR] catalog manager: fix DDL race

2017-10-10 Thread Dan Burkert (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8254 to review the following change. Change subject: catalog manager: fix DDL race .. catalog manager: fix DDL race This fi

[kudu-CR] WIP: java-client: enforce that only Java 7 APIs are used

2017-10-10 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8250 ) Change subject: WIP: java-client: enforce that only Java 7 APIs are used .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c

[kudu-CR](branch-1.5.x) KUDU-2188: restore Java 7 compatibility to artifacts built with JDK8

2017-10-10 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8252 ) Change subject: KUDU-2188: restore Java 7 compatibility to artifacts built with JDK8 .. KUDU-2188: restore Java 7 compatibility to

[kudu-CR] KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction

2017-10-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8144 ) Change subject: KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction .. Patch Set 10: (1 comment) http://g

[kudu-CR](branch-1.5.x) KUDU-2188: restore Java 7 compatibility to artifacts built with JDK8

2017-10-10 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8252 ) Change subject: KUDU-2188: restore Java 7 compatibility to artifacts built with JDK8 .. Patch Set 1: Code-Review+2 -- To view, visit ht

[kudu-CR] KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction

2017-10-10 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8144 ) Change subject: KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction .. Patch Set 10: (2 comments) http://ger

[kudu-CR] KUDU-2048. consensus: only evict unresponsive nodes if remaining voters are viable

2017-10-10 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8245 ) Change subject: KUDU-2048. consensus: only evict unresponsive nodes if remaining voters are viable .. Patch Set 1: (1 comment) http://ge

[kudu-CR] mini-kdc: two workarounds to help Java tests pass in more environments

2017-10-10 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8253 to review the following change. Change subject: mini-kdc: two workarounds to help Java tests pass in more environments ..

[kudu-CR] KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction

2017-10-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8144 ) Change subject: KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction .. Patch Set 10: (2 comments) http://

[kudu-CR] KUDU-2184. Avoid allocations larger than 1MB

2017-10-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8239 ) Change subject: KUDU-2184. Avoid allocations larger than 1MB .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloud

[kudu-CR] KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction

2017-10-10 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8144 ) Change subject: KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction .. Patch Set 7: (2 comments) http://gerr

[kudu-CR] KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction

2017-10-10 Thread Hao Hao (Code Review)
Hello Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8144 to look at the new patch set (#10). Change subject: KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction

[kudu-CR] KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction

2017-10-10 Thread Hao Hao (Code Review)
Hello Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8144 to look at the new patch set (#9). Change subject: KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction .

[kudu-CR](branch-1.5.x) KUDU-2188: restore Java 7 compatibility to artifacts built with JDK8

2017-10-10 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8252 Change subject: KUDU-2188: restore Java 7 compatibility to artifacts built with JDK8 .. KUDU-2188: restore Java 7 compatibility to artifact

[kudu-CR] KUDU-2188: restore Java 7 compatibility to artifacts built with JDK8

2017-10-10 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8249 ) Change subject: KUDU-2188: restore Java 7 compatibility to artifacts built with JDK8 .. KUDU-2188: restore Java 7 compatibility to

[kudu-CR] KUDU-2188: restore Java 7 compatibility to artifacts built with JDK8

2017-10-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8249 ) Change subject: KUDU-2188: restore Java 7 compatibility to artifacts built with JDK8 .. Patch Set 1: > Does this need to be backported?

[kudu-CR] KUDU-2184. Avoid allocations larger than 1MB

2017-10-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8239 ) Change subject: KUDU-2184. Avoid allocations larger than 1MB .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/823

[kudu-CR] KUDU-2188: restore Java 7 compatibility to artifacts built with JDK8

2017-10-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8249 ) Change subject: KUDU-2188: restore Java 7 compatibility to artifacts built with JDK8 .. Patch Set 1: Code-Review+2 lgtm. Does this need

[kudu-CR] KUDU-2188: restore Java 7 compatibility to artifacts built with JDK8

2017-10-10 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8249 ) Change subject: KUDU-2188: restore Java 7 compatibility to artifacts built with JDK8 .. Patch Set 1: Code-Review+2 -- To view, visit ht

[kudu-CR] WIP: KUDU-1366: allow building against jemalloc

2017-10-10 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6918 to look at the new patch set (#9). Change subject: WIP: KUDU-1366: allow building against jemalloc .. WIP:

[kudu-CR] KUDU-2184. Avoid allocations larger than 1MB

2017-10-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8239 ) Change subject: KUDU-2184. Avoid allocations larger than 1MB .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/8239/4/src/

[kudu-CR] KUDU-2184. Avoid allocations larger than 1MB

2017-10-10 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, David Ribeiro Alves, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8239 to look at the new patch set (#5). Change subject: KUDU-2184. Avoid allocations larger than 1MB ...

[kudu-CR] tsan: flush TSAN memory every 10 seconds

2017-10-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8251 Change subject: tsan: flush TSAN memory every 10 seconds .. tsan: flush TSAN memory every 10 seconds I'm seeing a TSAN precommit test fail

[kudu-CR] KUDU-1865 (part 1): reduce some cross-thread allocations

2017-10-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/5905 ) Change subject: KUDU-1865 (part 1): reduce some cross-thread allocations .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:

[kudu-CR] KUDU-2048. consensus: only evict unresponsive nodes if remaining voters are viable

2017-10-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8245 ) Change subject: KUDU-2048. consensus: only evict unresponsive nodes if remaining voters are viable .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2184. Avoid allocations larger than 1MB

2017-10-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8239 ) Change subject: KUDU-2184. Avoid allocations larger than 1MB .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/823

[kudu-CR] KUDU-2188: restore Java 7 compatibility to artifacts built with JDK8

2017-10-10 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8249 to review the following change. Change subject: KUDU-2188: restore Java 7 compatibility to artifacts built with JDK8

[kudu-CR] WIP: java-client: enforce that only Java 7 APIs are used

2017-10-10 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8250 to review the following change. Change subject: WIP: java-client: enforce that only Java 7 APIs are used .

[kudu-CR] itest: allow use of verifiers with EMCs that specify non-default block managers

2017-10-10 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8208 ) Change subject: itest: allow use of verifiers with EMCs that specify non-default block managers .. itest: allow use of verifiers w

[kudu-CR] KUDU-2184. Avoid allocations larger than 1MB

2017-10-10 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8239 to look at the new patch set (#4). Change subject: KUDU-2184. Avoid allocations larger than 1MB

[kudu-CR] itest: allow use of verifiers with EMCs that specify non-default block managers

2017-10-10 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8208 ) Change subject: itest: allow use of verifiers with EMCs that specify non-default block managers .. Patch Set 7: Code-Review+2 -- To view

[kudu-CR] KUDU-2048. consensus: only evict unresponsive nodes if remaining voters are viable

2017-10-10 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8245 ) Change subject: KUDU-2048. consensus: only evict unresponsive nodes if remaining voters are viable .. Patch Set 1: (1 comment) > Patch S

[kudu-CR] KUDU-2048. consensus: only evict unresponsive nodes if remaining voters are viable

2017-10-10 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8245 ) Change subject: KUDU-2048. consensus: only evict unresponsive nodes if remaining voters are viable .. Patch Set 1: (1 comment) http://ge

[kudu-CR] pb util: avoid repeated stat() calls reading files

2017-10-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8010 ) Change subject: pb_util: avoid repeated stat() calls reading files .. pb_util: avoid repeated stat() calls reading files This red

[kudu-CR] KUDU-2048. consensus: only evict unresponsive nodes if remaining voters are viable

2017-10-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8245 ) Change subject: KUDU-2048. consensus: only evict unresponsive nodes if remaining voters are viable .. Patch Set 1: (2 comments)

[kudu-CR] WIP: KUDU-1366: allow building against jemalloc

2017-10-10 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6918 to look at the new patch set (#8). Change subject: WIP: KUDU-1366: allow building against jemalloc .. WIP:

[kudu-CR] pb util: avoid repeated stat() calls reading files

2017-10-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8010 ) Change subject: pb_util: avoid repeated stat() calls reading files .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera

[kudu-CR] java client: remove JDK8 library calls from MiniKuduCluster

2017-10-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8248 ) Change subject: java client: remove JDK8 library calls from MiniKuduCluster .. Patch Set 1: Verified+1 Overriding Jenkins, another instanc

[kudu-CR] java client: remove JDK8 library calls from MiniKuduCluster

2017-10-10 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8248 ) Change subject: java client: remove JDK8 library calls from MiniKuduCluster .. java client: remove JDK8 library calls from MiniKudu

[kudu-CR] java client: remove JDK8 library calls from MiniKuduCluster

2017-10-10 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8248 ) Change subject: java client: remove JDK8 library calls from MiniKuduCluster .. Removed reviewer Kudu Jenkins with the following vot

[kudu-CR] java client: remove JDK8 library calls from MiniKuduCluster

2017-10-10 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/8248 ) Change subject: java client: remove JDK8 library calls from MiniKuduCluster .. Patch Set 1: Code-Review+2 -- To view, visit http:

[kudu-CR] java client: remove JDK8 library calls from MiniKuduCluster

2017-10-10 Thread Adar Dembo (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8248 to review the following change. Change subject: java client: remove JDK8 library calls from MiniKuduCluster ..

[kudu-CR] Allow configuration of values passed into kebreros env vars

2017-10-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8247 ) Change subject: Allow configuration of values passed into kebreros env vars .. Patch Set 1: Looks like a flaky timeout failure in clien

[kudu-CR] WIP: KUDU-1366: allow building against jemalloc

2017-10-10 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6918 to look at the new patch set (#7). Change subject: WIP: KUDU-1366: allow building against jemalloc .. WIP:

[kudu-CR] KUDU-2184. Avoid allocations larger than 1MB

2017-10-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8239 ) Change subject: KUDU-2184. Avoid allocations larger than 1MB .. Patch Set 3: > Patch Set 3: Verified-1 > > Build Failed > > http://jenkin